markparz (Thu, 02 Feb 2017 23:31:11 GMT):
Weekly review of outstanding PRs

nickgaski (Thu, 02 Feb 2017 23:46:58 GMT):
Has joined the channel.

C0rWin (Fri, 03 Feb 2017 00:12:09 GMT):
Has joined the channel.

salmanbaset (Fri, 03 Feb 2017 01:21:06 GMT):
Has joined the channel.

yacovm (Fri, 03 Feb 2017 01:42:53 GMT):
Has joined the channel.

Ratnakar (Fri, 03 Feb 2017 02:51:45 GMT):
Has joined the channel.

SriramaSharma (Fri, 03 Feb 2017 03:22:12 GMT):
Has joined the channel.

grapebaba (Fri, 03 Feb 2017 06:27:07 GMT):
Has joined the channel.

cbf (Fri, 03 Feb 2017 06:32:00 GMT):
Has joined the channel.

JonathanLevi (Fri, 03 Feb 2017 07:48:33 GMT):
Has joined the channel.

cca88 (Fri, 03 Feb 2017 08:21:56 GMT):
Has joined the channel.

dave.enyeart (Fri, 03 Feb 2017 11:21:34 GMT):
Has joined the channel.

greg.haskins (Fri, 03 Feb 2017 12:17:06 GMT):
Has joined the channel.

greg.haskins (Fri, 03 Feb 2017 12:17:40 GMT):
these two need some eyes: https://gerrit.hyperledger.org/r/#/c/4943/ https://gerrit.hyperledger.org/r/#/c/4941/

greg.haskins (Fri, 03 Feb 2017 12:18:19 GMT):
they are blocking the merge of https://gerrit.hyperledger.org/r/#/c/5427/ which is needed to complete the FAB-678 task for alpha

silliman (Fri, 03 Feb 2017 13:57:29 GMT):
Has joined the channel.

gormand (Fri, 03 Feb 2017 14:43:28 GMT):
Has joined the channel.

danacr (Fri, 03 Feb 2017 15:23:44 GMT):
Has joined the channel.

kostas (Fri, 03 Feb 2017 15:41:45 GMT):
Has joined the channel.

jyellick (Fri, 03 Feb 2017 16:06:47 GMT):
Has joined the channel.

muralisr (Fri, 03 Feb 2017 16:31:47 GMT):
Has joined the channel.

muralisr (Fri, 03 Feb 2017 16:32:30 GMT):
@greg.haskins looking at https://gerrit.hyperledger.org/r/#/c/4943

smithbk (Fri, 03 Feb 2017 16:36:49 GMT):
Has joined the channel.

jimthematrix (Fri, 03 Feb 2017 19:29:06 GMT):
Has joined the channel.

jimthematrix (Fri, 03 Feb 2017 19:30:15 GMT):
http://gerrit.hyperledger.org/r/5513 trivial change to remove 2sec pause in end to end test due to FAB-1862

jimthematrix (Fri, 03 Feb 2017 19:30:15 GMT):
http://gerrit.hyperledger.org/r/5513 trivial change to remove 2sec pause in end to end test due to FAB-1862 (which has been fixed since)

jimthematrix (Fri, 03 Feb 2017 19:31:02 GMT):
https://gerrit.hyperledger.org/r/#/c/5117/ for the alpha branch, only changes test cases

karkal (Fri, 03 Feb 2017 19:55:23 GMT):
Has joined the channel.

jimthematrix (Fri, 03 Feb 2017 20:22:32 GMT):
http://gerrit.hyperledger.org/r/5515 only code format and style changes, thanks

jimthematrix (Fri, 03 Feb 2017 21:18:48 GMT):
https://gerrit.hyperledger.org/r/#/c/5519/ update to end to end test and move event listener registration before sending transactions

manu (Fri, 03 Feb 2017 22:06:31 GMT):
Has joined the channel.

jiangyaoguo (Sat, 04 Feb 2017 01:32:58 GMT):
Has joined the channel.

genggjh (Sat, 04 Feb 2017 03:46:21 GMT):
Has joined the channel.

sheehan (Sat, 04 Feb 2017 14:44:49 GMT):
Has joined the channel.

greg.haskins (Sat, 04 Feb 2017 16:15:23 GMT):
@cbf Could you review the comments to your question and weigh in with approval/disapproval? https://gerrit.hyperledger.org/r/#/c/4941/

smithbk (Sat, 04 Feb 2017 17:24:18 GMT):
Pls review the following. The 1st is just vendoring

smithbk (Sat, 04 Feb 2017 17:24:22 GMT):
https://gerrit.hyperledger.org/r/#/c/5533/ https://gerrit.hyperledger.org/r/#/c/5535

smithbk (Sat, 04 Feb 2017 17:24:59 GMT):
These are for fabric-ca and are the beginning of rebasing the CLI on cobra/viper

smithbk (Sat, 04 Feb 2017 17:25:19 GMT):
rather than cfssl's CLI package

yacovm (Sat, 04 Feb 2017 19:33:07 GMT):
https://gerrit.hyperledger.org/r/#/c/5199/ `Add MSP-ID to anchor peers` this blocks https://gerrit.hyperledger.org/r/#/c/5123/ (`Get ID for local MSP from core.yaml`) from being merged

yacovm (Sat, 04 Feb 2017 19:33:07 GMT):
https://gerrit.hyperledger.org/r/#/c/5199/ `Add MSP-ID to anchor peers` this blocks https://gerrit.hyperledger.org/r/#/c/5123/ ( `Get ID for local MSP from core.yaml` ) from being merged

cbf (Sat, 04 Feb 2017 21:29:43 GMT):
@greg.haskins merged thanks

cbf (Sat, 04 Feb 2017 21:45:07 GMT):
@greg.haskins there were a couple of FIXMEs in https://gerrit.hyperledger.org/r/#/c/4943/ could you please add JIRAs to track those?

dave.enyeart (Sun, 05 Feb 2017 01:31:20 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/5461 https://gerrit.hyperledger.org/r/#/c/5503

greg.haskins (Sun, 05 Feb 2017 03:09:42 GMT):
@cbf: https://jira.hyperledger.org/browse/FAB-2051

greg.haskins (Sun, 05 Feb 2017 03:10:06 GMT):
https://jira.hyperledger.org/browse/FAB-2049

greg.haskins (Sun, 05 Feb 2017 03:10:32 GMT):
also, added notes on remaining tasks for 678: https://jira.hyperledger.org/browse/FAB-678

cbf (Sun, 05 Feb 2017 04:29:20 GMT):
danke!

yacovm (Sun, 05 Feb 2017 10:00:01 GMT):
Integrate gossip logging with `flogging`: https://gerrit.hyperledger.org/r/#/c/2865/ needs 1 more +2

yacovm (Sun, 05 Feb 2017 10:00:01 GMT):
Integrate gossip logging with `flogging` (peer logging): https://gerrit.hyperledger.org/r/#/c/2865/ needs 1 more +2

yacovm (Sun, 05 Feb 2017 17:51:20 GMT):
A few very simple CRs: https://gerrit.hyperledger.org/r/#/c/4939/ - Add panic when failed to sign with local MSP https://gerrit.hyperledger.org/r/#/c/5545/ - Endorsement documentation malformed sentence fix https://gerrit.hyperledger.org/r/#/c/5543/ - Move gossip proto files under protos/

smithbk (Sun, 05 Feb 2017 22:43:12 GMT):
The following fabric-ca are ready for review, related to rebasing CLI on cobra/viper rather than cfssl's CLI:

smithbk (Sun, 05 Feb 2017 22:43:15 GMT):
https://gerrit.hyperledger.org/r/#/c/5535 https://gerrit.hyperledger.org/r/#/c/5551

Honglei (Sun, 05 Feb 2017 23:54:14 GMT):
Has joined the channel.

jimthematrix (Mon, 06 Feb 2017 04:04:19 GMT):
https://gerrit.hyperledger.org/r/#/c/5117/ updates to test case only, has been sitting there for too long, can someone review and merge

jimthematrix (Mon, 06 Feb 2017 04:04:53 GMT):
https://gerrit.hyperledger.org/r/#/c/5127/ doc updates only, need one more +2

jimthematrix (Mon, 06 Feb 2017 04:21:54 GMT):
https://gerrit.hyperledger.org/r/#/c/5515/ review comments addressed and rebased

gennadyl (Mon, 06 Feb 2017 08:19:42 GMT):
Has joined the channel.

david.peyronnin (Mon, 06 Feb 2017 09:52:54 GMT):
Has joined the channel.

aarenw (Mon, 06 Feb 2017 10:03:17 GMT):
Has joined the channel.

jimthematrix (Mon, 06 Feb 2017 13:15:43 GMT):
can I get reviews on the 3 PRs I listed above? @cbf @gari @yacovm @JonathanLevi

greg.haskins (Mon, 06 Feb 2017 14:04:38 GMT):
@muralisr trivial one: https://gerrit.hyperledger.org/r/#/c/5547/

cbf (Mon, 06 Feb 2017 14:33:19 GMT):
@jimthematrix@gmail.com one of them needs another +2

muralisr (Mon, 06 Feb 2017 14:48:13 GMT):
looking @greg.haskins

greg.haskins (Mon, 06 Feb 2017 14:48:31 GMT):
@muralisr ?

greg.haskins (Mon, 06 Feb 2017 14:48:35 GMT):
which PR?

muralisr (Mon, 06 Feb 2017 14:48:46 GMT):
https://gerrit.hyperledger.org/r/#/c/5547

muralisr (Mon, 06 Feb 2017 14:48:51 GMT):
is that right ?

greg.haskins (Mon, 06 Feb 2017 14:49:15 GMT):
ah, hah, i completely misunderstood you

greg.haskins (Mon, 06 Feb 2017 14:49:24 GMT):
I read above as "looking at ghaskins"

greg.haskins (Mon, 06 Feb 2017 14:49:30 GMT):
like, I had an action item

greg.haskins (Mon, 06 Feb 2017 14:49:44 GMT):
yes, that is the one I would love your feedback on

greg.haskins (Mon, 06 Feb 2017 14:50:59 GMT):
@muralisr its companion if you feel so inclined: https://gerrit.hyperledger.org/r/#/c/5579/

greg.haskins (Mon, 06 Feb 2017 14:51:28 GMT):
5579 isnt perfect...the code still refers to "hashing" etc, but at least its all in the right place now

greg.haskins (Mon, 06 Feb 2017 14:52:04 GMT):
java needs a similar refactoring, as there is a similar pattern to that code (hashing where we dont need it, java-isms in common code, etc

greg.haskins (Mon, 06 Feb 2017 14:52:17 GMT):
but I havent got to that task yet

skarim (Mon, 06 Feb 2017 14:53:48 GMT):
Has joined the channel.

jimthematrix (Mon, 06 Feb 2017 15:27:57 GMT):
https://gerrit.hyperledger.org/r/#/c/5519/ has been rebased on latest master, @cbf @mastersingh24 @pmullaney

pmullaney (Mon, 06 Feb 2017 15:27:57 GMT):
Has joined the channel.

mastersingh24 (Mon, 06 Feb 2017 15:27:57 GMT):
Has joined the channel.

mastersingh24 (Mon, 06 Feb 2017 15:29:21 GMT):
done

muralisr (Mon, 06 Feb 2017 15:33:29 GMT):
@greg.haskins what do you think of merging https://gerrit.hyperledger.org/r/#/c/5579 post alpha ?

muralisr (Mon, 06 Feb 2017 15:34:23 GMT):
(but https://gerrit.hyperledger.org/r/#/c/5547/ I think is isolated and completes and belongs in alpha I think)

muralisr (Mon, 06 Feb 2017 15:34:23 GMT):
(but https://gerrit.hyperledger.org/r/#/c/5547/ I think is isolated and completes and belongs in alpha)

greg.haskins (Mon, 06 Feb 2017 15:36:19 GMT):
@muralisr works for me

greg.haskins (Mon, 06 Feb 2017 15:36:23 GMT):
theres no urgency

greg.haskins (Mon, 06 Feb 2017 15:37:04 GMT):
(other than the assault on my eyes every time I am in there ;)

manu (Mon, 06 Feb 2017 15:39:24 GMT):
https://gerrit.hyperledger.org/r/#/c/5505/ adds a new dependency required for [FAB-2005], reviews would be welcome

jimthematrix (Mon, 06 Feb 2017 15:54:48 GMT):
@greg.haskins is there more work to be done to enable the SDK to not send Dockerfile in the deploy transaction? I saw https://gerrit.hyperledger.org/r/#/c/4943/ was merged and thought it's all that's needed in the backend

greg.haskins (Mon, 06 Feb 2017 15:55:20 GMT):
all the support is there, trying to figure out whats happening but I suspect the system is simply being more strict about the chaincodespec being passed in

greg.haskins (Mon, 06 Feb 2017 15:55:44 GMT):
it would have been lax about validating certain aspects such as the path in the old setup since it had no reason to look

greg.haskins (Mon, 06 Feb 2017 15:55:57 GMT):
still trying to dicipher

jimthematrix (Mon, 06 Feb 2017 15:57:43 GMT):
ok thanks

jimthematrix (Mon, 06 Feb 2017 16:02:17 GMT):
just submitted http://gerrit.hyperledger.org/r/5599 related to this, @greg.haskins @cbf @mastersingh24

jimthematrix (Mon, 06 Feb 2017 18:39:25 GMT):
http://gerrit.hyperledger.org/r/5605 please

jimthematrix (Mon, 06 Feb 2017 18:46:04 GMT):
and http://gerrit.hyperledger.org/r/5607 same fix for the v1.0-alpha branch

jimthematrix (Mon, 06 Feb 2017 18:50:56 GMT):
https://gerrit.hyperledger.org/r/#/c/5609/ trivial fix for istanbul line coverage tool config

mastersingh24 (Mon, 06 Feb 2017 18:51:38 GMT):
@jimthematrix - at this point, I think we should just do things on the master branch

jimthematrix (Mon, 06 Feb 2017 18:53:40 GMT):
for sure only critical fixes for the alpha branch, this one would prevent npm "production" installs to fail to run. there's an easy workaround so you could argue 5607 is not needed for the alpha

vpaprots (Mon, 06 Feb 2017 19:01:28 GMT):
Has joined the channel.

weeds (Mon, 06 Feb 2017 20:26:29 GMT):
Has joined the channel.

ashutosh_kumar (Mon, 06 Feb 2017 21:11:18 GMT):
Has joined the channel.

ashutosh_kumar (Mon, 06 Feb 2017 21:15:15 GMT):
Hi folks. Are you not doing any merge till alpha is out ? Please forgive my ignorance.

ashutosh_kumar (Mon, 06 Feb 2017 21:15:15 GMT):
Hi folks. Are we not doing any merge till alpha is out ? Please forgive my ignorance.

ashutosh_kumar (Mon, 06 Feb 2017 21:16:25 GMT):
The reason , I asked is : I have 4 change sets that needs review and merge.

ashutosh_kumar (Mon, 06 Feb 2017 21:16:42 GMT):
3 of them are sitting there for 3-4 weeks now.

mastersingh24 (Mon, 06 Feb 2017 21:16:46 GMT):
we are working to figure out what we need for the alpha

ashutosh_kumar (Mon, 06 Feb 2017 21:16:58 GMT):
ok.

mastersingh24 (Mon, 06 Feb 2017 21:17:06 GMT):
to be fair, some needed to be rebased at one point ;)

ashutosh_kumar (Mon, 06 Feb 2017 21:18:24 GMT):
ok. that make sense.

yury (Tue, 07 Feb 2017 14:01:36 GMT):
Has joined the channel.

ruslan.kryukov (Tue, 07 Feb 2017 14:01:59 GMT):
Has joined the channel.

ruslan.kryukov (Tue, 07 Feb 2017 14:03:05 GMT):
hello guys, please review my PR http://gerrit.hyperledger.org/r/5639 https://jira.hyperledger.org/browse/FAB-2086 thanks

ruslan.kryukov (Tue, 07 Feb 2017 14:03:05 GMT):
hello guys, please review my PR http://gerrit.hyperledger.org/r/5641 https://jira.hyperledger.org/browse/FAB-2086 thanks

jimthematrix (Tue, 07 Feb 2017 14:48:00 GMT):
https://gerrit.hyperledger.org/r/#/c/5621/ is ready for review, tested with latest fabric pulled last night, critical fix for FAB-2060 and needed for alpha. @greg.haskins @cbf @mastersingh24

ardashev120101 (Tue, 07 Feb 2017 14:59:54 GMT):
Has joined the channel.

rameshthoomu (Tue, 07 Feb 2017 15:11:42 GMT):
Has joined the channel.

adc (Tue, 07 Feb 2017 15:17:51 GMT):
Has joined the channel.

mihaig (Tue, 07 Feb 2017 15:19:18 GMT):
Has joined the channel.

harrijk (Tue, 07 Feb 2017 15:36:33 GMT):
Has joined the channel.

jimthematrix (Tue, 07 Feb 2017 16:33:06 GMT):
https://gerrit.hyperledger.org/r/#/c/5621/ has got a +2 and I'm tempted to merge it myself ;-) @cbf I addressed your suggestion

cbf (Tue, 07 Feb 2017 16:38:28 GMT):
merged thanks!

jimthematrix (Tue, 07 Feb 2017 16:44:39 GMT):
thanks Chris!

smithbk (Tue, 07 Feb 2017 18:00:49 GMT):
https://gerrit.hyperledger.org/r/#/c/5535/ fabric-ca-server command plumbing with cobra/viper .... is ready for re-review ... thanks

mastersingh24 (Tue, 07 Feb 2017 18:55:45 GMT):
@cbf @JonathanLevi take a look at https://gerrit.hyperledger.org/r/#/c/5601/ - not perfect but will help with our SDKs being able to retrieve tcerts.

JonathanLevi (Tue, 07 Feb 2017 19:00:58 GMT):
@mastersingh24: Approved (including the removal/commenting out the RSA part). Can't merge due to dependencies.

JonathanLevi (Tue, 07 Feb 2017 19:01:22 GMT):
We can either split them or prioritize the other ones @ashutosh_kumar, WDYT ?

rjones (Tue, 07 Feb 2017 19:06:02 GMT):
Has joined the channel.

rjones (Tue, 07 Feb 2017 19:06:13 GMT):
doc update https://gerrit.hyperledger.org/r/#/c/5663/2

mastersingh24 (Tue, 07 Feb 2017 19:11:12 GMT):
folks - a nice set of updates from @jyellick - https://gerrit.hyperledger.org/r/#/q/owner:%22Jason+Yellick%22+status:open

yacovm (Tue, 07 Feb 2017 19:27:37 GMT):
2 easy changes, related to gossip: https://gerrit.hyperledger.org/r/#/c/5635/ Just a protobuf fix, nothing more https://gerrit.hyperledger.org/r/#/c/5637/ just a protobuf decoupling

ashutosh_kumar (Tue, 07 Feb 2017 19:54:19 GMT):
@JonathanLevi , you can merge 5601 as it is. I do not think , there is any dependency.

rjones (Tue, 07 Feb 2017 19:54:24 GMT):
@cbf: I updated https://gerrit.hyperledger.org/r/#/c/5615/6 but @kostas has comments on patchset 6

rjones (Tue, 07 Feb 2017 19:54:24 GMT):
@cbf: I updated https://gerrit.hyperledger.org/r/#/c/5615/6 but @kostas has comments on patchset 5

cbf (Tue, 07 Feb 2017 22:03:27 GMT):
https://gerrit.hyperledger.org/r/#/c/5615/ could use some love from one of those of you who has already reviewed... I've addressed @muralisr @kostas @mastersingh24 and @nickgaski comments

jimthematrix (Tue, 07 Feb 2017 22:12:43 GMT):
merged 5615

jimthematrix (Tue, 07 Feb 2017 22:13:21 GMT):
https://gerrit.hyperledger.org/r/#/c/5681/ for an intermediate step toward completing the create/join channel work (msp part)

yacovm (Tue, 07 Feb 2017 23:17:49 GMT):
https://gerrit.hyperledger.org/r/#/c/5637/ just need someone to hit the submit button

xixuejia (Wed, 08 Feb 2017 01:40:46 GMT):
Has joined the channel.

grapebaba (Wed, 08 Feb 2017 02:46:06 GMT):
@dave.enyeart @manish-sethi https://gerrit.hyperledger.org/r/#/c/4749/

manish-sethi (Wed, 08 Feb 2017 02:46:06 GMT):
Has joined the channel.

jimthematrix (Wed, 08 Feb 2017 04:28:14 GMT):
@grapebaba 4749 verification build failed but it seems to be a CI server problem, just triggered a reverify

jimthematrix (Wed, 08 Feb 2017 04:28:40 GMT):
https://gerrit.hyperledger.org/r/#/c/5681 for an intermediate step toward completing the create/join channel work (msp part), @cbf @mastersingh24 @adc @JonathanLevi

grapebaba (Wed, 08 Feb 2017 04:51:40 GMT):
thanks, jim

ruslan.kryukov (Wed, 08 Feb 2017 07:43:04 GMT):
please review this https://gerrit.hyperledger.org/r/#/c/5643/ (with related changes)

yacovm (Wed, 08 Feb 2017 08:05:13 GMT):
Will do when i get to the office

yacovm (Wed, 08 Feb 2017 08:05:29 GMT):
Cant code review and drive

yacovm (Wed, 08 Feb 2017 11:12:11 GMT):
This patch connects between gossip and `peer/core.yaml` https://gerrit.hyperledger.org/r/#/c/5627/ already got 1 +2.

Maria (Wed, 08 Feb 2017 12:51:51 GMT):
Has joined the channel.

jimthematrix (Wed, 08 Feb 2017 12:53:10 GMT):
https://gerrit.hyperledger.org/r/#/c/5681/ needs review and merge for progress towards creation channel and join channel

gennadyl (Wed, 08 Feb 2017 13:49:55 GMT):
Can somebody look into https://gerrit.hyperledger.org/r/#/c/5711/ ? just some commented out piece of code removed

mastersingh24 (Wed, 08 Feb 2017 14:36:29 GMT):
waiting for verify - but Yacov and I did +2

haidong (Wed, 08 Feb 2017 14:52:57 GMT):
Has joined the channel.

gennadyl (Wed, 08 Feb 2017 15:22:24 GMT):
Thanks

jimthematrix (Wed, 08 Feb 2017 19:31:27 GMT):
i'll sound like a broken record until someone takes a look at this ;-) https://gerrit.hyperledger.org/r/#/c/5681/

mastersingh24 (Wed, 08 Feb 2017 19:32:24 GMT):
it's terrible ;)

jimthematrix (Wed, 08 Feb 2017 19:41:07 GMT):
ha!

jimthematrix (Wed, 08 Feb 2017 19:41:17 GMT):
but it worked ;-) thanks Gari

ashutosh_kumar (Wed, 08 Feb 2017 19:53:58 GMT):
https://gerrit.hyperledger.org/r/#/c/5161/ has gone through lots of sufferings and needs love badly.

jimthematrix (Wed, 08 Feb 2017 20:29:55 GMT):
http://gerrit.hyperledger.org/r/5735 - straightforward change to remove unnecessary constructor param from the ecdsa key impl

harrijk (Thu, 09 Feb 2017 04:08:29 GMT):
@cbf please review my remarks for https://gerrit.hyperledger.org/r/#/c/5647. This change will not work for z or p platforms. Thanks.

baohua (Thu, 09 Feb 2017 06:02:48 GMT):
Has joined the channel.

shibo.lin (Thu, 09 Feb 2017 06:55:31 GMT):
Has joined the channel.

shibo.lin (Thu, 09 Feb 2017 06:58:04 GMT):
Has left the channel.

baohua (Thu, 09 Feb 2017 07:13:11 GMT):
Pls help review https://gerrit.hyperledger.org/r/#/c/5701/, which is a quick change on cfg path. Thanks!

gennadyl (Thu, 09 Feb 2017 09:29:31 GMT):
Can somebody review https://gerrit.hyperledger.org/r/#/c/5189/ ? This is next step in leader election journey.

mastersingh24 (Thu, 09 Feb 2017 11:57:41 GMT):
@gennadyl - for a nominal fee I'll be happy to review ;)

gennadyl (Thu, 09 Feb 2017 12:51:31 GMT):
:)

JonathanLevi (Thu, 09 Feb 2017 12:57:57 GMT):
Now that's Leadership! I'll *follow* with only 80% of what @mastersingh24 charges above.

JonathanLevi (Thu, 09 Feb 2017 12:58:19 GMT):
(BTW: taking a look while it's still building, I note)

mastersingh24 (Thu, 09 Feb 2017 13:32:52 GMT):
times are tough - gotta make $$$ somehow

mastersingh24 (Thu, 09 Feb 2017 13:33:11 GMT):
once Fabric is done, you'll be able pay me on the blockchain ;)

smithbk (Thu, 09 Feb 2017 13:42:39 GMT):
https://gerrit.hyperledger.org/r/#/c/5535 needs another reviewer ... thanks

JonathanLevi (Thu, 09 Feb 2017 13:57:32 GMT):
@smithbk: merged. BTW: if people want to pay us prior to the alpha release, please do *not* pay in BTC @ 1Ez69SnzzmePmZX3WpEzMKTrcBF2gpNQ55 ;-)

dave.enyeart (Thu, 09 Feb 2017 14:16:43 GMT):
We've got a backlog of ledger changes ready for review:

dave.enyeart (Thu, 09 Feb 2017 14:16:46 GMT):
https://gerrit.hyperledger.org/r/#/c/5725/ https://gerrit.hyperledger.org/r/#/c/5731/ https://gerrit.hyperledger.org/r/#/c/5709/ https://gerrit.hyperledger.org/r/#/c/5685/ https://gerrit.hyperledger.org/r/#/c/5741/ https://gerrit.hyperledger.org/r/#/c/5745/ https://gerrit.hyperledger.org/r/#/c/5729/ https://gerrit.hyperledger.org/r/#/c/5013/

dave.enyeart (Thu, 09 Feb 2017 14:24:59 GMT):
@chris.elder @manish-sethi I've included yours in the list above

chris.elder (Thu, 09 Feb 2017 14:24:59 GMT):
Has joined the channel.

smithbk (Thu, 09 Feb 2017 16:04:56 GMT):
https://gerrit.hyperledger.org/r/#/c/5551/ has been rebased and ready for review ... thanks

smithbk (Thu, 09 Feb 2017 16:05:19 GMT):
This is for fabric-ca

yacovm (Thu, 09 Feb 2017 17:21:18 GMT):
https://jenkins.hyperledger.org/job/fabric-verify-x86_64/6488/console This is the 1st commit in [FAB-2007] - An ability to expose different endpoints to peers within the organization and outside of the organization.

yacovm (Thu, 09 Feb 2017 17:21:18 GMT):
https://gerrit.hyperledger.org/r/#/c/5787/ This is the 1st commit in [FAB-2007] - An ability to expose different endpoints to peers within the organization and outside of the organization.

jimthematrix (Thu, 09 Feb 2017 19:32:43 GMT):
rather simple change to allow BCCSP (aka CryptoSuite in sdk lingo) instances to be created in different configs (hsm or not, key len, algo) easily: https://gerrit.hyperledger.org/r/#/c/5789/

MikeMayori (Thu, 09 Feb 2017 19:48:38 GMT):
Has joined the channel.

rjones (Thu, 09 Feb 2017 21:06:02 GMT):
merge this please: https://gerrit.hyperledger.org/r/#/c/5669/

mastersingh24 (Thu, 09 Feb 2017 21:06:07 GMT):
no

yacovm (Thu, 09 Feb 2017 23:11:39 GMT):
Some CRs, in descending order of complexity: https://gerrit.hyperledger.org/r/#/c/5787/ Makes gossip support intra-organizational endpoints and inter-organizational endpoints (the 1st change set in the series) https://gerrit.hyperledger.org/r/#/c/5809/ Makes gossip re-connect to bootstrap peers if they're not available https://gerrit.hyperledger.org/r/#/c/5811/ *Not a gossip change set, a really simple one* - Makes the `peer` cli commands not puke MSP logs when run by setting the relevant log invocations from Info to Debug.

C0rWin (Thu, 09 Feb 2017 23:49:06 GMT):
and another one: https://gerrit.hyperledger.org/r/#/c/3793/ :)

manish-sethi (Fri, 10 Feb 2017 05:41:53 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=tQkzgYkae3TDNXKyB) @dave.enyeart Can you add one more - https://gerrit.hyperledger.org/r/#/c/5707/ (Update document with changes in transaction behavior)

dave.enyeart (Fri, 10 Feb 2017 05:44:02 GMT):
done. simply posting the link to this channel should be sufficient

nickgaski (Fri, 10 Feb 2017 16:04:07 GMT):
https://gerrit.hyperledger.org/r/#/c/5847/ - this is a fix to the path of the node code in GettingStarted

muralisr (Fri, 10 Feb 2017 16:51:10 GMT):
two easy ones please https://gerrit.hyperledger.org/r/#/c/5841/ and https://gerrit.hyperledger.org/r/#/c/5843/

muralisr (Fri, 10 Feb 2017 16:51:48 GMT):
the later is a bug fix for a panic

dave.enyeart (Fri, 10 Feb 2017 18:08:57 GMT):
https://gerrit.hyperledger.org/r/#/c/5815/ has two +2. Please merge :)

jyellick (Fri, 10 Feb 2017 18:19:23 GMT):
https://gerrit.hyperledger.org/r/#/c/5507/ <- it's a simple one, but seems to need rebasing after every merge, if I could get another +2 ( @yacovm and @greg.haskins have +2-ed in the past)

nickgaski (Fri, 10 Feb 2017 18:23:29 GMT):
https://gerrit.hyperledger.org/r/#/c/5847 - pretty please :v::v:

nickgaski (Fri, 10 Feb 2017 18:24:09 GMT):
gettingstarted instructions are wrong until this guy gets in

yacovm (Fri, 10 Feb 2017 18:48:13 GMT):
In the past and in the present @jyellick

mastersingh24 (Fri, 10 Feb 2017 19:46:53 GMT):
@dave.enyeart - 5815 needs a rebase now :(

jyellick (Fri, 10 Feb 2017 19:51:11 GMT):
https://gerrit.hyperledger.org/r/#/c/5667/ https://gerrit.hyperledger.org/r/#/c/5675/ ^ Each has 1 +2, are others built on top which need rebasing, would prefer to get them merged before rebase to avoid losing existing +2

jyellick (Fri, 10 Feb 2017 20:19:39 GMT):
https://gerrit.hyperledger.org/r/#/c/5509/ <- and additional proto style fixes with one +2

JonathanLevi (Fri, 10 Feb 2017 21:16:40 GMT):
Hi, just a quick one: Any suggestion(s) regarding the environment var naming in fabric-ca? Opened this after a nice CR by @baohua, and I thought we should run it by others as well: https://jira.hyperledger.org/browse/FAB-2188 [I think that FABRIC_CA_.... is a better prefix, but I didn't want to short-circuit it. Please chime in should you have an objection...]

JonathanLevi (Fri, 10 Feb 2017 21:26:03 GMT):
@cbf, @mastersingh24, @smithbk ^^^

smithbk (Fri, 10 Feb 2017 21:43:17 GMT):
The reason I made FABRIC_CA_CLIENT and FABRIC_CA_SERVER different was to avoid any potential conflict, just to be safe. In reality, I'm not aware of any other than home directory, which we could still make FABRIC_CA_CLIENT_HOME and FABRIC_CA_SERVER_HOME

smithbk (Fri, 10 Feb 2017 21:44:23 GMT):
while all others would just be FABRIC_CA prefix

baohua (Sat, 11 Feb 2017 00:19:49 GMT):
sure, and also suggest to consider if we need to keep the same style between fabric-peer, fabric-orderer and fabric-ca. currently they have names of `PEER_CFG_PATH`, `ORDERER_CFG_PATH` and `FABRIC_CA_HOME` as the default configuration paths.

baohua (Sat, 11 Feb 2017 00:40:22 GMT):
Make update on https://jira.hyperledger.org/browse/FAB-2118, welcome for comments. I guess better to consider this change ASAP, as the cfg variables are important for all bootup, test and usage things.

baohua (Sat, 11 Feb 2017 00:40:44 GMT):
Thanks!

dave.enyeart (Sat, 11 Feb 2017 01:20:39 GMT):
@binhn @muralisr @mastersingh24 Rebased and ready to go again: https://gerrit.hyperledger.org/r/#/c/5815/

dave.enyeart (Sat, 11 Feb 2017 01:20:39 GMT):
@binhn @muralisr @mastersingh24 Rebased and ready to go again (api name changes): https://gerrit.hyperledger.org/r/#/c/5815/

binhn (Sat, 11 Feb 2017 01:20:39 GMT):
Has joined the channel.

dave.enyeart (Sat, 11 Feb 2017 01:22:31 GMT):
Also these other ledger changes have been waiting for +2 for a while: https://gerrit.hyperledger.org/r/5741 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013

dave.enyeart (Sat, 11 Feb 2017 01:22:31 GMT):
Also these other ledger changes have been waiting for +2 for a while: https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5885 https://gerrit.hyperledger.org/r/5775

smithbk (Sat, 11 Feb 2017 03:26:26 GMT):
Pls review https://gerrit.hyperledger.org/r/#/c/5631/ for fabric-ca-server start command

smithbk (Sat, 11 Feb 2017 03:27:38 GMT):
And https://gerrit.hyperledger.org/r/#/c/5851/ which is just a doc update

binhn (Sat, 11 Feb 2017 14:00:31 GMT):
a lot of these cr's failed ci with the error below, which I noticed after having merged cr's on proto changes @jyellick ``` 13:22:29 [33munit-tests_1 |[0m [31m2017-02-11 13:19:43.382 UTC [chaincode] ExecuteWithErrorFilter -> ERRO 04b[0m ExecuteWithErrorFilter esender error: Failed to unmarshal response for (5985ebea-b283-49d8-aa5a-02bca4fd432e): proto: can't skip unknown wire type 6 for peer.Response ```

muralisr (Sat, 11 Feb 2017 14:51:49 GMT):
@binhn I see it too after rebasing...looking

mastersingh24 (Sat, 11 Feb 2017 15:13:57 GMT):
it is really disappointing that you cannot simply run go test half the time

mastersingh24 (Sat, 11 Feb 2017 15:14:03 GMT):
too much other crap needed

mastersingh24 (Sat, 11 Feb 2017 15:30:50 GMT):
so I pulled down 5815 and ran TestGetEvent locally and it passed

mastersingh24 (Sat, 11 Feb 2017 15:31:03 GMT):
now trying `make unit-tests` for the core/chaincode pacakge

mastersingh24 (Sat, 11 Feb 2017 15:31:03 GMT):
now trying `make unit-tests` for the core/chaincode package

muralisr (Sat, 11 Feb 2017 16:07:51 GMT):
I did a make protos and ran tests

mastersingh24 (Sat, 11 Feb 2017 16:08:08 GMT):
I simply did a checkout and ran the unit tests

mastersingh24 (Sat, 11 Feb 2017 16:08:10 GMT):
it works

muralisr (Sat, 11 Feb 2017 16:08:14 GMT):
ok

mastersingh24 (Sat, 11 Feb 2017 16:08:16 GMT):
make protos sucks

mastersingh24 (Sat, 11 Feb 2017 16:08:22 GMT):
;)

muralisr (Sat, 11 Feb 2017 16:08:46 GMT):
of course

mastersingh24 (Sat, 11 Feb 2017 16:08:56 GMT):
I only ran the tests for the core/chaincode package but they all passed

muralisr (Sat, 11 Feb 2017 16:09:02 GMT):
just wanted to make sure git didn't show proto changes

muralisr (Sat, 11 Feb 2017 16:09:13 GMT):
and thankfully it didn;t

mastersingh24 (Sat, 11 Feb 2017 16:09:17 GMT):
on both master and just checking out 5815

mastersingh24 (Sat, 11 Feb 2017 16:15:26 GMT):
hmm - so what could be causing the failures in CI?

mastersingh24 (Sat, 11 Feb 2017 16:18:48 GMT):
@muralisr - pulling down 5881 and trying locally as well

muralisr (Sat, 11 Feb 2017 16:23:17 GMT):
right I was wondering myself

muralisr (Sat, 11 Feb 2017 16:23:52 GMT):
I rebased and tried locally and it worked ...

muralisr (Sat, 11 Feb 2017 16:24:39 GMT):
(this may or may not be relevant... but when cleaned and did make peer it failed. after doing make protos and retrying, it worked)

muralisr (Sat, 11 Feb 2017 16:25:42 GMT):
but the make protos did not lead to changed ".pb.go" files .. so don't know what difference that made

muralisr (Sat, 11 Feb 2017 16:26:01 GMT):
will keep looking @mastersingh24

muralisr (Sat, 11 Feb 2017 16:38:07 GMT):
it is interesting that a different CI than what @binhn reported fails in a different place with the same signature

muralisr (Sat, 11 Feb 2017 16:38:15 GMT):
```14:34:31 [33munit-tests_1 |[0m removing dir = /tmp/hyperledger/test/tmpdb/ledgersData 14:34:31 [33munit-tests_1 |[0m --- FAIL: TestChaincodeQueryChaincodeUsingInvoke (6.93s) 14:34:31 [33munit-tests_1 |[0m exectransaction_test.go:1062: Error initializing chaincode example02(Error deploying chaincode: Failed to unmarshal response for (09205c0c-7b7a-4a66-8a0a-a155481cc377): proto: can't skip unknown wire type 6 for peer.Response)```

muralisr (Sat, 11 Feb 2017 17:19:37 GMT):
@binhn @mastersingh24 I see one problem in a premature unmarshalling of pb.Response ... I think it masked a original problem for failures (possibly timeout). As unmarshall can pass if the bits are in the right place we probably didn't see it sooner.

muralisr (Sat, 11 Feb 2017 17:20:30 GMT):
This will also explain why its passing locally (we did not face timeouts and unmarshalled good responses)

muralisr (Sat, 11 Feb 2017 17:20:33 GMT):
working on a fix

muralisr (Sat, 11 Feb 2017 17:27:43 GMT):
opened https://jira.hyperledger.org/browse/FAB-2194 to track this

yacovm (Sat, 11 Feb 2017 19:25:47 GMT):
https://gerrit.hyperledger.org/r/#/c/5809/ Make gossip re-connect to bootstrap peers upon startup

mastersingh24 (Sat, 11 Feb 2017 19:57:27 GMT):
@muralisr interesting that https://gerrit.hyperledger.org/r/#/c/5815/ passes now

muralisr (Sat, 11 Feb 2017 19:58:15 GMT):
@mastersingh24 indeed

muralisr (Sat, 11 Feb 2017 19:58:24 GMT):
there's something really fishy with all this

jyellick (Sat, 11 Feb 2017 20:50:52 GMT):
87*

jyellick (Sat, 11 Feb 2017 21:41:51 GMT):
https://gerrit.hyperledger.org/r/#/q/owner:jyellick+status:open+label:Verified%252B1

mastersingh24 (Sat, 11 Feb 2017 22:30:16 GMT):
cool @jyellick - finally all verified again. I had previously reviewed them but was waiting for CI (again :( )

dave.enyeart (Sat, 11 Feb 2017 22:46:42 GMT):
https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5885 https://gerrit.hyperledger.org/r/5775

dave.enyeart (Sat, 11 Feb 2017 22:46:42 GMT):
Do I hear a +2 ? https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5885 https://gerrit.hyperledger.org/r/5775

dave.enyeart (Sat, 11 Feb 2017 22:46:42 GMT):
Do I hear a +2 ? https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5775 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5885

dave.enyeart (Sat, 11 Feb 2017 22:46:42 GMT):
Do I hear a +2 ? The first four are priority and are not too big. https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5775 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5885

dave.enyeart (Sat, 11 Feb 2017 22:46:42 GMT):
Do I hear a +2 ? The first four are priority and are not too big. https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013

dave.enyeart (Sat, 11 Feb 2017 22:46:42 GMT):
Do I hear a +2 ? The first ones are priority and are not too big. https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013

dave.enyeart (Sat, 11 Feb 2017 22:46:42 GMT):
Do I hear a +2 ? The first ones are priority (Updated list): https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5879 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5901

mastersingh24 (Sun, 12 Feb 2017 00:12:08 GMT):
-2 from me just cuz

mastersingh24 (Sun, 12 Feb 2017 00:12:53 GMT):
I can look in the AM if no one gets to them. gotta go clear some more snow :( (and find some dinner) ;)

dave.enyeart (Sun, 12 Feb 2017 00:57:19 GMT):
it's about time you moved to Raleigh... springtime down here...

jyellick (Sun, 12 Feb 2017 01:09:51 GMT):
https://gerrit.hyperledger.org/r/#/c/5755/ just needs the submit button pushed

muralisr (Sun, 12 Feb 2017 01:20:23 GMT):
done Jason

muralisr (Sun, 12 Feb 2017 01:20:23 GMT):
done @jyellick

gennadyl (Sun, 12 Feb 2017 16:00:43 GMT):
https://gerrit.hyperledger.org/r/#/c/5189/ - its already have one +2

yacovm (Sun, 12 Feb 2017 16:22:54 GMT):
[FAB-2198]: Starting to refactor Gossip message signature mechanism https://gerrit.hyperledger.org/r/#/c/5903/ ---> https://gerrit.hyperledger.org/r/#/c/5907/ The 1st commit of the two doesn't change/add any logic, it's just cosmetics. The 2nd commit simply makes our membership module use a map instead of a slice, nothing too hard to review IMO.

yacovm (Sun, 12 Feb 2017 16:22:54 GMT):
[FAB-2198]: Starting to refactor Gossip message signature mechanism (because protobuf marshaling is non-deterministic) The right depends on the left: https://gerrit.hyperledger.org/r/#/c/5903/ ---> https://gerrit.hyperledger.org/r/#/c/5907/ The 1st commit of the two doesn't change/add any logic, it's just cosmetics. The 2nd commit simply makes our membership module use a map instead of a slice, nothing too hard to review IMO.

C0rWin (Sun, 12 Feb 2017 16:37:19 GMT):
simplifies compilation of proto files: https://gerrit.hyperledger.org/r/#/c/5911/1

C0rWin (Sun, 12 Feb 2017 16:37:19 GMT):
simplifies compilation of proto files: https://gerrit.hyperledger.org/r/#/c/5911/1, no need to build an orderer and peers :)

muralisr (Sun, 12 Feb 2017 16:55:43 GMT):
Hi @gennadyl I had one comment/question on https://gerrit.hyperledger.org/r/#/c/5189 please

muralisr (Sun, 12 Feb 2017 16:57:55 GMT):
@C0rWin perhaps have @greg.haskins take a look at https://gerrit.hyperledger.org/r/#/c/5911 (think not, but didn't know if there were any side effects to doing the Makefie change)

C0rWin (Sun, 12 Feb 2017 17:00:48 GMT):
Sure thing

dave.enyeart (Sun, 12 Feb 2017 17:14:03 GMT):
I've updated my list for +2. The first ones are priority: https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5879 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5901

dave.enyeart (Sun, 12 Feb 2017 17:14:03 GMT):
I've updated ledger list for +2. The first ones are priority: https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887 https://gerrit.hyperledger.org/r/5745 https://gerrit.hyperledger.org/r/5879 https://gerrit.hyperledger.org/r/5729 https://gerrit.hyperledger.org/r/5013 https://gerrit.hyperledger.org/r/5901

smithbk (Sun, 12 Feb 2017 18:12:18 GMT):
Pls review https://gerrit.hyperledger.org/r/#/c/5631/ for fabric-ca

smithbk (Sun, 12 Feb 2017 18:16:25 GMT):
And https://gerrit.hyperledger.org/r/#/c/5851/ which is just a doc update

baohua (Mon, 13 Feb 2017 04:33:16 GMT):
pls help review: https://gerrit.hyperledger.org/r/#/c/5701/. One of the implementation of https://jira.hyperledger.org/browse/FAB-2118. Thanks!

gennadyl (Mon, 13 Feb 2017 08:00:00 GMT):
@muralisr Thanks

mastersingh24 (Mon, 13 Feb 2017 11:28:44 GMT):
any takers: https://gerrit.hyperledger.org/r/#/c/5917/

lehors (Mon, 13 Feb 2017 15:28:51 GMT):
Has joined the channel.

lehors (Mon, 13 Feb 2017 15:29:42 GMT):
could you guys please merge my tiny change https://gerrit.hyperledger.org/r/#/c/3931/ so that I don't have to keep updating Vagrantfile? Thank you

lehors (Mon, 13 Feb 2017 15:30:23 GMT):
this is merely to be able to build fabric-ca from the fabric vagrant env

mastersingh24 (Mon, 13 Feb 2017 15:30:31 GMT):
boooo

lehors (Mon, 13 Feb 2017 15:30:35 GMT):
it adds one sync'ed folder

mastersingh24 (Mon, 13 Feb 2017 15:31:09 GMT):
greg just added a comment

lehors (Mon, 13 Feb 2017 15:31:16 GMT):
and please, spare me the hatred on vagrant ;-)

greg.haskins (Mon, 13 Feb 2017 15:37:20 GMT):
@lehors the lack of symmetry with fabric.git bothers me, as does the notion that the user must have CA as they might not care...is there a way to refactor this to be variable? E.g. if FABRIC_CA_PATH then map()

greg.haskins (Mon, 13 Feb 2017 15:37:33 GMT):
otherwise, I suggest just using LOCALDEVDIR (thats what I use)

greg.haskins (Mon, 13 Feb 2017 15:38:07 GMT):
I think if you can parameterize it as in my last example, I see no problem

lehors (Mon, 13 Feb 2017 15:39:11 GMT):
ok, that's reasonable

lehors (Mon, 13 Feb 2017 15:40:04 GMT):
but if the use doesn't have CA it's not a problem, is it?

lehors (Mon, 13 Feb 2017 15:40:04 GMT):
but if the user doesn't have CA it's not a problem, is it?

greg.haskins (Mon, 13 Feb 2017 15:50:49 GMT):
im not sure how vagrant handles a map that doesnt exist

greg.haskins (Mon, 13 Feb 2017 15:50:58 GMT):
my assumption is, its an error

greg.haskins (Mon, 13 Feb 2017 15:51:03 GMT):
but maybe it just gets ignored

lehors (Mon, 13 Feb 2017 15:52:23 GMT):
yes, you're right, I just tried it

lehors (Mon, 13 Feb 2017 15:56:26 GMT):
ok, so, actually LOCALDEVDIR doesn't work the way I thought

lehors (Mon, 13 Feb 2017 15:56:33 GMT):
can you please tell me how to use it?

lehors (Mon, 13 Feb 2017 15:59:35 GMT):
hmm

lehors (Mon, 13 Feb 2017 16:00:39 GMT):
so LOCALDEVDIR has to be set to a relative path?

lehors (Mon, 13 Feb 2017 16:00:49 GMT):
absolute one didn't work

lehors (Mon, 13 Feb 2017 16:01:49 GMT):
and then it's mounted to /local-dev

lehors (Mon, 13 Feb 2017 16:02:06 GMT):
I can't say that I love that...

lehors (Mon, 13 Feb 2017 16:02:20 GMT):
but ok

lehors (Mon, 13 Feb 2017 16:39:14 GMT):
fabric-ca's make expects /opt/gopath/src/github.com/hyperledger/fabric-ca

dave.enyeart (Mon, 13 Feb 2017 17:15:24 GMT):
Requesting +2 review for 5 at a time hasn't worked out so well for me. How about if we prioritize these two @muralisr @binhn @mastersingh24 :

dave.enyeart (Mon, 13 Feb 2017 17:15:26 GMT):
https://gerrit.hyperledger.org/r/5815 https://gerrit.hyperledger.org/r/5887

dave.enyeart (Mon, 13 Feb 2017 17:16:16 GMT):
finalize api stuff

binhn (Mon, 13 Feb 2017 17:16:31 GMT):
been reviewing many others -- these are on my queue

dave.enyeart (Mon, 13 Feb 2017 17:16:40 GMT):
thanks!

mastersingh24 (Mon, 13 Feb 2017 17:17:09 GMT):
@lehors - not sure what you mean by expects the path mentioned? the only place I see `/opt/gopath/src` is as the mount point for a volume inside the Docker container

mastersingh24 (Mon, 13 Feb 2017 17:22:38 GMT):
any takers? https://gerrit.hyperledger.org/r/#/c/5917/

muralisr (Mon, 13 Feb 2017 18:35:30 GMT):
done @mastersingh24

lehors (Mon, 13 Feb 2017 20:46:47 GMT):
@mastersingh24 that part is actually ok, it's the rename-repo script which spits: Neither /opt/gopath/src/github.com/hyperledger/fabric-cop nor /opt/gopath/src/github.com/hyperledger/fabric-ca exists

lehors (Mon, 13 Feb 2017 20:46:52 GMT):
but that's harmless

lehors (Mon, 13 Feb 2017 20:48:04 GMT):
now I need to find out why the run_tests fails but I'll take it to the #fabric-ca channel

jimthematrix (Mon, 13 Feb 2017 21:28:28 GMT):
https://gerrit.hyperledger.org/r/#/c/5943/ - refactoring of the headless-tests.js to individual test suites. it's only affecting tests so feel free to be bold ;-)

jimthematrix (Mon, 13 Feb 2017 22:19:39 GMT):
https://gerrit.hyperledger.org/r/#/c/5975/ - super trivial, adding inline doc only

yacovm (Mon, 13 Feb 2017 22:20:29 GMT):
https://gerrit.hyperledger.org/r/#/c/5809/ A small change set, 44 lines. Need only 1 more +2

greg.haskins (Mon, 13 Feb 2017 23:58:00 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/5953/

rjones (Mon, 13 Feb 2017 23:58:56 GMT):
Has left the channel.

jimthematrix (Tue, 14 Feb 2017 03:32:30 GMT):
https://gerrit.hyperledger.org/r/#/c/5943/ - anyone? it may look big but it's mostly structural, and it's all in the test code, which are verified by the CI. so, very safe to merge ;-)

adc (Tue, 14 Feb 2017 10:11:25 GMT):
Hi All, does someone understand why this is failing: https://jenkins.hyperledger.org/job/fabric-verify-x86_64/6943/console ? Please, help needed.

yacovm (Tue, 14 Feb 2017 10:26:52 GMT):
@adc , &> #ci-pipeline or #fabric-ci

adc (Tue, 14 Feb 2017 10:27:12 GMT):
oh thanks :)

mastersingh24 (Tue, 14 Feb 2017 10:43:38 GMT):
https://gerrit.hyperledger.org/r/#/c/5835/ for anyone who is around

vpaprots (Tue, 14 Feb 2017 12:13:48 GMT):
I am getting into rebase cycles with these two, they are in principle ready, but would appreciate a review: https://gerrit.hyperledger.org/r/#/c/4877/10 https://gerrit.hyperledger.org/r/#/c/5897/4

coolsvap (Tue, 14 Feb 2017 13:03:02 GMT):
Has joined the channel.

jimthematrix (Tue, 14 Feb 2017 14:49:16 GMT):
https://gerrit.hyperledger.org/r/#/c/5943 - anyone? it may look big but it's mostly structural, and it's all in the test code, which are verified by the CI. so, very safe to merge

jimthematrix (Tue, 14 Feb 2017 14:50:12 GMT):
https://gerrit.hyperledger.org/r/#/c/5997/ step1 to allow crypto key store to use different super classes implementing the KeyValueStore interface

dave.enyeart (Tue, 14 Feb 2017 15:25:52 GMT):
Priorities for ledger reviews today: https://gerrit.hyperledger.org/r/#/c/5729/ https://gerrit.hyperledger.org/r/#/c/5879/

joshhus (Tue, 14 Feb 2017 16:46:43 GMT):
Has joined the channel.

joshhus (Tue, 14 Feb 2017 16:47:57 GMT):
Doc topic "capabilities" needs a +2: https://gerrit.hyperledger.org/r/#/c/4855/

mastersingh24 (Tue, 14 Feb 2017 16:56:30 GMT):
@jyellick - had a question on https://gerrit.hyperledger.org/r/#/c/5985/

mastersingh24 (Tue, 14 Feb 2017 16:56:30 GMT):
@jyellick - had a question on https://gerrit.hyperledger.org/r/#/c/5985/ (posted a comment)

jyellick (Tue, 14 Feb 2017 16:59:14 GMT):
@mastersingh24 Thanks for the feedback, replied, will fix

joshhus (Tue, 14 Feb 2017 16:59:35 GMT):
New proposed docs topic: Channels. https://gerrit.hyperledger.org/r/#/c/6017/

smithbk (Tue, 14 Feb 2017 17:25:38 GMT):
Several for fabric-ca need review

smithbk (Tue, 14 Feb 2017 17:25:41 GMT):
https://gerrit.hyperledger.org/r/5631 https://gerrit.hyperledger.org/r/5763 https://gerrit.hyperledger.org/r/5853 https://gerrit.hyperledger.org/r/6003

muralisr (Tue, 14 Feb 2017 17:36:26 GMT):
can we get a review on https://gerrit.hyperledger.org/r/#/c/5979/ please ? its small (just some checks in one file) and helps deploy work (right :-) ) ?

jimthematrix (Tue, 14 Feb 2017 18:31:28 GMT):
can I ask any brave souls around to click the "Submit" button on this one for me? @mastersingh24 already gave +2 so it's ready to merge (fabric-sdk-node only requires one +2): https://gerrit.hyperledger.org/r/#/c/5943/

jimthematrix (Tue, 14 Feb 2017 18:32:10 GMT):
@mastersingh24 @cbf @yacovm @muralisr ^^^

jimthematrix (Tue, 14 Feb 2017 18:36:29 GMT):
@yacovm :thumbsup:

harsha (Tue, 14 Feb 2017 18:36:38 GMT):
Has joined the channel.

jimthematrix (Tue, 14 Feb 2017 19:16:06 GMT):
trivial one: moving a test from the "integration" bucket to the "headless" bucket to maximize coverage of the verification build (that only runs the headless bucket): https://gerrit.hyperledger.org/r/#/c/6029/

jimthematrix (Tue, 14 Feb 2017 19:16:28 GMT):
this was an escape of the previous re-factor (5943)

dave.enyeart (Tue, 14 Feb 2017 20:25:19 GMT):
@binhn @mastersingh24 I reviewed the GetHistoryForKey changeset with Murali in detail. Just need one more +2 please: https://gerrit.hyperledger.org/r/#/c/5981

greg.haskins (Tue, 14 Feb 2017 20:37:25 GMT):
some low hanging fruit: https://gerrit.hyperledger.org/r/#/c/5953/

greg.haskins (Tue, 14 Feb 2017 20:37:34 GMT):
https://gerrit.hyperledger.org/r/#/c/6019/

greg.haskins (Tue, 14 Feb 2017 20:37:46 GMT):
https://gerrit.hyperledger.org/r/#/c/6023/

JonathanLevi (Tue, 14 Feb 2017 22:46:06 GMT):
@greg.haskins: any "known" ramifications wrt 6023 ? I know it's a breaking change, etc...

greg.haskins (Tue, 14 Feb 2017 22:46:37 GMT):
not really, v1.0+chaintool support is newly emerging

greg.haskins (Tue, 14 Feb 2017 22:46:50 GMT):
e.g. there are no users other than me (I am guessing, since its not fully working)

greg.haskins (Tue, 14 Feb 2017 22:47:23 GMT):
it breaks people from v0.6 but right now, its already "broken" in the sense that v1.0 support is missing ;)

JonathanLevi (Tue, 14 Feb 2017 22:47:26 GMT):
I agree. Your commit message sounded pretty dramatic ;-) so I wanted to make sure. It's not the only breaking change....

greg.haskins (Tue, 14 Feb 2017 22:47:35 GMT):
haha, thats me

greg.haskins (Tue, 14 Feb 2017 22:47:39 GMT):
dramatic

JonathanLevi (Tue, 14 Feb 2017 22:47:40 GMT):
But the sooner we break stuff that we "have to" break, the better.

greg.haskins (Tue, 14 Feb 2017 22:47:44 GMT):
right

JonathanLevi (Tue, 14 Feb 2017 22:47:49 GMT):
Ha ha. Merged ;-)

greg.haskins (Tue, 14 Feb 2017 22:47:57 GMT):
it was stated in the interest of full disclosure, not to cause alarm

JonathanLevi (Tue, 14 Feb 2017 22:48:09 GMT):
Fair enough - just wanted to double-check here.

greg.haskins (Tue, 14 Feb 2017 22:48:14 GMT):
but I could have been clearer

greg.haskins (Tue, 14 Feb 2017 22:48:17 GMT):
yes, thank you

JonathanLevi (Tue, 14 Feb 2017 22:48:25 GMT):
Nah, you are fine. Thanks.

smithbk (Wed, 15 Feb 2017 00:44:58 GMT):
Could someone review some of these fabric-ca change sets? Thanks

smithbk (Wed, 15 Feb 2017 00:45:00 GMT):
https://gerrit.hyperledger.org/r/5631 https://gerrit.hyperledger.org/r/5763 https://gerrit.hyperledger.org/r/5853 https://gerrit.hyperledger.org/r/6003 https://gerrit.hyperledger.org/r/6037

grapebaba (Wed, 15 Feb 2017 01:25:53 GMT):
https://gerrit.hyperledger.org/r/#/c/5983/ need another +2

muralisr (Wed, 15 Feb 2017 02:32:17 GMT):
@grapebaba looking...

grapebaba (Wed, 15 Feb 2017 02:32:34 GMT):
thanks

baohua (Wed, 15 Feb 2017 03:51:29 GMT):
A quick and simple fix on docker image: http://gerrit.hyperledger.org/r/6041. Thanks!

adc (Wed, 15 Feb 2017 08:23:14 GMT):
Hi All, please some love to: https://gerrit.hyperledger.org/r/#/c/6001/ and https://gerrit.hyperledger.org/r/#/c/5945/ Thanks :)

yacovm (Wed, 15 Feb 2017 09:28:21 GMT):
@adc you're missing only 1 +2 on the replay attack, but you wrote: > Before merging this change-set, the client-sdk needs to be modified to generate the TxID in the new expected way. Was it modified or not?

adc (Wed, 15 Feb 2017 09:28:46 GMT):
ah, right

adc (Wed, 15 Feb 2017 09:29:01 GMT):
Yacov, really good point

adc (Wed, 15 Feb 2017 09:29:09 GMT):
that one needs to wait

yacovm (Wed, 15 Feb 2017 09:29:15 GMT):
so -1 yourself

adc (Wed, 15 Feb 2017 09:30:02 GMT):
perfect, thanks for the feedback

jimthematrix (Wed, 15 Feb 2017 11:34:07 GMT):
@adc the client SDK at the moment is stuck on a few big changes (ie chaincode deploy) so this part can't be done until those are cleared first, sorry for the delay

adc (Wed, 15 Feb 2017 12:05:50 GMT):
np, thanks @jimthematrix

smithbk (Wed, 15 Feb 2017 14:24:51 GMT):
The following still need review. Thanks

smithbk (Wed, 15 Feb 2017 14:24:56 GMT):
https://gerrit.hyperledger.org/r/5631 https://gerrit.hyperledger.org/r/5763 https://gerrit.hyperledger.org/r/5853 https://gerrit.hyperledger.org/r/6003 https://gerrit.hyperledger.org/r/6037

dave.enyeart (Wed, 15 Feb 2017 15:52:06 GMT):
@mastersingh24 Can you review 'scope couch query to chaincode', implemented in two parts:

dave.enyeart (Wed, 15 Feb 2017 15:52:15 GMT):
https://gerrit.hyperledger.org/r/#/c/5879/

dave.enyeart (Wed, 15 Feb 2017 15:52:26 GMT):
https://gerrit.hyperledger.org/r/#/c/5971/

greg.haskins (Wed, 15 Feb 2017 16:10:47 GMT):
simple one: https://gerrit.hyperledger.org/r/#/c/6035/

greg.haskins (Wed, 15 Feb 2017 16:38:52 GMT):
@muralisr two more for you sir: https://gerrit.hyperledger.org/r/#/c/6059/

muralisr (Wed, 15 Feb 2017 16:41:50 GMT):
certainly @greg.haskins ... in about 10 mins ?

greg.haskins (Wed, 15 Feb 2017 16:42:05 GMT):
of course, whenever you get a chance

muralisr (Wed, 15 Feb 2017 17:03:24 GMT):
responded with a comment/question, @greg.haskins

greg.haskins (Thu, 16 Feb 2017 00:57:38 GMT):
@muralisr all passing CI now: https://gerrit.hyperledger.org/r/#/c/6059/

muralisr (Thu, 16 Feb 2017 00:58:54 GMT):
@greg.haskins I was looking at that... couldn't figure out why the entry was removed in platforms_test.go ... ?

greg.haskins (Thu, 16 Feb 2017 00:59:25 GMT):
oh because in the earlier form of the patch I was trying to enforce /src/$pkg/.*

greg.haskins (Thu, 16 Feb 2017 00:59:32 GMT):
but that broke a lot of tests

greg.haskins (Thu, 16 Feb 2017 00:59:39 GMT):
that are just packaging the entire GOPATH

greg.haskins (Thu, 16 Feb 2017 01:00:08 GMT):
and I decided that it was probably safer to just stick to excluding binaries than to try to impose policy on the golang packages themselves

muralisr (Thu, 16 Feb 2017 01:00:18 GMT):
ok

greg.haskins (Thu, 16 Feb 2017 01:00:31 GMT):
but then I forgot to remove the test to was looking for that enforcement

muralisr (Thu, 16 Feb 2017 01:00:59 GMT):
ok

muralisr (Thu, 16 Feb 2017 01:01:13 GMT):
I didn't connect those dots.

muralisr (Thu, 16 Feb 2017 01:01:14 GMT):
thanks

greg.haskins (Thu, 16 Feb 2017 01:01:35 GMT):
here was the original logic that drove the test: https://gerrit.hyperledger.org/r/#/c/6059/1..3/core/chaincode/platforms/golang/platform.go

greg.haskins (Thu, 16 Feb 2017 01:01:35 GMT):
here was the original logic that warranted the test: https://gerrit.hyperledger.org/r/#/c/6059/1..3/core/chaincode/platforms/golang/platform.go

greg.haskins (Thu, 16 Feb 2017 01:02:43 GMT):
but it turns out the CLI/platform is overzealous and just grabs $GOPATH/src/.*\.(go|c|h|yaml|json)

greg.haskins (Thu, 16 Feb 2017 01:03:03 GMT):
(which I think I knew, but had forgotten until the tests went belly up

greg.haskins (Thu, 16 Feb 2017 01:03:54 GMT):
ideally, we would replicate similar logic to ./scripts/goListFiles.sh

greg.haskins (Thu, 16 Feb 2017 01:04:15 GMT):
i.e. take the chaincode package and then walk the deps/transitives backwards

baohua (Thu, 16 Feb 2017 01:08:56 GMT):
hi, there're missing configs in the orderer image, which will cause booting error possibly. Here is a quick fix, thanks! https://gerrit.hyperledger.org/r/6041, https://gerrit.hyperledger.org/r/6047

muralisr (Thu, 16 Feb 2017 01:34:51 GMT):
+2ed , Greg. If we need in future to include exes we can revisit. The one thing that might bite us if valid go files have +x on them

muralisr (Thu, 16 Feb 2017 01:35:19 GMT):
but that's better than allowing exes I think

murrekatt (Thu, 16 Feb 2017 06:18:33 GMT):
Has joined the channel.

murrekatt (Thu, 16 Feb 2017 06:23:40 GMT):
hi all, did my first code change yesterday fixing something small and pushed the changes for review (FAB-2244). i opened the issue before and then made the changes and pushed for review to gerrit https://gerrit.hyperledger.org/r/#/c/6049/. a few questions: 1) how to link from jira to gettit? 2) who to select as reviewers? thanks!

wutongtree (Thu, 16 Feb 2017 10:08:05 GMT):
Has joined the channel.

greg.haskins (Thu, 16 Feb 2017 13:01:36 GMT):
@muralisr ty. If you wouldnt mind, please review the other two in the stack

greg.haskins (Thu, 16 Feb 2017 13:01:38 GMT):
https://gerrit.hyperledger.org/r/#/c/6077/

greg.haskins (Thu, 16 Feb 2017 13:01:49 GMT):
https://gerrit.hyperledger.org/r/#/c/6057/

muralisr (Thu, 16 Feb 2017 13:11:35 GMT):
will look today (hopefully by midday), @greg.haskins

greg.haskins (Thu, 16 Feb 2017 13:14:33 GMT):
@muralisr ty

muralisr (Thu, 16 Feb 2017 13:49:48 GMT):
with https://gerrit.hyperledger.org/r/#/c/6081, the later master passes end-to-end sniff tests (default as well as create chains)

muralisr (Thu, 16 Feb 2017 13:50:01 GMT):
will continue doing tests throughout the day

muralisr (Thu, 16 Feb 2017 13:51:09 GMT):
docs need to be updated...

dave.enyeart (Thu, 16 Feb 2017 15:21:38 GMT):
Please merge: https://gerrit.hyperledger.org/r/#/c/6075/

dave.enyeart (Thu, 16 Feb 2017 15:21:38 GMT):
@muralisr @binhn @mastersingh24 Please merge: https://gerrit.hyperledger.org/r/#/c/6075/

dave.enyeart (Thu, 16 Feb 2017 15:21:54 GMT):
that is the last one tripping up end-to-end scenario for people

alviontaran (Thu, 16 Feb 2017 16:21:52 GMT):
Has joined the channel.

chris.elder (Thu, 16 Feb 2017 22:32:32 GMT):
@muralisr @mastersingh24 If anyone has time, can you review https://gerrit.hyperledger.org/r/#/c/5971/ ?

chris.elder (Fri, 17 Feb 2017 01:19:03 GMT):
Can I get a ledger review for https://gerrit.hyperledger.org/r/#/c/6051/ ? This is a change to make the CouchDB name be consistent with the Chain ID.

ylsGit (Fri, 17 Feb 2017 02:29:32 GMT):
Has joined the channel.

dave.enyeart (Fri, 17 Feb 2017 03:24:12 GMT):
Ready for review: https://gerrit.hyperledger.org/r/#/c/5991/

mastersingh24 (Fri, 17 Feb 2017 06:23:12 GMT):
easy one on fabric-ca: https://gerrit.hyperledger.org/r/#/c/5481/

nickgaski (Fri, 17 Feb 2017 17:00:19 GMT):
this aint an easy one; but there is clamoring for this to be done by Monday with the completion of an overview/key concepts section - https://gerrit.hyperledger.org/r/#/c/6157/

nickgaski (Fri, 17 Feb 2017 17:01:43 GMT):
If we can get this merged, we can start cleaning up the top level topics, add some new formatting stuff to make it more attractive and facilitate navigation. I will be bugging this channel for the next three days, you've been warned

greg.haskins (Fri, 17 Feb 2017 17:19:25 GMT):
@mastersingh24 @muralisr @cbf new stack for your review: https://gerrit.hyperledger.org/r/#/c/6167/

greg.haskins (Fri, 17 Feb 2017 17:19:41 GMT):
(note that its three patches in total, not including the unrelated FAB-2341 fix)

greg.haskins (Fri, 17 Feb 2017 17:19:57 GMT):
chaincode containers reduced from 1.4G to ~175MB

greg.haskins (Fri, 17 Feb 2017 17:26:09 GMT):
as a side note, technically we should get CAR chaincode built with -static too (and I have a CR for that, hint hint @muralisr: https://gerrit.hyperledger.org/r/#/c/6093/) but I think 6167 and friends may go in independent of a new chaintool release that incorporates CR 6093 for now

greg.haskins (Fri, 17 Feb 2017 17:26:14 GMT):
as long as we get it in eventually

muralisr (Fri, 17 Feb 2017 17:26:56 GMT):
+2ed the 2341 @greg.haskins ... can't wait to get to 6167 (later today ?)

greg.haskins (Fri, 17 Feb 2017 17:27:04 GMT):
a) it seems to work anyway (e.g. there arent any missing .so files in baseos) and b) there arent any users of chaintool + v1.0 yet since I am still in the process of qualifying it

greg.haskins (Fri, 17 Feb 2017 17:27:50 GMT):
so im just thinking we get a CR 6093 release before 1.0, but no reason to block the fabric work

greg.haskins (Fri, 17 Feb 2017 17:28:44 GMT):
@muralisr of course, appreciate any review time but always at your schedule

nickgaski (Fri, 17 Feb 2017 17:55:52 GMT):
ok this one is a little more manageable - CLI commands for install and instantiate - https://gerrit.hyperledger.org/r/#/c/6119/

latitiah (Fri, 17 Feb 2017 18:24:20 GMT):
Has joined the channel.

latitiah (Fri, 17 Feb 2017 18:26:41 GMT):
I have a couple of PRs for review for building out more behave tests: https://gerrit.hyperledger.org/r/#/c/5657/ https://gerrit.hyperledger.org/r/#/c/6117/

latitiah (Fri, 17 Feb 2017 18:26:41 GMT):
PRs for review for behave tests: https://gerrit.hyperledger.org/r/#/c/5657/ https://gerrit.hyperledger.org/r/#/c/6117/

nickgaski (Fri, 17 Feb 2017 20:00:30 GMT):
https://gerrit.hyperledger.org/r/#/c/6157 - Table of Contents. Gotta get eyes on this and figure out how to get this or an iteration of this merged by Monday

muralisr (Fri, 17 Feb 2017 20:15:12 GMT):
with https://gerrit.hyperledger.org/r/#/c/6161 end-to-end tests work now (thanks @greg.haskins)

ashutosh_kumar (Fri, 17 Feb 2017 22:32:45 GMT):
@JonathanLevi I have incorporated your comments in https://gerrit.hyperledger.org/r/#/c/4363/. Please have a look.

baohua (Sat, 18 Feb 2017 00:00:44 GMT):
this needs another +2 :) https://gerrit.hyperledger.org/r/#/c/6041/

dave.enyeart (Sat, 18 Feb 2017 00:25:50 GMT):
some ledger CRs for +2 review: https://gerrit.hyperledger.org/r/#/c/6091/ https://gerrit.hyperledger.org/r/#/c/5973/ https://gerrit.hyperledger.org/r/#/c/5991/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/6080/

dave.enyeart (Sat, 18 Feb 2017 00:25:50 GMT):
some ledger CRs for +2 review: https://gerrit.hyperledger.org/r/#/c/6199/ https://gerrit.hyperledger.org/r/#/c/6091/ https://gerrit.hyperledger.org/r/#/c/5973/ https://gerrit.hyperledger.org/r/#/c/5991/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/6080/

dave.enyeart (Sat, 18 Feb 2017 00:25:50 GMT):
some ledger CRs for +2 review: https://gerrit.hyperledger.org/r/#/c/6091/ https://gerrit.hyperledger.org/r/#/c/5991/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/6080/

nickgaski (Sat, 18 Feb 2017 00:42:37 GMT):
one more try - https://gerrit.hyperledger.org/r/#/c/6157

nickgaski (Sat, 18 Feb 2017 00:42:58 GMT):
https://gerrit.hyperledger.org/r/#/c/6119 this needs one more +2

muralisr (Sat, 18 Feb 2017 13:38:32 GMT):
@nickgaski , @yacovm has some comments on 6119 ... can you take a look and incorporate please ? Sooner we get 6119 out the better

baohua (Sat, 18 Feb 2017 14:31:52 GMT):
I've rebased a patchset, which got +2 before, welcome for new review, thanks! https://gerrit.hyperledger.org/r/#/c/5701/

yacovm (Sat, 18 Feb 2017 15:15:50 GMT):
Trivial one , 12 lines: https://gerrit.hyperledger.org/r/#/c/6197/

yacovm (Sat, 18 Feb 2017 15:15:50 GMT):
2 Trivial ones , 12 lines: https://gerrit.hyperledger.org/r/#/c/6197/ https://gerrit.hyperledger.org/r/#/c/6207/

jimthematrix (Sat, 18 Feb 2017 17:48:45 GMT):
super trivial (test only): https://gerrit.hyperledger.org/r/#/c/6209/ improving API design of couchdb keyvaluestore implementation: https://gerrit.hyperledger.org/r/#/c/6211/

mastersingh24 (Sat, 18 Feb 2017 18:51:43 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/6201/

mastersingh24 (Sat, 18 Feb 2017 18:52:48 GMT):
https://gerrit.hyperledger.org/r/#/c/6203/ - just needs someone to hit submit ;)

smithbk (Sat, 18 Feb 2017 19:25:27 GMT):
Hi, the following change sets are the next in line for fabric-ca ... thanks

smithbk (Sat, 18 Feb 2017 19:25:29 GMT):
https://gerrit.hyperledger.org/r/5853 https://gerrit.hyperledger.org/r/6003 https://gerrit.hyperledger.org/r/6037 https://gerrit.hyperledger.org/r/6179

yacovm (Sat, 18 Feb 2017 22:00:07 GMT):
Can anyone fix the broken master? https://gerrit.hyperledger.org/r/#/c/6225

muralisr (Sat, 18 Feb 2017 22:40:43 GMT):
https://gerrit.hyperledger.org/r/#/c/6219 has been rebased to use https://gerrit.hyperledger.org/r/#/c/6225.. once it succeeds hopefully master will be back on track

latitiah (Sat, 18 Feb 2017 22:55:57 GMT):
I have a couple of PRs for review for building out more behave tests: https://gerrit.hyperledger.org/r/#/c/5657 https://gerrit.hyperledger.org/r/#/c/6117

smithbk (Sat, 18 Feb 2017 23:55:33 GMT):
https://gerrit.hyperledger.org/r/#/c/5853/ needs another +2 review ... thanks

mastersingh24 (Sun, 19 Feb 2017 00:16:18 GMT):
any takers: https://gerrit.hyperledger.org/r/#/c/6201/

muralisr (Sun, 19 Feb 2017 01:31:29 GMT):
one more +2 for https://gerrit.hyperledger.org/r/#/c/6219/ to make end-2-end work please?

muralisr (Sun, 19 Feb 2017 01:33:11 GMT):
and done @mastersingh24

JonathanLevi (Sun, 19 Feb 2017 07:32:23 GMT):
@smithbk: https://gerrit.hyperledger.org/r/#/c/5853/ is merged as well (will follow up with a CR myself...)

mastersingh24 (Sun, 19 Feb 2017 12:49:12 GMT):
quick series of repo / package cleanup requests: https://gerrit.hyperledger.org/r/#/c/6237/ https://gerrit.hyperledger.org/r/#/c/6239/ https://gerrit.hyperledger.org/r/#/c/6241/

smithbk (Sun, 19 Feb 2017 13:35:40 GMT):
@JonathanLevi thanks

smithbk (Sun, 19 Feb 2017 13:35:54 GMT):
Here are next in line for fabric-ca

smithbk (Sun, 19 Feb 2017 13:35:56 GMT):
https://gerrit.hyperledger.org/r/6003 https://gerrit.hyperledger.org/r/6037 https://gerrit.hyperledger.org/r/6179 https://gerrit.hyperledger.org/r/6243

greg.haskins (Sun, 19 Feb 2017 14:58:48 GMT):
ready for review: https://gerrit.hyperledger.org/r/#/c/6167/

bmos299 (Sun, 19 Feb 2017 15:51:13 GMT):
Has joined the channel.

bmos299 (Sun, 19 Feb 2017 15:51:58 GMT):
Can maintainers please look at: https://gerrit.hyperledger.org/r/#/c/6157/ ...we want to get the ToC in so we can then start adding docs and send in a pr to use sphinx for the readability.

bmos299 (Sun, 19 Feb 2017 15:52:11 GMT):
Thanks you Greg.

yacovm (Sun, 19 Feb 2017 16:24:52 GMT):
This only looks scary, but 400 of it are `pb.go` https://gerrit.hyperledger.org/r/#/c/5965/

vpaprots (Sun, 19 Feb 2017 18:20:34 GMT):
can we PLEASE get this one merged. https://gerrit.hyperledger.org/r/#/c/4877/15 The rebase game is killing me. I suspect I will spend another 3 hours just getting the two of the patches fixed :(

mastersingh24 (Sun, 19 Feb 2017 19:27:15 GMT):
@adc @JonathanLevi ^^^^^

mastersingh24 (Sun, 19 Feb 2017 19:27:58 GMT):
one more for https://gerrit.hyperledger.org/r/#/c/6239/ please and then please submit https://gerrit.hyperledger.org/r/#/c/6241 as well

JonathanLevi (Sun, 19 Feb 2017 21:04:30 GMT):
@mastersingh24, @vpaprots: approved. Need another `+2`...

mastersingh24 (Sun, 19 Feb 2017 21:05:51 GMT):
cool - just wanted to make sure you or Angelo reviewed before approving

JonathanLevi (Sun, 19 Feb 2017 21:06:07 GMT):
Thank you.

JonathanLevi (Sun, 19 Feb 2017 21:06:07 GMT):
Thank you. @vpaprots thanks for addressing all of these over the weekend...

vpaprots (Sun, 19 Feb 2017 21:06:55 GMT):
Thanks @JonathanLevi ! :D

vpaprots (Sun, 19 Feb 2017 21:09:44 GMT):
I am still strugling rebasing the second of the group, but if you got time ( @JonathanLevi @mastersingh24 ) the change is growing in scope and havent figured out a way to break it up.. https://gerrit.hyperledger.org/r/#/c/5897/

vpaprots (Sun, 19 Feb 2017 21:11:08 GMT):
(at the moment, https://gerrit.hyperledger.org/r/#/c/6235/4 adds several uses of BCCSP, which I hadnt accounted configuration for)

dave.enyeart (Mon, 20 Feb 2017 00:39:17 GMT):
some ledger CRs for +2 review: https://gerrit.hyperledger.org/r/#/c/6091/ https://gerrit.hyperledger.org/r/#/c/5991/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/6080/

muralisr (Mon, 20 Feb 2017 01:05:07 GMT):
https://gerrit.hyperledger.org/r/#/c/6091 merged @dave.enyeart

yacovm (Mon, 20 Feb 2017 12:03:24 GMT):
Replay attack integration tests courtesy of @adc https://gerrit.hyperledger.org/r/#/c/6233/

harsha (Mon, 20 Feb 2017 12:11:35 GMT):
@greg.haskins @harrijk @SriramaSharma I have rebased https://gerrit.hyperledger.org/r/#/c/6053/ . Kindly help with review.

mastersingh24 (Mon, 20 Feb 2017 12:21:55 GMT):
@harsha - looks good

harsha (Mon, 20 Feb 2017 12:23:50 GMT):
@mastersingh24 Thank you !!

harsha (Mon, 20 Feb 2017 12:25:10 GMT):
@yacovm Thank you

yacovm (Mon, 20 Feb 2017 12:25:17 GMT):
sure thing

murrekatt (Mon, 20 Feb 2017 13:10:01 GMT):
please review and merge https://gerrit.hyperledger.org/r/#/c/6049/ thanks!

muralisr (Mon, 20 Feb 2017 13:52:51 GMT):
done @murrekatt , thanks!

smithbk (Mon, 20 Feb 2017 14:13:31 GMT):
These are still in need of review for fabric-ca. Thanks

smithbk (Mon, 20 Feb 2017 14:13:35 GMT):
https://gerrit.hyperledger.org/r/6003 https://gerrit.hyperledger.org/r/6037 https://gerrit.hyperledger.org/r/6179 https://gerrit.hyperledger.org/r/6243

scottz (Mon, 20 Feb 2017 16:19:53 GMT):
Has joined the channel.

scottz (Mon, 20 Feb 2017 16:25:20 GMT):
Can I get some folks to review languishing https://gerrit.hyperledger.org/r/#/c/6039/ ? @greg.haskins Did you finish your code review? I see a history log for patch set 3, but no more comments. It would be really helpful if we could get this done, so I can avoid rebasing and updating in my branch to keep current with other changes being merged, and so we can use this in CI tests!

ashutosh_kumar (Mon, 20 Feb 2017 17:21:16 GMT):
I have lots of CR . This will need some attention https://gerrit.hyperledger.org/r/#/c/5161/

adc (Tue, 21 Feb 2017 12:26:33 GMT):
Hi All, please some love to this change-set: https://gerrit.hyperledger.org/r/#/c/6277/ Thanks :)

suryalanka (Tue, 21 Feb 2017 13:50:01 GMT):
Has joined the channel.

smithbk (Tue, 21 Feb 2017 17:30:07 GMT):
The following are ready for re-review ... thanks

smithbk (Tue, 21 Feb 2017 17:30:09 GMT):
https://gerrit.hyperledger.org/r/6037 - Intermediate CA server support https://gerrit.hyperledger.org/r/6179 - Reflect to add server config flags https://gerrit.hyperledger.org/r/6243 - Docker images for client and server commands

aso (Tue, 21 Feb 2017 20:48:36 GMT):
Has joined the channel.

aso (Tue, 21 Feb 2017 20:49:07 GMT):
Please look at this https://gerrit.hyperledger.org/r/#/c/6319/ it blocks the access control work

vpaprots (Wed, 22 Feb 2017 02:06:47 GMT):
https://gerrit.hyperledger.org/r/#/c/5897/12 is in (after 3 days of struggling with rebase updates, rethought my approach with bootBCCSP) I think the people I bugged about this at one point or another: @mastersingh24 @JonathanLevi @adc @elli-androulaki @jyellick @aso.

elli-androulaki (Wed, 22 Feb 2017 02:06:47 GMT):
Has joined the channel.

JonathanLevi (Wed, 22 Feb 2017 06:56:30 GMT):
@smithbk: will it be possible to unlink https://gerrit.hyperledger.org/r/#/c/6179 from https://gerrit.hyperledger.org/r/6037 ?

ashutosh_kumar (Wed, 22 Feb 2017 13:21:49 GMT):
I have one more for review : https://gerrit.hyperledger.org/r/#/c/4363/. @JonathanLevi , I have incorporated your last comments. This one does not have any dependency on other TCert component(s).

smithbk (Wed, 22 Feb 2017 14:19:47 GMT):
@jonathanlevi done

psa (Wed, 22 Feb 2017 15:56:16 GMT):
Has joined the channel.

gennadyl (Wed, 22 Feb 2017 16:09:59 GMT):
Can anybody look into https://gerrit.hyperledger.org/r/#/c/5909/ - connection between leader election and deliver service

jimthematrix (Wed, 22 Feb 2017 16:35:07 GMT):
two from node sdk to fix fabric-ca-client tests: https://gerrit.hyperledger.org/r/#/c/6323/ https://gerrit.hyperledger.org/r/#/c/6363/

adc (Wed, 22 Feb 2017 17:09:16 GMT):
@JonathanLevi, may you unblock https://gerrit.hyperledger.org/r/#/c/6277/ ?

JonathanLevi (Wed, 22 Feb 2017 17:20:17 GMT):
@adc, will address it today.

adc (Wed, 22 Feb 2017 17:20:27 GMT):
thanks much :)

JonathanLevi (Wed, 22 Feb 2017 17:21:53 GMT):
@ashutosh_kumar: please see my comment. I believe you have incorporated the comments, and then they got undone/reverted in a subsequent patchset.

JonathanLevi (Wed, 22 Feb 2017 17:22:06 GMT):
Also,

JonathanLevi (Wed, 22 Feb 2017 17:22:13 GMT):
Any objections to merging this: https://gerrit.hyperledger.org/r/#/c/5065

ashutosh_kumar (Wed, 22 Feb 2017 18:07:29 GMT):
I am fine with that.

ashutosh_kumar (Wed, 22 Feb 2017 18:10:37 GMT):
@JonathanLevi , I see that now. Let me fix that.

ashutosh_kumar (Wed, 22 Feb 2017 19:29:20 GMT):
@JonathanLevi , I fixed https://gerrit.hyperledger.org/r/#/c/4363 by bringing it to patch set 10 level. Please have a look.

JonathanLevi (Wed, 22 Feb 2017 20:03:59 GMT):
Yes, I'm with you on that one. Already replied... if you could decouple from the rest, it may be quicker to get it in.

JonathanLevi (Wed, 22 Feb 2017 20:04:44 GMT):
There are a few overlapping files in a few CRs and we may end up again with these vicious circular rebasing cycles.

JonathanLevi (Wed, 22 Feb 2017 20:05:57 GMT):
At the same time, it's really tempting to ask you for a few examples of such encrypted attrs?

JonathanLevi (Wed, 22 Feb 2017 20:05:57 GMT):
At the same time, it's really tempting to ask you for a few examples of such encrypted attrs... but let's see if you can decouple this one first

JonathanLevi (Wed, 22 Feb 2017 20:06:18 GMT):
But honestly, let's just get one of these ready for submissions, and we'll work something out.

jimthematrix (Wed, 22 Feb 2017 20:17:11 GMT):
two more for node SDK: https://gerrit.hyperledger.org/r/#/c/6383/ - test update https://gerrit.hyperledger.org/r/#/c/6381/ - cleanup unneeded modules from package.json

smithbk (Wed, 22 Feb 2017 20:30:15 GMT):
For fabric-ca:

smithbk (Wed, 22 Feb 2017 20:30:17 GMT):
https://gerrit.hyperledger.org/r/6037 - Intermediate CA server support https://gerrit.hyperledger.org/r/6179 - Reflect to add server config flags https://gerrit.hyperledger.org/r/6243 - Docker images for client and server commands https://gerrit.hyperledger.org/r/6373 - Revendor cfssl for fabric-ca BCCSP integration

ashutosh_kumar (Wed, 22 Feb 2017 21:07:27 GMT):
@JonathanLevi 4363 is completely independent , not dependent on any other change set. So , it is safe to merge this.

ashutosh_kumar (Wed, 22 Feb 2017 21:09:03 GMT):
Where to put the examples of encrypted attributes ?

JonathanLevi (Wed, 22 Feb 2017 21:11:17 GMT):
If you have them, then let's wrap and add them as tests...

JonathanLevi (Wed, 22 Feb 2017 21:11:38 GMT):
(expected vs calculated) style

mastersingh24 (Wed, 22 Feb 2017 22:30:03 GMT):
@smithbk - some comments on a few of the items above

dave.enyeart (Thu, 23 Feb 2017 05:13:46 GMT):
Ledger items for review: https://gerrit.hyperledger.org/r/#/c/6365/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/5991/

hgabre (Thu, 23 Feb 2017 11:34:19 GMT):
Has joined the channel.

hgabre (Thu, 23 Feb 2017 11:34:32 GMT):
I would need some +2s for this fix here: https://gerrit.hyperledger.org/r/#/c/6025/

JonathanLevi (Thu, 23 Feb 2017 13:17:52 GMT):
@hgabre: hello, hello! You've got mine. One more to go.

vpaprots (Thu, 23 Feb 2017 15:36:33 GMT):
https://gerrit.hyperledger.org/r/#/c/5897/ +1 from Gari and Ale.. almost there!

smithbk (Thu, 23 Feb 2017 15:58:42 GMT):
@mastersingh24 @JonathanLevi The following are ready for your review again. Thanks.

smithbk (Thu, 23 Feb 2017 15:58:44 GMT):
https://gerrit.hyperledger.org/r/6037 - Intermediate CA server support https://gerrit.hyperledger.org/r/6179 - Reflect to add server config flags https://gerrit.hyperledger.org/r/6243 - Docker images for client and server commands

gennadyl (Thu, 23 Feb 2017 16:12:24 GMT):
https://gerrit.hyperledger.org/r/#/c/5909/ - gossip + leader election + deliver service. Review, plz

JonathanLevi (Thu, 23 Feb 2017 16:21:14 GMT):
@smithbk you got them all !

JonathanLevi (Thu, 23 Feb 2017 16:21:43 GMT):
We would really need to see a few integration tests... of using the Intermediate CA.

JonathanLevi (Thu, 23 Feb 2017 16:23:11 GMT):
I have `+2`'ed and we can perform/commit these separately, by you, or others - but I'd feel much better knowing that we have tried it and tested it ourselves.

latitiah (Thu, 23 Feb 2017 17:14:58 GMT):
https://gerrit.hyperledger.org/r/#/c/5657/ needs some +2's

mastersingh24 (Thu, 23 Feb 2017 17:41:46 GMT):
doc cleanup - https://gerrit.hyperledger.org/r/#/c/6441/ - basically the FAQ is outdated and will cause confusion for V1.0. We can add it back later, but for now this stuff is wrong

yacovm (Thu, 23 Feb 2017 18:00:36 GMT):
Easy one-liner https://gerrit.hyperledger.org/r/#/c/6443/

binhn (Thu, 23 Feb 2017 18:45:59 GMT):

Message Attachments

JonathanLevi (Thu, 23 Feb 2017 19:00:21 GMT):
@binhn Ha ha!

smithbk (Thu, 23 Feb 2017 19:07:34 GMT):
@JonathanLevi https://gerrit.hyperledger.org/r/#/c/6037/ is ready

JonathanLevi (Thu, 23 Feb 2017 19:46:21 GMT):
@smithbk I have approved it (again). For the record, I would have merged it with only one intermediate in the test. I think (in the future), we should a nice *integration test*... which shows the feature.

JonathanLevi (Thu, 23 Feb 2017 19:46:21 GMT):
@smithbk I have approved it (again). For the record, I would have merged it with only one intermediate in the test. I think (in the future), we should also add a nice *integration test*... which shows the feature.

rameshthoomu (Thu, 23 Feb 2017 20:21:19 GMT):
RTD build is failing.. easy fix https://gerrit.hyperledger.org/r/#/c/6449/

C0rWin (Fri, 24 Feb 2017 00:04:13 GMT):
pretty easy CR: https://gerrit.hyperledger.org/r/#/c/6445/, no need to open connection to ordering service for most of the peer CLI commands

C0rWin (Fri, 24 Feb 2017 00:05:21 GMT):
(need this to test reconnection to ordering service while joining channel)

jimthematrix (Fri, 24 Feb 2017 00:13:55 GMT):
http://gerrit.hyperledger.org/r/6457 - adding authentication to register() call

jimthematrix (Fri, 24 Feb 2017 00:14:16 GMT):
also, https://gerrit.hyperledger.org/r/#/c/6383/ - update to tests only

mastersingh24 (Fri, 24 Feb 2017 01:18:19 GMT):
@jimthematrix - made some comments on 6457

mastersingh24 (Fri, 24 Feb 2017 01:18:52 GMT):
@JonathanLevi @smithbk @cbf - https://gerrit.hyperledger.org/r/#/c/5897/

JonathanLevi (Fri, 24 Feb 2017 01:22:38 GMT):
@mastersingh24: merged 5897. @vpaprots: you may turn off that cron job that writes to me every 4 hours ;-)

vpaprots (Fri, 24 Feb 2017 01:22:58 GMT):
:D

vpaprots (Fri, 24 Feb 2017 01:23:27 GMT):
Ah, but I will have a whole slew more code for you in a few short minutes ;)

vpaprots (Fri, 24 Feb 2017 01:24:08 GMT):
fabric-ca now runs with bccsp on my laptop at least.. prettyfying

JonathanLevi (Fri, 24 Feb 2017 01:24:36 GMT):
Can't wait ;-). BTW: We should also document these, e.g. the bootBCCSP, motivation, etc.

mastersingh24 (Fri, 24 Feb 2017 01:25:03 GMT):
this is an automated message for @vpaprots : You have reached your limit code limit for the week. We thank you for your contributions and will look at your next set in about a week or so. Thanks for playing

vpaprots (Fri, 24 Feb 2017 01:25:15 GMT):
HA!

jimthematrix (Fri, 24 Feb 2017 01:44:37 GMT):
@mastersingh24 thanks for the review on 6457, I responded to our comments

gennadyl (Fri, 24 Feb 2017 08:45:00 GMT):
https://gerrit.hyperledger.org/r/#/c/5909/ - gossip + leader election + deliver service. Review, plz

yacovm (Fri, 24 Feb 2017 11:57:52 GMT):
https://gerrit.hyperledger.org/r/#/c/6477/ Makes gossip stop logging these annoying warning messages about connecting to a bootstrap peer that doesn't exist. Many complained on rocket.Chat and also from quality.

latitiah (Fri, 24 Feb 2017 17:15:31 GMT):
https://gerrit.hyperledger.org/r/#/c/5657/ - Needs +2s

ashutosh_kumar (Fri, 24 Feb 2017 19:50:14 GMT):
@JonathanLevi , incorporated your comments in https://gerrit.hyperledger.org/r/#/c/4363.Needs some love.

latitiah (Fri, 24 Feb 2017 20:26:50 GMT):
This is a small PR: https://gerrit.hyperledger.org/r/#/c/6499/

latitiah (Fri, 24 Feb 2017 20:29:46 GMT):
This PR updates the docker compose files to use the modified ordere environment variables (use configtx instead of genesis): https://gerrit.hyperledger.org/r/#/c/6501/

dave.enyeart (Fri, 24 Feb 2017 22:00:40 GMT):
Ledger items for review: https://gerrit.hyperledger.org/r/#/c/5991/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/6365/ https://gerrit.hyperledger.org/r/#/c/6377/

jimthematrix (Fri, 24 Feb 2017 22:10:21 GMT):
rounding out the fabric-ca client APIs (except re-enroll(), will revisit later): https://gerrit.hyperledger.org/r/#/c/6503/ - revoke certs by enroll ID or serial#+AKI https://gerrit.hyperledger.org/r/#/c/6511/ - more ca tests

muralisr (Fri, 24 Feb 2017 22:16:41 GMT):
CRs https://gerrit.hyperledger.org/r/#/c/6489/ https://gerrit.hyperledger.org/r/#/c/6379/ https://gerrit.hyperledger.org/r/#/c/5955/ should provide a stable commit level for the fabric with end to end function working with multiple MSPs, orgs and so forth....they have been reviewed, cherry picked and tested. Plan to test/merge these in within the next few hours. Unless urgent it'll be good to hold of other CRs till then

muralisr (Fri, 24 Feb 2017 22:17:31 GMT):
^^^ sdk CRs should be fine though

muralisr (Sat, 25 Feb 2017 00:03:34 GMT):
at `commit bb5a53f9c1f3c4427c1182ee6d93f7969ac40ebf` - confirm various tests pass after merging and testing. We can start working on other CRs now. Thanks for the patience!

gennadyl (Sat, 25 Feb 2017 14:59:35 GMT):
@yacovm @muralisr @mastersingh24 https://gerrit.hyperledger.org/r/#/c/5909/ - review, plz :pray:

yacovm (Sat, 25 Feb 2017 15:00:06 GMT):
You've got a merge conflict

gennadyl (Sat, 25 Feb 2017 15:31:00 GMT):
No, fixed it

yacovm (Sat, 25 Feb 2017 15:35:28 GMT):
OK. Well, master has changed quite a bit in the last 2 days, so I think it could be a good idea to test your change set on top of the new master, according to the instructions in Murali's email. Also- the docker-compose yaml file used in the e2e flow also needs to be changed if your change set gets in, so I guess it'll be a good idea to sync with him. The setup is complex enough, adding more entropy to it without proper testing and synchronization won't do anyone good

C0rWin (Sat, 25 Feb 2017 15:42:41 GMT):
@gennadyl @yacovm I'd agree w/ Yacov's arguments, we need to make sure to keep master clean

yacovm (Sat, 25 Feb 2017 15:44:14 GMT):
Also I commented on your change set, I think it'd be a good idea to parallelize the tests to reduce the time CI runs

C0rWin (Sat, 25 Feb 2017 15:47:43 GMT):
Having to check end-to-end for this CR will be enough :)

C0rWin (Sat, 25 Feb 2017 15:47:54 GMT):
We can parallelize in the separate

C0rWin (Sat, 25 Feb 2017 15:48:14 GMT):
Let's make sure it works w/ @muralisr instructions and let it in.

yacovm (Sat, 25 Feb 2017 15:56:32 GMT):
Whether this is in that or a next change set, I think we need to keep CI time to a minimum when we can.

C0rWin (Sat, 25 Feb 2017 16:04:23 GMT):
@yacovm agreed

dave.enyeart (Sat, 25 Feb 2017 16:13:12 GMT):
@mastersingh24 @binhn Could you review/merge these ledger CRs? None are too big or risky: https://gerrit.hyperledger.org/r/#/c/5991/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/6365/ https://gerrit.hyperledger.org/r/#/c/6377/ https://gerrit.hyperledger.org/r/#/c/6505/

dave.enyeart (Sat, 25 Feb 2017 16:13:12 GMT):
@mastersingh24 @binhn Could you review/merge these ledger CRs? None are too big or risky: https://gerrit.hyperledger.org/r/#/c/6365/ https://gerrit.hyperledger.org/r/#/c/5991/ https://gerrit.hyperledger.org/r/#/c/6051/ https://gerrit.hyperledger.org/r/#/c/6377/ https://gerrit.hyperledger.org/r/#/c/6505/

gennadyl (Sat, 25 Feb 2017 16:19:57 GMT):
@yacovm @C0rWin running e2e test right now

binhn (Sat, 25 Feb 2017 16:22:35 GMT):
@dave.enyeart ok

binhn (Sat, 25 Feb 2017 17:16:39 GMT):
@dave.enyeart i merge 1 and they all have conflict

sanchezl (Sat, 25 Feb 2017 21:19:20 GMT):
Has joined the channel.

sanchezl (Sat, 25 Feb 2017 21:19:53 GMT):
Need review on https://gerrit.hyperledger.org/r/6529 . Simple file permission change, but it block golang chaincode deployment.

sanchezl (Sat, 25 Feb 2017 21:19:53 GMT):
Need review on https://gerrit.hyperledger.org/r/6529 . Simple file permission change, but it blocks golang chaincode deployment.

muralisr (Sat, 25 Feb 2017 21:25:09 GMT):
done @sanchezl

muralisr (Sat, 25 Feb 2017 21:25:38 GMT):
need one more... and merge. I guess tests are failing because of this ?

muralisr (Sat, 25 Feb 2017 21:25:38 GMT):
need one more... and merge. I guess tests are failing because of perms ?

yacovm (Sat, 25 Feb 2017 21:30:13 GMT):
Pretty easy one (25 lines of real code, the rest is test) https://gerrit.hyperledger.org/r/#/c/6513/

yacovm (Sat, 25 Feb 2017 21:30:13 GMT):
Pretty easy one (25 lines of real production code, the rest is test) https://gerrit.hyperledger.org/r/#/c/6513/

yacovm (Sat, 25 Feb 2017 21:30:13 GMT):
Pretty easy one (25 lines of real production code, the rest is test) https://gerrit.hyperledger.org/r/#/c/6513/ Also 2 change sets for [FAB-2198] (Refactoring of Gossip to use signed envelopes), tested with e2e. https://gerrit.hyperledger.org/r/#/c/5965/ https://gerrit.hyperledger.org/r/#/c/6311/

yacovm (Sat, 25 Feb 2017 21:30:13 GMT):
2 change sets for [FAB-2198] (Refactoring of Gossip to use signed envelopes), tested with e2e. https://gerrit.hyperledger.org/r/#/c/5965/ https://gerrit.hyperledger.org/r/#/c/6311/

mastersingh24 (Sat, 25 Feb 2017 22:52:30 GMT):
@sanchezl @muralisr @greg.haskins - re: https://gerrit.hyperledger.org/r/#/c/6529/ - maybe this will work for something like Vagrant or will work if you only have fabric and fabric-ca in you $GOPATH/src, but due to https://gerrit.hyperledger.org/r/#/c/6059/3 we've made it 100% impossible for someone to run anything natively / outside of Docker if they have additional projects in their $GOPATH/src . And personally I am not going to go change all the file permissions of all of my Go projects

muralisr (Sat, 25 Feb 2017 22:56:50 GMT):
@mastersingh24 I remember discussion with @greg.haskins on this... and (correct me if I misremember Greg) the decision was to make it strict and revisit if it becomes painful... maybe time has come to revisit

mastersingh24 (Sat, 25 Feb 2017 23:00:28 GMT):
well I think there *might* be a larger problem in that the CLI commands which package chaincode end up believing that $GOPATH/src contains only the chaincode you want to deploy

mastersingh24 (Sat, 25 Feb 2017 23:00:34 GMT):
that's the real issue

mastersingh24 (Sat, 25 Feb 2017 23:01:30 GMT):
so for example any of the tests which involve chaincode install/deploy will fail when run directly vi `go test` in the package folder if you have multiple projects in your $GOLANG/src folder

mastersingh24 (Sat, 25 Feb 2017 23:02:18 GMT):
so not sure which *problem* to fix or maybe we don't care :(

mastersingh24 (Sat, 25 Feb 2017 23:02:50 GMT):
I mean I love fabric, but I do have other Go projects on my laptop

muralisr (Sat, 25 Feb 2017 23:06:22 GMT):
right :-).. we will run into this for sure in dev envs

mastersingh24 (Sat, 25 Feb 2017 23:08:43 GMT):
well I'll try to get to it tomorrow. I think I'm too old to take redeyes (took one home from PHX last night)

jimthematrix (Sun, 26 Feb 2017 00:46:21 GMT):
how do you debug peer code these days? i used to be able to use a command like below in the `peer` folder to debug (albeit a long while ago): ``` CORE_PEER_ID=vp0 CORE_PEER_PROFILE_ENABLED=true CORE_PEER_COMMITTER_LEDGER_ORDERER=localhost:7050 CORE_PEER_MSPCONFIGPATH=/Users/jimzhang/workspace/go/src/github.com/hyperledger/fabric/msp/sampleconfig/ dlv debug -- node start ``` but now it panics and exits

jimthematrix (Sun, 26 Feb 2017 00:46:50 GMT):
``` 2017-02-25 19:23:43.512 EST [msp] Validate -> INFO 018 MSP DEFAULT validating identity 2017-02-25 19:23:43.512 EST [gossip/gossip#0.0.0.0:7051] NewGossipService -> WARN 019 External endpoint is empty, peer will not be accessible outside of its organization 2017-02-25 19:23:43.512 EST [gossip/gossip#0.0.0.0:7051] Stop -> INFO 01b Stopping gossip 2017-02-25 19:23:43.512 EST [gossip/discovery#0.0.0.0:7051] Stop -> INFO 01c Stopping 2017-02-25 19:23:43.512 EST [gossip/gossip#0.0.0.0:7051] start -> INFO 01a Gossip instance 0.0.0.0:7051 started 2017-02-25 19:23:43.512 EST [gossip/discovery#0.0.0.0:7051] Stop -> INFO 01e Stopped 2017-02-25 19:23:43.512 EST [gossip/comm#-1] Stop -> INFO 01d Stopping 2017-02-25 19:23:43.512 EST [gossip/comm#-1] 1 -> WARN 01f Recovered 2017-02-25 19:23:43.512 EST [gossip/comm#-1] Stop -> INFO 020 Stopped panic: ---empty version---(chain=,chaincode=cscc,version=,txid=d14f1427-d73c-4066-9ce6-7a0c9e7672b9,syscc=true,proposal=0x0 goroutine 1 [running]: github.com/hyperledger/fabric/core/common/ccprovider.NewCCContext(0x0, 0x0, 0x4870c67, 0x4, 0x0, 0x0, 0xc4202fb7d0, 0x24, 0x4498d01, 0x0, ...) /Users/jimzhang/workspace/go/src/github.com/hyperledger/fabric/core/common/ccprovider/ccprovider.go:202 +0x9c8 github.com/hyperledger/fabric/core/chaincode.(*ccProviderImpl).GetCCContext(0xc4217c9d80, 0x0, 0x0, 0x4870c67, 0x4, 0x0, 0x0, 0xc4202fb7d0, 0x24, 0xc42001f301, ...) /Users/jimzhang/workspace/go/src/github.com/hyperledger/fabric/core/chaincode/ccproviderimpl.go:71 +0xb3 github.com/hyperledger/fabric/core/scc.deploySysCC(0x0, 0x0, 0x4c66f00, 0x0, 0x0) /Users/jimzhang/workspace/go/src/github.com/hyperledger/fabric/core/scc/sysccapi.go:121 +0x515 github.com/hyperledger/fabric/core/scc.DeploySysCCs(0x0, 0x0) /Users/jimzhang/workspace/go/src/github.com/hyperledger/fabric/core/scc/importsysccs.go:79 +0x65 github.com/hyperledger/fabric/peer/node.initSysCCs() /Users/jimzhang/workspace/go/src/github.com/hyperledger/fabric/peer/node/start.go:82 +0x33 github.com/hyperledger/fabric/peer/node.serve(0x4c8f358, 0x0, 0x0, 0x0, 0x0) /Users/jimzhang/workspace/go/src/github.com/hyperledger/fabric/peer/node/start.go:162 +0x978```

greg.haskins (Sun, 26 Feb 2017 01:15:03 GMT):
@mastersingh24 @muralisr I think there are two problems

greg.haskins (Sun, 26 Feb 2017 01:16:24 GMT):
1) the SDK/CLI should be using "go list" to determine only exactly the list of packages required rather than assuming $GOPATH/*

greg.haskins (Sun, 26 Feb 2017 01:16:54 GMT):
(See scripts/goListDeps.sh for concept)

greg.haskins (Sun, 26 Feb 2017 01:18:03 GMT):
2) once the minimal set is ascertained, the SDK/CLI should be managing how the tarball is formed, including filtering bogus mode bits

greg.haskins (Sun, 26 Feb 2017 01:18:35 GMT):
IMHO

greg.haskins (Sun, 26 Feb 2017 01:20:18 GMT):
For reference: https://dave.cheney.net/2014/09/14/go-list-your-swiss-army-knife

muralisr (Sun, 26 Feb 2017 01:56:37 GMT):
@jimthematrix it needs `-ldflags "-X github.com/hyperledger/fabric/common/metadata.Version=0.7.0-snapshot- -X github.com/hyperledger/fabric/common/metadata.BaseVersion=0.3.0"`

jimthematrix (Sun, 26 Feb 2017 01:57:09 GMT):
thanks will try that

muralisr (Sun, 26 Feb 2017 01:57:29 GMT):
(not sure how'll you'll supply it though...)

weeds (Sun, 26 Feb 2017 02:59:54 GMT):
@mastersingh24 if you are "too old to take redeyes" than I must be ancient as after trip to UK i was falling asleep at 8pm- embarrassing.

jimthematrix (Sun, 26 Feb 2017 08:15:24 GMT):
http://gerrit.hyperledger.org/r/6543 for the signature (and txId generation) issue related to using SHA2/3 256 at various points

jimthematrix (Sun, 26 Feb 2017 08:16:17 GMT):
@rickr @pmullaney @bretharrison @cdaughtr ^^^

bretharrison (Sun, 26 Feb 2017 08:16:17 GMT):
Has joined the channel.

rickr (Sun, 26 Feb 2017 08:16:17 GMT):
Has joined the channel.

cdaughtr (Sun, 26 Feb 2017 08:16:17 GMT):
Has joined the channel.

yacovm (Sun, 26 Feb 2017 10:32:26 GMT):
2 change sets for [FAB-2198] (Refactoring of Gossip to use signed envelopes), tested with e2e. https://gerrit.hyperledger.org/r/#/c/5965/ https://gerrit.hyperledger.org/r/#/c/6311/

yacovm (Sun, 26 Feb 2017 11:32:09 GMT):
Also, https://gerrit.hyperledger.org/r/#/c/6445/ : _ Prevent CLI to connect to ordering service on join. _ courtesy of @C0rWin

mastersingh24 (Sun, 26 Feb 2017 12:30:31 GMT):
easy one - just some naming cleanup for the node sdk - https://gerrit.hyperledger.org/r/#/c/6545/ ( @jimthematrix FYI)

mastersingh24 (Sun, 26 Feb 2017 12:31:27 GMT):
https://gerrit.hyperledger.org/r/#/c/6449/ - can someone else +2 this one (it correct something I missed when deleting the FAQ from the docs)

muralisr (Sun, 26 Feb 2017 14:14:49 GMT):
+2ed and merged 6449 @mastersingh24

dave.enyeart (Sun, 26 Feb 2017 14:15:12 GMT):
@muralisr @mastersingh24 @binhn The next ledger CR to get untangled from merge/verification conflicts is: https://gerrit.hyperledger.org/r/#/c/6505/

muralisr (Sun, 26 Feb 2017 14:18:03 GMT):
thanks @dave.enyeart ...+2ed

jimthematrix (Sun, 26 Feb 2017 15:12:37 GMT):
https://gerrit.hyperledger.org/r/#/c/6543/ - critical fix uploaded last night but forgot to update the test case

jimthematrix (Sun, 26 Feb 2017 15:13:05 GMT):
@mastersingh24 @cbf @binhn @muralisr ^^^

muralisr (Sun, 26 Feb 2017 15:13:54 GMT):
awesome, Jim...!

muralisr (Sun, 26 Feb 2017 15:13:59 GMT):
+2ed

muralisr (Sun, 26 Feb 2017 15:14:03 GMT):
(thanks!)

kostas (Sun, 26 Feb 2017 15:23:58 GMT):
A set of simple, non-debatable (hopefully) changesets: https://gerrit.hyperledger.org/r/#/c/5857/ https://gerrit.hyperledger.org/r/#/c/6175/ https://gerrit.hyperledger.org/r/#/c/6465/ https://gerrit.hyperledger.org/r/#/c/6525/ https://gerrit.hyperledger.org/r/#/c/6527/ https://gerrit.hyperledger.org/r/#/c/6533/ https://gerrit.hyperledger.org/r/#/c/6535/

nickgaski (Sun, 26 Feb 2017 15:40:37 GMT):
tx flow diagram with explanation of the steps - https://gerrit.hyperledger.org/r/#/c/6461/

mastersingh24 (Sun, 26 Feb 2017 16:40:39 GMT):
@kostas - haven't you learned by now that anything is debatable? But I laud your optimism ;)

kostas (Sun, 26 Feb 2017 19:40:09 GMT):
@mastersingh24 (Sigh, too true.)

AdnanC (Sun, 26 Feb 2017 20:06:14 GMT):
Has joined the channel.

yacovm (Sun, 26 Feb 2017 21:27:47 GMT):
@kostas all but the 1st (merge conflict) are merged

kostas (Sun, 26 Feb 2017 21:48:02 GMT):
@yacovm: Thanks! Will take care of that one as well tomorrow.

dave.enyeart (Sun, 26 Feb 2017 23:14:05 GMT):
@muralisr @mastersingh24 @binhn The next ledger CR to get untangled from merge/verification conflicts is: https://gerrit.hyperledger.org/r/#/c/6505

mastersingh24 (Sun, 26 Feb 2017 23:20:49 GMT):
@dave.enyeart - so can I assume that the fact that this now throw an error is actually handled when the peer tries to initialize the ledger and that's when peer startup is aborted?

mastersingh24 (Sun, 26 Feb 2017 23:21:14 GMT):
code looks fine otherwise

dave.enyeart (Sun, 26 Feb 2017 23:24:36 GMT):
yes, i tested with peer and it aborts upon peer startup with a clear error message that it cant connect to couch

muralisr (Mon, 27 Feb 2017 00:02:20 GMT):
done @dave.enyeart

dave.enyeart (Mon, 27 Feb 2017 00:02:26 GMT):
thanks!

jimthematrix (Mon, 27 Feb 2017 04:38:05 GMT):
http://gerrit.hyperledger.org/r/6555 - fixed chaincode packaging to comply to peer's content checking (file paths, permissions) @greg.haskins @mastersingh24

jimthematrix (Mon, 27 Feb 2017 04:58:59 GMT):
https://gerrit.hyperledger.org/r/#/c/6557/ - fixes chaincode instantiate failures due to missing "path" field (wasn't required until recently)

dave.enyeart (Mon, 27 Feb 2017 07:03:57 GMT):
@muralisr @mastersingh24 @binhn The next (and last!) ledger CR to get untangled from merge/verification conflicts is:

dave.enyeart (Mon, 27 Feb 2017 07:03:57 GMT):
@muralisr @mastersingh24 @binhn The next ledger CR to get untangled from merge/verification conflicts is:

dave.enyeart (Mon, 27 Feb 2017 07:04:12 GMT):
https://gerrit.hyperledger.org/r/#/c/6365/

shibo.lin (Mon, 27 Feb 2017 07:31:04 GMT):
Has joined the channel.

yacovm (Mon, 27 Feb 2017 09:49:33 GMT):
_ [FAB-2424] Enforce MSP channel validation in gossip _ https://gerrit.hyperledger.org/r/#/c/6393/ Tested with @muralisr 's end-to-end guide

dave.enyeart (Mon, 27 Feb 2017 10:22:56 GMT):
@muralisr @mastersingh24 @binhn https://gerrit.hyperledger.org/r/#/c/6561/

JonathanLevi (Mon, 27 Feb 2017 11:31:52 GMT):
@Hangyu Hi, all.. I tried to commit a changset to gerrit but failed at the compiling phase (got a -1 from Jobbuilder). This is a very trivial changset involves removing unused code. I tried twice but both were verified with failure (and the error messages ere different). Could anyone so kindly give me some advises on this? JonathanLevi Hello @Hangyu! 1. Absolutely. 2. What CR? 3. Let's take it to the #fabric-pr-review channel?

Hangyu (Mon, 27 Feb 2017 11:31:52 GMT):
Has joined the channel.

hgabre (Mon, 27 Feb 2017 12:10:56 GMT):
https://gerrit.hyperledger.org/r/#/c/4861/4 according to the author, this needs some testing/help from ppc64 side

yacovm (Mon, 27 Feb 2017 12:19:56 GMT):
_ [FAB-2424] Enforce MSP channel validation in gossip _ https://gerrit.hyperledger.org/r/#/c/6393/ Tested end-to-end flow

dave.enyeart (Mon, 27 Feb 2017 12:49:09 GMT):
@muralisr @mastersingh24 @binhn @jimthematrix Here's the change for GetTransactionById to return invalidation reason: https://gerrit.hyperledger.org/r/#/c/5995/

latitiah (Mon, 27 Feb 2017 13:02:06 GMT):
PRs for review: https://gerrit.hyperledger.org/r/#/c/6499/ https://gerrit.hyperledger.org/r/#/c/6501/

latitiah (Mon, 27 Feb 2017 13:05:02 GMT):
https://gerrit.hyperledger.org/r/#/c/6117

hgabre (Mon, 27 Feb 2017 13:45:21 GMT):
hi @latitiah , have you tried 6501 locally/somehow?

jimthematrix (Mon, 27 Feb 2017 13:58:32 GMT):
https://gerrit.hyperledger.org/r/#/c/6555/ - addressed @yacovm 's comment

latitiah (Mon, 27 Feb 2017 14:03:06 GMT):
@hgabre : Yes, I am updating/adding behave tests and have been using these docker compositions to get those done

hgabre (Mon, 27 Feb 2017 14:03:41 GMT):
@latitiah it looks OK, so +2

hgabre (Mon, 27 Feb 2017 14:03:54 GMT):
btw it needs rebase

latitiah (Mon, 27 Feb 2017 14:04:01 GMT):
Though I do see that it needs to be rebased with master. I'll do that and post again

latitiah (Mon, 27 Feb 2017 14:04:05 GMT):
:)

dave.enyeart (Mon, 27 Feb 2017 14:20:45 GMT):
@muralisr @mastersingh24 @binhn Summary of the remaining ledger review requests: Get CouchDB tests working in CI environment: https://gerrit.hyperledger.org/r/#/c/6365/ Return invalidation reason code in GetTransactionById: https://gerrit.hyperledger.org/r/#/c/5995/ State db recovery: https://gerrit.hyperledger.org/r/#/c/6561/

weeds (Mon, 27 Feb 2017 14:23:50 GMT):
@cbf working on increasing coverage for testing ^^

cbf (Mon, 27 Feb 2017 14:24:05 GMT):
yes, please

weeds (Mon, 27 Feb 2017 14:24:42 GMT):
@cbf Dave may need your help on getting reviews completed

latitiah (Mon, 27 Feb 2017 14:35:32 GMT):
@hgabre: rebase completed - thx!

skarim (Mon, 27 Feb 2017 14:43:55 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/6005/

mastersingh24 (Mon, 27 Feb 2017 15:38:08 GMT):
https://gerrit.hyperledger.org/r/#/c/6273/ - easy one to update bccsp vendoring on fabric-ca

jimthematrix (Mon, 27 Feb 2017 15:43:15 GMT):
https://gerrit.hyperledger.org/r/#/c/6569/ - allow fabric-ca-client to use per-instance crypto parameters (and could be different than what's used for fabric-client talking to peers and orderers)

yacovm (Mon, 27 Feb 2017 15:58:56 GMT):
* [FAB-2424] Enforce MSP channel validation in gossip * https://gerrit.hyperledger.org/r/#/c/6393/ Tested in end-to-end flow

JonathanLevi (Mon, 27 Feb 2017 17:27:34 GMT):
@smithbk, @mastersingh24, re: https://gerrit.hyperledger.org/r/#/c/6547

JonathanLevi (Mon, 27 Feb 2017 17:28:29 GMT):
Maybe I was "late to the game" as I took a look at ps2, which was uploaded after you two agreed that only one attempt of decoding will be made.... but if we take a step back, we seem to create 2 extra functions that are a single line each.

JonathanLevi (Mon, 27 Feb 2017 17:28:29 GMT):
Maybe I was "late to the game" as I first took a look at this CR when it was already at patchset 2, which was uploaded after you two agreed that only one attempt of decoding will be made.... but, if we take a step back, we seem to create 2 extra functions that are a single line each.

JonathanLevi (Mon, 27 Feb 2017 17:30:11 GMT):
, if we take a step back, we seem to create 2 extra functions that are a single line each.

JonathanLevi (Mon, 27 Feb 2017 17:31:07 GMT):
Is *util.B64Decode(str)* clearer than *base64.StdEncoding.DecodeString(str)* ?

JonathanLevi (Mon, 27 Feb 2017 17:31:07 GMT):
Now, is *util.B64Decode(str)* clearer, more intuitive, easier to look-up, than *base64.StdEncoding.DecodeString(str)* ?

vpaprots (Mon, 27 Feb 2017 18:14:56 GMT):
https://gerrit.hyperledger.org/r/#/c/6273/ already has +2 from Gari!

varadatibm (Mon, 27 Feb 2017 18:56:39 GMT):
Has joined the channel.

smithbk (Mon, 27 Feb 2017 19:13:37 GMT):
@JonathanLevi The main reason for the simple functions are to have a single place that needs to be changed should we need to

JonathanLevi (Mon, 27 Feb 2017 19:14:16 GMT):
Sure thing. Discussed it with Gari & merged.

JonathanLevi (Mon, 27 Feb 2017 19:15:16 GMT):
Thank you for the clarification (yes, it is more "unified" if everything calls it).

daveryIBM (Mon, 27 Feb 2017 19:45:45 GMT):
Has joined the channel.

jimthematrix (Mon, 27 Feb 2017 21:34:45 GMT):
https://gerrit.hyperledger.org/r/#/c/6569/ - allow fabric-ca-client to use per-instance crypto parameters (and could be different than what's used for fabric-client talking to peers and orderers) https://gerrit.hyperledger.org/r/#/c/6585/ - for SHA3->SHA2 default change

dave.enyeart (Tue, 28 Feb 2017 02:21:13 GMT):
fix for state db recovery: https://gerrit.hyperledger.org/r/#/c/6561/

dave.enyeart (Tue, 28 Feb 2017 02:21:42 GMT):
logging improvements for serviceability: https://gerrit.hyperledger.org/r/#/c/6599/

gennadyl (Tue, 28 Feb 2017 08:27:00 GMT):
https://gerrit.hyperledger.org/r/#/c/5909/ - new change set. Now it pass e2e scenario both using leader election to connect to orderer and static peer configuration to connect to orderer. Please review

gennadyl (Tue, 28 Feb 2017 12:07:19 GMT):
https://gerrit.hyperledger.org/r/#/c/6621/ - small change set. Just fix logs output

greg.haskins (Tue, 28 Feb 2017 14:31:18 GMT):
trivial one: https://gerrit.hyperledger.org/r/#/c/6467/

greg.haskins (Tue, 28 Feb 2017 14:31:38 GMT):
@jimthematrix any thoughts on: https://gerrit.hyperledger.org/r/#/c/6583/ ?

skarim (Tue, 28 Feb 2017 14:59:36 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/6005/ https://gerrit.hyperledger.org/r/#/c/6031/

jimthematrix (Tue, 28 Feb 2017 15:23:40 GMT):
@greg.haskins i like the streaming approach (was thinking about the same myself), let me give 6583 a more in-depth look and will let you know

greg.haskins (Tue, 28 Feb 2017 15:37:51 GMT):
@jimthematrix ty

C0rWin (Tue, 28 Feb 2017 16:00:01 GMT):
simple cleaning of messages and errors formatting: https://gerrit.hyperledger.org/r/#/c/6637/1

jimthematrix (Tue, 28 Feb 2017 16:57:53 GMT):
@greg.haskins added my review comment, code looks good (and works great)! only have one request for a simple update

yacovm (Tue, 28 Feb 2017 17:04:58 GMT):
3 change sets to be merged: 1) https://gerrit.hyperledger.org/r/#/c/6623/ Fixes a thread-safety issue when the gossip comm layer is shut down The 2 below are the last items for FAB-2424 - * Make sure remote peer is authorized (is indeed in the channel) to ask for blocks of a channel * 2) https://gerrit.hyperledger.org/r/#/c/6595/ : ran e2e test today to make sure it doesn't break anything. 3) The above (2) depends on https://gerrit.hyperledger.org/r/#/c/6593/ - Just extends an inner interface of the gossip comm layer, nothing that effects functionality.

murrekatt (Tue, 28 Feb 2017 17:08:00 GMT):
please review and merge this minor change https://gerrit.hyperledger.org/r/#/c/6639/

greg.haskins (Tue, 28 Feb 2017 17:52:14 GMT):
@jimthematrix two easy ones: https://gerrit.hyperledger.org/r/#/c/6591/

greg.haskins (Tue, 28 Feb 2017 17:52:24 GMT):
https://gerrit.hyperledger.org/r/#/c/6641/

jimthematrix (Tue, 28 Feb 2017 18:11:50 GMT):
@greg.haskins merged 6591, need a change for 6641

bretharrison (Tue, 28 Feb 2017 18:14:48 GMT):
Has left the channel.

kostas (Tue, 28 Feb 2017 19:36:26 GMT):
To the maintainers who review: what's up with the pattern of `foo/foobar/` (or `foo/barfoo`) that seems to be the norm across the codebase? Why is this sort of stuttering allowed?

yacovm (Tue, 28 Feb 2017 19:43:07 GMT):
you mean packages and file names?

kostas (Tue, 28 Feb 2017 19:44:32 GMT):
Filenames, but the same rule applies to packages.

kostas (Tue, 28 Feb 2017 19:44:36 GMT):
`foo/bar` where the package `bar` will be imported as `foobar` by a consumer not in that tree is the only sane way of going at it.

mastersingh24 (Tue, 28 Feb 2017 20:22:39 GMT):
@kostas - I think I know what you mean, but can you point at a real example? (perhaps what made you post this)

kostas (Tue, 28 Feb 2017 20:23:36 GMT):
@mastersingh24: https://github.com/hyperledger/fabric/tree/master/core/scc and all the `*cc` inside is a good example of this.

kostas (Tue, 28 Feb 2017 20:23:49 GMT):
I got more -- hold on.

kostas (Tue, 28 Feb 2017 20:25:00 GMT):
https://github.com/hyperledger/fabric/tree/master/common/ledger/blkstorage/fsblkstorage

kostas (Tue, 28 Feb 2017 20:25:17 GMT):
(^^ This is actually what prompted me to post this.)

kostas (Tue, 28 Feb 2017 20:25:52 GMT):
And of course in our `orderer` package we have some stuttering with `ledger/orderledger`, etc. that I will most definitely get rid of.

kostas (Tue, 28 Feb 2017 20:26:35 GMT):
So, going to the `scc/lccc` example: `lccc` should be renamed `lifecycle`, and that should be the name of the package as well.

kostas (Tue, 28 Feb 2017 20:26:35 GMT):
So, going to the `scc/lccc` example: `lccc` should be renamed to `lifecycle`, and that should be the name of the package as well.

kostas (Tue, 28 Feb 2017 20:27:30 GMT):
Everyone else who wishes to import `lifecycle` may import it as `lccc` (via aliasing) if they choose to do so.

mastersingh24 (Tue, 28 Feb 2017 20:27:30 GMT):
yep - makes sense

mastersingh24 (Tue, 28 Feb 2017 20:28:15 GMT):
my complaints start at a different level - common,core, core/common, peer, core/peer, etc

mastersingh24 (Tue, 28 Feb 2017 20:28:29 GMT):
sh*t all over the place

greg.haskins (Tue, 28 Feb 2017 20:38:00 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=KCKCSKbbh6Z9EZned) @kostas I had this exact thought this morning

muralisr (Tue, 28 Feb 2017 21:45:03 GMT):
but lifcycle of what ?

yacovm (Tue, 28 Feb 2017 21:45:24 GMT):
lifecycle is under chaincode so it can be implicitly derived I guess

muralisr (Tue, 28 Feb 2017 21:45:25 GMT):
to be exact, lifecyclechaincode

muralisr (Tue, 28 Feb 2017 21:45:31 GMT):
ie, lccc :-)

greg.haskins (Tue, 28 Feb 2017 21:47:46 GMT):
I agree with @kostas on this one, the relationship in the tree can convey appropriate meaning

greg.haskins (Tue, 28 Feb 2017 21:48:29 GMT):
so ./systemchaincode/lifecycle is better than stuttering

greg.haskins (Tue, 28 Feb 2017 21:48:37 GMT):
or whatever

greg.haskins (Tue, 28 Feb 2017 21:48:58 GMT):
but also, lifecycle* is better than lccc

greg.haskins (Tue, 28 Feb 2017 21:49:10 GMT):
people are always asking me what that acronym is

greg.haskins (Tue, 28 Feb 2017 21:49:14 GMT):
;)

greg.haskins (Tue, 28 Feb 2017 21:49:50 GMT):
to be clear, I am primarily referring to the fs hierarchy...i have no problem with "lccc" as the chaincodeID

kostas (Tue, 28 Feb 2017 22:26:57 GMT):
@muralisr: As Greg and Yacov have noted, the tree conveys the meaning.

kostas (Tue, 28 Feb 2017 22:27:56 GMT):
As I have also noted, if you have someone consuming this package outside the `scc/*` tree, then they may import `scc/lifecycle` as `lccc` (or whatever name they wish really).

kostas (Tue, 28 Feb 2017 22:28:35 GMT):
But it is simply wrong to do `scc/lccc/`, you have folder hierarchy there for a reason.

kostas (Tue, 28 Feb 2017 22:28:35 GMT):
But it is simply wrong to do `scc/lccc/`, you have a folder hierarchy there for a reason.

yacovm (Tue, 28 Feb 2017 22:31:13 GMT):
https://golang.org/pkg/#subrepo

binhn (Tue, 28 Feb 2017 23:32:25 GMT):
Please help review and merge these fixes https://gerrit.hyperledger.org/r/#/c/6595 https://gerrit.hyperledger.org/r/#/c/6563 https://gerrit.hyperledger.org/r/#/c/6561 https://gerrit.hyperledger.org/r/#/c/6593 https://gerrit.hyperledger.org/r/#/c/6623 doc https://gerrit.hyperledger.org/r/#/c/5623

norinos (Wed, 01 Mar 2017 01:42:46 GMT):
Has joined the channel.

jimthematrix (Wed, 01 Mar 2017 05:31:30 GMT):
http://gerrit.hyperledger.org/r/6663 - node sdk test sandbox needed for an end-to-end that include create/join channel

dave.enyeart (Wed, 01 Mar 2017 07:27:48 GMT):
@mastersingh24 @muralisr Got a +2 already, please review/merge:

dave.enyeart (Wed, 01 Mar 2017 07:28:07 GMT):
https://gerrit.hyperledger.org/r/#/c/6561/ https://gerrit.hyperledger.org/r/#/c/6563/

murrekatt (Wed, 01 Mar 2017 10:08:10 GMT):
please merge https://gerrit.hyperledger.org/r/#/c/6639/ thanks!

muralisr (Wed, 01 Mar 2017 13:12:04 GMT):
@cbf @mastersingh24 https://gerrit.hyperledger.org/r/#/c/6661/ Skips some overlapping chaincode tests

muralisr (Wed, 01 Mar 2017 13:13:22 GMT):
it brings down the time to 133 secs compared with a random 610secs (a random console...but I think its consistent)

muralisr (Wed, 01 Mar 2017 13:13:28 GMT):
```04:48:50 [32munit-tests_1 |[0m ok github.com/hyperledger/fabric/core/chaincode 133.716s coverage: 55.9% of statements 05:21:12 [32munit-tests_1 |[0m ok github.com/hyperledger/fabric/core/chaincode 610.368s coverage: 55.6% of statements```

muralisr (Wed, 01 Mar 2017 13:14:33 GMT):
note that the coverage has changed very little - which bears out the rationale for the test that we are just skipping "overlapping"

muralisr (Wed, 01 Mar 2017 13:14:33 GMT):
note that the coverage has changed very little - which bears out the rationale for the change that we are just skipping "overlapping"

muralisr (Wed, 01 Mar 2017 13:16:24 GMT):
@yacovm do take a look too please :-)

yacovm (Wed, 01 Mar 2017 13:16:31 GMT):
I did

yacovm (Wed, 01 Mar 2017 13:17:06 GMT):
Still trying to figure out if I'm dreaming or not

yacovm (Wed, 01 Mar 2017 13:19:08 GMT):
I did, astonished from the low runtime

muralisr (Wed, 01 Mar 2017 13:19:14 GMT):
me too actually

muralisr (Wed, 01 Mar 2017 13:19:37 GMT):
there's something there thats worth digging into ...and will

muralisr (Wed, 01 Mar 2017 13:21:03 GMT):
it could be that we are not using new chaincodes so less burden on docker (very loose statement, that... but first one that popped into the head)

muralisr (Wed, 01 Mar 2017 13:21:45 GMT):
let me compare other tests in those two runs...

muralisr (Wed, 01 Mar 2017 13:24:13 GMT):
pretty much in the ball park I'd say

muralisr (Wed, 01 Mar 2017 13:24:24 GMT):
anyway, there you have it :-)

binhn (Wed, 01 Mar 2017 14:26:23 GMT):
@muralisr +1

dave.enyeart (Wed, 01 Mar 2017 15:10:05 GMT):
Defect fix for couch rich queries: https://gerrit.hyperledger.org/r/#/c/6671/

smithbk (Wed, 01 Mar 2017 17:38:01 GMT):
Hi, several fabric-ca change sets to be reviewed ... thanks:

smithbk (Wed, 01 Mar 2017 17:38:39 GMT):
1. https://gerrit.hyperledger.org/r/#/c/6005/ 2. https://gerrit.hyperledger.org/r/#/c/6031/ 3. https://gerrit.hyperledger.org/r/#/c/6375/ 4. https://gerrit.hyperledger.org/r/#/c/6567/ 5. https://gerrit.hyperledger.org/r/#/c/6577/

muralisr (Wed, 01 Mar 2017 19:38:25 GMT):
This is a easy bug fix https://gerrit.hyperledger.org/r/#/c/6263/ please

jimthematrix (Wed, 01 Mar 2017 20:38:54 GMT):
https://gerrit.hyperledger.org/r/#/c/6663/ - node sdk test sandbox needed for an end-to-end that include create/join channel with non-default setup

dave.enyeart (Wed, 01 Mar 2017 21:59:34 GMT):
Defect to fix history db if transaction was invalidated: https://gerrit.hyperledger.org/r/#/c/6685/

mastersingh24 (Wed, 01 Mar 2017 22:04:50 GMT):
a little love for https://gerrit.hyperledger.org/r/#/c/6635/ ( @jimthematrix @cbf @yacovm ) want to add some more stuff but while it's passing CI would like to get it in ;)

jimthematrix (Wed, 01 Mar 2017 22:05:36 GMT):
you got my +2 already!

jimthematrix (Wed, 01 Mar 2017 22:05:36 GMT):
you got my +2 already! :thumbsup:

mastersingh24 (Wed, 01 Mar 2017 22:06:12 GMT):
do you want https://gerrit.hyperledger.org/r/#/c/6663/ merged?

jimthematrix (Wed, 01 Mar 2017 22:06:22 GMT):
haha just about to ask

jimthematrix (Wed, 01 Mar 2017 22:06:25 GMT):
yes please

mastersingh24 (Wed, 01 Mar 2017 22:06:36 GMT):
done

jimthematrix (Wed, 01 Mar 2017 22:06:41 GMT):
thanks

yacovm (Wed, 01 Mar 2017 22:36:59 GMT):
@mastersingh24 merged. Can anyone please take a look at https://gerrit.hyperledger.org/r/#/c/6689/ ? `+274, -53` but `191` of it is test code I added...

C0rWin (Wed, 01 Mar 2017 22:45:55 GMT):
getting rid of using environmental variables in peer cli https://gerrit.hyperledger.org/r/#/c/6691/, instead of `CORE_PEER_COMMITTER_LEDGER_ORDERER` simple command line key -o added i.e. `peer channel create -o orderer:port ...`

Donald Liu (Thu, 02 Mar 2017 01:24:41 GMT):
Has joined the channel.

scottz (Thu, 02 Mar 2017 02:21:15 GMT):
looking for love... https://gerrit.hyperledger.org/r/#/c/6575/ and now also https://gerrit.hyperledger.org/r/#/c/6713/ . Includes rebase/integration fixes for tests to be used for CI. Thanks! I know everyone is working so hard!

kostas (Thu, 02 Mar 2017 03:12:41 GMT):
A series of changesets related to the orderer/ledger package: https://gerrit.hyperledger.org/r/#/c/5857/ https://gerrit.hyperledger.org/r/#/c/5929/ https://gerrit.hyperledger.org/r/#/c/6693/ https://gerrit.hyperledger.org/r/#/c/6693/ https://gerrit.hyperledger.org/r/#/c/6697/ https://gerrit.hyperledger.org/r/#/c/6699/

kostas (Thu, 02 Mar 2017 03:12:41 GMT):
A series of changesets related to the `orderer/ledger` package: https://gerrit.hyperledger.org/r/#/c/5857/ https://gerrit.hyperledger.org/r/#/c/5929/ https://gerrit.hyperledger.org/r/#/c/6693/ https://gerrit.hyperledger.org/r/#/c/6693/ https://gerrit.hyperledger.org/r/#/c/6697/ https://gerrit.hyperledger.org/r/#/c/6699/

kostas (Thu, 02 Mar 2017 03:12:41 GMT):
A series of changesets related to the orderer/ledger package: https://gerrit.hyperledger.org/r/#/c/5857/ https://gerrit.hyperledger.org/r/#/c/5929/ (UPDATE: waiting for a clarification on this one, so let's hold off for a sec -- updated the CR accordingly) https://gerrit.hyperledger.org/r/#/c/6693/ https://gerrit.hyperledger.org/r/#/c/6693/ https://gerrit.hyperledger.org/r/#/c/6697/ https://gerrit.hyperledger.org/r/#/c/6699/

gennadyl (Thu, 02 Mar 2017 09:43:47 GMT):
https://gerrit.hyperledger.org/r/#/c/6729/ - small change, just skip one test, till I check it.

mastersingh24 (Thu, 02 Mar 2017 14:40:55 GMT):
@jeffgarratt - https://gerrit.hyperledger.org/r/#/c/6389/ - should we be merging this?

jeffgarratt (Thu, 02 Mar 2017 14:40:55 GMT):
Has joined the channel.

jeffgarratt (Thu, 02 Mar 2017 14:41:26 GMT):
@mastersingh24 not yet. Getting ready to patch with final

jeffgarratt (Thu, 02 Mar 2017 14:41:34 GMT):
will ping as soon as available?

mastersingh24 (Thu, 02 Mar 2017 14:46:13 GMT):
ok - want to make sure we get this one in ;)

C0rWin (Thu, 02 Mar 2017 15:54:28 GMT):
removed unused package https://gerrit.hyperledger.org/r/#/c/6737/

yacovm (Thu, 02 Mar 2017 16:03:13 GMT):
3 Changed sets 1) https://gerrit.hyperledger.org/r/#/c/6689/ FAB-2007 part I 2) https://gerrit.hyperledger.org/r/#/c/6701/ FAB-2007 part II 3) https://gerrit.hyperledger.org/r/#/c/6703/ - Trivial one

yacovm (Thu, 02 Mar 2017 16:03:13 GMT):
3 Change sets 1) https://gerrit.hyperledger.org/r/#/c/6689/ FAB-2007 part I 2) https://gerrit.hyperledger.org/r/#/c/6701/ FAB-2007 part II 3) https://gerrit.hyperledger.org/r/#/c/6703/ - Trivial one

binhn (Thu, 02 Mar 2017 16:53:00 GMT):
@kostas I think I have reviewed all from your list but merged none; please run e2e test when you're done with https://gerrit.hyperledger.org/r/#/c/5929

kostas (Thu, 02 Mar 2017 16:54:00 GMT):
@binhn: Will do, thanks for the feedback. I'll go through everything once I'm done with this: https://chat.hyperledger.org/channel/fabric-ledger?msg=pAbYSvz6p2LeduFYW

kostas (Thu, 02 Mar 2017 16:54:00 GMT):
@binhn: Will do, thanks for the feedback. I'll go through everything once I'm done with a couple of fixes in the ledger package.

kostas (Thu, 02 Mar 2017 16:54:46 GMT):
@binhn: Will do, thanks for the feedback. I'll go through everything once I'm done with a couple of fixes in the ledger package.

binhn (Thu, 02 Mar 2017 16:57:00 GMT):
@kostas https://gerrit.hyperledger.org/r/#/c/6607/ you can cherry pick and run

binhn (Thu, 02 Mar 2017 16:57:34 GMT):
@jeffgarratt still waiting for bdd

jeffgarratt (Thu, 02 Mar 2017 16:57:52 GMT):
@binhn k

jeffgarratt (Thu, 02 Mar 2017 16:58:09 GMT):
will update asap

lehors (Thu, 02 Mar 2017 17:37:39 GMT):
hi everyone

lehors (Thu, 02 Mar 2017 17:37:56 GMT):
in case you haven't heard yet, the request to move Fabric out of Incubation was approved by the TSC

lehors (Thu, 02 Mar 2017 17:38:12 GMT):
I just submitted a change request to reflect that change in our documentation

mastersingh24 (Thu, 02 Mar 2017 19:19:57 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/6739/

mastersingh24 (Thu, 02 Mar 2017 19:20:17 GMT):
just setting some groundwork by tagging some structs with yaml tags

dave.enyeart (Thu, 02 Mar 2017 19:25:21 GMT):
fix peer-couchdb initialization in docker env: https://gerrit.hyperledger.org/r/#/c/6745/

cbf (Thu, 02 Mar 2017 20:05:50 GMT):
https://chat.hyperledger.org/channel/fabric-maintainers?msg=mbCQfPqsgbpdkobCx

mastersingh24 (Thu, 02 Mar 2017 20:17:18 GMT):
can someone +2 and merge https://gerrit.hyperledger.org/r/#/c/6273/ ? just updates fabric-ca vendor of bccsp

kostas (Thu, 02 Mar 2017 21:22:14 GMT):
Small and quick changesets: https://gerrit.hyperledger.org/r/#/c/6749/ https://gerrit.hyperledger.org/r/#/c/6751/ https://gerrit.hyperledger.org/r/#/c/6753/

mastersingh24 (Thu, 02 Mar 2017 21:28:08 GMT):
they were easy

skarim (Thu, 02 Mar 2017 21:30:23 GMT):
the following fabric-ca change sets need reviewing: https://gerrit.hyperledger.org/r/#/c/6031/9 https://gerrit.hyperledger.org/r/#/c/6375/4 https://gerrit.hyperledger.org/r/#/c/6567/3 https://gerrit.hyperledger.org/r/#/c/6577/2 https://gerrit.hyperledger.org/r/#/c/6651/1 https://gerrit.hyperledger.org/r/#/c/6705/1 https://gerrit.hyperledger.org/r/#/c/6715/3

mastersingh24 (Thu, 02 Mar 2017 21:32:25 GMT):
@skarim - many need to be rebased and there's some comments on a few of them which need to be addressed

skarim (Thu, 02 Mar 2017 21:33:20 GMT):
Right, I am working on resolving those. https://gerrit.hyperledger.org/r/#/c/6031/9 is good to go though.

bmos299 (Thu, 02 Mar 2017 23:18:01 GMT):
The community is really looking for some getting started samples which we have in this CR. https://gerrit.hyperledger.org/r/#/c/6607/

lehors (Thu, 02 Mar 2017 23:53:03 GMT):
LF is planning on a big PR event for tomorrow around Fabric's graduation

lehors (Thu, 02 Mar 2017 23:53:27 GMT):
I just submitted a CR to fix the status section in the new doc

lehors (Thu, 02 Mar 2017 23:54:35 GMT):
it would look bad if the PR attracted people to our site and it said otherwise

lehors (Fri, 03 Mar 2017 00:10:10 GMT):
I'll be in a plane for the next 12h so if something is wrong someone else will need to fix it

baohua (Fri, 03 Mar 2017 03:43:21 GMT):
dears, here is a simple logic processing refinement, welcome to help review: https://gerrit.hyperledger.org/r/#/c/6775/, thanks!

jimthematrix (Fri, 03 Mar 2017 06:12:28 GMT):
http://gerrit.hyperledger.org/r/6777 - Updated e2e test to use multi-org setup

mastersingh24 (Fri, 03 Mar 2017 09:40:06 GMT):
would someone mind hitting submit on https://gerrit.hyperledger.org/r/#/c/6755/ ? thx

yacovm (Fri, 03 Mar 2017 09:43:06 GMT):
Really small (1 line) but important gossip bug fix: https://gerrit.hyperledger.org/r/#/c/6783/

dave.enyeart (Fri, 03 Mar 2017 11:57:12 GMT):
Fix an edge case nil pointer exception: https://gerrit.hyperledger.org/r/#/c/6781

gennadyl (Fri, 03 Mar 2017 12:18:39 GMT):
https://gerrit.hyperledger.org/r/#/c/6735/ - small fix in leader election test, not in leader election itself

jimthematrix (Fri, 03 Mar 2017 13:23:20 GMT):
http://gerrit.hyperledger.org/r/6789 Revert accidental changes to original end-to-end

jimthematrix (Fri, 03 Mar 2017 13:23:20 GMT):
two trivial ones: http://gerrit.hyperledger.org/r/6789 Revert accidental changes to original end-to-end

jimthematrix (Fri, 03 Mar 2017 13:27:01 GMT):
http://gerrit.hyperledger.org/r/6791 'npm test' command broke

dave.enyeart (Fri, 03 Mar 2017 13:30:03 GMT):
fix peer-couchdb initialization in docker env by enhancing retry logic: https://gerrit.hyperledger.org/r/#/c/6745

lehors (Fri, 03 Mar 2017 14:58:49 GMT):
This one needs some love: https://gerrit.hyperledger.org/r/#/c/6769/

lehors (Fri, 03 Mar 2017 14:59:11 GMT):
We need to fix the doc asap

lehors (Fri, 03 Mar 2017 14:59:28 GMT):
Before the PR goes out

skarim (Fri, 03 Mar 2017 15:48:34 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/6375/

jimthematrix (Fri, 03 Mar 2017 17:56:40 GMT):
https://gerrit.hyperledger.org/r/#/c/6789/ - critical fix for keeping the current end-to-end running, it's only test code so be brave ;-)

yacovm (Fri, 03 Mar 2017 18:05:29 GMT):
https://gerrit.hyperledger.org/r/#/c/6787/ Pretty critical fix for gossip, please review

yacovm (Fri, 03 Mar 2017 18:05:29 GMT):
https://gerrit.hyperledger.org/r/#/c/6787/ Pretty *critical* fix for gossip, please review

dave.enyeart (Fri, 03 Mar 2017 18:42:44 GMT):
additional unit tests for ledger transaction manager: https://gerrit.hyperledger.org/r/#/c/6795/

kostas (Fri, 03 Mar 2017 20:23:40 GMT):
https://gerrit.hyperledger.org/r/#/c/5929/ (and all the Related ones up --but not incl.-- the WIP one)

nickgaski (Fri, 03 Mar 2017 20:44:26 GMT):
https://gerrit.hyperledger.org/r/#/c/6803/ - this fixes the hyperlinks that were otherwise unnoticeable with the dark blue shade.

nickgaski (Fri, 03 Mar 2017 21:12:48 GMT):
https://gerrit.hyperledger.org/r/#/c/6805/ - this adds the end-to-end.rst documentation to our source folder so that it will build with the nice output.

nickgaski (Fri, 03 Mar 2017 21:55:34 GMT):
https://gerrit.hyperledger.org/r/#/c/6809/ - this adds the `Needs Review` header to about a dozen in our library

scottz (Sat, 04 Mar 2017 01:06:27 GMT):
https://gerrit.hyperledger.org/r/#/c/6575/ , https://gerrit.hyperledger.org/r/#/c/6713/ , and https://gerrit.hyperledger.org/r/#/c/6819/ are needed for Orderer Traffic Engine testing

C0rWin (Sat, 04 Mar 2017 01:06:52 GMT):
https://gerrit.hyperledger.org/r/#/c/6807/ produce events once GB is committed after join channel

C0rWin (Sat, 04 Mar 2017 01:07:26 GMT):
@binh, @jimthematrix, @mastersingh24 ^^^

C0rWin (Sat, 04 Mar 2017 01:17:20 GMT):
another one: https://gerrit.hyperledger.org/r/#/c/6821/

gennadyl (Sat, 04 Mar 2017 09:59:11 GMT):
https://gerrit.hyperledger.org/r/#/c/6735/ - once more

gennadyl (Sat, 04 Mar 2017 09:59:11 GMT):
https://gerrit.hyperledger.org/r/#/c/6735/ - fixing leader election test

gennadyl (Sat, 04 Mar 2017 09:59:50 GMT):
https://gerrit.hyperledger.org/r/#/c/6811/ - moving leader election configuration parameters to core.yaml

gennadyl (Sat, 04 Mar 2017 13:43:17 GMT):
For 6811 I need one more +2. Somebody, please?

gennadyl (Sat, 04 Mar 2017 13:46:07 GMT):
https://gerrit.hyperledger.org/r/#/c/6735 - fixed leader election integration test, want to re-enable it... @binhn , @muralisr , @mastersingh24

muralisr (Sat, 04 Mar 2017 13:47:48 GMT):
@gennadyl ```While using real gossip as communication middleware for leader election it become impossible to point to what peer will become leader after previous leader shutdown. So test was changed to check only amount of leaders, but not what peer is a leader.```

muralisr (Sat, 04 Mar 2017 13:48:43 GMT):
so you are saying it's not possible to know beforehand who will become leader

muralisr (Sat, 04 Mar 2017 13:49:18 GMT):
but we can know who is the leader once elected, correct ?

gennadyl (Sat, 04 Mar 2017 13:49:40 GMT):
Short answer - yes

muralisr (Sat, 04 Mar 2017 13:49:45 GMT):
ok

gennadyl (Sat, 04 Mar 2017 13:50:57 GMT):
Long answer - I can to guess who will be leader with high probability

muralisr (Sat, 04 Mar 2017 13:51:10 GMT):
that is interesting :-)

muralisr (Sat, 04 Mar 2017 13:52:08 GMT):
curious now.... can you explain a bit more ?

gennadyl (Sat, 04 Mar 2017 13:53:47 GMT):
Sure.

gennadyl (Sat, 04 Mar 2017 14:04:04 GMT):
Each peer can be in 3 states - leader, follower and in leader election.

gennadyl (Sat, 04 Mar 2017 14:04:33 GMT):
If peer is leader, it sends once in while leadership message to all other peers

gennadyl (Sat, 04 Mar 2017 14:05:42 GMT):
If peer is follower, it expect to get leadership message in predefined period of time

gennadyl (Sat, 04 Mar 2017 14:06:24 GMT):
If follower don't get message in this period of time, it decide to start leader lection

gennadyl (Sat, 04 Mar 2017 14:06:52 GMT):
It sends propose message to all peers and wait

gennadyl (Sat, 04 Mar 2017 14:08:13 GMT):
In case it didn't get non propose message from other peer, then my.peerId > his.peerId, nor leadership message,

gennadyl (Sat, 04 Mar 2017 14:08:52 GMT):
it starts to send leadership message to all peers - become leader

gennadyl (Sat, 04 Mar 2017 14:09:51 GMT):
so, peers discover in different periods of time that they didn't get leadership message from leader and go to election

gennadyl (Sat, 04 Mar 2017 14:11:28 GMT):
so, peer with higher peerId can send propose message, wait leader election period of time and send leadership message

gennadyl (Sat, 04 Mar 2017 14:12:03 GMT):
before it gets propose message from peer with lower peerId

gennadyl (Sat, 04 Mar 2017 14:12:26 GMT):
Thats all

muralisr (Sat, 04 Mar 2017 14:19:39 GMT):
a bit like HSRP sounds like.. thanks for the explanation, @gennadyl

muralisr (Sat, 04 Mar 2017 14:20:55 GMT):
+2ed but will wait for @C0rWin or @yacovm review

yacovm (Sat, 04 Mar 2017 14:21:29 GMT):
I just don't understand the https://gerrit.hyperledger.org/r/#/c/6735/15/gossip/service/gossip_service_test.go@123 stuff

yacovm (Sat, 04 Mar 2017 14:21:46 GMT):
why do you have this `gossips[i].(*gossipServiceImpl).chains[channelName].Stop()` inside each loop?

yacovm (Sat, 04 Mar 2017 14:28:58 GMT):
Anyhow- it looks kinda ok to me, I commented on that thing and will merge, you can write in the change set after.

gennadyl (Sat, 04 Mar 2017 14:43:21 GMT):
@muralisr Can you look into https://gerrit.hyperledger.org/r/#/c/6811/

gennadyl (Sat, 04 Mar 2017 14:43:42 GMT):
It already have +2 from @yacovm

yacovm (Sat, 04 Mar 2017 14:46:59 GMT):
@gennadyl : https://chat.hyperledger.org/channel/fabric-pr-review?msg=WP6b9czoJtCtp6Bn7 ?

gennadyl (Sat, 04 Mar 2017 16:01:44 GMT):
@yacovm It not connected to the test. I just want to make sure state sync service not running - don't know how it will with mock committer.

gennadyl (Sat, 04 Mar 2017 16:01:44 GMT):
@yacovm It not connected to the test. I just want to make sure state sync service not running - don't know how it will work with mock committer.

yacovm (Sat, 04 Mar 2017 16:02:37 GMT):
oh, I was wondering why it is shut down at the beginning and not in the end.... oh well, fine by me I guess.

nickgaski (Sat, 04 Mar 2017 19:28:25 GMT):
https://gerrit.hyperledger.org/r/#/c/6803 - this makes links green so that they can be seen in the documentation. They're basically invisible right now

nickgaski (Sat, 04 Mar 2017 19:29:22 GMT):
https://gerrit.hyperledger.org/r/#/c/6805 - this adds the ordering service endpoint to the -o flag and puts the end-to-end piece in our doc source folder, which I feel should become the new getting started content

nickgaski (Sat, 04 Mar 2017 19:29:58 GMT):
https://gerrit.hyperledger.org/r/#/c/6809 - this adds the `Needs Review` header to about a dozen or so files in the doc library

C0rWin (Sat, 04 Mar 2017 21:55:43 GMT):
ready for review: https://gerrit.hyperledger.org/r/#/c/6821/4

muralisr (Sat, 04 Mar 2017 22:19:41 GMT):
could we get this one reviewed and merged please https://gerrit.hyperledger.org/r/#/c/6823 ?

muralisr (Sat, 04 Mar 2017 22:20:17 GMT):
it a change to e2e tests to not use testchainid

muralisr (Sat, 04 Mar 2017 22:22:16 GMT):
in addition to being a better test, testchainid also requires some requisites that make it a better for developer envs than CI

muralisr (Sat, 04 Mar 2017 22:22:16 GMT):
in addition to being a better test, testchainid also has some requisites that make it a better for developer envs than CI

muralisr (Sat, 04 Mar 2017 22:23:18 GMT):
@rameshthoomu CI worked with the above in your test ?

rameshthoomu (Sat, 04 Mar 2017 22:59:58 GMT):
Testing both #6283 and #6821... Will update the status once done..

rameshthoomu (Sat, 04 Mar 2017 23:05:59 GMT):
ok Tested and verified patch https://gerrit.hyperledger.org/r/#/c/6823 in CI on `FABRIC_COMMIT=5b48469` and `FABRIC CA COMMIT= 3021231`

rameshthoomu (Sat, 04 Mar 2017 23:06:41 GMT):
Here is the build reference: https://jenkins.hyperledger.org/sandbox/job/behave_latest/3/

muralisr (Sat, 04 Mar 2017 23:13:09 GMT):
if there are any maintainers around, can we get https://gerrit.hyperledger.org/r/#/c/6821 merged please

yacovm (Sat, 04 Mar 2017 23:13:44 GMT):
@muralisr what's the problem? it has a +2, you can merge it

muralisr (Sat, 04 Mar 2017 23:13:57 GMT):
ah I didn't see your +2

muralisr (Sat, 04 Mar 2017 23:14:02 GMT):
thatnks @yacovm

yacovm (Sat, 04 Mar 2017 23:14:07 GMT):
np

jimthematrix (Sun, 05 Mar 2017 07:17:20 GMT):
https://gerrit.hyperledger.org/r/#/c/6869/ - adding a default chaincode policy of 'signed by any member of org by mspid' where mspid is the submitter's local MSP. this is only the initial step for policy support but is required for the new end2end tests to work (because the built-in default policy uses the "DEFAULT" msp id which of course should not be used in real setup)

jimthematrix (Sun, 05 Mar 2017 07:18:03 GMT):
@mastersingh24 @jyellick @aso @yacovm ^^^

gennadyl (Sun, 05 Mar 2017 11:44:54 GMT):
https://gerrit.hyperledger.org/r/#/c/6811/ - can somebody review it? It already has +2

gennadyl (Sun, 05 Mar 2017 11:44:54 GMT):
https://gerrit.hyperledger.org/r/#/c/6811/ - can somebody review it? It already has +2 @muralisr @mastersingh24 @binhn

gennadyl (Sun, 05 Mar 2017 14:52:41 GMT):
https://gerrit.hyperledger.org/r/#/c/6875/ - fix in test of gossip service. Fixed mock committer implementation for state transfer.

dave.enyeart (Sun, 05 Mar 2017 15:48:08 GMT):
Some low risk test cleanup:

dave.enyeart (Sun, 05 Mar 2017 15:48:11 GMT):
https://gerrit.hyperledger.org/r/#/c/6795/

dave.enyeart (Sun, 05 Mar 2017 15:48:11 GMT):
https://gerrit.hyperledger.org/r/#/c/6795/ https://gerrit.hyperledger.org/r/#/c/6873/

dave.enyeart (Sun, 05 Mar 2017 17:01:59 GMT):
Rename ledger "blocks" directory to "chains" directory, since there are N chains there now: https://gerrit.hyperledger.org/r/#/c/6871/

jimthematrix (Sun, 05 Mar 2017 17:23:00 GMT):
http://gerrit.hyperledger.org/r/6881 Enhance the default endorsement policy, the initial step in 6869 creates a default policy that looks for the specific signature from the org that submitted the "instantiate()" proposal. the enhancement creates a more robust policy that looks for a single signature from any of the chain's participating orgs, which are discovered from the chain's config block. @mastersingh24 @binhn @jyellick @aso @yacovm

jyellick (Sun, 05 Mar 2017 17:41:32 GMT):
@jimthematrix My javascript skills are sub-par, but I don't think the policy construction in this one is right, -2-ed for now

jimthematrix (Sun, 05 Mar 2017 17:41:51 GMT):
you are right Jason, silly error on my part ;-)

jimthematrix (Sun, 05 Mar 2017 17:46:25 GMT):
@jyellick just pushed an update, can you check again?

jyellick (Sun, 05 Mar 2017 17:48:01 GMT):
@jimthematrix I don't see a new patchset?

jimthematrix (Sun, 05 Mar 2017 17:49:06 GMT):
shoot it went to 6885 (got two stacked up) ;-)

jimthematrix (Sun, 05 Mar 2017 17:49:21 GMT):
let me make a quick change, one minute

jimthematrix (Sun, 05 Mar 2017 17:50:44 GMT):
should be up there now

jimthematrix (Sun, 05 Mar 2017 17:50:44 GMT):
should be up there now @jyellick

jimthematrix (Sun, 05 Mar 2017 17:55:15 GMT):
and just passed verify

jimthematrix (Sun, 05 Mar 2017 17:55:54 GMT):
one sec, still another small change...

jimthematrix (Sun, 05 Mar 2017 17:56:26 GMT):
(in a high school for my daughter's volleyball tournament so there's all this noise ;-) )

jimthematrix (Sun, 05 Mar 2017 17:59:34 GMT):
finally there. should be all set now. feel free to review the latest (patch 3)

jyellick (Sun, 05 Mar 2017 18:39:50 GMT):
Sure

jyellick (Sun, 05 Mar 2017 18:39:50 GMT):
Sure, looking now

jimthematrix (Sun, 05 Mar 2017 18:48:51 GMT):
@jyellick I changed var name from `policies` to `signedBys`

jimthematrix (Sun, 05 Mar 2017 18:48:51 GMT):
@jyellick I changed var name from `policies` to `signedBys` re: your latest comment

jyellick (Sun, 05 Mar 2017 18:49:36 GMT):
I was referencing the `oneOfone` variable name

jyellick (Sun, 05 Mar 2017 18:49:49 GMT):
Since it's more appropriately `oneOfAny` or something like that

jimthematrix (Sun, 05 Mar 2017 18:50:09 GMT):
oh...

jimthematrix (Sun, 05 Mar 2017 18:50:58 GMT):
how about now

jimthematrix (Sun, 05 Mar 2017 18:51:13 GMT):
changed to `oneOfAny`, does sound more appropriate for the new policy

jyellick (Sun, 05 Mar 2017 18:52:05 GMT):
Works for me, sorry for the nit-picking!

jimthematrix (Sun, 05 Mar 2017 19:01:15 GMT):
good review Jason, makes the code much better now :thumbsup:

jimthematrix (Sun, 05 Mar 2017 19:01:44 GMT):
btw you can click "Submit" already, sdk needs only one +2 ;-)

smithbk (Sun, 05 Mar 2017 20:27:22 GMT):
The following fabric-ca items need review or re-review. Fixed some merge conflicts and addressed previous comments. Thanks

smithbk (Sun, 05 Mar 2017 20:27:24 GMT):
https://gerrit.hyperledger.org/r/6577 https://gerrit.hyperledger.org/r/6651 https://gerrit.hyperledger.org/r/6705 https://gerrit.hyperledger.org/r/6715

C0rWin (Mon, 06 Mar 2017 00:26:23 GMT):
very simple ones

C0rWin (Mon, 06 Mar 2017 00:26:24 GMT):
https://gerrit.hyperledger.org/r/#/c/6883/2

C0rWin (Mon, 06 Mar 2017 00:26:27 GMT):
https://gerrit.hyperledger.org/r/#/c/6875/3

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a couple of change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 2 more: Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a couple of change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6861/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 2 more: Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a couple of change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6861/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 2 mor (pretty easy): Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a couple of change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6861/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 3 more (pretty easy): Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/ https://gerrit.hyperledger.org/r/#/c/6901/ Change *Info* --> *Debug*

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a couple of change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6861/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 3 more (pretty easy): Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/ https://gerrit.hyperledger.org/r/#/c/6901/ Change *Info* --> *Debug* in 2 logging events

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a *few* change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6861/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 3 more (pretty easy): Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/ https://gerrit.hyperledger.org/r/#/c/6901/ Change *Info* --> *Debug* in 2 logging events

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a *few* change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6861/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 3 more (pretty easy): Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) @adc Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/ https://gerrit.hyperledger.org/r/#/c/6901/ Change *Info* --> *Debug* in 2 logging events

yacovm (Mon, 06 Mar 2017 10:31:23 GMT):
Good morning, I have a *few* change sets, the first chain is for FAB-2007, Making gossip membership use external endpoints between organizations and internal endpoints inside the organization https://gerrit.hyperledger.org/r/#/c/6815/ -> https://gerrit.hyperledger.org/r/#/c/6787/ -> https://gerrit.hyperledger.org/r/#/c/6855/ -> https://gerrit.hyperledger.org/r/#/c/6857/ -> https://gerrit.hyperledger.org/r/#/c/6859/ -> https://gerrit.hyperledger.org/r/#/c/6861/ -> https://gerrit.hyperledger.org/r/#/c/6865/ -> https://gerrit.hyperledger.org/r/#/c/6867/ Also 4 more (pretty easy) independent change sets : Bug fix in MessageCryptoService https://gerrit.hyperledger.org/r/#/c/6887/ - This is *not* a bug in gossip ;) @adc Nicer formatting of NetworkMember struct in gossip logs https://gerrit.hyperledger.org/r/#/c/6863/ https://gerrit.hyperledger.org/r/#/c/6901/ Change *Info* --> *Debug* in 2 logging events FAB-2640 *Support empty set of anchor peers* https://gerrit.hyperledger.org/r/#/c/6903/ I guess this could be counted as a bug, or an essential feature

dave.enyeart (Mon, 06 Mar 2017 12:40:21 GMT):
Rename ledger "blocks" directory to "chains" directory, since there are N chains there now: https://gerrit.hyperledger.org/r/#/c/6871

yacovm (Mon, 06 Mar 2017 17:32:13 GMT):
2 bug fixes: https://gerrit.hyperledger.org/r/#/c/6909/ https://gerrit.hyperledger.org/r/#/c/6915/1

yacovm (Mon, 06 Mar 2017 17:32:13 GMT):
2 bug fixes: https://gerrit.hyperledger.org/r/#/c/6909/ https://gerrit.hyperledger.org/r/#/c/6915/

kostas (Mon, 06 Mar 2017 18:19:14 GMT):
This one introduces the path to the new file-based ledger: https://gerrit.hyperledger.org/r/#/c/6725/

kostas (Mon, 06 Mar 2017 18:19:14 GMT):
This one introduces the path to the new file-based ledger for the orderer: https://gerrit.hyperledger.org/r/#/c/6725/

jimthematrix (Mon, 06 Mar 2017 19:53:48 GMT):
https://gerrit.hyperledger.org/r/#/c/6885/ - last step to add to the new multi-org e2e test

jimthematrix (Mon, 06 Mar 2017 20:45:38 GMT):
http://gerrit.hyperledger.org/r/6925 Update readme and ca build task

C0rWin (Mon, 06 Mar 2017 20:45:56 GMT):
https://gerrit.hyperledger.org/r/#/c/6895/, small improvements

C0rWin (Mon, 06 Mar 2017 20:46:03 GMT):
and https://gerrit.hyperledger.org/r/#/c/6897/

C0rWin (Mon, 06 Mar 2017 20:46:03 GMT):
and another one https://gerrit.hyperledger.org/r/#/c/6897/

smithbk (Tue, 07 Mar 2017 02:45:24 GMT):
@mastersingh24 @JonathanLevi Could you +2 the following? Gari, you already did and Jonathan, you were waiting for my signoff, which I did.

smithbk (Tue, 07 Mar 2017 02:45:26 GMT):
https://gerrit.hyperledger.org/r/6651

smithbk (Tue, 07 Mar 2017 02:46:36 GMT):
The next ones in line after this for fabric-ca are as follows:

smithbk (Tue, 07 Mar 2017 02:46:38 GMT):
1) https://gerrit.hyperledger.org/r/6705 2) https://gerrit.hyperledger.org/r/6715 3) https://gerrit.hyperledger.org/r/6921 4) https://gerrit.hyperledger.org/r/6943

smithbk (Tue, 07 Mar 2017 02:47:09 GMT):
Gari has already +2'ed 1 and 2

jimthematrix (Tue, 07 Mar 2017 03:13:48 GMT):
two easy ones guys: https://gerrit.hyperledger.org/r/#/c/6885 - last step to add to the new multi-org e2e test http://gerrit.hyperledger.org/r/6925 Update readme and ca build task

jimthematrix (Tue, 07 Mar 2017 03:54:07 GMT):
*critical fix*: http://gerrit.hyperledger.org/r/6945 Update orderer genesis block used in test

jimthematrix (Tue, 07 Mar 2017 03:55:08 GMT):
@rameshthoomu this should fix the orderer crash when using the test/fixtures/channel/docker-compose.yaml to start the network

rameshthoomu (Tue, 07 Mar 2017 03:55:53 GMT):
cool. will test this and let you know the status..

JonathanLevi (Tue, 07 Mar 2017 06:08:04 GMT):
@smithbk/Keith, you should always add a sign-off when you upload a patchset to someone else's changeset [ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=f2TcZprqA7EhjbCgY) @smithbk

JonathanLevi (Tue, 07 Mar 2017 06:08:04 GMT):
Keith, please, you must always add a sign-off when you upload a patchset/append code to someone else's changeset [ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=f2TcZprqA7EhjbCgY) @smithbk

JonathanLevi (Tue, 07 Mar 2017 06:09:06 GMT):
And I have +2'ed 1 and 2 as well before your post above. It's just that all these CRs are somehow intertwined, so we cannot merge them gradually.

JonathanLevi (Tue, 07 Mar 2017 06:09:15 GMT):
See: https://gerrit.hyperledger.org/r/#/c/6705/

JonathanLevi (Tue, 07 Mar 2017 06:09:37 GMT):
... and: https://gerrit.hyperledger.org/r/#/c/6715/

JonathanLevi (Tue, 07 Mar 2017 06:11:46 GMT):
Now on that note, why isn't a CR such as *Remove cli from fabric-ca* - a self-contained, atomic CR that requires so many others?

JonathanLevi (Tue, 07 Mar 2017 06:11:46 GMT):
Now on that note, why isn't a CR such as *Remove cli from fabric-ca* - a self-contained, atomic CR - and instead, it requires/linked to so many other CRs? (for example)

JonathanLevi (Tue, 07 Mar 2017 06:12:54 GMT):
Being able to merge self-contained items (with sign-offs) will save us all plenty of time (and iterations)

yacovm (Tue, 07 Mar 2017 13:20:31 GMT):
Stuff left to CR in gossip: https://gerrit.hyperledger.org/r/#/c/6859/ - 1 line of code, already got +2 https://gerrit.hyperledger.org/r/#/c/6861 This is for the brave, already got +2 https://gerrit.hyperledger.org/r/#/c/6865 Just 26 of production code, the rest is misc and test, got +2 https://gerrit.hyperledger.org/r/#/c/6867 22 lines of code, got +2 https://gerrit.hyperledger.org/r/#/c/6909/ Easy bug fix https://gerrit.hyperledger.org/r/#/c/6903/ I'm not sure if that counts as bug fix but I think it should be in alpha, @binhn what do you think? (Adding support for gossip to have an empty set of anchor peers in case there is only 1 organization in the channel)

yacovm (Tue, 07 Mar 2017 13:20:31 GMT):
Stuff left to CR in gossip: https://gerrit.hyperledger.org/r/#/c/6859/ - 1 line of code, already got +2 https://gerrit.hyperledger.org/r/#/c/6861 This is for the brave, it's 131 lines of production code only though, the rest is a test. already got +2 https://gerrit.hyperledger.org/r/#/c/6865 Just 26 of production code, the rest is misc and test, got +2 https://gerrit.hyperledger.org/r/#/c/6867 22 lines of code, got +2 https://gerrit.hyperledger.org/r/#/c/6909/ Easy bug fix https://gerrit.hyperledger.org/r/#/c/6903/ I'm not sure if that counts as bug fix but I think it should be in alpha, @binhn what do you think? (Adding support for gossip to have an empty set of anchor peers in case there is only 1 organization in the channel)

yacovm (Tue, 07 Mar 2017 13:20:31 GMT):
Stuff left to CR in gossip: https://gerrit.hyperledger.org/r/#/c/6859/ - 1 line of code, already got +2 https://gerrit.hyperledger.org/r/#/c/6861 This is for the brave, it's 131 lines of production code only though, the rest is a test. already got +2 https://gerrit.hyperledger.org/r/#/c/6865 Just 26 of production code, the rest is misc and test, got +2 https://gerrit.hyperledger.org/r/#/c/6867 22 lines of code, got +2 https://gerrit.hyperledger.org/r/#/c/6903/ I'm not sure if that counts as bug fix but I think it should be in alpha, @binhn what do you think? (Adding support for gossip to have an empty set of anchor peers in case there is only 1 organization in the channel)

yacovm (Tue, 07 Mar 2017 13:20:31 GMT):
Stuff left to CR in gossip: https://gerrit.hyperledger.org/r/#/c/6861 This is for the brave, it's 131 lines of production code only though, the rest is a test. already got +2 https://gerrit.hyperledger.org/r/#/c/6865 Just 26 of production code, the rest is misc and test, got +2 https://gerrit.hyperledger.org/r/#/c/6867 22 lines of code, got +2 https://gerrit.hyperledger.org/r/#/c/6903/ I'm not sure if that counts as bug fix but I think it should be in alpha, @binhn what do you think? (Adding support for gossip to have an empty set of anchor peers in case there is only 1 organization in the channel)

yacovm (Tue, 07 Mar 2017 13:20:31 GMT):
Stuff left to CR in gossip: https://gerrit.hyperledger.org/r/#/c/6861 This is for the brave, it's 131 lines of production code only though, the rest is a test. already got +2 https://gerrit.hyperledger.org/r/#/c/6865 Just 26 of production code, the rest is misc and test, got +2 https://gerrit.hyperledger.org/r/#/c/6903/ I'm not sure if that counts as bug fix but I think it should be in alpha, @binhn what do you think? (Adding support for gossip to have an empty set of anchor peers in case there is only 1 organization in the channel)

JonathanLevi (Tue, 07 Mar 2017 14:29:53 GMT):
So, it it only me who feels that if we were to create a decentralized limit order book for pull requests, and needed marketing person with the unique ability of being able to create a demand and motivation for others to approve such pull requests... Hands down, Yacov M is the first name to spring to mind?

JonathanLevi (Tue, 07 Mar 2017 14:29:53 GMT):
So, it it only me who feels that if we were to create a decentralized limit order book for pull requests, and needed a marketing person with the unique skill of being able to create the demand and motivation for others to approve such pull requests... Hands down, Yacov M is the first name to spring to mind?

JonathanLevi (Tue, 07 Mar 2017 14:30:00 GMT):
*1 line of code, already got +2*

JonathanLevi (Tue, 07 Mar 2017 14:30:21 GMT):
*This is for the brave* ... *the rest is a test.* etc.

JonathanLevi (Tue, 07 Mar 2017 14:30:30 GMT):
*Easy bug fix*

JonathanLevi (Tue, 07 Mar 2017 14:30:33 GMT):
...

JonathanLevi (Tue, 07 Mar 2017 14:31:06 GMT):
I can't even come up with such original statements even when I really need to get some stuff merged!

JonathanLevi (Tue, 07 Mar 2017 14:31:27 GMT):
Oh, *Just 26 of production code, the rest is misc and test, got +2*

JonathanLevi (Tue, 07 Mar 2017 14:31:30 GMT):
LOL.

JonathanLevi (Tue, 07 Mar 2017 14:31:35 GMT):
This stuff is GOLD !

JonathanLevi (Tue, 07 Mar 2017 14:31:57 GMT):
The build-up, the suspense... and then tops it with a *got +2*

JonathanLevi (Tue, 07 Mar 2017 14:31:57 GMT):
The build-up *Just ...*, the suspense *the rest is misc, and then he tops it with a *got +2*. SLAM DUNK!

JonathanLevi (Tue, 07 Mar 2017 14:31:57 GMT):
The build-up *Just ... *, the suspense *the rest is misc*, and then he tops it with a *got +2*. SLAM DUNK!

yacovm (Tue, 07 Mar 2017 14:33:12 GMT):
I'm trying to get it merged, it's very important for alpha :)

JonathanLevi (Tue, 07 Mar 2017 14:35:34 GMT):
I know, I know. It's just too impressive to ignore.

yacovm (Tue, 07 Mar 2017 14:40:47 GMT):
So, Jonathan since I entertained you, any chance for a +2 on this bug fix? Jason already +2ed and C0rwin needs to base a very urgent commit on this https://gerrit.hyperledger.org/r/#/c/6909/

JonathanLevi (Tue, 07 Mar 2017 15:01:28 GMT):

Message Attachments

JonathanLevi (Tue, 07 Mar 2017 15:01:40 GMT):
OK, just a quick one.

JonathanLevi (Tue, 07 Mar 2017 15:02:27 GMT):
I have been trying to unclog some of you... (from gossip, fabric-ca, some of Jason's very nice stuff wrt to the Proposer/config)

JonathanLevi (Tue, 07 Mar 2017 15:02:27 GMT):
I have been trying to unclog some of you... (of all sections/areas: gossip, fabric-ca, some of Jason's very nice stuff wrt to the Proposer/config...)

JonathanLevi (Tue, 07 Mar 2017 15:03:02 GMT):
But I feel like we have a few "camps", components that are "building up" a *LOT* of logic.

JonathanLevi (Tue, 07 Mar 2017 15:03:02 GMT):
But I feel like we have a few "camps", components that are "building up" a *LOT* of pending/logic that we slowly approve +2 at a time.

JonathanLevi (Tue, 07 Mar 2017 15:04:03 GMT):
If possible, and I know it is a bit difficult at times, to submit some smaller independent issues... it will allow us to merge things gradually so that we can better test the "integration" of these.

JonathanLevi (Tue, 07 Mar 2017 15:04:51 GMT):
It's what I asked Keith to do earlier this morning, similar with the backlog that Yacov uploaded here (and I did just merge a bug-fix), and it's the same with Jason's (very nice!) work.

JonathanLevi (Tue, 07 Mar 2017 15:04:52 GMT):
----

JonathanLevi (Tue, 07 Mar 2017 15:05:02 GMT):
Keep in mind that the build cycles are slow.

yacovm (Tue, 07 Mar 2017 15:05:10 GMT):
Wait, my commits in the last week are either bug fixes or a single JIRA item

JonathanLevi (Tue, 07 Mar 2017 15:05:22 GMT):
Nothing personal (Yacov)

JonathanLevi (Tue, 07 Mar 2017 15:05:22 GMT):
Nothing personal (Yacov) - yours was self-contained and I have merged it, right?

yacovm (Tue, 07 Mar 2017 15:05:23 GMT):
There isn't really lots of logic that is changed

yacovm (Tue, 07 Mar 2017 15:05:27 GMT):
just saying :)

JonathanLevi (Tue, 07 Mar 2017 15:06:29 GMT):
It's just a more general statement... that even though we approve things... in many cases, we end up being able to merge them only a few days later. Which can be a bit/more risky as we "integrate" a lot in "one go".

yacovm (Tue, 07 Mar 2017 15:07:18 GMT):
Yeah I totally agree about the configuration stuff.

JonathanLevi (Tue, 07 Mar 2017 15:08:30 GMT):
Not blaming anything/anyone specifically. Just saying that the sooner we merge and test - the better these days. And the more we review/approve and can't merge (postpone the merging)... the more "risk" we build up as the upcoming merges grow, and we'll end up with even less time for testing an "integrated"/combined version of the "master" branch.

JonathanLevi (Tue, 07 Mar 2017 15:08:30 GMT):
Not blaming anything/anyone specifically. Just saying that the sooner we merge and test stuff that we need to have as part of the alpha cut - the better (these days). And the more we review/approve and can't merge (postpone the merging, while we know it will be needed)... the more "risk" we build up as the upcoming merges grow, and we'll end up with even less time for testing an "integrated"/combined version of the "master" branch.

JonathanLevi (Tue, 07 Mar 2017 15:08:30 GMT):
Not blaming anything/anyone specifically. Just saying that the sooner we merge and test stuff that we need to have as part of the alpha cut - the better (these days). And the more we review/approve and can't merge (postpone the merging step), while we know it will be needed... the more "risk" we build up as the upcoming merges grow, and we'll end up with even less time for testing an "integrated"/combined version of the "master" branch.

JonathanLevi (Tue, 07 Mar 2017 15:09:15 GMT):
Just a request/suggestion for everybody - as a "by stander" who took a quick snapshot at the current state of gerrit.

JonathanLevi (Tue, 07 Mar 2017 15:48:55 GMT):

Message Attachments

JonathanLevi (Tue, 07 Mar 2017 15:49:34 GMT):
As an example (really without loss of generality ;-))

JonathanLevi (Tue, 07 Mar 2017 16:04:08 GMT):
OK, @binhn and I found a way out of some of these... https://gerrit.hyperledger.org/r/#/c/6587 & https://gerrit.hyperledger.org/r/#/c/6771

jimthematrix (Tue, 07 Mar 2017 16:45:49 GMT):
hey guys broken record warning: we need these 3 merged asap as I'm getting pinged from rocket.chat by multiple ppl trying out the stuff but had failures that would've been addressed by these - https://gerrit.hyperledger.org/r/6791/ https://gerrit.hyperledger.org/r/6885 https://gerrit.hyperledger.org/r/6925

dave.enyeart (Tue, 07 Mar 2017 17:25:44 GMT):
Chaincode gets an error if iterating beyond the hard-coded query limit of 100. This change adds a configurable query limit (default 10000) to help people get past the error scenarios: https://gerrit.hyperledger.org/r/#/c/6683/

dave.enyeart (Tue, 07 Mar 2017 17:26:49 GMT):
This is a proposed fix for beta. The larger fix to re-enable batching results between shim and peer is riskier and therefore targeted for post-beta.

dave.enyeart (Tue, 07 Mar 2017 17:28:17 GMT):
@muralisr as the maintainer with the most knowledge in this area, the others would probably defer to your judgement

harsha (Tue, 07 Mar 2017 18:05:44 GMT):
This needs review https://gerrit.hyperledger.org/r/#/c/6899/2/ as it addresses https://jira.hyperledger.org/browse/FAB-1485

greg.haskins (Tue, 07 Mar 2017 19:37:07 GMT):
@muralisr https://gerrit.hyperledger.org/r/#/c/5579/

greg.haskins (Tue, 07 Mar 2017 19:37:15 GMT):
ready for consideration

muralisr (Tue, 07 Mar 2017 19:38:03 GMT):
@greg.haskins right, started looking at that

muralisr (Tue, 07 Mar 2017 19:52:41 GMT):
(went back to look at the CR... hence the delay @greg.haskins )

greg.haskins (Tue, 07 Mar 2017 19:54:03 GMT):
no worries, your review is appreciated

muralisr (Tue, 07 Mar 2017 20:05:32 GMT):
let me get back by tomorrow morning latest (aiming for tonight)

muralisr (Tue, 07 Mar 2017 20:05:32 GMT):
let me get back by tomorrow morning latest (aiming for tonight) ?

jimthematrix (Tue, 07 Mar 2017 21:36:03 GMT):
the last remaining piece for the new multi-org e2e test in the node sdk: http://gerrit.hyperledger.org/r/6977 Add event listener to chain genesis block commit

jimthematrix (Tue, 07 Mar 2017 21:36:32 GMT):
@mastersingh24 @binhn @muralisr @yacovm ^^^

binhn (Tue, 07 Mar 2017 21:55:28 GMT):
doc on policy, easy read https://gerrit.hyperledger.org/r/#/c/6923/

yacovm (Tue, 07 Mar 2017 22:16:23 GMT):
Last commit in the series of FAB-2007 https://gerrit.hyperledger.org/r/#/c/6865/

latitiah (Tue, 07 Mar 2017 22:26:30 GMT):
I have some PRs for behave tests: https://gerrit.hyperledger.org/r/#/c/6973/ https://gerrit.hyperledger.org/r/#/c/6979/ (@binhn: my understanding is that you are waiting on this one) https://gerrit.hyperledger.org/r/#/c/6117/

latitiah (Tue, 07 Mar 2017 22:26:30 GMT):
I have some PRs for behave tests: https://gerrit.hyperledger.org/r/#/c/6973/ https://gerrit.hyperledger.org/r/#/c/6979/ ( @binhn: my understanding is that you are waiting on this one) https://gerrit.hyperledger.org/r/#/c/6117/

binhn (Wed, 08 Mar 2017 02:20:28 GMT):
1 more +2 on this https://gerrit.hyperledger.org/r/#/c/6683/

dave.enyeart (Wed, 08 Mar 2017 04:25:15 GMT):
@muralisr Do I hear another +2 on the chaincode query limit fix? https://gerrit.hyperledger.org/r/#/c/6683

yacovm (Wed, 08 Mar 2017 11:00:04 GMT):
Can any maintainer please +2 this? There is a compilation error that breaks CI https://gerrit.hyperledger.org/r/#/c/7011/

JonathanLevi (Wed, 08 Mar 2017 11:13:33 GMT):
Merged.

JonathanLevi (Wed, 08 Mar 2017 11:15:21 GMT):
@C0rWin / Artem: thanks for fixing!

JonathanLevi (Wed, 08 Mar 2017 11:16:18 GMT):
All, please feel free to escalate when/if the master branch is broken, tests don't pass, you experience inconsistent behavior... let alone if/when the code cannot compile!

dave.enyeart (Wed, 08 Mar 2017 12:03:51 GMT):
Config updates for our fabric-couchdb docker image, and start using it in vagrant env (already being used in CI env): https://gerrit.hyperledger.org/r/#/c/6929/ Instructions for how to use fabric-couchdb docker in e2e docker compose: https://gerrit.hyperledger.org/r/#/c/6947/

dave.enyeart (Wed, 08 Mar 2017 12:03:51 GMT):
https://gerrit.hyperledger.org/r/#/c/6929/ Config updates for our fabric-couchdb docker image, and start using it in vagrant env (already being used in CI env). Ready for merge. https://gerrit.hyperledger.org/r/#/c/6947/ Instructions for how to use fabric-couchdb docker in e2e docker compose. Want to get feedback on the overall approach.

yacovm (Wed, 08 Mar 2017 12:17:54 GMT):
A few easy commits: https://gerrit.hyperledger.org/r/#/c/6863/ *String()* implementation for some gossip struct, had 2 +2s but had to rebase https://gerrit.hyperledger.org/r/#/c/7005/ 1 line change - was requested to do this in a CR of a change set yesterday https://gerrit.hyperledger.org/r/#/c/7007/ Removal of a few un-used lines in a test

yacovm (Wed, 08 Mar 2017 12:17:54 GMT):
A few easy commits: https://gerrit.hyperledger.org/r/#/c/6863/ *String()* implementation for some gossip struct, had 2 +2s but had to rebase https://gerrit.hyperledger.org/r/#/c/7005/ 1 line change - was requested to do this in a CR of a change set yesterday, @muralisr https://gerrit.hyperledger.org/r/#/c/7007/ Removal of a few un-used lines in a test

muralisr (Wed, 08 Mar 2017 13:43:48 GMT):
@dave.enyeart meant to look at https://gerrit.hyperledger.org/r/#/c/6683 yesterday... looking now

muralisr (Wed, 08 Mar 2017 13:44:44 GMT):
(thanks for https://gerrit.hyperledger.org/r/#/c/7005 , @yacovm )

greg.haskins (Wed, 08 Mar 2017 14:30:08 GMT):
@muralisr @mastersingh24 with CR 6991, the "peer chaincode" CLI is now about as efficient as I think it can possibly be in terms of codepackage size: https://gerrit.hyperledger.org/r/#/c/6991/

greg.haskins (Wed, 08 Mar 2017 14:31:03 GMT):
for instance, packaging example02 results in a 2421 byte payload, whereas it used to be over a MB

muralisr (Wed, 08 Mar 2017 14:31:53 GMT):
wow ... and I see `https://gerrit.hyperledger.org/r/#/c/6991/2/core/chaincode/platforms/golang/list.go`

muralisr (Wed, 08 Mar 2017 14:32:25 GMT):
thanks @greg.haskins ... will look by today for sure

harsha (Wed, 08 Mar 2017 15:41:53 GMT):
I've a PR that needs review :- https://gerrit.hyperledger.org/r/#/c/6899/ - This patch addresses *FAB-1485* which in brief creates `openldap` specific docker image across respective arch.

harsha (Wed, 08 Mar 2017 15:41:53 GMT):
I've submitted a PR that needs review :- https://gerrit.hyperledger.org/r/#/c/6899/ - This patch addresses *FAB-1485* which in brief creates `openldap` specific docker image across respective arch.

jyellick (Wed, 08 Mar 2017 15:47:47 GMT):
Talked some with @JonathanLevi about this yesterday. In the interest of not stopping development, but also stabilizing code for alpha, I'm tagging CRs which should not be pulled in before alpha as `[FAB-XXXX] (PA) `. I post it here as a suggested convention to allow reviewers to easily determine which CRs should be considered for alpha.

jyellick (Wed, 08 Mar 2017 15:47:47 GMT):
Talked some with @JonathanLevi about this yesterday. In the interest of not stopping development, but also stabilizing code for alpha, I'm tagging CRs which should not be pulled in before alpha as `[FAB-XXXX] (PA) `. (Thought being PA can mean post-alpha) I post it here as a suggested convention to allow reviewers to easily determine which CRs should be considered for alpha.

JonathanLevi (Wed, 08 Mar 2017 15:54:28 GMT):
Yes, let's try to test that new stuff we need - as much as we can...

muralisr (Wed, 08 Mar 2017 15:56:55 GMT):
talking of testing, people who know this please to ignore the following steps I typically use to do e2e testing :-)

muralisr (Wed, 08 Mar 2017 15:58:31 GMT):
```make clean make peer make peer-docker make orderer-docker cd examples/e2e-cli ./network__setup.sh up if everything went well you should see Query Result: 90 2017-03-08 14:59:08.968 UTC [main] main -> INFO 006 Exiting..... ===================== Query on PEER3 on channel 'mychannel' is successful ===================== ===================== All GOOD, End-2-End execution completed ===================== to cleanup ./network_setup.sh down```

muralisr (Wed, 08 Mar 2017 15:59:34 GMT):
that tests a bit of manythings - gossip, orderer, channel create/join, ledger

yacovm (Wed, 08 Mar 2017 16:17:25 GMT):
Same thing here @muralisr ``` Query Result: 90 2017-03-08 16:17:03.059 UTC [main] main -> INFO 006 Exiting..... ===================== Query on PEER3 on channel 'mychannel' is successful ===================== ===================== All GOOD, End-2-End execution completed ===================== ```

yacovm (Wed, 08 Mar 2017 16:17:33 GMT):
Nice script btw (whoever wrote it)

jimthematrix (Wed, 08 Mar 2017 17:07:24 GMT):
http://gerrit.hyperledger.org/r/7037 Update genesis blocks for orderer and chain, needed to fix orderer crashes due to outdated genesis block and/or channel config template used by node sdk's e2e

nickgaski (Wed, 08 Mar 2017 17:32:15 GMT):
https://gerrit.hyperledger.org/r/#/c/6803/ fixes links throughout our Read The Docs and makes them noticeable! Converts two important files - policies and configtxgen - to .rst so that they can be added to community doc

rameshthoomu (Wed, 08 Mar 2017 17:54:46 GMT):
@binhn @muralisr could you please review and merge pls.. https://gerrit.hyperledger.org/r/#/c/6979/

nickgaski (Wed, 08 Mar 2017 18:55:33 GMT):
https://gerrit.hyperledger.org/r/#/c/6877/ - this needs to be merged ASAP. There is some confidential information currently in the architecture FAQ; this PR from @dave.enyeart removes and resolves

nickgaski (Wed, 08 Mar 2017 18:56:09 GMT):
also, how bout a little love for - https://gerrit.hyperledger.org/r/#/c/6803 - while I'm here panhandling

yacovm (Wed, 08 Mar 2017 19:39:50 GMT):
@nickgaski that CR is based on top of another

yacovm (Wed, 08 Mar 2017 19:40:16 GMT):
but I think it has a stale parent

yacovm (Wed, 08 Mar 2017 19:40:31 GMT):
can you detach the commit from its parent and re-push

yacovm (Wed, 08 Mar 2017 19:40:31 GMT):
can you detach the commit from its parent and re-push?

nickgaski (Wed, 08 Mar 2017 19:57:18 GMT):
ah yes np

jimthematrix (Wed, 08 Mar 2017 20:07:33 GMT):
@binhn I rebased https://gerrit.hyperledger.org/r/#/c/7037/ so now it can be merged directly

binhn (Wed, 08 Mar 2017 21:03:51 GMT):
@jimthematrix done

dave.enyeart (Wed, 08 Mar 2017 22:09:52 GMT):
https://gerrit.hyperledger.org/r/#/c/6877 : Architecture FAQ cleanup... got two +2, please merge!

dave.enyeart (Wed, 08 Mar 2017 22:09:52 GMT):
https://gerrit.hyperledger.org/r/#/c/6877 Architecture FAQ has been replaced with: https://gerrit.hyperledger.org/r/#/c/7053

dave.enyeart (Wed, 08 Mar 2017 22:29:10 GMT):
@nickgaski ^^^^^^^^

dave.enyeart (Thu, 09 Mar 2017 00:00:15 GMT):
Ok, the Architecture FAQ is fixed up, need one more +2 please: https://gerrit.hyperledger.org/r/#/c/7053/

dave.enyeart (Thu, 09 Mar 2017 00:00:42 GMT):
FYI, this is just the start of the Architecture FAQ, I will work with documentation to extend in the coming days

yacovm (Thu, 09 Mar 2017 08:50:51 GMT):
log warning in case a bad network configuration is detected in the gossip layer: https://gerrit.hyperledger.org/r/#/c/7065/ @bmos299 @Ratnakar

bmos299 (Thu, 09 Mar 2017 14:55:31 GMT):
@yacovm Thanks.

samirsadeghi (Thu, 09 Mar 2017 15:02:34 GMT):
Has joined the channel.

mastersingh24 (Thu, 09 Mar 2017 15:30:50 GMT):
https://gerrit.hyperledger.org/r/#/c/7075/ - first part of TLS

C0rWin (Thu, 09 Mar 2017 15:35:43 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=8N7qYm3kXp77HpeBK) @yacovm Just uploaded small fix to change warning message to error

ashutosh_kumar (Thu, 09 Mar 2017 15:54:28 GMT):
@mastersingh24 , put small comment, might not be relevant for this round.

dave.enyeart (Thu, 09 Mar 2017 19:07:08 GMT):
Configuration for fabric-couchdb docker (we want to publish next week): https://gerrit.hyperledger.org/r/#/c/6929

dave.enyeart (Thu, 09 Mar 2017 19:07:08 GMT):
Configuration for fabric-couchdb docker (we want to publish next week): https://gerrit.hyperledger.org/r/#/c/7099/

jeffgarratt (Thu, 09 Mar 2017 20:10:04 GMT):
@binhn @muralisr @jyellick @bmos299 https://gerrit.hyperledger.org/r/#/c/7085/

ruslan.kryukov (Fri, 10 Mar 2017 04:22:44 GMT):
As for couchDB, recently we have made stress test, which included invoke requests to fabric, a lot of them, 1000reqs with 50 threads.. so couchdb just hanged when we were doing test, finally we turned off couchdb and currently we use embdedd levelDB

ruslan.kryukov (Fri, 10 Mar 2017 04:23:58 GMT):
(Tiny stress test)

muralisr (Fri, 10 Mar 2017 13:03:30 GMT):
@ruslan.kryukov and the same test worked with levelDB I assume ?

ruslan.kryukov (Fri, 10 Mar 2017 13:03:48 GMT):
yes

ruslan.kryukov (Fri, 10 Mar 2017 13:04:20 GMT):
leveldb works fast

muralisr (Fri, 10 Mar 2017 13:04:58 GMT):
can you relate this in fabric-ledger too please ?

ruslan.kryukov (Fri, 10 Mar 2017 13:05:36 GMT):
done

muralisr (Fri, 10 Mar 2017 13:05:52 GMT):
also, does the test verify the results of the invoke after commit ?

ruslan.kryukov (Fri, 10 Mar 2017 13:08:49 GMT):
yes, I had status 200

muralisr (Fri, 10 Mar 2017 13:13:12 GMT):
sorry.. let me be be clearer. The invoke returns 200 which is good. But the transacation that the invoke submits to orderer and finally gets committed to the ledger. Once committed, will be good to verify the chaincode state (say using a query)

dave.enyeart (Fri, 10 Mar 2017 13:57:39 GMT):
Thanks @ruslan.kryukov CouchDB has not yet gone through optimization, performance, stress test. That will be done under https://jira.hyperledger.org/browse/FAB-2725

ruslan.kryukov (Fri, 10 Mar 2017 14:00:27 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=m5i8LyAFdsGLJu5Ej) @muralisr well, I checked that too, result was successful, I had correct envelope from block, but in this case test was slow because each transaction spent about 1-2 seconds

yury (Fri, 10 Mar 2017 14:49:29 GMT):
Please to review my PR: https://gerrit.hyperledger.org/r/#/c/7103/

JatinderBali (Fri, 10 Mar 2017 15:45:43 GMT):
Has joined the channel.

nickgaski (Fri, 10 Mar 2017 16:44:08 GMT):
https://gerrit.hyperledger.org/r/#/c/6803/ - hunting for one more +2

AdnanC (Fri, 10 Mar 2017 21:24:13 GMT):
https://gerrit.hyperledger.org/r/#/c/7099/ Config updates for the fabric-couchdb docker image, and start using it in vagrant env (already being used in CI env).

mastersingh24 (Sat, 11 Mar 2017 01:39:29 GMT):
@binhn - I think https://gerrit.hyperledger.org/r/#/c/7129/ is good to merge?

binhn (Sat, 11 Mar 2017 02:08:33 GMT):
yep, merged

greg.haskins (Sat, 11 Mar 2017 02:38:12 GMT):
simple one: https://gerrit.hyperledger.org/r/#/c/7061/

muralisr (Sat, 11 Mar 2017 16:16:45 GMT):
thanks @greg.haskins ... merged

ruslan.kryukov (Sun, 12 Mar 2017 06:48:35 GMT):
https://gerrit.hyperledger.org/r/#/c/7139/ check please

yacovm (Sun, 12 Mar 2017 07:48:19 GMT):
@ruslan.kryukov you have a merge conflict, and I left a comment

ruslan.kryukov (Sun, 12 Mar 2017 12:42:44 GMT):
closed

yacovm (Sun, 12 Mar 2017 17:11:02 GMT):
3 *Very easy* CRs They are all like 2-7 lines and very trivial (removal of dead code, log formatting fix, and a "ToString()" method) https://gerrit.hyperledger.org/r/#/c/6863 https://gerrit.hyperledger.org/r/#/c/7145 https://gerrit.hyperledger.org/r/#/c/7007 Have 1 (+2) on all of them

skarim (Mon, 13 Mar 2017 14:14:03 GMT):
Please review this documentation related change set for fabric-ca: https://gerrit.hyperledger.org/r/#/c/6759/

AdnanC (Mon, 13 Mar 2017 17:38:53 GMT):
Please review: Docker config update for fabric-couchdb https://gerrit.hyperledger.org/r/#/c/7099/

JonathanLevi (Tue, 14 Mar 2017 00:46:58 GMT):
If anyone's online... https://gerrit.hyperledger.org/r/#/c/6759 @jimthematrix ?

JonathanLevi (Tue, 14 Mar 2017 00:46:58 GMT):
If anyone's online... https://gerrit.hyperledger.org/r/#/c/6759

JonathanLevi (Tue, 14 Mar 2017 00:47:32 GMT):
I have skipped the build to save the unnecessary cycle

JonathanLevi (Tue, 14 Mar 2017 00:47:32 GMT):
I have skipped the build to save the unnecessary cycle. @jimthematrix ?

jimthematrix (Tue, 14 Mar 2017 07:39:40 GMT):
@JonathanLevi just merged 6759

aambati (Tue, 14 Mar 2017 13:12:40 GMT):
Has joined the channel.

aambati (Tue, 14 Mar 2017 13:13:03 GMT):
Please review: fabric-ca change set https://gerrit.hyperledger.org/r/#/c/7079

yacovm (Tue, 14 Mar 2017 13:53:28 GMT):
Simple log-level change in 2 files https://gerrit.hyperledger.org/r/#/c/7183/ to make gossip logging less verbose

yacovm (Tue, 14 Mar 2017 13:53:28 GMT):
Simple log-level change in 2 files https://gerrit.hyperledger.org/r/#/c/7183/ to make gossip logging less verbose Already got 1 +2

jimthematrix (Tue, 14 Mar 2017 18:12:09 GMT):
so I think two from node SDK should be merged asap: https://gerrit.hyperledger.org/r/#/c/7063/ - gets the local mspid to be set by the app when the user enrollment is set https://gerrit.hyperledger.org/r/#/c/7135/ - the TLS support for node sdk (fabric-client only, fabric-ca-client TLS support is being worked on)

jimthematrix (Tue, 14 Mar 2017 18:12:59 GMT):
@mastersingh24 @binhn @yacovm @vpaprots @muralisr

jimthematrix (Tue, 14 Mar 2017 18:12:59 GMT):
@mastersingh24 @binhn @yacovm @vpaprots @muralisr ^^^

jimthematrix (Tue, 14 Mar 2017 18:18:42 GMT):
need you guy's help to get 7063 merged first, then I may need to rebase 7135

binhn (Tue, 14 Mar 2017 19:49:22 GMT):
@jimthematrix merged 7063

mastersingh24 (Tue, 14 Mar 2017 19:58:57 GMT):
this one should take care of TLS between the node sdk and fabric-ca: https://gerrit.hyperledger.org/r/#/c/7207/

jimthematrix (Tue, 14 Mar 2017 20:32:04 GMT):
https://gerrit.hyperledger.org/r/#/c/7135/ has been rebased, @binhn @mastersingh24

jimthematrix (Tue, 14 Mar 2017 20:54:00 GMT):
note that 7135 needs a CI job update to clear the verify (docker-compose.yaml location change): fab-2786

binhn (Tue, 14 Mar 2017 21:37:25 GMT):
@bmos299 i am assuming you're on fab-2786

dave.enyeart (Tue, 14 Mar 2017 21:48:43 GMT):
@binhn Can these two updates go in? No impact to main path: https://gerrit.hyperledger.org/r/#/c/7099/ fabric-couchdb docker image configuration

dave.enyeart (Tue, 14 Mar 2017 21:48:43 GMT):
@binhn Can these two updates go in? No impact to main path: https://gerrit.hyperledger.org/r/#/c/7099/ fabric-couchdb docker image configuration https://gerrit.hyperledger.org/r/#/c/7097/ add couchdb option to e2e docker compose

binhn (Tue, 14 Mar 2017 21:52:31 GMT):
@dave.enyeart on 7097, e2e status: FAILURE (skipped) -- is this contributing to the e2e test?

dave.enyeart (Tue, 14 Mar 2017 22:02:21 GMT):
@binhn I believe those e2e tests have been failing for more changesets. The only update here that impacts e2e test is that orderer timeout is changed from 10s to 2s since the long delay was causing some problems

dave.enyeart (Tue, 14 Mar 2017 22:02:21 GMT):
@binhn I believe those e2e tests have been failing for most changesets. The only update here that impacts e2e test is that orderer timeout is changed from 10s to 2s since the long delay was causing some problems

binhn (Tue, 14 Mar 2017 22:08:38 GMT):
@dave.enyeart ok, thanks

dhuseby (Tue, 14 Mar 2017 22:54:59 GMT):
Has joined the channel.

binhn (Tue, 14 Mar 2017 22:57:10 GMT):
@bmos299 @jimthematrix https://gerrit.hyperledger.org/r/#/c/7135 has been merged

jimthematrix (Tue, 14 Mar 2017 23:07:00 GMT):
Thanks @binhn !

jeffgarratt (Wed, 15 Mar 2017 02:39:21 GMT):
@binhn @mastersingh24 @muralisr @jyellick @jimthematrix https://gerrit.hyperledger.org/r/#/c/7219/

mastersingh24 (Wed, 15 Mar 2017 11:09:58 GMT):
@jimthematrix - updates made to https://gerrit.hyperledger.org/r/#/c/7207

mastersingh24 (Wed, 15 Mar 2017 11:10:25 GMT):
anyone takers for a small one: https://gerrit.hyperledger.org/r/#/c/7177/

jimthematrix (Wed, 15 Mar 2017 12:30:30 GMT):
thanks Gari, I'll take a look after a call I have at 8:30

mychewcents (Wed, 15 Mar 2017 12:31:37 GMT):
Has joined the channel.

smithbk (Wed, 15 Mar 2017 13:51:55 GMT):
pls review https://gerrit.hyperledger.org/r/#/c/7167/ ... this is a very small doc update for fabric-ca ... thanks

smithbk (Wed, 15 Mar 2017 19:04:28 GMT):
pls review https://gerrit.hyperledger.org/r/#/c/7237 ... this is a code fix but very small also. It fixes a problem in where the home directory is created for the fabric-ca-client when a env variable is created. I discovered this when verifying the readthedocs against the latest build

smithbk (Wed, 15 Mar 2017 19:04:28 GMT):
pls review https://gerrit.hyperledger.org/r/#/c/7237 ... this is a code fix but very small also. It fixes a problem in where the home directory is created for the fabric-ca-client when a env variable is set. I discovered this when verifying the readthedocs against the latest build

jimthematrix (Wed, 15 Mar 2017 20:18:05 GMT):
https://gerrit.hyperledger.org/r/#/c/7225/ - test code fix only, to get passed failures in s390 CI builds (which in theory would happen anywhere because the way the old test code was written it's not deterministic as far as timing sequence is concerns among the different promise chains) @yacovm @binhn @mastersingh24

jimthematrix (Wed, 15 Mar 2017 20:18:05 GMT):
https://gerrit.hyperledger.org/r/#/c/7225/ - test code fix only, to get past failures in s390 CI builds (which in theory would happen anywhere because the way the old test code was written it's not deterministic as far as timing sequence is concerns among the different promise chains) @yacovm @binhn @mastersingh24

jimthematrix (Wed, 15 Mar 2017 20:18:05 GMT):
https://gerrit.hyperledger.org/r/#/c/7225/ - test code fix only, to get past failures in s390 CI builds (which in theory could happen anywhere because the way the old test code was written it's not deterministic as far as timing sequence is concerns among the different promise chains) @yacovm @binhn @mastersingh24

jimthematrix (Wed, 15 Mar 2017 20:18:05 GMT):
https://gerrit.hyperledger.org/r/#/c/7225/ - test code fix only, to get past failures in s390 CI builds (which in theory could happen anywhere because the way the old test code was written it's not deterministic as far as timing sequence is concerned among the different promise chains) @yacovm @binhn @mastersingh24

mastersingh24 (Wed, 15 Mar 2017 20:55:46 GMT):
@jimthematrix - merged

jimthematrix (Wed, 15 Mar 2017 20:56:02 GMT):
thanks!

harsha (Thu, 16 Mar 2017 13:03:29 GMT):
Need some +2's on this PR:- https://gerrit.hyperledger.org/r/#/c/7161/

mrkiouak (Thu, 16 Mar 2017 13:29:50 GMT):
Has joined the channel.

JonathanLevi (Thu, 16 Mar 2017 13:31:29 GMT):
@harsha: Merged. Thank you vm!

harsha (Thu, 16 Mar 2017 14:28:20 GMT):
Thank you @JonathanLevi 😀

jyellick (Thu, 16 Mar 2017 17:22:42 GMT):
Have a whole series that needs some love: [FAB-2758] Decouple anchor peers endpoints from orgIDs https://gerrit.hyperledger.org/r/#/c/7155/ [FAB-2646] (PA) Create consortium configuration https://gerrit.hyperledger.org/r/#/c/6889/ [FAB-2702] (PA) Specify consortium in chan config https://gerrit.hyperledger.org/r/#/c/7047/ [FAB-2703] (PA) Expose committed configEnvelope https://gerrit.hyperledger.org/r/#/c/7049/ [FAB-2783] (PA) configtxgen specify admin principl https://gerrit.hyperledger.org/r/#/c/7209/ [FAB-1302] (PA) Add channel create authorization https://gerrit.hyperledger.org/r/#/c/7105/ [FAB-2723] (PA) Remove old ChainCreationPolicyName https://gerrit.hyperledger.org/r/#/c/7107/ [FAB-2729] (PA) Document the configtx https://gerrit.hyperledger.org/r/#/c/7115/ [FAB-2735] (PA) Clean up config mocks https://gerrit.hyperledger.org/r/#/c/7125/

mastersingh24 (Thu, 16 Mar 2017 17:29:00 GMT):
@jyellick - how many of those changes are "breaking" changes for what we just tagged as 1.0.0-alpha?

yacovm (Thu, 16 Mar 2017 17:37:16 GMT):
The first on his list is mine, not breaking anything, just adds flexibiity

yacovm (Thu, 16 Mar 2017 17:37:16 GMT):
The first on his list is mine, does not break anything, just adds flexibiity

mastersingh24 (Thu, 16 Mar 2017 17:41:39 GMT):
to be clear, the reason for my question is because it looks like the docs might tell people to run the e2ecli sample and the only place to get it from is the fabric repo. and of course we need e2ecli to keep working. so if we change it for any reason, then people using it with the alpha images will be broken.

mastersingh24 (Thu, 16 Mar 2017 17:42:24 GMT):
So to avoid that, perhaps we'll need to ZIP up the e2ecli sample as is today and have people download the ZIP rather than get it from the repo

jyellick (Thu, 16 Mar 2017 17:47:39 GMT):
FAB-1302 / Gerrit-7105 is the breaking one. Everything before that I believe should be benign.

jyellick (Thu, 16 Mar 2017 17:58:08 GMT):
(But really, I would say if we want to point people to the fabric repo, we need to point them to the alpha commit, or, fork them a branch to point them to)

mastersingh24 (Thu, 16 Mar 2017 18:00:34 GMT):
I personally don't want to point people at the fabric repo

mastersingh24 (Thu, 16 Mar 2017 18:01:01 GMT):
and uses tags and branches will confuse many people who just want to use the stuff anyway

mastersingh24 (Thu, 16 Mar 2017 18:02:50 GMT):
@greg.haskins - 2 questions: 1) would you be opposed to adding the ZIP of just the e2ecli sample (or maybe all the samples) to https://github.com/hyperledger/fabric/releases ? (I know they are in the ZIP but would be nice to just have a samples ZIP) 2) how hard would it be to do that?

greg.haskins (Thu, 16 Mar 2017 18:04:09 GMT):
@mastersingh24 we should probably shift to nexus.hyperledger.org vs gh releases

greg.haskins (Thu, 16 Mar 2017 18:04:27 GMT):
but once that happens, I think it would be trivial for CI to publish what we want

greg.haskins (Thu, 16 Mar 2017 18:04:44 GMT):
I have no opinion on the e2e zip file being included

mastersingh24 (Thu, 16 Mar 2017 18:13:32 GMT):
does nexus have a public download?

greg.haskins (Thu, 16 Mar 2017 18:13:56 GMT):
it certainly can, but I cant speak as to how its currently configured

mastersingh24 (Thu, 16 Mar 2017 18:15:01 GMT):
so what would you suggest in the short term (meaning say today ;) ) ?

baohua (Fri, 17 Mar 2017 01:25:47 GMT):
dear all, here's a simple patchset 2 weeks ago, hope anyone can help give ur comments, thanks! https://gerrit.hyperledger.org/r/#/c/6775/

RahulBagaria (Fri, 17 Mar 2017 04:03:22 GMT):
Has joined the channel.

mastersingh24 (Fri, 17 Mar 2017 16:54:26 GMT):
an easy one with no effect on the e2e - https://gerrit.hyperledger.org/r/#/c/7205/ (added a few handy features to cryptogen)

muralisr (Fri, 17 Mar 2017 17:20:00 GMT):
@mastersingh24 so basically generate an MSP (admincerts,signcerts, key and certs) and make it useable for TLS ?

muralisr (Fri, 17 Mar 2017 17:20:49 GMT):
I thought it already did the former ?

mastersingh24 (Fri, 17 Mar 2017 17:26:01 GMT):
I added a feature to actually generate user certs and and admin cert for each org

mastersingh24 (Fri, 17 Mar 2017 17:26:01 GMT):
I added a feature to actually generate user certs and an admin cert for each org

mastersingh24 (Fri, 17 Mar 2017 17:26:15 GMT):
admincerts takes an explicit cert not a root cert - so i fixed that as well

mastersingh24 (Fri, 17 Mar 2017 17:26:53 GMT):
the certs can now be used for TLS as well with openssl clients (without the key usage openssl clients - used by Node, Python, etc - will reject the certs)

mastersingh24 (Fri, 17 Mar 2017 17:27:39 GMT):
they should provide the material required when channel create require authorization

mastersingh24 (Fri, 17 Mar 2017 17:27:39 GMT):
this should also provide all the material required for when channel create requires authorization (which is in one of Jason's CRs)

yacovm (Fri, 17 Mar 2017 17:29:13 GMT):
But why do we need root CA certs to be used as TLS server certs?

yacovm (Fri, 17 Mar 2017 17:30:13 GMT):
isn't what's done in https://gerrit.hyperledger.org/r/#/c/7205/2/common/tools/cryptogen/ca/generator.go@103 enough

yacovm (Fri, 17 Mar 2017 17:30:13 GMT):
isn't what's done in https://gerrit.hyperledger.org/r/#/c/7205/2/common/tools/cryptogen/ca/generator.go@103 enough?

mastersingh24 (Fri, 17 Mar 2017 17:31:39 GMT):
ah - that's laziness for using the defaults for fabric-ca which use the same certs for both signing and TLS if you don't explicitly provide TLS certs

mastersingh24 (Fri, 17 Mar 2017 17:31:39 GMT):
ah - that's laziness for using the defaults for fabric-ca which uses the same certs for both signing and TLS if you don't explicitly provide TLS certs

mastersingh24 (Fri, 17 Mar 2017 17:32:39 GMT):
line 103 is used when the CA signs a cert but not for creating it's own self-signed cert

yacovm (Fri, 17 Mar 2017 17:33:22 GMT):
yeah, I understand that. I thought it was for fabric-CA but didn't know `cryptogen` was supposed to be used also for `fabric-ca`.

yacovm (Fri, 17 Mar 2017 17:33:22 GMT):
> line 103 is used when the CA signs a cert but not for creating it's own self-signed cert yeah, I understand that. I thought it was for fabric-CA but didn't know `cryptogen` was supposed to be used also for `fabric-ca`.

mastersingh24 (Fri, 17 Mar 2017 18:03:55 GMT):
you don't have to use fabric-ca, but if you wanted to add more users or peers to your org, you could use the stuff in the `ca` folder to start a fabric-ca for your org

jimthematrix (Fri, 17 Mar 2017 18:29:21 GMT):
https://gerrit.hyperledger.org/r/#/c/7317/ - integrated documentation combining API references (generated from jsdoc comments) and tutorials (hand-written .md files), @mastersingh24 @cbf @yacovm

jimthematrix (Fri, 17 Mar 2017 18:30:36 GMT):
the rendered content will look like this: https://jimthematrix.github.io/

muralisr (Fri, 17 Mar 2017 21:01:51 GMT):
https://gerrit.hyperledger.org/r/#/c/7319 simple fix to reenable dev mode along with chaincode dev mode documentation @nickgaski @greg.haskins @mastersingh24

dave.enyeart (Fri, 17 Mar 2017 22:20:22 GMT):
https://gerrit.hyperledger.org/r/#/c/7251/ - fixes to get e2e instructions working

JonathanLevi (Fri, 17 Mar 2017 23:53:27 GMT):
@muralisr, @dave.enyeart: approved & merged. I agree with keeping the devmode flag at this point, btw.

muralisr (Fri, 17 Mar 2017 23:54:48 GMT):
thanks @JonathanLevi

JonathanLevi (Sat, 18 Mar 2017 00:07:08 GMT):
In theory ;-)

jimthematrix (Sat, 18 Mar 2017 04:45:46 GMT):
two doc related ones: https://gerrit.hyperledger.org/r/#/c/7317/ https://gerrit.hyperledger.org/r/#/c/7317/

harsha (Sat, 18 Mar 2017 16:29:25 GMT):
Needs review for `fabric-ca openldap` testing :- https://gerrit.hyperledger.org/r/#/c/6899/4/

harsha (Mon, 20 Mar 2017 13:57:37 GMT):
Need some +2's on this one https://gerrit.hyperledger.org/r/#/c/6899/4 (openldap docker creation)

jeffgarratt (Mon, 20 Mar 2017 20:09:52 GMT):
@binhn @muralisr @jyellick @bmos299 https://gerrit.hyperledger.org/r/#/c/7227/

jeffgarratt (Mon, 20 Mar 2017 20:11:10 GMT):
the above makes the concept of minimum 3 orderers consistent across solo/kafka consensus types

jeffgarratt (Mon, 20 Mar 2017 20:11:34 GMT):
and adds couchdb mixin configuration support

greg.haskins (Tue, 21 Mar 2017 00:53:46 GMT):
@cbf made the requested changes: https://gerrit.hyperledger.org/r/#/c/7163/

smithbk (Tue, 21 Mar 2017 11:52:05 GMT):
fabric-ca readthedocs update: https://gerrit.hyperledger.org/r/#/c/7273/

yacovm (Tue, 21 Mar 2017 14:16:28 GMT):
Easy 1-liner bug fix : https://gerrit.hyperledger.org/r/#/c/7365/

yacovm (Tue, 21 Mar 2017 14:16:28 GMT):
Easy 1-liner bug fix : https://gerrit.hyperledger.org/r/#/c/7365/ already got 1 +2 ( @JonathanLevi am I doing it right?)

nickgaski (Tue, 21 Mar 2017 14:57:40 GMT):
@here https://gerrit.hyperledger.org/r/#/c/7285/ - really need this merged. We are linking to it from some external locations and those links are currently broken

nickgaski (Tue, 21 Mar 2017 14:57:47 GMT):
sorry for mass broadcast

greg.haskins (Tue, 21 Mar 2017 17:16:56 GMT):
need some eyes on https://gerrit.hyperledger.org/r/#/c/6991/ and https://gerrit.hyperledger.org/r/#/c/7163/

greg.haskins (Tue, 21 Mar 2017 17:17:07 GMT):
been languishing for a while now

greg.haskins (Tue, 21 Mar 2017 17:17:39 GMT):
6991 requires a sign-off by @muralisr IMO

jeffgarratt (Tue, 21 Mar 2017 18:13:49 GMT):
@binhn @muralisr @jyellick @bmos299 https://gerrit.hyperledger.org/r/#/c/7227/ Updated per Jason's comments

baohua (Wed, 22 Mar 2017 09:11:23 GMT):
hi, 2 quick patchset updated according to comments, thanks for review: https://gerrit.hyperledger.org/r/#/c/6775/ and https://gerrit.hyperledger.org/r/#/c/7375/

C0rWin (Wed, 22 Mar 2017 09:16:29 GMT):
last +2 needed: https://gerrit.hyperledger.org/r/#/c/6895/

C0rWin (Wed, 22 Mar 2017 09:16:29 GMT):
last +2 needed: https://gerrit.hyperledger.org/r/#/c/6895/, hanging there for almost two weeks now

baohua (Wed, 22 Mar 2017 09:26:42 GMT):
a little slow review recently, aha, most guys are too busy.

yacovm (Wed, 22 Mar 2017 09:31:00 GMT):
I gave a comment on 1 of them @baohua , for the validation one I added @jyellick to the reviewers, it could be nice if he takes a look

baohua (Wed, 22 Mar 2017 11:25:24 GMT):
thanks! @yacovm

jeffgarratt (Wed, 22 Mar 2017 13:44:32 GMT):
@yacovm here is the one I referred to https://gerrit.hyperledger.org/r/#/c/7227/

sanchezl (Thu, 23 Mar 2017 01:39:13 GMT):
Now that alpha has been tagged, the following need to be merged for Java Chaincode to work: • https://gerrit.hyperledger.org/r/6959 • https://gerrit.hyperledger.org/r/7089

matanyahu (Thu, 23 Mar 2017 10:58:03 GMT):
Has joined the channel.

nickgaski (Thu, 23 Mar 2017 13:22:29 GMT):
https://gerrit.hyperledger.org/r/#/c/5717/ - needs one more

nickgaski (Thu, 23 Mar 2017 13:23:17 GMT):
https://gerrit.hyperledger.org/r/#/c/7285 - this is the release testing doc that we are linking to from external locations. Need it merged

smithbk (Thu, 23 Mar 2017 13:46:48 GMT):
https://gerrit.hyperledger.org/r/#/c/7273/ - a fabric-ca readthedocs update to match alpha code. This would be really useful to folks starting to use it

smithbk (Thu, 23 Mar 2017 13:47:57 GMT):
And https://gerrit.hyperledger.org/r/#/c/6955/ fixes a defect which multiple folks have already encountered while working with alpha code

smithbk (Thu, 23 Mar 2017 13:48:05 GMT):
Thanks

harsha (Thu, 23 Mar 2017 13:53:42 GMT):
Need some +2's on this one https://gerrit.hyperledger.org/r/#/c/6899/4 (openldap docker creation)

nickgaski (Thu, 23 Mar 2017 19:39:54 GMT):
@cbf - can you hit https://gerrit.hyperledger.org/r/#/c/5717

muralisr (Thu, 23 Mar 2017 19:55:26 GMT):
@greg.haskins at a high level the idea behind 6991 looks sound and as we discussed, with the end goal to provide parity with SDKs so all modes will generate the same chaincode, strengthens 6991. I'd like to spend sometime pulling it down and playing but plan to complete the review over the weekend ....thanks for your patience!

smithbk (Thu, 23 Mar 2017 20:01:33 GMT):
A very easy one for fabric-ca: https://gerrit.hyperledger.org/r/#/c/7401 thanks

cbf (Thu, 23 Mar 2017 20:02:41 GMT):
@nickgaski done

C0rWin (Thu, 23 Mar 2017 20:10:33 GMT):
https://gerrit.hyperledger.org/r/#/c/7395/ adds ability to peer cli to query for list of channels peer has joined

baohua (Fri, 24 Mar 2017 07:10:57 GMT):
a easy remove of unused doc file patchset, thanks for review: http://gerrit.hyperledger.org/r/7415

baohua (Fri, 24 Mar 2017 07:10:57 GMT):
a easy removing of an unused doc file patchset, thanks for helping review: http://gerrit.hyperledger.org/r/7415

joe-alewine (Fri, 24 Mar 2017 13:59:13 GMT):
Has joined the channel.

mastersingh24 (Fri, 24 Mar 2017 14:16:26 GMT):
can we get some eyes on this important series from @jyellick - https://gerrit.hyperledger.org/r/#/q/owner:jyellick%2540us.ibm.com+status:open

yacovm (Fri, 24 Mar 2017 15:17:56 GMT):
You can do a cascading merge for FABs 2693-2695

yacovm (Fri, 24 Mar 2017 15:17:56 GMT):
You can do a cascading merge for FABs 2693-2695 starting from https://gerrit.hyperledger.org/r/#/c/7019

harsha (Fri, 24 Mar 2017 17:46:46 GMT):
Need some +2's on this one https://gerrit.hyperledger.org/r/#/c/6899/4 (openldap docker creation) https://gerrit.hyperledger.org/r/#/c/6899/4

nickgaski (Fri, 24 Mar 2017 18:56:09 GMT):
https://gerrit.hyperledger.org/r/#/c/7429/ - this is a refactored getting started section. Preview available here - http://fabric-rtd.readthedocs.io/en/latest/v1start.html @mastersingh24 @cbf @muralisr (while I realize it's probably not perfect, it is reflective of our current architecture, whereas the sfhackfest content is way way out of date)

mastersingh24 (Fri, 24 Mar 2017 19:17:11 GMT):
https://gerrit.hyperledger.org/r/#/c/7115/16

baohua (Sat, 25 Mar 2017 03:07:46 GMT):
https://gerrit.hyperledger.org/r/#/c/6775/, with several round of reviews. now guess it should be OK, thanks!

mastersingh24 (Sat, 25 Mar 2017 14:09:01 GMT):
for anyone around, a pretty easy one I think: https://gerrit.hyperledger.org/r/#/c/7443/ (adds the option to build without PKCS11 support ;) )

harsha (Sat, 25 Mar 2017 17:03:10 GMT):
This one needs a submit https://gerrit.hyperledger.org/r/#/c/6899/4

muralisr (Sun, 26 Mar 2017 15:51:07 GMT):
@mastersingh24 are the CI failures https://gerrit.hyperledger.org/r/#/c/7443 be fixed by https://gerrit.hyperledger.org/r/#/c/7449 ? I couldn't tell... if so perhaps a rebase and push ?

mastersingh24 (Sun, 26 Mar 2017 15:57:38 GMT):
7449 is what we want. somehow I must have messed things up - I thought I was pushing 7443 on top of 7449 but must have reversed it somehow

harrijk (Sun, 26 Mar 2017 16:22:17 GMT):
https://gerrit.hyperledger.org/r/#/c/6905/ ... thanks

harsha (Sun, 26 Mar 2017 16:26:14 GMT):
This one needs a submit https://gerrit.hyperledger.org/r/#/c/6899/4 , thank you

yacovm (Sun, 26 Mar 2017 16:26:23 GMT):
@harrijk this is a week old, have you tried locally rebasing it on top of a latest master?

harrijk (Sun, 26 Mar 2017 16:26:52 GMT):
i'll do that now. thanks

yacovm (Sun, 26 Mar 2017 16:27:29 GMT):
give me a ping and I'll +2 it

harrijk (Sun, 26 Mar 2017 16:28:03 GMT):
```$ git rebase origin/master Current branch couchdb-docker-fix is up to date. ```

yacovm (Sun, 26 Mar 2017 16:28:30 GMT):
no I meant *[FAB-2651] Single path to unit-testing keystore*

harrijk (Sun, 26 Mar 2017 16:29:08 GMT):
sorry... wrong patch. my bad.

harrijk (Sun, 26 Mar 2017 16:30:00 GMT):
```$ git co keystore-loc-fix Switched to branch 'keystore-loc-fix' jharris@proteus ~/git/fabric (keystore-loc-fix) $ git rebase origin/master Current branch keystore-loc-fix is up to date. ```

harrijk (Sun, 26 Mar 2017 16:30:09 GMT):
This is what Vegas does to me. :)

yacovm (Mon, 27 Mar 2017 10:02:40 GMT):
2 Change sets for review- let's make the connection from peer to ordering service highly available and only on demand instead of brittle and persistent: https://gerrit.hyperledger.org/r/#/c/7337/ https://gerrit.hyperledger.org/r/#/c/7343/14

mastersingh24 (Mon, 27 Mar 2017 13:36:16 GMT):
a few easy ones for fabric-ca : https://gerrit.hyperledger.org/r/6955 https://gerrit.hyperledger.org/r/7379 https://gerrit.hyperledger.org/r/7397 https://gerrit.hyperledger.org/r/7403 (I'll merge if someone else can give the additonal +2

mastersingh24 (Mon, 27 Mar 2017 13:36:16 GMT):
a few easy ones for fabric-ca : https://gerrit.hyperledger.org/r/6955 https://gerrit.hyperledger.org/r/#/c/7261/ https://gerrit.hyperledger.org/r/7379 https://gerrit.hyperledger.org/r/7397 https://gerrit.hyperledger.org/r/7403 (I'll merge if someone else can give the additonal +2's needed)

vpaprots (Mon, 27 Mar 2017 14:05:44 GMT):
Could use a review: https://gerrit.hyperledger.org/r/#/c/6727/ @smithbk @mastersingh24

mastersingh24 (Mon, 27 Mar 2017 14:10:27 GMT):
https://gerrit.hyperledger.org/r/#/c/7443/ could use some love as well (note I marked it as verified because CI unit tests actually passed - see link in comment - but the CI job puked)

smithbk (Mon, 27 Mar 2017 14:11:17 GMT):
@vpaprots Could you fix the merge conflict 1st on https://gerrit.hyperledger.org/r/#/c/6727 ?

nickgaski (Mon, 27 Mar 2017 15:55:45 GMT):
https://gerrit.hyperledger.org/r/#/c/7285/ - @mastersingh24 - this one needs some votes

smithbk (Mon, 27 Mar 2017 15:58:37 GMT):
And this one which is fabric-ca readthedocs

smithbk (Mon, 27 Mar 2017 15:58:39 GMT):
https://gerrit.hyperledger.org/r/#/c/7273/

yacovm (Mon, 27 Mar 2017 16:01:52 GMT):
@mastersingh24 I +2ed the TLS client time checking but it's based on https://gerrit.hyperledger.org/r/#/c/7179

jeffgarratt (Mon, 27 Mar 2017 20:23:51 GMT):
@binhn @muralisr @mastersingh24 update to latest proto changes from @jyellick https://gerrit.hyperledger.org/r/#/c/7477/

jeffgarratt (Mon, 27 Mar 2017 20:23:51 GMT):
@binhn @muralisr @mastersingh24 update BDD to latest proto changes from @jyellick https://gerrit.hyperledger.org/r/#/c/7477/

muralisr (Tue, 28 Mar 2017 13:45:19 GMT):
@jeffgarratt the CI has failed for behave... is that expected (ie, WIP or something ?)

jeffgarratt (Tue, 28 Mar 2017 13:45:42 GMT):
talking to Greg now

muralisr (Tue, 28 Mar 2017 13:45:46 GMT):
ok

jeffgarratt (Tue, 28 Mar 2017 13:45:50 GMT):
seems zookeeper image is not there

jeffgarratt (Tue, 28 Mar 2017 13:45:55 GMT):
the CR is ready to go

muralisr (Tue, 28 Mar 2017 13:45:57 GMT):
ok

jeffgarratt (Tue, 28 Mar 2017 13:46:13 GMT):
wanted to get both Kafka and solo in for CI

muralisr (Tue, 28 Mar 2017 13:46:31 GMT):
ok.

muralisr (Tue, 28 Mar 2017 13:47:23 GMT):
are you planning to make more changes to the CR to get BDD to work or will that be a future CR ?

jeffgarratt (Tue, 28 Mar 2017 13:49:36 GMT):
will see if I can tweak this one real quick

muralisr (Tue, 28 Mar 2017 13:49:47 GMT):
ok

muralisr (Tue, 28 Mar 2017 13:51:56 GMT):
an easy CR for a bug fix please https://gerrit.hyperledger.org/r/#/c/7453/.... we should not be returninng errors if proposal response status is less than 500

jeffgarratt (Tue, 28 Mar 2017 15:06:14 GMT):
one more time.... @binhn @muralisr @mastersingh24 update BDD to latest proto changes from @jyellick https://gerrit.hyperledger.org/r/#/c/7477/

C0rWin (Tue, 28 Mar 2017 15:29:32 GMT):
Simple CR: https://gerrit.hyperledger.org/r/#/c/7501/ to produce baseimages for ARM platform, needed this to build hyperledger for RPi device

dave.enyeart (Tue, 28 Mar 2017 15:49:24 GMT):
https://gerrit.hyperledger.org/r/#/c/7081/ Fixes to intermittent couch unit test failures

smithbk (Tue, 28 Mar 2017 16:47:38 GMT):
https://gerrit.hyperledger.org/r/6727 Fabric CA BCCSP integration

smithbk (Tue, 28 Mar 2017 16:48:30 GMT):
https://gerrit.hyperledger.org/r/7273 Fabric CA readthedocs

jimthematrix (Tue, 28 Mar 2017 18:05:35 GMT):
https://gerrit.hyperledger.org/r/#/c/7503/ - node sdk custom endorsement policy support using json format as policy spec, @cbf @mastersingh24 @binhn @aso @yacovm

baohua (Wed, 29 Mar 2017 01:49:14 GMT):
Enhance the linter checking, need another +2, thanks! https://gerrit.hyperledger.org/r/#/c/7497/

jimthematrix (Wed, 29 Mar 2017 04:39:23 GMT):
https://gerrit.hyperledger.org/r/#/c/7503 - node sdk custom endorsement policy support using json format as policy spec, @cbf @mastersingh24 @binhn @aso @yacovm https://gerrit.hyperledger.org/r/#/c/7523 - re-enroll() API, last remaining fabric-ca API to support

mastersingh24 (Wed, 29 Mar 2017 12:27:29 GMT):
@dave.enyeart - what do you want to do with https://gerrit.hyperledger.org/r/#/c/7303/ ?

dave.enyeart (Wed, 29 Mar 2017 12:28:04 GMT):
i think we should do it, i'll review today

mastersingh24 (Wed, 29 Mar 2017 12:29:20 GMT):
gracias

troyronda (Wed, 29 Mar 2017 14:24:51 GMT):
Has joined the channel.

troyronda (Wed, 29 Mar 2017 14:30:18 GMT):
Small patch to fix docker-compose usage in fabric's unit-test (when docker-compose down isn't called at the end of unit test and make dist-clean all is then invoked you will then get "No Such Image" until docker-compose rm or down is manually invoked: https://gerrit.hyperledger.org/r/#/c/7447/

troyronda (Wed, 29 Mar 2017 14:30:32 GMT):
(known issue in docker-compose: https://github.com/docker/compose/issues/1113)

JonathanLevi (Wed, 29 Mar 2017 15:57:19 GMT):
@troyronda: a nice one!

mastersingh24 (Wed, 29 Mar 2017 17:21:43 GMT):
https://gerrit.hyperledger.org/r/#/c/7525/ - simple yet important fix from @kostas

yacovm (Wed, 29 Mar 2017 17:29:31 GMT):
Can be merged if the change set it is based on is also merged (I +2ed it)

jimthematrix (Wed, 29 Mar 2017 19:39:55 GMT):
need these reviewed asap, been sitting there for a while: https://gerrit.hyperledger.org/r/#/c/7503 - custom endorsement policy support using json format as policy spec. patch 4 added a custom policy to the e2e tests to show that the new support works fine with fabric https://gerrit.hyperledger.org/r/#/c/7523 - re-enroll() API, last remaining fabric-ca API to support

jimthematrix (Wed, 29 Mar 2017 19:40:34 GMT):
@mastersingh24 @yacovm @binhn @aso

mastersingh24 (Wed, 29 Mar 2017 20:14:59 GMT):
@jimthematrix - sorry - I had reviewed and then never commented - 7523 looks good, but checkout my comment on 7503

jimthematrix (Wed, 29 Mar 2017 20:31:28 GMT):
@mastersingh24 good question on 7503, I added a proposal in my response, please let me know your thoughts

mastersingh24 (Wed, 29 Mar 2017 20:35:42 GMT):
posted my response - but I'm ok with what you proposed or some type of quick explanation / comment in the sample. up to you

jimthematrix (Wed, 29 Mar 2017 20:43:42 GMT):
@mastersingh24 actually, this was explained already in the jsdoc for the typedef EndorsementPolicy: https://gerrit.hyperledger.org/r/#/c/7503/4/fabric-client/lib/Policy.js line 55

jimthematrix (Wed, 29 Mar 2017 20:45:26 GMT):
the type is linked from the jsdoc for the sendInstantiate() where the endorsement-policy property is described

jimthematrix (Wed, 29 Mar 2017 20:46:20 GMT):
(when this gets merged and the generated html gets published it'll look more prominent)

jimthematrix (Wed, 29 Mar 2017 20:49:43 GMT):
here's a preview: https://jimthematrix.github.io/Chain.html#sendInstantiateProposal__anchor

mastersingh24 (Wed, 29 Mar 2017 20:53:23 GMT):
ah yes - I did not follow enough links - cool - will merge

nickgaski (Wed, 29 Mar 2017 21:04:55 GMT):
https://gerrit.hyperledger.org/r/#/c/7429/5 - this is in high demand. If we can get it eyes on it I will make some final adjustments and then hopefully get it out into the world. Should be close. We've had multiple folks go through it with no errors. @cbf @mastersingh24 @binhn @muralisr

mastersingh24 (Wed, 29 Mar 2017 21:16:48 GMT):
@nickgaski - see my comments. I know you can't really address the one about tools / binaries on your own, but we can't be pointing people to Nexus

mastersingh24 (Wed, 29 Mar 2017 21:25:44 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/7333/

greg.haskins (Thu, 30 Mar 2017 13:18:18 GMT):
Needs some love: https://gerrit.hyperledger.org/r/#/c/7163/

muralisr (Thu, 30 Mar 2017 13:41:51 GMT):
@greg.haskins sorry about that... was going to ask you if that was ready (I know its been on the wings for a while)... will wait for the CI to complete

muralisr (Thu, 30 Mar 2017 13:43:31 GMT):
also https://gerrit.hyperledger.org/r/#/c/6991 ... are there tooling dependencies that need to be in place ? like we chatted, I thought I had problems running tests using docker

greg.haskins (Thu, 30 Mar 2017 14:09:53 GMT):
@muralisr I need to revisit 6991 and try to reproduce that problem you found

muralisr (Thu, 30 Mar 2017 14:10:54 GMT):
sounds good @greg.haskins .. I need to refresh memory on that too. Will try to attempt it again (don't want to send you on a wild goose chase)

greg.haskins (Thu, 30 Mar 2017 14:19:31 GMT):
@muralisr ok, cool

nickgaski (Thu, 30 Mar 2017 18:55:22 GMT):
https://gerrit.hyperledger.org/r/#/c/7429/ - @mastersingh24 @cbf (pulls from Docker Hub now)

mastersingh24 (Thu, 30 Mar 2017 20:48:17 GMT):
can someone else take a look at https://gerrit.hyperledger.org/r/#/c/7429/ as well?

muralisr (Thu, 30 Mar 2017 21:03:09 GMT):
@mastersingh24 @nickgaski +1ed for now in case @cbf or @lehors have comments

mastersingh24 (Thu, 30 Mar 2017 21:03:48 GMT):
BTW - thanks @nickgaski for bearing with us and getting this done

mastersingh24 (Thu, 30 Mar 2017 21:03:54 GMT):
this is going to be very helpful

muralisr (Thu, 30 Mar 2017 21:04:01 GMT):
meanwhile first of Chaincode Install Package up - a look please https://gerrit.hyperledger.org/r/#/c/7591/ .

mastersingh24 (Thu, 30 Mar 2017 21:04:23 GMT):
always something from you @muralisr ;)

muralisr (Thu, 30 Mar 2017 21:05:21 GMT):
one tries @mastersingh24 ;-) .. but do take a look.. I'm trying hard to do it in bite sized chunks

muralisr (Thu, 30 Mar 2017 21:05:38 GMT):
this one just has proto definition with util and tests

mastersingh24 (Thu, 30 Mar 2017 21:07:28 GMT):
will do

Honglei (Fri, 31 Mar 2017 11:17:41 GMT):
Could someone help review https://gerrit.hyperledger.org/r/#/c/7299/ ? Thanks!

kostas (Fri, 31 Mar 2017 11:52:31 GMT):
https://gerrit.hyperledger.org/r/#/c/7527/ and the changesets that depend on it

dave.enyeart (Fri, 31 Mar 2017 14:17:24 GMT):
We've got a backlog of ledger items out for review. It would make sense to review them in this order: https://gerrit.hyperledger.org/r/#/c/7567/ https://gerrit.hyperledger.org/r/#/c/7221 https://gerrit.hyperledger.org/r/#/c/7303/ https://gerrit.hyperledger.org/r/#/c/7099/ https://gerrit.hyperledger.org/r/#/c/7369/ https://gerrit.hyperledger.org/r/#/c/7191/

dave.enyeart (Fri, 31 Mar 2017 14:17:24 GMT):
We've got a backlog of ledger items out for review. It would make sense to review them in this order: https://gerrit.hyperledger.org/r/#/c/7567/ https://gerrit.hyperledger.org/r/#/c/7221 https://gerrit.hyperledger.org/r/#/c/7303/ https://gerrit.hyperledger.org/r/#/c/7573 https://gerrit.hyperledger.org/r/#/c/7099/ https://gerrit.hyperledger.org/r/#/c/7369/ https://gerrit.hyperledger.org/r/#/c/7191/

cbf (Fri, 31 Mar 2017 14:20:38 GMT):
https://gerrit.hyperledger.org/r/#/c/7583/

emir888 (Fri, 31 Mar 2017 15:18:24 GMT):
Has joined the channel.

binhn (Fri, 31 Mar 2017 17:24:53 GMT):
@sanchezl @muralisr I'd like to understand this better https://gerrit.hyperledger.org/r/#/c/6959 Is it necessary to change the proto filenames? What impact on SDKs?

sanchezl (Fri, 31 Mar 2017 17:28:38 GMT):
It's mainly a "code style" level cleanup. Best to do now before we're stuck with it post 1.0. Java SDK manually merges protos, so nothing new there for them. (IMO, I've made it easier to merge as they now don't have to add package names every time)

binhn (Fri, 31 Mar 2017 17:30:20 GMT):
what about nodejs and py? also py in bdd?

binhn (Fri, 31 Mar 2017 17:30:20 GMT):
@sanchezl what about nodejs and py? also py in bdd?

vpaprots (Fri, 31 Mar 2017 17:35:33 GMT):
https://gerrit.hyperledger.org/r/#/c/6727/ could use some eyes

binhn (Fri, 31 Mar 2017 17:39:59 GMT):
@vpaprots ok, thanks

mastersingh24 (Fri, 31 Mar 2017 17:51:11 GMT):
@cbf https://gerrit.hyperledger.org/r/#/c/7443/ - @greg.haskins - tried to address your comments. let me know if you want me to remove the PHONY targets and I'll submit an update

binhn (Fri, 31 Mar 2017 18:08:58 GMT):
@jimthematrix @baohua could you assess the impact of this changeset https://gerrit.hyperledger.org/r/#/c/6959 on nodejs sdk and py sdk - thanks.

muralisr (Fri, 31 Mar 2017 18:39:11 GMT):
@binhn `Is it necessary to change the proto filenames? ` from what I understood it helps to change the filenames so the Java side will generate nice classnames.

muralisr (Fri, 31 Mar 2017 18:40:24 GMT):
somefile.proto will generate either `class Somefile` or `class somefile` whereas "some_file" will generate `SomeFile`

muralisr (Fri, 31 Mar 2017 18:40:42 GMT):
(@sanchezl to correct above)

muralisr (Fri, 31 Mar 2017 18:40:42 GMT):
( @sanchezl to correct above)

muralisr (Fri, 31 Mar 2017 18:40:50 GMT):
so it seemed to make sense

binhn (Fri, 31 Mar 2017 18:54:55 GMT):
@sanchezl @baohua I looked at the py sdk code, and it seems that we committed both proto and generated files in the repo; that means we would have to redo this commit to get the new filenames and delete the old ones and fix up code as appropriate

binhn (Fri, 31 Mar 2017 18:59:33 GMT):
there are 3 filenames changed msp_config, chaincode_event, and chaincode_shim

emir888 (Fri, 31 Mar 2017 19:43:21 GMT):
Hi, could someone help review https://gerrit.hyperledger.org/r/#/c/7623/ Thanks

emir (Fri, 31 Mar 2017 19:44:24 GMT):
Has joined the channel.

dave.enyeart (Fri, 31 Mar 2017 19:47:09 GMT):
one down, six to go: https://gerrit.hyperledger.org/r/#/c/7221 https://gerrit.hyperledger.org/r/#/c/7303 https://gerrit.hyperledger.org/r/#/c/7573 https://gerrit.hyperledger.org/r/#/c/7099 https://gerrit.hyperledger.org/r/#/c/7369 https://gerrit.hyperledger.org/r/#/c/7191

binhn (Fri, 31 Mar 2017 20:36:27 GMT):
@dave.enyeart still on 7221 :-)

jimthematrix (Fri, 31 Mar 2017 20:53:33 GMT):
@binhn I +2'ed 6959 and added my comments. @sanchezl please make sure to submit a separate CR for the proto files in fabric-sdk-java are modified accordingly

jimthematrix (Fri, 31 Mar 2017 20:53:43 GMT):
and these changes don't affect node SDK

binhn (Fri, 31 Mar 2017 20:54:23 GMT):
@jimthematrix perfect, thanks

binhn (Fri, 31 Mar 2017 21:28:04 GMT):
@dave.enyeart could you take a look https://gerrit.hyperledger.org/r/#/c/7507/

binhn (Fri, 31 Mar 2017 21:37:47 GMT):
@dave.enyeart https://gerrit.hyperledger.org/r/#/c/7221 merge conflict

baohua (Sat, 01 Apr 2017 04:41:32 GMT):
@binhn yeap, binh, as we need to slightly modify the proto files before the generation in python implementation (due to the weak support from grpc). currently we have to maintain both the updated proto files and the generated py files. And https://gerrit.hyperledger.org/r/#/c/6959 has been merged. will look at how to follow that change, thanks!

dave.enyeart (Sat, 01 Apr 2017 09:10:13 GMT):
@binhn https://gerrit.hyperledger.org/r/#/c/7221 - Rebased!

dave.enyeart (Sat, 01 Apr 2017 09:18:26 GMT):
https://gerrit.hyperledger.org/r/#/c/7221 - rebased https://gerrit.hyperledger.org/r/#/c/7303 https://gerrit.hyperledger.org/r/#/c/7573 - review feedback applied https://gerrit.hyperledger.org/r/#/c/7099 https://gerrit.hyperledger.org/r/#/c/7369 https://gerrit.hyperledger.org/r/#/c/7191

dave.enyeart (Sat, 01 Apr 2017 09:18:26 GMT):
https://gerrit.hyperledger.org/r/#/c/7221 - rebased https://gerrit.hyperledger.org/r/#/c/7573 - review feedback applied https://gerrit.hyperledger.org/r/#/c/7099 https://gerrit.hyperledger.org/r/#/c/7369 https://gerrit.hyperledger.org/r/#/c/7191

dave.enyeart (Sat, 01 Apr 2017 10:48:31 GMT):
@binhn https://gerrit.hyperledger.org/r/#/c/7507 looks good

mastersingh24 (Sat, 01 Apr 2017 13:44:28 GMT):
@muralisr @greg.haskins can you check out https://gerrit.hyperledger.org/r/#/c/7571/ ?

binhn (Sat, 01 Apr 2017 14:58:25 GMT):
@emir888 +2d, thanks @cbf please take a look https://gerrit.hyperledger.org/r/#/c/7623

muralisr (Sat, 01 Apr 2017 15:37:11 GMT):
@mastersingh24 added 1 suggestion to https://gerrit.hyperledger.org/r/#/c/7571

muralisr (Sat, 01 Apr 2017 15:44:04 GMT):
@mastersingh24 responded to https://gerrit.hyperledger.org/r/#/c/7591

muralisr (Sat, 01 Apr 2017 15:45:37 GMT):
the endorsement was basically for some protection against the package from being modified.

mastersingh24 (Sat, 01 Apr 2017 18:56:06 GMT):
https://gerrit.hyperledger.org/r/#/c/7443/

C0rWin (Sun, 02 Apr 2017 14:30:34 GMT):
Simple CR which enables project to pass tests on Raspberry Pi devices: https://gerrit.hyperledger.org/r/#/c/7577/

C0rWin (Sun, 02 Apr 2017 14:31:15 GMT):
Another one to stop CI failing because of leader election intermittent tests: https://gerrit.hyperledger.org/r/#/c/7629/

C0rWin (Sun, 02 Apr 2017 14:31:58 GMT):
Batching of state request messages: https://gerrit.hyperledger.org/r/#/c/7635/

mastersingh24 (Sun, 02 Apr 2017 18:21:45 GMT):
https://gerrit.hyperledger.org/r/#/c/7633/ - easy doc change

muralisr (Sun, 02 Apr 2017 20:08:03 GMT):
@mastersingh24 https://gerrit.hyperledger.org/r/#/c/7591 added instantiation policy to the protos specified in the same way as endorsement policy

muralisr (Sun, 02 Apr 2017 20:09:31 GMT):
by including the policy in the LCCC record at instantiation time, we will be able to validate it uniformly at commit time on all peers in the channel (including those that don't have the chaincode installed)

mastersingh24 (Sun, 02 Apr 2017 20:10:32 GMT):
awesome

dave.enyeart (Mon, 03 Apr 2017 12:25:06 GMT):
@muralisr https://gerrit.hyperledger.org/r/#/c/7221 touches chaincode, could you review?

muralisr (Mon, 03 Apr 2017 12:26:55 GMT):
@dave.enyeart yes, I started on that late last week. Will get back to it today after putting in a CR

dave.enyeart (Mon, 03 Apr 2017 12:27:05 GMT):
thx

dave.enyeart (Mon, 03 Apr 2017 17:35:35 GMT):
This changeset fixes the CI verification errors that we've seen today: https://gerrit.hyperledger.org/r/#/c/7653/

dave.enyeart (Mon, 03 Apr 2017 17:54:52 GMT):
Thanks for merging quickly!

dave.enyeart (Tue, 04 Apr 2017 00:36:37 GMT):
quick one: https://gerrit.hyperledger.org/r/#/c/7655/

mastersingh24 (Tue, 04 Apr 2017 12:40:11 GMT):
@dave.enyeart - I merged it but maintainers - please - let's stop letting things in that are not complete. The java package should have been added in the original CR

yacovm (Tue, 04 Apr 2017 12:52:48 GMT):
Can anyone ( @muralisr / @binhn / @mastersingh24 ) take a look at Angelo's Chaincode CR? It needs to be decided whether the new chaincode shim method `GetSignedProposal() ` returns an error or not

yacovm (Tue, 04 Apr 2017 12:52:48 GMT):
Can anyone take a look at Angelo's Chaincode CR? It needs to be decided whether the new chaincode shim method `GetSignedProposal() ` returns an error or not

yacovm (Tue, 04 Apr 2017 12:52:48 GMT):
Can anyone (maintainers) take a look at Angelo's Chaincode CR? It needs to be decided whether the new chaincode shim method `GetSignedProposal() ` returns an error or not

mastersingh24 (Tue, 04 Apr 2017 12:53:59 GMT):
I'm heading into some meetings, but I'll review later. As a favor, can we not merge any of the access control or other chaincode changes until a few of us have all reviewed?

mastersingh24 (Tue, 04 Apr 2017 12:54:07 GMT):
@yacovm - thanks for pointing this out

binhn (Tue, 04 Apr 2017 13:31:16 GMT):
@yacovm ok, so either nil or not nil, but it seems that we should never get to nil condition

yacovm (Tue, 04 Apr 2017 13:34:02 GMT):
I think likewise. If doesn't make sense that you have a chaincode invocation going on, without the ability of having the signed proposal, as the signed proposal is simply passed to `init` of `chaincode.go`.

yacovm (Tue, 04 Apr 2017 13:35:47 GMT):
It's a shame that the `GetCreator` method also returns an error, since it's extracted at `init` time as well. But it's too late for that, that ship has sailed.

binhn (Tue, 04 Apr 2017 13:39:06 GMT):
good point

binhn (Tue, 04 Apr 2017 14:03:10 GMT):
unfortunately there are several that follow this pattern, including getTransient, getBinding, getArgsSlice, GetTxTimestamp , so either we change them all (may be difficult for folks) or keep the pattern for 1 more function

yacovm (Tue, 04 Apr 2017 14:05:11 GMT):
Maybe in V2.0 we can drop the error

muralisr (Tue, 04 Apr 2017 14:09:17 GMT):
can we take a look at the Java chaincode CR https://gerrit.hyperledger.org/r/#/c/7089/ please ? Its been out there for a while. Now its got a test case (with SSL too) (thanks @sanchezl )

binhn (Tue, 04 Apr 2017 14:10:45 GMT):
@yacovm agreed

vpaprots (Tue, 04 Apr 2017 14:27:51 GMT):
https://gerrit.hyperledger.org/r/#/c/6727/ please? @JonathanLevi @mastersingh24

JonathanLevi (Tue, 04 Apr 2017 14:41:47 GMT):
@muralisr @sanchezl: review comments/enquiry inline.

muralisr (Tue, 04 Apr 2017 14:43:07 GMT):
thanks @JonathanLevi

sanchezl (Tue, 04 Apr 2017 15:33:05 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=KvQZxXtocMSsHw6SD) @JonathanLevi Thanks!

greg.haskins (Tue, 04 Apr 2017 15:46:43 GMT):
a few easy ones: https://gerrit.hyperledger.org/r/#/c/7679/ https://gerrit.hyperledger.org/r/#/c/7681/

JonathanLevi (Tue, 04 Apr 2017 16:20:02 GMT):
@greg.haskins: re 7679, I suggest we do both...

JonathanLevi (Tue, 04 Apr 2017 16:20:31 GMT):
(Let's use the file mode bits and also update the mount options...)

JonathanLevi (Tue, 04 Apr 2017 16:20:40 GMT):
What do you think?

sanchezl (Tue, 04 Apr 2017 16:26:13 GMT):
@muralisr , @JonathanLevi – I've rebased https://gerrit.hyperledger.org/r/#/c/7089 and removed 1 file from the patchset.

muralisr (Tue, 04 Apr 2017 16:30:11 GMT):
@greg.haskins I keep coming back to this one thing with https://gerrit.hyperledger.org/r/#/c/6991.. While it is attractive in (1) picking up exactly what is needed from go dependencies (2) keeping the size small, the other side is that (1) user cannot add arbitrary files and (2) we have to support this in other SDKs for consistency and uniformity.. the later is not a big issue (we can package/ prereq go env in a usable manner) but the former worries me a bit. While it may sound nice to say "we will not allow anything other than go chaincode depedencies" it may have practical limitations when user wants to inject non go files.

greg.haskins (Tue, 04 Apr 2017 16:31:37 GMT):
Honestly, I think that is "ok", and here is why

greg.haskins (Tue, 04 Apr 2017 16:31:58 GMT):
in order for us to support _anything_ else other than .go files, it really needs to be a spec

greg.haskins (Tue, 04 Apr 2017 16:33:12 GMT):
that spec would encompass everything from how the chaincode deployment package is formed, how it is processed on the peer, and how it is presented and available to the chaincode application environment are not something we can just say "just in case"

greg.haskins (Tue, 04 Apr 2017 16:33:34 GMT):
for example: perhaps we model something like java ./resources and CLASSPATH

muralisr (Tue, 04 Apr 2017 16:33:43 GMT):
ok

muralisr (Tue, 04 Apr 2017 16:33:54 GMT):
I remember now touching upon that

greg.haskins (Tue, 04 Apr 2017 16:34:02 GMT):
and on the peer, we take ./resources, put it in /var/chaincode/resources, and then set an envvar

greg.haskins (Tue, 04 Apr 2017 16:34:14 GMT):
this is all fine, but it does need to be defined

greg.haskins (Tue, 04 Apr 2017 16:34:38 GMT):
until that happens, I just say KISS...that is the spec

muralisr (Tue, 04 Apr 2017 16:34:59 GMT):
I think you are right...

greg.haskins (Tue, 04 Apr 2017 16:35:00 GMT):
when/if we define whatever this enhanced feature is, lets spec it, and if necessary, create a new TYPE for it

muralisr (Tue, 04 Apr 2017 16:35:21 GMT):
let me wait for other comments (but will run the CR later today)

greg.haskins (Tue, 04 Apr 2017 16:35:40 GMT):
ok

greg.haskins (Tue, 04 Apr 2017 16:36:16 GMT):
heres my hope...that kind of enhanced usage can be captured in either chaintool, or a chaintool like utility

muralisr (Tue, 04 Apr 2017 16:36:27 GMT):
keeping it minimal lays the foundation to grow in the right direction (a la the java resource example)

greg.haskins (Tue, 04 Apr 2017 16:36:38 GMT):
i want to capture this "package" process in a tool so that the SDKs dont need to keep reimplementing it

muralisr (Tue, 04 Apr 2017 16:36:49 GMT):
yes

muralisr (Tue, 04 Apr 2017 16:36:57 GMT):
its all coming back to me :-)

greg.haskins (Tue, 04 Apr 2017 16:37:15 GMT):
so to that point, lets keep the existing GOLANG/JAVA spec simple, and we can build up from there

muralisr (Tue, 04 Apr 2017 16:37:36 GMT):
in agreement

greg.haskins (Tue, 04 Apr 2017 16:37:40 GMT):
cool

greg.haskins (Tue, 04 Apr 2017 16:38:52 GMT):
just to emphasize the point, keep in mind that today we dont preserve the code package in the runtime anyway

greg.haskins (Tue, 04 Apr 2017 16:39:04 GMT):
we only have baseos + chaincode-binary

greg.haskins (Tue, 04 Apr 2017 16:39:26 GMT):
so even if we permitted something other than .go files, it gets tossed away after compilation

muralisr (Tue, 04 Apr 2017 16:41:50 GMT):
true.. although at one point we did keep stuff around (so I remember)... or put it another way, just like we put the TLS cert, we *could* chose to put such files (as we'd have to when doing resources properly)

greg.haskins (Tue, 04 Apr 2017 17:06:44 GMT):
right, it just need to be a spec...code will rely on it, etc, so we want to treat it as any other ABI extending mechanism

greg.haskins (Tue, 04 Apr 2017 17:07:08 GMT):
e.g. we can load the code in /var/chaincode/resources today and somewhere else tomorrow

greg.haskins (Tue, 04 Apr 2017 17:07:08 GMT):
e.g. we can't load the code in /var/chaincode/resources today and somewhere else tomorrow

mastersingh24 (Tue, 04 Apr 2017 19:13:37 GMT):
@greg.haskins - then we need to define a spec for the code structure for chaincode. We can't just make arbitrary changes which basically make this stuff unusable

mastersingh24 (Tue, 04 Apr 2017 19:16:15 GMT):
BTW - did the CR which only brings in the chaincode src (and not everything under $GOPATH/src) make it in at some point?

greg.haskins (Tue, 04 Apr 2017 19:16:33 GMT):
@mastersingh24 I think we are arguing the same thing

greg.haskins (Tue, 04 Apr 2017 19:16:50 GMT):
That's 6991, needs approval

mastersingh24 (Tue, 04 Apr 2017 19:17:08 GMT):
We are - but I would have preferred the spec before tightening things up ;)

mastersingh24 (Tue, 04 Apr 2017 19:17:31 GMT):
ah - 6991 - got it

mastersingh24 (Tue, 04 Apr 2017 19:17:35 GMT):
I knew there was one out tehrte

mastersingh24 (Tue, 04 Apr 2017 19:17:35 GMT):
I knew there was one out there

greg.haskins (Tue, 04 Apr 2017 19:17:50 GMT):
Are you saying there are people that were exploiting the lack of policing?

mastersingh24 (Tue, 04 Apr 2017 19:18:39 GMT):
Actually I was saying that the code (perhaps with 6991 it would have been OK) prevents me from using the peer cli to package and install chaincode on my local machine

greg.haskins (Tue, 04 Apr 2017 19:18:53 GMT):
My only argument about that was we never speced that you could load more than just go files in go packages, but we didn't check very carefully and now we do

mastersingh24 (Tue, 04 Apr 2017 19:19:41 GMT):
I guess I would have likely been ok with 6991 - my issue was I have multiple projects under my GOPATH

greg.haskins (Tue, 04 Apr 2017 19:19:48 GMT):
I see 6991 as orthogonal to that problem though. 6991 really just eliminates the need to vendor

mastersingh24 (Tue, 04 Apr 2017 19:19:57 GMT):
hmmm

greg.haskins (Tue, 04 Apr 2017 19:20:08 GMT):
Ah yeah, wel it fixes that too

greg.haskins (Tue, 04 Apr 2017 19:20:42 GMT):
But it has little to do with adding non golang payloads, which is what Murali was concerned with

mastersingh24 (Tue, 04 Apr 2017 19:20:59 GMT):
So yeah - with 6991 I would have never been affected by the file mode / .go file check

mastersingh24 (Tue, 04 Apr 2017 19:21:05 GMT):
sure

mastersingh24 (Tue, 04 Apr 2017 19:21:18 GMT):
My issue was with the fact of checking file mode

greg.haskins (Tue, 04 Apr 2017 19:21:26 GMT):
Right, but only because it tightens up the payload

mastersingh24 (Tue, 04 Apr 2017 19:21:28 GMT):
it all goes hand in hand

greg.haskins (Tue, 04 Apr 2017 19:21:33 GMT):
Right

greg.haskins (Tue, 04 Apr 2017 19:22:13 GMT):
After the 6991 stack, the CLI should always generate a pure, minimal golang payload

greg.haskins (Wed, 05 Apr 2017 02:09:16 GMT):
still can use eyes on these: https://gerrit.hyperledger.org/r/#/c/7681/ https://gerrit.hyperledger.org/r/#/c/6991/ .... 6991 needs @muralisr approval before merging pls

muralisr (Wed, 05 Apr 2017 02:24:19 GMT):
Was just doing `make testenv` prior to running e2e

muralisr (Wed, 05 Apr 2017 02:24:19 GMT):
Was just doing `make testenv` prior to running e2e @greg.haskins

muralisr (Wed, 05 Apr 2017 02:24:41 GMT):
and e2e did work

muralisr (Wed, 05 Apr 2017 02:24:49 GMT):
so that's good

muralisr (Wed, 05 Apr 2017 02:26:19 GMT):
we'd also need to change examples/e2e_cli/end-to-end.rst

muralisr (Wed, 05 Apr 2017 02:26:23 GMT):

Message Attachments

muralisr (Wed, 05 Apr 2017 02:26:33 GMT):
need a `make testenv` there I think

muralisr (Wed, 05 Apr 2017 02:27:37 GMT):
it'll be nice to be able to say somehere `if you are running CLI commands from a docker image, do the following`

muralisr (Wed, 05 Apr 2017 02:27:45 GMT):
but that can be done later

muralisr (Wed, 05 Apr 2017 02:27:59 GMT):
I can add the above to the gerritt

muralisr (Wed, 05 Apr 2017 02:29:12 GMT):
oh I see you did a "make docker"

muralisr (Wed, 05 Apr 2017 02:29:26 GMT):
never meind about the `make testenv` then

greg.haskins (Wed, 05 Apr 2017 02:59:56 GMT):
heh, ok

greg.haskins (Wed, 05 Apr 2017 13:23:05 GMT):
@harrijk https://gerrit.hyperledger.org/r/#/c/7709/

greg.haskins (Wed, 05 Apr 2017 13:23:22 GMT):
i point that out because its a gate that frees up the new baseimage spin

greg.haskins (Wed, 05 Apr 2017 13:23:28 GMT):
(or I would like to get that in first, anyway

harrijk (Wed, 05 Apr 2017 13:24:04 GMT):
Thanks.

harrijk (Wed, 05 Apr 2017 13:24:44 GMT):
Any idea on when this might be merged in?

muralisr (Wed, 05 Apr 2017 13:27:25 GMT):
@greg.haskins added a comment to 7709...`What would this mean to folks (especially developers) who are used to/rely on Vagrant ? Just slower "vagrant up" the first time ?`

greg.haskins (Wed, 05 Apr 2017 13:49:43 GMT):
in theory, its probably slower but I would guess not appreciably so: its all binary installations so as long as you have a decent internet connection...

greg.haskins (Wed, 05 Apr 2017 13:50:00 GMT):
the main advantage is that baseimage meant some of that binary download was cachable

greg.haskins (Wed, 05 Apr 2017 13:50:39 GMT):
whereas this model means the provisioner will re-download some of the tools whenever its rebuilt

greg.haskins (Wed, 05 Apr 2017 13:51:11 GMT):
i think the most important part is that docker-baseimage release be decoupled from vagrant

greg.haskins (Wed, 05 Apr 2017 13:51:35 GMT):
we could achieve that this way, or we could retain a vagrant baseimage that is independent from docker baseimage (at least in release cycle)

greg.haskins (Wed, 05 Apr 2017 13:51:52 GMT):
but until we have automated CI pipelines that can build vagrant, this is very painful for me

greg.haskins (Wed, 05 Apr 2017 13:51:58 GMT):
I have to build/push by hand

greg.haskins (Wed, 05 Apr 2017 13:52:15 GMT):
(the kicker is: we _do_ have this pipeline, it was just flaky)

greg.haskins (Wed, 05 Apr 2017 13:52:43 GMT):
for whatever reason, the LF substrate for running virtualbox jobs was unreliable

greg.haskins (Wed, 05 Apr 2017 13:53:53 GMT):
there are some positives here too I should point out

greg.haskins (Wed, 05 Apr 2017 13:54:17 GMT):
the devenv is decidedly simpler and more transparent now (it all is conrolled more or less by that one script)

greg.haskins (Wed, 05 Apr 2017 13:54:36 GMT):
also, if someone needs a change, they can just mod fabric.git in a standard way

greg.haskins (Wed, 05 Apr 2017 13:55:03 GMT):
right now, baseimage changes have to go through fabric-baseimage.git CR, approval, and then wait for a release window

greg.haskins (Wed, 05 Apr 2017 13:55:18 GMT):
so we do gain some agility

greg.haskins (Wed, 05 Apr 2017 13:56:22 GMT):
but to your point: ill benchmark the before and after

greg.haskins (Wed, 05 Apr 2017 13:56:38 GMT):
(and add that to the commit message)

adc (Wed, 05 Apr 2017 14:38:06 GMT):
Hi All, please some love to: https://gerrit.hyperledger.org/r/#/c/7495/ https://gerrit.hyperledger.org/r/#/c/7647/ https://gerrit.hyperledger.org/r/#/c/7649/ https://gerrit.hyperledger.org/r/#/c/7651/ and https://gerrit.hyperledger.org/r/#/c/7705/ Thanks a lot :)

smithbk (Wed, 05 Apr 2017 15:40:18 GMT):
Pls review: https://gerrit.hyperledger.org/r/#/c/6727

smithbk (Wed, 05 Apr 2017 17:52:23 GMT):
Pls also review: https://gerrit.hyperledger.org/r/7701

smithbk (Wed, 05 Apr 2017 17:52:25 GMT):
Thanks

dave.enyeart (Wed, 05 Apr 2017 23:17:35 GMT):
Ledger items for review: https://gerrit.hyperledger.org/r/#/c/7549/ https://gerrit.hyperledger.org/r/#/c/7099/ https://gerrit.hyperledger.org/r/#/c/6793/

JonathanLevi (Wed, 05 Apr 2017 23:17:58 GMT):
@aambati https://gerrit.hyperledger.org/r/#/c/7739/ I'm evidently still with high fever, judging by my list ;-)

JonathanLevi (Wed, 05 Apr 2017 23:18:40 GMT):
(but as I wrote inline, that's a great fix, really!)

C0rWin (Wed, 05 Apr 2017 23:28:49 GMT):
https://gerrit.hyperledger.org/r/#/c/7707/ needs only one more +2 :) small and simple change, while still important

adc (Thu, 06 Apr 2017 16:20:08 GMT):
Hi All, please some love to this: https://gerrit.hyperledger.org/r/#/c/7775/ Thanks :)

JonathanLevi (Thu, 06 Apr 2017 17:33:12 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=EvuCu3h9nAoks5Yf9) @adc I agree with Binhn. One more to go.

JonathanLevi (Thu, 06 Apr 2017 17:33:44 GMT):
Merged.

dave.enyeart (Thu, 06 Apr 2017 23:06:16 GMT):
Ledger items for review: https://gerrit.hyperledger.org/r/#/c/7549 https://gerrit.hyperledger.org/r/#/c/7687 https://gerrit.hyperledger.org/r/#/c/7787 https://gerrit.hyperledger.org/r/#/c/7255 https://gerrit.hyperledger.org/r/#/c/7099 https://gerrit.hyperledger.org/r/#/c/6793

muralisr (Fri, 07 Apr 2017 12:15:49 GMT):
next in the series of tasks for chaincode packaging (https://jira.hyperledger.org/browse/FAB-2859), https://gerrit.hyperledger.org/r/#/c/7823/ provides an interface for hiding package details (either the current mode of dumping deployment spec or the using the more sophisticated package container)... with this abstraction we will at last be able to do an actual install of the package container.. please note that we will retain deploying the raw deployment spec (mainly for ease of use ... it will be nice to have only one way in the end upto fabric users to decide)

adc (Fri, 07 Apr 2017 12:19:16 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/6279/ Thanks :)

muralisr (Fri, 07 Apr 2017 12:21:22 GMT):
@adc looking

adc (Fri, 07 Apr 2017 12:21:36 GMT):
thanks :)

greg.haskins (Fri, 07 Apr 2017 13:22:52 GMT):
can I get a few of you to try this: https://gerrit.hyperledger.org/r/#/c/7709/

greg.haskins (Fri, 07 Apr 2017 13:23:04 GMT):
check it out, vagrant destroy + up

adc (Fri, 07 Apr 2017 13:31:46 GMT):
Hi All, some love to https://gerrit.hyperledger.org/r/#/c/7825/ please :)

wlahti (Fri, 07 Apr 2017 13:55:33 GMT):
Has joined the channel.

wlahti (Fri, 07 Apr 2017 14:12:33 GMT):
I'd appreciate any and all reviews/feedback on https://gerrit.hyperledger.org/r/#/c/7745/ . It's one last enhancement to the Fabric error handling framework before we attempt a big push to utilize it throughout the code base.

JonathanLevi (Fri, 07 Apr 2017 14:45:32 GMT):
Amigos, not sure if all of you have noticed the (relatively) recent update to the contribution guidelines: 1. When submitting change requests, we should start our (git/Gerrit) commit messages with the JIRA ticket in square brackets. e.g., *[FAB-8765] Set the boolean flag 'make-it-awesome' to true by default* 2. Gerrit "auto-url"s it for us. See two examples [that were (pseudo-)randomly picked]: https://gerrit.hyperledger.org/r/#/c/7781 and https://gerrit.hyperledger.org/r/#/c/7709 and this also saves us from some URL encoding issues that some of you used to experience when inlining the URL directly, and makes it a lot easier to look at the "table" of CRs and find/pick one by its JIRA ticket number. 3. No need to update already submitted change requests (unless it was submitted without the/a mandatory JIRA ticket). FWIW, Jonathan

JonathanLevi (Fri, 07 Apr 2017 14:45:32 GMT):
Amigos, not sure if all of you have noticed the (relatively) recent update to the contribution guidelines: 1. When submitting change requests, we should start our (git/Gerrit) commit messages with the JIRA ticket in square brackets. e.g., *[FAB-8765] Set the boolean flag 'make-it-awesome' to true by default* 2. Gerrit "auto-url"s it for us. See two examples [that were (pseudo-)randomly picked]: https://gerrit.hyperledger.org/r/#/c/7781 and https://gerrit.hyperledger.org/r/#/c/7709, this also saves us from some URL encoding issues that some of you used to experience when inlining the URL directly, and makes it a lot easier to look at the "table" of CRs and find/pick one by its JIRA ticket number. 3. No need to update already submitted change requests (unless it/they was submitted without the/a mandatory JIRA ticket). FWIW, Jonathan

muralisr (Fri, 07 Apr 2017 14:56:19 GMT):
@JonathanLevi thanks, will do... at some early point I got the impression that without embedding the URL the notification didn't flow...but if its working consistently for others, I was likely wrong

JonathanLevi (Fri, 07 Apr 2017 15:25:24 GMT):
@muralisr To be honest, regarding the JIRA integration - I still didn't crack that... I noted that sometimes the CR/commits are linked, but not always. It got fixed at some point, but I'm not 100% sure. Will check.

binhn (Fri, 07 Apr 2017 19:24:43 GMT):
1 more review please https://gerrit.hyperledger.org/r/#/c/7823

jimthematrix (Fri, 07 Apr 2017 19:35:00 GMT):
pretty simple fix for a bug: https://gerrit.hyperledger.org/r/#/c/7805/

yacovm (Fri, 07 Apr 2017 19:45:31 GMT):
@jimthematrix I have a small inquiry in the change set

jimthematrix (Fri, 07 Apr 2017 22:16:03 GMT):
@yacovm thanks for the review, just responded in the CR

muralisr (Sat, 08 Apr 2017 13:19:50 GMT):
@binhn thanks in addition to https://gerrit.hyperledger.org/r/#/c/7823 do look at https://gerrit.hyperledger.org/r/#/c/7843 please. With that the mainline "install a package" is complete. Note that current install methods will continue to work in CLI and SDK

mastersingh24 (Sat, 08 Apr 2017 13:49:02 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/7855/ - updates fabric-ca-client to match the fabric-ca implementation

yacovm (Sat, 08 Apr 2017 13:49:57 GMT):
why was it required to prefix with 0?

yacovm (Sat, 08 Apr 2017 13:49:57 GMT):
why was it required to prefix with 0? @mastersingh24

mastersingh24 (Sat, 08 Apr 2017 14:09:10 GMT):
For some odd reason which I argued with him about, Saad felt he needed to prefix the serial number of a 0 if it was less than some number of characters (I think because openssl returned serial numbers with a leading zero)

mastersingh24 (Sat, 08 Apr 2017 14:09:10 GMT):
For some odd reason at the time, Saad felt he needed to prefix the serial number of a 0 if it was less than some number of characters (I think because openssl returned serial numbers with a leading zero)

mastersingh24 (Sat, 08 Apr 2017 14:09:30 GMT):
He then changed the logic in a different unrelated changeset which I just caught

yacovm (Sat, 08 Apr 2017 14:10:38 GMT):
you mean openssl command to generate a certificate?

mastersingh24 (Sat, 08 Apr 2017 14:11:18 GMT):
it was actually using openssl to retrieve the serial number and then use it as input to the revoke command

mastersingh24 (Sat, 08 Apr 2017 14:11:40 GMT):
basically openssl to get the info about a certificate

binhn (Sat, 08 Apr 2017 14:13:36 GMT):
@muralisr comment on https://gerrit.hyperledger.org/r/#/c/7843

muralisr (Sat, 08 Apr 2017 14:37:43 GMT):
thanks @binhn ..responded and pushed

gennadyl (Sat, 08 Apr 2017 17:09:23 GMT):
https://gerrit.hyperledger.org/r/#/c/7201/ - small change related to FAB-1845

muralisr (Sat, 08 Apr 2017 17:12:27 GMT):
https://gerrit.hyperledger.org/r/#/c/7831 is an important CR that'll complete the upgrade chancode path (thanks @jiangyaoguo !) ... some review please

binhn (Sat, 08 Apr 2017 20:32:24 GMT):
@muralisr @jiangyaoguo 1 comment on 7831 -- having a headache so I might not read the code right

muralisr (Sat, 08 Apr 2017 21:10:08 GMT):
that's a reasonable comment @binhn .... responded

adc (Sun, 09 Apr 2017 05:36:12 GMT):
please, some love to: https://gerrit.hyperledger.org/r/#/c/6279/ https://gerrit.hyperledger.org/r/#/c/7495/ https://gerrit.hyperledger.org/r/#/c/7651/ https://gerrit.hyperledger.org/r/#/c/7705/ Thanks much :)

yacovm (Sun, 09 Apr 2017 06:53:51 GMT):
@adc I commented on the first one

yacovm (Sun, 09 Apr 2017 10:44:17 GMT):
Can any maintainer please take a look at https://gerrit.hyperledger.org/r/#/c/7495 ? It's been +2ed by me, and 2 maintainers at some point in time.

mychewcents (Sun, 09 Apr 2017 12:08:48 GMT):
Has left the channel.

yacovm (Sun, 09 Apr 2017 12:29:40 GMT):
Can any maintainer please take a look at https://gerrit.hyperledger.org/r/#/c/7495 ? It's been +2ed by me, and it was also +2ed by maintainers before

binhn (Sun, 09 Apr 2017 14:01:22 GMT):
@yacovm done 7495

yacovm (Sun, 09 Apr 2017 14:03:15 GMT):
Thanks @binhn

dave.enyeart (Sun, 09 Apr 2017 16:13:26 GMT):
Ledger items for review list continues to grow :( The first one has been split into 3 to meet changeset size recommendations: https://gerrit.hyperledger.org/r/#/c/7549 (1 of 4) https://gerrit.hyperledger.org/r/#/c/7859 (2 of 4) https://gerrit.hyperledger.org/r/#/c/7869 (3 of 4) https://gerrit.hyperledger.org/r/#/c/7687 https://gerrit.hyperledger.org/r/#/c/7787 https://gerrit.hyperledger.org/r/#/c/7255 https://gerrit.hyperledger.org/r/#/c/7099 https://gerrit.hyperledger.org/r/#/c/6793

JonathanLevi (Sun, 09 Apr 2017 22:37:21 GMT):
Hi @dave.enyeart, maybe we/you should approach these differently?

JonathanLevi (Sun, 09 Apr 2017 22:39:26 GMT):
I have merged the first one, so that have the the c_db in... It maybe be easier (for you and the reviewers), to first get the "core" stuff in, and only after "build no top of it". Because, otherwise, for example, after each of my merges, you may need to rebase a few (which can/may get frustrating, for you, exponentially ;-))

JonathanLevi (Sun, 09 Apr 2017 22:39:45 GMT):
Hope I helped, will give these some more attention after the next round/iteration.

dave.enyeart (Mon, 10 Apr 2017 00:55:48 GMT):
Thanks @JonathanLevi . We did attempt to structure them that way. The first three parts each deliver a couchdb building block. Part 4 exercises the first three in the fabric logic. The functions are next to each other in the files, therefore there are merge conflicts. Maybe I'm not understanding the advice though. The splitting, dependencies, and exponential rebasing is indeed making this more difficult and time consuming than having a single changeset to cover the new functionality end-to-end (which we would have done in the past). I'm open to learning if there are some tricks to make this easier for all of us. @cbf @chris.elder

adc (Mon, 10 Apr 2017 05:36:05 GMT):
Hi, last mile for https://gerrit.hyperledger.org/r/#/c/7651/ and https://gerrit.hyperledger.org/r/#/c/6279/, please :)

JonathanLevi (Mon, 10 Apr 2017 11:43:07 GMT):
@dave.enyeart, @chris.elder: I/we have just merged: https://gerrit.hyperledger.org/r/#/c/7859/ https://jira.hyperledger.org/browse/FAB-3046 "reate couchdb batch read operations for optimization" https://gerrit.hyperledger.org/r/#/c/7859/ https://jira.hyperledger.org/browse/FAB-3047 "Change couchdb attachment arrays to use pointers"

JonathanLevi (Mon, 10 Apr 2017 11:43:31 GMT):
Maybe we should make *exponential rebasing* a "term" ;-)...

smithbk (Mon, 10 Apr 2017 11:44:17 GMT):
next in line for fabric-ca review (bottom of stack)

smithbk (Mon, 10 Apr 2017 11:44:21 GMT):
https://gerrit.hyperledger.org/r/7701

JonathanLevi (Mon, 10 Apr 2017 11:44:27 GMT):
@dave.enyeart: The easiest/simplest approach is usually to "partition" the files... but again, may be different in different cases.

smithbk (Mon, 10 Apr 2017 11:44:35 GMT):
and https://gerrit.hyperledger.org/r/7735

JonathanLevi (Mon, 10 Apr 2017 11:48:34 GMT):
@smithbk: That was (a) straightforward (-2).

JonathanLevi (Mon, 10 Apr 2017 11:48:34 GMT):
@smithbk: That's a straightforward `-2` !

JonathanLevi (Mon, 10 Apr 2017 11:48:36 GMT):
Please can you also follow the commit message structure? Not sure what's going on with the formatting there....

JonathanLevi (Mon, 10 Apr 2017 11:48:42 GMT):
https://gerrit.hyperledger.org/r/#/c/7701/

mastersingh24 (Mon, 10 Apr 2017 11:49:40 GMT):
@JonathanLevi - it looks like we no longer need to include the actual link to the JIRA - simply using the FAB-XXXX notation seems to handle the link(s) now

smithbk (Mon, 10 Apr 2017 11:50:16 GMT):
yeh, something changed with tooling ... yes, i'll update now

smithbk (Mon, 10 Apr 2017 11:53:26 GMT):
commit message fixed for https://gerrit.hyperledger.org/r/#/c/7701/

smithbk (Mon, 10 Apr 2017 11:55:02 GMT):
and for http://gerrit.hyperledger.org/r/7735

JonathanLevi (Mon, 10 Apr 2017 12:01:15 GMT):
@mastersingh24: Yes, exactly. We have a RegEx that converts to a URL.

mastersingh24 (Mon, 10 Apr 2017 12:03:48 GMT):
for a long time it was not working

JonathanLevi (Mon, 10 Apr 2017 12:05:21 GMT):
True. The "trick" is, to simply follow @cbf's updated contribution guidelines.

JonathanLevi (Mon, 10 Apr 2017 12:05:50 GMT):
I also posted a small "announcement" on the #fabric channel and here about it, last week.

JonathanLevi (Mon, 10 Apr 2017 12:07:57 GMT):
Long story short, my review score is `-2` on https://gerrit.hyperledger.org/r/#/c/7701 `-1` on https://gerrit.hyperledger.org/r/#/c/7735 (which should be -2, really... and you can see it inline)

JonathanLevi (Mon, 10 Apr 2017 12:08:55 GMT):
The Linux Foundation is a registered trademark.... we should really have consistent guidelines for contribution (the ones posted fro fabric-ca there are different, and somewhat ambiguous, etc.)

JonathanLevi (Mon, 10 Apr 2017 12:08:55 GMT):
The Linux Foundation is a registered trademark.... we should really have consistent guidelines for contribution (the ones posted for fabric-ca there are different, and somewhat ambiguous, etc.), we should provide users with better syntax than just `push`... etc.

JonathanLevi (Mon, 10 Apr 2017 12:12:22 GMT):

Message Attachments

muralisr (Mon, 10 Apr 2017 12:15:46 GMT):
some love for https://gerrit.hyperledger.org/r/#/c/7843 https://gerrit.hyperledger.org/r/#/c/7875 and https://gerrit.hyperledger.org/r/#/c/7879 pretty please

wlahti (Mon, 10 Apr 2017 13:23:13 GMT):
Hey everybody, I'd still appreciate some reviews for two CRs (one functional, one documentation) related to error handling: https://gerrit.hyperledger.org/r/#/c/7745/ and https://gerrit.hyperledger.org/r/#/c/7845/

wlahti (Mon, 10 Apr 2017 13:24:27 GMT):
I also have two others needing review: https://gerrit.hyperledger.org/r/#/c/7421/ and https://gerrit.hyperledger.org/r/#/c/7717/

yacovm (Mon, 10 Apr 2017 13:33:43 GMT):
Easy bug fix, 1 liner https://gerrit.hyperledger.org/r/#/c/7877/

muralisr (Mon, 10 Apr 2017 16:27:30 GMT):
just putting some context around https://gerrit.hyperledger.org/r/#/c/7843 https://gerrit.hyperledger.org/r/#/c/7875 and https://gerrit.hyperledger.org/r/#/c/7879 ... they are all related to https://jira.hyperledger.org/browse/FAB-2859.

muralisr (Mon, 10 Apr 2017 16:30:48 GMT):
They key are the following points ``` provide a notion for "packaging a chaincode" keep existing methods work without change (ie, "install" and "instantiate" etc) link instantiated record with the install via a fingerprint (this is perhaps the most interesting) so future chaincode launches do validation add optional ownership signatures to a package. This is primarily for future expansion and usage```

muralisr (Mon, 10 Apr 2017 16:31:54 GMT):
hopefully that summarizes the tasks listed in FAB-2859

muralisr (Mon, 10 Apr 2017 16:33:18 GMT):
https://gerrit.hyperledger.org/r/#/c/7843 https://gerrit.hyperledger.org/r/#/c/7875 and https://gerrit.hyperledger.org/r/#/c/7879 would close most of the tasks

sanchezl (Mon, 10 Apr 2017 16:35:24 GMT):
Can someone please try https://gerrit.hyperledger.org/r/#/c/7893/ on ppc and/or s390 ?

harsha (Mon, 10 Apr 2017 18:11:24 GMT):
Easy fix, https://gerrit.hyperledger.org/r/#/c/7887

harsha (Mon, 10 Apr 2017 18:45:03 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=KYTECGGAqWi8yj7uS) @sanchezl Works on `ppc6le`

smithbk (Mon, 10 Apr 2017 19:09:22 GMT):
Pls review fabric-ca https://gerrit.hyperledger.org/r/#/c/7701/ ... thanks

dave.enyeart (Mon, 10 Apr 2017 19:53:10 GMT):
Thanks @JonathanLevi and @yacovm for CouchDB bulk operation reviews. Here's what's left: https://gerrit.hyperledger.org/r/#/c/7715 CouchDB bulk operations (4 of 5) https://gerrit.hyperledger.org/r/#/c/7787 Replace gob encoding (small) https://gerrit.hyperledger.org/r/#/c/7255 Re-enable chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 CouchDB default config https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

dave.enyeart (Mon, 10 Apr 2017 19:53:10 GMT):
Thanks @JonathanLevi and @yacovm for CouchDB bulk operation reviews. Here's what's left: https://gerrit.hyperledger.org/r/#/c/7715 CouchDB bulk operations (4 of 5) https://gerrit.hyperledger.org/r/#/c/7787 Fix gob encoding (small) https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

dave.enyeart (Mon, 10 Apr 2017 19:53:10 GMT):
Thanks @JonathanLevi and @yacovm for CouchDB bulk operation reviews. Here's what's left: https://gerrit.hyperledger.org/r/#/c/7715 CouchDB bulk operations - order of magnitude performance improvement (4 of 5) https://gerrit.hyperledger.org/r/#/c/7787 Fix gob encoding (small) https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

jimthematrix (Mon, 10 Apr 2017 21:02:18 GMT):
event security as discussed earlier: peer side: https://gerrit.hyperledger.org/r/#/c/7905 node SDK side: https://gerrit.hyperledger.org/r/#/c/7909

jimthematrix (Mon, 10 Apr 2017 21:02:39 GMT):
@binhn @yacovm @mastersingh24 @adc @aso ^^^

jimthematrix (Mon, 10 Apr 2017 21:06:01 GMT):
note that 7909 will fail until 7905 has been merged

jimthematrix (Mon, 10 Apr 2017 21:06:01 GMT):
note that 7909 will fail until 7905 gets merged

skarim (Mon, 10 Apr 2017 21:53:59 GMT):
Please review the following fabric-ca change sets: https://gerrit.hyperledger.org/r/#/c/7829/ https://gerrit.hyperledger.org/r/#/c/7701/ https://gerrit.hyperledger.org/r/#/c/7713/ https://gerrit.hyperledger.org/r/#/c/7741/ https://gerrit.hyperledger.org/r/#/c/7903/1

smithbk (Tue, 11 Apr 2017 00:11:39 GMT):
Another fabric-ca change set (an easy one):

smithbk (Tue, 11 Apr 2017 00:11:41 GMT):
http://gerrit.hyperledger.org/r/7911

adc (Tue, 11 Apr 2017 05:05:16 GMT):
Hi All, please some love to: https://gerrit.hyperledger.org/r/#/c/6279/ and https://gerrit.hyperledger.org/r/#/c/7651/

adc (Tue, 11 Apr 2017 05:05:30 GMT):
@muralisr, please, may you have a look at Yacov comment's on https://gerrit.hyperledger.org/r/#/c/7651/. Thanks :)

yacovm (Tue, 11 Apr 2017 10:58:22 GMT):
Hi. 2 Easy (<5 lines) commits: https://gerrit.hyperledger.org/r/#/c/7925/ https://gerrit.hyperledger.org/r/#/c/7923/

yacovm (Tue, 11 Apr 2017 10:58:22 GMT):
Hi. 2 Easy (<5 lines) commits (fixes) https://gerrit.hyperledger.org/r/#/c/7925/ Fixes peer/core.yaml misleading comments that are confusing users https://gerrit.hyperledger.org/r/#/c/7923/ A trivial `Debug`-->`Debugf` fix

harsha (Tue, 11 Apr 2017 12:54:16 GMT):
Needs +2 on this https://gerrit.hyperledger.org/r/#/c/7887/4/

harsha (Tue, 11 Apr 2017 12:54:16 GMT):
Needs +2's on this https://gerrit.hyperledger.org/r/#/c/7887/4/

mastersingh24 (Tue, 11 Apr 2017 13:08:46 GMT):
@harsha - I added a comment - but basically I don't like that script and it's not the way we should be doing things. I have some ideas and need to add some JIRA entries to describe how we are going to fix this

mastersingh24 (Tue, 11 Apr 2017 13:08:58 GMT):
so it's not your change, but the overall script itself

sanchezl (Tue, 11 Apr 2017 13:15:14 GMT):
Just need another +2: https://gerrit.hyperledger.org/r/#/c/7893/

harrijk (Tue, 11 Apr 2017 13:15:54 GMT):
@sanchezl you're one step ahead of me. :)

dave.enyeart (Tue, 11 Apr 2017 13:15:56 GMT):
We have decided to defer performance optimizations that require significant changes from v1. Therefore the bulk operations changeset is removed from the ledger list. Still need reviews for these aging fixes/tests as soon as possible: https://gerrit.hyperledger.org/r/#/c/7787 Fix gob encoding (small) https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

wlahti (Tue, 11 Apr 2017 15:14:22 GMT):
Hey everybody, I'd still appreciate some reviews for two CRs related to error handling (one functional, one documentation): https://gerrit.hyperledger.org/r/#/c/7745 and https://gerrit.hyperledger.org/r/#/c/7845 I also have two others needing review: https://gerrit.hyperledger.org/r/#/c/7421 and https://gerrit.hyperledger.org/r/#/c/7717 (simple - only updates a few error messages to be more informative)

sanchezl (Tue, 11 Apr 2017 16:20:29 GMT):
Simple CR needing a push: https://gerrit.hyperledger.org/r/#/c/7893/

skarim (Tue, 11 Apr 2017 17:30:10 GMT):
@JonathanLevi Please review https://gerrit.hyperledger.org/r/#/c/7701/

JonathanLevi (Tue, 11 Apr 2017 17:39:33 GMT):
@skarim, @smithbk: Who contributed this code snip (in Green)? https://gerrit.hyperledger.org/r/#/c/7701/3..4/lib/client.go

JonathanLevi (Tue, 11 Apr 2017 18:51:09 GMT):
@skarim: No problem. So instead of asking to add the Sign-off line, Keith has manually removed all your changes?

JonathanLevi (Tue, 11 Apr 2017 18:52:01 GMT):
There is not even a comment there. Have just compared line by line manually (patch set 9 vs patch set 3). @smithbk ?

skarim (Tue, 11 Apr 2017 19:02:23 GMT):
@JonathanLevi Patch set 4 should not have actually been created. It was an unintended consequence of pushing a patch set to another change (https://gerrit.hyperledger.org/r/#/c/7829/4). I am still trying to track down as to why that happened, but backing out patch set 4 is correct.

JonathanLevi (Tue, 11 Apr 2017 19:18:34 GMT):
Keith should have explained that in the CR. Anyway, will approve. Thanks for clarifying.

JonathanLevi (Tue, 11 Apr 2017 19:33:48 GMT):
Keith should have explained that in the CR. Thanks for clarifying.

Lin-YiTang (Tue, 11 Apr 2017 21:17:47 GMT):
Has joined the channel.

binhn (Tue, 11 Apr 2017 22:29:09 GMT):
@elli-androulaki @aso please review https://gerrit.hyperledger.org/r/#/c/7905

binhn (Tue, 11 Apr 2017 22:30:07 GMT):
@adc i reviewed all of your cr's

baohua (Wed, 12 Apr 2017 03:34:52 GMT):
A quick fix, welcome for review, thanks! https://gerrit.hyperledger.org/r/#/c/7885

baohua (Wed, 12 Apr 2017 03:50:36 GMT):
https://gerrit.hyperledger.org/r/#/c/7851

king3000 (Wed, 12 Apr 2017 05:40:08 GMT):
Has joined the channel.

adc (Wed, 12 Apr 2017 07:36:22 GMT):
@binhn, Thanks :)

mgk (Wed, 12 Apr 2017 09:38:00 GMT):
Has joined the channel.

yacovm (Wed, 12 Apr 2017 11:02:57 GMT):
Good morning. Two trivial merges of bug fixes https://gerrit.hyperledger.org/r/#/c/7967/ - Without this, connection attempts that fail, fail after a very, very long time. https://gerrit.hyperledger.org/r/#/c/7969/ - This is to make the logs more informative

yacovm (Wed, 12 Apr 2017 11:02:57 GMT):
Good morning. Two trivial merges of bug fixes https://gerrit.hyperledger.org/r/#/c/7967/ [ 1 line ] - Without this, connection attempts that fail, fail after a very, very long time. https://gerrit.hyperledger.org/r/#/c/7969/ [ 4 lines ] - This is to make the logs more informative

yacovm (Wed, 12 Apr 2017 12:02:38 GMT):
Also, 2 change sets that are stacked, and they (combined) make the peer reconnect to the ordering service, and to failover to other ordering service nodes in case of their crash: https://gerrit.hyperledger.org/r/#/c/7781/ - A needed bug fix for the next one https://gerrit.hyperledger.org/r/#/c/7385/ - The actual change set, note that ~ 300 lines is test

wlahti (Wed, 12 Apr 2017 12:09:37 GMT):
Hey everybody, I'd still appreciate some reviews for two CRs related to error handling (one functional, one documentation): https://gerrit.hyperledger.org/r/#/c/7745 and https://gerrit.hyperledger.org/r/#/c/7845 I also have two others needing review: https://gerrit.hyperledger.org/r/#/c/7421 (revert log levels to peer startup levels) and https://gerrit.hyperledger.org/r/#/c/7717 (simple - only updates a few error messages to be more informative)

dave.enyeart (Wed, 12 Apr 2017 12:36:36 GMT):
Still need reviews for these aging ledger fixes/tests as soon as possible: https://gerrit.hyperledger.org/r/#/c/7687 Fix query result to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7787 Fix gob encoding to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

dave.enyeart (Wed, 12 Apr 2017 12:36:36 GMT):
Still need reviews for these aging ledger fixes/tests as soon as possible: https://gerrit.hyperledger.org/r/#/c/7687 Fix query result to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7787 Fix gob encoding to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config (security) https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

dave.enyeart (Wed, 12 Apr 2017 12:36:36 GMT):
Still need reviews for these aging ledger fixes/tests as soon as possible: https://gerrit.hyperledger.org/r/#/c/7787 Fix gob encoding to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config (security) https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

dave.enyeart (Wed, 12 Apr 2017 12:36:36 GMT):
Still need reviews for these aging ledger fixes/tests as soon as possible: https://gerrit.hyperledger.org/r/#/c/7687 Switch QueryResult to protobuf to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7787 Switch gob encoding to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config (security) https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

C0rWin (Wed, 12 Apr 2017 13:07:12 GMT):
https://gerrit.hyperledger.org/r/#/c/7635/ takes care to batch gossip state transfer request

gennadyl (Wed, 12 Apr 2017 13:21:37 GMT):
https://gerrit.hyperledger.org/r/#/c/7201/ and https://gerrit.hyperledger.org/r/#/c/7203/ - messages expiration in gossip discovery module

binhn (Wed, 12 Apr 2017 19:01:39 GMT):
need 1 more reviewer please on yacov's https://gerrit.hyperledger.org/r/#/c/7781 and https://gerrit.hyperledger.org/r/#/c/7385

rameshthoomu (Wed, 12 Apr 2017 19:06:42 GMT):
trivial patch on regression folder structure https://gerrit.hyperledger.org/r/#/c/7991/

mastersingh24 (Wed, 12 Apr 2017 20:07:43 GMT):
https://gerrit.hyperledger.org/r/#/c/7403/

mastersingh24 (Wed, 12 Apr 2017 20:08:02 GMT):
rebase - just needs another +2 @JonathanLevi

mastersingh24 (Wed, 12 Apr 2017 20:08:30 GMT):
easy peasy cleanup - https://gerrit.hyperledger.org/r/#/c/7983/

JonathanLevi (Wed, 12 Apr 2017 20:09:50 GMT):
7403 - merged

JonathanLevi (Wed, 12 Apr 2017 20:10:01 GMT):
7983 - LGTM. Requires another +2.

JonathanLevi (Wed, 12 Apr 2017 20:10:01 GMT):
7983 - LGTM. Requires another +2. [UPD: Thank you @yacovm]

mastersingh24 (Wed, 12 Apr 2017 20:10:30 GMT):
https://gerrit.hyperledger.org/r/#/c/7981/ also - working on pro releases ;)

nickgaski (Wed, 12 Apr 2017 20:12:04 GMT):
MARBLES - so this isn't the prettiest but it works and actually gives us a demo beyond the end2end - https://gerrit.hyperledger.org/r/#/c/7997/ You can preview the doc here - http://fabric-rtd.readthedocs.io/en/latest/marbles.html

JonathanLevi (Wed, 12 Apr 2017 20:14:20 GMT):
@mastersingh24: Please see my note re https://gerrit.hyperledger.org/r/#/c/7981. We (other maintainers) may have some (other?) opinions suggested there esp. regarding the CI, but LGTM at this point. Merged.

JonathanLevi (Wed, 12 Apr 2017 20:14:20 GMT):
@mastersingh24: Please see my note re https://gerrit.hyperledger.org/r/#/c/7981. We (other maintainers) may have some (other?) opinions/suggestions from others in that respect esp. regarding the CI, but LGTM at this point. Merged.

mastersingh24 (Wed, 12 Apr 2017 20:23:36 GMT):
I have some JIRA's open as follow up for publishing - e.g. https://jira.hyperledger.org/browse/FAB-3123

mastersingh24 (Wed, 12 Apr 2017 20:24:25 GMT):
let me know where the best place to discuss will be - obviously JIRA items are good for comments but you need to know they exist

mastersingh24 (Wed, 12 Apr 2017 20:24:53 GMT):
I attached them to the UX epic: https://jira.hyperledger.org/browse/FAB-3095

wlahti (Wed, 12 Apr 2017 21:12:43 GMT):
core.yaml logging section cleanup: https://gerrit.hyperledger.org/r/#/c/7977/

wlahti (Wed, 12 Apr 2017 21:26:46 GMT):
Just need one more review for https://gerrit.hyperledger.org/r/#/c/7717/, which improves the error messages for invalid chaincode name/version

wlahti (Wed, 12 Apr 2017 21:33:21 GMT):
Thanks @JonathanLevi !

muralisr (Thu, 13 Apr 2017 05:57:07 GMT):
An easy one https://gerrit.hyperledger.org/r/#/c/7785

skarim (Thu, 13 Apr 2017 13:29:46 GMT):
Please review the following fabric-ca change sets: https://gerrit.hyperledger.org/r/#/c/7713 https://gerrit.hyperledger.org/r/#/c/7941 https://gerrit.hyperledger.org/r/#/c/7789

rameshthoomu (Thu, 13 Apr 2017 17:07:20 GMT):
regression folder structure patch.. Simple one to review https://gerrit.hyperledger.org/r/#/c/7991

rjones (Thu, 13 Apr 2017 19:21:33 GMT):
Has joined the channel.

rjones (Thu, 13 Apr 2017 19:21:51 GMT):
I would appreciate a little bit of attention to a small change. well, attention and +2s https://gerrit.hyperledger.org/r/#/c/8021/

mastersingh24 (Thu, 13 Apr 2017 20:31:26 GMT):
don't work too hard @rjones ;)

mastersingh24 (Thu, 13 Apr 2017 20:31:28 GMT):
done

mastersingh24 (Thu, 13 Apr 2017 20:31:43 GMT):
https://gerrit.hyperledger.org/r/#/c/8021 - any easy one (I think or feel free to criticize the concept)

mastersingh24 (Thu, 13 Apr 2017 20:31:43 GMT):
https://gerrit.hyperledger.org/r/#/c/8005/ - any easy one (I think or feel free to criticize the concept)

rjones (Thu, 13 Apr 2017 20:41:21 GMT):
@mastersingh24 you linked to my PR 😀

mastersingh24 (Thu, 13 Apr 2017 20:43:51 GMT):
well it was easy and people can criticize ;)

mastersingh24 (Thu, 13 Apr 2017 20:43:53 GMT):
thx

mastersingh24 (Thu, 13 Apr 2017 20:44:58 GMT):
here's the right one: https://gerrit.hyperledger.org/r/#/c/8005/

jwagantall (Thu, 13 Apr 2017 23:51:35 GMT):
Has joined the channel.

jwagantall (Thu, 13 Apr 2017 23:51:55 GMT):
hi all!... Can someone please help me review this change: https://gerrit.hyperledger.org/r/#/c/8027/

jwagantall (Thu, 13 Apr 2017 23:52:43 GMT):
Super simple and will help us have a cleaner/easier to read code now that we are starting to add more aesthetics checks

yacovm (Fri, 14 Apr 2017 06:28:30 GMT):
Since you have a JIRA item there could you please make the title of the commit msg start with [FAB-3153] ? @jwagantall

baohua (Fri, 14 Apr 2017 07:57:41 GMT):
https://gerrit.hyperledger.org/r/#/c/8035/

baohua (Fri, 14 Apr 2017 07:57:49 GMT):
could anyone help review? Thanks!

binhn (Fri, 14 Apr 2017 13:22:56 GMT):
@jwagantall thanks but could you resubmit the cr without changing the vendor files https://gerrit.hyperledger.org/r/#/c/8027

baohua (Fri, 14 Apr 2017 15:26:14 GMT):
@muralisr wait for ur review, thanks https://gerrit.hyperledger.org/r/#/c/8035/

jwagantall (Fri, 14 Apr 2017 16:37:38 GMT):
@binhn I have removed the vendor file changes now: https://gerrit.hyperledger.org/r/#/c/8027/7

jwagantall (Fri, 14 Apr 2017 16:37:47 GMT):
Thanks a ton for reviewing my change!

muralisr (Fri, 14 Apr 2017 17:11:56 GMT):
@baohua will review as soon as I can ....spottily available for a few days

mastersingh24 (Fri, 14 Apr 2017 18:19:32 GMT):
an easy one for anyone out there: https://gerrit.hyperledger.org/r/#/c/8043/

mastersingh24 (Fri, 14 Apr 2017 18:19:49 GMT):
(increases test coverage of the core/comm package)

muralisr (Fri, 14 Apr 2017 18:35:05 GMT):
looks good and +2ed @mastersingh24 ... @baohua https://gerrit.hyperledger.org/r/#/c/8035 is reviewed with +2 too

rameshthoomu (Fri, 14 Apr 2017 19:36:58 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=cQp3uZKN5GQAk8Ng3) @mastersingh24 I have submitted one similar to this here https://github.com/hyperledger/fabric/blob/master/examples/e2e_cli/download-dockerimages.sh

rameshthoomu (Fri, 14 Apr 2017 19:37:45 GMT):
bash script just pull images and tag it as latest to avoid changing docker-compose file with correct tags..

mastersingh24 (Fri, 14 Apr 2017 19:39:23 GMT):
@rameshthoomu - yes - I saw that - but actually I don't want to tag things as latest - I want people to be able to use the correct version that goes along with the rest of the assets

rameshthoomu (Fri, 14 Apr 2017 19:40:59 GMT):
ok make sense..

rameshthoomu (Fri, 14 Apr 2017 19:40:59 GMT):
ok makes sense..

greg.haskins (Fri, 14 Apr 2017 20:47:21 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/8001/

baohua (Sat, 15 Apr 2017 01:35:03 GMT):
thanks for the quick review! @muralisr @yacovm @binhn

muralisr (Sat, 15 Apr 2017 01:43:36 GMT):
merged Greg

greg.haskins (Sat, 15 Apr 2017 02:45:39 GMT):
ty @muralisr

greg.haskins (Sat, 15 Apr 2017 02:45:43 GMT):
another quick one: https://gerrit.hyperledger.org/r/#/c/8055/

muralisr (Sat, 15 Apr 2017 03:08:56 GMT):
done @greg.haskins

greg.haskins (Sat, 15 Apr 2017 03:09:08 GMT):
ty sir

muralisr (Sat, 15 Apr 2017 03:09:17 GMT):
sure

cbf (Sat, 15 Apr 2017 12:18:48 GMT):
https://gerrit.hyperledger.org/r/#/c/7947/

cbf (Sat, 15 Apr 2017 12:19:00 GMT):
https://gerrit.hyperledger.org/r/#/c/7985/

cbf (Sat, 15 Apr 2017 12:19:12 GMT):
https://gerrit.hyperledger.org/r/#/c/8045/

cbf (Sat, 15 Apr 2017 12:19:25 GMT):
https://gerrit.hyperledger.org/r/#/c/8051/

cbf (Sat, 15 Apr 2017 12:19:30 GMT):
some easy doc fixes

yacovm (Sat, 15 Apr 2017 13:02:18 GMT):
the info in `7985` isn't accurate.

mastersingh24 (Sat, 15 Apr 2017 18:27:09 GMT):
https://gerrit.hyperledger.org/r/#/c/8073/

dave.enyeart (Mon, 17 Apr 2017 13:51:18 GMT):
Still need reviews for these aging ledger fixes/tests as soon as possible: https://gerrit.hyperledger.org/r/#/c/7687 Switch QueryResult to protobuf to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7787 Switch gob encoding to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Fix CouchDB default config (security) https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code)

vpaprots (Mon, 17 Apr 2017 16:27:59 GMT):
Trying to wrap up pkcs11 support for v1.0: https://gerrit.hyperledger.org/r/#/c/6727 Fabric ca SW BCCSP integration https://gerrit.hyperledger.org/r/#/c/8103 PKCS11 BCCSP fixes https://gerrit.hyperledger.org/r/#/c/8105 cryptogen + pkcs11

cbf (Mon, 17 Apr 2017 17:41:30 GMT):
couple of easy ones

cbf (Mon, 17 Apr 2017 17:41:32 GMT):
https://gerrit.hyperledger.org/r/#/c/8079/

cbf (Mon, 17 Apr 2017 17:41:45 GMT):
https://gerrit.hyperledger.org/r/#/c/8089/

nickgaski (Mon, 17 Apr 2017 21:14:53 GMT):
real easy as well - https://gerrit.hyperledger.org/r/#/c/8115/

yacovm (Mon, 17 Apr 2017 21:37:57 GMT):
A set of easy bug fixes https://gerrit.hyperledger.org/r/#/c/8107/ docker-compose.yaml fix 2 CI failure fixes: https://gerrit.hyperledger.org/r/#/c/8087/ https://gerrit.hyperledger.org/r/#/c/8085/ https://gerrit.hyperledger.org/r/#/c/8121/ remove the requirement that orgID and orgName in configtx.yaml *must* be the same or gossip will reject the channel join

yacovm (Mon, 17 Apr 2017 21:37:57 GMT):
A set of easy (was easy to fix, and are easy to CR!) bug fixes https://gerrit.hyperledger.org/r/#/c/8107/ docker-compose.yaml fix 2 CI failure fixes: https://gerrit.hyperledger.org/r/#/c/8087/ https://gerrit.hyperledger.org/r/#/c/8085/ https://gerrit.hyperledger.org/r/#/c/8121/ remove the requirement that orgID and orgName in configtx.yaml *must* be the same or gossip will reject the channel join

jwagantall (Mon, 17 Apr 2017 23:36:05 GMT):
@kostas @binhn can we proceed and merge https://gerrit.hyperledger.org/r/#/c/8027/ I have updated it today as per the comments

jwagantall (Mon, 17 Apr 2017 23:38:58 GMT):
thank you!

jwagantall (Mon, 17 Apr 2017 23:39:18 GMT):
just need a +2 + merge :)

baohua (Tue, 18 Apr 2017 02:55:47 GMT):
This is a fundamental change of the lifecycle system chaincode names, so would like to have ur comments soon. Thanks! https://gerrit.hyperledger.org/r/#/c/8113/

jimthematrix (Tue, 18 Apr 2017 04:40:13 GMT):
https://gerrit.hyperledger.org/r/#/c/7905/ - updated based on latest discussion re: scope of the security check. @binhn @mastersingh24 @elli-androulaki @adc @yacovm

elli-androulaki (Tue, 18 Apr 2017 09:10:30 GMT):
@jimthematrix , just reviewed it, but it would be nice if @adc could also take a look :)

yacovm (Tue, 18 Apr 2017 09:45:00 GMT):
Easy bug fix https://gerrit.hyperledger.org/r/#/c/8133/

jimthematrix (Tue, 18 Apr 2017 13:03:17 GMT):
@elli-androulaki @yacovm thanks for the review, I responded to your comments. especially regarding replay attacks that Yacov pointed out, Elli can you respond and decide what should be done? also @binhn @mastersingh24

binhn (Tue, 18 Apr 2017 14:10:00 GMT):
I merged https://gerrit.hyperledger.org/r/#/c/8113 very late last night and didn't think straight that it would impact SDK. The CR changes the life-cycle system chaincode from LCCC to LSCC

binhn (Tue, 18 Apr 2017 16:16:28 GMT):
@cbf https://gerrit.hyperledger.org/r/#/c/7853/

skarim (Tue, 18 Apr 2017 17:15:33 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/7713/

yacovm (Tue, 18 Apr 2017 17:59:35 GMT):
Could use an endorsement on 2 very simple bug fix proposals: https://gerrit.hyperledger.org/r/#/c/8133/ https://gerrit.hyperledger.org/r/#/c/8121/

yacovm (Tue, 18 Apr 2017 17:59:35 GMT):
Could use an endorsement on 2 very simple bug fix proposals: https://gerrit.hyperledger.org/r/#/c/8133/ https://gerrit.hyperledger.org/r/#/c/8121/ Each has 1 +2 already

yacovm (Tue, 18 Apr 2017 17:59:35 GMT):
Could use an endorsement on 3 very simple bug fix proposals: https://gerrit.hyperledger.org/r/#/c/8133/ https://gerrit.hyperledger.org/r/#/c/8121/ https://gerrit.hyperledger.org/r/#/c/8085/ Each has 1 +2 already

JonathanLevi (Tue, 18 Apr 2017 18:41:24 GMT):
@yacovm: merged. We should add more test and cover the MSPID() stuff "at your earliest convenience"...

yacovm (Tue, 18 Apr 2017 18:42:45 GMT):
I don't mind adding tests. What should the test do in your opinion?

yacovm (Tue, 18 Apr 2017 18:42:58 GMT):
and thanks for the merges :)

JonathanLevi (Tue, 18 Apr 2017 18:45:47 GMT):
Possibly cover the change in logic, here: `orgListFromConfig()`.... the `appOrgMock::MSPID()` and the `Organizations()`

jimthematrix (Tue, 18 Apr 2017 18:45:58 GMT):
https://gerrit.hyperledger.org/r/#/c/7905/ - both @elli-androulaki and @yacovm have reviewed and approved, can anybody please add another +2 and merge? then we can move on to https://gerrit.hyperledger.org/r/#/c/7909 (for node SDK)

JonathanLevi (Tue, 18 Apr 2017 18:46:07 GMT):
Now that we don't have the "Implement me..." place holder.

yacovm (Tue, 18 Apr 2017 18:47:07 GMT):
The reason I didn't add a test was that now the code supports more options than before. I'll see what I can do tomorrow. That area is very test-able and I'm a fan of tests in general.

JonathanLevi (Tue, 18 Apr 2017 18:49:38 GMT):
Cool, thank you.

JonathanLevi (Tue, 18 Apr 2017 18:49:47 GMT):
[good night]

JonathanLevi (Tue, 18 Apr 2017 18:53:04 GMT):
@jimthematrix: some minor stuff re: licensing and error. LGTM, otherwise.

elli-androulaki (Tue, 18 Apr 2017 19:18:41 GMT):
Hi, could one take a look at this one? https://gerrit.hyperledger.org/r/#/c/6279

elli-androulaki (Tue, 18 Apr 2017 19:18:41 GMT):
Hi, could one take a look at this one? https://gerrit.hyperledger.org/r/#/c/6279 (please, please?)

yacovm (Tue, 18 Apr 2017 19:46:42 GMT):
@elli-androulaki 1) The change set was last updated a week ago, I rebased it to make sure it doesn't break master somehow. 2) Alessandro's change set is now merged so Binh's comment on https://gerrit.hyperledger.org/r/#/c/6279/37/core/chaincode/handler.go@251 can now be addressed. Angelo (or you/Ale) can update the change set if you want.

greg.haskins (Tue, 18 Apr 2017 20:29:08 GMT):
need a review on this pls: https://gerrit.hyperledger.org/r/#/c/7963/

greg.haskins (Tue, 18 Apr 2017 20:29:27 GMT):
it may look daunting, but its only about 1-4 lines per file, I just had to touch lots of files

muralisr (Tue, 18 Apr 2017 20:31:35 GMT):
if we are to get this in we need to move quickly..looking @greg.haskins

muralisr (Tue, 18 Apr 2017 20:33:16 GMT):
I did look briefly before but stopped for the V-1's to be cleared.... let me pull it and test now. Will update after testing

yacovm (Tue, 18 Apr 2017 21:36:09 GMT):
I have 2 gossip change sets that @C0rWin has +1ed and are for v1.0 https://gerrit.hyperledger.org/r/#/c/8075 - this is the first of a series that deals with confidentiality - it's basically only `70` lines of production code and the rest is test code. https://gerrit.hyperledger.org/r/#/c/8155/ this adds basic revocation support to gossip, and will be enhanced in the (near) future to be more efficient and less naive.

yacovm (Tue, 18 Apr 2017 21:36:09 GMT):
I have 4 gossip change sets that @C0rWin has +1ed and are for v1.0 https://gerrit.hyperledger.org/r/#/c/8075 - this is the first of a series that deals with confidentiality - it's basically only `70` lines of production code and the rest is test code. https://gerrit.hyperledger.org/r/#/c/8077/ the 2ndone in the series https://gerrit.hyperledger.org/r/#/c/8081 the 3rd one, just 80 lines, most of it is test code... https://gerrit.hyperledger.org/r/#/c/8155/ this adds basic revocation support to gossip, and will be enhanced in the (near) future to be more efficient and less naive.

wlahti (Wed, 19 Apr 2017 02:18:07 GMT):
Need reviews for this change to enhance the logging for sending block events from the peer: https://gerrit.hyperledger.org/r/#/c/8197/

wlahti (Wed, 19 Apr 2017 02:18:07 GMT):
Need reviews for this change to enhance the logging for sending block events from the peer, please and thank you! https://gerrit.hyperledger.org/r/#/c/8197/

jimthematrix (Wed, 19 Apr 2017 06:01:25 GMT):
https://gerrit.hyperledger.org/r/#/c/7905/ - @JonathanLevi @yacovm both your comments addressed

yacovm (Wed, 19 Apr 2017 06:21:58 GMT):
Didnt i +2?

adc (Wed, 19 Apr 2017 11:48:56 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/7651/ Thanks :)

smithbk (Wed, 19 Apr 2017 12:22:11 GMT):
Pls review for fabric-ca

smithbk (Wed, 19 Apr 2017 12:22:13 GMT):
https://gerrit.hyperledger.org/r/8117 https://gerrit.hyperledger.org/r/8173

smithbk (Wed, 19 Apr 2017 12:23:03 GMT):
Actually, 1st one is for cryptogen

jimthematrix (Wed, 19 Apr 2017 12:23:17 GMT):
@adc I reviewed 7651 and added my comments, thanks

cbf (Wed, 19 Apr 2017 13:49:27 GMT):
simple ones https://gerrit.hyperledger.org/r/#/c/8083/

cbf (Wed, 19 Apr 2017 13:49:45 GMT):
https://gerrit.hyperledger.org/r/#/c/8071/

cbf (Wed, 19 Apr 2017 13:52:26 GMT):
https://gerrit.hyperledger.org/r/#/c/8027/

rjones (Wed, 19 Apr 2017 14:09:47 GMT):
whitespace fixes https://gerrit.hyperledger.org/r/#/c/8179/ https://gerrit.hyperledger.org/r/#/c/8181/

nickgaski (Wed, 19 Apr 2017 14:52:01 GMT):
https://gerrit.hyperledger.org/r/#/c/8231/ - small potatoes, just one line

wlahti (Wed, 19 Apr 2017 15:03:30 GMT):
Error handling changes that have already gone through a number of review cycles: https://gerrit.hyperledger.org/r/#/c/7745/ (functional) and https://gerrit.hyperledger.org/r/#/c/7845/ (documentation)

wlahti (Wed, 19 Apr 2017 15:06:27 GMT):
core.yaml logging section cleanup: https://gerrit.hyperledger.org/r/#/c/7977/ (related to 7745 and can go in after that one is merged) remove fmt.Print calls from peer start: https://gerrit.hyperledger.org/r/#/c/8147/

jimthematrix (Wed, 19 Apr 2017 15:14:56 GMT):
https://gerrit.hyperledger.org/r/#/c/8215/ - verify fails because of the fix needed in https://gerrit.hyperledger.org/r/#/c/7909/, both must be in for the build to succeed. but 8215 did fix what it was intended for: all fabric-ca calls for enroll and register succeeded.

jimthematrix (Wed, 19 Apr 2017 15:15:25 GMT):
can someone override the verify build failure and merge it please? @yacovm @mastersingh24 @binhn

jimthematrix (Wed, 19 Apr 2017 15:16:03 GMT):
basic the two CRs (8215 and 7909) need to get merged asap for the SDK build to be green again

yacovm (Wed, 19 Apr 2017 15:20:29 GMT):
Jim you have a merge conflict for the SDK one

yacovm (Wed, 19 Apr 2017 15:20:34 GMT):
(event)

yacovm (Wed, 19 Apr 2017 15:20:59 GMT):
and also - isn't the event thing on the fabric already merged?

yacovm (Wed, 19 Apr 2017 15:21:49 GMT):
and what fix is in https://gerrit.hyperledger.org/r/#/c/7909/ that the 8215 depends on? I don't understand

jimthematrix (Wed, 19 Apr 2017 15:29:19 GMT):
so 8215 fixes the SDK to react to two breaking changes in fabric-ca (rest api root, ca.name now a required setting)

jimthematrix (Wed, 19 Apr 2017 15:30:09 GMT):
then the end-2-end is still broken after that because of the event security merge, which needs 7909 (i'm rebasing it)

jimthematrix (Wed, 19 Apr 2017 15:30:19 GMT):
@yacovm ^^^

yacovm (Wed, 19 Apr 2017 15:32:43 GMT):
ah so 7909 needs to be merged first right:?

elli-androulaki (Wed, 19 Apr 2017 15:54:39 GMT):
Hi, @binh, @yacov, may you take a look at this one, ACL for CSCC? https://gerrit.hyperledger.org/r/#/c/7651/16

elli-androulaki (Wed, 19 Apr 2017 15:54:39 GMT):
Hi, @binhn , @yacovm , may you take a look at this one, ACL for CSCC? https://gerrit.hyperledger.org/r/#/c/7651/16

yacovm (Wed, 19 Apr 2017 16:02:00 GMT):
The ACL is your request is redundant, Elli

yacovm (Wed, 19 Apr 2017 16:02:00 GMT):
The "ACL" in your request is redundant, Elli

jimthematrix (Wed, 19 Apr 2017 16:15:27 GMT):
no the two are interdependent, so the order doesn't matter. let's merge 8215 first since it's a simpler change and ready to merge

jimthematrix (Wed, 19 Apr 2017 16:15:35 GMT):
@yacovm ^^^

yacovm (Wed, 19 Apr 2017 16:19:04 GMT):
IMO it's better to squash the 2 into one

yacovm (Wed, 19 Apr 2017 16:19:07 GMT):
since they are both SDK

yacovm (Wed, 19 Apr 2017 16:19:10 GMT):
and then it'll succeed

jimthematrix (Wed, 19 Apr 2017 16:30:32 GMT):
agree that's a better route. just updated 7909 with 8215's content squashed into it

jimthematrix (Wed, 19 Apr 2017 16:30:38 GMT):
will abandon 8215

nickgaski (Wed, 19 Apr 2017 16:39:49 GMT):
minor fix here - https://gerrit.hyperledger.org/r/#/c/8239/

elli-androulaki (Wed, 19 Apr 2017 17:19:32 GMT):
@wlahti @binhn @yacovm may you take a look at this, please please :) @aso's CR :) https://gerrit.hyperledger.org/r/#/c/6421/3

jwagantall (Wed, 19 Apr 2017 17:23:09 GMT):
@yacovm thanks so much for merging my changes... i have the last one just now ready https://gerrit.hyperledger.org/r/#/c/8183/ thank you so much!

skarim (Wed, 19 Apr 2017 17:26:41 GMT):
Please review the following fabric-ca changes: https://gerrit.hyperledger.org/r/#/c/7713/ https://gerrit.hyperledger.org/r/#/c/7941/ https://gerrit.hyperledger.org/r/#/c/8145/

yacovm (Wed, 19 Apr 2017 17:41:59 GMT):
Need some help with getting https://gerrit.hyperledger.org/r/#/c/8155/ in. It blocks 2 different commit chains of our squad

binhn (Wed, 19 Apr 2017 18:01:52 GMT):
@elli-androulaki reviewed

aso (Wed, 19 Apr 2017 18:15:30 GMT):
@cbf pls have a look at https://gerrit.hyperledger.org/r/#/c/7853/, it has a -2 from you but I've addressed your comments

smithbk (Wed, 19 Apr 2017 18:30:02 GMT):
Pls review https://gerrit.hyperledger.org/r/#/c/6727/

binhn (Wed, 19 Apr 2017 18:40:33 GMT):
@rjones @cbf why would chris' -2 remains after a new patch pushed https://gerrit.hyperledger.org/r/#/c/7853 ? i thought it would wipe out all review ratings

binhn (Wed, 19 Apr 2017 18:40:33 GMT):
@rjones @cbf why would chris' -2 remains after a new patch pushed https://gerrit.hyperledger.org/r/#/c/7853 ? i thought it would wiped out all review ratings

rjones (Wed, 19 Apr 2017 18:41:48 GMT):
@binhn because -2 is sticky. -1...+2 are not sticky

binhn (Wed, 19 Apr 2017 18:42:50 GMT):
ah, good to know :-) i'll use that from now on :grin:

jimthematrix (Wed, 19 Apr 2017 19:25:10 GMT):
https://gerrit.hyperledger.org/r/#/c/8245/ - trivial change, only error log updates (but critical in understanding the error details)

jwagantall (Wed, 19 Apr 2017 19:58:26 GMT):
@JonathanLevi thanks a ton! last one (promise :) ) the docs https://gerrit.hyperledger.org/r/#/c/8249/2

JonathanLevi (Wed, 19 Apr 2017 20:07:50 GMT):
Jessica: no worries, it does not have the be the "last one"... pray continue! ;-)

JonathanLevi (Wed, 19 Apr 2017 20:19:30 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=4Hw56HuESSGpnEbpe) @aso merged.

aso (Wed, 19 Apr 2017 20:20:10 GMT):
thx @JonathanLevi !

jimthematrix (Wed, 19 Apr 2017 20:37:39 GMT):
@yacovm @binhn @mastersingh24 @JonathanLevi I'm asking you guys for a favor: https://gerrit.hyperledger.org/r/#/c/7909/ the builds on both x86 and s390 have successfully completed the test phase (with all 725 tests passing), but the CI jobs are mysteriously stuck at something for the past 45min. this has been happening on all builds for fabric-sdk-node. have notified Ramesh and Ry but they don't have a solution yet.

jimthematrix (Wed, 19 Apr 2017 20:38:21 GMT):
here's the favor I'm asking, I think at this point it's reasonable to take out "Hyperledger Jobbuilder" from the reviewer list and manually set verified to +1, so this can be merged

yacovm (Wed, 19 Apr 2017 20:42:30 GMT):
I did it for the events one since I sent you back and forth git sqashing change sets and also reviewed it, looks ok to me.

mastersingh24 (Wed, 19 Apr 2017 20:48:47 GMT):
[ I'm fine with the removal of job builder, but https://gerrit.hyperledger.org/r/#/c/8173/ - I don't like the new URL for fabric-ca and I see that you are including that change here](https://chat.hyperledger.org/channel/fabric-pr-review?msg=NueH2jXJDFGFrcwCy) @jimthematrix

latitiah (Wed, 19 Apr 2017 21:05:50 GMT):
Can I get a review on this? It's adding a utility file for use in the behave functional tests (more code to follow): https://gerrit.hyperledger.org/r/#/c/8265/ Thanks!

nickgaski (Wed, 19 Apr 2017 21:07:43 GMT):
one more and it's out the door (or in the door?); anyway +2 please - https://gerrit.hyperledger.org/r/#/c/8247/

binhn (Wed, 19 Apr 2017 21:22:27 GMT):
@greg.haskins please review fabric-baseimage to Go v1.7.5 https://gerrit.hyperledger.org/r/#/c/8267/

greg.haskins (Wed, 19 Apr 2017 21:32:38 GMT):
@binhn done

mastersingh24 (Wed, 19 Apr 2017 21:43:03 GMT):
[ Can you guys check my comment about s390 and ppc64le?](https://chat.hyperledger.org/channel/fabric-pr-review?msg=iQcxFw8nwA2yAtQWg) @binhn @greg.haskins

binhn (Wed, 19 Apr 2017 21:49:33 GMT):
sure

binhn (Wed, 19 Apr 2017 21:53:55 GMT):
@vpaprots please review the z Go version in the baseimage, we are moving to 1.7.5 https://gerrit.hyperledger.org/r/#/c/8267

vpaprots (Wed, 19 Apr 2017 21:54:11 GMT):
caught me redhanded.. comenting already :)

binhn (Wed, 19 Apr 2017 21:54:32 GMT):
telepathy -- thanks

vpaprots (Wed, 19 Apr 2017 21:57:22 GMT):
@binhn @mastersingh24 I just asked Bill to rebase his golang on z branch.. he has till it gets merged to do it?

binhn (Wed, 19 Apr 2017 21:59:04 GMT):
would we need to do anything here https://gerrit.hyperledger.org/r/#/c/8267/1/scripts/common/setup.sh@44 ?

vpaprots (Wed, 19 Apr 2017 21:59:36 GMT):
no, no change. on line 47 is the actual compiler source

binhn (Wed, 19 Apr 2017 21:59:38 GMT):
currently https://storage.googleapis.com/golang/go1.7.1.linux-s390x.tar.gz

vpaprots (Wed, 19 Apr 2017 21:59:46 GMT):
but the branch name will stay the same

vpaprots (Wed, 19 Apr 2017 22:00:03 GMT):
(44 is the golang compiler used to build the actual golang compiler)

binhn (Wed, 19 Apr 2017 22:00:28 GMT):
ha ha we are recursive

vpaprots (Wed, 19 Apr 2017 22:00:51 GMT):
makes you wonder how first golang was 'born' :D

binhn (Wed, 19 Apr 2017 22:01:40 GMT):
same as the first chicken

vpaprots (Wed, 19 Apr 2017 22:05:25 GMT):
https://gerrit.hyperledger.org/r/#/c/6727 Fabric ca SW BCCSP integration << responded to @mastersingh24 comments, Keith +1'ed, Gari, @JonathanLevi this probably needs your eyes again https://gerrit.hyperledger.org/r/#/c/8103 PKCS11 BCCSP fixes << Got +2 from Gari, @yacovm lost your +2 from pushing another patch https://gerrit.hyperledger.org/r/#/c/8105 cryptogen + pkcs11 << Gari, @binhn this probably needs you both

binhn (Wed, 19 Apr 2017 22:26:41 GMT):
@SriramaSharma could you review the Power Go version in the baseimage, we are moving to 1.7.5 https://gerrit.hyperledger.org/r/#/c/8267

ada-wang (Thu, 20 Apr 2017 01:56:15 GMT):
Has joined the channel.

skarim (Thu, 20 Apr 2017 02:10:52 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/7941/ https://gerrit.hyperledger.org/r/#/c/7789/ https://gerrit.hyperledger.org/r/#/c/7903/

jimthematrix (Thu, 20 Apr 2017 02:21:12 GMT):
@mastersingh24 @smithbk I like the new api root /api/v1 better as well

elli-androulaki (Thu, 20 Apr 2017 09:28:35 GMT):
Hi, a review (and ideally a +2) would be much appreciated here :) https://gerrit.hyperledger.org/r/#/c/8141/5

mastersingh24 (Thu, 20 Apr 2017 10:19:40 GMT):
@elli-androulaki - added some comments ^^^

mastersingh24 (Thu, 20 Apr 2017 10:45:07 GMT):
https://gerrit.hyperledger.org/r/#/c/8269/ - please have a look. some nice changes by @greg.haskins which will help us make our sample configs easier to generate and more consumable

yacovm (Thu, 20 Apr 2017 11:25:34 GMT):
https://gerrit.hyperledger.org/r/#/c/8155/ is still left in the :cloud_rain: , waiting for 1 more :heavy_plus_sign::two: to join his friends in the merged change set list

mastersingh24 (Thu, 20 Apr 2017 11:30:19 GMT):
@yacovm - done - added a comment as well for when we deal with the TLS issue for updating the root CAs - not sure if what I wrote makes sense but just a thought

mastersingh24 (Thu, 20 Apr 2017 11:30:53 GMT):
while you are here, can you look at https://gerrit.hyperledger.org/r/#/c/8269/ real quick?

elli-androulaki (Thu, 20 Apr 2017 11:34:34 GMT):
@mastersingh24 thanks!

SriramaSharma (Thu, 20 Apr 2017 11:35:57 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=vivyd8yXWSvK9QdC9) @binhn The current version of go is 1.7 which corresponds to advance_toolchain v10.0-1 which is being used in fabric-baseimage. I also wanted to upgrade the same with latest version of advanced toolchain 10.0-3 (that got released recently) which corresponds to go v1.7.5. will confirm that again and update on CR.

SriramaSharma (Thu, 20 Apr 2017 11:35:57 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=vivyd8yXWSvK9QdC9) @binhn The current version of go is 1.7 which corresponds to advance_toolchain v10.0-1 which is being used in fabric-baseimage for ppc64le. I also wanted to upgrade the same with latest version of advanced toolchain 10.0-3 (that got released recently) which corresponds to go v1.7.5. will confirm that again and update on CR.

mastersingh24 (Thu, 20 Apr 2017 11:37:36 GMT):
great. thx @SriramaSharma

yacovm (Thu, 20 Apr 2017 12:21:39 GMT):
@mastersingh24 yes- I left a small comment, should @greg.haskins address this before it's merged?

greg.haskins (Thu, 20 Apr 2017 12:22:06 GMT):
@yacovm which CR are we talking about?

yacovm (Thu, 20 Apr 2017 12:22:23 GMT):
Your 1K dependency one :)

yacovm (Thu, 20 Apr 2017 12:23:01 GMT):
`Make cryptogen output more flexible`

nickgaski (Thu, 20 Apr 2017 12:37:18 GMT):
https://gerrit.hyperledger.org/r/#/c/8247/ - still looking for one more here

jiangyaoguo (Thu, 20 Apr 2017 13:07:21 GMT):
https://gerrit.hyperledger.org/r/#/c/7831/ needs +2 after rebased @binhn

mastersingh24 (Thu, 20 Apr 2017 13:09:48 GMT):
https://gerrit.hyperledger.org/r/#/c/8277/ - easy one please

binhn (Thu, 20 Apr 2017 13:15:33 GMT):
@jiangyaoguo thanks - done

muralisr (Thu, 20 Apr 2017 14:58:37 GMT):
@jiangyaoguo were you going to open a new JIRA to complete the followup (version check etc) on the upgrade or use existing one ?

jiangyaoguo (Thu, 20 Apr 2017 15:13:22 GMT):
@binhn thanks. @muralisr I'll complete the followup as FAB-1516 part2.

dave.enyeart (Thu, 20 Apr 2017 16:07:18 GMT):
Still need reviews for these aging ledger items. They have been out there for review for a couple weeks. They have been peer reviewed, under the recommended lines of code, tested end-to-end, and rebased to ensure they are still valid. Please help! https://gerrit.hyperledger.org/r/#/c/7687 Switch QueryResult to protobuf to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7787 Switch gob encoding to enable java chaincode https://gerrit.hyperledger.org/r/#/c/7255 Fix chaincode result set paging https://gerrit.hyperledger.org/r/#/c/7099 Provide CouchDB default config (security) https://gerrit.hyperledger.org/r/#/c/6793 Benchmark test framework for ledger (large… but it’s a test harness not production code) https://gerrit.hyperledger.org/r/#/c/7975 Create CouchDB system databases https://gerrit.hyperledger.org/r/#/c/8139 History enablement in core.yaml

guoger (Thu, 20 Apr 2017 16:16:09 GMT):
Has joined the channel.

greg.haskins (Thu, 20 Apr 2017 16:17:19 GMT):
if we could get some priority on this one https://gerrit.hyperledger.org/r/#/c/7963 for review, it would be appreciated...its facing nearly hourly merge conflicts due to the sheer breadth of the change and people adding new tests. Its very hard to use fabric in a real-world deployment scenario without it that hopefully people like @mastersingh24 can attest. Ill try to track what new CI failure just crept in

cbf (Thu, 20 Apr 2017 16:31:07 GMT):
greg, there are go import errors and the build fails on this

cbf (Thu, 20 Apr 2017 16:31:10 GMT):
https://jenkins.hyperledger.org/job/fabric-verify-x86_64/9936/console

cbf (Thu, 20 Apr 2017 16:31:37 GMT):
14:44:56 LINT: Running code checks.. 14:45:00 Checking ./bccsp 14:45:01 Checking ./common 14:45:02 Checking ./core 14:45:04 Checking ./events 14:45:04 Checking ./examples 14:45:05 Checking ./gossip 14:45:06 Checking ./msp 14:45:07 Checking ./orderer 14:45:08 Checking ./peer 14:45:08 The following files contain goimports errors 14:45:08 peer/common/common.go 14:45:08 The goimports command must be run for these files 14:45:14 Makefile:156: recipe for target 'linter' failed

cbf (Thu, 20 Apr 2017 16:31:46 GMT):
@greg.haskins ^^

muralisr (Thu, 20 Apr 2017 16:33:47 GMT):
@greg.haskins also, were you able to run `./networks_setup.sh up` successfully ?

cbf (Thu, 20 Apr 2017 16:35:50 GMT):
@dave.enyeart https://gerrit.hyperledger.org/r/#/c/7255/12 needs rebase

greg.haskins (Thu, 20 Apr 2017 16:50:44 GMT):
@cbf yeah, hasty rebase...fixing it up nw

greg.haskins (Thu, 20 Apr 2017 16:51:01 GMT):
@muralisr not yet, will look at that now

greg.haskins (Thu, 20 Apr 2017 16:51:26 GMT):
right now, just trying to rally up support for getting it reviewed/merged once I get there, because it will quickly grow stale

muralisr (Thu, 20 Apr 2017 16:51:35 GMT):
right

muralisr (Thu, 20 Apr 2017 16:52:55 GMT):
having some tech. difficulties, will continue testing when I can get around

muralisr (Thu, 20 Apr 2017 16:53:28 GMT):
but agree important to review ASAP given scope

muralisr (Thu, 20 Apr 2017 16:53:28 GMT):
but agree important to review ASAP given scope @greg.haskins

greg.haskins (Thu, 20 Apr 2017 17:05:36 GMT):
its ok...i literally cannot keep up...i rebase/resolve only to find ive already gone stale in a few minutes

greg.haskins (Thu, 20 Apr 2017 17:05:41 GMT):
massive churn right now, heh

nickgaski (Thu, 20 Apr 2017 17:11:22 GMT):
easy one here; adds channels piece to our Arch section and adds the CC packaging doc to Ops Guide section - https://gerrit.hyperledger.org/r/#/c/8307/

greg.haskins (Thu, 20 Apr 2017 17:13:25 GMT):
This one is easier than 7963 and is ready to go for anyone willing to take a look: https://gerrit.hyperledger.org/r/#/c/8269/

wlahti (Thu, 20 Apr 2017 17:16:00 GMT):
Hey maintainers, I'd appreciate reviews for one documentation CR for the error handling framework: https://gerrit.hyperledger.org/r/#/c/7845/ and then for one small CR that changes fmt.Print calls during peer start to use the logger: https://gerrit.hyperledger.org/r/#/c/8147/. Thanks!

elli-androulaki (Thu, 20 Apr 2017 18:55:39 GMT):
Hi, we could use some maintainer reviews in the following sequence of CRs of Ale's : https://gerrit.hyperledger.org/r/#/c/8253/, https://gerrit.hyperledger.org/r/#/c/8305/1, https://gerrit.hyperledger.org/r/#/c/8305/1 .

elli-androulaki (Thu, 20 Apr 2017 18:57:32 GMT):
The CRs depend on this one https://gerrit.hyperledger.org/r/#/c/8141/, but given CI frequent failures today, it would be super helpful for us if we could collect your feedback in advance and start addressing your comments (even if the CRs cannot be merged yet).

elli-androulaki (Thu, 20 Apr 2017 18:58:36 GMT):
The CRs are on on security around instantiation/installation and upgrade.

muralisr (Thu, 20 Apr 2017 19:41:23 GMT):
@greg.haskins with the latest patch `./networks_setup.sh up` works... will do a few more shortly

greg.haskins (Thu, 20 Apr 2017 19:41:45 GMT):
cool

muralisr (Thu, 20 Apr 2017 19:41:45 GMT):
^^^ context https://gerrit.hyperledger.org/r/#/c/7963

smithbk (Thu, 20 Apr 2017 20:33:43 GMT):
https://gerrit.hyperledger.org/r/#/c/8173/ needs one more review. It's an easy one. Thanks

vpaprots (Thu, 20 Apr 2017 21:17:49 GMT):
an easy one: https://gerrit.hyperledger.org/r/#/c/8281/ fabric-ca SW bccsp integration: https://gerrit.hyperledger.org/r/#/c/6727/ << @mastersingh24 @JonathanLevi

mastersingh24 (Thu, 20 Apr 2017 21:19:04 GMT):
@vpaprots - I still don't like 6727 - will come back to you on it - I think it only needs a small change

vpaprots (Thu, 20 Apr 2017 21:22:32 GMT):
And the note I sent this morning about static builds: https://gerrit.hyperledger.org/r/#/c/8285 https://gerrit.hyperledger.org/r/#/c/8287

vpaprots (Thu, 20 Apr 2017 21:24:10 GMT):
@mastersingh24 I also need to revendor bccsp into fabric-ca again with the fixes that you and Yacov merged in yesterday, would be good to get 8281 in first

mastersingh24 (Thu, 20 Apr 2017 21:24:58 GMT):
you guys kill me with changing config properties - ugh

mastersingh24 (Thu, 20 Apr 2017 21:25:18 GMT):
we still use keystore for loading the local msp

mastersingh24 (Thu, 20 Apr 2017 21:25:48 GMT):
can we punt on 8281?

vpaprots (Thu, 20 Apr 2017 21:26:08 GMT):
how do you mean?

mastersingh24 (Thu, 20 Apr 2017 21:26:14 GMT):
I mean not do it ;)

vpaprots (Thu, 20 Apr 2017 21:26:27 GMT):
heh.

mastersingh24 (Thu, 20 Apr 2017 21:26:59 GMT):
well others can decide ;)

vpaprots (Thu, 20 Apr 2017 21:27:03 GMT):
the msp config is mostly 'implicit'

mastersingh24 (Thu, 20 Apr 2017 21:27:06 GMT):
I gotta run for a bit

vpaprots (Thu, 20 Apr 2017 21:27:32 GMT):
@smithbk ^ since you opened the Jira item for 8281?

mastersingh24 (Thu, 20 Apr 2017 21:27:42 GMT):
here's my issue - the config is hard enough as it is and fragile - so not sure we need to introduce a aesthetic change

mastersingh24 (Thu, 20 Apr 2017 21:27:56 GMT):
anyway - let the community prevail

mastersingh24 (Thu, 20 Apr 2017 21:28:03 GMT):
;)

mastersingh24 (Thu, 20 Apr 2017 21:28:22 GMT):
I will not stand in the way of progress (even if I think it's backwards progress) ;)

vpaprots (Thu, 20 Apr 2017 21:28:24 GMT):
yep. I see the issue, on other hand its not very clear.. so.. its out there. .thats why I am asking for reviews :)

vpaprots (Thu, 20 Apr 2017 21:28:24 GMT):
yep. I see the issue, on other hand its not very clear name.. so.. its out there. .thats why I am asking for reviews :)

smithbk (Thu, 20 Apr 2017 21:30:15 GMT):
I opened it a while ago I thought, while there was still time, but given that it is minor and this late, makes sense to me to just let it go. It is not a big deal.

yacovm (Thu, 20 Apr 2017 21:33:10 GMT):
This one is pretty easy IMO - just adds scaffolding https://gerrit.hyperledger.org/r/#/c/8077 Already have 1 +1 and 1 +2

yacovm (Thu, 20 Apr 2017 21:33:10 GMT):
This one is pretty easy IMO - just adds scaffolding https://gerrit.hyperledger.org/r/#/c/8077 but doesn't change any functionality. Already have 1 +1 and 1 +2

mastersingh24 (Thu, 20 Apr 2017 21:34:44 GMT):
sorry @yacovm - you already have my vote ;)

yacovm (Thu, 20 Apr 2017 21:34:53 GMT):
yep.

latitiah (Thu, 20 Apr 2017 21:37:01 GMT):
:beer: for +2s on these CRs: :) https://gerrit.hyperledger.org/r/#/c/8265 https://gerrit.hyperledger.org/r/#/c/8327/

smithbk (Thu, 20 Apr 2017 21:46:02 GMT):
https://gerrit.hyperledger.org/r/#/c/7741/ ... thanks

latitiah (Thu, 20 Apr 2017 22:31:15 GMT):
... and another: http://gerrit.hyperledger.org/r/8329 (this is scaffolding for these tests)

yacovm (Thu, 20 Apr 2017 22:37:18 GMT):
@JonathanLevi thanks for the merge! @mastersingh24 This one doesn't have your vote and it's pretty easy (3 lines of production code only) https://gerrit.hyperledger.org/r/#/c/8217/

mastersingh24 (Thu, 20 Apr 2017 22:38:47 GMT):
@yacovm - done - sorry - just never gve it a +2 when I looked at it

yacovm (Thu, 20 Apr 2017 22:38:57 GMT):
np and thanks!

mastersingh24 (Thu, 20 Apr 2017 23:04:22 GMT):
https://gerrit.hyperledger.org/r/#/c/7483/ - easy doc update

smithbk (Fri, 21 Apr 2017 12:15:33 GMT):
The following are for FAB-2896 (fabric-ca multi-CA support) and need reviews in the following order: https://gerrit.hyperledger.org/r/#/c/7713 (Jonathan +2, needs another) https://gerrit.hyperledger.org/r/#/c/7941 https://gerrit.hyperledger.org/r/#/c/7789 And this one for review also: https://gerrit.hyperledger.org/r/7471

greg.haskins (Fri, 21 Apr 2017 13:23:01 GMT):
@muralisr @mastersingh24 did (yet another) rebase/resolve and 7963 is now building:: https://gerrit.hyperledger.org/r/#/c/7963/

greg.haskins (Fri, 21 Apr 2017 13:23:35 GMT):
if/when this goes in, I suggest that we hit the rebase button on any pending CRs to root out any additional conflicts

greg.haskins (Fri, 21 Apr 2017 13:23:35 GMT):
if/when this goes in, I suggest that we hit the rebase button on any pending CRs to flush out any additional conflicts

greg.haskins (Fri, 21 Apr 2017 13:24:01 GMT):
@rjones: is there a master "rebase all" option in gerrit ?

greg.haskins (Fri, 21 Apr 2017 13:25:15 GMT):
the problem is people are adding lines like this: https://gerrit.hyperledger.org/r/#/c/7963/18/core/committer/txvalidator/txvalidator_test.go

greg.haskins (Fri, 21 Apr 2017 13:25:17 GMT):
all the time

greg.haskins (Fri, 21 Apr 2017 13:31:03 GMT):
and the only way to really find them in an automated way is to run the UTs

Nishi (Fri, 21 Apr 2017 13:57:00 GMT):
Has joined the channel.

Nishi (Fri, 21 Apr 2017 14:06:38 GMT):
hi submitted patchset https://gerrit.hyperledger.org/r/#/c/8275/ - this has basic e2e environment for quality-tests, we intend to push more tests, so that tests can be integrated into CI runs in our regression bucket.

Nishi (Fri, 21 Apr 2017 14:06:58 GMT):
Can maintainers please approve this patchset - thanks!

Nishi (Fri, 21 Apr 2017 14:06:58 GMT):
Please hold on my review making some directory changes...

wlahti (Fri, 21 Apr 2017 14:21:28 GMT):
Error handling documentation change ready for review (finally passed CI): https://gerrit.hyperledger.org/r/#/c/7845/

elli-androulaki (Fri, 21 Apr 2017 16:35:53 GMT):
A review here, would be much appreciated as the CI finally completed successfully!! https://gerrit.hyperledger.org/r/#/c/8229/, and here https://gerrit.hyperledger.org/r/#/c/8141/ and the gerrit chain upwards! Yacov has already given them +2 and I have reviewed it :)

C0rWin (Fri, 21 Apr 2017 16:49:04 GMT):
A simple one, takes care of golint warning for gossip package: https://gerrit.hyperledger.org/r/#/c/8321/, already have +2 need a final one :)

tkuhrt (Fri, 21 Apr 2017 17:23:36 GMT):
Has joined the channel.

tkuhrt (Fri, 21 Apr 2017 17:26:53 GMT):
Review needed: Document changes to fix [FAB-3229] broken links in Development Setup pages: https://gerrit.hyperledger.org/r/#/c/8325/2?

tkuhrt (Fri, 21 Apr 2017 17:26:53 GMT):
Review needed: Document changes to fix [FAB-3229] broken links in Development Setup pages: https://gerrit.hyperledger.org/r/#/c/8325/2

yacovm (Fri, 21 Apr 2017 17:42:57 GMT):
@elli-androulaki , it seems that although the CI gave its blessings, the e2e fails (thanks for the heads up @adc and @aso ) so I withdrew my +2s IMO - we really need to identify the missing code paths that do not exist in unit tests but that are executed in production (e2e) and add test coverage for those.

yacovm (Fri, 21 Apr 2017 17:42:57 GMT):
@elli-androulaki , it seems that although the CI gave its blessings, the e2e fails (thanks for the heads up @adc and @aso ) so I withdrew my +2s IMO - we really need to identify the missing code paths that do not exist in unit tests but are executed in production (e2e) and add test coverage for those.

elli-androulaki (Fri, 21 Apr 2017 17:44:08 GMT):
yes, i noticed unfortunately; thanks for the prompt move...

elli-androulaki (Fri, 21 Apr 2017 17:44:08 GMT):
yes, i just noticed unfortunately; thanks for the prompt move...

greg.haskins (Fri, 21 Apr 2017 17:56:31 GMT):
@muralisr @mastersingh24 ok, its ready for consideration: https://gerrit.hyperledger.org/r/#/c/7963/

muralisr (Fri, 21 Apr 2017 18:00:33 GMT):
We should always run tests e2e and anything else before merging ...

muralisr (Fri, 21 Apr 2017 18:01:57 GMT):
will look later tonight (your time) @greg.haskins ...

adc (Fri, 21 Apr 2017 18:07:36 GMT):
just pushed the fix implemented by Alessandro to https://gerrit.hyperledger.org/r/#/c/8229/

adc (Fri, 21 Apr 2017 18:07:39 GMT):
now e2e works :)

greg.haskins (Fri, 21 Apr 2017 18:15:03 GMT):
anyone else that is around that can review 7963?

greg.haskins (Fri, 21 Apr 2017 18:15:47 GMT):
@cbf @binhn ^^^ ?

binhn (Fri, 21 Apr 2017 18:21:58 GMT):
@greg.haskins will do

elli-androulaki (Fri, 21 Apr 2017 18:33:47 GMT):
thanks @aso, thanks @adc!

elli-androulaki (Fri, 21 Apr 2017 18:33:47 GMT):
thanks @aso, thanks @adc! > just pushed the fix implemented by Alessandro to https://gerrit.hyperledger.org/r/#/c/8229

RandyM1 (Fri, 21 Apr 2017 19:11:52 GMT):
Has joined the channel.

RandyM1 (Fri, 21 Apr 2017 19:18:02 GMT):
Hi - I'm new and decided to try https://jira.hyperledger.org/browse/FAB-2784 first in an attempt to learn the tech stack. Are there a suggested set of tests to run before commit? bddtests fail for me, but they also fail in exactly the same way on a fresh checkout without my changes. Is there a place online (ie CI tests) that I can compare my test runs against? I plan to test thoroughly before submitting anything to review :)

RandyM1 (Fri, 21 Apr 2017 19:18:31 GMT):
*before submitting a review - not commit

Nishi (Fri, 21 Apr 2017 20:02:40 GMT):
Submitted patchset https://gerrit.hyperledger.org/r/#/c/8275/ to be able to add regression tests to CI pipeleine. - can we get approval on this patch set. Thanks!

RandyM1 (Fri, 21 Apr 2017 20:07:54 GMT):
Ah I see TravisCI_Readme.md has what I need

cbf (Fri, 21 Apr 2017 20:31:08 GMT):
https://gerrit.hyperledger.org/r/#/c/8237/

cbf (Fri, 21 Apr 2017 20:31:11 GMT):
easy one

Ratnakar (Fri, 21 Apr 2017 21:32:16 GMT):
Submitted a patch for DC hackfest https://gerrit.hyperledger.org/r/#/c/8393/

Ratnakar (Fri, 21 Apr 2017 21:32:24 GMT):
nick is working on the README

aambati (Fri, 21 Apr 2017 21:32:43 GMT):
@smithbk @mastersingh24 I have fixed merge conflicts with change set https://gerrit.hyperledger.org/r/#/c/7815/ , please replus them as you had already plussed them before

yacovm (Fri, 21 Apr 2017 21:46:07 GMT):
Please help the war effort by merging this https://gerrit.hyperledger.org/r/#/c/8397/ that skips a test that sometimes fails in CI

yacovm (Fri, 21 Apr 2017 21:46:07 GMT):
Please help the war (well, more like code merging) effort by merging this https://gerrit.hyperledger.org/r/#/c/8397/ that skips a test that sometimes fails in CI

JonathanLevi (Fri, 21 Apr 2017 21:46:47 GMT):
@aambati: merged.

aambati (Fri, 21 Apr 2017 21:47:20 GMT):
@JonathanLevi thank you

aambati (Fri, 21 Apr 2017 21:47:31 GMT):
@smithbk Please review https://gerrit.hyperledger.org/r/#/c/7725/ and replus https://gerrit.hyperledger.org/r/#/c/7989/ (fixed merge conflict)

dave.enyeart (Fri, 21 Apr 2017 22:01:19 GMT):
@cbf @binhn @kostas these are urgent ones... https://gerrit.hyperledger.org/r/#/c/8399/ Fixes unit test failures do to a stale merge https://gerrit.hyperledger.org/r/#/c/8391/ Fixes intermittent unit test failures due to couch timeout

dave.enyeart (Fri, 21 Apr 2017 22:01:19 GMT):
@cbf @binhn @kostas these are urgent ones... https://gerrit.hyperledger.org/r/#/c/8399/ Fixes unit test failures due to a stale merge https://gerrit.hyperledger.org/r/#/c/8391/ Fixes intermittent unit test failures due to couch timeout

JonathanLevi (Fri, 21 Apr 2017 22:17:46 GMT):
@mastersingh24 : https://gerrit.hyperledger.org/r/#/c/8399/

JonathanLevi (Fri, 21 Apr 2017 22:17:55 GMT):
(i have approved/skipped quickly)

dave.enyeart (Fri, 21 Apr 2017 22:18:33 GMT):
Thanks Jonathan

JonathanLevi (Fri, 21 Apr 2017 22:18:39 GMT):
@Ratnakar: All licenses for new files should be `2017`

mastersingh24 (Fri, 21 Apr 2017 22:32:50 GMT):
done

mastersingh24 (Fri, 21 Apr 2017 22:33:24 GMT):
@jimthematrix -https://gerrit.hyperledger.org/r/#/c/8349/

mastersingh24 (Fri, 21 Apr 2017 22:33:24 GMT):
@jimthematrix - https://gerrit.hyperledger.org/r/#/c/8349/

Ratnakar (Fri, 21 Apr 2017 22:41:28 GMT):
@JonathanLevi Updated the license ( some of the chaincode files are uploaded accidentally )

muralisr (Sat, 22 Apr 2017 00:31:21 GMT):
@greg.haskins https://gerrit.hyperledger.org/r/#/c/8229 needs a rebase (again) unfort. now that e2e was also working issues related to this change has been largely (hopefully all) worked out we can merge this soon ... I have been reviewing (and testing) and will finish the review today.

muralisr (Sat, 22 Apr 2017 00:31:21 GMT):
@greg.haskins https://gerrit.hyperledger.org/r/#/c/7963 needs a rebase (again) unfort. now that e2e was also working issues related to this change has been largely (hopefully all) worked out we can merge this soon ... I have been reviewing (and testing) and will finish the review today.

rjones (Sat, 22 Apr 2017 01:26:18 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=2vY7aD55ruQdbRckS) @greg.haskins no but as a committer you could run through the UI and do a ton of rebases

Senthil1 (Sat, 22 Apr 2017 03:00:43 GMT):
Has joined the channel.

harsha (Sat, 22 Apr 2017 04:21:39 GMT):
Can someone review https://gerrit.hyperledger.org/r/#/c/7887/7/ ?

adc (Sat, 22 Apr 2017 05:27:29 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/8301/. Thanks :)

jiangyaoguo (Sat, 22 Apr 2017 06:34:28 GMT):
hi, all. Need some love to https://gerrit.hyperledger.org/r/#/c/8409/ . A minimal CR of adding ChaincodeID to ChaincodeAction. so that we can working on following CRs concurrently.

jiangyaoguo (Sat, 22 Apr 2017 06:44:18 GMT):
This is important part of chaincode upgrade https://jira.hyperledger.org/browse/FAB-3334. and will complete https://jira.hyperledger.org/browse/FAB-198 . blocks FAB-3329 and FAB-3330.

dave.enyeart (Sat, 22 Apr 2017 10:58:46 GMT):
https://gerrit.hyperledger.org/r/#/c/7255/ - Re-introduce chaincode result set paging. Would especially like @muralisr to review

mastersingh24 (Sat, 22 Apr 2017 11:56:46 GMT):
[ merged](https://chat.hyperledger.org/channel/fabric-pr-review?msg=PkQvKo5Aep4c7jyZn) @jiangyaoguo

mastersingh24 (Sat, 22 Apr 2017 11:58:27 GMT):
https://gerrit.hyperledger.org/r/#/c/8349/ - should help with allowing the output of cryptogen to work with the SDKs - @jimthematrix @adc @JonathanLevi

jimthematrix (Sat, 22 Apr 2017 11:59:50 GMT):
reviewed the code, looks good to my understanding, just trying to download it and try the output with node SDK

jimthematrix (Sat, 22 Apr 2017 12:08:17 GMT):
merged, thanks Gari!

wlahti (Sat, 22 Apr 2017 13:10:05 GMT):
My big CR to update the all the loggers for the peer is ready to go: https://gerrit.hyperledger.org/r/#/c/8311/ . It touches a lot of files but the majority of them it simply changes `logging.MustGetLogger` to `flogging.MustGetLogger` (and imports the package). Once this is in, updating the log level for modules using regular expressions will be enabled for anything running on the peer (say goodbye to jumping through hoops to turn off gossip logging :laughing:).

adc (Sat, 22 Apr 2017 13:29:55 GMT):
love, love, love to https://gerrit.hyperledger.org/r/#/c/6279/ please :)

mastersingh24 (Sat, 22 Apr 2017 13:32:48 GMT):
https://gerrit.hyperledger.org/r/#/c/8173/ - @jimthematrix - not sure when you'll be ready for this - but this is the URI change for fabric-ca

adc (Sat, 22 Apr 2017 13:35:22 GMT):
https://gerrit.hyperledger.org/r/#/c/8359/ increases test coverage, please have a look :)

yacovm (Sat, 22 Apr 2017 13:40:10 GMT):
https://gerrit.hyperledger.org/r/#/c/8411/ easy bug fix

wlahti (Sat, 22 Apr 2017 13:41:13 GMT):
One more CR that moves the error handling framework from core to common: https://gerrit.hyperledger.org/r/#/c/8417/

adc (Sat, 22 Apr 2017 13:55:12 GMT):
CI passed on https://gerrit.hyperledger.org/r/#/c/8229/, please have a look :)

adc (Sat, 22 Apr 2017 18:16:02 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/8301/ :)

adc (Sat, 22 Apr 2017 18:16:16 GMT):
also https://gerrit.hyperledger.org/r/#/c/8229/, thanks

jimthematrix (Sat, 22 Apr 2017 20:15:32 GMT):
@mastersingh24 finally got past the node SDK build errors: https://gerrit.hyperledger.org/r/#/c/8011/

jimthematrix (Sat, 22 Apr 2017 20:15:51 GMT):
so i should be ready to change for the api URI update now

jimthematrix (Sat, 22 Apr 2017 20:16:44 GMT):
speaking of which, would appreciate help on reviewing and merging 8011 (also @yacovm @binhn)

jimthematrix (Sat, 22 Apr 2017 20:19:28 GMT):
warning: it's a large changeset due to: 1. 3 fixes are needed at the same time to get past the build errors 2. used the updated `cryptogen` tool in order to get admin private keys which has a different directory structure

jimthematrix (Sat, 22 Apr 2017 20:19:44 GMT):
majority of the changes are in test code

yacovm (Sat, 22 Apr 2017 22:08:50 GMT):
https://gerrit.hyperledger.org/r/#/c/8315/ Adding gossip identity(certificate) expiration support

yacovm (Sat, 22 Apr 2017 22:08:50 GMT):
https://gerrit.hyperledger.org/r/#/c/8315/ Adding gossip identity(certificate) expiration support Most of the change (200 lines) is because I had to refactor a test in order to have finer-grained control on flow of things to add a test

yacovm (Sat, 22 Apr 2017 22:08:50 GMT):
https://gerrit.hyperledger.org/r/#/c/8315/ Adding gossip identity(certificate) expiration support Most of the change (200 lines out of 333) is because I had to refactor a test in order to have finer-grained control on flow of things to add a test

jimthematrix (Sun, 23 Apr 2017 00:51:14 GMT):
https://gerrit.hyperledger.org/r/#/c/8429/ - simple change in response to fabric-ca REST API root uri

muralisr (Sun, 23 Apr 2017 01:00:29 GMT):
done @jimthematrix

jimthematrix (Sun, 23 Apr 2017 01:42:13 GMT):
https://gerrit.hyperledger.org/r/#/c/8365/ - simple one again for fabric-ca register() call

adc (Sun, 23 Apr 2017 06:27:10 GMT):
Hi All, please have a look at https://gerrit.hyperledger.org/r/#/c/8229/ and https://gerrit.hyperledger.org/r/#/c/8301/. Thanks :)

yacovm (Sun, 23 Apr 2017 09:46:36 GMT):
2 Change sets related to gossip confidentiality. https://gerrit.hyperledger.org/r/#/c/8081/ This had 2 +2s but I had to resolve a merge conflict so they got wiped. https://gerrit.hyperledger.org/r/#/c/8091/ This already has 1 +1 from @C0rWin https://gerrit.hyperledger.org/r/#/c/8315/ Adding gossip identity(certificate) expiration support

yacovm (Sun, 23 Apr 2017 09:46:36 GMT):
3 Change sets related to gossip security https://gerrit.hyperledger.org/r/#/c/8081/ This had 2 +2s but I had to resolve a merge conflict so they got wiped. https://gerrit.hyperledger.org/r/#/c/8091/ This already has 1 +1 from @C0rWin https://gerrit.hyperledger.org/r/#/c/8315/ Adding gossip identity(certificate) expiration support

yacovm (Sun, 23 Apr 2017 09:46:36 GMT):
4 Change sets related to gossip security https://gerrit.hyperledger.org/r/#/c/8081/ This had 2 +2s but I had to resolve a merge conflict so they got wiped. https://gerrit.hyperledger.org/r/#/c/8091/ This already has 1 +1 from @C0rWin https://gerrit.hyperledger.org/r/#/c/8315/ Adding gossip identity(certificate) expiration support https://gerrit.hyperledger.org/r/#/c/8219/ Switching from `math.Rand` usage to `crypto.Rand` usage in gossip, easy CR

yacovm (Sun, 23 Apr 2017 09:46:36 GMT):
2 Change sets related to gossip security https://gerrit.hyperledger.org/r/#/c/8315/ Adding gossip identity(certificate) expiration support https://gerrit.hyperledger.org/r/#/c/8219/ Switching from `math.Rand` usage to `crypto.Rand` usage in gossip, easy CR

C0rWin (Sun, 23 Apr 2017 10:20:38 GMT):
Simple fix of CSCC: https://gerrit.hyperledger.org/r/#/c/8433/ avoiding to block content into error message and array out of bound exception

muralisr (Sun, 23 Apr 2017 11:58:46 GMT):
an easy CR to help with trouble-shooting and serviceability of chaincodes please - https://gerrit.hyperledger.org/r/#/c/8435/

adc (Sun, 23 Apr 2017 12:58:57 GMT):
Hi All, please look at https://gerrit.hyperledger.org/r/#/c/8229/ It is ready to be merged and need just a bit more love :)

adc (Sun, 23 Apr 2017 14:36:18 GMT):
last mile for https://gerrit.hyperledger.org/r/#/c/8301/, please have a look :)

adc (Sun, 23 Apr 2017 15:23:28 GMT):
I know there is still some love in this channel available, please give it to https://gerrit.hyperledger.org/r/#/c/8141/9 :)

yacovm (Sun, 23 Apr 2017 16:15:23 GMT):
https://gerrit.hyperledger.org/r/#/c/8445/ without this, flogging outputs ~ 50 lines at peer startup.

mastersingh24 (Sun, 23 Apr 2017 16:49:20 GMT):
https://gerrit.hyperledger.org/r/#/c/8441/ - better test coverage for cryptogen - still needs tests for the main function but this cleans up the existing tests

jimthematrix (Sun, 23 Apr 2017 20:03:45 GMT):
@adc while adding ACL please keep the SDK in mind because every strengthened check will cause existing SDK end2end test to fail. the tests have been all using the "Members" identities so far (node SDK has been updated to use "Admins" for join-channel) so for instance after 8229 the install chaincode step now needs the org's admin

jimthematrix (Sun, 23 Apr 2017 20:04:31 GMT):
I like how @smithbk does it with https://jira.hyperledger.org/browse/FAB-2597

jimthematrix (Sun, 23 Apr 2017 20:05:03 GMT):
pro-actively opening the corresponding SDK changes and group them all under the same task/story

jimthematrix (Sun, 23 Apr 2017 20:20:11 GMT):
I added two subtasks under fab-2969 for node and java SDK. @troyronda @grapebaba not sure if the same applies to GO and Python SDKs

troyronda (Mon, 24 Apr 2017 00:30:51 GMT):
Ok - thanks for letting me know

grapebaba (Mon, 24 Apr 2017 01:53:47 GMT):
@jimthematrix will do today

dave.enyeart (Mon, 24 Apr 2017 02:20:39 GMT):
Ready for +2s: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block https://gerrit.hyperledger.org/r/#/c/8297/ Ledger backup/restore cleanup and test

adc (Mon, 24 Apr 2017 05:09:04 GMT):
https://gerrit.hyperledger.org/r/#/c/8443/ : [FAB-3176] Fixing staticcheck errors. Please, have a look :)

jiangyaoguo (Mon, 24 Apr 2017 06:32:01 GMT):
https://gerrit.hyperledger.org/r/#/c/8413/ set chaincode version while endorsing, later we can validate version at committer

dave.enyeart (Mon, 24 Apr 2017 12:26:58 GMT):
https://gerrit.hyperledger.org/r/#/c/8317 Re-use couchDB connections - fixes system test issue and improves performance.

jiangyaoguo (Mon, 24 Apr 2017 12:56:36 GMT):
how can i re-trigger CI ? replying "reverify" didn't work.

yacovm (Mon, 24 Apr 2017 13:52:52 GMT):
https://gerrit.hyperledger.org/r/#/c/8315/ Gossip identity expiration

rameshthoomu (Mon, 24 Apr 2017 13:58:04 GMT):
@jiangyaoguo we are seeing issues in build nodes and not able to kick off new builds.. As build nodes are offline, your `reverify` triggering a build build but it's in queue..

gennadyl (Mon, 24 Apr 2017 14:02:43 GMT):
https://gerrit.hyperledger.org/r/#/c/8473/ - fix errors from staticcheck

jiangyaoguo (Mon, 24 Apr 2017 14:10:16 GMT):
@rameshthoomu thanks for your info. will wait

cbf (Mon, 24 Apr 2017 14:29:07 GMT):
@greg.haskins can you look at https://gerrit.hyperledger.org/r/#/c/7987/ @rameshthoomu addressed your issue, I believe

greg.haskins (Mon, 24 Apr 2017 14:35:12 GMT):
@cbf I still am torn on whether this is the right direction...at some point, I would like to see "fabric-peer" be a super lightweight container for running a peer instance....

greg.haskins (Mon, 24 Apr 2017 14:35:21 GMT):
I think docker makes a poor CLI experience

greg.haskins (Mon, 24 Apr 2017 14:35:28 GMT):
but that said, I understand why this is needed

greg.haskins (Mon, 24 Apr 2017 14:35:52 GMT):
so, if its a stop-gap and we can revisit our CLI deployment strategy for v1.1+, I am happy

greg.haskins (Mon, 24 Apr 2017 14:36:27 GMT):
if docker will continue to be a CLI vehicle, it should probably be something like "fabric-cli" or "fabric-tools"

greg.haskins (Mon, 24 Apr 2017 14:36:32 GMT):
and leave the poor peer alone ;)

greg.haskins (Mon, 24 Apr 2017 14:40:08 GMT):
@cbf thinking more, it would be near trivial to set the stage for this notion

greg.haskins (Mon, 24 Apr 2017 14:40:47 GMT):
we could trivially add "fabric-cli" based on baseimage (so, has golang compiler, etc) and add peer+configtxgen+cryptogen

greg.haskins (Mon, 24 Apr 2017 14:41:01 GMT):
and then someday when we unify the CLI approach, we just do it there

cbf (Mon, 24 Apr 2017 14:41:13 GMT):
I agree, and the CLI should actually be a separate thing distributed as platform-specific binary

greg.haskins (Mon, 24 Apr 2017 14:41:20 GMT):
yep

greg.haskins (Mon, 24 Apr 2017 14:41:49 GMT):
but as a stop-gap, we could do a docker image but one that is != "fabric-peer"

greg.haskins (Mon, 24 Apr 2017 14:42:11 GMT):
(one of the problems is I never intended "fabric-peer" to be used for anything other than "peer node start"

greg.haskins (Mon, 24 Apr 2017 14:42:32 GMT):
it has no golang compiler (e.g. to be useful as a "peer chaincode" environment), it doesnt have configtxgen, etc etc

greg.haskins (Mon, 24 Apr 2017 14:42:41 GMT):
(and I dont really want it to have all that

greg.haskins (Mon, 24 Apr 2017 14:43:02 GMT):
I wanted it to be a 25MB payload that ran "peer node start" really really well, and that is it

greg.haskins (Mon, 24 Apr 2017 14:44:28 GMT):
i think post v1.0, we can try to collapse "peer [chaincode/channel/node-status]", configtxgen, and cryptogen into one "fabric-cli" type binary, as you said

greg.haskins (Mon, 24 Apr 2017 14:44:46 GMT):
one that is pure go, so it can be easily built/distributed

greg.haskins (Mon, 24 Apr 2017 14:45:03 GMT):
(e.g. no CGO deps, like libltdr

cbf (Mon, 24 Apr 2017 15:27:50 GMT):
https://gerrit.hyperledger.org/r/#/c/8341/

dave.enyeart (Mon, 24 Apr 2017 19:47:38 GMT):
Looks like builds are starting to work again, got two Verified and ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block https://gerrit.hyperledger.org/r/#/c/8317/ Re-use couchDB connections - fixes system test issue and improves performance.

dave.enyeart (Mon, 24 Apr 2017 19:47:38 GMT):
Looks like builds are starting to work again, got three Verified and ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block https://gerrit.hyperledger.org/r/#/c/8317/ Re-use couchDB connections - fixes system test issue and improves performance. https://gerrit.hyperledger.org/r/#/c/8213/ Re-enable error test

yacovm (Mon, 24 Apr 2017 21:01:43 GMT):
* This is the change set scores of you have been waiting for *: https://gerrit.hyperledger.org/r/#/c/8439/ This change set silences gossip's logging and makes it be WARNING instead of DEBUG even when all the other log modules are in DEBUG. (thanks @wlahti

yacovm (Mon, 24 Apr 2017 21:02:22 GMT):
*This is the change set many of you have been waiting for* : https://gerrit.hyperledger.org/r/#/c/8439 This change set silences gossip's logging and makes it be WARNING instead of DEBUG even when all the other log modules are in DEBUG. (thanks @wlahti)

yacovm (Mon, 24 Apr 2017 21:03:22 GMT):
I cannot +2 it because I have added a line there though

jimthematrix (Tue, 25 Apr 2017 03:05:51 GMT):
https://gerrit.hyperledger.org/r/#/c/8499/ - fixes node SDK CI job failures by using "peerOrgAdmin" user for: install chaincode, query installed chaincode and query instantiated chaincode. @mastersingh24 @cbf @yacovm @bretharrison

bretharrison (Tue, 25 Apr 2017 03:05:51 GMT):
Has joined the channel.

muralisr (Tue, 25 Apr 2017 04:55:33 GMT):
@yacovm e2e CLI did not pass (I think) https://gerrit.hyperledger.org/r/#/c/8439... did a -1 for checking on that

ynamiki (Tue, 25 Apr 2017 05:11:56 GMT):
Has joined the channel.

ynamiki (Tue, 25 Apr 2017 05:21:05 GMT):
Has left the channel.

yacovm (Tue, 25 Apr 2017 05:33:25 GMT):
But i checked locally... Can you do so too?

yacovm (Tue, 25 Apr 2017 05:48:31 GMT):
@muralisr

muralisr (Tue, 25 Apr 2017 05:48:46 GMT):
ok. If you pulled that version and checked that's enough... can you add that comment there ?

muralisr (Tue, 25 Apr 2017 05:48:46 GMT):
ok. If you pulled that version and checked that's enough... can you add that comment there @yacovm ?

muralisr (Tue, 25 Apr 2017 05:49:13 GMT):
still I wonder why the e2e CLI did not pass

yacovm (Tue, 25 Apr 2017 05:54:03 GMT):
Because the cli container wasnt able to start

yacovm (Tue, 25 Apr 2017 05:54:09 GMT):
Or something

yacovm (Tue, 25 Apr 2017 08:04:47 GMT):
@muralisr when I did `reverify` it passed e2e in CI

muralisr (Tue, 25 Apr 2017 08:05:25 GMT):
thanks @yacovm I reviewed the code.. let me take a peek and +2

muralisr (Tue, 25 Apr 2017 08:06:00 GMT):
(will wait for CI to go thru)

gennadyl (Tue, 25 Apr 2017 08:06:08 GMT):
https://gerrit.hyperledger.org/r/#/c/8473/ - have one +2, need another one

yacovm (Tue, 25 Apr 2017 08:06:18 GMT):
But @muralisr the CI passed ;)

yacovm (Tue, 25 Apr 2017 08:06:21 GMT):
I just did a reverify

yacovm (Tue, 25 Apr 2017 08:06:28 GMT):
so the code hasn't changed

muralisr (Tue, 25 Apr 2017 08:07:08 GMT):
well.. if the V+1 fails, no point in +2ing is there ? :-)

yacovm (Tue, 25 Apr 2017 08:08:35 GMT):
of course there is

yacovm (Tue, 25 Apr 2017 08:08:40 GMT):
the CI did +1

yacovm (Tue, 25 Apr 2017 08:08:49 GMT):
and then I did a reverify

yacovm (Tue, 25 Apr 2017 08:08:52 GMT):
so the code hasn't changed

yacovm (Tue, 25 Apr 2017 08:09:36 GMT):
but ok

yacovm (Tue, 25 Apr 2017 08:09:47 GMT):
I have faith in this round

yacovm (Tue, 25 Apr 2017 08:10:02 GMT):
so will wait ;)

dave.enyeart (Tue, 25 Apr 2017 10:36:34 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block https://gerrit.hyperledger.org/r/#/c/8297/ Backup/Restore ledger tests https://gerrit.hyperledger.org/r/#/c/8317/ Re-use couchDB connections - fixes system test issue and improves performance. https://gerrit.hyperledger.org/r/#/c/8213/ Re-enable error test

dave.enyeart (Tue, 25 Apr 2017 10:36:34 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block https://gerrit.hyperledger.org/r/#/c/8297/ Backup/Restore ledger tests https://gerrit.hyperledger.org/r/#/c/7255/ Re-enable paging of chaincode results https://gerrit.hyperledger.org/r/#/c/8317/ Re-use couchDB connections - fixes system test issue and improves performance. https://gerrit.hyperledger.org/r/#/c/8213/ Re-enable error test

dave.enyeart (Tue, 25 Apr 2017 10:36:34 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block https://gerrit.hyperledger.org/r/#/c/8297/ Backup/Restore ledger tests https://gerrit.hyperledger.org/r/#/c/7255/ Re-enable paging of chaincode results https://gerrit.hyperledger.org/r/#/c/8317/ Re-use couchDB connections - fixes system test issue and improves performance. https://gerrit.hyperledger.org/r/#/c/8213/ Re-enable error test https://gerrit.hyperledger.org/r/#/c/8211/ Cleanup TODO

dave.enyeart (Tue, 25 Apr 2017 10:36:34 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block https://gerrit.hyperledger.org/r/#/c/8297/ Backup/Restore ledger tests https://gerrit.hyperledger.org/r/#/c/7255/ Re-enable paging of chaincode results https://gerrit.hyperledger.org/r/#/c/8213/ Re-enable error test https://gerrit.hyperledger.org/r/#/c/8211/ Cleanup TODO

dave.enyeart (Tue, 25 Apr 2017 10:36:34 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block TOP PRIORITY... HAVE HAD TO REBASE MANY TIMES ALREADY https://gerrit.hyperledger.org/r/#/c/8297/ Backup/Restore ledger tests https://gerrit.hyperledger.org/r/#/c/7255/ Re-enable paging of chaincode results https://gerrit.hyperledger.org/r/#/c/8213/ Re-enable error test https://gerrit.hyperledger.org/r/#/c/8211/ Cleanup TODO

dave.enyeart (Tue, 25 Apr 2017 10:36:34 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/7929/ Create ledger must include genesis block *TOP PRIORITY... HAVE HAD TO REBASE MANY TIMES ALREADY* https://gerrit.hyperledger.org/r/#/c/8297/ Backup/Restore ledger tests https://gerrit.hyperledger.org/r/#/c/7255/ Re-enable paging of chaincode results https://gerrit.hyperledger.org/r/#/c/8213/ Re-enable error test https://gerrit.hyperledger.org/r/#/c/8211/ Cleanup TODO

dave.enyeart (Tue, 25 Apr 2017 10:36:34 GMT):
Ready for +2 reviews: https://gerrit.hyperledger.org/r/#/c/8211/ Cleanup TODO

yacovm (Tue, 25 Apr 2017 12:43:13 GMT):
This change set re-introduces a test back to CI (was disabled) https://gerrit.hyperledger.org/r/#/c/8467/

yacovm (Tue, 25 Apr 2017 12:43:13 GMT):
This change set re-introduces a test back to CI (was disabled) https://gerrit.hyperledger.org/r/#/c/8467/ Missing 1 +2 to be merged

elli-androulaki (Tue, 25 Apr 2017 16:52:00 GMT):
https://gerrit.hyperledger.org/r/#/c/8141 is again to be reviewed succeeded!!

elli-androulaki (Tue, 25 Apr 2017 16:52:00 GMT):
https://gerrit.hyperledger.org/r/#/c/8141 is again ready to be reviewed!!

elli-androulaki (Tue, 25 Apr 2017 16:52:00 GMT):
https://gerrit.hyperledger.org/r/#/c/8141 is again ready to be reviewed!! (Instantiation policy evaluation on the endorser side; was already reviewed by @muralisr, @binhn , and @mastersingh24 )

mastersingh24 (Tue, 25 Apr 2017 17:46:07 GMT):
@cbf @JonathanLevi https://gerrit.hyperledger.org/r/#/c/7713/

mastersingh24 (Tue, 25 Apr 2017 17:46:07 GMT):
@cbf @JonathanLevi https://gerrit.hyperledger.org/r/#/c/7713/ (so we can merge the new CA structs)

mastersingh24 (Tue, 25 Apr 2017 18:17:13 GMT):
https://gerrit.hyperledger.org/r/#/c/7941/

elli-androulaki (Tue, 25 Apr 2017 18:37:46 GMT):
Thanks for the reviews for 8141 @mastersingh24 !

elli-androulaki (Tue, 25 Apr 2017 18:38:42 GMT):
This one (based on 8141) is also ready for reviews https://gerrit.hyperledger.org/r/#/c/8253! @yacovm has already reviewed it, as well as @muralisr in the past.

jimthematrix (Tue, 25 Apr 2017 18:57:16 GMT):
https://gerrit.hyperledger.org/r/#/c/8499/ - fixes node SDK build breaks (from enhanced ACL checks on various peer-based requests: install chaincode, etc.), @mastersingh24 @yacovm @cbf

yacovm (Tue, 25 Apr 2017 19:04:48 GMT):
@jimthematrix I think the code makes sense, I just think that the commit message is a bit misleading

yacovm (Tue, 25 Apr 2017 19:07:49 GMT):
https://gerrit.hyperledger.org/r/#/c/8315/ Making identities expire in gossip

yacovm (Tue, 25 Apr 2017 19:07:49 GMT):
https://gerrit.hyperledger.org/r/#/c/8315/ Making identities expire in gossip (this isn't new, it's from last week...)

jimthematrix (Tue, 25 Apr 2017 19:08:42 GMT):
@yacovm mea culpa, submitted two separate JIRAs but decided to use the same CR to fix both ;-)

yacovm (Tue, 25 Apr 2017 19:09:12 GMT):
yeah but why does the title imply that you added an e2e test?

yacovm (Tue, 25 Apr 2017 19:09:31 GMT):
You fixed the credentials

jimthematrix (Tue, 25 Apr 2017 19:10:08 GMT):
it meant to say "e2e test to install chaincode as admin *instead of member*"

jimthematrix (Tue, 25 Apr 2017 19:10:17 GMT):
but the title can't be that long

yacovm (Tue, 25 Apr 2017 19:10:44 GMT):
I think "Fix credentials in e2e test" should do it ;)

yacovm (Tue, 25 Apr 2017 19:11:17 GMT):
Since that's the common thing

jimthematrix (Tue, 25 Apr 2017 19:13:33 GMT):
fair enough, just fixed it and re-building, thanks for the suggestion

aambati (Wed, 26 Apr 2017 04:11:56 GMT):
@binhn @smithbk i have resolved the conflicts, please +1 the change set https://gerrit.hyperledger.org/r/#/c/8099/ again

harsha (Wed, 26 Apr 2017 04:13:54 GMT):
Can someone help review this https://gerrit.hyperledger.org/r/#/c/7887/9

harsha (Wed, 26 Apr 2017 04:13:54 GMT):
Can someone kindly help review this https://gerrit.hyperledger.org/r/#/c/7887/9 , thank you !!

jiangyaoguo (Wed, 26 Apr 2017 06:20:44 GMT):
https://gerrit.hyperledger.org/r/#/c/8413/ need another +2 or comments. thanks

aso (Wed, 26 Apr 2017 08:44:11 GMT):
I need a second +2 on https://gerrit.hyperledger.org/r/#/c/8253/ please

aso (Wed, 26 Apr 2017 08:44:26 GMT):
it's been out for a week and we need it in asap. Thx!

adc (Wed, 26 Apr 2017 09:25:51 GMT):
Hi All, some love for https://gerrit.hyperledger.org/r/#/c/8463/, please :)

adc (Wed, 26 Apr 2017 10:59:09 GMT):
please, also this: https://gerrit.hyperledger.org/r/#/c/8443/ :)

muralisr (Wed, 26 Apr 2017 12:14:57 GMT):
@adc done for the above

muralisr (Wed, 26 Apr 2017 12:15:41 GMT):
a simple CR to increase test coverage for platforms/golang https://gerrit.hyperledger.org/r/#/c/8537/ please

adc (Wed, 26 Apr 2017 12:17:59 GMT):
thanks a lot for the love given to those CRs :)

adc (Wed, 26 Apr 2017 12:18:05 GMT):
now, it is time for this one: https://gerrit.hyperledger.org/r/#/c/8531/

adc (Wed, 26 Apr 2017 12:18:14 GMT):
:)

muralisr (Wed, 26 Apr 2017 13:35:25 GMT):
@greg.haskins can you take a peek at https://gerrit.hyperledger.org/r/#/c/8537/ when you have time please ? i think this overlaps a bit with your https://gerrit.hyperledger.org/r/#/c/6991/

adc (Wed, 26 Apr 2017 13:43:08 GMT):
Hi All, another change-set easy to review for you: https://gerrit.hyperledger.org/r/#/c/8539/ :)

rameshthoomu (Wed, 26 Apr 2017 14:02:34 GMT):
@jimthematrix trivial patch to fix node sdk documentation build issue https://jira.hyperledger.org/browse/FAB-3379

rameshthoomu (Wed, 26 Apr 2017 14:02:34 GMT):
@jimthematrix trivial patch to fix node sdk documentation build issuehttps://gerrit.hyperledger.org/r/#/c/8481/

rameshthoomu (Wed, 26 Apr 2017 14:02:34 GMT):
@jimthematrix trivial patch to fix node sdk documentation build issue https://gerrit.hyperledger.org/r/#/c/8481/

jimthematrix (Wed, 26 Apr 2017 14:04:12 GMT):
Ramesh I actually reviewed it yesterday but had a question about the purpose of mkdocs.yaml, how is that used?

rameshthoomu (Wed, 26 Apr 2017 14:05:03 GMT):
mkdocs.yaml (which supports markdown files) is a configuration file for readthedocs

rameshthoomu (Wed, 26 Apr 2017 14:05:57 GMT):
pls see output of node sdk markdown documents here http://fabric-sdk-node.readthedocs.io/en/master/

mastersingh24 (Wed, 26 Apr 2017 14:36:02 GMT):
https://gerrit.hyperledger.org/r/#/c/7789/

mastersingh24 (Wed, 26 Apr 2017 14:37:41 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/8221/

jimthematrix (Wed, 26 Apr 2017 14:49:14 GMT):
@rameshthoomu ok got it. thanks

rameshthoomu (Wed, 26 Apr 2017 14:54:22 GMT):
ok Thanks @jimthematrix .. I see fabric-sdk-node documentation builds are passing now..

nickgaski (Wed, 26 Apr 2017 15:31:36 GMT):
https://gerrit.hyperledger.org/r/#/c/8513/ - new getting started material with some comments from Kostas incorporated

yacovm (Wed, 26 Apr 2017 17:10:04 GMT):
Can anyone please CR https://gerrit.hyperledger.org/r/#/c/8315/ ? It's been stuck there since last week and it's not that scary

yacovm (Wed, 26 Apr 2017 17:10:04 GMT):
Can anyone please CR https://gerrit.hyperledger.org/r/#/c/8315/ ? It's been stuck there since last week and it's not that scary, most of the lines are just a refactor of a test

wlahti (Wed, 26 Apr 2017 18:07:09 GMT):
Easy change to switch a few fmt.Print calls in peer start to use the logger instead: https://gerrit.hyperledger.org/r/#/c/8147/

nickgaski (Wed, 26 Apr 2017 20:50:45 GMT):
https://gerrit.hyperledger.org/r/#/c/8591/ - this was a stupid mistake I made. Nothing to this PR.

rameshthoomu (Wed, 26 Apr 2017 23:19:58 GMT):
@binhn could you please review this https://gerrit.hyperledger.org/r/#/c/8585/

greg.haskins (Thu, 27 Apr 2017 01:12:42 GMT):
a few easy ones: https://gerrit.hyperledger.org/r/#/c/8577/ https://gerrit.hyperledger.org/r/#/c/8579/

greg.haskins (Thu, 27 Apr 2017 02:52:23 GMT):
just need one more +2 here: https://gerrit.hyperledger.org/r/#/c/8589/

muralisr (Thu, 27 Apr 2017 03:32:21 GMT):
^^^ done @greg.haskins

adc (Thu, 27 Apr 2017 09:06:26 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/8539/ :)

cbf (Thu, 27 Apr 2017 13:33:03 GMT):
https://gerrit.hyperledger.org/r/#/c/8307/

nickgaski (Thu, 27 Apr 2017 13:47:42 GMT):
can we get this merged - https://gerrit.hyperledger.org/r/#/c/8591/ . It's really nothing, just a small formatting tweak to a code block; looks kinda silly right now

yacovm (Thu, 27 Apr 2017 14:59:22 GMT):
test `core/common/validation/fullflow_test` is broken due to compilation errors and https://gerrit.hyperledger.org/r/#/c/8659 fixes this (thanks @aso !) CI cannot give +1, I have pulled this and checked that it indeed fixes the latest master I suggest we manually verify it and merge to fix the master branch @cbf @mastersingh24

yacovm (Thu, 27 Apr 2017 14:59:22 GMT):
test `core/common/validation/fullflow_test` is broken due to compilation errors and https://gerrit.hyperledger.org/r/#/c/8659 fixes this (thanks @aso !) CI cannot give +1, I have pulled this and checked that it indeed fixes the latest master (well- at least the test...) I suggest we manually verify it and merge to fix the master branch @cbf @mastersingh24 @muralisr @JonathanCohen

cbf (Thu, 27 Apr 2017 15:08:31 GMT):
https://gerrit.hyperledger.org/r/#/c/7887/

muralisr (Thu, 27 Apr 2017 15:11:30 GMT):
@yacovm @aso this appears to be one of those infrequent dependency from CR merges

muralisr (Thu, 27 Apr 2017 15:12:02 GMT):
+1 for manual V+1

binhn (Thu, 27 Apr 2017 20:21:05 GMT):
@rameshthoomu the cr https://gerrit.hyperledger.org/r/#/c/8585 stuck on ci since yesterday

rameshthoomu (Thu, 27 Apr 2017 20:29:00 GMT):
@binhn we had issues in Jenkins.. We re-triggered this patch and it failed in gossip tests..

rameshthoomu (Thu, 27 Apr 2017 20:29:44 GMT):
you can see the code coverage report output of patch 1 here https://jenkins.hyperledger.org/job/fabric-verify-x86_64/10614/cobertura/

baohua (Fri, 28 Apr 2017 03:39:13 GMT):
pls help review, thanks! https://github.com/hyperledger/cello/blob/master/docs/CONTRIBUTING.md

baohua (Fri, 28 Apr 2017 03:39:13 GMT):
pls help review, thanks! https://gerrit.hyperledger.org/r/#/c/8535/

jiangyaoguo (Fri, 28 Apr 2017 03:41:09 GMT):
need one more +2 for https://gerrit.hyperledger.org/r/#/c/8465/ ,:slight_smile:

adc (Fri, 28 Apr 2017 05:15:44 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/8547/, thanks :)

adc (Fri, 28 Apr 2017 05:16:43 GMT):
these are all about test coverage: https://gerrit.hyperledger.org/r/#/c/8627/ https://gerrit.hyperledger.org/r/#/c/8629/ https://gerrit.hyperledger.org/r/#/c/8631/. Please, have a look :)

wsh_bob (Fri, 28 Apr 2017 08:10:37 GMT):
Has joined the channel.

yacovm (Fri, 28 Apr 2017 10:21:13 GMT):
Improvement of gossip code coverage code... just tests, safe to merge https://gerrit.hyperledger.org/r/#/c/8663/

aietcn (Fri, 28 Apr 2017 11:13:00 GMT):
Has joined the channel.

greg.haskins (Fri, 28 Apr 2017 11:43:21 GMT):
This stack is ready to go: https://gerrit.hyperledger.org/r/#/c/8605/

greg.haskins (Fri, 28 Apr 2017 11:43:41 GMT):
note to final committer: 8605+8603 must merge together

adc (Fri, 28 Apr 2017 12:01:38 GMT):
Hi All, improved test-coverage: https://gerrit.hyperledger.org/r/#/c/8627/ https://gerrit.hyperledger.org/r/#/c/8653/ Thanks :)

adc (Fri, 28 Apr 2017 12:01:38 GMT):
Hi All, improved test-coverage: https://gerrit.hyperledger.org/r/#/c/8627/, https://gerrit.hyperledger.org/r/#/c/8629/, https://gerrit.hyperledger.org/r/#/c/8653/ Thanks :)

yacovm (Fri, 28 Apr 2017 12:50:43 GMT):
@adc i left you a comment in https://gerrit.hyperledger.org/r/#/c/8629/

adc (Fri, 28 Apr 2017 12:51:17 GMT):
sorry, I missed them. Will do

wlahti (Fri, 28 Apr 2017 13:22:23 GMT):
Improved test coverage for peer/clilogging: https://gerrit.hyperledger.org/r/#/c/8691/. Up to 66% from 25%. Still some work remaining to mock a few more things which will allow us to improve coverage for this and the rest of the peer CLI packages.

nickgaski (Fri, 28 Apr 2017 14:13:21 GMT):
https://gerrit.hyperledger.org/r/#/c/8591/ - these are some minor updates to getting started, along with a disclaimer stating that our instructions will only work against alpha images and the packaged binaries. Please merge ASAP as we are seeing repeated errors from people who have compiled the binaries from master and then see configuration errors when they try to run the configtxgen tool

adc (Fri, 28 Apr 2017 15:58:51 GMT):
Hi All, please have a look at this: https://gerrit.hyperledger.org/r/#/c/8653/. Thanks :)

nickgaski (Fri, 28 Apr 2017 17:54:19 GMT):
https://gerrit.hyperledger.org/r/#/c/8729/ - this fixes the environment variable that is causing the config error. It accompanies the above CR - 8591

smithbk (Fri, 28 Apr 2017 19:09:03 GMT):
https://gerrit.hyperledger.org/r/#/c/7471/ - for fabric-ca TLS support to LDAP server - needs one more +2 ... thanks

smithbk (Fri, 28 Apr 2017 19:10:17 GMT):
https://gerrit.hyperledger.org/r/#/c/8735/ - small change that fixes a bug folks will likely hit soon

rameshthoomu (Fri, 28 Apr 2017 19:18:49 GMT):
@binhn here is the final output on patch https://gerrit.hyperledger.org/r/#/c/8585/ === Coverage report https://jenkins.hyperledger.org/job/fabric-verify-x86_64/10801/cobertura/

greg.haskins (Sat, 29 Apr 2017 00:01:41 GMT):
very easy stack all ready to go: https://gerrit.hyperledger.org/r/#/c/8605/

binhn (Sat, 29 Apr 2017 00:33:24 GMT):
need 1 more +2 on @greg.haskins' stack ^^ please

adc (Sat, 29 Apr 2017 04:36:49 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/8629/, https://gerrit.hyperledger.org/r/#/c/8701/, https://gerrit.hyperledger.org/r/#/c/8707/. It is about test coverage :)

adc (Sat, 29 Apr 2017 11:03:53 GMT):
Hi All, time to merge https://gerrit.hyperledger.org/r/#/c/8531/ :)

adc (Sat, 29 Apr 2017 11:03:53 GMT):
Hi All, time to merge https://gerrit.hyperledger.org/r/#/c/8531/. It is waiting your love :)

smithbk (Sat, 29 Apr 2017 12:36:21 GMT):
https://gerrit.hyperledger.org/r/#/c/8755/ - this fixes a build error in fabric-ca-server ... very small change, and btw, investigating why CI passed

jimthematrix (Sat, 29 Apr 2017 23:30:45 GMT):
+2'ed

jimthematrix (Sat, 29 Apr 2017 23:31:38 GMT):
@binhn @yacovm @mastersingh24 @greg.haskins if you guys are online, please give the above 8755 another +2 and merge, it's currently breaking node and Java SDK builds

jimthematrix (Sat, 29 Apr 2017 23:32:02 GMT):
thanks Keith for fixing it

muralisr (Sun, 30 Apr 2017 03:26:21 GMT):
@jimthematrix merged 8755

adc (Sun, 30 Apr 2017 10:12:15 GMT):
Hi @JonathanLevi, I have updated https://gerrit.hyperledger.org/r/#/c/8701/ as you requested, hopefully. Thanks for the feedback.

mastersingh24 (Sun, 30 Apr 2017 14:51:08 GMT):
@C0rWin @yacovm - https://gerrit.hyperledger.org/r/#/c/8777/ (has not passed CI but if you could review that would be great)

C0rWin (Sun, 30 Apr 2017 14:55:53 GMT):
[ ] (https://chat.hyperledger.org/channel/fabric-pr-review?msg=tvif9uLDXWh45sHxF) @mastersingh24 sure

yacovm (Sun, 30 Apr 2017 16:58:41 GMT):
Gossip bug fix - https://gerrit.hyperledger.org/r/#/c/8647/ Already got 1 +2

mastersingh24 (Sun, 30 Apr 2017 17:47:57 GMT):
[done ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=c2K5juFYbmm7pY5Hu) @yacovm

mastersingh24 (Sun, 30 Apr 2017 21:34:53 GMT):
pretty easy one for gossip: https://gerrit.hyperledger.org/r/#/c/8765/

C0rWin (Sun, 30 Apr 2017 23:29:29 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=x7Pbb8njXqSrQ6yzh) @mastersingh24 merged.

JonathanLevi (Mon, 01 May 2017 04:12:01 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=FtoBt2nw2sjSbYCJ8) Yes, we had a few sessions last week and we decided to tighten up the screws a bit more regarding the JIRA tickets, tests, docs, etc. for 1.0.... hence my review of https://gerrit.hyperledger.org/r/#/c/8701... thanks for the quick turn-around time. Merged.

JonathanLevi (Mon, 01 May 2017 04:12:01 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=FtoBt2nw2sjSbYCJ8) Yes, we had a few sessions discussing the road to 1.0 last week and we decided to tighten up the screws a bit more regarding the JIRA tickets, tests, docs, etc. (esp. for 1.0).... hence my review of https://gerrit.hyperledger.org/r/#/c/8701... thanks for the quick turn-around time. Merged.

adc (Mon, 01 May 2017 13:46:20 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/8707/. It is about test-coverage for BCCSP. Thanks :)

yacovm (Mon, 01 May 2017 13:55:42 GMT):
The last code coverage change set for gossip https://gerrit.hyperledger.org/r/#/c/8773/

wlahti (Mon, 01 May 2017 15:12:53 GMT):
Improved unit test coverage (and some refactoring) for peer/clilogging: https://gerrit.hyperledger.org/r/#/c/8691/

greg.haskins (Mon, 01 May 2017 15:57:53 GMT):
just need a final sweep of +2s for 8693/8699/8741 pls: https://gerrit.hyperledger.org/r/#/c/8741/

binhn (Mon, 01 May 2017 16:49:21 GMT):
@greg.haskins done

greg.haskins (Mon, 01 May 2017 16:49:28 GMT):
@binhn ty

latitiah (Mon, 01 May 2017 18:19:14 GMT):
Can I get some +2 actions on these: https://gerrit.hyperledger.org/r/#/c/8265/ (has a +1); https://gerrit.hyperledger.org/r/#/c/8329/ (has a +1 and +2 - just needs 1 more); https://gerrit.hyperledger.org/r/#/c/8739/ (has 2 +1s); https://gerrit.hyperledger.org/r/#/c/8783/ (needs review)

latitiah (Mon, 01 May 2017 18:19:20 GMT):
Thx!

nickgaski (Mon, 01 May 2017 19:45:21 GMT):
https://gerrit.hyperledger.org/r/#/c/8591/ - This is another attempt to fix getting started ...

nickgaski (Mon, 01 May 2017 21:33:54 GMT):
We are seeing people constantly hit this FABRIC_CFG_PATH error and the current URL does NOT work. Please merge :(

nickgaski (Mon, 01 May 2017 21:33:54 GMT):
We are seeing people constantly hit this FABRIC_CFG_PATH error and the current URL does NOT work. Please merge :( ^^^^

cbf (Mon, 01 May 2017 23:24:28 GMT):
simple one https://gerrit.hyperledger.org/r/#/c/8745/

JonathanLevi (Tue, 02 May 2017 00:59:09 GMT):
Merged.

jiangyaoguo (Tue, 02 May 2017 01:27:38 GMT):
https://gerrit.hyperledger.org/r/#/c/8711/ need some love. A easy parameter replace. one +2 already.

muralisr (Tue, 02 May 2017 02:18:48 GMT):
@jiangyaoguo would you mind waiting for https://gerrit.hyperledger.org/r/#/c/8509/ ? We had held that up for the upgrade tasks to go in ... now its our turn

muralisr (Tue, 02 May 2017 02:19:04 GMT):
hopefully it won't mess with your CR too much

jiangyaoguo (Tue, 02 May 2017 02:20:07 GMT):
@muralisr OK

muralisr (Tue, 02 May 2017 02:20:25 GMT):
also do take a peek at https://gerrit.hyperledger.org/r/#/c/8509/ if you can

muralisr (Tue, 02 May 2017 02:21:14 GMT):
it undoes the VSCCOutData - as we are not yet ready for data from multiple chaincodes in a CC-2-CC scenario

muralisr (Tue, 02 May 2017 02:21:43 GMT):
but keeps the version check logic itself in tact

jimthematrix (Tue, 02 May 2017 04:32:59 GMT):
https://gerrit.hyperledger.org/r/#/c/8823 - critical fix to build breaks in node SDK, @mastersingh24 @yacovm @smithbk @binhn

jimthematrix (Tue, 02 May 2017 12:03:46 GMT):
@yacovm thanks for the review, your comments have been addressed and re-building now

yacovm (Tue, 02 May 2017 12:37:50 GMT):
An easy merge https://gerrit.hyperledger.org/r/#/c/8831/ - need just 1 +2

muralisr (Tue, 02 May 2017 13:32:43 GMT):
done @yacovm

binhn (Tue, 02 May 2017 13:53:41 GMT):
i defined some error codes https://gerrit.hyperledger.org/r/#/c/8821/

Nishi (Tue, 02 May 2017 14:32:04 GMT):
Can I get some votes on patchset: https://gerrit.hyperledger.org/r/#/c/8669/. Thanks!

wlahti (Tue, 02 May 2017 16:15:23 GMT):
Fixes/improves the chaincode container logging to allow an overall default log level as well as a shim log level override: https://gerrit.hyperledger.org/r/#/c/8807/

wlahti (Tue, 02 May 2017 16:15:23 GMT):
Fixes/improves chaincode container logging to allow an overall default log level as well as a shim log level override: https://gerrit.hyperledger.org/r/#/c/8807/

wlahti (Tue, 02 May 2017 16:16:23 GMT):
Unit test coverage and a little refactoring: https://gerrit.hyperledger.org/r/#/c/8691/

mastersingh24 (Tue, 02 May 2017 17:10:12 GMT):
easy one please: https://gerrit.hyperledger.org/r/8819

nickgaski (Tue, 02 May 2017 17:56:56 GMT):
@here - https://gerrit.hyperledger.org/r/#/c/8591/5 - This HAS to get merged. The instructions are broken right now and folks can't get going. I know there are different opinions on how to retrieve the artifacts, where to host them, etc... Can we please decide on that when we cut our final iteration of getting started.

AbhilekhSingh (Tue, 02 May 2017 18:57:02 GMT):
Has joined the channel.

mastersingh24 (Tue, 02 May 2017 20:38:02 GMT):
https://gerrit.hyperledger.org/r/#/c/8819/ is still looking for just a little more love here. It is also open to a hateful merge as well ;)

nickgaski (Wed, 03 May 2017 01:38:35 GMT):
can I trouble someone for one more +2 on 8591

JonathanLevi (Wed, 03 May 2017 08:09:06 GMT):
@nickgaski: done. Thank you @kostas

yacovm (Wed, 03 May 2017 08:24:45 GMT):
3 Easy change sets: https://gerrit.hyperledger.org/r/#/c/8855/ - just fixed a logging statement (misleading sentence) https://gerrit.hyperledger.org/r/#/c/8857/ - Added nil check https://gerrit.hyperledger.org/r/#/c/8869/ - This one is important for serviceability - removes non-text characters from our logs

baohua (Wed, 03 May 2017 09:05:07 GMT):
Some doc patchset, should be easy to confirm :) https://gerrit.hyperledger.org/r/#/c/8867/, https://gerrit.hyperledger.org/r/8871

yacovm (Wed, 03 May 2017 10:28:08 GMT):
@baohua gave you a comment on the first

baohua (Wed, 03 May 2017 12:29:31 GMT):
thanks, will update

adc (Wed, 03 May 2017 13:36:24 GMT):
Please, some love to https://gerrit.hyperledger.org/r/#/c/8787/ :)

smithbk (Wed, 03 May 2017 17:49:07 GMT):
Pls review https://gerrit.hyperledger.org/r/#/c/8853/ ... thanks

mastersingh24 (Thu, 04 May 2017 12:24:40 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/8949/

C0rWin (Thu, 04 May 2017 12:59:44 GMT):
another easy one: https://gerrit.hyperledger.org/r/#/c/8911/, already has one +2.

wlahti (Thu, 04 May 2017 13:43:16 GMT):
Small update to improve a few messages related to the peer logging CLI: https://gerrit.hyperledger.org/r/#/c/8893/ Fix logging for chaincode container to allow log level to be set for modules other than 'shim' and control the 'shim' level separately: https://gerrit.hyperledger.org/r/#/c/8807/

baohua (Thu, 04 May 2017 14:07:12 GMT):
This patchset adds more strict checking on the code format, which help improve code quality for 1.0 release. Welcome for review: https://gerrit.hyperledger.org/r/8861, thanks!

smithbk (Thu, 04 May 2017 15:44:04 GMT):
Pls review 3 change sets for fabric-ca related to multi CA config [FAB-3574]

smithbk (Thu, 04 May 2017 15:44:08 GMT):
https://gerrit.hyperledger.org/r/#/c/8853 - deep copy config https://gerrit.hyperledger.org/r/#/c/8909 - fix missing CA values logic https://gerrit.hyperledger.org/r/#/c/8944 - Finish fix of multi CA config

smithbk (Thu, 04 May 2017 15:46:34 GMT):
And 2 other very simple ones:

smithbk (Thu, 04 May 2017 15:46:36 GMT):
https://gerrit.hyperledger.org/r/#/c/8803 - document serial number of CSR https://gerrit.hyperledger.org/r/#/c/8959 - log to stdout

greg.haskins (Thu, 04 May 2017 16:40:29 GMT):
simple one: https://gerrit.hyperledger.org/r/#/c/8915/

greg.haskins (Thu, 04 May 2017 16:57:29 GMT):
removed WIP tag: ready for consideration: https://gerrit.hyperledger.org/r/#/c/8579/

greg.haskins (Thu, 04 May 2017 16:57:57 GMT):
@cbf @muralisr @yacovm note ^^^^

greg.haskins (Thu, 04 May 2017 16:58:11 GMT):
@mastersingh24 as well ^^^

greg.haskins (Thu, 04 May 2017 16:59:23 GMT):
its completely standalone, and therefore zero risk to codebase stability...its more of a question of "does this add value to using/understanding the system, or does it add a potentially confusing example"

yacovm (Thu, 04 May 2017 16:59:58 GMT):
@greg.haskins can you rebase?

greg.haskins (Thu, 04 May 2017 17:00:05 GMT):
it should be on latest

greg.haskins (Thu, 04 May 2017 17:00:07 GMT):
no?

greg.haskins (Thu, 04 May 2017 17:00:33 GMT):
@yacovm wait, which CR?

yacovm (Thu, 04 May 2017 17:00:49 GMT):
nevermind, the git log shows what I was looking for

yacovm (Thu, 04 May 2017 17:00:56 GMT):
the cluster

cbf (Thu, 04 May 2017 18:18:17 GMT):
@greg.haskins yes, I am trying to build now

greg.haskins (Thu, 04 May 2017 18:35:27 GMT):
@cbf let me know if it still doesnt run for you

cbf (Thu, 04 May 2017 18:54:33 GMT):
https://gerrit.hyperledger.org/r/#/c/8579/15

cbf (Thu, 04 May 2017 18:54:45 GMT):
also see my gist in the review comment

cbf (Thu, 04 May 2017 18:54:57 GMT):
@greg.haskins ^^

greg.haskins (Thu, 04 May 2017 18:55:43 GMT):
hmm, thats weird

greg.haskins (Thu, 04 May 2017 18:55:54 GMT):
ill look at the gist

greg.haskins (Thu, 04 May 2017 18:57:02 GMT):
@cbf what happens when you do "make clean compose-up" ?

cbf (Thu, 04 May 2017 18:57:41 GMT):
trying

cbf (Thu, 04 May 2017 18:58:27 GMT):
that worked

cbf (Thu, 04 May 2017 18:58:36 GMT):
cool

cbf (Thu, 04 May 2017 18:58:46 GMT):
so just need to fix the target to build configtxgen

cbf (Thu, 04 May 2017 18:59:17 GMT):
@greg.haskins ^^

greg.haskins (Thu, 04 May 2017 19:00:16 GMT):
i just dont get why its needed there, i need to study the dep graph

greg.haskins (Thu, 04 May 2017 19:02:44 GMT):
@cbf the part confusing me is that the only three targets that invoke configtxgen do seem to have it as a dep

greg.haskins (Thu, 04 May 2017 19:03:25 GMT):
im wondering if there was some cruft in your ./build dir that was confusing the build-graph

greg.haskins (Thu, 04 May 2017 19:03:39 GMT):
can you try reverting that change, and doing the "make clean" and then see if it all works?

cbf (Thu, 04 May 2017 19:26:19 GMT):
sure

cbf (Thu, 04 May 2017 19:32:47 GMT):
@greg.haskins changed my vote - looks good

greg.haskins (Thu, 04 May 2017 19:33:33 GMT):
ty

greg.haskins (Thu, 04 May 2017 19:34:02 GMT):
theres probably some subtle issue w.r.t. the old state you had, but we can refine it as we move forward

greg.haskins (Thu, 04 May 2017 19:35:18 GMT):
I have an update that improves the success reporting/output at the end, as follows:

greg.haskins (Thu, 04 May 2017 19:35:21 GMT):
```======================================================================== Cluster ready! ======================================================================== 172.18.0.2 ca 172.18.0.3 orderer 172.18.0.4 peer1 172.18.0.5 peer3 172.18.0.6 peer2 172.18.0.7 peer4```

greg.haskins (Thu, 04 May 2017 19:35:44 GMT):
if I push, it will wipe out your vote..should I push that or wait?

yacovm (Thu, 04 May 2017 19:35:54 GMT):
too late

cbf (Thu, 04 May 2017 19:35:56 GMT):
yacov merged it;-_

greg.haskins (Thu, 04 May 2017 19:35:58 GMT):
haha, ok

greg.haskins (Thu, 04 May 2017 19:36:05 GMT):
ill do a follow up CR then

cbf (Thu, 04 May 2017 19:39:51 GMT):
I left your JIRA open

greg.haskins (Thu, 04 May 2017 19:39:58 GMT):
roger

wlahti (Thu, 04 May 2017 19:43:07 GMT):
A few easy ones to switch some core.yaml parameters from ints to durations: https://gerrit.hyperledger.org/r/#/c/8957/ https://gerrit.hyperledger.org/r/#/c/8963/ https://gerrit.hyperledger.org/r/#/c/8967/

greg.haskins (Thu, 04 May 2017 20:32:24 GMT):
@cbf @yacovm Added the delta back in as a new CR

greg.haskins (Thu, 04 May 2017 20:32:25 GMT):
https://gerrit.hyperledger.org/r/#/c/8983/

cbf (Thu, 04 May 2017 21:56:50 GMT):
bump https://gerrit.hyperledger.org/r/#/c/8965/

nickgaski (Thu, 04 May 2017 21:58:14 GMT):
would be good to get some eyes on this - https://gerrit.hyperledger.org/r/#/c/8981/ - adds the README for the end to end code

cbf (Fri, 05 May 2017 00:31:11 GMT):
@nickgaski I'd like this to replace getting started and also have downloadable and installable binaries from the release

nickgaski (Fri, 05 May 2017 09:57:08 GMT):
makes sense. let me get with ramesh and see where we are on that.

muralisr (Fri, 05 May 2017 11:54:47 GMT):
review for a simple chaincodedev doc update https://gerrit.hyperledger.org/r/#/c/8985/ please ?

wlahti (Fri, 05 May 2017 14:04:42 GMT):
Fix logging for chaincode container to allow log level to be set for modules other than 'shim' and control the 'shim' level separately: https://gerrit.hyperledger.org/r/#/c/8807

elli-androulaki (Fri, 05 May 2017 15:01:45 GMT):
Hi, pairs of eyes to review this one ? https://gerrit.hyperledger.org/r/#/c/8667 Thanks!

elli-androulaki (Fri, 05 May 2017 15:01:45 GMT):
Hi, any pairs of eyes to review this one ? https://gerrit.hyperledger.org/r/#/c/8667 Thanks!

yacovm (Fri, 05 May 2017 15:24:37 GMT):
Can anyone +2 this please? disabling of a brittle unit test https://gerrit.hyperledger.org/r/#/c/9007/

yacovm (Fri, 05 May 2017 15:24:37 GMT):
Can anyone +2 this please? disabling of a brittle unit test https://gerrit.hyperledger.org/r/#/c/9007/ @JonathanLevi @cbf

smithbk (Fri, 05 May 2017 17:32:18 GMT):
The following still need attention:

smithbk (Fri, 05 May 2017 17:32:20 GMT):
https://gerrit.hyperledger.org/r/#/c/8853 - deep copy config https://gerrit.hyperledger.org/r/#/c/8909 - fix missing CA values logic https://gerrit.hyperledger.org/r/#/c/8944 - Finish fix of multi CA config

muralisr (Sat, 06 May 2017 02:24:14 GMT):
simple bug fix https://gerrit.hyperledger.org/r/#/c/9031/

muralisr (Sat, 06 May 2017 02:24:14 GMT):
simple (but important) bug fix https://gerrit.hyperledger.org/r/#/c/9031/

yacovm (Sat, 06 May 2017 10:06:36 GMT):
Easy one - typo fixes https://gerrit.hyperledger.org/r/#/c/8987/

yacovm (Sat, 06 May 2017 10:06:36 GMT):
Easy one - typo fixes https://gerrit.hyperledger.org/r/#/c/8987/ (thanks @nnao )

cbf (Sat, 06 May 2017 10:20:33 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/9005/

rameshthoomu (Sun, 07 May 2017 00:22:03 GMT):
review this pls https://gerrit.hyperledger.org/r/#/c/9041/

cbf (Sun, 07 May 2017 10:29:18 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/9049/

baohua (Mon, 08 May 2017 02:08:01 GMT):
easyone: https://gerrit.hyperledger.org/r/8873 and https://gerrit.hyperledger.org/r/8879

baohua (Mon, 08 May 2017 02:08:49 GMT):
This one add more checking in make linter, better merged for 1.0 quality insurance: https://gerrit.hyperledger.org/r/8861

muralisr (Mon, 08 May 2017 11:31:36 GMT):
this one generated a lot of discussion in fabric-crypto ..https://gerrit.hyperledger.org/r/#/c/9073 the main fix is in LSCC. Rest of the changes to UT

muralisr (Mon, 08 May 2017 11:32:27 GMT):
with the above we hshould be closer to getting the SDK e2e to run successfully... so some love please

cbf (Mon, 08 May 2017 12:35:18 GMT):
simple one https://gerrit.hyperledger.org/r/#/c/8991/

JonathanLevi (Mon, 08 May 2017 13:20:52 GMT):
--- All, to make it easier for us (the maintainers, and other reviewers) to review/evaluate/prioritize CRs better... please make sure that the underlying JIRA tickets contain enough motivation, or in one word the *why* - why something is being suggested, requires a change... this is not only something that we going to be more strict about in the coming weeks (certainly more than before) - but it will also help the code/CR submitter to make sure that what one works is needed + gets the appropriate/correct priority and handled in a more timely fashion. Thanks. ---

adc (Mon, 08 May 2017 13:37:36 GMT):
Hi All, please have a look at https://gerrit.hyperledger.org/r/#/c/9013/. Now CI is passing :)

JonathanLevi (Mon, 08 May 2017 13:41:35 GMT):
Very nice @adc, thanks.

JonathanLevi (Mon, 08 May 2017 13:42:23 GMT):
(You have really "made it your mission" to improve coverage - I can tell! ;-))

jimthematrix (Mon, 08 May 2017 13:59:26 GMT):
@muralisr I just +2'ed (i already tested your private patch, am now pulling down the CR just to double check)

muralisr (Mon, 08 May 2017 13:59:50 GMT):
perfect, thanks @jimthematrix

jimthematrix (Mon, 08 May 2017 14:01:21 GMT):
the CR checked out fine with node SDK e2e just now

jimthematrix (Mon, 08 May 2017 14:01:29 GMT):
(locally on my machine)

gennadyl (Mon, 08 May 2017 14:35:14 GMT):
https://gerrit.hyperledger.org/r/#/c/8657/ - small fix in gossip discovery module

gennadyl (Mon, 08 May 2017 14:35:40 GMT):
Most of the code is unit test for the change :)

nickgaski (Mon, 08 May 2017 16:00:57 GMT):
hi where are we on this - https://gerrit.hyperledger.org/r/#/c/8981/ - I know the end goal is to port this documentation to getting started. But as it stands you still need to set GOPATH, clone and then run a make to get the images and binaries . Regardless, I feel we should merge this CR and upgrade the existing documentation in examples/e2e_cli

wlahti (Mon, 08 May 2017 16:21:38 GMT):
One line change to remove a fmt.Printf statement that generates a lot of log output: https://gerrit.hyperledger.org/r/#/c/9101/

wlahti (Mon, 08 May 2017 16:21:38 GMT):
One line change to remove a fmt.Printf statement that generates a lot of log output: https://gerrit.hyperledger.org/r/#/c/9101/ . Everyone who has pulled the latest changes within the last few hours and run the e2e cli will greatly appreciate this. :)

sanchezl (Mon, 08 May 2017 20:04:16 GMT):
Looking to get this pushed.. it's been out there for a while: https://gerrit.hyperledger.org/r/#/c/8529/

muralisr (Mon, 08 May 2017 20:06:54 GMT):
@sanchezl will look by tonight (did look before but was waiting for V+1 ... need to do it again)

greg.haskins (Mon, 08 May 2017 21:28:30 GMT):
trivial stack of fixes for a tool not in the critical path: https://gerrit.hyperledger.org/r/#/c/9095/

scottz (Mon, 08 May 2017 22:35:30 GMT):
https://gerrit.hyperledger.org/r/#/c/8989/ Please review, so we can get started with running the automated daily test suite from Jenkins and create display dashboards. And then this will allow us to start adding actual system tests into the community. Contains repeating formatted code structure, and additional examples and feeder scripts, so this should not be too time-consuming to review. The README files are all WIP, so don't worry about all those 150+ lines (although high level comments about structure and topics would be helpful and welcome).

jiangyaoguo (Tue, 09 May 2017 02:47:59 GMT):
https://gerrit.hyperledger.org/r/#/c/9087/ add chaincode upgrade test in e2e_cli

jimthematrix (Tue, 09 May 2017 03:47:59 GMT):
https://gerrit.hyperledger.org/r/#/c/9059/ - critical fix to overcome the recent breaking changes (instantiation policy) @mastersingh24 @yacovm @binhn

adc (Tue, 09 May 2017 11:32:03 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/8797/ :) It is about integration of the error handling framwork in bccsp/sw

baohua (Tue, 09 May 2017 12:06:56 GMT):
Easy one to update private key format in fabric-ca: https://gerrit.hyperledger.org/r/#/c/9121/, welcome for review, thanks!

Honglei (Tue, 09 May 2017 15:04:51 GMT):
removed some stale code in ./core/chaincode https://gerrit.hyperledger.org/r/#/c/9079/, welcome for review. Thanks.

yacovm (Tue, 09 May 2017 15:16:52 GMT):
@Honglei if you could just fix the imports that'd be great

jeffgarratt (Tue, 09 May 2017 15:33:42 GMT):
@kostas @binhn to address FAB-3550, 2 liner :) https://gerrit.hyperledger.org/r/#/c/9129/

cbf (Tue, 09 May 2017 15:37:07 GMT):
https://gerrit.hyperledger.org/r/#/c/9113/ easy one

Honglei (Tue, 09 May 2017 15:42:02 GMT):
@yacovm OK.

jimthematrix (Tue, 09 May 2017 15:56:12 GMT):
https://gerrit.hyperledger.org/r/#/c/8995/ - rebased and rebuilt successfully, required by Composer and part of the alpha2 list. @mastersingh24 @yacovm @davidkel @sstone1

davidkel (Tue, 09 May 2017 15:56:12 GMT):
Has joined the channel.

sstone1 (Tue, 09 May 2017 15:56:12 GMT):
Has joined the channel.

muralisr (Tue, 09 May 2017 21:29:50 GMT):
thought worth noting ..... all 3 CI jobs pass with https://gerrit.hyperledger.org/r/#/c/9153

muralisr (Tue, 09 May 2017 21:30:05 GMT):

Message Attachments

jeffgarratt (Tue, 09 May 2017 22:48:00 GMT):
@binhn @kostas ready to go, passed and @muralisr +2d https://gerrit.hyperledger.org/r/#/c/9153/

JonathanLevi (Tue, 09 May 2017 23:28:38 GMT):
@jeffgarratt Thanks so much. Merged.

jimthematrix (Wed, 10 May 2017 02:51:38 GMT):
https://gerrit.hyperledger.org/r/#/c/9147/ - last fix to build breaks in node SDK (this one only occurs occasionally but frequent enough to warrant a Highest bug), @mastersingh24 @yacovm @binhn @cbf

jimthematrix (Wed, 10 May 2017 03:45:05 GMT):
https://gerrit.hyperledger.org/r/#/c/9075/ - is now ready for merge, @binhn @mastersingh24 @cbf @yacovm

yacovm (Wed, 10 May 2017 09:39:44 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/9175/

yacovm (Wed, 10 May 2017 09:39:44 GMT):
2 ones https://gerrit.hyperledger.org/r/#/c/9175/ https://gerrit.hyperledger.org/r/#/c/9175/

yacovm (Wed, 10 May 2017 09:39:44 GMT):
2 easy ones https://gerrit.hyperledger.org/r/#/c/9175/ https://gerrit.hyperledger.org/r/#/c/9175/

yacovm (Wed, 10 May 2017 11:19:33 GMT):
2 easy ones https://gerrit.hyperledger.org/r/#/c/9175/ https://gerrit.hyperledger.org/r/#/c/9083/

muralisr (Wed, 10 May 2017 12:20:06 GMT):
an easy (but important) bug fix https://gerrit.hyperledger.org/r/#/c/9169/

muralisr (Wed, 10 May 2017 12:20:17 GMT):
@dave.enyeart ^^

JonathanLevi (Wed, 10 May 2017 17:16:13 GMT):
Community ;-) I have a question: are these two, just a matter of timeouts on the CI ? https://gerrit.hyperledger.org/r/#/c/8909 https://gerrit.hyperledger.org/r/#/c/8944

JonathanLevi (Wed, 10 May 2017 17:16:48 GMT):
Is/was anyone able to reproduce the/such a failure locally?

latitiah (Wed, 10 May 2017 17:57:19 GMT):
I have 4 CRs that I'd like to get merged: https://gerrit.hyperledger.org/r/#/c/8841/ https://gerrit.hyperledger.org/r/#/c/8897/ https://gerrit.hyperledger.org/r/#/c/8925/ https://gerrit.hyperledger.org/r/#/c/9131/

jeffgarratt (Wed, 10 May 2017 18:45:32 GMT):
@binhn @kostas @jyellick Kafka and BDD is ready to go https://gerrit.hyperledger.org/r/#/c/9195/

binhn (Wed, 10 May 2017 19:28:11 GMT):
@JonathanLevi those failures were on power system, and i know folks have been chasing that ci

jimthematrix (Wed, 10 May 2017 19:31:24 GMT):
https://gerrit.hyperledger.org/r/#/c/9207/ - trivial updates to README. @mastersingh24 @cbf @binhn @yacovm

skarim (Thu, 11 May 2017 14:19:06 GMT):
Please review the following fabric-ca changes: https://gerrit.hyperledger.org/r/#/c/7741 https://gerrit.hyperledger.org/r/#/c/8909 https://gerrit.hyperledger.org/r/#/c/8944

adc (Thu, 11 May 2017 14:32:03 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/9221/ Thanks :)

jimthematrix (Thu, 11 May 2017 16:59:03 GMT):
https://gerrit.hyperledger.org/r/#/c/9219/ - trivial enhancement to add transient map support in proposals. most of the code in the CR are tests. @mastersingh24 @binhn @cbf @yacovm

latitiah (Thu, 11 May 2017 18:42:19 GMT):
The following have +1s, but are in need of +2s These are for the feature and system behave tests: https://gerrit.hyperledger.org/r/#/c/8841 https://gerrit.hyperledger.org/r/#/c/8897 https://gerrit.hyperledger.org/r/#/c/8925 https://gerrit.hyperledger.org/r/#/c/9131 https://gerrit.hyperledger.org/r/#/c/9163

nickgaski (Thu, 11 May 2017 19:13:35 GMT):
this has been sitting out for a week - https://gerrit.hyperledger.org/r/#/c/8981/ - it accompanies all of the new code merged into e2e_cli. I will port this content to getting started once we cut alpha2 images. However, the examples/e2e_cli folder still merits a good README, and this far exceeds the current resident.

adc (Fri, 12 May 2017 08:23:52 GMT):
Hi All, please give some love to https://gerrit.hyperledger.org/r/#/c/9187/ :)

adc (Fri, 12 May 2017 09:31:00 GMT):
Hi All, please share your love with https://gerrit.hyperledger.org/r/#/c/9275/ :)

cbf (Fri, 12 May 2017 11:37:23 GMT):
@here we are very close to cutting the alpha2 release, please don't merge any CRs until we have done so unless they are explicitly agreed as a function of the release process

cbf (Fri, 12 May 2017 15:19:06 GMT):
as a reminder, I have https://gerrit.hyperledger.org/r/#/c/9267/ whcih proposes a process for feature/enhancement proposals - I'd like maintainers (and anyone else) to review and add +1s to build consensus

jimthematrix (Fri, 12 May 2017 16:10:03 GMT):
@cbf @binhn https://gerrit.hyperledger.org/r/#/c/9271/ - optional but totally on the tooling side for easier getting started (based on feedback from Chris)

jeffgarratt (Sat, 13 May 2017 16:26:53 GMT):
@jyellick @binhn @mastersingh24 Propoer orderer configuration -> https://gerrit.hyperledger.org/r/#/c/9337/

jeffgarratt (Sat, 13 May 2017 16:26:53 GMT):
@jyellick @binhn @mastersingh24 Proper orderer configuration -> https://gerrit.hyperledger.org/r/#/c/9337/

JonathanLevi (Sun, 14 May 2017 18:45:09 GMT):
Just to be clear, we are still in *CODE FREEZE*. No merging of anything other than stuff that is in agreement (in writing), until we have the release published and we declare otherwise.

JonathanLevi (Sun, 14 May 2017 18:45:52 GMT):
(The above is a note mainly to the maintainers - but if there's any doubt/disagreement - please include me)

lehors (Mon, 15 May 2017 11:13:22 GMT):
guys, I'd like to ask for https://gerrit.hyperledger.org/r/#/c/8887/6 to be reviewed and merged in

lehors (Mon, 15 May 2017 11:13:43 GMT):
this is about fixing broken links in the doc

lehors (Mon, 15 May 2017 11:14:38 GMT):
maybe not critical but certainly important - our doc is really in bad shape - and at the same time there are zero risks associated with this CR

lehors (Mon, 15 May 2017 11:15:18 GMT):
I've got more doc related fixes coming but that would be a good first step

lehors (Mon, 15 May 2017 11:15:20 GMT):
thanks

C0rWin (Mon, 15 May 2017 12:13:44 GMT):
So, now I see alpha2 tag has been pushed, are we still in pre-alpha2 code freeze? If not, what are remained items that need to get in? [ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=v8N2M3Jh8XTqXw5oC) @JonathanLevi

JonathanLevi (Mon, 15 May 2017 15:44:15 GMT):
@lehors: G-d bless them relative file paths!

lehors (Mon, 15 May 2017 15:44:34 GMT):
you're welcome :)

JonathanLevi (Mon, 15 May 2017 15:44:35 GMT):
I agree that we should fix the broken links in the doc!

JonathanLevi (Mon, 15 May 2017 15:45:20 GMT):
We are actually about to release the hard `CODE FREEZE`... and allow more tests and bug fixes in.

JonathanLevi (Mon, 15 May 2017 15:45:54 GMT):
I will send out a wide email about the end of the CODE FREEZE, but we can continue to review stuff happily.

muralisr (Mon, 15 May 2017 15:46:10 GMT):
@JonathanLevi tests as in the UTs that's in the gerritt CR list ?

JonathanLevi (Mon, 15 May 2017 15:47:02 GMT):
Tests as in the service-ability, and code coverage improvements that are part of the "Grand Master Plan" (FAB-3040)

JonathanLevi (Mon, 15 May 2017 15:47:02 GMT):
Tests + errors + logs as in the "service-ability", and code coverage improvements that are part of the "Grand Master Plan" (FAB-3040)

JonathanLevi (Mon, 15 May 2017 15:47:31 GMT):
And any bug (fixes) that we will find as time goes by.

JonathanLevi (Mon, 15 May 2017 15:50:12 GMT):
@muralisr: https://gerrit.hyperledger.org/r/#/c/9281/

JonathanLevi (Mon, 15 May 2017 15:58:35 GMT):
@muralisr: See the last comment from Greg. Pardon the CAPS, I've been really surprised to see that merge going in when I work up. It was at 2:48am locally. https://gerrit.hyperledger.org/r/#/c/9281/

muralisr (Mon, 15 May 2017 16:00:09 GMT):
no worries @JonathanLevi ...

jimthematrix (Mon, 15 May 2017 16:42:54 GMT):
@JonathanLevi is the code freeze still necessary at this point? are there more tests being performed? I'm of the impression that we are open for business for post-alpha2 because 1) https://gerrit.hyperledger.org/r/#/c/9305/ got merged and 2) v1.0.0-alpha2 tag was pushed

mastersingh24 (Mon, 15 May 2017 20:09:49 GMT):
@jimthematrix @JonathanLevi - https://gerrit.hyperledger.org/r/#/c/9367/ - minor update to the release notes - hopefully you guys can approve and merge

jimthematrix (Mon, 15 May 2017 20:10:15 GMT):
+2'ed

cbf (Mon, 15 May 2017 21:06:06 GMT):
need one more on https://gerrit.hyperledger.org/r/#/c/9367/

cbf (Mon, 15 May 2017 21:06:13 GMT):
please

muralisr (Mon, 15 May 2017 23:48:14 GMT):
@cbf I have +2ed ^^^ but did not hit submit as I was not sure of status ... wanted to wait if you want to do last minute verifies (links, etc)

cbf (Mon, 15 May 2017 23:59:50 GMT):
thx

C0rWin (Tue, 16 May 2017 05:27:21 GMT):
1. Elimination of unused code and duplication: https://gerrit.hyperledger.org/r/#/c/9361/ 2. Add/Enhance unit tests for CSCC: https://gerrit.hyperledger.org/r/#/c/9363/ (I believe this, it falls into definition from: https://chat.hyperledger.org/channel/fabric-maintainers?msg=zWq3HaRy9Dbk6hCsx)

C0rWin (Tue, 16 May 2017 05:27:57 GMT):
and another one: https://gerrit.hyperledger.org/r/#/c/9375/

jiangyaoguo (Tue, 16 May 2017 06:14:15 GMT):
https://gerrit.hyperledger.org/r/#/c/9087/ e2e_cli test for chaincode upgrade

yacovm (Tue, 16 May 2017 06:33:22 GMT):
UTs for SCC https://gerrit.hyperledger.org/r/#/c/9375/

adc (Tue, 16 May 2017 08:54:24 GMT):
Hi All, some love to https://gerrit.hyperledger.org/r/#/c/9355/ and https://gerrit.hyperledger.org/r/#/c/9357/. They improve the test coverage of fabric-ca :)

rameshthoomu (Tue, 16 May 2017 12:27:14 GMT):
@mastersingh24 @greg.haskins @cbf need your review comments on this patch. This patch has to go to publish fabric binaries from production CI https://gerrit.hyperledger.org/r/#/c/8939/

rameshthoomu (Tue, 16 May 2017 12:27:52 GMT):
especially on this https://gerrit.hyperledger.org/r/#/c/8939/17/jjb/fabric/include-raw-fabric-push-fabric-binaries.sh

greg.haskins (Tue, 16 May 2017 12:28:36 GMT):
@rameshthoomu I will take a look, but I have serious reservations about two things

greg.haskins (Tue, 16 May 2017 12:29:37 GMT):
1) using nexus for release artifacts...need to understand the URI planning better, and 2) using the "make release" artifacts as a substitute for real packaging (RPM/DEB/BREW)

greg.haskins (Tue, 16 May 2017 12:29:51 GMT):
ill try to review later today

rameshthoomu (Tue, 16 May 2017 12:37:15 GMT):
thanks @greg.haskins

cbf (Tue, 16 May 2017 12:38:06 GMT):
@rameshthoomu see my review comment

mastersingh24 (Tue, 16 May 2017 12:38:08 GMT):
@greg.haskins - we can change in the future - but this is the best we have for now and it is a nice way to least make downloadable archives until we get into installers. We were also told that Nexus3 was what we were supposed to use to host "file" based artifacts / archives

mastersingh24 (Tue, 16 May 2017 12:38:28 GMT):
But agree we need to make sure the URIs are simple

greg.haskins (Tue, 16 May 2017 12:38:35 GMT):
heres my beef, so if you can talk me off the ledge

mastersingh24 (Tue, 16 May 2017 12:38:42 GMT):
And if need be we should register vanity URLs

cbf (Tue, 16 May 2017 12:38:47 GMT):
@greg.haskins while I want a true installer experience, we need to make progress with baby steps

mastersingh24 (Tue, 16 May 2017 12:38:51 GMT):
talk or walk> ;)

mastersingh24 (Tue, 16 May 2017 12:38:51 GMT):
talk or walk? ;)

mastersingh24 (Tue, 16 May 2017 12:38:57 GMT):
just kidding - but could not resist

cbf (Tue, 16 May 2017 12:39:07 GMT):
definitely want simple URI scheme

greg.haskins (Tue, 16 May 2017 12:39:11 GMT):
I have no general problem with nexus hosting artifacts...as long as we have some planning around the URLs for being stable enough for LTS windows

greg.haskins (Tue, 16 May 2017 12:39:17 GMT):
ideally, not ugly either

cbf (Tue, 16 May 2017 12:39:22 GMT):
but first step is to eliminate the need to clone and build to run

mastersingh24 (Tue, 16 May 2017 12:39:22 GMT):
exactly

greg.haskins (Tue, 16 May 2017 12:39:41 GMT):
I have been planning on moving the hosting of chaintool from GH-releases to nexus, as a matter of fact

greg.haskins (Tue, 16 May 2017 12:39:56 GMT):
but chaintool is a different beast from, say, the peer binary

mastersingh24 (Tue, 16 May 2017 12:40:14 GMT):
Right now the only binaries are the tools

greg.haskins (Tue, 16 May 2017 12:40:19 GMT):
chaintool is JVM based, peer is compiled

cbf (Tue, 16 May 2017 12:40:20 GMT):
right

mastersingh24 (Tue, 16 May 2017 12:40:37 GMT):
We tested all the cross compilation stuff

greg.haskins (Tue, 16 May 2017 12:40:37 GMT):
I am concerned that the golang build is not as universal as we really think (thinking of glibc type problems)

mastersingh24 (Tue, 16 May 2017 12:41:11 GMT):
I agree we need to adjust longer term

greg.haskins (Tue, 16 May 2017 12:41:20 GMT):
so, are we really sure we can say "this is universal linux" ?

greg.haskins (Tue, 16 May 2017 12:41:35 GMT):
maybe it is: I havent investigated closely...but I suspect it is not

greg.haskins (Tue, 16 May 2017 12:41:53 GMT):
I bet there is a coupling to the OS it was built on

greg.haskins (Tue, 16 May 2017 12:43:00 GMT):
I certainly appreciate the notion of wanting to eliminate the need for building the binaries first, and for baby steps

greg.haskins (Tue, 16 May 2017 12:43:12 GMT):
I am primarily concerned that this is a giant cow pattie ;)

greg.haskins (Tue, 16 May 2017 12:43:57 GMT):
I also have a ton of experience with packaging software so I am not thinking that the next step is too far away, should the motivation be there to push

greg.haskins (Tue, 16 May 2017 12:44:13 GMT):
but I have to run to a family thing, ill be online in a bit

greg.haskins (Tue, 16 May 2017 14:14:35 GMT):
I just looked:

greg.haskins (Tue, 16 May 2017 14:14:41 GMT):
```$ make release Building release/linux-amd64/bin/configtxgen for linux-amd64 mkdir -p release/linux-amd64/bin CGO_CFLAGS=" " GOOS=linux GOARCH=amd64 go build -o /home/ghaskins/sandbox/hyperledger/go/src/github.com/hyperledger/fabric/release/linux-amd64/bin/configtxgen -tags "nopkcs11" -ldflags "-X github.com/hyperledger/fabric/common/metadata.Version=1.0.0-alpha3-snapshot-88c6b1a4 -X github.com/hyperledger/fabric/common/metadata.BaseVersion=0.3.0 -X github.com/hyperledger/fabric/common/metadata.BaseDockerLabel=org.hyperledger.fabric -X github.com/hyperledger/fabric/common/metadata.DockerNamespace=hyperledger -X github.com/hyperledger/fabric/common/metadata.BaseDockerNamespace=hyperledger" github.com/hyperledger/fabric/common/configtx/tool/configtxgen Building release/linux-amd64/bin/cryptogen for linux-amd64 mkdir -p release/linux-amd64/bin CGO_CFLAGS=" " GOOS=linux GOARCH=amd64 go build -o /home/ghaskins/sandbox/hyperledger/go/src/github.com/hyperledger/fabric/release/linux-amd64/bin/cryptogen -tags "nopkcs11" -ldflags "-X github.com/hyperledger/fabric/common/metadata.Version=1.0.0-alpha3-snapshot-88c6b1a4 -X github.com/hyperledger/fabric/common/metadata.BaseVersion=0.3.0 -X github.com/hyperledger/fabric/common/metadata.BaseDockerLabel=org.hyperledger.fabric -X github.com/hyperledger/fabric/common/metadata.DockerNamespace=hyperledger -X github.com/hyperledger/fabric/common/metadata.BaseDockerNamespace=hyperledger" github.com/hyperledger/fabric/common/tools/cryptogen mkdir -p release/linux-amd64/install ghaskins@hyperledger:~/sandbox/hyperledger/go/src/github.com/hyperledger/fabric$ ldd release/linux-amd64/bin/cryptogen linux-vdso.so.1 => (0x00007ffe89906000) libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0305bf4000) libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f030582d000) /lib64/ld-linux-x86-64.so.2 (0x000056402aef7000)```

greg.haskins (Tue, 16 May 2017 14:15:00 GMT):
This isn't likely to be completely portable

greg.haskins (Tue, 16 May 2017 14:15:30 GMT):
@mastersingh24 ^^^

latitiah (Tue, 16 May 2017 15:07:18 GMT):
Good day! I have multiple CRs for review in the documentation and test areas: https://gerrit.hyperledger.org/r/#/c/8841/ (behave test code) https://gerrit.hyperledger.org/r/#/c/8897/ (used with test code) https://gerrit.hyperledger.org/r/#/c/8925/ (behave test code) https://gerrit.hyperledger.org/r/#/c/9131/ (documentation) https://gerrit.hyperledger.org/r/#/c/9163/ (test code) https://gerrit.hyperledger.org/r/#/c/9237/ (behave feature test scaffolding)

rocket.cat (Tue, 16 May 2017 15:07:18 GMT):
Good day, latitiah

scottz (Tue, 16 May 2017 15:15:44 GMT):
The Quality team is putting together a nice CI report display page for automated daily test suite. But first we are desparately looking for love for some "fabric" patch requests for several tools and test placeholders that will feed into the daily test suite report. Several potential contributors are waiting for these, which will enable them to start writing tests, and of course our team is planning to use them to write numerous tests as well as submit some other tools to too. PLEASE can we get some help with these? Scott: https://gerrit.hyperledger.org/r/#/c/9257/ FAB-3880 rename sys testnames and descripts Scott: https://gerrit.hyperledger.org/r/#/c/9371/ FAB-3932 standardize test names Latitia: https://gerrit.hyperledger.org/r/#/c/8841/ [FAB-1017] Fix due to code changes Latitia: https://gerrit.hyperledger.org/r/#/c/8897/ [FAB-969]: Docker compose files Latitia: https://gerrit.hyperledger.org/r/#/c/8925/ [FAB-3633]: Setup and Teardown environment Latitia: https://gerrit.hyperledger.org/r/#/c/9131/ [FAB-3753]: Readme for Behave System Tests Latitia: https://gerrit.hyperledger.org/r/#/c/9237/ [FAB-3846]: Behave test feature file placeholders Latitia: https://gerrit.hyperledger.org/r/#/c/9163/ [FAB-3507] Chaincode Tests (this is associated with Nishi's changes, below) Nishi: https://gerrit.hyperledger.org/r/#/c/9311/ [FAB-3791] Script to Test Chaincode_Example03 Nishi: https://gerrit.hyperledger.org/r/#/c/9315/ [FAB-3796] Script to Test Chaincode_Example04 Nishi: https://gerrit.hyperledger.org/r/#/c/9319/ [FAB-3797] Script to Test Chaincode_Example05 Nishi: https://gerrit.hyperledger.org/r/#/c/9321/ [FAB-3792] Script to test marbles02 chaincode Adnan: https://gerrit.hyperledger.org/r/#/c/9251/ [FAB-3878] Placeholder for Ledger performance tests Ratnakar: https://gerrit.hyperledger.org/r/#/c/9377/ [FAB-3935] Add README to Balance-transfer sample Dongming: https://gerrit.hyperledger.org/r/#/c/9261/ [FAB-3559] submit Performance Traffic Engine (PTE) - This is a large one; we talked about having a playback and merging this working PTE tool. Scott: 9257 FAB-3880 rename sys testnames and descripts Scott: 9371 FAB-3932 standardize test names Latitia: 8841 [FAB-1017] Fix due to code changes Latitia: 8897 [FAB-969]: Docker compose files Latitia: 8925 [FAB-3633]: Setup and Teardown environment Latitia: 9131 [FAB-3753]: Readme for Behave System Tests Latitia: 9237 [FAB-3846]: Behave test feature file placeholders Latitia: 9163 [FAB-3507] Chaincode Tests (this is associated with Nishi's changes, below) Nishi: 9311 [FAB-3791] Script to Test Chaincode_Example03 Nishi: 9315 [FAB-3796] Script to Test Chaincode_Example04 Nishi: 9319 [FAB-3797] Script to Test Chaincode_Example05 Nishi: 9321 [FAB-3792] Script to test marbles02 chaincode Adnan: 9251 [FAB-3878] Placeholder for Ledger performance tests Ratnakar: 9377 [FAB-3935] Add README to Balance-transfer sample Dongming: 9261 [FAB-3559] submit Performance Traffic Engine (PTE) - This is a large one; we talked about having a playback and merging this working PTE tool.

smithbk (Tue, 16 May 2017 16:54:27 GMT):
Pls review: https://gerrit.hyperledger.org/r/#/c/8975/ - Fix panic in server start

nickgaski (Tue, 16 May 2017 18:28:11 GMT):
@here - I am curious about the status of this CR - https://gerrit.hyperledger.org/r/#/c/8939/ . We seem to be going back and forth in an endless debate regarding the appropriateness of hosting binaries on nexus and the underlying stability of the URL (I am aware that a previous tarball got wiped out). That said, there is a highest priority bug opened against the fact that getting started does not reflect alpha2 and this seems like the most realistic solution at this moment in time. It should be noted that these are only binaries for the two tools and the images will still be derived from Docker Hub. If the aversion to hosting on nexus is truly merited, then can we offer a better alternative?

jeffgarratt (Tue, 16 May 2017 18:31:37 GMT):
@cbf @mastersingh24 @jyellick @kostas Wanted to ask if https://gerrit.hyperledger.org/r/#/c/9337/ is good to go?

jyellick (Tue, 16 May 2017 18:32:30 GMT):
Looks good to me, but with @mastersingh24 in wanting to get @cbf's approval first

cbf (Tue, 16 May 2017 18:40:42 GMT):
done

cbf (Tue, 16 May 2017 18:41:48 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=dcTCjXjDYAdGne2Di) @nickgaski it was merged, but I am not clear on what the source of the back and forth is

cbf (Tue, 16 May 2017 18:42:29 GMT):
from my POV, we want to have people be able to download binaries (or have them installed with the likes of homebrew or apt-get

cbf (Tue, 16 May 2017 18:42:43 GMT):
we don't want people to have to build the software

cbf (Tue, 16 May 2017 18:43:01 GMT):
I have been saying this consistently since I can't recall

cbf (Tue, 16 May 2017 18:43:24 GMT):
I know we cut corners for the hackfests but IMO, that was a mistake

nickgaski (Tue, 16 May 2017 18:47:47 GMT):
yes I understand and agree. 8939 is not merged as far as I can tell; and as an example I see a response from Greg stating "I have reservations about the appropriateness of this release method." This is simply a tarball that bundles the examples/e2e_cli content and then inputs the binaries from a `make release-all`. The end user does NOT have to build anything, they merely run the download images script and then the subsequent scripts will grab the appropriate binaries for their platform. I am interjecting here because I cannot update getting started until we reach a conclusion on this CR. The end-to-end.rst document was indeed merged, and that is much appreciated as I plan to port nearly all of it into the Getting Started page

smithbk (Tue, 16 May 2017 19:11:46 GMT):
fabric-ca change sets needing review

smithbk (Tue, 16 May 2017 19:11:49 GMT):
https://gerrit.hyperledger.org/r/#/c/8975/ - Fix panic in server start https://gerrit.hyperledger.org/r/#/c/9265/ - Configuration of intermediate CA via CLI https://gerrit.hyperledger.org/r/#/c/9339/ - CA server error handling (1 of 2) https://gerrit.hyperledger.org/r/#/c/9341/ - CA server error handling (1 of 2) https://gerrit.hyperledger.org/r/#/c/9227/ - Fix validation of CA certificate https://gerrit.hyperledger.org/r/#/c/9407/ - Improve test coverage of lib https://gerrit.hyperledger.org/r/#/c/9357/ - Improve test coverage of lib/tls

bmos299 (Tue, 16 May 2017 19:11:53 GMT):
Please note the test automation is blocked without the CRs referenced by @scottz at [ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=oPfgaGHvLejoHuELA)

rjones (Tue, 16 May 2017 19:38:03 GMT):
Has left the channel.

mastersingh24 (Tue, 16 May 2017 20:06:38 GMT):
some UT work: https://gerrit.hyperledger.org/r/9343 https://gerrit.hyperledger.org/r/#/c/9345/ (just needs someone to hit submit)

yacovm (Tue, 16 May 2017 21:12:01 GMT):
some UT work as well https://gerrit.hyperledger.org/r/#/c/9375/ (just needs 2 +2s and to hit submit)

nickgaski (Tue, 16 May 2017 21:40:45 GMT):
this is an easy one; cleans up some formatting and a few inaccuracies on the end to end doc - https://gerrit.hyperledger.org/r/#/c/9417/

dave.enyeart (Tue, 16 May 2017 23:11:01 GMT):
@nickgaski What do you mean by: >and then inputs the binaries from a `make release-all`

dave.enyeart (Tue, 16 May 2017 23:11:01 GMT):
@nickgaski Concerning 8939, what do you mean by: >and then inputs the binaries from a `make release-all`

dave.enyeart (Tue, 16 May 2017 23:42:54 GMT):
I think you mean that configtxgen and cryptogen are built and along with examples/e2e_cli are published to nexus, where it can be downloaded by people to drive end2end trial with docker images. right?

dave.enyeart (Tue, 16 May 2017 23:43:57 GMT):
If so, I believe that fulfills the objective of people running the docker images without having to make anything

dave.enyeart (Tue, 16 May 2017 23:56:50 GMT):
Concerning 9417, I've +2ed your formatting updates for Getting Started doc. Could somebody else please +2 and merge so that these updates are available for a good Getting Started experience with alpha2.

dave.enyeart (Tue, 16 May 2017 23:56:50 GMT):
@nickgaski Concerning 9417, I've +2ed your formatting updates for Getting Started doc. Could somebody else please +2 and merge so that these updates are available for a good Getting Started experience with alpha2.

yacovm (Wed, 17 May 2017 07:00:04 GMT):
Easy one, effecting only UTs https://gerrit.hyperledger.org/r/#/c/9411/ `Re-introduce disabled goroutine leak test`

C0rWin (Wed, 17 May 2017 10:31:17 GMT):
eliminating unused code: https://gerrit.hyperledger.org/r/#/c/9361/ and adding more tests to cscc: https://gerrit.hyperledger.org/r/#/c/9363/

mastersingh24 (Wed, 17 May 2017 10:49:21 GMT):
There guys are getting a bit lonely: https://gerrit.hyperledger.org/r/9343 https://gerrit.hyperledger.org/r/9421

mastersingh24 (Wed, 17 May 2017 10:51:03 GMT):
[Merged ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=3EBbfJh6dHJ7fRRSy) @C0rWin

muralisr (Wed, 17 May 2017 11:45:29 GMT):
chaincode/shim tests https://gerrit.hyperledger.org/r/#/c/9395 still has "WIP" in subject but will remove it when reverify passes. Its up from 17 to 70% coverage. A bit of refactor to eliminate duplicate error code (such as failure due to unmarshal) that would help a little more (which is what I'll try today)

yacovm (Wed, 17 May 2017 11:45:34 GMT):
3 change sets: https://gerrit.hyperledger.org/r/#/c/9405/ Fixes a UT failure https://gerrit.hyperledger.org/r/#/c/9443/ makes cryptogen stop complaining that BCCSP isn't initialized https://gerrit.hyperledger.org/r/#/c/9411/ re-introduces a check in a unit test that was disabled

mastersingh24 (Wed, 17 May 2017 12:04:39 GMT):
trivial one for fabric-ca - https://gerrit.hyperledger.org/r/#/c/8975/ ( thx @yacovm for the +2)

muralisr (Wed, 17 May 2017 12:16:05 GMT):
I did a +2 and retracted... given @JonathanLevi comments, will wait for him to review signoff @mastersingh24 ^^^

greg.haskins (Wed, 17 May 2017 12:52:31 GMT):
trivial example/tool change: https://gerrit.hyperledger.org/r/#/c/9419/

sanchezl (Wed, 17 May 2017 13:17:29 GMT):
These just add some tests: • https://gerrit.hyperledger.org/r/#/c/9313/ • https://gerrit.hyperledger.org/r/#/c/9369/

muralisr (Wed, 17 May 2017 13:20:53 GMT):
@greg.haskins https://gerrit.hyperledger.org/r/#/c/9419 looks good... is https://jira.hyperledger.org/browse/FAB-3957 added to 3040 ? should it be ?

muralisr (Wed, 17 May 2017 13:21:47 GMT):
(or maybe I should read the release doc again :-) )

muralisr (Wed, 17 May 2017 13:23:39 GMT):
Ok this does not fall into the `Changes that affect production code but which have a more complex resolution` which are the ones that would need closer scrutiny... will merge 9419

greg.haskins (Wed, 17 May 2017 13:24:35 GMT):
@muralisr i am not sure what the current plan is: but my understanding and operating assumption is that things like doc/tools/examples which do not materially impact the production paths are more relaxed

muralisr (Wed, 17 May 2017 13:24:54 GMT):
thanks Greg.. that's my read too

greg.haskins (Wed, 17 May 2017 13:25:13 GMT):
and this is all w.r.t. /examples/cluster, which as far as I know, I am the only current consumer

yacovm (Wed, 17 May 2017 13:25:18 GMT):
This is a tool that greg added recently

yacovm (Wed, 17 May 2017 13:25:22 GMT):
no one uses it

yacovm (Wed, 17 May 2017 13:25:27 GMT):
(yet!)

greg.haskins (Wed, 17 May 2017 13:25:30 GMT):
_sniff_

muralisr (Wed, 17 May 2017 13:26:20 GMT):
one thing

muralisr (Wed, 17 May 2017 13:26:23 GMT):

Message Attachments

muralisr (Wed, 17 May 2017 13:26:45 GMT):
wonder they failed and was skipped and how it was skipeed

greg.haskins (Wed, 17 May 2017 13:27:11 GMT):
note that /examples/cluster is not consumed in any CI verification, so any failures are unrelated as far as I can tell

muralisr (Wed, 17 May 2017 13:27:52 GMT):
right. no, its just that that was interesting

greg.haskins (Wed, 17 May 2017 13:28:15 GMT):
yeah, it seems like CI is really flaky this week in general

muralisr (Wed, 17 May 2017 13:28:20 GMT):
ok

greg.haskins (Wed, 17 May 2017 13:28:34 GMT):
ive noted numerous failures in things like /examples/cluster CRs that should not be able to break CI

greg.haskins (Wed, 17 May 2017 13:28:53 GMT):
like 3 out of 4 runs failing, etc

muralisr (Wed, 17 May 2017 13:28:58 GMT):
will check with @rameshthoomu when he has some breathing space

rameshthoomu (Wed, 17 May 2017 14:22:19 GMT):
@muralisr @greg.haskins CI skips failure result on behave, verify z (unit-tests) and end-2-end test failures.. Initially we have added this and push -1 only incase of unit-test failures on x86..

rameshthoomu (Wed, 17 May 2017 14:24:03 GMT):
Not a big change from CI to enable voting.. Shall I enable voting on all these tests?

muralisr (Wed, 17 May 2017 14:36:41 GMT):
@rameshthoomu for a while there they were enabled right ?

rameshthoomu (Wed, 17 May 2017 14:37:20 GMT):
No..

rameshthoomu (Wed, 17 May 2017 14:38:30 GMT):
We had this discussion a week back in scrum call but not decided whether to enable them or not..

jimthematrix (Wed, 17 May 2017 14:49:03 GMT):
@rameshthoomu we should enable voting on the end-2-end tests, we've had too many breaks that could have been caught with end2end's failure that was simply ignored

rameshthoomu (Wed, 17 May 2017 14:52:20 GMT):
yes.. please note we are running end-to-end (java) , end-to-end (CLI), and end-to-end (node) in this job https://jenkins.hyperledger.org/view/fabric/job/fabric-verify-end-2-end-x86_64/

rameshthoomu (Wed, 17 May 2017 14:53:57 GMT):
also we run behave functional tests and unit-tests on z platform

muralisr (Wed, 17 May 2017 14:57:11 GMT):
@rameshthoomu for a while the e2e CLI tests were successful. they have started failing again... we need to fix the cause of failures before enable voiting but agree with @jimthematrix better to enable as soon as possible

rameshthoomu (Wed, 17 May 2017 14:57:44 GMT):
yes.. I see behave tests are working as expected on latest commits..

rameshthoomu (Wed, 17 May 2017 14:58:25 GMT):
and will enable once the e2e tests are back to work..

jimthematrix (Wed, 17 May 2017 15:00:02 GMT):
agree with Murali, whether the recent failures are in the product code or in end2end test code, they should be treated as top priority bugs to fix

yacovm (Wed, 17 May 2017 15:15:12 GMT):
3 change sets: https://gerrit.hyperledger.org/r/#/c/9405/ Fixes a UT failure https://gerrit.hyperledger.org/r/#/c/9443/ makes cryptogen stop complaining that BCCSP isn't initialized https://gerrit.hyperledger.org/r/#/c/9411/ re-introduces a check in a unit test that was disabled

yacovm (Wed, 17 May 2017 15:15:12 GMT):
3 change sets: https://gerrit.hyperledger.org/r/#/c/9443/ makes cryptogen stop complaining that BCCSP isn't initialized https://gerrit.hyperledger.org/r/#/c/9411/ re-introduces a check in a unit test that was disabled

yacovm (Wed, 17 May 2017 15:15:12 GMT):
2 change sets: https://gerrit.hyperledger.org/r/#/c/9443/ makes cryptogen stop complaining that BCCSP isn't initialized https://gerrit.hyperledger.org/r/#/c/9411/ re-introduces a check in a unit test that was disabled

greg.haskins (Wed, 17 May 2017 15:41:09 GMT):
another trivial one: https://gerrit.hyperledger.org/r/#/c/9413/

greg.haskins (Wed, 17 May 2017 15:41:13 GMT):
@muralisr ^^^

jimthematrix (Wed, 17 May 2017 15:56:47 GMT):
a few straight-forward node SDK ones: https://gerrit.hyperledger.org/r/9271 https://gerrit.hyperledger.org/r/9389 https://gerrit.hyperledger.org/r/9391 https://gerrit.hyperledger.org/r/9393

mastersingh24 (Wed, 17 May 2017 16:09:09 GMT):
[:thumbsup: ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=HEmX46FFM5Wjhv5FS) @jimthematrix

kostas (Wed, 17 May 2017 17:27:44 GMT):
These have already been 2x +2'd, can someone merge them? https://gerrit.hyperledger.org/r/#/c/9229/ https://gerrit.hyperledger.org/r/#/c/9231/

mastersingh24 (Wed, 17 May 2017 17:40:56 GMT):
@kostas - :couple:

mastersingh24 (Wed, 17 May 2017 17:41:01 GMT):
get it - they are merged ;)

kostas (Wed, 17 May 2017 17:41:38 GMT):
Hehe, cool! Thx Gari

scottz (Wed, 17 May 2017 17:51:06 GMT):

Message Attachments

nickgaski (Wed, 17 May 2017 19:24:28 GMT):
can we get this sucker in - https://gerrit.hyperledger.org/r/#/c/9417/2 - @cbf @dave.enyeart

mastersingh24 (Wed, 17 May 2017 19:57:58 GMT):
Hi folks! I finally made it through CI and would love to join some of my other friends in the codebase? Can someone please help me? https://gerrit.hyperledger.org/r/#/c/9421/

jeffgarratt (Wed, 17 May 2017 20:03:36 GMT):
@mastersingh24 even z, wow!!!

muralisr (Wed, 17 May 2017 20:04:32 GMT):
done @mastersingh24

muralisr (Wed, 17 May 2017 20:04:42 GMT):
(thank you for the 90% there :-) )

weeds (Wed, 17 May 2017 20:04:48 GMT):
what about nick's?

weeds (Wed, 17 May 2017 20:04:53 GMT):
seems important

muralisr (Wed, 17 May 2017 20:06:09 GMT):
its still under CI @weeds ... also good to have @dave.enyeart @cbf look there

muralisr (Wed, 17 May 2017 20:06:15 GMT):
on another set

muralisr (Wed, 17 May 2017 20:06:17 GMT):
https://chat.hyperledger.org/channel/fabric-pr-review?msg=WPQHzw6pMmAuDYufv

muralisr (Wed, 17 May 2017 20:06:32 GMT):
most of these are test/regression (some have been merged)

muralisr (Wed, 17 May 2017 20:07:16 GMT):
given they are non-core test items, seems it would be ok to merge without too much scrutiny (which would take a while....)

muralisr (Wed, 17 May 2017 20:07:36 GMT):
my +1 for ^^^

nickgaski (Wed, 17 May 2017 20:08:10 GMT):
while I'm begging, how about this one too - https://gerrit.hyperledger.org/r/#/c/9263/2 - @binhn @muralisr

weeds (Wed, 17 May 2017 20:08:25 GMT):
@binhn is on vacation

nickgaski (Wed, 17 May 2017 20:08:47 GMT):
good for him. 9263 is easy. upgrades the existing chaincode doc

weeds (Wed, 17 May 2017 20:08:51 GMT):
(although I would not be surprised if he lurks occasionally)

muralisr (Wed, 17 May 2017 20:09:14 GMT):
@nickgaski I took a look a while back... need to look again

mastersingh24 (Wed, 17 May 2017 22:42:31 GMT):
easy one - events from Will - https://gerrit.hyperledger.org/r/#/c/9299/

mastersingh24 (Wed, 17 May 2017 22:45:22 GMT):
@muralisr - is this ready - https://gerrit.hyperledger.org/r/#/c/9395/?

muralisr (Wed, 17 May 2017 22:48:53 GMT):
@mastersingh24 just pushed a few more coverage and removed WIP... should be ready after CI passes.

muralisr (Wed, 17 May 2017 22:51:28 GMT):
I don't know how this happened but that push got moved to https://gerrit.hyperledger.org/r/#/c/9493/

muralisr (Wed, 17 May 2017 22:51:49 GMT):
I did do the usual "--amend" and pushed

muralisr (Wed, 17 May 2017 22:52:18 GMT):
let me abandon https://gerrit.hyperledger.org/r/#/c/9395

muralisr (Wed, 17 May 2017 22:52:29 GMT):
and let's track https://gerrit.hyperledger.org/r/#/c/9493 please

cbf (Wed, 17 May 2017 23:08:40 GMT):
https://gerrit.hyperledger.org/r/#/c/9381/

cbf (Wed, 17 May 2017 23:09:20 GMT):
https://gerrit.hyperledger.org/r/#/c/9461/

cbf (Wed, 17 May 2017 23:27:08 GMT):
https://gerrit.hyperledger.org/r/#/c/9257/2

cbf (Wed, 17 May 2017 23:31:42 GMT):
https://gerrit.hyperledger.org/r/#/c/8889/

greg.haskins (Thu, 18 May 2017 01:33:29 GMT):
https://gerrit.hyperledger.org/r/#/c/9413/

greg.haskins (Thu, 18 May 2017 01:42:49 GMT):
needs 1 more : https://gerrit.hyperledger.org/r/#/c/9381/

yacovm (Thu, 18 May 2017 07:31:24 GMT):
https://gerrit.hyperledger.org/r/#/c/9475/ Unit test change set

yacovm (Thu, 18 May 2017 07:31:24 GMT):
https://gerrit.hyperledger.org/r/#/c/9475/ Unit test change set @mastersingh24 ?

rameshthoomu (Thu, 18 May 2017 09:28:03 GMT):
We have tried multiple options to publish tar balls to nexus snapshots/releases/staging URL's using maven from CI but none worked. As a workaround come up with the fix updated in the patch.. added detailed comment in the patch set;.. Please review https://gerrit.hyperledger.org/r/#/c/8939/ and approve please..

cbf (Thu, 18 May 2017 16:15:29 GMT):
@here https://jira.hyperledger.org/browse/FAB-3109 needs some review. It is a fix to an intermittently failing test. I believe that @yacovm and @C0rWin want it in, certainly we need to fix the intermittent CI failures. However, there are two approaches that we could take. one being simply skip the intermittently failing test for now. This does introduce about 200 LOC in the production code, but also adds lots of test code. Thoughts?

yacovm (Thu, 18 May 2017 16:16:21 GMT):
> It is a fix to an intermittently failing test. This is not the essence of the change set

yacovm (Thu, 18 May 2017 16:16:26 GMT):
The UT is a bonus

yacovm (Thu, 18 May 2017 16:16:26 GMT):
The UT failure fix is a bonus

yacovm (Thu, 18 May 2017 16:18:21 GMT):
This is a fix to a production problem

C0rWin (Thu, 18 May 2017 16:28:47 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=vFG4GMCMLgzd2mXHr) @cbf Test is a side effect, while CR takes care of more serious problem, 200 LOC is fare price for that ;)

yacovm (Thu, 18 May 2017 16:36:06 GMT):
The big picture is- anchor peer "connection" is a 2-phased thing, but the current code has only retry logic in the 1st phase and not in the 2nd. If the first step succeeded and the 2nd failed (as... happens in the unit tests sometimes) the peer is left alone, disconnected from the anchor peer. The change set simply makes this whole thing more robust, that's all.

yacovm (Thu, 18 May 2017 16:36:06 GMT):
The big picture is- connection to an anchor peer is a 2-phased thing, but the current code has only retry logic in the 1st phase and not in the 2nd. If the first step succeeded and the 2nd failed (as... happens in the unit tests sometimes) the peer is left alone, disconnected from the anchor peer. The change set simply makes this whole thing more robust, that's all.

nickgaski (Thu, 18 May 2017 17:39:03 GMT):
@here - I just pushed getting started for alpha2 - kindly bear in mind the urgency of this doc as you review and make comments - https://gerrit.hyperledger.org/r/#/c/9537/

latitiah (Thu, 18 May 2017 18:27:53 GMT):
Hi all, I have 3 +1s and a +2, can I get another? https://gerrit.hyperledger.org/r/#/c/8925/

rameshthoomu (Thu, 18 May 2017 20:36:17 GMT):
Hi all, need one more +2 on this https://gerrit.hyperledger.org/r/#/c/9529/

yacovm (Thu, 18 May 2017 21:06:12 GMT):
A few change sets related to *tests*: https://gerrit.hyperledger.org/r/#/c/9411/ re-introduces a test that was disabled, now (hopefully) fixed https://gerrit.hyperledger.org/r/#/c/9527/ fixes a UT https://gerrit.hyperledger.org/r/#/c/9405/ this one has 2 +2s, it may look like it touches production code but these 2 methods are just utility methods used only in test code.

yacovm (Thu, 18 May 2017 21:06:12 GMT):
A few change sets related to *tests*: https://gerrit.hyperledger.org/r/#/c/9411/ re-introduces a test that was disabled, now (hopefully) fixed https://gerrit.hyperledger.org/r/#/c/9527/ fixes a UT ( @cbf this time for sure, I saw it failing today (again, despite my earlier fix) so I changed the port numbers... ) https://gerrit.hyperledger.org/r/#/c/9405/ this one has 2 +2s, it may look like it touches production code but these 2 methods are just utility methods used only in test code.

muralisr (Thu, 18 May 2017 21:09:09 GMT):
@yacovm maybe wait a bit for https://gerrit.hyperledger.org/r/#/c/9411, just in case, you know, go routines did grow for some reason ... ? :-)

yacovm (Thu, 18 May 2017 21:10:10 GMT):
wait for what?

muralisr (Thu, 18 May 2017 21:13:46 GMT):
I thought maybe some more alpha2 fixes may be coming in... ? no ?

yacovm (Thu, 18 May 2017 21:14:06 GMT):
to the core/deliveryservice package?

yacovm (Thu, 18 May 2017 21:14:16 GMT):
by who?

yacovm (Thu, 18 May 2017 21:14:40 GMT):
Do you know of bugs in that package? :thinking:

muralisr (Thu, 18 May 2017 21:14:42 GMT):
we know there were doc and possibly script changes

muralisr (Thu, 18 May 2017 21:14:42 GMT):
we know there were doc and possibly pending script changes

muralisr (Thu, 18 May 2017 21:15:21 GMT):
so theres some room for other bug fixes too

muralisr (Thu, 18 May 2017 21:15:56 GMT):
nope, I don;t know of bugs in that package..

aambati (Thu, 18 May 2017 23:30:21 GMT):
@mastersingh24 @smithbk I have merged conflicts and got a good build for the CR https://gerrit.hyperledger.org/r/#/c/7725/ .. Please +2 again and merge

jimthematrix (Fri, 19 May 2017 00:32:22 GMT):
trivial one for sdk windows support: https://gerrit.hyperledger.org/r/#/c/9467/

muralisr (Fri, 19 May 2017 00:37:47 GMT):
trivial even for me, @jimthematrix ... submitted :-)

jeffgarratt (Fri, 19 May 2017 04:37:28 GMT):
@mastersingh24 @jyellick this one from kostas is ready https://gerrit.hyperledger.org/r/#/c/9495/

jimthematrix (Fri, 19 May 2017 13:15:00 GMT):
https://gerrit.hyperledger.org/r/#/c/9555/ - @nickgaski @cbf @mastersingh24 for https://jira.hyperledger.org/browse/FAB-2816, step1

cbf (Fri, 19 May 2017 13:44:06 GMT):
hi @jimthematrix regarding https://gerrit.hyperledger.org/r/#/c/9555/

cbf (Fri, 19 May 2017 13:45:01 GMT):
I think that this is fine on its face, but seems to me that a) it should BE the same for all SDKs/CLI

cbf (Fri, 19 May 2017 13:45:25 GMT):
and it basically provides a nice prose wrapper around what is already in getting_started.rst

cbf (Fri, 19 May 2017 13:46:35 GMT):
have you discussed with @odowdaibm ? seems like we should have a bootstrap development environment and then you can have an end-to-end example(s) off of this, or enter a tutorial for one or more of the SDKs

odowdaibm (Fri, 19 May 2017 13:46:35 GMT):
Has joined the channel.

jimthematrix (Fri, 19 May 2017 13:46:44 GMT):
_prose wrapper around what is already in getting_started.rst_ - you are right, it's meant to be a concise summary with pointers to the full blown version in the fabric doc, with the goal to get app developers started

cbf (Fri, 19 May 2017 13:47:20 GMT):
so, per @odowdaibm proposal (see mailing list) that's what he wants for getting_started.rst

jimthematrix (Fri, 19 May 2017 13:48:20 GMT):
ok, i can definitely ask @odowdaibm about it, good idea

cbf (Fri, 19 May 2017 13:48:25 GMT):
basically, I like the direction this, and Anthony's proposal are headed - a lot

cbf (Fri, 19 May 2017 13:48:37 GMT):
think there is some potential synergy

cbf (Fri, 19 May 2017 13:48:42 GMT):
super

cbf (Fri, 19 May 2017 13:49:15 GMT):
I have no problem merging this, but let's work on blending these

cbf (Fri, 19 May 2017 13:49:39 GMT):
merged

cbf (Fri, 19 May 2017 13:50:03 GMT):
if nothing else, we need alignment on the terminology

jimthematrix (Fri, 19 May 2017 13:51:12 GMT):
to be honest the main content for the "tutorials" I'm planning to do is mainly node SDK focused with code snippets ('this is how you enroll a user with fabric-ca, and this is how you load a user identity from pre-provisioned certs", as an example). this "overview" is necessary step1 but definitely not unique to node SDK (like you said)

jimthematrix (Fri, 19 May 2017 13:51:19 GMT):
thanks for merging it

odowdaibm (Fri, 19 May 2017 13:51:22 GMT):
I'm listening - very interested

jimthematrix (Fri, 19 May 2017 13:51:37 GMT):
hi Anthony!

odowdaibm (Fri, 19 May 2017 13:51:49 GMT):
hey Jim

jimthematrix (Fri, 19 May 2017 13:53:48 GMT):
could you take a look at the summary in https://gerrit.hyperledger.org/r/#/c/9555 and see if it'd be of value in your doc effort. also @nickgaski if you think there's a better way to host his I'm quite happy to move it somewhere else. but note that it should be very easy to find because it's focused on the developers who wants to get started coding but first have to get a target environment going

jimthematrix (Fri, 19 May 2017 13:53:48 GMT):
could you take a look at the summary in https://gerrit.hyperledger.org/r/#/c/9555 and see if it'd be of value in your doc effort. also @nickgaski

jimthematrix (Fri, 19 May 2017 13:54:38 GMT):
if you think there's a better way to host his I'm quite happy to move it somewhere else. but note that it should be very easy to find because it's focused on the developers who wants to get started coding but first have to get a target environment going

jimthematrix (Fri, 19 May 2017 13:54:38 GMT):
if you think there's a better way to host this I'm quite happy to move it somewhere else. but note that it should be very easy to find because it's focused on the developers who wants to get started coding but first have to get a target environment going

jimthematrix (Fri, 19 May 2017 13:55:56 GMT):
this is a better version to read: https://jimthematrix.github.io/tutorial-app-dev-env-setup.html

jimthematrix (Fri, 19 May 2017 13:56:48 GMT):
(once the merge CI is done it'll be automatically published to fabric-sdk-node.github.io)

cbf (Fri, 19 May 2017 13:57:36 GMT):
https://gerrit.hyperledger.org/r/#/c/9483/

cbf (Fri, 19 May 2017 13:58:38 GMT):
taking convo to #fabric-documentation

rameshthoomu (Fri, 19 May 2017 16:01:35 GMT):
Need review comments on this patch https://gerrit.hyperledger.org/r/#/c/9543... This will enable gerrit voting on fabric-behave, fabric-verify-z and fabric-end-2-end tests...

rameshthoomu (Fri, 19 May 2017 16:01:35 GMT):
Need review comments on this patch https://gerrit.hyperledger.org/r/#/c/9543... This will enable gerrit voting if fabric-behave, fabric-verify-z and fabric-end-2-end CI jobs fails.

latitiah (Fri, 19 May 2017 16:03:34 GMT):
I have 2 more CRs in need of +2's for the system behave tests and readme: https://gerrit.hyperledger.org/r/#/c/8841/ https://gerrit.hyperledger.org/r/#/c/9131/

jtclark (Fri, 19 May 2017 16:17:09 GMT):
Has joined the channel.

elli-androulaki (Fri, 19 May 2017 16:52:17 GMT):
Hi, regarding this https://chat.hyperledger.org/channel/fabric-peer-endorser-committer?msg=Sj9XDkR2gedne98dk

elli-androulaki (Fri, 19 May 2017 16:52:17 GMT):
Hi, regarding this https://chat.hyperledger.org/channel/fabric-peer-endorser-committer?msg=Sj9XDkR2gedne98dk Crypto squad's test coverage is already above 85%. Could maintainers assess whether you are satisfied with this coverage/need us to do something more?

elli-androulaki (Fri, 19 May 2017 16:52:17 GMT):
Hi, regarding this https://chat.hyperledger.org/channel/fabric-peer-endorser-committer?msg=Sj9XDkR2gedne98dk Crypto squad's test coverage is already above 85%. We have no pending CRs associated to increasing test coverage in crypto components. Could maintainers assess whether you are satisfied with this coverage/need us to do something more?

muralisr (Fri, 19 May 2017 16:54:24 GMT):
Hi @elli-androulaki

muralisr (Fri, 19 May 2017 16:54:33 GMT):
```6:14:53 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp [no test files] 16:15:03 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/factory 0.024s coverage: 37.7% of statements 16:15:03 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp/mocks [no test files] 16:18:12 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/pkcs11 182.506s coverage: 61.1% of statements 16:18:14 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/signer 0.080s coverage: 100.0% of statements 16:20:04 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/sw 105.466s coverage: 80.2% of statements 16:20:04 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp/sw/mocks [no test files]```

muralisr (Fri, 19 May 2017 16:55:47 GMT):
getting the other low ones there woud help boost the average :-) ... what do you think ?

muralisr (Fri, 19 May 2017 16:55:47 GMT):
getting the other low ones there woud help boost the aggregate :-) ... what do you think ?

muralisr (Fri, 19 May 2017 16:56:00 GMT):
and similar for any other crypto packages

elli-androulaki (Fri, 19 May 2017 16:56:11 GMT):
Hm, these are related to the HSM work. Not included in our components.

muralisr (Fri, 19 May 2017 16:56:21 GMT):
ah oh

muralisr (Fri, 19 May 2017 16:56:22 GMT):
ok

muralisr (Fri, 19 May 2017 16:56:26 GMT):
never mind then

muralisr (Fri, 19 May 2017 16:56:28 GMT):
sorry

elli-androulaki (Fri, 19 May 2017 16:56:51 GMT):
That said, are these numbers recent? Cause @adc helped these numbers increase...

elli-androulaki (Fri, 19 May 2017 16:56:51 GMT):
That said, are these numbers recent? Cause @adc helped these numbers to increase...

elli-androulaki (Fri, 19 May 2017 16:57:18 GMT):
Let me bring up the merged CR number.

muralisr (Fri, 19 May 2017 16:58:08 GMT):
I think you are right...

muralisr (Fri, 19 May 2017 16:58:12 GMT):
```15:10:21 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp [no test files] 15:10:29 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/factory 0.044s coverage: 87.3% of statements 15:10:30 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp/mocks [no test files] 15:12:42 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/pkcs11 127.159s coverage: 61.4% of statements 15:12:44 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/signer 0.069s coverage: 100.0% of statements 15:14:06 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/sw 77.711s coverage: 90.1% of statements 15:14:06 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp/sw/mocks [no test files] 15:14:08 unit-tests_1 | ok github.com/hyperledger/fabric/bccsp/utils 0.133s coverage: 87.0% of statements```

elli-androulaki (Fri, 19 May 2017 16:59:49 GMT):
Right :)

elli-androulaki (Fri, 19 May 2017 16:59:49 GMT):
ok!

elli-androulaki (Fri, 19 May 2017 16:59:49 GMT):
ok! (for completeness, the CR was https://gerrit.hyperledger.org/r/#/c/9455/)

elli-androulaki (Fri, 19 May 2017 17:04:25 GMT):
For HSM work there is this pending CR https://gerrit.hyperledger.org/r/#/c/9441 by @vpaprots (referring to bccsp/pkcs11 package). @vpaprots mentioned this CR would decrease the test coverage of that package so he is still working on it.

elli-androulaki (Fri, 19 May 2017 17:13:28 GMT):
Actually @yacovm pointed out this, which i missed: ``` 15:10:21 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp [no test files] Given this, we will work on test coverage of this package. Adding @adc in case he has something to add.

elli-androulaki (Fri, 19 May 2017 17:13:28 GMT):
Actually @yacovm pointed out this, which i missed: ``` 15:10:21 unit-tests_1 | ? github.com/hyperledger/fabric/bccsp [no test files] ``` Given this, we will work on test coverage of this package. Adding @adc in case he has something to add.

muralisr (Fri, 19 May 2017 17:13:56 GMT):
Can you copy the above in maintainers Elli ? just reailized we are in pr-review

elli-androulaki (Fri, 19 May 2017 17:14:34 GMT):
ok!

nickgaski (Fri, 19 May 2017 17:34:05 GMT):
Regarding this JIRA - https://jira.hyperledger.org/browse/FAB-4033 - do we really want people to compile from master branch? Another approach would be `git checkout v1.0.0-alpha2` `make docker` `make release-all` `git checkout master` . Thoughts?

mastersingh24 (Fri, 19 May 2017 18:19:17 GMT):
@nickgaski - the e2e in master must always work against master

mastersingh24 (Fri, 19 May 2017 18:20:09 GMT):
for people using the Docker images, as you know - we've put the e2e in the tarball for each platform

mastersingh24 (Fri, 19 May 2017 18:20:51 GMT):
We actually want to remove the doc from the archive as well - as people who just want to download and use fabric should be referring to RTD

mastersingh24 (Fri, 19 May 2017 18:21:33 GMT):
The only people who should be using the scripts in the master repo (or frankly any tag of the repo) are people doing development on fabric

vpaprots (Fri, 19 May 2017 18:31:30 GMT):
@yacovm @mastersingh24 @cbf would appreciate comments on http://gerrit.hyperledger.org/r/9441 (I also posted on FAB-3040). There is a lot of copied SW BCCSP code, with insufficient test coverage. My option is either copy even MORE code from SW BCCSP to improve the test coverage, or do as I did. While it looks like a big change (deleted 2k lines), all I did is compose SW BCCSP into PKCS11 BCCSP struct. I believe this is fairly low risk.

vpaprots (Fri, 19 May 2017 18:32:32 GMT):
I would appreciate direction there sooner, before I start adding more tests please.

yacovm (Fri, 19 May 2017 18:34:26 GMT):
Was it decided to go with the change?

yacovm (Fri, 19 May 2017 18:34:56 GMT):
or are you asking whether it should be weighted?

yacovm (Fri, 19 May 2017 18:34:56 GMT):
or are you asking whether that it be weighted?

yacovm (Fri, 19 May 2017 18:34:56 GMT):
or are you asking that it be weighted?

yacovm (Fri, 19 May 2017 18:37:23 GMT):
My opinion is that less code is better than more code, however I'm not sure about this specific change (didn't get a chance to review it).

yacovm (Fri, 19 May 2017 18:37:40 GMT):
I'd like to know what @adc thinks about this

vpaprots (Fri, 19 May 2017 18:38:26 GMT):
@yacovm Asking for opinions here.

vpaprots (Fri, 19 May 2017 18:40:01 GMT):
Too late in the day for @adc now, but he repeatedly urged me for exactly this change, even offering to do it himself, so don't see him objecting.

nickgaski (Fri, 19 May 2017 20:36:47 GMT):
https://gerrit.hyperledger.org/r/#/c/9263/ - I think it would be good to get this chaincode piece into the docs for this weekend

C0rWin (Fri, 19 May 2017 21:53:34 GMT):
https://gerrit.hyperledger.org/r/#/c/9405/ any objections to have it merged? affects only testing code and has +2 from me and @mastersingh24

kostas (Sat, 20 May 2017 12:59:13 GMT):
This should be good to go: https://gerrit.hyperledger.org/r/#/c/9495/

kostas (Sat, 20 May 2017 12:59:13 GMT):
This should be good to go now: https://gerrit.hyperledger.org/r/#/c/9495/

nickgaski (Sat, 20 May 2017 17:50:24 GMT):
@here - https://gerrit.hyperledger.org/r/#/c/9619/ - URGENT

jyellick (Sat, 20 May 2017 18:28:52 GMT):
Works for me on Linux

cbf (Sat, 20 May 2017 19:12:47 GMT):
https://gerrit.hyperledger.org/r/#/c/9483/

cbf (Sat, 20 May 2017 19:12:59 GMT):
https://gerrit.hyperledger.org/r/#/c/9509/

cbf (Sat, 20 May 2017 19:13:02 GMT):
two easy ones

nickgaski (Sat, 20 May 2017 19:40:21 GMT):
https://gerrit.hyperledger.org/r/#/c/9619/ - fixed the path to /releases - +2 please

muralisr (Sat, 20 May 2017 23:02:58 GMT):
@cbf more shim tests to bring it up to 78% coverage https://gerrit.hyperledger.org/r/#/c/9511/

muralisr (Sat, 20 May 2017 23:04:00 GMT):
I had to force V+1 as it kept failing in different CI each time - in all cases the shim tests themselves ran successfully

muralisr (Sat, 20 May 2017 23:14:43 GMT):
also @mastersingh24 ^^^ ... this is just some additions to previous UT in this area

muralisr (Sun, 21 May 2017 14:48:55 GMT):
a simple CR https://gerrit.hyperledger.org/r/#/c/9639/ which will hopefully take care of sporadic CI failures in peer/channel UT. Just pushed waiting for CI

yacovm (Sun, 21 May 2017 14:55:06 GMT):
@muralisr I already have one here ;) https://gerrit.hyperledger.org/r/#/c/9527/

muralisr (Sun, 21 May 2017 15:18:39 GMT):
ah

muralisr (Sun, 21 May 2017 15:18:45 GMT):
but 8050 ? :-)

yacovm (Sun, 21 May 2017 15:18:50 GMT):
yeah

yacovm (Sun, 21 May 2017 15:18:57 GMT):
what's the problem?

muralisr (Sun, 21 May 2017 15:19:19 GMT):
too close to "050" for someone else to use

yacovm (Sun, 21 May 2017 15:19:38 GMT):
too close?

muralisr (Sun, 21 May 2017 15:20:01 GMT):
someone else can easily choose 8050 for the same reason you did

muralisr (Sun, 21 May 2017 15:20:16 GMT):
not a big deal

muralisr (Sun, 21 May 2017 15:20:32 GMT):
I went and changed all ports

muralisr (Sun, 21 May 2017 15:20:40 GMT):
shall I abandon mine ?

yacovm (Sun, 21 May 2017 15:20:55 GMT):
If you could merge mine

muralisr (Sun, 21 May 2017 15:20:58 GMT):
ok

yacovm (Sun, 21 May 2017 15:21:00 GMT):
it'd be great :)

muralisr (Sun, 21 May 2017 15:21:01 GMT):
lets do that

yacovm (Sun, 21 May 2017 15:21:04 GMT):
cool

yacovm (Sun, 21 May 2017 15:21:16 GMT):
the other ports are just for show

yacovm (Sun, 21 May 2017 15:21:23 GMT):
they don't do anything

muralisr (Sun, 21 May 2017 15:21:40 GMT):
yea

muralisr (Sun, 21 May 2017 15:21:42 GMT):
noticed that

muralisr (Sun, 21 May 2017 15:21:58 GMT):
should I rebase yours to pick up the event skip ?

muralisr (Sun, 21 May 2017 15:22:01 GMT):
see the z failed

muralisr (Sun, 21 May 2017 15:22:06 GMT):
it might fail again

yacovm (Sun, 21 May 2017 15:22:08 GMT):
hmm?

yacovm (Sun, 21 May 2017 15:22:13 GMT):
why rebase mine?

yacovm (Sun, 21 May 2017 15:22:21 GMT):
it's verified

muralisr (Sun, 21 May 2017 15:22:42 GMT):
yea... was just curious to see if Z would complete with your fix

muralisr (Sun, 21 May 2017 15:22:48 GMT):
hard to tell if it keeps failing

yacovm (Sun, 21 May 2017 15:22:52 GMT):
I don't see why not

muralisr (Sun, 21 May 2017 15:23:35 GMT):
having it succeed will show for sure

muralisr (Sun, 21 May 2017 15:23:55 GMT):
lets do a quick rebase ?

yacovm (Sun, 21 May 2017 15:24:03 GMT):
Well but you changed the ports too

muralisr (Sun, 21 May 2017 15:24:05 GMT):
and we'll have all CIs work

yacovm (Sun, 21 May 2017 15:24:15 GMT):
and it succeeded no?

muralisr (Sun, 21 May 2017 15:24:28 GMT):
it succeeds sporadically

yacovm (Sun, 21 May 2017 15:24:35 GMT):
ok ok

yacovm (Sun, 21 May 2017 15:24:40 GMT):
I'll rebase

muralisr (Sun, 21 May 2017 15:24:40 GMT):
not that it always fails

muralisr (Sun, 21 May 2017 15:24:43 GMT):
I can

muralisr (Sun, 21 May 2017 15:24:48 GMT):
right from CI

muralisr (Sun, 21 May 2017 15:24:57 GMT):
from gerritt I mean

yacovm (Sun, 21 May 2017 15:25:03 GMT):
I did, can you +2 please?

muralisr (Sun, 21 May 2017 15:25:08 GMT):
ok

muralisr (Sun, 21 May 2017 15:25:53 GMT):
can you bear with me till the CI completes pretty please :-) :

muralisr (Sun, 21 May 2017 15:25:59 GMT):
promise will +2 at the end

yacovm (Sun, 21 May 2017 15:26:17 GMT):
:rolling_eyes:

muralisr (Sun, 21 May 2017 15:26:54 GMT):
:-)

jimthematrix (Mon, 22 May 2017 02:40:18 GMT):
trivial change: https://gerrit.hyperledger.org/r/#/c/9577/

yacovm (Mon, 22 May 2017 10:52:31 GMT):
Some unit test change sets: https://gerrit.hyperledger.org/r/#/c/9581/ https://gerrit.hyperledger.org/r/#/c/9583/ https://gerrit.hyperledger.org/r/#/c/9609/

yacovm (Mon, 22 May 2017 10:54:27 GMT):
This fixes a possible test failure due to concurrency https://gerrit.hyperledger.org/r/#/c/9405/ ( @C0rWin I lost your +2...) This fixes a false positive log WARN. https://gerrit.hyperledger.org/r/#/c/9633/

yacovm (Mon, 22 May 2017 10:54:27 GMT):
This fixes a possible test failure due to concurrency https://gerrit.hyperledger.org/r/#/c/9405/ ( @C0rWin and @mastersingh24 I lost your +2...) This fixes a false positive log WARN. https://gerrit.hyperledger.org/r/#/c/9633/

C0rWin (Mon, 22 May 2017 10:58:44 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=DL5TnK32KW8LeFf7e) @yacovm np, got another one :)

smithbk (Mon, 22 May 2017 12:28:46 GMT):
The following for fabric-ca ... thanks:

smithbk (Mon, 22 May 2017 12:28:52 GMT):
https://gerrit.hyperledger.org/r/#/c/9553/ - Fix -M option of fabric-ca-client (already has 2 +2's, just needs merging) https://gerrit.hyperledger.org/r/#/c/9535/ - Fix fvt test bug which causes transient false CI test failures https://gerrit.hyperledger.org/r/#/c/9563/ - Fix default expiration times https://gerrit.hyperledger.org/r/#/c/9479/ - Fix for registration with multiple attrs https://gerrit.hyperledger.org/r/#/c/9429/ - Improve an error message (needs another +2) https://gerrit.hyperledger.org/r/#/c/8919/ - Add TLS tests for LDAP https://gerrit.hyperledger.org/r/#/c/8993/ - Add TLS tests for mysql https://gerrit.hyperledger.org/r/#/c/9547/ - Update vendor for Fabric flogging (needs another +2) https://gerrit.hyperledger.org/r/#/c/7741/ - Fix max enrollment checking logic https://gerrit.hyperledger.org/r/#/c/9339/ - Improve server error handling (part 1) https://gerrit.hyperledger.org/r/#/c/9341/ - Improve server error handling (part 2) https://gerrit.hyperledger.org/r/#/c/9407/ - Test coverage of lib package to 85% (depends on 9341) https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling (depends on 9341)

smithbk (Mon, 22 May 2017 13:18:26 GMT):
and one more ...

smithbk (Mon, 22 May 2017 13:18:35 GMT):
https://gerrit.hyperledger.org/r/#/c/9235/ - Fix TLS support (needs another +2)

kostas (Mon, 22 May 2017 14:53:42 GMT):
https://chat.hyperledger.org/channel/fabric-pr-review?msg=AXGfWmyTYf5iF83Gm

cbf (Mon, 22 May 2017 14:56:31 GMT):
@here https://gerrit.hyperledger.org/r/#/c/9651/ is a refactor of the e2e_cli scripting

cbf (Mon, 22 May 2017 14:56:45 GMT):
it is still WIP, but feedback and testing welcomed

dolanor (Mon, 22 May 2017 15:18:46 GMT):
Has joined the channel.

dolanor (Mon, 22 May 2017 15:21:54 GMT):
Hello! What is the best way to get a PR merged (except for making it good to merge) ?

dolanor (Mon, 22 May 2017 15:24:00 GMT):
I made a push to gerrit, but except for the bot, nothing happened. I could think that you might lack the time to review all the commits. So if I personally review some other PR, would it help ? (by removing/merging other PRs, and thus, making more bandwidth available for the merger to focus on less tasks)

dolanor (Mon, 22 May 2017 15:24:26 GMT):
Or it wouldn't since I'm a newcomer and not really approved by anyone out there.

cbf (Mon, 22 May 2017 15:42:06 GMT):
@dolanor the maintainers have been pretty much heads down trying to get the release published, and dealing with last minute issues etc

cbf (Mon, 22 May 2017 15:42:46 GMT):
as such, we basically telegraphed that the only CRs that would get attention were relevant to the alpha2 release

cbf (Mon, 22 May 2017 15:44:22 GMT):
now that it is published, we should be returning to BAU for those items that are a) bug fixes that don't yield extensive change b) new tests that don't make extensive changes to production code, and c) those new tests and bug fixes that do make more extensive change to production code, but whcih the maintainers agree should be in the 1.0 release

cbf (Mon, 22 May 2017 15:47:48 GMT):
see bottom of https://wiki.hyperledger.org/projects/fabric/release_exit_criteria

jimthematrix (Mon, 22 May 2017 15:51:34 GMT):
@mastersingh24 @cbf @yacovm @binh

jimthematrix (Mon, 22 May 2017 15:51:34 GMT):
@mastersingh24 @cbf @yacovm @binhn node SDK changes: https://gerrit.hyperledger.org/r/#/c/6825/

cbf (Mon, 22 May 2017 15:51:50 GMT):
you rang?

jimthematrix (Mon, 22 May 2017 15:52:29 GMT):
just edited above

jimthematrix (Mon, 22 May 2017 15:53:16 GMT):
this one has been pending for a long time, finally was able to make it work thanks to the work by the CI team (in preparing the CI VMs with SoftHSM)

cbf (Mon, 22 May 2017 15:55:47 GMT):
really need to learn the Curly Principle ;-)

cbf (Mon, 22 May 2017 15:56:20 GMT):
https://www.youtube.com/watch?v=2k1uOqRb0HU

jimthematrix (Mon, 22 May 2017 16:14:09 GMT):
I realized this could be generating some controversy as we are not committing to HSM support in v1.0 (at least for node or java SDKs), the main reason I'd like to keep this in rather than pulling the code out is to use it to test the SDK's API pluggability design.

jimthematrix (Mon, 22 May 2017 16:14:44 GMT):
we can mark the implementation "experimental" if needed

jimthematrix (Mon, 22 May 2017 16:15:25 GMT):
the coding was done a long time ago but we have not been able to test it due to lack of support in the CI VMs.

jimthematrix (Mon, 22 May 2017 16:15:41 GMT):
@cbf ^^^

yacovm (Mon, 22 May 2017 16:17:35 GMT):
> to test the SDK's API pluggability design - how?

cbf (Mon, 22 May 2017 16:24:20 GMT):
@jimthematrix the tests fail for me

cbf (Mon, 22 May 2017 16:24:31 GMT):
I rebuild node_modules and got it to run, but fails

jimthematrix (Mon, 22 May 2017 16:25:09 GMT):
hi Chris, I assume you haven't installed SoftHSM the emulator?

jimthematrix (Mon, 22 May 2017 16:26:00 GMT):
at the top of the test/unit/pkcs11.js file there are instructions

jimthematrix (Mon, 22 May 2017 16:26:51 GMT):
``` // To run this test case, install SoftHSM2 library at this link: // https://wiki.opendnssec.org/display/SoftHSMDOCS/SoftHSM+Documentation+v2 // After installing the library, you need to initialize at least one token // which will be used below. The test case assumes you have configured slot 0 // with user pin = 98765432. // Sample configuration using softhsm2-util command line utility: // softhsm2-util --init-token --slot 0 --label "My token 1" so pin abcd user pin 98765432

cbf (Mon, 22 May 2017 16:30:16 GMT):
ahem

cbf (Mon, 22 May 2017 16:30:26 GMT):
this should be in the README then

cbf (Mon, 22 May 2017 16:33:13 GMT):
and frankly, you need to make the install instructions clearer than they have at that site https://wiki.opendnssec.org/display/SoftHSMDOCS/SoftHSM+Documentation+v2

cbf (Mon, 22 May 2017 16:33:18 GMT):
holy cow that's crap

jimthematrix (Mon, 22 May 2017 16:34:05 GMT):
;-) yeah not the best doc for sure

jimthematrix (Mon, 22 May 2017 16:34:44 GMT):
good point, I probably should have a switch to turn it off so everyone don't have to install softhsm when running locally

latitiah (Mon, 22 May 2017 17:08:30 GMT):
Hi! Can I get more +2s on https://gerrit.hyperledger.org/r/#/c/8841?

jimthematrix (Mon, 22 May 2017 18:07:29 GMT):
@cbf addressed your comments above: https://gerrit.hyperledger.org/r/#/c/6825/

cbf (Mon, 22 May 2017 18:27:16 GMT):
so, I started down this path, and installed openssl

cbf (Mon, 22 May 2017 18:27:26 GMT):
success! or so, I thought

cbf (Mon, 22 May 2017 18:27:38 GMT):
then went to configure SoftHSMv2 and bzzt

cbf (Mon, 22 May 2017 18:28:10 GMT):
checking for OpenSSL version... >= 1.0.0 checking for OpenSSL ECC support... Found P256, P384, and P521 checking for OpenSSL GOST support... Cannot find GOST engine configure: error: OpenSSL library has no GOST support

cbf (Mon, 22 May 2017 18:28:42 GMT):
ah, I see -disable-gost

cbf (Mon, 22 May 2017 18:28:49 GMT):
back to drawing board

jimthematrix (Mon, 22 May 2017 18:31:23 GMT):
;-)

jimthematrix (Mon, 22 May 2017 18:32:52 GMT):
yeah i added it to the readme already should've mentioned that to you

cbf (Mon, 22 May 2017 19:14:46 GMT):
still have multiple failures running gulp test

cbf (Mon, 22 May 2017 19:14:47 GMT):
1..737 # tests 737 # pass 630 # fail 107

cbf (Mon, 22 May 2017 19:15:42 GMT):
@jimthematrix ^^

yacovm (Mon, 22 May 2017 19:17:25 GMT):
@cbf @jimthematrix could you guys please +2 these unit test change sets please? https://gerrit.hyperledger.org/r/#/c/9609/ https://gerrit.hyperledger.org/r/#/c/9581/

yacovm (Mon, 22 May 2017 19:17:25 GMT):
@cbf @jimthematrix could you guys (or anyone else) please +2 these unit test change sets please? https://gerrit.hyperledger.org/r/#/c/9609/ https://gerrit.hyperledger.org/r/#/c/9581/

yacovm (Mon, 22 May 2017 19:18:54 GMT):
Also https://gerrit.hyperledger.org/r/#/c/9583/ (thanks for the +2 cbf)

jimthematrix (Mon, 22 May 2017 19:19:54 GMT):
@cbf details on the failure? i assume you have the target environment launched with `test/fixtures/docker-compose.yaml` against fabric master build?

muralisr (Mon, 22 May 2017 19:22:03 GMT):
a very easy UT CR https://gerrit.hyperledger.org/r/#/c/9659/ please

yacovm (Mon, 22 May 2017 19:22:49 GMT):
@muralisr license header year ;)

muralisr (Mon, 22 May 2017 19:23:08 GMT):
Argh ... come on yacov :-)

muralisr (Mon, 22 May 2017 19:23:13 GMT):
pushing shortl

muralisr (Mon, 22 May 2017 19:25:59 GMT):
thanks @yacovm ... done

yacovm (Mon, 22 May 2017 19:26:08 GMT):
I saw that, I was too late

yacovm (Mon, 22 May 2017 19:26:22 GMT):
uploaded 2 more comments

muralisr (Mon, 22 May 2017 19:42:38 GMT):
responded :-)

smithbk (Mon, 22 May 2017 21:48:25 GMT):
another fabric-ca: https://gerrit.hyperledger.org/r/#/c/9663 - Removing openldap image tarball

cbf (Mon, 22 May 2017 22:12:01 GMT):
add missing license header to shell scripts https://gerrit.hyperledger.org/r/#/c/9673/

cbf (Mon, 22 May 2017 22:12:25 GMT):
@greg.haskins please review, some I assigned copyright to you since you were primary author

greg.haskins (Tue, 23 May 2017 01:55:25 GMT):
@cbf had to rebase: https://gerrit.hyperledger.org/r/#/c/9379/

jimthematrix (Tue, 23 May 2017 02:08:48 GMT):
@cbf were you able to try https://gerrit.hyperledger.org/r/#/c/6825/ locally? to verify the tests impacted by this CR, you can run `gulp test-headless` so as to skip having to set up a local network for the integration suite (although setting one up should be trivial for you since you've done it before and have all the dependencies)

jimthematrix (Tue, 23 May 2017 04:08:49 GMT):
also https://gerrit.hyperledger.org/r/#/c/9681/ to replace the hashtable dependency that causes problems on windows and cloudfoundry node.js buildpacks, with a "native" associated array based approach

cbf (Tue, 23 May 2017 12:11:02 GMT):
1..598 # tests 598 # pass 591 # fail 7

cbf (Tue, 23 May 2017 12:11:09 GMT):
from running gulp test-headless

cbf (Tue, 23 May 2017 12:12:35 GMT):
@jimthematrix ^^

adc (Tue, 23 May 2017 12:33:40 GMT):
Hi @JonathanLevi, may we resurrect this https://gerrit.hyperledger.org/r/#/c/9279/ ?

dolanort (Tue, 23 May 2017 13:27:26 GMT):
Has joined the channel.

greg.haskins (Tue, 23 May 2017 13:34:46 GMT):
anyone: https://gerrit.hyperledger.org/r/#/c/9379/ ? I'd like to ensure this is merged before whatever the next release is, or we can't support kubernetes properly

smithbk (Tue, 23 May 2017 13:50:18 GMT):
Still need to make progress on the following fabric CA reviews ... thanks:

smithbk (Tue, 23 May 2017 13:50:23 GMT):
https://gerrit.hyperledger.org/r/#/c/9663/ - Remove openldap tarball (needs another +2) https://gerrit.hyperledger.org/r/#/c/9553/ - Fix -M option of fabric-ca-client (already has 2 +2's, just needs merging) https://gerrit.hyperledger.org/r/#/c/9535/ - Fix fvt test bug which causes transient false CI test failures https://gerrit.hyperledger.org/r/#/c/9563/ - Fix default expiration times https://gerrit.hyperledger.org/r/#/c/9479/ - Fix for registration with multiple attrs https://gerrit.hyperledger.org/r/#/c/9429/ - Improve an error message (needs another +2) https://gerrit.hyperledger.org/r/#/c/8919/ - Add TLS tests for LDAP https://gerrit.hyperledger.org/r/#/c/8993/ - Add TLS tests for mysql https://gerrit.hyperledger.org/r/#/c/9235/ - Fix TLS suppor https://gerrit.hyperledger.org/r/#/c/9547/ - Update vendor for Fabric flogging (needs another +2) https://gerrit.hyperledger.org/r/#/c/7741/ - Fix max enrollment checking logic https://gerrit.hyperledger.org/r/#/c/9339/ - Improve server error handling (part 1) https://gerrit.hyperledger.org/r/#/c/9341/ - Improve server error handling (part 2) https://gerrit.hyperledger.org/r/#/c/9407/ - Test coverage of lib package to 85% (depends on 9341) https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling (depends on 9341)

jimthematrix (Tue, 23 May 2017 14:25:56 GMT):
@cbf can you paste the errors?

muralisr (Tue, 23 May 2017 14:52:18 GMT):
@greg.haskins looking at https://gerrit.hyperledger.org/r/#/c/9379 now

muralisr (Tue, 23 May 2017 14:55:13 GMT):
@jimthematrix not sure if this is the same as what @cbf sees but the `# fail 7` is common. I see upgrade test fail on the e2e nodejs CI runs once a while which look as follows :

muralisr (Tue, 23 May 2017 14:55:24 GMT):
```23:41:20 # tests 80 23:41:20 # pass 73 23:41:20 # fail 7```

muralisr (Tue, 23 May 2017 14:55:35 GMT):
and the failure itself looks like this :

muralisr (Tue, 23 May 2017 14:56:15 GMT):
```23:41:19 ***** U P G R A D E flow: query chaincode ***** 23:41:19 # getMember, name: admin, client.getUserContext(admin, true) 23:41:19 info: [utils.CryptoKeyStore]: This class requires a CryptoKeyStore to save keys, using the store: {"opts":{"path":"/tmp/hfc/hfc-test-kvs_peerOrg2"}} 23:41:19 info: [Client.js]: Successfully loaded user "admin" from local key value store 23:41:19 ok 73 Successfully loaded member from persistence 23:41:19 not ok 74 checking query results are correct that user b has 410 now after the move 23:41:19 --- 23:41:19 operator: equal 23:41:19 expected: '410' 23:41:19 actual: '400' 23:41:19 at: Client.newDefaultKeyValueStore.then.then.then (/w/workspace/fabric-verify-end-2-end-x86_64/gopath/src/github.com/hyperledger/fabric-sdk-node/test/integration/e2e/e2eUtils.js:750:8) 23:41:19 ... 23:41:19 not ok 75 checking query results are correct that user b has 410 now after the move 23:41:19 --- 23:41:19 operator: equal 23:41:19 expected: '410' 23:41:19 actual: '400' 23:41:19 at: Client.newDefaultKeyValueStore.then.then.then (/w/workspace/fabric-verify-end-2-end-x86_64/gopath/src/github.com/hyperledger/fabric-sdk-node/test/integration/e2e/e2eUtils.js:750:8) 23:41:19 ...```

muralisr (Tue, 23 May 2017 14:56:28 GMT):
the above from https://jenkins.hyperledger.org/job/fabric-verify-end-2-end-x86_64/3526/consoleFull

muralisr (Tue, 23 May 2017 14:56:47 GMT):
^^^ @jimthematrix

jimthematrix (Tue, 23 May 2017 15:16:39 GMT):
@muralisr thanks for bringing this up, I investigated that yesterday from your ping. couldn't reproduce it locally or getting CI to fail the same way again. so not sure what to make of it

muralisr (Tue, 23 May 2017 15:16:53 GMT):
ok

muralisr (Tue, 23 May 2017 15:17:31 GMT):
just saw the common `# fail 7` and thought worth mentioning

muralisr (Tue, 23 May 2017 15:18:07 GMT):
and u r right, this happens sporadically

rennman (Tue, 23 May 2017 15:18:23 GMT):
Has joined the channel.

jimthematrix (Tue, 23 May 2017 15:32:50 GMT):
thanks it could well be that, @cbf? if both of you are able to reproduce it, I'm really curious what it is that is different b/w your environments and mine

cbf (Tue, 23 May 2017 15:34:17 GMT):
well, I think that the key thing is that there SHOULDN"T be a difference;-) @jimthematrix

jimthematrix (Tue, 23 May 2017 15:48:09 GMT):
agreed, but still trying to decide if what you are seeing is the same as what Murali pasted above

jimthematrix (Tue, 23 May 2017 15:49:17 GMT):
can you paste the errors from the test run? they should be clearly marked with a distinctive color (dark orange-ish)

rameshthoomu (Tue, 23 May 2017 16:43:16 GMT):
https://gerrit.hyperledger.org/r/#/c/9473/ && https://gerrit.hyperledger.org/r/#/c/9477/ need one more +2

muralisr (Tue, 23 May 2017 17:03:46 GMT):
@rameshthoomu merged both... looked good at high level (didn't actually run the test myself)

rameshthoomu (Tue, 23 May 2017 17:09:05 GMT):
Will include these in weekly or long runs

rameshthoomu (Tue, 23 May 2017 17:09:17 GMT):
Will give you an update

rameshthoomu (Tue, 23 May 2017 20:39:04 GMT):
@greg.haskins need your review on this patch https://jira.hyperledger.org/browse/FAB-3918

rameshthoomu (Tue, 23 May 2017 20:39:04 GMT):
@greg.haskins need your review on this patch https://gerrit.hyperledger.org/r/#/c/9387/ & https://gerrit.hyperledger.org/r/#/c/9385/ (https://jira.hyperledger.org/browse/FAB-3918)

greg.haskins (Tue, 23 May 2017 20:42:27 GMT):
looks like these are dupped out with https://gerrit.hyperledger.org/r/#/c/9197/ https://gerrit.hyperledger.org/r/#/c/9191/

greg.haskins (Tue, 23 May 2017 20:42:42 GMT):
@harrijk do you care which?

harrijk (Tue, 23 May 2017 20:44:54 GMT):
They are different. One for fabric (.basimage-release) and one for fabric-ca (Makefile change base image version #fabric-maintainers

harrijk (Tue, 23 May 2017 20:45:12 GMT):
Slight wording change

harrijk (Tue, 23 May 2017 20:47:14 GMT):
After seeing the above message, I understand the meaning of "dup". :wink:

harrijk (Tue, 23 May 2017 20:47:14 GMT):
After seeing the above messages, I understand the meaning of "dup". :wink:

harrijk (Tue, 23 May 2017 20:47:48 GMT):
I don't care which version gets put in.

greg.haskins (Tue, 23 May 2017 20:49:07 GMT):
done

greg.haskins (Tue, 23 May 2017 20:49:12 GMT):
needs one more: https://gerrit.hyperledger.org/r/#/c/9673/

cbf (Tue, 23 May 2017 21:53:09 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/9735/

cbf (Tue, 23 May 2017 21:53:18 GMT):
skips a failing UT test

latitiah (Tue, 23 May 2017 22:16:10 GMT):
Needs 1 more +2: https://gerrit.hyperledger.org/r/#/c/9131

yacovm (Tue, 23 May 2017 22:17:43 GMT):
`core/policy` unit tests https://gerrit.hyperledger.org/r/#/c/9689/

muralisr (Tue, 23 May 2017 23:12:19 GMT):
a bug fix that'll help fix some of the CI failures please https://gerrit.hyperledger.org/r/#/c/9721/

baohua (Wed, 24 May 2017 01:42:53 GMT):
This patchset got two +2, welcome for further review :) https://gerrit.hyperledger.org/r/#/c/9057/

baohua (Wed, 24 May 2017 02:01:01 GMT):
And 2 enhancement/checking patchsets for 1.0 quality: https://gerrit.hyperledger.org/r/#/c/8873/; https://gerrit.hyperledger.org/r/#/c/8861/

adc (Wed, 24 May 2017 07:36:04 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/9689/ . It improves test coverage of the core/policy package. Thanks :)

smithbk (Wed, 24 May 2017 12:08:56 GMT):
fabric-ca CRs still needing review:

smithbk (Wed, 24 May 2017 12:09:01 GMT):
https://gerrit.hyperledger.org/r/#/c/9663/ - Remove openldap tarball (needs another +2) https://gerrit.hyperledger.org/r/#/c/9535/ - Fix fvt test bug which causes transient false CI test failures https://gerrit.hyperledger.org/r/#/c/9563/ - Fix default expiration times https://gerrit.hyperledger.org/r/#/c/9479/ - Fix for registration with multiple attrs https://gerrit.hyperledger.org/r/#/c/8919/ - Add TLS tests for LDAP https://gerrit.hyperledger.org/r/#/c/8993/ - Add TLS tests for mysql https://gerrit.hyperledger.org/r/#/c/9235/ - Fix TLS support https://gerrit.hyperledger.org/r/#/c/9533/ - Intermediate CA restriction on CN https://gerrit.hyperledger.org/r/#/c/9579/ - Fix duplicate flags registered for Hosts https://gerrit.hyperledger.org/r/#/c/9547/ - Update vendor for Fabric flogging (needs another +2) https://gerrit.hyperledger.org/r/#/c/7741/ - Fix max enrollment checking logic https://gerrit.hyperledger.org/r/#/c/9339/ - Improve server error handling (part 1) https://gerrit.hyperledger.org/r/#/c/9341/ - Improve server error handling (part 2) https://gerrit.hyperledger.org/r/#/c/9407/ - Test coverage of lib package to 85% (depends on 9341) https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling (depends on 9341)

cbf (Wed, 24 May 2017 13:14:00 GMT):
@smithbk https://gerrit.hyperledger.org/r/#/c/9579/2 needs rebase

cbf (Wed, 24 May 2017 13:14:11 GMT):
missing dependency cannot be merged

cbf (Wed, 24 May 2017 13:18:39 GMT):
https://gerrit.hyperledger.org/r/#/c/9407/ needs rebase

cbf (Wed, 24 May 2017 13:36:56 GMT):
https://gerrit.hyperledger.org/r/#/c/9735/ needs some love please

cbf (Wed, 24 May 2017 13:37:46 GMT):
also https://gerrit.hyperledger.org/r/#/c/9733/ is an easy one - remove vendored test dependency (whcih we don't need) that has incompatible license

baohua (Wed, 24 May 2017 14:15:45 GMT):
Has left the channel.

jimthematrix (Wed, 24 May 2017 14:36:20 GMT):
https://gerrit.hyperledger.org/r/#/c/9749/ - based on community feedback

jimthematrix (Wed, 24 May 2017 14:37:45 GMT):
also, @cbf can we get https://gerrit.hyperledger.org/r/#/c/6825/ merged please? it's been reliably running successfully on CI (last 4 runs on that CR)

wlahti (Wed, 24 May 2017 16:22:27 GMT):
Need one more review of https://gerrit.hyperledger.org/r/#/c/9661/ (unit tests for QSCC) whenever a maintainer has a moment.

jimthematrix (Wed, 24 May 2017 19:07:20 GMT):
trivial change to add logging only in tests for diagnosis: https://gerrit.hyperledger.org/r/#/c/9763/, @muralisr

muralisr (Wed, 24 May 2017 19:10:56 GMT):
done @jimthematrix (thanks!)

jimthematrix (Wed, 24 May 2017 19:11:14 GMT):
thanks

cbf (Wed, 24 May 2017 19:40:21 GMT):
https://gerrit.hyperledger.org/r/#/c/9733/ needs love please

cbf (Wed, 24 May 2017 20:42:42 GMT):
https://gerrit.hyperledger.org/r/#/c/9709/ needs lovin

cbf (Wed, 24 May 2017 21:15:44 GMT):
https://gerrit.hyperledger.org/r/#/c/9775/ - replace the raw.github URL with a goo.gl shortened URL from which we can track download analytics

cbf (Wed, 24 May 2017 21:35:32 GMT):
https://gerrit.hyperledger.org/r/#/c/9687/ could also use love while it is NOT in conflict with other CRs, please

cbf (Wed, 24 May 2017 21:36:05 GMT):
@smithbk https://gerrit.hyperledger.org/r/#/c/9677/ does same for fabric-ca

jimthematrix (Wed, 24 May 2017 23:18:28 GMT):
https://gerrit.hyperledger.org/r/#/c/9749 - based on community feedback

jimthematrix (Wed, 24 May 2017 23:18:28 GMT):
https://gerrit.hyperledger.org/r/#/c/9749 - also needs some love please, it's done based on community feedback

jiangyaoguo (Thu, 25 May 2017 01:23:48 GMT):
https://gerrit.hyperledger.org/r/#/c/9683/ A

jiangyaoguo (Thu, 25 May 2017 01:24:01 GMT):
easy legacy code clean

jimthematrix (Thu, 25 May 2017 02:26:13 GMT):
@muralisr @cbf https://gerrit.hyperledger.org/r/#/c/9783/ - for more diagnosis code in tests to investigate the intermittent upgrade failures in fabric end-2-end CI

muralisr (Thu, 25 May 2017 02:57:10 GMT):
done @jimthematrix

jimthematrix (Thu, 25 May 2017 13:20:50 GMT):
thanks Murali!

jimthematrix (Thu, 25 May 2017 13:22:12 GMT):
any takers for https://gerrit.hyperledger.org/r/#/c/9749? it's done based on community feedback so that fabric-ca-client can be completely self-sufficient in managing user persistence (well, this is step1, another simpler CR following)

harrijk (Thu, 25 May 2017 13:43:11 GMT):
bccsp/pkcs11 coverage CRs: http://gerrit.hyperledger.org/r/9777 http://gerrit.hyperledger.org/r/9779 http://gerrit.hyperledger.org/r/9781 https://gerrit.hyperledger.org/r/#/c/9441 ( pre-req for above CRs) I'd appreciate any feedback. Thanks.

cbf (Thu, 25 May 2017 14:15:59 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/9775/

jeffgarratt (Thu, 25 May 2017 18:15:47 GMT):
@binhn @muralisr @kostas precursor to subsequent bootstrap changes wrt to anchor peers and governance options https://gerrit.hyperledger.org/r/#/c/9809/

cbf (Thu, 25 May 2017 21:50:58 GMT):
@here would appreciate some testing of this CR https://gerrit.hyperledger.org/r/#/c/9811/

cbf (Thu, 25 May 2017 21:51:34 GMT):
have made changes with @tongli to limit unit-test execution to affected packages only

tongli (Thu, 25 May 2017 21:51:35 GMT):
Has joined the channel.

cbf (Thu, 25 May 2017 21:51:57 GMT):
also replaced gocov with go test -cover as it performs much better

cbf (Thu, 25 May 2017 21:52:16 GMT):
would especially appreciate windows and linux testing

cbf (Thu, 25 May 2017 21:53:27 GMT):
note new target in Makefile 'verify' will only test packages in the scope of the change

yacovm (Thu, 25 May 2017 21:53:49 GMT):
Why would we want CI to run just the packages that changed?

yacovm (Thu, 25 May 2017 21:54:13 GMT):
I think it's an un-necessary risk. What is the gain here? merge CRs faster?

cbf (Thu, 25 May 2017 21:54:40 GMT):
two step process - on submit CR, runs subset, on merge will run full pass and we'll revert merged patches that fail full CI

yacovm (Thu, 25 May 2017 21:54:50 GMT):
auto-revert?

yacovm (Thu, 25 May 2017 21:54:53 GMT):
or manual?

cbf (Thu, 25 May 2017 21:54:56 GMT):
yes

cbf (Thu, 25 May 2017 21:55:31 GMT):
of course, if ppl don't agree, the change is there for local CI passes to be much more efficient

cbf (Thu, 25 May 2017 21:56:14 GMT):
this doesn't change the end-to-end and bdd CI jobs

cbf (Thu, 25 May 2017 21:56:16 GMT):
just UT

cbf (Thu, 25 May 2017 21:56:35 GMT):
actually, this step changes nothing in CI

yacovm (Thu, 25 May 2017 21:56:39 GMT):
yeah but e2e doesn't test anything but the super-optimistic path

cbf (Thu, 25 May 2017 21:56:47 GMT):
understood

cbf (Thu, 25 May 2017 21:57:17 GMT):
many if not most large OSS projects revert to either a smoke test first pass or something like this

C0rWin (Thu, 25 May 2017 21:57:49 GMT):
IMO it's better to invest effort trying to improve UT, rather to scoping them for CR specific packages

C0rWin (Thu, 25 May 2017 21:58:04 GMT):
like trying to parallelize them

C0rWin (Thu, 25 May 2017 21:58:11 GMT):
remove sleeps

yacovm (Thu, 25 May 2017 21:58:56 GMT):
1) Well if I have package `a` that imports package `b` and calls `b.F()` and now `b.F()` is removed, master is broken until it auto-reverts. 2) Our UTs are still brittle. That means false-negatives, and auto-reverts right?

yacovm (Thu, 25 May 2017 21:59:28 GMT):
@C0rWin I tried parallelizing them, but the minions that run in CI just couldn't handle the load :(

C0rWin (Thu, 25 May 2017 22:00:19 GMT):
:/

C0rWin (Thu, 25 May 2017 22:04:07 GMT):
@cbf will merge of CR-9811 mean we gonna switch to using it in CI?

C0rWin (Thu, 25 May 2017 22:04:20 GMT):
or it will be an option for meanwhile?

cbf (Thu, 25 May 2017 22:07:35 GMT):
https://gerrit.hyperledger.org/r/#/c/9799/ could use some love

cbf (Thu, 25 May 2017 22:07:59 GMT):
@C0rWin it is an option

cbf (Thu, 25 May 2017 22:08:31 GMT):
AFAIK, @rameshthoomu has not begun the ci-management changes

cbf (Thu, 25 May 2017 22:08:58 GMT):
if this merges, it can be used to speed up local unit-tests

C0rWin (Thu, 25 May 2017 22:08:59 GMT):
well, so worth to merge it and to use for local development

cbf (Thu, 25 May 2017 22:09:05 GMT):
and leave at that

C0rWin (Thu, 25 May 2017 22:09:05 GMT):
yeah

cbf (Thu, 25 May 2017 22:09:37 GMT):
I would like to do the auto-revert regardless

cbf (Thu, 25 May 2017 22:09:58 GMT):
but I think that we can and should adopt a two phase process

C0rWin (Thu, 25 May 2017 22:10:04 GMT):
can get rid of `TEST_PKGS`

cbf (Thu, 25 May 2017 22:10:10 GMT):
yes

cbf (Thu, 25 May 2017 22:10:29 GMT):
except the CR basically populates it for you if you run make verify

mastersingh24 (Thu, 25 May 2017 22:38:46 GMT):
[ Why?](https://chat.hyperledger.org/channel/fabric-pr-review?msg=uFy8b7soinznhnsox) @C0rWin

mastersingh24 (Thu, 25 May 2017 22:38:46 GMT):
[ Why? I use this all the time. Or are you saying we can get rid of it one we make it possible to just do go test everywhere?](https://chat.hyperledger.org/channel/fabric-pr-review?msg=uFy8b7soinznhnsox) @C0rWin

C0rWin (Thu, 25 May 2017 22:39:24 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=zGo2qQAjHumZBNdDx) @mastersingh24 do not get me wrong :)

C0rWin (Thu, 25 May 2017 22:39:45 GMT):
all I meant to say is the with CR-9811

C0rWin (Thu, 25 May 2017 22:39:51 GMT):
no need to handle it manually

mastersingh24 (Thu, 25 May 2017 22:40:12 GMT):
ah - gotcha ;)

C0rWin (Thu, 25 May 2017 22:40:49 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=8PPXtMEc2TEN7Eyus) @mastersingh24 for now I cannot test locally my changes w/o using `TEST_PKGS`

C0rWin (Thu, 25 May 2017 22:41:14 GMT):
otherwise I will have to wait all tests to complete for 40 mins at least

cbf (Fri, 26 May 2017 00:29:46 GMT):
https://gerrit.hyperledger.org/r/#/c/9807/ needs some love please

cbf (Fri, 26 May 2017 00:29:55 GMT):
it's also an easy one

muralisr (Fri, 26 May 2017 01:04:01 GMT):
thanks to @jimthematrix helping figuring out a bad change in this UT. Its now ready to go https://gerrit.hyperledger.org/r/#/c/9645/

cbf (Fri, 26 May 2017 01:09:59 GMT):
@muralisr no offense, but this is a rather significant refactor and hence review-needed

muralisr (Fri, 26 May 2017 01:10:21 GMT):
@cbf sure

cbf (Fri, 26 May 2017 01:10:26 GMT):
the -2 is not a negative reflection of the change, just that we need to minimize risk

muralisr (Fri, 26 May 2017 01:10:33 GMT):
understood

muralisr (Fri, 26 May 2017 01:11:13 GMT):
the goal was to refactor to reduce repetitive code

muralisr (Fri, 26 May 2017 01:11:24 GMT):
and so increas UT surface

muralisr (Fri, 26 May 2017 01:11:40 GMT):
but definitely

muralisr (Fri, 26 May 2017 01:12:40 GMT):

Message Attachments

muralisr (Fri, 26 May 2017 01:12:52 GMT):
that tells the story

jimthematrix (Fri, 26 May 2017 02:12:03 GMT):
for https://gerrit.hyperledger.org/r/#/c/9749/ - trying again to see if anybody would be interested in reviewing and merging, it's been hanging out for 2 days. even though the CR looks big, the net change is really just adding "newDefaultKeyValueStore()" to FabricCAClientImpl. I had to do a bit of code refactoring though, because that class and Client.js end up having quite a few common properties and methods, so I created a comment base class BaseClient.js that both inherit from. about half of the code changes are in tests

yacovm (Fri, 26 May 2017 13:19:41 GMT):
Bug fixes to be reviewed and merged: https://gerrit.hyperledger.org/r/#/c/9119/ Mutual TLS https://gerrit.hyperledger.org/r/#/c/9637/ StateInfo expiration related bug fix https://gerrit.hyperledger.org/r/#/c/9753/ identities expiration related bug fix https://gerrit.hyperledger.org/r/#/c/9691/ Prevent logging of the entire pull update to the log. In case of blocks - this may blow up the log with binary data. *Lots* of binary data.

smithbk (Fri, 26 May 2017 13:26:12 GMT):
fabric-ca CRs needing review:

smithbk (Fri, 26 May 2017 13:26:15 GMT):
https://gerrit.hyperledger.org/r/#/c/9805/ - Workaround for panic due to libc bug https://gerrit.hyperledger.org/r/#/c/9663/ - Remove openldap tarball (needs another +2) https://gerrit.hyperledger.org/r/#/c/9563/ - Fix default expiration times https://gerrit.hyperledger.org/r/#/c/9479/ - Fix for registration with multiple attrs https://gerrit.hyperledger.org/r/#/c/7741/ - Fix max enrollment checking logic https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling

cbf (Fri, 26 May 2017 13:28:12 GMT):
could use some love please https://gerrit.hyperledger.org/r/#/c/9211/

rameshthoomu (Fri, 26 May 2017 13:44:51 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/9723/

smithbk (Fri, 26 May 2017 14:19:07 GMT):
A couple more read for fabric-ca. Here is the new list:

smithbk (Fri, 26 May 2017 14:19:10 GMT):
https://gerrit.hyperledger.org/r/#/c/9805/ - Workaround for panic due to libc bug https://gerrit.hyperledger.org/r/#/c/9663/ - Remove openldap tarball (needs another +2) https://gerrit.hyperledger.org/r/#/c/9563/ - Fix default expiration times https://gerrit.hyperledger.org/r/#/c/9479/ - Fix for registration with multiple attrs https://gerrit.hyperledger.org/r/#/c/7741/ - Fix max enrollment checking logic https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling https://gerrit.hyperledger.org/r/#/c/9849/ - Fix typo in error message https://gerrit.hyperledger.org/r/#/c/9847/ - Fix leaking authority to delegate

aambati (Fri, 26 May 2017 14:29:21 GMT):
@muralisr @binhn I need your help review https://gerrit.hyperledger.org/r/8913 and https://gerrit.hyperledger.org/r/9285, you had +2d them at some point. I have rebased and able to reverify them few time. Need you to review one more time and +2 them again

aambati (Fri, 26 May 2017 14:30:05 GMT):
@muralisr @binhn Also, https://gerrit.hyperledger.org/r/9585 needs a review as well

scottz (Fri, 26 May 2017 16:26:28 GMT):
Need approvals for test tooling addition: https://gerrit.hyperledger.org/r/#/c/9667/ - few simple function changes for start/stop in behave

scottz (Fri, 26 May 2017 16:27:14 GMT):
https://gerrit.hyperledger.org/r/#/c/9657/ - ledger test tool, bash and go https://gerrit.hyperledger.org/r/#/c/9761/ - ledger tests, bash @dave.enyeart and another

cbf (Fri, 26 May 2017 16:27:14 GMT):
this is like the 3rd time asking for https://gerrit.hyperledger.org/r/#/c/9799/ and https://gerrit.hyperledger.org/r/#/c/9807/ both ready to submit just need one more +2

muralisr (Fri, 26 May 2017 16:41:38 GMT):
@cbf https://gerrit.hyperledger.org/r/#/c/9799 done

muralisr (Fri, 26 May 2017 16:41:42 GMT):
looking at 9807

muralisr (Fri, 26 May 2017 16:42:15 GMT):
ah I had reviewed that and +2ed ... need somone else to review

cbf (Fri, 26 May 2017 16:43:43 GMT):
thx

muralisr (Fri, 26 May 2017 16:43:47 GMT):
@scottz +2ed https://gerrit.hyperledger.org/r/#/c/9667

muralisr (Fri, 26 May 2017 16:49:03 GMT):
@aambati couple of comments on https://gerrit.hyperledger.org/r/#/c/8913/

smithbk (Fri, 26 May 2017 17:23:04 GMT):
Updated list for fabric-ca:

smithbk (Fri, 26 May 2017 17:23:07 GMT):
https://gerrit.hyperledger.org/r/#/c/7741/ - Fix max enrollment checking logic https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling https://gerrit.hyperledger.org/r/#/c/9847/ - Fix leaking authority to delegates https://gerrit.hyperledger.org/r/#/c/9725/ - Fix getcacert client command config

elli-androulaki (Fri, 26 May 2017 17:57:35 GMT):
Hi, the following CRs will appreciate your reviews :)

elli-androulaki (Fri, 26 May 2017 17:57:44 GMT):
Need review: cryptogen intermediate CA and CRL generation enablement (FAB-3888) - (https://gerrit.hyperledger.org/r/#/c/9275/) OU certificates fail to match (FAB-4003) (https://gerrit.hyperledger.org/r/#/c/9519) Error handling in bccsp/signer (FAB-3540) (https://gerrit.hyperledger.org/r/#/c/9279/)

elli-androulaki (Fri, 26 May 2017 17:57:44 GMT):
cryptogen intermediate CA and CRL generation enablement (FAB-3888) - (https://gerrit.hyperledger.org/r/#/c/9275/) OU certificates fail to match (FAB-4003) (https://gerrit.hyperledger.org/r/#/c/9519) Error handling in bccsp/signer (FAB-3540) (https://gerrit.hyperledger.org/r/#/c/9279/)

aambati (Fri, 26 May 2017 17:59:02 GMT):
@smithbk i have fixed the merge conflict for https://gerrit.hyperledger.org/r/#/c/9725/, can u pls re-review and +2 it

aambati (Fri, 26 May 2017 18:01:55 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=9rWMf8GMP3aS63LCk) @muralisr ok, i will take a look

harrijk (Fri, 26 May 2017 23:14:52 GMT):
The bccsp/pkcs11 coverage CRs have settled down after an update and rebase. I'd appreciate it if you could take another look. Thanks. http://gerrit.hyperledger.org/r/9777 http://gerrit.hyperledger.org/r/9779 http://gerrit.hyperledger.org/r/9781

cbf (Sat, 27 May 2017 00:35:03 GMT):
https://gerrit.hyperledger.org/r/#/c/5147/

cbf (Sat, 27 May 2017 00:35:29 GMT):
https://gerrit.hyperledger.org/r/#/c/9425/

harrijk (Sat, 27 May 2017 14:03:07 GMT):
An easy one.. please and thanks! https://gerrit.hyperledger.org/r/#/c/9889/

bmalavan (Sat, 27 May 2017 20:04:01 GMT):
Has joined the channel.

mastersingh24 (Sat, 27 May 2017 20:43:03 GMT):
Upgrading grpc-go is ready for review: https://gerrit.hyperledger.org/r/#/c/9861/

C0rWin (Sun, 28 May 2017 09:18:11 GMT):
Removing admin stop command preventing to shutdown peer by remote call: https://gerrit.hyperledger.org/r/#/c/9845/, already has +2, also voted(FAB-4166) to get in for v1.0 :)

mastersingh24 (Sun, 28 May 2017 18:14:44 GMT):
https://gerrit.hyperledger.org/r/#/c/9861/ (upgrade grpc-go ) should be ready for hopefully a final review

jimthematrix (Sun, 28 May 2017 22:18:34 GMT):
https://gerrit.hyperledger.org/r/#/c/9749/ - has been ready for review for 4 days, and 4th time asking for review now, if you have any concerns please feel free to let me know, I tried to explain above what this is trying to do, and pasting here again: `even though the CR looks significant, the net change is really just adding "newDefaultKeyValueStore()" to FabricCAClientImpl, and adding User class to the fabric-ca-client package. I had to do a bit of code refactoring though, because that class and Client.js end up having quite a few common properties and methods, so I created a comment base class BaseClient.js that both inherit from. about half of the code changes are in tests`

cbf (Mon, 29 May 2017 00:20:05 GMT):
https://gerrit.hyperledger.org/r/#/c/9871/

cbf (Mon, 29 May 2017 00:21:28 GMT):
@jimthematrix https://jira.hyperledger.org/browse/FAB-4131 is review-needed

cbf (Mon, 29 May 2017 00:22:11 GMT):
the point of that was - as the maintainers agreed - to limit changes to production code and to have a process for reviewing and agreeing on substantive changes

cbf (Mon, 29 May 2017 00:25:27 GMT):
the reason that this has not been merged is the same as for @muralisr request for https://gerrit.hyperledger.org/r/#/c/9645/ and that is that despite the fact that I have sent DAILY reminders to the #fabric-maintainers list, most of the issues in the https://jira.hyperledger.org/secure/Dashboard.jspa?selectPageId=10104#Filter-Results/10517 dashboard list have NOT been reviewed. The idea was to get FIVE mintainers to agree on merging patches that met the criteria we agreed upon and as documented in the wiki https://wiki.hyperledger.org/projects/fabric/release_exit_criteria

jimthematrix (Mon, 29 May 2017 02:49:30 GMT):
thanks @cbf, understood, @binhn did add one vote to FAB-4131, should have included the link to the JIRA item (https://jira.hyperledger.org/browse/FAB-4131), so other maintainers can voice their opinions. will also add my vote to the other items in the FAB-9871 list

jimthematrix (Mon, 29 May 2017 03:30:51 GMT):
I added more explanations in https://jira.hyperledger.org/browse/FAB-4131 to help maintainers review and vote

cbf (Mon, 29 May 2017 06:55:38 GMT):
thx

adc (Mon, 29 May 2017 07:14:38 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/9275/. Thanks :)

C0rWin (Mon, 29 May 2017 07:29:36 GMT):
@adc re: CR-9275, seems that no one voted in JIRA in favor of this change to make it before v1.0

C0rWin (Mon, 29 May 2017 07:54:13 GMT):
@cbf there is an explicit feedback of items which everyone agreed to get into v1.0, while no feedback of deferring/postponing items to post v1.0. I think we need to have some retention agreement to move items from your filter into backlog or something, otherwise it will keep growing.

yacovm (Mon, 29 May 2017 07:55:19 GMT):
we can just remove the lablel once it is merged no?

C0rWin (Mon, 29 May 2017 07:55:54 GMT):
for those which merged Id' guess so, but I was talking about those which we won't get into before v1.0

yacovm (Mon, 29 May 2017 07:56:39 GMT):
Then I guess write a comment "not to be merged" and remove the label :)

yacovm (Mon, 29 May 2017 07:56:59 GMT):
and the person that opened the JIRA should do it

cbf (Mon, 29 May 2017 11:03:01 GMT):
the label can be removed when we make a decision. Thus far, no issue has enough votes to merge or consensus to defer

jimthematrix (Mon, 29 May 2017 13:07:16 GMT):
@adc I voted for FAB-3888 but had a comment in gerrit for your CR.

adc (Mon, 29 May 2017 13:47:11 GMT):
Thanks @jimthematrix, I replied :)

yacovm (Mon, 29 May 2017 14:58:44 GMT):
I have 5 votes for https://gerrit.hyperledger.org/r/#/c/9637/ and https://gerrit.hyperledger.org/r/#/c/9753/, can we merge them please?

yacovm (Mon, 29 May 2017 14:58:44 GMT):
I have 5 votes for https://gerrit.hyperledger.org/r/#/c/9637/ and https://gerrit.hyperledger.org/r/#/c/9753/, can we merge them please? @cbf

mastersingh24 (Mon, 29 May 2017 15:03:50 GMT):
So need a little coordination here (I kinda messed things up accidentally). Can we get some eyes on https://gerrit.hyperledger.org/r/#/c/9887/ and hopefully merge it? Then I can rebase https://gerrit.hyperledger.org/r/#/c/9861/ (grpc-go update) on it and e2e will pass

yacovm (Mon, 29 May 2017 17:03:50 GMT):
@mastersingh24 is that a planned thing to remove the testchainid? I'm asking because it belongs to category (3)

yacovm (Mon, 29 May 2017 17:05:56 GMT):
I guess that since the e2e is broken we need to go all the way with that

mastersingh24 (Mon, 29 May 2017 17:49:19 GMT):
I had opened it as a bug before alpha2 since IMHO it's a bug that this has stayed in the code path. The other "smaller" change would be to set the default to "false" rather than"true" but I think it's both a bug and a security hole to have test code enabled in the production path.

yacovm (Mon, 29 May 2017 17:50:08 GMT):
mm, then it's category (2) then and not (3) right?

yacovm (Mon, 29 May 2017 17:50:08 GMT):
mm, then it's category (2) then and not (3) right @mastersingh24 ?

mastersingh24 (Mon, 29 May 2017 17:57:35 GMT):
That was my take

yacovm (Mon, 29 May 2017 17:58:32 GMT):
ok I also think your classification makes sense

cbf (Mon, 29 May 2017 19:11:57 GMT):
Easy one that has been sitting for days https://gerrit.hyperledger.org/r/#/c/9871/

mastersingh24 (Mon, 29 May 2017 19:31:55 GMT):
https://gerrit.hyperledger.org/r/#/c/9895/ is good to go

mastersingh24 (Mon, 29 May 2017 22:21:43 GMT):
https://gerrit.hyperledger.org/r/#/c/9895/ is still good to go ;)

muralisr (Mon, 29 May 2017 22:46:02 GMT):
@mastersingh24 https://gerrit.hyperledger.org/r/#/c/9895... removing `--peer-defaultchain=false` will make it use "testchainid" (unless something changed)

muralisr (Mon, 29 May 2017 22:46:10 GMT):
is that what you are going after ?

muralisr (Mon, 29 May 2017 22:47:14 GMT):
could be given the compose files are not the usual "e2e" or other known culprits that use channel... just making sure

yacovm (Mon, 29 May 2017 22:48:03 GMT):
@muralisr see https://gerrit.hyperledger.org/r/#/c/9887/

muralisr (Mon, 29 May 2017 22:48:25 GMT):
ah it has been removed

muralisr (Mon, 29 May 2017 22:48:26 GMT):
ok

muralisr (Mon, 29 May 2017 22:52:25 GMT):
I've been a bit behind (working on chaincode/ UT :-) )

mastersingh24 (Mon, 29 May 2017 22:53:59 GMT):
@muralisr - for a variety of "odd" reasons, in order to eliminate --peer-defaultchain, I had to do the following: 1) Remove the actual code which creates testchainid from the peer but leave the CLI flag in place so that e2e would pass (since the Java and Node e2e pass --peer-defaultchain=false to the peer on startup) 2) Modify the compose files for e2e for Node and Java to remove the --peer-defaultchain flag 3) Submit a final change which removes the flag from the peer (the trick is that for odd reasons, the SDK e2e's will fail if testchainid is created on startup)

mastersingh24 (Mon, 29 May 2017 22:54:38 GMT):
Rick merged the Java change yesterday (before we realized all of the complex dependencies :( )

muralisr (Mon, 29 May 2017 22:55:37 GMT):
ok. will stay away a bit then :-) ... but this is nice!

muralisr (Mon, 29 May 2017 22:55:43 GMT):
talking of nice...

muralisr (Mon, 29 May 2017 22:56:14 GMT):
I have made very good progress with chaincode UT ...65% coverage without spinning a single image or starting peer

muralisr (Mon, 29 May 2017 22:57:16 GMT):
but really could do some help with https://jira.hyperledger.org/browse/FAB-3948 please

muralisr (Mon, 29 May 2017 22:57:33 GMT):
I'd need common mockpeer changes for the chaincode work

muralisr (Mon, 29 May 2017 22:58:11 GMT):
I *could* refactor https://gerrit.hyperledger.org/r/#/c/9645/ to remove all the error handling refactoring

muralisr (Mon, 29 May 2017 22:58:20 GMT):
but its not all that bad

jimthematrix (Mon, 29 May 2017 23:02:12 GMT):
@mastersingh24 thanks for making the change https://gerrit.hyperledger.org/r/#/c/9895/, totally agree with your sequence of attack steps, but a small glitch with 9895 is that the examples code should have been left alone because it's based on alpha level images

muralisr (Tue, 30 May 2017 03:51:33 GMT):
proper UT framework for chaincode env (long overdue)

muralisr (Tue, 30 May 2017 03:51:33 GMT):
proper UT framework for chaincode env (long overdue) - https://gerrit.hyperledger.org/r/#/c/9911/ (https://jira.hyperledger.org/browse/FAB-4208)

elli-androulaki (Tue, 30 May 2017 06:36:51 GMT):
Hi, could we have another round of reviews here ? https://gerrit.hyperledger.org/r/#/c/9279 (titled [FAB-3540] Error Handling in bccsp/signer) It was +2ed before by @yacovm and @C0rWin , but was stalled afterwards till alpha2 cut was done. Not it is back for v1.

C0rWin (Tue, 30 May 2017 08:16:20 GMT):
@elli-androulaki I think this type of CR (serviceability + error handling) agreed to be post v1.0

yacovm (Tue, 30 May 2017 10:08:27 GMT):
https://gerrit.hyperledger.org/r/#/c/9905/ missing 1 +2

cbf (Tue, 30 May 2017 11:24:57 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=hBsG8Ls2cgRwm4XAd) @elli-androulaki @elli-androulaki I was under the distinct impression that serviceability was for post 1.0.

elli-androulaki (Tue, 30 May 2017 11:28:33 GMT):
@cbf, @C0rWin , @yacovm, fixed that for post-v1. Apologies for the confusion. Was a bit confused myself with the conversation that took place here https://jira.hyperledger.org/browse/FAB-3540. I also -1-ed the CR to prevent others from reviewing it.

cbf (Tue, 30 May 2017 11:28:54 GMT):
ok, thanks @elli-androulaki

mastersingh24 (Tue, 30 May 2017 12:16:00 GMT):
[https://gerrit.hyperledger.org/r/#/c/9895/ is ready ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=Maa2PJ9rTZkKCN2pT) @jimthematrix

cbf (Tue, 30 May 2017 12:30:00 GMT):
@mastersingh24 @jimthematrix I don't see a JIRA to fix the examples

cbf (Tue, 30 May 2017 12:30:18 GMT):
if they aren't current, that is a bad thing (a defect) and a high one at that

aambati (Tue, 30 May 2017 14:08:37 GMT):
@binhn Please re-review https://gerrit.hyperledger.org/r/#/c/9285/ and https://gerrit.hyperledger.org/r/#/c/9585/ ...Murali has already +2ed them

binhn (Tue, 30 May 2017 14:09:29 GMT):
@aambati thought i did, checking

binhn (Tue, 30 May 2017 14:15:13 GMT):
@aambati done, thanks

jimthematrix (Tue, 30 May 2017 15:03:19 GMT):
@cbf https://jira.hyperledger.org/browse/FAB-4226

jimthematrix (Tue, 30 May 2017 15:03:19 GMT):
@cbf just created one https://jira.hyperledger.org/browse/FAB-4226

cbf (Tue, 30 May 2017 15:21:23 GMT):
two easy ones https://gerrit.hyperledger.org/r/#/c/9425/

cbf (Tue, 30 May 2017 15:21:43 GMT):
https://gerrit.hyperledger.org/r/#/c/5147/

cbf (Tue, 30 May 2017 15:23:10 GMT):
@jimthematrix ETA? Are there any other examples that aren't current?

jimthematrix (Tue, 30 May 2017 15:24:28 GMT):
that's the only sample in the SDKs (java doesn't have one yet), on the fabric side the event-listener one needs to be updated to have signatures

jimthematrix (Tue, 30 May 2017 15:24:37 GMT):
those are the ones i'm aware of

binhn (Tue, 30 May 2017 20:37:58 GMT):
chaincode document https://gerrit.hyperledger.org/r/#/c/9263/

harrijk (Tue, 30 May 2017 21:53:04 GMT):
additions & changes for pkcs11 UTs https://gerrit.hyperledger.org/r/#/c/9951/ thanks.

muralisr (Wed, 31 May 2017 02:46:36 GMT):
some love for the chaincode UT https://gerrit.hyperledger.org/r/#/c/9911/ please... tagged the JIRA review-needed as these were potential replacement of the older tests

mastersingh24 (Wed, 31 May 2017 11:10:57 GMT):
Any word on FAB-4002 / https://gerrit.hyperledger.org/r/#/c/9861/ ? It's ready ;)

cbf (Wed, 31 May 2017 14:21:58 GMT):
@mastersingh24 removed from review-needed, has 5 votes needed. I've also +2ed looking for one more

cbf (Wed, 31 May 2017 14:59:38 GMT):
https://gerrit.hyperledger.org/r/#/c/9977/ needs to be done before we cut another release - missing CCBY licenses from markdown and rst files

muralisr (Wed, 31 May 2017 15:17:03 GMT):
https://gerrit.hyperledger.org/r/#/c/9911 has +2 and JIRA does not need `review-needed` ...

cbf (Wed, 31 May 2017 18:33:30 GMT):
https://gerrit.hyperledger.org/r/#/c/9997/ needs love to fix the CI failure

yacovm (Wed, 31 May 2017 18:34:35 GMT):
@cbf - is this related to the gRPC upgrade? How did it get verified then?

cbf (Wed, 31 May 2017 18:34:39 GMT):
yes

cbf (Wed, 31 May 2017 18:34:42 GMT):
unclear

mastersingh24 (Wed, 31 May 2017 19:05:56 GMT):
I never saw that running unit tests locally

AdnanC (Wed, 31 May 2017 19:25:02 GMT):
Need approvals for couple of CRS for test tools and tests, (already reviewd by Barry and others in the Quality team) https://gerrit.hyperledger.org/r/#/c/9657/ https://gerrit.hyperledger.org/r/#/c/9761/

cbf (Wed, 31 May 2017 19:33:53 GMT):
https://gerrit.hyperledger.org/r/#/c/9945/3 needs love

cbf (Wed, 31 May 2017 19:34:26 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=mmiMgaWfEqqSH7qHD) @mastersingh24 nor did I, and I verified your patch locally a couple of times

mastersingh24 (Wed, 31 May 2017 19:37:18 GMT):
@cbf - one comment for 9945 (basically we need to use go 1.7.x - if you use go 1.8 some tests will fail; I know that the TLS tests will fail because the changed the rules and some error messages)

cbf (Wed, 31 May 2017 19:38:41 GMT):
https://gerrit.hyperledger.org/r/#/c/9977/ adds CCBY license to all markdown and rst files

cbf (Wed, 31 May 2017 19:46:14 GMT):
need one more xv

cbf (Wed, 31 May 2017 19:46:14 GMT):
need one more https://gerrit.hyperledger.org/r/#/c/9977/

cbf (Wed, 31 May 2017 19:46:29 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=dkdCftp77sQHAgK2p) @mastersingh24 done

harrijk (Wed, 31 May 2017 23:34:57 GMT):
Another look at https://gerrit.hyperledger.org/r/#/c/9951/ would be greatly appreciated.

anik (Thu, 01 Jun 2017 04:19:06 GMT):
Has joined the channel.

yacovm (Thu, 01 Jun 2017 11:20:35 GMT):
https://gerrit.hyperledger.org/r/#/c/9905/ is ready to be merged, it has 7/5 votes

smithbk (Thu, 01 Jun 2017 13:29:32 GMT):
For fabric-ca review:

smithbk (Thu, 01 Jun 2017 13:29:36 GMT):
https://gerrit.hyperledger.org/r/#/c/7741/ - Fix max enrollment checking logic https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling https://gerrit.hyperledger.org/r/#/c/9939/ - Fix the TLS client using BCCSP https://gerrit.hyperledger.org/r/#/c/9943/ - Documentation updates

nickgaski (Thu, 01 Jun 2017 15:18:49 GMT):
I have a few easy ones: https://gerrit.hyperledger.org/r/#/c/10017/ - consortium definition

nickgaski (Thu, 01 Jun 2017 15:19:12 GMT):
https://gerrit.hyperledger.org/r/#/c/10019/ - improvements to getting started

cbf (Thu, 01 Jun 2017 15:49:57 GMT):
https://gerrit.hyperledger.org/r/#/c/9945/ please

smithbk (Thu, 01 Jun 2017 18:08:11 GMT):
Another for fabric-ca:

smithbk (Thu, 01 Jun 2017 18:08:14 GMT):
https://gerrit.hyperledger.org/r/#/c/9987/ - Fix/clarify CA pathlen constraints

jyellick (Thu, 01 Jun 2017 18:34:15 GMT):
https://gerrit.hyperledger.org/r/#/c/9981/ <- a little help with the verify? Have gotten a pass from the builder with the union of the last two reverifies

muralisr (Thu, 01 Jun 2017 18:49:44 GMT):
an easy CR https://gerrit.hyperledger.org/r/#/c/8873 that has been languishing for a month

cbf (Thu, 01 Jun 2017 18:51:56 GMT):
some love please? https://gerrit.hyperledger.org/r/#/c/9945/ had to be rebased

muralisr (Thu, 01 Jun 2017 18:59:30 GMT):
@cbf will look ... https://gerrit.hyperledger.org/r/#/c/9909/ is an easy one

muralisr (Thu, 01 Jun 2017 20:14:50 GMT):
another easy one https://gerrit.hyperledger.org/r/#/c/9995

cbf (Thu, 01 Jun 2017 22:07:15 GMT):
needs one more https://gerrit.hyperledger.org/r/#/c/9945/6

cbf (Thu, 01 Jun 2017 23:33:45 GMT):
some easy ones to add CCBY licenses

cbf (Thu, 01 Jun 2017 23:33:47 GMT):
https://gerrit.hyperledger.org/r/#/c/10041/

cbf (Thu, 01 Jun 2017 23:34:01 GMT):
https://gerrit.hyperledger.org/r/#/c/10043/

cbf (Thu, 01 Jun 2017 23:34:13 GMT):
https://gerrit.hyperledger.org/r/#/c/10045/

cbf (Thu, 01 Jun 2017 23:34:26 GMT):
https://gerrit.hyperledger.org/r/#/c/10047/

elli-androulaki (Fri, 02 Jun 2017 00:24:36 GMT):
Hi, easy CRs :) https://gerrit.hyperledger.org/r/#/c/10027 https://gerrit.hyperledger.org/r/#/c/10031/

muralisr (Fri, 02 Jun 2017 12:21:57 GMT):
An easy bug fix (reporting chaincode response correctly in CLI) https://gerrit.hyperledger.org/r/#/c/9253/ please

smithbk (Fri, 02 Jun 2017 12:29:34 GMT):
For fabric-ca:

smithbk (Fri, 02 Jun 2017 12:29:37 GMT):
https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling https://gerrit.hyperledger.org/r/#/c/9939/ - Fix the TLS client using BCCSP

nickgaski (Fri, 02 Jun 2017 13:08:49 GMT):
https://gerrit.hyperledger.org/r/#/c/10019/ - Need one more vote here

JonathanLevi (Fri, 02 Jun 2017 13:19:05 GMT):
@nickgaski can you unlinked https://gerrit.hyperledger.org/r/#/c/10019 ?

JonathanLevi (Fri, 02 Jun 2017 13:19:05 GMT):
@nickgaski can you unlink https://gerrit.hyperledger.org/r/#/c/10019 ?

JonathanLevi (Fri, 02 Jun 2017 13:19:57 GMT):
(and https://gerrit.hyperledger.org/r/#/c/10017)

smithbk (Fri, 02 Jun 2017 13:23:02 GMT):
Meant to include one other in fabric-ca to review list:

smithbk (Fri, 02 Jun 2017 13:23:05 GMT):
https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling https://gerrit.hyperledger.org/r/#/c/9939/ - Fix the TLS client using BCCSP https://gerrit.hyperledger.org/r/#/c/9987/ - Fix/clarify CA pathlen constraints

jyellick (Fri, 02 Jun 2017 13:43:17 GMT):
This is the set of CRs related to FAB-1678 which need some help: https://gerrit.hyperledger.org/r/9785 https://gerrit.hyperledger.org/r/9851 https://gerrit.hyperledger.org/r/9853 https://gerrit.hyperledger.org/r/9879 https://gerrit.hyperledger.org/r/9981 https://gerrit.hyperledger.org/r/9989 https://gerrit.hyperledger.org/r/10007 https://gerrit.hyperledger.org/r/10059

JonathanLevi (Fri, 02 Jun 2017 13:47:48 GMT):
@jyellick I have been waiting for a Gorilla/mux vendor'ing ! ;-)

mastersingh24 (Fri, 02 Jun 2017 13:48:10 GMT):
They might be beyond help @jyellick but I'll review them ;)

JonathanLevi (Fri, 02 Jun 2017 13:49:20 GMT):
Yup, I agree. Jsaon, "we'll try" ;-)

jyellick (Fri, 02 Jun 2017 13:50:35 GMT):
Hopefully they're not too rough.... 9785 is the only big one, which is probably why it's been stuck, but it's 2/3rds test, so hopefully looks more intimidating than it is

JonathanLevi (Fri, 02 Jun 2017 13:58:41 GMT):
I really like your "copy on write" trick, btw.

JonathanLevi (Fri, 02 Jun 2017 13:59:01 GMT):
(Updating versions only on change)

mastersingh24 (Fri, 02 Jun 2017 14:44:54 GMT):
[Went through all of them and gave them the :thumbsup_tone5: ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=N6b5geiexLw3XoaMX) @jyellick

jimthematrix (Fri, 02 Jun 2017 15:01:55 GMT):
hi guys, can I ask someone to +2 and merge https://gerrit.hyperledger.org/r/#/c/9749/? the JIRA has been approved (5 votes)

mastersingh24 (Fri, 02 Jun 2017 15:10:22 GMT):
https://gerrit.hyperledger.org/r/#/c/10071/ could use a look.

mastersingh24 (Fri, 02 Jun 2017 15:11:00 GMT):
[done ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=tCpFJGQpZgYPBJp8D) @jimthematrix

jeffgarratt (Fri, 02 Jun 2017 17:58:38 GMT):
@here may go unnoticed, but the work to optimize the golang chaincode packaging seems to work very well (https://gerrit.hyperledger.org/r/#/c/6991/) . Kudos @greg.haskins This has dramatically reduce the install time and obviated the need for caching of deployment for golang

greg.haskins (Fri, 02 Jun 2017 17:59:31 GMT):
Note that I only addressed the CLI...SDKs still need updates

greg.haskins (Fri, 02 Jun 2017 18:00:04 GMT):
Though on that front, I think the node-sdk has the opposite approach (too little info, vs CLI packing too much)

tongli (Fri, 02 Jun 2017 19:02:42 GMT):
@here, really need some helping soul to help get this merged. https://gerrit.hyperledger.org/r/#/c/9811, please help out reviewing , this patch is to make our CI run a lot faster for all patch sets.

cbf (Fri, 02 Jun 2017 19:08:16 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=xHeTmaqD7YWaYFikk) @tongli We could really use some eyes on this CR, please - it will vastly improve your local build performance

tongli (Fri, 02 Jun 2017 19:09:43 GMT):
@binhn can you please review this real quick? https://gerrit.hyperledger.org/r/#/c/9811,

binhn (Fri, 02 Jun 2017 19:10:59 GMT):
@tongli sure

tongli (Fri, 02 Jun 2017 19:12:22 GMT):
thanks @binhn

mastersingh24 (Fri, 02 Jun 2017 19:15:05 GMT):
@cbf - is this what is going to be run in CI as well? It's not hard to just test your own changes locally today - I do it all the time. But I worry that it's risky to change how we test this close to a potential release. I also know that I missed part of the debate on this earlier

cbf (Fri, 02 Jun 2017 19:16:03 GMT):
@mastersingh24 no, CI won't change until we have an ability to run a full CI pass between reviews and merge

cbf (Fri, 02 Jun 2017 19:16:19 GMT):
this will ONLY affect LOCAL builds

cbf (Fri, 02 Jun 2017 19:16:46 GMT):
there is a new target 'make desk-check' and another 'make verify' that will exploit the changes

cbf (Fri, 02 Jun 2017 19:16:46 GMT):
there are new targets 'make desk-check' and another 'make verify' that will exploit the changes

cbf (Fri, 02 Jun 2017 19:17:50 GMT):
as for testing your own changes, you have to manually enter the TEST_PKGS variable and it still uses gocov which is slow as molasses

cbf (Fri, 02 Jun 2017 19:18:29 GMT):
the new targets use go test -cover which for a full pass can reduce the UT overhead from about an hour to 40 minutes

jyellick (Fri, 02 Jun 2017 20:24:54 GMT):
https://gerrit.hyperledger.org/r/#/c/9785/ has previously had a +2 from @mastersingh24 , needs an additional, and will unblock 3 others (which already have +2s) to merge

cbf (Fri, 02 Jun 2017 20:35:46 GMT):
fun fact, here's a query of all CRs that are ready to submit (with one more review) https://gerrit.hyperledger.org/r/#/q/is:open+label:Verified%252B1++label:Code-Review%252B2+NOT+label:Code-Review-1+NOT+label:Code-Review-2+is:mergeable

cbf (Fri, 02 Jun 2017 20:46:32 GMT):
@jyellick https://gerrit.hyperledger.org/r/#/c/9851/6 and the CRs after it in some weird limbo state

cbf (Fri, 02 Jun 2017 20:46:48 GMT):
ready to submit but the button's greyed out

yacovm (Fri, 02 Jun 2017 20:50:16 GMT):
The parent of https://gerrit.hyperledger.org/r/#/c/9851/ is https://gerrit.hyperledger.org/r/#/c/9785/7 while patch set 9 was the one that was merged

jyellick (Fri, 02 Jun 2017 21:06:27 GMT):
@cbf Thanks for the heads up, rebased them all onto master, hopefully CI will be fast and friendly

mastersingh24 (Fri, 02 Jun 2017 23:17:36 GMT):
easy one - just some UT - https://gerrit.hyperledger.org/r/#/c/10099/ (had to do it since I had already updated the coverage previously)

jyellick (Sun, 04 Jun 2017 17:53:09 GMT):
https://gerrit.hyperledger.org/r/#/c/10127/ <- small one https://gerrit.hyperledger.org/r/#/c/10129/ <- also small, needs a manual +1 verify, union of two reverifies shows it passing

jyellick (Sun, 04 Jun 2017 17:53:09 GMT):
https://gerrit.hyperledger.org/r/#/c/10127/ <- small one https://gerrit.hyperledger.org/r/#/c/10129/ <- also small, ~needs a manual +1 verify, union of two reverifies shows it passing~

jimthematrix (Sun, 04 Jun 2017 19:33:17 GMT):
@here please review this urgent one that's discovered by node SDK tests and is preventing it from being 100% successful: https://gerrit.hyperledger.org/r/#/c/10135

cbf (Sun, 04 Jun 2017 19:40:48 GMT):
@jimthematrix @muralisr wait, what?

cbf (Sun, 04 Jun 2017 19:42:53 GMT):
why are you making yet another API change? What precipitated this new urgency? We haven' merged the 500-400 change from Will

muralisr (Sun, 04 Jun 2017 19:59:05 GMT):
@cbf its not an API change ... in fact a recent bug fix in https://gerrit.hyperledger.org/r/#/c/9213 to delineate chaincode errors broke the old API contract

muralisr (Sun, 04 Jun 2017 20:00:47 GMT):
@wlahti actually did ask the question during the bug fix but I overlooked it (by mistake). This new fix https://gerrit.hyperledger.org/r/#/c/10135 completes https://gerrit.hyperledger.org/r/#/c/9213 correctly and maintains old contract

muralisr (Sun, 04 Jun 2017 20:01:32 GMT):
also, this should not affect Will's 500-400 change

jimthematrix (Sun, 04 Jun 2017 20:02:55 GMT):
@muralisr I did test the CR locally, with that the node SDK tests were able to run to 100% success again

cbf (Sun, 04 Jun 2017 20:03:47 GMT):
ok, makes sense

cbf (Sun, 04 Jun 2017 20:04:48 GMT):
the commit message could/should have been clearer - please add that missing info in a comment at least

muralisr (Sun, 04 Jun 2017 20:04:59 GMT):
Just did in response to your comment

cbf (Sun, 04 Jun 2017 20:05:05 GMT):
thanks

muralisr (Sun, 04 Jun 2017 20:05:17 GMT):
thanks ^ !

jimthematrix (Sun, 04 Jun 2017 20:16:15 GMT):
thanks @cbf for reviewing and merging!

jimthematrix (Mon, 05 Jun 2017 00:44:26 GMT):
https://gerrit.hyperledger.org/r/#/c/10091/ - updating the example to latest API, and simplifying the code so it's easier to follow

jimthematrix (Mon, 05 Jun 2017 00:44:26 GMT):
https://gerrit.hyperledger.org/r/#/c/10091/ - updating the balance-transfer example in node SDK to latest API, and simplifying the code so it's easier to follow

JonathanLevi (Mon, 05 Jun 2017 02:01:28 GMT):
2 Suggestions inline ^^^

vpaprots (Mon, 05 Jun 2017 06:36:48 GMT):
would appreciate a review of https://gerrit.hyperledger.org/r/#/c/10101 - some fixes around how bccsp factory handles default options

dave.enyeart (Mon, 05 Jun 2017 13:25:58 GMT):
https://gerrit.hyperledger.org/r/#/c/10023 - Quick one, doc only

kostas (Mon, 05 Jun 2017 13:43:22 GMT):
I posted this on Friday: https://gerrit.hyperledger.org/r/#/c/10039/ (it's not mergeable until the maintainers reach consensus, but we'll need to evaluate it as a changeset nonetheless)

cbf (Mon, 05 Jun 2017 13:53:06 GMT):
https://gerrit.hyperledger.org/r/#/c/10153/ proposes release notes for 1.0.0-beta

tongli (Mon, 05 Jun 2017 14:03:50 GMT):
@here guys continue plea for the review of this patch set. https://gerrit.hyperledger.org/r/#/c/9811/

tongli (Mon, 05 Jun 2017 14:04:40 GMT):
it helps your development and runs only the unit test cases that your code change affects, it will make the CI run many folds faster.

tongli (Mon, 05 Jun 2017 14:05:22 GMT):
had to resolve the merge conflicts few times as well, the patch has lost few +1 in earlier patch set.

tongli (Mon, 05 Jun 2017 14:05:49 GMT):
your help is really needed to move this forward.

tongli (Mon, 05 Jun 2017 14:06:32 GMT):
you can easily do a comparison by running a make unit-test on the time to take you, and a make verify with this patch.

muralisr (Mon, 05 Jun 2017 14:07:23 GMT):
@tongli +1 for now on @https://gerrit.hyperledger.org/r/#/c/9811

muralisr (Mon, 05 Jun 2017 14:07:36 GMT):
waiting for a few more reviews

tongli (Mon, 05 Jun 2017 14:07:44 GMT):
@muralisr thanks.

cbf (Mon, 05 Jun 2017 14:11:43 GMT):
https://gerrit.hyperledger.org/r/#/c/9745/

muralisr (Mon, 05 Jun 2017 14:22:28 GMT):
@cbf done ^^^

cbf (Mon, 05 Jun 2017 14:29:16 GMT):
https://gerrit.hyperledger.org/r/#/c/10157/

cbf (Mon, 05 Jun 2017 14:29:39 GMT):
@muralisr thx

cbf (Mon, 05 Jun 2017 14:42:05 GMT):
@jimthematrix @smithbk please feel free to hijack these CRs to update the contents if I have missed anything https://gerrit.hyperledger.org/r/#/c/10157/ https://gerrit.hyperledger.org/r/#/c/10159/

cbf (Mon, 05 Jun 2017 14:50:32 GMT):
also https://gerrit.hyperledger.org/r/#/c/10161/

cbf (Mon, 05 Jun 2017 14:50:32 GMT):
also https://gerrit.hyperledger.org/r/#/c/10161/ @rickr

smithbk (Mon, 05 Jun 2017 15:58:18 GMT):
For fabric-ca review:

smithbk (Mon, 05 Jun 2017 15:58:21 GMT):
https://gerrit.hyperledger.org/r/#/c/9423/ - Improve LDAP usage and error handling https://gerrit.hyperledger.org/r/#/c/9987/ - Fix/clarify CA pathlen constraints https://gerrit.hyperledger.org/r/#/c/9939/ - Fix the TLS client using BCCSP

jimthematrix (Mon, 05 Jun 2017 19:36:37 GMT):
trivial one (removing dead test code): https://gerrit.hyperledger.org/r/#/c/10173/

muralisr (Mon, 05 Jun 2017 19:53:07 GMT):
removing code easy review, done @jimthematrix :-)

jimthematrix (Mon, 05 Jun 2017 19:53:23 GMT):
thanks!

simsc (Mon, 05 Jun 2017 20:04:51 GMT):
Has joined the channel.

simsc (Mon, 05 Jun 2017 20:05:27 GMT):
@markparz asking for a review for https://gerrit.hyperledger.org/r/#/c/9469/

markparz (Mon, 05 Jun 2017 20:07:05 GMT):
@jimthematrix also https://gerrit.hyperledger.org/r/#/c/9249/ bottom section is regarding the endorsement policy checker

muralisr (Mon, 05 Jun 2017 20:15:40 GMT):
@simsc https://gerrit.hyperledger.org/r/#/c/9469 is i "Cannot Merge" state and needs to be rebaed

muralisr (Mon, 05 Jun 2017 20:15:40 GMT):
@simsc https://gerrit.hyperledger.org/r/#/c/9469 is i "Cannot Merge" state and needs to be rebased

jimthematrix (Mon, 05 Jun 2017 20:36:30 GMT):
@markparz I reviewed and added comments to https://gerrit.hyperledger.org/r/#/c/9249

simsc (Mon, 05 Jun 2017 21:13:08 GMT):
@nickgaski can you look at cr 9249

smithbk (Mon, 05 Jun 2017 21:26:22 GMT):
For fabric-ca: https://gerrit.hyperledger.org/r/#/c/9423/

yacovm (Mon, 05 Jun 2017 21:27:35 GMT):
Hi all! https://gerrit.hyperledger.org/r/#/c/10033/ `Harden gossip bootstrap peer connection` and https://gerrit.hyperledger.org/r/#/c/9119/ `Mutual TLS support in gossip handshake` are awaiting your confirmation and/or scrutiny! They each have 1 +2

yacovm (Mon, 05 Jun 2017 21:27:35 GMT):
Hi all! https://gerrit.hyperledger.org/r/#/c/10033/ `Harden gossip bootstrap peer connection` and ~ https://gerrit.hyperledger.org/r/#/c/9119/ `Mutual TLS support in gossip handshake` ~ are awaiting your confirmation and/or scrutiny! They each have 1 +2 and got 5 votes

yacovm (Mon, 05 Jun 2017 21:27:35 GMT):
Hi all! https://gerrit.hyperledger.org/r/#/c/10033/ `Harden gossip bootstrap peer connection` and ~ https://gerrit.hyperledger.org/r/#/c/9119/ `Mutual TLS support in gossip handshake` ~ Thanks @JonathanLevi ! are awaiting your confirmation and/or scrutiny! They each have 1 +2 and got 5 votes

yacovm (Mon, 05 Jun 2017 21:27:35 GMT):
Hi all! ~ https://gerrit.hyperledger.org/r/#/c/10033/ `Harden gossip bootstrap peer connection` ~ thanks @cbf and ~ https://gerrit.hyperledger.org/r/#/c/9119/ `Mutual TLS support in gossip handshake` ~ Thanks @JonathanLevi ! are awaiting your confirmation and/or scrutiny! They each have 1 +2 and got 5 votes

kostas (Mon, 05 Jun 2017 23:14:23 GMT):
https://gerrit.hyperledger.org/r/#/c/10077/

muralisr (Tue, 06 Jun 2017 00:25:03 GMT):
any easy one https://gerrit.hyperledger.org/r/#/c/8879/

jimthematrix (Tue, 06 Jun 2017 02:45:18 GMT):
a zero-risk one but very useful: https://gerrit.hyperledger.org/r/#/c/10063/ - updating the event listener GO example to support signing so it now works with the latest fabric, contributed by @Hangyu from Fujitsu Japan

jimthematrix (Tue, 06 Jun 2017 02:45:37 GMT):
already got one +2

jimthematrix (Tue, 06 Jun 2017 02:46:58 GMT):
tagging @muralisr since you reviewed it too

adc (Tue, 06 Jun 2017 07:24:43 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/9897/9. I have just addressed the comments :)

adc (Tue, 06 Jun 2017 07:24:43 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/9897/9. I have just addressed the comments. Thanks much :)

adc (Tue, 06 Jun 2017 11:31:09 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/10201/, it is about BCCSP configuration in core.yaml and orderer.yaml. Thanks much :)

cbf (Tue, 06 Jun 2017 11:33:57 GMT):
@adc https://jira.hyperledger.org/browse/FAB-4410 isn't a bug, it is an improvement

adc (Tue, 06 Jun 2017 11:34:29 GMT):
fixed, sorry :(

cbf (Tue, 06 Jun 2017 11:35:38 GMT):
further, it is two improvements bundled in a single CR

adc (Tue, 06 Jun 2017 11:42:14 GMT):
yes, because the size of the change-set is minimal and the two are closely related we though to merge them in a single CR

adc (Tue, 06 Jun 2017 11:42:14 GMT):
@cbf yes, because the size of the change-set is minimal and the two are closely related we though to merge them in a single CR

adc (Tue, 06 Jun 2017 11:42:21 GMT):
how should we proceed?

adc (Tue, 06 Jun 2017 11:42:28 GMT):
shall we split anyway?

yacovm (Tue, 06 Jun 2017 11:43:37 GMT):
Add a needs_review label

yacovm (Tue, 06 Jun 2017 11:43:43 GMT):
Angelo

adc (Tue, 06 Jun 2017 11:44:25 GMT):
done, thanks

rameshthoomu (Tue, 06 Jun 2017 11:52:01 GMT):
Need review on this pls.. https://gerrit.hyperledger.org/r/#/c/10207/

cbf (Tue, 06 Jun 2017 11:56:12 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=pQSKZ8yE9TwjEpzEa) @adc Angelo, size has nothing to do with it. We are not accepting improvements at this time - bug fxes and new test coverage only and even then, if it makes substantive changes to mainline code, we have review-needed process to determine whether we will merge the change

cbf (Tue, 06 Jun 2017 11:56:25 GMT):
we are trying to minimize all changes to the code code

cbf (Tue, 06 Jun 2017 11:56:25 GMT):
we are trying to minimize all changes to the core code

adc (Tue, 06 Jun 2017 11:56:50 GMT):
I see, got it

troyronda (Tue, 06 Jun 2017 15:59:26 GMT):
https://gerrit.hyperledger.org/r/#/c/9875/ (@jpatchell)

troyronda (Tue, 06 Jun 2017 15:59:26 GMT):
https://gerrit.hyperledger.org/r/#/c/9875/ ( @jpatchell )

dave.enyeart (Tue, 06 Jun 2017 19:24:33 GMT):
could the Makefile experts (@greg.haskins) review https://gerrit.hyperledger.org/r/#/c/10163 (quick one)

dave.enyeart (Tue, 06 Jun 2017 19:24:33 GMT):
could the Makefile experts, e.g. @greg.haskins review https://gerrit.hyperledger.org/r/#/c/10163 (quick one)

rameshthoomu (Tue, 06 Jun 2017 19:39:47 GMT):
Need +2 on this patch https://gerrit.hyperledger.org/r/#/c/10175/

markparz (Tue, 06 Jun 2017 20:28:20 GMT):
first sections of writing an app https://gerrit.hyperledger.org/r/#/c/10231/

cbf (Tue, 06 Jun 2017 21:15:42 GMT):
@markparz see my comments in the CR

markparz (Tue, 06 Jun 2017 21:17:21 GMT):
cool, good stuff thanks

markparz (Tue, 06 Jun 2017 21:17:28 GMT):
let me get on it

yacovm (Tue, 06 Jun 2017 23:07:52 GMT):
CI currently fails because of compilation errors... I uploaded a fix https://gerrit.hyperledger.org/r/#/c/10243/

yacovm (Tue, 06 Jun 2017 23:08:36 GMT):
@rjones I guess the abortion was because of the 2nd change set?

rjones (Tue, 06 Jun 2017 23:08:36 GMT):
Has joined the channel.

rjones (Tue, 06 Jun 2017 23:09:03 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=asPvAkKpgWmaQebdN) @yacovm I aborted builds on patch one by hand to test something else out

yacovm (Tue, 06 Jun 2017 23:09:27 GMT):
ah, ok

cbf (Tue, 06 Jun 2017 23:35:27 GMT):
https://gerrit.hyperledger.org/r/#/c/10247/

JonathanLevi (Wed, 07 Jun 2017 13:29:43 GMT):
https://gerrit.hyperledger.org/r/#/c/10177 How come this has not (never) been tested so far?

JonathanLevi (Wed, 07 Jun 2017 13:30:33 GMT):
I don't think that adding tests AFTER the development is "complete" is that brilliant of a technique/method.

JonathanLevi (Wed, 07 Jun 2017 13:30:33 GMT):
I don't think that adding tests "AFTER the 'development is complete'" is that brilliant of a technique/method.

JonathanLevi (Wed, 07 Jun 2017 13:32:36 GMT):
Not sure how we can we declare "complete" without testing... but the important thing is that I have never heard or read about such a innovative software development lifecycle.

JonathanLevi (Wed, 07 Jun 2017 13:33:09 GMT):
First, we declare "complete". Then, we "test".

JonathanLevi (Wed, 07 Jun 2017 13:33:29 GMT):
Or, not even. Sigh.

C0rWin (Wed, 07 Jun 2017 13:39:59 GMT):

Message Attachments

C0rWin (Wed, 07 Jun 2017 13:40:02 GMT):
@JonathanLevi ^^^

JonathanLevi (Wed, 07 Jun 2017 13:40:22 GMT):
Evidently!

JonathanLevi (Wed, 07 Jun 2017 13:42:14 GMT):
More than this. I don't understand how does somebody tells me a feature like a "Revoker" works, where one can configure a boolean parameter...('hf.Revoker=false')... yet, it was *never* tested.

JonathanLevi (Wed, 07 Jun 2017 13:42:29 GMT):
How did the JIRA ticket got closed in the first place?!

JonathanLevi (Wed, 07 Jun 2017 14:05:30 GMT):
@smithbk Any suggestion? ^^^

JonathanLevi (Wed, 07 Jun 2017 14:06:13 GMT):
Or was it "already complete" so why test it?

JonathanLevi (Wed, 07 Jun 2017 14:07:02 GMT):
What shall we say in the Change Log for v1.0.0-beta.... "Introducing Revoker" ?

JonathanLevi (Wed, 07 Jun 2017 14:07:52 GMT):
Or, "Now we read your parameter" enhanement?

JonathanLevi (Wed, 07 Jun 2017 14:07:52 GMT):
Or, "Now we read your parameter" *enhancement*?

smithbk (Wed, 07 Jun 2017 14:09:14 GMT):
Guys, we had a test case but the test case itself was not complete. It checked for the existence of the attribute but not the value. Do you think that this is the only place in the product that this exists? I guess this doesn't happen to anyone else?

JonathanLevi (Wed, 07 Jun 2017 14:10:06 GMT):
Ah, the *test* was not complete.

JonathanLevi (Wed, 07 Jun 2017 14:10:13 GMT):
The feature was complete.

JonathanLevi (Wed, 07 Jun 2017 14:10:33 GMT):
I beg your pardon. Maybe we should introduce 2 steps then.

JonathanLevi (Wed, 07 Jun 2017 14:10:36 GMT):
1. Feature complete

JonathanLevi (Wed, 07 Jun 2017 14:10:45 GMT):
And *a few months later*

JonathanLevi (Wed, 07 Jun 2017 14:10:49 GMT):
2. Test complete

JonathanLevi (Wed, 07 Jun 2017 14:10:53 GMT):
---

JonathanLevi (Wed, 07 Jun 2017 14:11:02 GMT):
Wonder when we should switch to 2.

JonathanLevi (Wed, 07 Jun 2017 14:11:39 GMT):
More seriously, *how can we trust such statuses*

JonathanLevi (Wed, 07 Jun 2017 14:11:55 GMT):
How much *trust* can we have in these...?

JonathanLevi (Wed, 07 Jun 2017 14:12:05 GMT):
---

JonathanLevi (Wed, 07 Jun 2017 14:12:29 GMT):
And no, I don't buy the "this is not the only place in the product...", or "look at the other cowboys"

smithbk (Wed, 07 Jun 2017 14:12:55 GMT):
Jonathan, if I had known the test case didn't check that, I would not have said it was complete. I'm not omniscient.

smithbk (Wed, 07 Jun 2017 14:13:14 GMT):
I'll be glad to discuss, but this isn't productive

JonathanLevi (Wed, 07 Jun 2017 14:13:21 GMT):
I'm not even going to look up all the use cases of omniscient.

JonathanLevi (Wed, 07 Jun 2017 14:13:21 GMT):
I'm not even going to look up all the uses of the word omniscient.

JonathanLevi (Wed, 07 Jun 2017 14:13:28 GMT):
No, please. No more meetings!

JonathanLevi (Wed, 07 Jun 2017 14:14:09 GMT):
----

JonathanLevi (Wed, 07 Jun 2017 14:14:34 GMT):
Holding off the release, for such a CR, is much more productive, eh?

JonathanLevi (Wed, 07 Jun 2017 14:15:03 GMT):
^^^ That was a rhetorical.

mastersingh24 (Wed, 07 Jun 2017 14:17:59 GMT):
This does not warrant holding off the release IMHO

mastersingh24 (Wed, 07 Jun 2017 14:17:59 GMT):
This does not warrant holding up the release IMHO

mastersingh24 (Wed, 07 Jun 2017 14:19:03 GMT):
But it does not seem risky to add either

mastersingh24 (Wed, 07 Jun 2017 14:19:26 GMT):
So if we are truly frozen, let's move on

smithbk (Wed, 07 Jun 2017 14:20:58 GMT):
ok, which would you prefer ... update release notes as vulnerability and not put it in or put it in with release notes as is?

smithbk (Wed, 07 Jun 2017 14:22:10 GMT):
I assume you mean to just update release notes with this as a known vulnerability?

mastersingh24 (Wed, 07 Jun 2017 14:28:08 GMT):
@smithbk - where are the fabric-ca release notes?

mastersingh24 (Wed, 07 Jun 2017 14:28:43 GMT):
I found them

mastersingh24 (Wed, 07 Jun 2017 14:29:59 GMT):
The release notes now say that https://jira.hyperledger.org/browse/FAB-4372 has been resolved

smithbk (Wed, 07 Jun 2017 14:30:54 GMT):
right ... if we don't merge, then should simply move that to the other section

cbf (Wed, 07 Jun 2017 14:32:30 GMT):
right

cbf (Wed, 07 Jun 2017 14:32:45 GMT):
I can't now as I have no internet

cbf (Wed, 07 Jun 2017 14:32:54 GMT):
I can go either way

mastersingh24 (Wed, 07 Jun 2017 14:33:14 GMT):
Looks like there is still churn in the comments for the CR

cbf (Wed, 07 Jun 2017 14:33:24 GMT):
right

mastersingh24 (Wed, 07 Jun 2017 14:33:29 GMT):
I'll update the release notes and move to vulnerabilityy

mastersingh24 (Wed, 07 Jun 2017 14:33:29 GMT):
I'll update the release notes and move to vulnerability

cbf (Wed, 07 Jun 2017 14:33:36 GMT):
so list as vuln then?

cbf (Wed, 07 Jun 2017 14:33:41 GMT):
cool

mastersingh24 (Wed, 07 Jun 2017 14:39:07 GMT):
done

cbf (Wed, 07 Jun 2017 14:39:25 GMT):
thx

JonathanLevi (Wed, 07 Jun 2017 14:50:30 GMT):
Thank you @mastersingh24.

JonathanLevi (Wed, 07 Jun 2017 14:50:30 GMT):
Thank you @mastersingh24

jeffgarratt (Wed, 07 Jun 2017 15:53:29 GMT):
Now support specification of channel members as sub-selection of consortium https://gerrit.hyperledger.org/r/#/c/10237/

jeffgarratt (Wed, 07 Jun 2017 15:53:29 GMT):
@jyellick @kostas @binhn Now support specification of channel members as sub-selection of consortium https://gerrit.hyperledger.org/r/#/c/10237/

xixuejia (Wed, 07 Jun 2017 18:58:43 GMT):
A simple fix of unit-test failure on local host https://gerrit.hyperledger.org/r/#/c/10289/

nickgaski (Wed, 07 Jun 2017 20:41:49 GMT):
Fixes chaincode dev mode doc - https://gerrit.hyperledger.org/r/#/c/10295/

nickgaski (Wed, 07 Jun 2017 21:12:02 GMT):
@jimthematrix - two easy guys: https://gerrit.hyperledger.org/r/#/c/10297/ & https://gerrit.hyperledger.org/r/#/c/10307/

jimthematrix (Thu, 08 Jun 2017 01:58:49 GMT):
@nickgaski merged one, left comment for the other

cbf (Thu, 08 Jun 2017 09:50:04 GMT):
@jimthematrix we are supposed to be under a merge moratorium for the release unless the change is agreed by the release managers

jimthematrix (Thu, 08 Jun 2017 13:03:37 GMT):
@cbf you got me there ;-)

jimthematrix (Thu, 08 Jun 2017 13:03:37 GMT):
the link to the commit should be for the `fabric-sdk-node` repo

jimthematrix (Thu, 08 Jun 2017 13:03:37 GMT):
you got me there ;-)

cbf (Thu, 08 Jun 2017 13:03:53 GMT):
no worries

cbf (Thu, 08 Jun 2017 13:03:56 GMT):
and good catch

cbf (Thu, 08 Jun 2017 13:04:13 GMT):
I also fixed the generated changelog

cbf (Thu, 08 Jun 2017 13:04:21 GMT):
not sure I understood your second comment?

jimthematrix (Thu, 08 Jun 2017 13:05:14 GMT):
the link to the commit should be for the `fabric-sdk-node` repo

cbf (Thu, 08 Jun 2017 13:05:49 GMT):
yes fixed

cbf (Thu, 08 Jun 2017 13:05:54 GMT):
what was the second?

jimthematrix (Thu, 08 Jun 2017 13:07:31 GMT):
the other is you have: ``` -e "s/\[$FAB-[0-9]*$\]/\[\1\](https:\/\/jira.hyperledger.org\/browse\/\1\)/" -e "s/ $FAB-[0-9]*$/ \[\1\](https:\/\/jira.hyperledger.org\/browse\/\1\)/"

jimthematrix (Thu, 08 Jun 2017 13:07:53 GMT):
so it's `-e "s/\[$FAB-[0-9]*$\]/\[\1\](https:\/\/jira.hyperledger.org\/browse\/\1\)/"` twice

yacovm (Thu, 08 Jun 2017 13:08:49 GMT):
btw - If it's sed you can do "s/a/b/ ; s/c/d/ "

cbf (Thu, 08 Jun 2017 13:11:04 GMT):
ah

silliman (Thu, 08 Jun 2017 14:56:34 GMT):
Has left the channel.

jimthematrix (Thu, 08 Jun 2017 19:18:43 GMT):
https://gerrit.hyperledger.org/r/#/c/10321/ - for rc1 stream, docs only

jeffgarratt (Thu, 08 Jun 2017 23:42:40 GMT):
https://gerrit.hyperledger.org/r/#/c/10237/ - +2d ready to submit

jyellick (Fri, 09 Jun 2017 03:42:59 GMT):
Looks like release has been cut (I see https://gerrit.hyperledger.org/r/#/c/10301/ ) are we good to resume merging?

cbf (Fri, 09 Jun 2017 10:19:43 GMT):
yes, sorry - I have held off the announce because waiting for Jonatan to review the note.

mastersingh24 (Fri, 09 Jun 2017 11:19:24 GMT):
2 easy ones: https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open

muralisr (Fri, 09 Jun 2017 11:44:43 GMT):
done @mastersingh24

mastersingh24 (Fri, 09 Jun 2017 13:21:24 GMT):
A series from @jyellick - https://gerrit.hyperledger.org/r/#/q/owner:jyellick%2540us.ibm.com+status:open (a majority of these are an easy review)

jeffgarratt (Fri, 09 Jun 2017 13:48:49 GMT):
https://gerrit.hyperledger.org/r/#/c/10237/ - ready to submit

jeffgarratt (Fri, 09 Jun 2017 13:48:49 GMT):
https://gerrit.hyperledger.org/r/#/c/10237/ - ready to submit, adds sub-selection of members of consortium

kostas (Fri, 09 Jun 2017 15:11:38 GMT):
Some easy ones to get going and clear the stack: https://gerrit.hyperledger.org/r/#/c/10249/ https://gerrit.hyperledger.org/r/#/c/10385/

kostas (Fri, 09 Jun 2017 15:22:22 GMT):
Also this: https://gerrit.hyperledger.org/r/#/c/10163/

yacovm (Fri, 09 Jun 2017 15:36:52 GMT):
https://gerrit.hyperledger.org/r/#/c/10353/ @mastersingh24 this one on the left is ready for scrutiny

yacovm (Fri, 09 Jun 2017 16:40:21 GMT):
https://gerrit.hyperledger.org/r/#/c/10403/ Disabling a brittle test I don't know why they show up only after they are merged :(

jyellick (Fri, 09 Jun 2017 17:00:09 GMT):
https://gerrit.hyperledger.org/r/#/c/10331/ https://gerrit.hyperledger.org/r/#/c/10333/ Two easy tiny ones, just adding a nil check (they are bugs, but currently tracked as sub-tasks of 3831, which now has 5 votes)

cbf (Sat, 10 Jun 2017 20:42:09 GMT):
https://gerrit.hyperledger.org/r/#/c/9993/

yacovm (Sat, 10 Jun 2017 21:49:23 GMT):
Hi all: https://gerrit.hyperledger.org/r/#/c/10437/ `[FAB-4533] Use context cancellations in deliveryservice` Fixes a bug in deliveryservice induced by underlying grpc bug and also re-introduces 2 skipped tests that now don't fail after the fix

yacovm (Sat, 10 Jun 2017 21:49:23 GMT):
Hi all: `https://gerrit.hyperledger.org/r/#/c/10437/` `[FAB-4533] Use context cancellations in deliveryservice` Fixes a bug in deliveryservice induced by underlying grpc bug and also re-introduces 2 skipped tests that now don't fail after the fix

yacovm (Sun, 11 Jun 2017 14:37:47 GMT):
Hi all A few bug fixes: https://gerrit.hyperledger.org/r/#/c/10259/ - tough one, not for the faint of heart https://gerrit.hyperledger.org/r/#/c/10439/ - easy one https://gerrit.hyperledger.org/r/#/c/10447/ - an even easier one

yacovm (Mon, 12 Jun 2017 07:56:08 GMT):
Another trivial change - only 2 LOC https://gerrit.hyperledger.org/r/#/c/10449/

yacovm (Mon, 12 Jun 2017 07:56:08 GMT):
~ Another trivial change - only 2 LOC https://gerrit.hyperledger.org/r/#/c/10449/ ~

yacovm (Mon, 12 Jun 2017 09:45:11 GMT):
And another trivial one - just fixes a missing nil check https://gerrit.hyperledger.org/r/#/c/10461/

yacovm (Mon, 12 Jun 2017 09:45:11 GMT):
~ And another trivial one - just fixes a missing nil check https://gerrit.hyperledger.org/r/#/c/10461/ ~ Thanks for the merges @mastersingh24 !

rameshthoomu (Mon, 12 Jun 2017 15:03:39 GMT):
need one more +2 on this https://gerrit.hyperledger.org/r/#/c/10325/

Sandeep (Mon, 12 Jun 2017 16:19:58 GMT):
Has joined the channel.

Sandeep (Mon, 12 Jun 2017 16:21:51 GMT):
Hi all. I have added Auction App Daily and Weekly to Daily and Weekly Test Suite. Please Review https://gerrit.hyperledger.org/r/#/c/9949/ - Daily https://gerrit.hyperledger.org/r/#/c/9953/ - Weekly

Sandeep (Mon, 12 Jun 2017 16:21:51 GMT):
Hi all. I have added Auction App to the Daily and Weekly Test Suite. Please Review https://gerrit.hyperledger.org/r/#/c/9949/ - Daily https://gerrit.hyperledger.org/r/#/c/9953/ - Weekly

cbf (Mon, 12 Jun 2017 16:50:55 GMT):
https://gerrit.hyperledger.org/r/#/c/10413/

latitiah (Mon, 12 Jun 2017 20:08:39 GMT):
I need 1 more +2 on: https://gerrit.hyperledger.org/r/#/c/10139/ (Talking to ramesh about why the other 3 have unrelated failures in CI): https://gerrit.hyperledger.org/r/#/c/9669/ (behave peer utilities) https://gerrit.hyperledger.org/r/#/c/10415/ (solo docker composition file) https://gerrit.hyperledger.org/r/#/c/10417/ (kafka docker composition file)

cbf (Mon, 12 Jun 2017 20:25:16 GMT):
https://gerrit.hyperledger.org/r/#/c/10413/ needs love please

yacovm (Mon, 12 Jun 2017 20:37:12 GMT):
2 easy ones - just fixed some misleading comments in core.yaml and a proto file https://gerrit.hyperledger.org/r/#/c/10493/ https://gerrit.hyperledger.org/r/#/c/10495/

kostas (Mon, 12 Jun 2017 22:05:29 GMT):
This one's good to go: https://gerrit.hyperledger.org/r/#/c/10489/

cbf (Mon, 12 Jun 2017 22:58:56 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=3Xy2KZ6CHzcxTQLfi) @cbf needs one more +2 please

cbf (Tue, 13 Jun 2017 00:16:00 GMT):
https://gerrit.hyperledger.org/r/#/c/10485/

cbf (Tue, 13 Jun 2017 00:28:45 GMT):
https://gerrit.hyperledger.org/r/#/c/10481/

cbf (Tue, 13 Jun 2017 00:28:59 GMT):
https://gerrit.hyperledger.org/r/#/c/10487/

cbf (Tue, 13 Jun 2017 00:30:02 GMT):
https://gerrit.hyperledger.org/r/#/c/10497/

JonathanLevi (Tue, 13 Jun 2017 03:47:25 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=iphGTAfcvbDEGQodS) Merged.

C0rWin (Tue, 13 Jun 2017 07:03:05 GMT):
https://gerrit.hyperledger.org/r/#/c/10315/ - prevents peer from crashing on receiving wrong genesis block while joining the chain (returns error instead)

JonathanLevi (Tue, 13 Jun 2017 07:03:52 GMT):
https://chat.hyperledger.org/channel/fabric-release?msg=gLfSiAgymeynuTAaW

cbf (Tue, 13 Jun 2017 11:01:36 GMT):
https://gerrit.hyperledger.org/r/#/c/10139/ and https://gerrit.hyperledger.org/r/#/c/10401/

kostas (Tue, 13 Jun 2017 15:09:06 GMT):
https://gerrit.hyperledger.org/r/#/c/10531/ a one-liner of text

cbf (Tue, 13 Jun 2017 15:50:35 GMT):
need one more on https://gerrit.hyperledger.org/r/#/c/10483/

muralisr (Tue, 13 Jun 2017 16:05:12 GMT):
@cbf done

cbf (Tue, 13 Jun 2017 17:00:15 GMT):
thanks!

jimthematrix (Tue, 13 Jun 2017 17:39:13 GMT):
https://gerrit.hyperledger.org/r/#/c/10511/ - API docs part II

cbf (Tue, 13 Jun 2017 19:10:24 GMT):
https://gerrit.hyperledger.org/r/#/c/10485/ can someone please review and merge this? just changes license headers

cbf (Tue, 13 Jun 2017 19:10:38 GMT):
for fabrc-test-resources

cbf (Tue, 13 Jun 2017 19:18:55 GMT):
https://gerrit.hyperledger.org/r/#/c/10431/

latitiah (Tue, 13 Jun 2017 20:04:36 GMT):
Behave System Test CRs: https://gerrit.hyperledger.org/r/#/c/9669/ https://gerrit.hyperledger.org/r/#/c/10415/ https://gerrit.hyperledger.org/r/#/c/10417/

cbf (Tue, 13 Jun 2017 22:10:17 GMT):
https://gerrit.hyperledger.org/r/#/c/10525/

cbf (Tue, 13 Jun 2017 22:40:01 GMT):
helloooo https://gerrit.hyperledger.org/r/#/c/10485/

scottz (Tue, 13 Jun 2017 23:48:35 GMT):
Are we merging testing materials and scripts cleanup? If so, our team could use some +2 help: https://gerrit.hyperledger.org/r/#/c/10527/ https://gerrit.hyperledger.org/r/#/c/9949/ https://gerrit.hyperledger.org/r/#/c/9953/ https://gerrit.hyperledger.org/r/#/c/9669/ https://gerrit.hyperledger.org/r/#/c/10415/ https://gerrit.hyperledger.org/r/#/c/10417/

cbf (Wed, 14 Jun 2017 00:25:16 GMT):
done

kostas (Wed, 14 Jun 2017 01:10:21 GMT):
https://gerrit.hyperledger.org/r/#/c/10549/ (one line)

binhn (Wed, 14 Jun 2017 03:34:27 GMT):
@scottz 10527 has merge conflict

kostas (Wed, 14 Jun 2017 06:29:47 GMT):
These are quite easy: https://gerrit.hyperledger.org/r/#/c/10557/

kostas (Wed, 14 Jun 2017 06:29:47 GMT):
These are quite easy: https://gerrit.hyperledger.org/r/#/c/10557/ https://gerrit.hyperledger.org/r/#/c/10559/ https://gerrit.hyperledger.org/r/#/c/10561/

guoger (Wed, 14 Jun 2017 08:01:15 GMT):
https://gerrit.hyperledger.org/r/#/c/10565/ fix broken test introduced by 94d7e9 @kostas @jyellick

jimthematrix (Wed, 14 Jun 2017 13:24:33 GMT):
https://gerrit.hyperledger.org/r/#/c/10553/ - docs only but critical information on how to use the stateful APIs

markparz (Wed, 14 Jun 2017 14:18:33 GMT):
can this be clicked to merged https://gerrit.hyperledger.org/r/#/c/10183/

Ratnakar (Wed, 14 Jun 2017 14:30:27 GMT):
https://gerrit.hyperledger.org/r/#/c/10527 - Rebased due to merge conflicts

cbf (Wed, 14 Jun 2017 14:33:59 GMT):
@jimthematrix build errors

jimthematrix (Wed, 14 Jun 2017 14:43:24 GMT):
just reverified, x86 builds still fail from time to time randomly

jimthematrix (Wed, 14 Jun 2017 14:43:31 GMT):
s390 builds have been rock solid

jimthematrix (Wed, 14 Jun 2017 14:43:51 GMT):
also they trigger sooner and run faster

cbf (Wed, 14 Jun 2017 16:37:49 GMT):
https://gerrit.hyperledger.org/r/#/c/9263/ is a WIP but still would like some feedback on the content thus far esp from @muralisr @binhn @nickgaski @odowdaibm

jimthematrix (Wed, 14 Jun 2017 17:00:46 GMT):
https://gerrit.hyperledger.org/r/#/c/10553/ - build is green now and comments from Bret addressed, @cbf

cbf (Wed, 14 Jun 2017 17:11:22 GMT):
done

nickgaski (Wed, 14 Jun 2017 17:12:13 GMT):
on the way @cbf

cbf (Wed, 14 Jun 2017 17:12:23 GMT):
thx

jeffgarratt (Wed, 14 Jun 2017 19:48:19 GMT):
@binhn @jyellick @kostas this one augments behave to account for latest channel naming convention change https://gerrit.hyperledger.org/r/#/c/10587/

latitiah (Wed, 14 Jun 2017 20:50:29 GMT):
@cbf https://gerrit.hyperledger.org/r/#/c/8845/ - CR needed to start adding behave tests to the daily CI. This includes stopping and starting peers

jimthematrix (Thu, 15 Jun 2017 01:52:14 GMT):
https://gerrit.hyperledger.org/r/#/c/10307/ - docs update for RTD to point to the new node SDK doc location, should be merged asap

yacovm (Thu, 15 Jun 2017 12:38:22 GMT):
@JonathanLevi @cbf Can we get this https://gerrit.hyperledger.org/r/#/c/10623/ in ? It's not a bug but this code has a potential to become a bug

C0rWin (Thu, 15 Jun 2017 12:41:25 GMT):
pretty simple code cleanups: https://gerrit.hyperledger.org/r/#/c/10627/

cbf (Thu, 15 Jun 2017 13:16:10 GMT):
@yacovm is there a reason that this is not being deferred to post 1.0? https://gerrit.hyperledger.org/r/#/c/10623/

cbf (Thu, 15 Jun 2017 13:16:42 GMT):
the overflow could be a bug in waiting... yes, it is only 5 LOC but technically...

yacovm (Thu, 15 Jun 2017 13:17:26 GMT):
well no but at the same time I have seen change sets that refactor the code as part of UT coverage. I'm good with it being postponed of course.

cbf (Thu, 15 Jun 2017 13:17:47 GMT):
having the test added is good

cbf (Thu, 15 Jun 2017 13:18:03 GMT):
I guess I am ok with this then

markparz (Thu, 15 Jun 2017 15:52:31 GMT):
can we flip the merge bit on https://gerrit.hyperledger.org/r/#/c/10183/

JonathanLevi (Thu, 15 Jun 2017 16:54:16 GMT):
@markparz, it is approved (despite/in addition to the comment there from Joe Alewin, who is asking for more app samples as well as diagrams). It cannot get merged (yet) due to its dependence on 2 other CRs.

kostas (Thu, 15 Jun 2017 20:02:13 GMT):
https://gerrit.hyperledger.org/r/#/c/10609/

C0rWin (Thu, 15 Jun 2017 22:17:11 GMT):
https://gerrit.hyperledger.org/r/#/c/10641/

cbf (Fri, 16 Jun 2017 01:51:06 GMT):
https://gerrit.hyperledger.org/r/#/c/10507/

cbf (Fri, 16 Jun 2017 01:52:14 GMT):
however, please do not merge yet!

cbf (Fri, 16 Jun 2017 01:53:25 GMT):
https://gerrit.hyperledger.org/r/#/c/10583/

markparz (Fri, 16 Jun 2017 15:46:32 GMT):
had to abandon a fix and redo, couldn't fix a bogus merge conflict... please see https://gerrit.hyperledger.org/r/#/c/10707/1

kostas (Fri, 16 Jun 2017 16:06:38 GMT):
https://gerrit.hyperledger.org/r/#/c/10555/ (documentation for getting the Kafka-based ordering service up and running)

jyellick (Fri, 16 Jun 2017 16:39:51 GMT):
https://gerrit.hyperledger.org/r/#/c/10689/ Also a doc one, adding an example of how to add an org to a channel

cbf (Sat, 17 Jun 2017 22:31:50 GMT):
https://gerrit.hyperledger.org/r/#/c/10673/ https://gerrit.hyperledger.org/r/#/c/10675/ address missing license headers

cbf (Sat, 17 Jun 2017 22:32:17 GMT):
also too https://gerrit.hyperledger.org/r/#/c/10679/ @greg.haskins

cbf (Sat, 17 Jun 2017 22:33:41 GMT):
https://gerrit.hyperledger.org/r/#/c/10677/ some documentation cleanup to delete obsoleted doc files (no longer referenced or "WIP" pages that had no content)

cbf (Sat, 17 Jun 2017 22:33:57 GMT):
also deleted a bunch of images not used anywhere

cbf (Sun, 18 Jun 2017 02:13:55 GMT):
https://gerrit.hyperledger.org/r/#/c/10743/ add a basic network config for application development and sample apps, etc

cbf (Sun, 18 Jun 2017 08:52:15 GMT):
https://gerrit.hyperledger.org/r/#/c/10677/

muralisr (Sun, 18 Jun 2017 14:30:09 GMT):
@cbf in https://gerrit.hyperledger.org/r/#/c/10675/, do we need the test/regression/daily/README.rst.orig file ?

cbf (Sun, 18 Jun 2017 16:05:06 GMT):
up to @scottz I suspect... anyone can get it from an older commit

C0rWin (Sun, 18 Jun 2017 22:12:29 GMT):
simple test fix: https://gerrit.hyperledger.org/r/#/c/10755/

cbf (Mon, 19 Jun 2017 01:53:26 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=Q54XthE7DxhLepipJ) @cbf bump

sfukazu (Mon, 19 Jun 2017 06:36:01 GMT):
Has joined the channel.

cbf (Mon, 19 Jun 2017 09:17:01 GMT):
https://gerrit.hyperledger.org/r/#/c/9263/ please esp @muralisr and @binhn

muralisr (Mon, 19 Jun 2017 12:32:17 GMT):
will review today after scrum @cbf (its getting pretty close I thought last time)

scottz (Mon, 19 Jun 2017 13:27:53 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=FbgFMxArPY9fvyD4q) @muralisr no; that .orig file is not needed

mastersingh24 (Mon, 19 Jun 2017 15:22:49 GMT):
https://gerrit.hyperledger.org/r/#/c/10775/ - easy one - restrict fabric-ca-server to TLS 1.2

jimthematrix (Mon, 19 Jun 2017 20:36:49 GMT):
https://gerrit.hyperledger.org/r/#/c/10791/ - test code only but clears up a lot of confusions

kostas (Tue, 20 Jun 2017 01:40:50 GMT):
https://gerrit.hyperledger.org/r/#/c/10591/ - great fix by Luis

cbf (Tue, 20 Jun 2017 01:48:06 GMT):
https://gerrit.hyperledger.org/r/#/c/10803/

cbf (Tue, 20 Jun 2017 02:23:52 GMT):
https://gerrit.hyperledger.org/r/#/c/10805/ was https://gerrit.hyperledger.org/r/#/c/10743/

cbf (Tue, 20 Jun 2017 02:23:52 GMT):
https://gerrit.hyperledger.org/r/#/c/10805/ was https://gerrit.hyperledger.org/r/#/c/10475/

cbf (Tue, 20 Jun 2017 02:25:19 GMT):
https://gerrit.hyperledger.org/r/#/c/10807/ was https://gerrit.hyperledger.org/r/#/c/10743/

Ratnakar (Tue, 20 Jun 2017 05:12:10 GMT):
https://gerrit.hyperledger.org/r/#/c/10815 ^^^ @jimthematrix

dongqi (Tue, 20 Jun 2017 08:38:19 GMT):
Has joined the channel.

jeffgarratt (Tue, 20 Jun 2017 15:15:41 GMT):
@binhn @mastersingh24 @adc https://gerrit.hyperledger.org/r/#/c/10841/ is in jobbuilder. Will update as soon as passes. Then @adc can rebase and his CR should pass behave. Then he will need to incorporate @mastersingh24 changes.

adc (Tue, 20 Jun 2017 15:30:01 GMT):
@mastersingh24, at this point you can push directly on my change-set :)

jeffgarratt (Tue, 20 Jun 2017 16:28:58 GMT):
@binhn @mastersingh24 @adc https://gerrit.hyperledger.org/r/#/c/10841/ has passed and ready for review

jeffgarratt (Tue, 20 Jun 2017 16:28:58 GMT):
@binhn @mastersingh24 @adc @kostas https://gerrit.hyperledger.org/r/#/c/10841/ has passed and ready for review

JonathanLevi (Tue, 20 Jun 2017 17:29:38 GMT):
@jeffgarratt A nice one ^^^. Merged.

jeffgarratt (Tue, 20 Jun 2017 17:33:41 GMT):
@JonathanLevi thanks so much!

cbf (Tue, 20 Jun 2017 18:04:45 GMT):
so, I feel like a broken record but https://gerrit.hyperledger.org/r/#/c/10507/ and https://gerrit.hyperledger.org/r/#/c/10805/ are the refactored Getting Started (now build your first network) and I would really like to get this into RC1 if we do end up cutting a release

cbf (Tue, 20 Jun 2017 18:05:34 GMT):
also, the other samples https://gerrit.hyperledger.org/r/#/c/10803/ https://gerrit.hyperledger.org/r/#/c/10807/ and https://gerrit.hyperledger.org/r/#/c/10809/

cbf (Tue, 20 Jun 2017 18:08:54 GMT):
now it should be noted that https://gerrit.hyperledger.org/r/#/c/10507 should be the last to be merged, just before we cut the release

cbf (Tue, 20 Jun 2017 18:09:06 GMT):
@JonathanLevi ^^

cbf (Tue, 20 Jun 2017 18:10:05 GMT):
finally, https://gerrit.hyperledger.org/r/#/c/9263/

bmos299 (Tue, 20 Jun 2017 19:44:40 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=mWXqWLFRCidE7h3Am) @cbf CR10507 has been merged which breaks the http://hyperledger-fabric.readthedocs.io/en/latest/samples.html because the code is not in the fabric-samples repo yet.

cbf (Tue, 20 Jun 2017 21:51:23 GMT):
https://gerrit.hyperledger.org/r/#/c/10867/ restores getting started

cbf (Tue, 20 Jun 2017 21:51:44 GMT):
yes, I had asked that it not be merged, but this CR restores Getting Started

cbf (Tue, 20 Jun 2017 21:52:01 GMT):
I will stage the Getting Started change with the release

cbf (Tue, 20 Jun 2017 23:25:19 GMT):
@here ^^ please

JonathanLevi (Wed, 21 Jun 2017 05:52:59 GMT):
@cbf: I think history has been written in front of our eyes today, in the sense that the *fabric-samples* are merged! :-) Good night.

JonathanLevi (Wed, 21 Jun 2017 05:53:50 GMT):
BTW: We can discuss whether we would like to have 2x `+2` there, once these get stabilized.

cbf (Wed, 21 Jun 2017 09:37:15 GMT):
it was supposed to be 2+2 will talk to @rjones

cbf (Wed, 21 Jun 2017 11:52:25 GMT):
once https://gerrit.hyperledger.org/r/#/c/9263/ finishes CI, I think it is ready to be merged... I removed the testing chaincode using --peer-chaincodedev mode section as @nickgaski has that covered in a separate CR. I also removed the sample code as this is now headed for fabric-samples repo

cbf (Wed, 21 Jun 2017 12:11:44 GMT):
once https://gerrit.hyperledger.org/r/#/c/10795/ clears CI it should be ready to be merged

cbf (Wed, 21 Jun 2017 12:12:11 GMT):
@jimthematrix @bretharrison

rameshthoomu (Wed, 21 Jun 2017 14:50:26 GMT):
need one more +2 on this https://gerrit.hyperledger.org/r/#/c/10893/

rjones (Wed, 21 Jun 2017 15:34:46 GMT):
@cbf fabric-samples is 2+2 now.

mastersingh24 (Wed, 21 Jun 2017 15:46:02 GMT):
https://gerrit.hyperledger.org/r/#/c/10825/ could use some eyes

binhn (Wed, 21 Jun 2017 16:15:46 GMT):
very simple update on comments to support fab-4751 https://gerrit.hyperledger.org/r/#/c/10919

yacovm (Wed, 21 Jun 2017 16:20:20 GMT):
@binhn should we add there that the chaincode port in production is supposed to be protected by a FW?

yacovm (Wed, 21 Jun 2017 16:20:36 GMT):
It doesn't say why it's not recommended for production

binhn (Wed, 21 Jun 2017 16:22:23 GMT):
@yacovm i don't think we need to spell everything out

yacovm (Wed, 21 Jun 2017 16:22:34 GMT):
all right, fine by me

muralisr (Wed, 21 Jun 2017 17:05:58 GMT):
ok then

muralisr (Wed, 21 Jun 2017 17:06:03 GMT):
will +2 merge

mastersingh24 (Wed, 21 Jun 2017 17:26:58 GMT):
one more on the way to finishing FAB-4626 - https://gerrit.hyperledger.org/r/#/c/10915/

mastersingh24 (Wed, 21 Jun 2017 17:27:05 GMT):
(we are getting there)

binhn (Wed, 21 Jun 2017 18:12:47 GMT):
ok

JonathanLevi (Wed, 21 Jun 2017 18:43:00 GMT):
Gari, a nice one. Do we have an estimate for https://jira.hyperledger.org/browse/FAB-4626 ?

JonathanLevi (Wed, 21 Jun 2017 18:43:41 GMT):
If you are coding it, then we can wait... ;-)

JonathanLevi (Wed, 21 Jun 2017 18:43:58 GMT):
@adc What are your thoughts?

mastersingh24 (Wed, 21 Jun 2017 20:27:15 GMT):
Hey - sorry - should be done in the next couple of hours

mastersingh24 (Wed, 21 Jun 2017 20:27:42 GMT):
need to coordinate some changes with the NodeSDK (modify the e2e test artifacts used by Node) and possible the Java SDK as well

mastersingh24 (Wed, 21 Jun 2017 20:27:53 GMT):
Then one last change for fabric and we should be good (I hope)

muralisr (Wed, 21 Jun 2017 20:37:33 GMT):
a simple one https://gerrit.hyperledger.org/r/#/c/10943 to get `make dist-all` to build successfully (was breaking at a windows build)

muralisr (Wed, 21 Jun 2017 20:37:55 GMT):
(thanks @C0rWin for comments...)

latitiah (Wed, 21 Jun 2017 20:41:10 GMT):
https://gerrit.hyperledger.org/r/#/c/8845/ - behave system tests

C0rWin (Wed, 21 Jun 2017 21:06:28 GMT):
https://gerrit.hyperledger.org/r/#/c/10897/ need last vote to get in :)

cbf (Thu, 22 Jun 2017 04:19:23 GMT):
https://gerrit.hyperledger.org/r/#/c/9263/

cbf (Thu, 22 Jun 2017 04:20:35 GMT):
there are a bunch of CRs waiting for one more review https://gerrit.hyperledger.org/r/#/q/is:open+label:Verified%252B1++label:Code-Review%252B2+NOT+label:Code-Review-1+NOT+label:Code-Review-2+is:mergeable

mastersingh24 (Thu, 22 Jun 2017 13:03:26 GMT):
Still working to close all of the tasks under FAB-4626 - this one is next: https://gerrit.hyperledger.org/r/#/c/10999/

mastersingh24 (Thu, 22 Jun 2017 13:34:39 GMT):
and this one for the Java SDK as well: https://gerrit.hyperledger.org/r/#/c/11005/

rameshthoomu (Thu, 22 Jun 2017 14:50:00 GMT):
need one more +2 on this https://gerrit.hyperledger.org/r/#/c/10943.. This is blocking fabric-binaries release CI job..

mastersingh24 (Thu, 22 Jun 2017 14:52:18 GMT):
@rameshthoomu - merged - can you verify it work and close the JIRA ?

rameshthoomu (Thu, 22 Jun 2017 14:52:47 GMT):
thanks @mastersingh24 @muralisr .. Will update the status..

mastersingh24 (Thu, 22 Jun 2017 20:23:16 GMT):
Folks - this little guy needs one more +2 https://gerrit.hyperledger.org/r/#/c/11021/

mastersingh24 (Thu, 22 Jun 2017 20:23:28 GMT):
That should finish off the hard parts of FAB-4626

mastersingh24 (Thu, 22 Jun 2017 23:19:21 GMT):
https://gerrit.hyperledger.org/r/#/c/10913/ needs one more +2

rameshthoomu (Fri, 23 Jun 2017 02:15:36 GMT):
https://gerrit.hyperledger.org/r/#/c/11027/ need review on this please ..

mastersingh24 (Fri, 23 Jun 2017 02:17:30 GMT):
https://gerrit.hyperledger.org/r/#/c/11043/ - updates byfn based on FAB-4626 changes

AdnanC (Fri, 23 Jun 2017 13:51:21 GMT):
Test tool update https://gerrit.hyperledger.org/r/#/c/10713/ already reviewed by Barry and others in Quality team

AdnanC (Fri, 23 Jun 2017 13:51:21 GMT):
Test tool update https://gerrit.hyperledger.org/r/#/c/10713/ alreay reviewed by others in Quality team

AdnanC (Fri, 23 Jun 2017 13:51:21 GMT):
Test tool update https://gerrit.hyperledger.org/r/#/c/10713/ already reviewed by others in Quality team

cbf (Fri, 23 Jun 2017 13:58:37 GMT):
can we get eyes on https://gerrit.hyperledger.org/r/#/c/9263/ please? I know @muralisr is looking

rameshthoomu (Fri, 23 Jun 2017 14:16:54 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=XmcdHDDr5jo6HBerC) @AdnanC this patch reduces daily test suite build time.. This has been tested in sandbox CI.. see the build result here https://jenkins.hyperledger.org/sandbox/job/testdaily/9/console

wyanglau (Fri, 23 Jun 2017 16:06:45 GMT):
Has joined the channel.

cbf (Fri, 23 Jun 2017 16:13:11 GMT):
https://gerrit.hyperledger.org/r/#/c/10975/

cbf (Fri, 23 Jun 2017 16:46:34 GMT):
https://gerrit.hyperledger.org/r/#/c/10869/ please???

yacovm (Fri, 23 Jun 2017 16:52:22 GMT):
why is the binary there though @cbf ?

cbf (Fri, 23 Jun 2017 16:54:11 GMT):
oh good catch, need to add to gitignore

cbf (Fri, 23 Jun 2017 17:01:51 GMT):
good catch by @yacovm I hadn't included the binaries in .gitignore

cbf (Fri, 23 Jun 2017 17:02:06 GMT):
please revisit https://gerrit.hyperledger.org/r/#/c/10869/

cbf (Fri, 23 Jun 2017 17:02:31 GMT):
need one more on https://gerrit.hyperledger.org/r/#/c/9263/

JonathanLevi (Fri, 23 Jun 2017 17:31:08 GMT):
@here: we have initiating a MERGE FREEZE just now https://chat.hyperledger.org/channel/fabric-release?msg=jRWGZsCFbMZ8EXpMc

JonathanLevi (Fri, 23 Jun 2017 17:31:08 GMT):
@here: we have initiating a MERGE FREEZE just now https://chat.hyperledger.org/channel/fabric-pr-review?msg=yeaJwmz2is2JB8x8R

JonathanLevi (Fri, 23 Jun 2017 17:31:08 GMT):
@here: we are initiating a MERGE FREEZE just now. https://chat.hyperledger.org/channel/fabric-pr-review?msg=yeaJwmz2is2JB8x8R

cbf (Fri, 23 Jun 2017 17:37:21 GMT):
https://chat.hyperledger.org/channel/fabric-release?msg=QjN8AHYrGTgS4WTCd

dhuseby (Fri, 23 Jun 2017 17:43:19 GMT):
sweet

dhuseby (Fri, 23 Jun 2017 17:43:32 GMT):
i wish there was a way to lock jira so that nobody can hit the merge button

cbf (Fri, 23 Jun 2017 17:45:32 GMT):
it's gerrit

cbf (Fri, 23 Jun 2017 17:45:58 GMT):
but yeah, there should be a way of doing that by changing the policy to limit merges on various projects to the release managers

yacovm (Fri, 23 Jun 2017 17:46:11 GMT):
I guess if you set the database of gerrit to READ ONLY that'll do the trick

yacovm (Fri, 23 Jun 2017 17:46:11 GMT):
I guess if you set the database of gerrit to READ ONLY that'll do the trick (jk, not really suggesting that...)

cbf (Fri, 23 Jun 2017 17:46:14 GMT):
@rjones would know

rjones (Fri, 23 Jun 2017 17:48:56 GMT):
I don't know how to implement that off the top of my head. I imagine it is possible - but I don't know enough prolog to make it happen

cbf (Fri, 23 Jun 2017 18:33:36 GMT):
can't we have a policy staged that we toggle with the normal policy?

rjones (Fri, 23 Jun 2017 18:44:44 GMT):
right now doing that means setting up two sets of committers (fine) and either changing group membership in LDAP each time (ugh) or changing project permissions for each project twice per release (also ugh).

cbf (Fri, 23 Jun 2017 19:17:20 GMT):
ok, probably just use honor system then

mastersingh24 (Fri, 23 Jun 2017 19:42:15 GMT):
It's actually pretty easy to create submit rules

rjones (Fri, 23 Jun 2017 19:42:37 GMT):
@mastersingh24 if you could help with prolog I would greatly appreciate it

mastersingh24 (Fri, 23 Jun 2017 19:42:48 GMT):
I will give it a shot

rjones (Fri, 23 Jun 2017 19:42:50 GMT):
@mastersingh24 our submit rules are a hash right now and I need help

mastersingh24 (Fri, 23 Jun 2017 19:43:22 GMT):
What do we want to do? For example, we could limit submit to a specific user and/or we could block all submits as well

rjones (Fri, 23 Jun 2017 19:43:35 GMT):
is there a better forum to discuss?

rjones (Fri, 23 Jun 2017 19:44:02 GMT):
#ci-pipeline possibly?

mastersingh24 (Fri, 23 Jun 2017 19:44:04 GMT):
not sure - I'll see if I can find some stuff and maybe you and I can chat about it?

mastersingh24 (Fri, 23 Jun 2017 19:44:12 GMT):
I did this once before a while back

mastersingh24 (Fri, 23 Jun 2017 19:45:29 GMT):
sure - I'll post over there

cbf (Sat, 24 Jun 2017 01:21:51 GMT):
https://gerrit.hyperledger.org/r/#/c/11111/3

muralisr (Sat, 24 Jun 2017 01:24:31 GMT):
^^^ @cbf +2ed

JonathanLevi (Sat, 24 Jun 2017 01:25:14 GMT):
Merged. CODE FREEZE *END*

JonathanLevi (Sat, 24 Jun 2017 01:25:22 GMT):
We can get back to normal.

cbf (Sat, 24 Jun 2017 01:37:37 GMT):
tested first-network, basic-network

cbf (Sat, 24 Jun 2017 01:37:39 GMT):
AOKAY

Ratnakar (Sat, 24 Jun 2017 04:50:36 GMT):
fabric-sample app fabrcar is not working on rc1 ,here are the chanegs https://gerrit.hyperledger.org/r/#/c/11119

Ratnakar (Sat, 24 Jun 2017 04:50:36 GMT):
fabric-sample app fabrcar is not working on rc1 ,here is the fix https://gerrit.hyperledger.org/r/#/c/11119

cbf (Sat, 24 Jun 2017 14:28:56 GMT):
done

rameshthoomu (Sat, 24 Jun 2017 19:11:06 GMT):
Need review on this https://gerrit.hyperledger.org/r/#/c/11127

rameshthoomu (Sat, 24 Jun 2017 19:11:50 GMT):
This path fix the Daily Auction Chaincode test failures

rameshthoomu (Sat, 24 Jun 2017 19:11:50 GMT):
This patch fix the Daily Auction Chaincode test failures

mastersingh24 (Sat, 24 Jun 2017 21:02:44 GMT):
easy one - https://gerrit.hyperledger.org/r/#/c/10843/

mastersingh24 (Mon, 26 Jun 2017 12:03:49 GMT):
Two pretty easy ones for fabric-ca: https://gerrit.hyperledger.org/r/11129 https://gerrit.hyperledger.org/r/11145

mastersingh24 (Mon, 26 Jun 2017 14:27:16 GMT):
https://gerrit.hyperledger.org/r/#/c/11149/ - my attempt to add a note for Docker Toolbox / Docker for Windows / macOS users

mastersingh24 (Mon, 26 Jun 2017 14:28:46 GMT):
@lehors ^^^^^

rameshthoomu (Mon, 26 Jun 2017 14:52:54 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/10713/

joe-alewine (Mon, 26 Jun 2017 15:23:04 GMT):
If I could just urge any maintainer -- other than Chris, who has already obliged -- to give a +2 to https://gerrit.hyperledger.org/r/#/c/10971 All that's been done here is to update images (and remove some others) to conform to our current image styles. Without a merge this doc looks very out of sync with the new Writing Your First App doc. These images will change again soon -- the design team pushed these out to help improve the look of the doc but is working on finalized versions -- but even this intermediary step would help make the docs look more organized and professional. Thank you.

mastersingh24 (Mon, 26 Jun 2017 17:00:55 GMT):
one more time: https://gerrit.hyperledger.org/r/#/q/owner:%22Gari+Singh%22+status:open

mastersingh24 (Mon, 26 Jun 2017 17:00:57 GMT):
;)

lehors (Mon, 26 Jun 2017 17:52:12 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=AejsLNDomKzXdNjy5) @mastersingh24 I have to admit I didn't know about that, I happen to always have had things under C:\Users so I guess I didn't get to deal with the consequences of not doing so :)

yacovm (Mon, 26 Jun 2017 18:50:08 GMT):
https://gerrit.hyperledger.org/r/#/c/11147/

mastersingh24 (Mon, 26 Jun 2017 19:45:45 GMT):
and this little guy needs one more https://gerrit.hyperledger.org/r/#/c/11129/

mastersingh24 (Mon, 26 Jun 2017 19:57:24 GMT):
And if someone could submit this one I'll be done bugging you all: https://gerrit.hyperledger.org/r/#/c/11145/ ;)

cbf (Tue, 27 Jun 2017 12:50:34 GMT):
https://gerrit.hyperledger.org/r/11187

cbf (Tue, 27 Jun 2017 12:51:09 GMT):
https://gerrit.hyperledger.org/r/#/c/11185/

cbf (Tue, 27 Jun 2017 14:37:35 GMT):
https://gerrit.hyperledger.org/r/#/c/10935/

cbf (Tue, 27 Jun 2017 15:53:12 GMT):
https://gerrit.hyperledger.org/r/11197

cbf (Tue, 27 Jun 2017 21:23:28 GMT):
https://gerrit.hyperledger.org/r/#/c/11205/

cbf (Tue, 27 Jun 2017 21:24:04 GMT):
https://gerrit.hyperledger.org/r/#/c/11193/

cbf (Tue, 27 Jun 2017 21:24:04 GMT):
https://gerrit.hyperledger.org/r/#/c/11199/

cbf (Tue, 27 Jun 2017 21:24:27 GMT):
https://gerrit.hyperledger.org/r/#/c/11193/

gennadyl (Wed, 28 Jun 2017 12:19:30 GMT):
https://gerrit.hyperledger.org/r/#/c/11169/

cbf (Wed, 28 Jun 2017 12:28:25 GMT):
https://gerrit.hyperledger.org/r/#/c/11193/ https://gerrit.hyperledger.org/r/#/c/11197/ https://gerrit.hyperledger.org/r/#/c/11199/ https://gerrit.hyperledger.org/r/#/c/11205/ https://gerrit.hyperledger.org/r/#/c/11207/ need some love

cbf (Wed, 28 Jun 2017 15:58:36 GMT):
one more on this please https://gerrit.hyperledger.org/r/#/c/11197/

cbf (Wed, 28 Jun 2017 15:59:10 GMT):
this was in response to feedback that @weeds shared that ppl were having trouble figuring out how to get the binaries and images without the samples

cbf (Thu, 29 Jun 2017 01:50:50 GMT):
https://gerrit.hyperledger.org/r/#/c/11241/ homebrew installer for fabric tools

cbf (Thu, 29 Jun 2017 01:51:13 GMT):
see README in Formula directory for instructions on how to test

rjones (Thu, 29 Jun 2017 02:03:10 GMT):
```==> Tapping rjones-lf/fabric Cloning into '/usr/local/Homebrew/Library/Taps/rjones-lf/homebrew-fabric'... remote: Counting objects: 7, done. remote: Compressing objects: 100% (6/6), done. remote: Total 7 (delta 1), reused 7 (delta 1), pack-reused 0 Unpacking objects: 100% (7/7), done. Error: Invalid formula: /usr/local/Homebrew/Library/Taps/rjones-lf/homebrew-fabric/Formula/fabric-tools.rb No available formula with the name "fabric-tools" In formula file: /usr/local/Homebrew/Library/Taps/rjones-lf/homebrew-fabric/Formula/fabric-tools.rb Expected to find class FabricTools, but only found: Tools. Error: Cannot tap rjones-lf/fabric: invalid syntax in tap! Rys-iMac:homebrew-fabric ry$ ```

rjones (Thu, 29 Jun 2017 02:06:00 GMT):
when I tap `https://github.com/rjones-lf/homebrew-fabric` I get this error:

rjones (Thu, 29 Jun 2017 02:06:18 GMT):
```Error: Invalid formula: /usr/local/Homebrew/Library/Taps/rjones-lf/homebrew-fabric/Formula/fabric-tools.rb No available formula with the name "fabric-tools" In formula file: /usr/local/Homebrew/Library/Taps/rjones-lf/homebrew-fabric/Formula/fabric-tools.rb Expected to find class FabricTools, but only found: Tools. Error: Cannot tap rjones-lf/fabric: invalid syntax in tap!```

rjones (Thu, 29 Jun 2017 02:07:06 GMT):
and I'm pretty sure I have your change on master: https://github.com/rjones-lf/homebrew-fabric/commits/master

cbf (Thu, 29 Jun 2017 02:18:03 GMT):
one more please https://gerrit.hyperledger.org/r/#/c/11225/

cbf (Thu, 29 Jun 2017 02:19:03 GMT):
@rjones yes, I found that testing my own fork... it just never made it to the gerrit clone

cbf (Thu, 29 Jun 2017 02:19:07 GMT):
thanks for testing!

rjones (Thu, 29 Jun 2017 02:19:21 GMT):
sure thing!

rjones (Thu, 29 Jun 2017 02:25:14 GMT):
I see a suspicious error when I run `peer`:

rjones (Thu, 29 Jun 2017 02:25:18 GMT):
```panic(0x7929c0, 0xc4201fada0) /opt/go/go1.7.linux.amd64/src/runtime/panic.go:500 +0x1a1 ```

rjones (Thu, 29 Jun 2017 02:26:06 GMT):
maybe we have the linux binaries up as Mac OS binaries? or are go binaries platform independent?

cbf (Thu, 29 Jun 2017 10:44:46 GMT):
hmmm

cbf (Thu, 29 Jun 2017 10:45:15 GMT):
that is what's in the tarball

cbf (Thu, 29 Jun 2017 10:45:25 GMT):
we need to check that then

cbf (Thu, 29 Jun 2017 10:53:17 GMT):
@rjones just tried it

cbf (Thu, 29 Jun 2017 10:53:19 GMT):
cbf$ which peer /usr/local/bin/peer cbf$ peer help 2017-06-29 06:52:25.936 EDT [msp] getMspConfig -> WARN 001 Intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts: no such file or directory] 2017-06-29 06:52:25.936 EDT [msp] getMspConfig -> WARN 002 TLS intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts: no such file or directory] 2017-06-29 06:52:25.936 EDT [msp] getMspConfig -> WARN 003 crls folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls: no such file or directory] Usage: peer [flags] peer [command] Available Commands: chaincode Operate a chaincode: install|instantiate|invoke|package|query|signpackage|upgrade. channel Operate a channel: create|fetch|join|list|update. logging Log levels: getlevel|setlevel|revertlevels. node Operate a peer node: start|status. version Print fabric peer version. Flags: --logging-level string Default logging level and overrides, see core.yaml for full syntax --test.coverprofile string Done (default "coverage.cov") -v, --version Display current version of fabric peer server Use "peer [command] --help" for more information about a command. 2017-06-29 06:52:25.956 EDT [main] main -> INFO 004 Exiting..... cbf$ peer version 2017-06-29 06:52:47.532 EDT [msp] getMspConfig -> WARN 001 Intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts: no such file or directory] 2017-06-29 06:52:47.532 EDT [msp] getMspConfig -> WARN 002 TLS intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts: no such file or directory] 2017-06-29 06:52:47.532 EDT [msp] getMspConfig -> WARN 003 crls folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls: no such file or directory] peer: Version: development build Go version: go1.7 OS/Arch: darwin/amd64 Chaincode: Base Image Version: Base Docker Namespace: Base Docker Label: Docker Namepace: 2017-06-29 06:52:47.555 EDT [main] main -> INFO 004 Exiting.....

cbf (Thu, 29 Jun 2017 10:54:24 GMT):
eg seems to be the right architecture and does not panic

cbf (Thu, 29 Jun 2017 12:20:55 GMT):
https://gerrit.hyperledger.org/r/#/c/11197/ needs love please

rameshthoomu (Thu, 29 Jun 2017 14:51:01 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/11233/

JonathanLevi (Thu, 29 Jun 2017 15:17:20 GMT):
@cbf, @rameshthoomu: merged.

cbf (Thu, 29 Jun 2017 15:48:09 GMT):
tx

cbf (Thu, 29 Jun 2017 15:48:23 GMT):
anyone else interested in verifying and reviewing this https://gerrit.hyperledger.org/r/#/c/11241/

cbf (Thu, 29 Jun 2017 15:48:28 GMT):
requires a Mac

rjones (Thu, 29 Jun 2017 16:07:50 GMT):
@cbf I'm interested in debugging this - I'll do a clean install again (or perhaps use ||s to spin up an OS X VM)

cbf (Thu, 29 Jun 2017 16:25:22 GMT):
it worked for me is all I can say... didn't get a panic

rjones (Thu, 29 Jun 2017 16:47:34 GMT):

Message Attachments

cbf (Thu, 29 Jun 2017 18:26:23 GMT):
nope

cbf (Thu, 29 Jun 2017 18:27:22 GMT):
cbf$ which peer /usr/local/bin/peer cbf$ peer help 2017-06-29 14:26:55.944 EDT [msp] getMspConfig -> WARN 001 Intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts: no such file or directory] 2017-06-29 14:26:55.944 EDT [msp] getMspConfig -> WARN 002 TLS intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts: no such file or directory] 2017-06-29 14:26:55.944 EDT [msp] getMspConfig -> WARN 003 crls folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls: no such file or directory] Usage: peer [flags] peer [command] Available Commands: chaincode Operate a chaincode: install|instantiate|invoke|package|query|signpackage|upgrade. channel Operate a channel: create|fetch|join|list|update. logging Log levels: getlevel|setlevel|revertlevels. node Operate a peer node: start|status. version Print fabric peer version. Flags: --logging-level string Default logging level and overrides, see core.yaml for full syntax --test.coverprofile string Done (default "coverage.cov") -v, --version Display current version of fabric peer server Use "peer [command] --help" for more information about a command. 2017-06-29 14:26:55.963 EDT [main] main -> INFO 004 Exiting..... cbf$ peer version 2017-06-29 14:27:07.775 EDT [msp] getMspConfig -> WARN 001 Intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/intermediatecerts: no such file or directory] 2017-06-29 14:27:07.775 EDT [msp] getMspConfig -> WARN 002 TLS intermediate certs folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/tlsintermediatecerts: no such file or directory] 2017-06-29 14:27:07.775 EDT [msp] getMspConfig -> WARN 003 crls folder not found at [/Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls]. Skipping. [stat /Users/cbf/dev/go/src/github.com/hyperledger/fabric/sampleconfig/msp/crls: no such file or directory] peer: Version: development build Go version: go1.7 OS/Arch: darwin/amd64 Chaincode: Base Image Version: Base Docker Namespace: Base Docker Label: Docker Namepace: 2017-06-29 14:27:07.800 EDT [main] main -> INFO 004 Exiting.....

cbf (Thu, 29 Jun 2017 18:27:43 GMT):
oh wait

cbf (Thu, 29 Jun 2017 18:27:52 GMT):
how am I getting a development build there

cbf (Thu, 29 Jun 2017 18:27:59 GMT):
hmmm

cbf (Thu, 29 Jun 2017 18:29:09 GMT):
interesting

cbf (Thu, 29 Jun 2017 18:29:19 GMT):
the peer version is different than configtxgen

cbf (Thu, 29 Jun 2017 18:29:26 GMT):
what is in the tarfile?

rjones (Thu, 29 Jun 2017 18:33:06 GMT):

Message Attachments

rjones (Thu, 29 Jun 2017 18:33:14 GMT):
@cbf ^^^

rjones (Thu, 29 Jun 2017 18:34:22 GMT):
I suspect the wrong tarfail is in the wrong place

rjones (Thu, 29 Jun 2017 18:34:22 GMT):
I suspect the wrong tar file is in the wrong place

rjones (Thu, 29 Jun 2017 18:35:18 GMT):
I stole that url from https://github.com/rjones-lf/homebrew-fabric/blob/master/Formula/fabric-tools.rb#L9

cbf (Thu, 29 Jun 2017 18:37:53 GMT):
weird, the peer in the tarfile is "development build"

cbf (Thu, 29 Jun 2017 18:37:59 GMT):
it should be v1.0.0-rc1

cbf (Thu, 29 Jun 2017 18:38:08 GMT):
@rameshthoomu ^^

cbf (Thu, 29 Jun 2017 18:38:31 GMT):
the configtxgen is correct

cbf (Thu, 29 Jun 2017 18:38:58 GMT):
in fact all the tools are fine

rameshthoomu (Thu, 29 Jun 2017 18:40:31 GMT):
let me check the `make dist-all` target in fabric..

rjones (Thu, 29 Jun 2017 18:43:20 GMT):
I'm trying to run `peer` on a system where I've never built or installed anything, perhaps that's the issue? it works if you have some other stuff installed?

cbf (Thu, 29 Jun 2017 18:57:49 GMT):
shouldn't be the case

cbf (Thu, 29 Jun 2017 18:58:02 GMT):
what I'll do is omit peer from the install for now

rameshthoomu (Thu, 29 Jun 2017 19:00:46 GMT):
@cbf checking why it generating version as "development build" for peer on 1.0.0-rc1

cbf (Thu, 29 Jun 2017 19:01:18 GMT):
https://jira.hyperledger.org/browse/FAB-5114

rameshthoomu (Thu, 29 Jun 2017 19:01:53 GMT):
ok

rjones (Thu, 29 Jun 2017 19:05:25 GMT):
@cbf all of the other binaries seem to work correctly.

rjones (Thu, 29 Jun 2017 19:05:54 GMT):
spoke too soon.

rjones (Thu, 29 Jun 2017 19:05:57 GMT):
```ry$ ./bin/configtxgen 2017-06-29 12:05:38.341 PDT [common/configtx/tool] main -> INFO 001 Loading configuration 2017-06-29 12:05:38.342 PDT [common/configtx/tool/localconfig] Load -> CRIT 002 Error reading configuration: Unsupported Config Type "" panic: Error reading configuration: Unsupported Config Type "" goroutine 1 [running]: panic(0x4d08c0, 0xc420200f80) /opt/go/go1.7.linux.amd64/src/runtime/panic.go:500 +0x1a1 github.com/hyperledger/fabric/vendor/github.com/op/go-logging.(*Logger).Panic(0xc4201fc630, 0xc420220720, 0x2, 0x2) /w/workspace/fabric-binaries-x86_64/gopath/src/github.com/hyperledger/fabric/vendor/github.com/op/go-logging/logger.go:188 +0xd0 github.com/hyperledger/fabric/common/configtx/tool/localconfig.Load(0x5acd55, 0x12, 0x0) /w/workspace/fabric-binaries-x86_64/gopath/src/github.com/hyperledger/fabric/common/configtx/tool/localconfig/config.go:180 +0xa8e main.main() /w/workspace/fabric-binaries-x86_64/gopath/src/github.com/hyperledger/fabric/common/configtx/tool/configtxgen/main.go:354 +0x537```

rjones (Thu, 29 Jun 2017 19:05:57 GMT):
``ry$ ./bin/configtxgen 2017-06-29 12:05:38.341 PDT [common/configtx/tool] main -> INFO 001 Loading configuration 2017-06-29 12:05:38.342 PDT [common/configtx/tool/localconfig] Load -> CRIT 002 Error reading configuration: Unsupported Config Type "" panic: Error reading configuration: Unsupported Config Type "" goroutine 1 [running]: panic(0x4d08c0, 0xc420200f80) /opt/go/go1.7.linux.amd64/src/runtime/panic.go:500 +0x1a1 github.com/hyperledger/fabric/vendor/github.com/op/go-logging.(*Logger).Panic(0xc4201fc630, 0xc420220720, 0x2, 0x2) /w/workspace/fabric-binaries-x86_64/gopath/src/github.com/hyperledger/fabric/vendor/github.com/op/go-logging/logger.go:188 +0xd0 github.com/hyperledger/fabric/common/configtx/tool/localconfig.Load(0x5acd55, 0x12, 0x0) /w/workspace/fabric-binaries-x86_64/gopath/src/github.com/hyperledger/fabric/common/configtx/tool/localconfig/config.go:180 +0xa8e main.main() /w/workspace/fabric-binaries-x86_64/gopath/src/github.com/hyperledger/fabric/common/configtx/tool/configtxgen/main.go:354 +0x537```

rameshthoomu (Thu, 29 Jun 2017 19:10:06 GMT):
@rjones did you set FABRIC_CFG_PATH?

rjones (Thu, 29 Jun 2017 19:10:49 GMT):
@rameshthoomu no, I set nothing

rjones (Thu, 29 Jun 2017 19:12:08 GMT):
still, I would expect something more informative than a core dump - the other commands dump a help screen with no args. that's another bug, though

rameshthoomu (Thu, 29 Jun 2017 19:13:36 GMT):
ignore my comment on FABRIC_CFG_PATH.

rameshthoomu (Thu, 29 Jun 2017 19:14:46 GMT):
I did curl on fabric-binaries and and ran ./bin/configtxgen.. ``` (hyp) ubuntu@hyperledger-devenv:9cb5aba:/opt/gopath/src/github.com/hyperledger/fabric/release/linux-amd64$ ./bin/configtxgen 2017-06-29 19:12:58.525 UTC [common/configtx/tool] main -> INFO 001 Loading configuration ( ```

rjones (Thu, 29 Jun 2017 19:15:53 GMT):
you're running it on ubuntu, I'm running it on macos

rameshthoomu (Thu, 29 Jun 2017 19:16:24 GMT):
yes

rjones (Thu, 29 Jun 2017 19:16:57 GMT):
so it looks like there is a problem with the tar file on nexus

rameshthoomu (Thu, 29 Jun 2017 19:18:34 GMT):
tested on mac here.. it worked

rameshthoomu (Thu, 29 Jun 2017 19:20:25 GMT):
``` Adnans-MacBook-Pro:bin adnanc$ ./configtxgen --version 2017-06-29 15:18:15.900 EDT [common/configtx/tool] main -> INFO 001 Loading configuration configtxgen: Version: 1.0.0-rc1 Go version: go1.7 OS/Arch: darwin/amd64 Adnans-MacBook-Pro:bin adnanc$ ./configtxgen 2017-06-29 15:18:20.966 EDT [common/configtx/tool] main -> INFO 001 Loading configuration Adnans-MacBook-Pro:bin adnanc$ ```

rjones (Thu, 29 Jun 2017 19:25:06 GMT):
I guess both of my macs are broken

cbf (Thu, 29 Jun 2017 19:32:10 GMT):
hmmm

cbf (Thu, 29 Jun 2017 19:32:33 GMT):
well there is still the problem of the version in the peer

rjones (Thu, 29 Jun 2017 21:09:17 GMT):
@cbf @rameshthoomu I just set up a bare Mac OS X VM with nothing installed. I pushed @cbf's patch 4 from gerrit to github, and I get the same error

rjones (Thu, 29 Jun 2017 21:09:25 GMT):
I can't make the test environment any more clean.

rjones (Thu, 29 Jun 2017 21:10:53 GMT):
I'm running `macOS Sierra 10.12.5`

muralisr (Thu, 29 Jun 2017 22:44:16 GMT):
@rjones @cbf @rameshthoomu I think it is this line 305 (in my env) in Makefile that's the cause of this `release/%: GO_LDFLAGS=-X $(pkgmap.$(@F))/metadata.Version=$(PROJECT_VERSION)` `

muralisr (Thu, 29 Jun 2017 22:45:44 GMT):
commenting that out, make clean and make dist (and release etc) seems to fix it... but need @greg.haskins eyes

muralisr (Thu, 29 Jun 2017 22:45:44 GMT):
commenting that out, make clean and make dist (and release etc) seems to fix `peer version`... but need @greg.haskins eyes

muralisr (Thu, 29 Jun 2017 22:45:44 GMT):
commenting that out, make clean and make dist (and release etc) seems to fix `peer version`... but need @greg.haskins eyes. The problem appears to be that peer and rest of the binaries follow different rules for metadata pattern. Line 305 does the the right thing for other binaries except for the peer binary

scottz (Thu, 29 Jun 2017 22:49:30 GMT):
https://gerrit.hyperledger.org/r/#/c/11201/ small one, reenabling an automated test using tlscacerts

scottz (Thu, 29 Jun 2017 22:53:52 GMT):
https://gerrit.hyperledger.org/r/#/c/11153/ just 4 lines addition to behave test framework

scottz (Thu, 29 Jun 2017 22:54:34 GMT):
https://gerrit.hyperledger.org/r/#/c/10521/ first of two enhancements to PTE tool, js and json

muralisr (Fri, 30 Jun 2017 00:04:16 GMT):
@greg.haskins @cbf @rjones @rameshthoomu submitted a possible fix for the version issue https://gerrit.hyperledger.org/r/#/c/11279/

greg.haskins (Fri, 30 Jun 2017 11:31:11 GMT):
Oh man, I am not sure how all those DRY violations crept in, heh

cbf (Fri, 30 Jun 2017 11:43:28 GMT):
https://gerrit.hyperledger.org/r/#/c/11245/

muralisr (Fri, 30 Jun 2017 11:46:23 GMT):
@greg.haskins the right fix would be fix metadata so all bins will follow the same pattern but that seemed too drastic at this stage

muralisr (Fri, 30 Jun 2017 11:48:09 GMT):
also we could override GO_LDFLAGS just in the peer production and leave the `release/%` rule in ...but I thought making the dependency explicit in each of the production is OK too

greg.haskins (Fri, 30 Jun 2017 12:01:55 GMT):
@muralisr sorry, that wasnt directed at you

greg.haskins (Fri, 30 Jun 2017 12:02:32 GMT):
I understand what you are trying to do...i was more lamenting on how the Makefile:release targets proliferated like that to begin with

greg.haskins (Fri, 30 Jun 2017 12:03:35 GMT):
first and foremost, those rules should be refactored so its not repeating itself...second thought is, the release process might deserve its own subordinate makefile at this point

greg.haskins (Fri, 30 Jun 2017 12:03:41 GMT):
neither here nor there on your patch though

cbf (Fri, 30 Jun 2017 12:04:11 GMT):
that was me, because it was easier to brute force than slog through a complete revamp of the makefile;-)

cbf (Fri, 30 Jun 2017 12:04:34 GMT):
we do need to do that... lots of targets with circular dependencies

greg.haskins (Fri, 30 Jun 2017 12:05:14 GMT):
no worries..i can take a look at it at some point

greg.haskins (Fri, 30 Jun 2017 12:05:27 GMT):
just looks a bit off the rails, but maybe there is nuance I am missing

mastersingh24 (Fri, 30 Jun 2017 13:01:49 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/11307/

mastersingh24 (Fri, 30 Jun 2017 13:04:45 GMT):
https://gerrit.hyperledger.org/r/#/c/11257/

pd93 (Fri, 30 Jun 2017 13:26:32 GMT):
Has joined the channel.

nickgaski (Fri, 30 Jun 2017 13:42:31 GMT):
https://gerrit.hyperledger.org/r/#/c/11205/ - this is an expansion on some work from Chris. It removes go source from each subdirectory in fabric samples and places into a central `chaincode` folder. Also allows the fabcar sample to leverage the basic-network docker-compose and the existing crypto/artifacts present in that directory

cbf (Fri, 30 Jun 2017 15:25:43 GMT):
https://gerrit.hyperledger.org/r/#/c/11241/

cbf (Fri, 30 Jun 2017 15:52:26 GMT):
https://gerrit.hyperledger.org/r/#/c/10873/

mastersingh24 (Sun, 02 Jul 2017 13:31:05 GMT):
2 pretty easy ones - https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open

mastersingh24 (Tue, 04 Jul 2017 15:10:57 GMT):
could use some eyes on https://gerrit.hyperledger.org/r/#/c/11355/

yacovm (Tue, 04 Jul 2017 15:57:56 GMT):
Typo in https://gerrit.hyperledger.org/r/#/c/11355/2/docs/source/chaincode4noah.rst@387

yacovm (Tue, 04 Jul 2017 15:58:10 GMT):
w should really have some AI that does such CRs :(

yacovm (Tue, 04 Jul 2017 15:58:10 GMT):
we should really have some AI that does such CRs :(

yacovm (Tue, 04 Jul 2017 16:00:45 GMT):
Everything else looks OK from my side

C0rWin (Tue, 04 Jul 2017 18:47:38 GMT):
@yacovm https://github.com/client9/misspell

C0rWin (Tue, 04 Jul 2017 18:48:01 GMT):
Do need in AI a simple plugin will do it for you

C0rWin (Tue, 04 Jul 2017 18:48:01 GMT):
No need in AI a simple plugin will do it for you

latitiah (Wed, 05 Jul 2017 17:51:22 GMT):
can I get some +2s on: https://gerrit.hyperledger.org/r/#/c/11153/ - Allows for negative testing in system behave tests

muralisr (Wed, 05 Jul 2017 19:11:05 GMT):
@latitiah done

latitiah (Wed, 05 Jul 2017 19:11:20 GMT):
thx!

mastersingh24 (Wed, 05 Jul 2017 19:30:01 GMT):
2 easy ones: https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open (spelling error and remove/correct Java chaincode docs)

mastersingh24 (Wed, 05 Jul 2017 20:20:02 GMT):
one more on the list as well now: https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open ;)

latitiah (Wed, 05 Jul 2017 20:43:34 GMT):
1 more +2 https://gerrit.hyperledger.org/r/#/c/11153

JonathanLevi (Wed, 05 Jul 2017 23:29:57 GMT):
@latitiah: merged.

mastersingh24 (Thu, 06 Jul 2017 11:09:57 GMT):
2 easy ones still waiting on a little love: https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open

smithbk (Thu, 06 Jul 2017 12:00:48 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=zYXHH49dcLss8ksTG) @mastersingh24 done

mastersingh24 (Thu, 06 Jul 2017 19:24:18 GMT):
https://gerrit.hyperledger.org/r/#/c/11419/1 - easy one from Nao

smithbk (Fri, 07 Jul 2017 03:59:44 GMT):
Two for fabric ca:

smithbk (Fri, 07 Jul 2017 03:59:47 GMT):
https://gerrit.hyperledger.org/r/#/c/11417 https://gerrit.hyperledger.org/r/#/c/11429

jyellick (Fri, 07 Jul 2017 15:12:23 GMT):
https://gerrit.hyperledger.org/r/#/c/11437/ ^ A simple but important one

JonathanLevi (Fri, 07 Jul 2017 19:52:01 GMT):
https://chat.hyperledger.org/channel/fabric-maintainers?msg=tEMjdpciYC94X9u4S *MERGE FREEZE* / *CODE FREEZE - BEGIN*

JonathanLevi (Fri, 07 Jul 2017 19:52:05 GMT):
*MERGE FREEZE* / *CODE FREEZE - BEGIN*

rameshthoomu (Mon, 10 Jul 2017 14:24:04 GMT):
Simple one https://gerrit.hyperledger.org/r/#/c/11473/

rameshthoomu (Mon, 10 Jul 2017 19:00:29 GMT):
incase if the release name is 1.0.0-rc2 (https://gerrit.hyperledger.org/r/#/c/11479/)

jeffgarratt (Tue, 11 Jul 2017 01:44:45 GMT):
@binhn @kostas @jyellick @muralisr this one is ready, not sure about merge status https://gerrit.hyperledger.org/r/#/c/11481/

jeffgarratt (Tue, 11 Jul 2017 01:44:45 GMT):
FYI @binhn @kostas @jyellick @muralisr this one is ready, not sure about merge status https://gerrit.hyperledger.org/r/#/c/11481/

jeffgarratt (Tue, 11 Jul 2017 01:44:45 GMT):
FYI @binhn @kostas @jyellick @muralisr this one is ready https://gerrit.hyperledger.org/r/#/c/11481/

jeffgarratt (Tue, 11 Jul 2017 01:48:18 GMT):
I assume code freeze in effect still... just an FYI

JonathanLevi (Tue, 11 Jul 2017 18:16:16 GMT):
---

JonathanLevi (Tue, 11 Jul 2017 18:16:17 GMT):
https://gerrit.hyperledger.org/r/#/c/11555

JonathanLevi (Tue, 11 Jul 2017 18:16:56 GMT):
@bmos299, @Ratnakar ^^^

nickgaski (Tue, 11 Jul 2017 19:30:42 GMT):
remove rc1 refs - https://gerrit.hyperledger.org/r/#/c/11561/

C0rWin (Tue, 11 Jul 2017 23:11:53 GMT):
fix license error warning - https://gerrit.hyperledger.org/r/#/c/11577/

rameshthoomu (Wed, 12 Jul 2017 15:11:44 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/11573/

latitiah (Wed, 12 Jul 2017 18:16:23 GMT):
https://gerrit.hyperledger.org/r/#/c/11413/ - Small change to update README for sys behave tests https://gerrit.hyperledger.org/r/#/c/11387/ - small change for sys behave test verification

jimthematrix (Wed, 12 Jul 2017 18:38:19 GMT):
https://gerrit.hyperledger.org/r/#/c/11587/ - trivial jsdoc changes, @dave.enyeart @JonathanLevi

cbf (Thu, 13 Jul 2017 13:50:05 GMT):
https://gerrit.hyperledger.org/r/#/c/11241/5 please

muralisr (Thu, 13 Jul 2017 13:55:50 GMT):
@cbf will look. btw.., not sure what the merge policy, branches etc are post 1.0 . will there be some communication about that ?

cbf (Thu, 13 Jul 2017 13:56:49 GMT):
we'll be opening up the merge freeze soon as we cut the release branch

cbf (Thu, 13 Jul 2017 13:56:58 GMT):
@JonathanLevi and I discussing now

JonathanLevi (Thu, 13 Jul 2017 13:57:32 GMT):
@muralisr: https://jira.hyperledger.org/browse/FAB-5050

muralisr (Thu, 13 Jul 2017 13:57:50 GMT):
ty much

jimthematrix (Thu, 13 Jul 2017 17:01:10 GMT):
https://gerrit.hyperledger.org/r/#/c/11553/ - necessary CR to be merged so master is open for business again (for 1.0.1)

cbf (Thu, 13 Jul 2017 22:12:20 GMT):
@JonathanLevi I noticed that the README had some branding issues - so I think that this needs to be merged before we branch https://gerrit.hyperledger.org/r/#/c/11633/

jimthematrix (Fri, 14 Jul 2017 02:29:19 GMT):
@cbf @JonathanLevi 1.0.1 CRs are starting to pile up in fabric-sdk-node (https://gerrit.hyperledger.org/r/#/q/project:fabric-sdk-node+status:open), can you please merge https://gerrit.hyperledger.org/r/#/c/11553?

mastersingh24 (Fri, 14 Jul 2017 09:42:14 GMT):
Hey team - we need to merge a few things here to finish off the 1.0.0 release: https://gerrit.hyperledger.org/r/#/c/11535/ - prepare fabric-ca for next release

JonathanLevi (Fri, 14 Jul 2017 10:19:12 GMT):
BTW: Just to note (as per the above ^^^) that we'll be branching out off master today.

JonathanLevi (Fri, 14 Jul 2017 10:19:12 GMT):
BTW: Just to note (as per the above ^^^) that we'll be branching out off of master today.

JonathanLevi (Fri, 14 Jul 2017 10:19:39 GMT):
BTW: Just to note (as per the above ^^^) that we'll be branching out off of master today.

jyellick (Fri, 14 Jul 2017 17:55:12 GMT):
https://gerrit.hyperledger.org/r/#/c/11645/ <- This is a bug fix which should definitely go into v1.0.1

cbf (Fri, 14 Jul 2017 19:23:01 GMT):
I agree, but help me understand how this would break existing deployments?

cbf (Fri, 14 Jul 2017 19:23:12 GMT):
@jyellick ^^

jyellick (Fri, 14 Jul 2017 19:25:05 GMT):
The CR does _not_ break anyone. If we made some other changes, it could. If we simply converted that `Warning` into an error, then anyone who has an infrastructure based on the old `configtxgen` will not be able to create channels until they update their version of `configtxgen` to match their update fabric.

cbf (Fri, 14 Jul 2017 19:25:59 GMT):
which seems like a good thing, no?

cbf (Fri, 14 Jul 2017 19:26:40 GMT):
ie this is a problem, why not get them to upgrade both fabric and configtxgen?

cbf (Fri, 14 Jul 2017 19:27:19 GMT):
and presume that use of new configtxgen could be used with 1.0.0 fabric

jyellick (Fri, 14 Jul 2017 19:27:41 GMT):
If we agree it is okay to require `configtxgen` and `fabric` to be upgraded together, then I am happy to change this into an error. I was simply err-ing on the side of not breaking things until we had more strict guidelines on what level of breakage is allowed in v1.0.1

cbf (Fri, 14 Jul 2017 19:29:30 GMT):
just to be clear the fixed configtxgen will work with 1.0.0 fabric without issue, use of the old configtxgen with fabric 1.0.1 would disallow creation of channels

cbf (Fri, 14 Jul 2017 19:29:47 GMT):
and force an update of configtxgen, yes?

cbf (Fri, 14 Jul 2017 19:30:24 GMT):
if so, seems like changing the warning to an error is desirable

yacovm (Fri, 14 Jul 2017 19:39:19 GMT):
IIRC Gari added a `--version` flag to all binaries, no?

yacovm (Fri, 14 Jul 2017 19:39:32 GMT):
I think this can be used to distinguish the configtxgen binaries

yacovm (Fri, 14 Jul 2017 19:41:47 GMT):
``` configtxgen: Version: 1.0.1-snapshot-d9c3202 ``` vs ``` configtxgen: Version: 1.0.0-rc2-snapshot-4709b33 ```

yacovm (Fri, 14 Jul 2017 19:42:17 GMT):
At least the end user doesn't need to "guess" what version its binary is now

cbf (Fri, 14 Jul 2017 20:30:33 GMT):
correct

JonathanLevi (Fri, 14 Jul 2017 22:43:26 GMT):
https://lists.hyperledger.org/pipermail/hyperledger-fabric/2017-July/001308.html Or in a line: *CODE FREEZE END*

JonathanLevi (Fri, 14 Jul 2017 22:43:26 GMT):
https://lists.hyperledger.org/pipermail/hyperledger-fabric/2017-July/001309.html Or in a line: *CODE FREEZE END*

yacovm (Sun, 16 Jul 2017 22:36:04 GMT):
2 easy ones https://gerrit.hyperledger.org/r/#/c/11671/ https://gerrit.hyperledger.org/r/#/c/11673/

latitiah (Mon, 17 Jul 2017 14:55:26 GMT):
https://gerrit.hyperledger.org/r/#/c/11413 - Small change to update README for sys behave tests https://gerrit.hyperledger.org/r/#/c/11387 - small change for sys behave test verification

AdnanC (Mon, 17 Jul 2017 14:57:44 GMT):
Test tool enhancement: using CouchDB: https://gerrit.hyperledger.org/r/#/c/11619/2

smithbk (Mon, 17 Jul 2017 15:39:41 GMT):
https://gerrit.hyperledger.org/r/#/c/10953/ - a fabric-ca CR to fix CI failures

smithbk (Mon, 17 Jul 2017 15:44:30 GMT):
And https://gerrit.hyperledger.org/r/#/c/11487/ - LDAP reconnect for idle timeout

rameshthoomu (Mon, 17 Jul 2017 17:34:40 GMT):
Need review on this.. https://gerrit.hyperledger.org/r/#/c/11249/

JonathanLevi (Mon, 17 Jul 2017 17:55:17 GMT):
@cbf: https://gerrit.hyperledger.org/r/#/c/11413/3

latitiah (Mon, 17 Jul 2017 21:36:06 GMT):
Can I get some :eyes: on https://gerrit.hyperledger.org/r/#/c/11387 ?

yacovm (Tue, 18 Jul 2017 06:43:57 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/11681/

cbf (Tue, 18 Jul 2017 12:37:13 GMT):
https://gerrit.hyperledger.org/r/#/c/11241/ thanks, @muralisr just need one more

jyellick (Tue, 18 Jul 2017 14:30:57 GMT):
https://gerrit.hyperledger.org/r/#/c/11703/ <- fabric-sdk-java https://gerrit.hyperledger.org/r/#/c/11709/ <- fabric-sdk-node These two CRs fix the node/java SDKs to use channel creation transactions which appropriately set the mod_policy on the application policies. These need to go in before https://gerrit.hyperledger.org/r/#/c/11645/ can pass the e2e.

kostas (Tue, 18 Jul 2017 15:11:34 GMT):
Very simple tweaks here: https://gerrit.hyperledger.org/r/#/c/11697/ https://gerrit.hyperledger.org/r/#/c/11693/

cbf (Tue, 18 Jul 2017 17:31:36 GMT):
@jyellick @jimthematrix is there a reason https://gerrit.hyperledger.org/r/#/c/11709/ has not been merged?

cbf (Tue, 18 Jul 2017 17:31:51 GMT):
I hesitate to submit if there's a reason it wasn't

jyellick (Tue, 18 Jul 2017 17:32:15 GMT):
@cbf My mistake, I was operating under the assumption of two required +2s

jyellick (Tue, 18 Jul 2017 17:32:45 GMT):
(submitted)

cbf (Tue, 18 Jul 2017 17:50:49 GMT):
no worries, just being cautious

jimthematrix (Tue, 18 Jul 2017 19:24:06 GMT):
a couple of test and sample updates: https://gerrit.hyperledger.org/r/11629 https://gerrit.hyperledger.org/r/11557 https://gerrit.hyperledger.org/r/11587 https://gerrit.hyperledger.org/r/11701

jimthematrix (Tue, 18 Jul 2017 19:24:20 GMT):
@cbf @mastersingh24 @yacovm ^^^

cbf (Wed, 19 Jul 2017 13:18:42 GMT):
https://gerrit.hyperledger.org/r/#/c/11241/ needs one more please

mastersingh24 (Wed, 19 Jul 2017 13:35:10 GMT):
@cbf - a few comments ^^^^

cbf (Wed, 19 Jul 2017 13:37:27 GMT):
cool thx

jyellick (Wed, 19 Jul 2017 13:42:33 GMT):
A very easy log/error message change https://gerrit.hyperledger.org/r/#/c/11733/

rameshthoomu (Wed, 19 Jul 2017 13:57:35 GMT):
need review on this https://gerrit.hyperledger.org/r/#/c/11249/

yacovm (Wed, 19 Jul 2017 20:11:07 GMT):
Easy bug fix, less than 30 LOC, the rest is test https://gerrit.hyperledger.org/r/#/c/11727/

jyellick (Wed, 19 Jul 2017 21:32:49 GMT):
An easy small one https://gerrit.hyperledger.org/r/#/c/11677/

AdnanC (Wed, 19 Jul 2017 21:46:16 GMT):
Requesting review again, test tool improvement so more tests can be automated. Reviewed by test team. (mostly bash, rest go) https://gerrit.hyperledger.org/r/#/c/11619/

AdnanC (Wed, 19 Jul 2017 21:46:16 GMT):
Requesting maintainer review again, test tool improvement so more tests can be automated. Reviewed by test team. (mostly bash, rest go) https://gerrit.hyperledger.org/r/#/c/11619/

AdnanC (Wed, 19 Jul 2017 21:46:16 GMT):
Requesting maintainer-review again, test tool improvement so more tests can be automated. Reviewed by test team. (mostly bash, rest go) https://gerrit.hyperledger.org/r/#/c/11619/

rjones (Wed, 19 Jul 2017 22:45:06 GMT):
Please take this survey from Google on your use of Gerrit: https://google.qualtrics.com/jfe/form/SV_0JKI9MBgY4eY4x7

mastersingh24 (Thu, 20 Jul 2017 12:28:01 GMT):
Easy one: https://gerrit.hyperledger.org/r/11773

muralisr (Thu, 20 Jul 2017 13:15:38 GMT):
done @mastersingh24

latitiah (Thu, 20 Jul 2017 18:46:31 GMT):
There are some system behave CRs that we would like to get +2s on and have been reviewed with +1s: https://gerrit.hyperledger.org/r/#/c/11387/ https://gerrit.hyperledger.org/r/#/c/11449/ https://gerrit.hyperledger.org/r/#/c/11283/ https://gerrit.hyperledger.org/r/#/c/11155/

scottz (Thu, 20 Jul 2017 19:11:58 GMT):
^^^ help please: @mastersingh24 @dave.enyeart @muralisr @yacovm @jyellick @binhand any other available folks: these are behave scripts, plus some include a bit of python - mostly that copy and modify existing functions and constructs so you should not require in-depth python expertise. We need to get them merged somehow.

scottz (Thu, 20 Jul 2017 19:11:58 GMT):
^^^ help please: @mastersingh24 @dave.enyeart @muralisr @yacovm @jyellick @binhn @JonathanLevi and any other available folks: these are behave scripts, plus some include a bit of python - mostly that copy and modify existing functions and constructs so you should not require in-depth python expertise. We need to get them merged somehow.

scottz (Thu, 20 Jul 2017 19:22:37 GMT):
Since there are few maintainers with the necessary language expertise, and since they are mostly focused on the dev effort rather than the system test automation efforts, could we drum up some more interest among current maintainers to agree to add 1 or 2 other maintainers with the interest and skillset to focus on the test CRs?

jyellick (Thu, 20 Jul 2017 19:34:38 GMT):
I'd feel better if @jeffgarratt gave a thumbs on up these CRs before processing as he understands the behave best

Ratnakar (Thu, 20 Jul 2017 20:10:05 GMT):
As per discussions with @kostas , updated e2e_cli scripts to include kafka ordereing service. https://gerrit.hyperledger.org/r/#/c/11789

mastersingh24 (Thu, 20 Jul 2017 20:46:34 GMT):
[You should propose creating separate repository for this stuff. Other than the core BDD, not sure why this would belong in the fabric repo ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=KZmYpSabzP8EK22SQ) @scottz

scottz (Thu, 20 Jul 2017 20:52:40 GMT):
hmmm. That idea definitely merits further consideration.

latitiah (Thu, 20 Jul 2017 21:29:15 GMT):
We've discussed doing this a few months ago and were told to move to a different directory instead, which we did. I'm all for moving this to a different repo, but we need a decision so we can move forward.

scottz (Fri, 21 Jul 2017 16:58:42 GMT):
@mastersingh24 Latitia is remembering some conversations we had with @cbf and a couple others, some time ago, when it was suggested and decided to put system test tools and automation testcases under fabric/test/ (instead of putting them under fabric/bddtest/ with jeff's bdd, or creating a new repo such as fabric-test). One reason was to keep the code together with the tests that were to be used in daily automation - and in effect encourage people to find the tools and write more tests. It has become abundantly clear that we will need to add some testers as maintainers - whether we continue to use fabric/test/ or whether we create a new repo. I could put together a summary and send proposal to the distribution list. It would make sense to request a vote. I would ask folks to provide other experiences and insights. And I would ask them to either agree to add testers as fabric mainainers or to create a new repo (with the accompanying overhead and lack of co-location with fabric code).

jimthematrix (Fri, 21 Jul 2017 18:44:27 GMT):
https://gerrit.hyperledger.org/r/#/c/11557/ - basic performance tests for endorsers and orderers, @cbf @mastersingh24 @yacovm

jimthematrix (Fri, 21 Jul 2017 18:44:27 GMT):
https://gerrit.hyperledger.org/r/#/c/11557/ - baseline performance tests for endorsers and orderers, @cbf @mastersingh24 @yacovm

jimthematrix (Fri, 21 Jul 2017 18:44:27 GMT):
https://gerrit.hyperledger.org/r/#/c/11557/ - baseline performance tests for endorsers and orderers, part I, @cbf @mastersingh24 @yacovm

jimthematrix (Fri, 21 Jul 2017 18:46:18 GMT):
these are performance under the most optimal conditions (co-located client and server), to establish baseline performance figures

jyellick (Fri, 21 Jul 2017 19:34:58 GMT):
I took a look at the first, but I agree with @mastersingh24 this should really be moved into its own repository, so stopping there. [ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=KmwCpy6YaP5c6coyX) [ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=Mewwgd3g2qy7aKERh)

jeffgarratt (Fri, 21 Jul 2017 19:37:47 GMT):
@mastersingh24 @jyellick @scottz I concur with the idea of moving this work out as well. I think it is itime.

ChandraLekhaChavva (Fri, 21 Jul 2017 19:53:50 GMT):
Has joined the channel.

cbf (Sat, 22 Jul 2017 18:52:32 GMT):
I don't have a problem moving the daily/weekly tests to their own repository

cbf (Sat, 22 Jul 2017 18:52:38 GMT):
BUT

cbf (Sat, 22 Jul 2017 18:53:04 GMT):
It is CRITICAL that it be kept in line with other fabric repositories

cbf (Sat, 22 Jul 2017 18:53:48 GMT):
it is also critical that there be fabric maintainers on that repo

cbf (Sat, 22 Jul 2017 18:53:48 GMT):
it is also critical that there be at least a couple fabric maintainers on that repo

cbf (Sat, 22 Jul 2017 18:57:49 GMT):
I created a review-needed issue here https://jira.hyperledger.org/browse/FAB-5430 please vote

cbf (Sun, 23 Jul 2017 12:57:23 GMT):
https://gerrit.hyperledger.org/r/#/c/11345/

mastersingh24 (Sun, 23 Jul 2017 14:08:50 GMT):
https://gerrit.hyperledger.org/r/#/c/11847/ - fixes issue with fabric-ca svt due to Ubuntu upgrade of mysql package

harsha (Mon, 24 Jul 2017 09:47:52 GMT):
Needs review :- https://gerrit.hyperledger.org/r/#/c/11769/

mastersingh24 (Mon, 24 Jul 2017 10:35:50 GMT):
Need one more +2 on https://gerrit.hyperledger.org/r/#/c/11847/

C0rWin (Mon, 24 Jul 2017 10:49:40 GMT):
https://gerrit.hyperledger.org/r/#/c/11753/ - prevent state inconsistency in case of external failures

cbf (Mon, 24 Jul 2017 11:27:55 GMT):
https://gerrit.hyperledger.org/r/#/c/11829/ https://gerrit.hyperledger.org/r/#/c/11849/

cbf (Mon, 24 Jul 2017 11:32:17 GMT):
also, review-needed for creating a fabric-rest-sdk sub-project https://jira.hyperledger.org/browse/FAB-3978

muralisr (Mon, 24 Jul 2017 12:07:00 GMT):
@C0rWin will try to review 11753 later today

kostas (Mon, 24 Jul 2017 12:52:56 GMT):
https://gerrit.hyperledger.org/r/#/c/11797/

rameshthoomu (Mon, 24 Jul 2017 14:51:21 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/11763/

rameshthoomu (Mon, 24 Jul 2017 14:51:50 GMT):
@greg.haskins need your review https://gerrit.hyperledger.org/r/#/c/11859/

smithbk (Mon, 24 Jul 2017 18:39:04 GMT):
For fabric-ca:

smithbk (Mon, 24 Jul 2017 18:39:07 GMT):
https://gerrit.hyperledger.org/r/#/c/10953/ - Fix timing bug causing failure in CI https://gerrit.hyperledger.org/r/#/c/11487/ - LDAP reconnect for connect timeout https://gerrit.hyperledger.org/r/#/c/10717/ - Store MSP intermediatecerts

cbf (Mon, 24 Jul 2017 19:52:28 GMT):
https://gerrit.hyperledger.org/r/#/c/11865/ fixes missing space in rst syntax for note

rameshthoomu (Mon, 24 Jul 2017 20:07:03 GMT):
needs review https://gerrit.hyperledger.org/r/#/c/11249/

skarim (Mon, 24 Jul 2017 20:16:35 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/11657/ https://gerrit.hyperledger.org/r/#/c/11817/

cbf (Mon, 24 Jul 2017 20:42:42 GMT):
@skarim @smithbk https://gerrit.hyperledger.org/r/#/c/11657/ can't be merged... looks like needs rebase? Says missing dependency

skarim (Mon, 24 Jul 2017 21:25:11 GMT):
https://gerrit.hyperledger.org/r/#/c/11657 has been rebased

C0rWin (Mon, 24 Jul 2017 22:00:58 GMT):
https://gerrit.hyperledger.org/r/#/c/11753/ still waiting for its last +2.

smithbk (Tue, 25 Jul 2017 13:07:32 GMT):
Ready for review:

smithbk (Tue, 25 Jul 2017 13:07:35 GMT):
https://gerrit.hyperledger.org/r/#/c/11487/ - LDAP reconnect for connect timeout https://gerrit.hyperledger.org/r/#/c/10717/ - Store MSP intermediatecerts

rameshthoomu (Tue, 25 Jul 2017 14:01:07 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/11249/

wlahti (Tue, 25 Jul 2017 14:45:56 GMT):
Bug fixes for v1.0.1 ready for review: https://gerrit.hyperledger.org/r/#/c/11889/ - prevents concurrent invokes from launching a chaincode container at the same time (e.g. during performance testing) https://gerrit.hyperledger.org/r/#/c/11819/ - prevent instantiatiation on a taken chaincode ID due to different capitalization

rameshthoomu (Tue, 25 Jul 2017 16:17:25 GMT):
Need review on this https://gerrit.hyperledger.org/r/#/c/11711/4

muralisr (Tue, 25 Jul 2017 17:53:17 GMT):
a simple fix that fixes node sdk breaks - https://gerrit.hyperledger.org/r/#/c/11917/

muralisr (Tue, 25 Jul 2017 17:53:17 GMT):
a simple fix that fixes node sdk test failures - https://gerrit.hyperledger.org/r/#/c/11917/

cbf (Tue, 25 Jul 2017 19:18:36 GMT):
https://gerrit.hyperledger.org/r/#/c/11865/

yacovm (Tue, 25 Jul 2017 22:33:24 GMT):
2 gossip change sets: https://gerrit.hyperledger.org/r/#/c/11751/ Bug fix https://gerrit.hyperledger.org/r/#/c/11851/ Performance tweak

jyellick (Wed, 26 Jul 2017 02:00:33 GMT):
Could use a maintainer's help with a manual +1 verify

jyellick (Wed, 26 Jul 2017 02:00:35 GMT):
https://gerrit.hyperledger.org/r/#/c/11921/

jyellick (Wed, 26 Jul 2017 02:01:00 GMT):
(Union of reverifies is definitely a success)

jyellick (Wed, 26 Jul 2017 05:26:27 GMT):
https://gerrit.hyperledger.org/r/#/c/11921/ <- important bug fix (but simple) https://gerrit.hyperledger.org/r/#/c/11887/ <- easy https://gerrit.hyperledger.org/r/#/c/11891/ <- trivial

wlahti (Wed, 26 Jul 2017 11:37:43 GMT):
https://gerrit.hyperledger.org/r/#/c/11819/ - - prevent instantiatiation on a taken chaincode ID due to different capitalization

wlahti (Wed, 26 Jul 2017 11:37:43 GMT):
https://gerrit.hyperledger.org/r/#/c/11819/ - bug fix - prevent instantiatiation on a taken chaincode ID due to different capitalization

smithbk (Wed, 26 Jul 2017 12:19:44 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/10717/ - Store MSP intermediatecerts appropriately

harsha (Wed, 26 Jul 2017 13:02:35 GMT):
Would appreciate review on https://gerrit.hyperledger.org/r/#/c/11769/4

jyellick (Wed, 26 Jul 2017 14:14:01 GMT):
https://gerrit.hyperledger.org/r/#/c/11499/ <- No new code/function just restructuring the orderer package a bit, needs one more +2

rameshthoomu (Wed, 26 Jul 2017 14:47:07 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/11249/

rameshthoomu (Wed, 26 Jul 2017 15:19:13 GMT):
Need review on this please https://gerrit.hyperledger.org/r/#/c/11711/

wlahti (Wed, 26 Jul 2017 17:15:20 GMT):
Ready for re-review: https://gerrit.hyperledger.org/r/#/c/11819/ - bug fix - prevent instantiatiation on a taken chaincode ID due to different capitalization

jimthematrix (Wed, 26 Jul 2017 17:58:50 GMT):
https://gerrit.hyperledger.org/r/#/c/11629/ - fixes to fabric-samples/balance-transfer, @cbf @mastersingh24 @yacovm @binhn

mastersingh24 (Wed, 26 Jul 2017 18:02:25 GMT):
Can we get some eyes on this? It's the last CR for 1.0.1 (https://chat.hyperledger.org/channel/fabric-pr-review?msg=Q44pEFE7r6ozh5CTT) @wlahti

cbf (Wed, 26 Jul 2017 21:28:05 GMT):
https://gerrit.hyperledger.org/r/#/c/11941/ to add some references to godoc resources

cbf (Wed, 26 Jul 2017 21:29:44 GMT):
https://gerrit.hyperledger.org/r/#/c/11843/1 adds derivative of bootstrap.sh to the fabric-samples so that ppl can re-download docker images

rameshthoomu (Thu, 27 Jul 2017 12:55:45 GMT):
https://gerrit.hyperledger.org/r/#/c/11711/ -- Decrease auction test time..

rameshthoomu (Thu, 27 Jul 2017 12:56:24 GMT):
https://gerrit.hyperledger.org/r/#/c/11249/ -- added parameter to enable couchdb tests

rameshthoomu (Thu, 27 Jul 2017 12:57:07 GMT):
https://gerrit.hyperledger.org/r/#/c/11975/ -- Updated ver ref. to 1.0.1 in regression/release tests

harsha (Thu, 27 Jul 2017 13:23:25 GMT):
https://gerrit.hyperledger.org/r/#/c/11769/4 :- Introduce configurable delay to byfn

smithbk (Thu, 27 Jul 2017 13:30:52 GMT):
For fabric-ca, pls review: https://gerrit.hyperledger.org/r/#/c/10717/ - Fix to store MSP intermediatecerts

adc (Thu, 27 Jul 2017 13:38:10 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/11929/. Thanks :)

jyellick (Thu, 27 Jul 2017 14:22:02 GMT):
https://gerrit.hyperledger.org/r/#/c/11499/ Could use one more +2 -- it's much less scary than it looks, really just moving some interface definitions from one place to another

mastersingh24 (Thu, 27 Jul 2017 15:06:15 GMT):
@adc - Added a comment / question (https://chat.hyperledger.org/channel/fabric-pr-review?msg=d3QGyMGyoF6b354jd)

mastersingh24 (Thu, 27 Jul 2017 15:09:42 GMT):
https://gerrit.hyperledger.org/r/#/c/11941/

Ratnakar (Thu, 27 Jul 2017 18:36:13 GMT):
https://gerrit.hyperledger.org/r/#/c/11789 - Adjusting the E2E CLI tests for Kafka

jyellick (Thu, 27 Jul 2017 19:53:22 GMT):
https://gerrit.hyperledger.org/r/#/c/11877/ <- small and easy https://gerrit.hyperledger.org/r/#/c/11875/ <- not quite as small, but hopefully still easy

mastersingh24 (Thu, 27 Jul 2017 20:12:05 GMT):
Needed for fabric-ca 1.0.1 - https://gerrit.hyperledger.org/r/#/c/10717/

mastersingh24 (Thu, 27 Jul 2017 20:12:05 GMT):
Needed for fabric-ca 1.0.1 - https://gerrit.hyperledger.org/r/#/c/11791/ https://gerrit.hyperledger.org/r/#/c/10717/

C0rWin (Thu, 27 Jul 2017 20:40:00 GMT):
an easy one: https://gerrit.hyperledger.org/r/#/c/11979/, needs last +2

mastersingh24 (Thu, 27 Jul 2017 21:11:35 GMT):
https://gerrit.hyperledger.org/r/#/c/10717/ still waiting for a little love

smithbk (Fri, 28 Jul 2017 00:34:40 GMT):
A small one: https://gerrit.hyperledger.org/r/#/c/11995/

jyellick (Fri, 28 Jul 2017 04:58:19 GMT):
https://gerrit.hyperledger.org/r/#/c/11501/ <- mostly deleted code

harsha (Fri, 28 Jul 2017 10:28:51 GMT):
Appreciate review on https://gerrit.hyperledger.org/r/#/c/11769/4

cbf (Fri, 28 Jul 2017 12:52:42 GMT):
https://gerrit.hyperledger.org/r/#/c/11843/

jyellick (Fri, 28 Jul 2017 20:06:05 GMT):
Simple +30/-144 CR [ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=tnmgA8HEW8LiiLxPN)

mastersingh24 (Fri, 28 Jul 2017 20:58:52 GMT):
Looks like https://gerrit.hyperledger.org/r/#/c/12019/ passed CI and is ready for some approvals ;) Once this is (hopefully) merged, will add the new download script, etc but at least the core code will be merged

rameshthoomu (Fri, 28 Jul 2017 21:13:14 GMT):
@mastersingh24 need your review on these patches FAB-5509 create bootstrap-1.0.1.sh script FAB-5500 update ver ref. to 1.0.1 in release tests FAB-5056 enable couchdb test in byfn e2e script [FAB-5320] Decrease Auction Daily Tests run time

gennadyl (Sun, 30 Jul 2017 06:52:26 GMT):
https://gerrit.hyperledger.org/r/#/c/11453/, plz

harsha (Sun, 30 Jul 2017 15:40:00 GMT):
https://gerrit.hyperledger.org/r/#/c/11769/4 -- Would appreciate review on this plz

jyellick (Sun, 30 Jul 2017 20:29:14 GMT):
https://gerrit.hyperledger.org/r/#/c/11875/ <- add multi-sig support for configtx to peer CLI https://gerrit.hyperledger.org/r/#/c/11501/ <- almost entirely code deletion https://gerrit.hyperledger.org/r/#/c/11503/ <- interface renaming https://gerrit.hyperledger.org/r/#/c/11507/ <- actually substantive ^ All of the above have one +2 and need one more

mastersingh24 (Sun, 30 Jul 2017 20:52:43 GMT):
For anyone around, need to +2 and merge these into master before I can create the 1.0.1 release for fabric-ca: https://gerrit.hyperledger.org/r/11961 https://gerrit.hyperledger.org/r/11157 https://gerrit.hyperledger.org/r/11995 https://gerrit.hyperledger.org/r/12049

JonathanLevi (Sun, 30 Jul 2017 22:21:11 GMT):
Another look at, please? https://gerrit.hyperledger.org/r/#/c/11995/

JonathanLevi (Sun, 30 Jul 2017 22:21:32 GMT):
Another look at https://gerrit.hyperledger.org/r/#/c/11995/ please

JonathanLevi (Sun, 30 Jul 2017 23:42:02 GMT):
Thank you @jyellick

JonathanLevi (Sun, 30 Jul 2017 23:42:31 GMT):
@mastersingh24 Please give us "a shout" if there's anything else.

JonathanLevi (Sun, 30 Jul 2017 23:42:55 GMT):
(So far I've merged anything I could)

JonathanLevi (Sun, 30 Jul 2017 23:43:23 GMT):
(So far I've reviewed & merged anything I could)

JonathanLevi (Sun, 30 Jul 2017 23:44:33 GMT):
Other than https://gerrit.hyperledger.org/r/#/c/12047, of course

grapebaba (Mon, 31 Jul 2017 07:52:03 GMT):
First commit for metrics, please review https://gerrit.hyperledger.org/r/#/c/11933

cbf (Mon, 31 Jul 2017 11:39:53 GMT):
https://gerrit.hyperledger.org/r/#/c/11843/

rameshthoomu (Mon, 31 Jul 2017 13:13:05 GMT):
@mastersingh24

rameshthoomu (Mon, 31 Jul 2017 13:18:19 GMT):
@mastersingh24 Need your review https://gerrit.hyperledger.org/r/#/c/11991/ -- create bootstrap-1.0.1.sh script https://gerrit.hyperledger.org/r/#/c/11975/ -- update ver ref. to 1.0.1 in release tests https://gerrit.hyperledger.org/r/#/c/11945/ -- cleanup deadcode from bddtests/regression https://gerrit.hyperledger.org/r/#/c/11249/ -- enable couchdb test in byfn e2e script

baohua (Mon, 31 Jul 2017 13:37:56 GMT):
Has joined the channel.

baohua (Mon, 31 Jul 2017 13:38:32 GMT):
can someone help review https://gerrit.hyperledger.org/r/11407, https://gerrit.hyperledger.org/r/9173, https://gerrit.hyperledger.org/r/11051 Thanks!

nickgaski (Mon, 31 Jul 2017 15:23:01 GMT):
https://gerrit.hyperledger.org/r/#/c/11947/ - this one is very trivial

grapebaba (Tue, 01 Aug 2017 09:19:28 GMT):
https://gerrit.hyperledger.org/r/#/c/11933/ ci passed

harsha (Tue, 01 Aug 2017 11:37:00 GMT):
plz review :- https://gerrit.hyperledger.org/r/#/c/11769/4

mastersingh24 (Tue, 01 Aug 2017 14:15:32 GMT):
Friends, Romans, countrymen - lend me your +2's: https://gerrit.hyperledger.org/r/c/12045/ https://gerrit.hyperledger.org/r/c/12053/

muralisr (Tue, 01 Aug 2017 15:24:51 GMT):
"Oh Romeo, where art those perms on them, Romeo ?" :-)

cbf (Tue, 01 Aug 2017 16:09:01 GMT):
I'd like @smithbk and @JonathanLevi to +2 https://gerrit.hyperledger.org/r/c/12053/

cbf (Tue, 01 Aug 2017 16:09:04 GMT):
but LGTM

cbf (Tue, 01 Aug 2017 16:09:12 GMT):
what I don't know is whether it is complete

cbf (Tue, 01 Aug 2017 16:09:48 GMT):
and that @mastersingh24 guy... don't know about him...

cbf (Tue, 01 Aug 2017 16:09:55 GMT):
(j/k)

jyellick (Tue, 01 Aug 2017 16:11:51 GMT):
https://gerrit.hyperledger.org/r/#/c/11509/ <- some cleanup of previously deprecated and now entirely unused codepath

yacovm (Tue, 01 Aug 2017 16:25:00 GMT):
@mastersingh24 @cbf https://gerrit.hyperledger.org/r/#/c/12045/ is ready for merge - should we merge it?

cbf (Tue, 01 Aug 2017 16:25:23 GMT):
I figured I'd leave that to the big guy

muralisr (Tue, 01 Aug 2017 16:49:26 GMT):
@mastersingh24 @cbf I get ```Not Found The page you requested was not found, or you do not have permission to view this page.``` on https://gerrit.hyperledger.org/r/#/r/c/12053/ and https://gerrit.hyperledger.org/r/#/r/c/12045

muralisr (Tue, 01 Aug 2017 16:49:32 GMT):
is that just me ?

muralisr (Tue, 01 Aug 2017 16:52:13 GMT):
hmm why do I get `/r/#/r/c` when I click on links here... https://gerrit.hyperledger.org/r/#/c/12045/ and https://gerrit.hyperledger.org/r/#/c/12053 works

muralisr (Tue, 01 Aug 2017 16:52:49 GMT):
so probably me... ignore please

cbf (Tue, 01 Aug 2017 17:47:37 GMT):
@muralisr very odd

cbf (Tue, 01 Aug 2017 17:48:39 GMT):
where did the bogus link come from?

mastersingh24 (Tue, 01 Aug 2017 17:48:58 GMT):
12045 and 12053 are safe to merge if you approve

mastersingh24 (Tue, 01 Aug 2017 17:49:02 GMT):
;)

cbf (Tue, 01 Aug 2017 17:49:58 GMT):
ok by me

cbf (Tue, 01 Aug 2017 17:50:04 GMT):
you want me to pull the trigger?

mastersingh24 (Tue, 01 Aug 2017 17:56:02 GMT):
Yeah - then we'll double check the the prepare ones - but these are good to go content wise

rjones (Tue, 01 Aug 2017 18:17:42 GMT):
@muralisr I've noticed that when I have a window in the old UI and one in the new UI. I've also noticed draft changes don't render in the new UI

muralisr (Tue, 01 Aug 2017 18:20:36 GMT):
@rjones thanks, let me clear my browsers and start afresh

harsha (Tue, 01 Aug 2017 18:33:26 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/11769/4/

JonathanLevi (Tue, 01 Aug 2017 19:06:40 GMT):
I have just merged https://gerrit.hyperledger.org/r/#/c/12045 *CODE FREEZE - BEGIN*

JonathanLevi (Tue, 01 Aug 2017 19:06:40 GMT):
I have just merged https://gerrit.hyperledger.org/r/#/c/12045 *CODE FREEZE - BEGIN*- *CODE FREEZE - END* we agreed on a better way

JonathanLevi (Tue, 01 Aug 2017 19:06:40 GMT):
I have just merged https://gerrit.hyperledger.org/r/#/c/12045 *CODE FREEZE - BEGIN*- *CODE FREEZE - END* we agreed on a better way *No* CODE FREEZE

rameshthoomu (Tue, 01 Aug 2017 19:19:44 GMT):
Need one more +2 on below patches https://gerrit.hyperledger.org/r/#/c/11991/ https://gerrit.hyperledger.org/r/#/c/11975/ https://gerrit.hyperledger.org/r/#/c/11249/

mastersingh24 (Tue, 01 Aug 2017 19:56:52 GMT):
This guy could use a little push: https://gerrit.hyperledger.org/r/c/12061/ (it merges the master branch to release for fabric-samples)

JonathanLevi (Wed, 02 Aug 2017 00:08:13 GMT):
*CODE FREEZE - END*

baohua (Wed, 02 Aug 2017 01:40:10 GMT):
Need one more +2 for the following patchset (already two +2s): https://gerrit.hyperledger.org/r/#/c/11407/, thanks!

grapebaba (Wed, 02 Aug 2017 07:06:57 GMT):
https://gerrit.hyperledger.org/r/#/c/11933/ could anyone start to look at this one?

yacovm (Wed, 02 Aug 2017 08:21:09 GMT):
I would help if you could perhaps include a high level explanation in the gerrit change set that explains how the metrics module is expected to be consumed.

yacovm (Wed, 02 Aug 2017 08:21:09 GMT):
Kai, It would help if you could perhaps include a high level explanation in the gerrit change set that explains how the metrics module is expected to be consumed.

yacovm (Wed, 02 Aug 2017 08:21:09 GMT):
Kai, it would help if you could perhaps include a high level explanation in the gerrit change set that explains how the metrics module is expected to be consumed.

yacovm (Wed, 02 Aug 2017 08:21:16 GMT):
@grapebaba ^

grapebaba (Wed, 02 Aug 2017 08:23:14 GMT):
OK

grapebaba (Wed, 02 Aug 2017 08:23:45 GMT):
In short, only interfaces in types.go

yacovm (Wed, 02 Aug 2017 08:24:04 GMT):
not here, in the change set. writing in rocket chat is like writing on sand

grapebaba (Wed, 02 Aug 2017 08:28:50 GMT):
Sure

yacovm (Wed, 02 Aug 2017 09:26:09 GMT):
Mutual TLS in chaincode: https://gerrit.hyperledger.org/r/#/c/11911/ https://gerrit.hyperledger.org/r/#/c/11913/ https://gerrit.hyperledger.org/r/#/c/11915/ Removal of costly checks from the ciritical path in gossip https://gerrit.hyperledger.org/r/#/c/11851/ already has 1 +2 Fix (I hope) of a CI failure in gossip leader election https://gerrit.hyperledger.org/r/#/c/12043/

yacovm (Wed, 02 Aug 2017 09:26:09 GMT):
Mutual TLS in chaincode: https://gerrit.hyperledger.org/r/#/c/11911/ https://gerrit.hyperledger.org/r/#/c/11913/ https://gerrit.hyperledger.org/r/#/c/11915/ Removal of costly checks from the ciritical path in gossip https://gerrit.hyperledger.org/r/#/c/11851/ already has 1 +2 - Fix (I hope) of a CI failure in gossip leader election https://gerrit.hyperledger.org/r/#/c/12043/ -

yacovm (Wed, 02 Aug 2017 09:26:09 GMT):
Mutual TLS in chaincode: https://gerrit.hyperledger.org/r/#/c/11911/ https://gerrit.hyperledger.org/r/#/c/11913/ https://gerrit.hyperledger.org/r/#/c/11915/ Removal of costly checks from the ciritical path in gossip https://gerrit.hyperledger.org/r/#/c/11851/ already has 1 +2 - Fix (I hope) of a CI failure in gossip leader election - https://gerrit.hyperledger.org/r/#/c/12043/ -

yacovm (Wed, 02 Aug 2017 09:26:09 GMT):
Mutual TLS in chaincode: https://gerrit.hyperledger.org/r/#/c/11911/ https://gerrit.hyperledger.org/r/#/c/11913/ https://gerrit.hyperledger.org/r/#/c/11915/ Removal of costly checks from the ciritical path in gossip https://gerrit.hyperledger.org/r/#/c/11851/ already has 1 +2 ~ Fix (I hope) of a CI failure in gossip leader election https://gerrit.hyperledger.org/r/#/c/12043/ ~

yacovm (Wed, 02 Aug 2017 09:26:09 GMT):
Mutual TLS in chaincode: https://gerrit.hyperledger.org/r/#/c/11911/ https://gerrit.hyperledger.org/r/#/c/11913/ https://gerrit.hyperledger.org/r/#/c/11915/ ~ Removal of costly checks from the ciritical path in gossip https://gerrit.hyperledger.org/r/#/c/11851/ ~ ~ Fix (I hope) of a CI failure in gossip leader election https://gerrit.hyperledger.org/r/#/c/12043/ ~

harsha (Wed, 02 Aug 2017 13:10:18 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/11769/4

mastersingh24 (Wed, 02 Aug 2017 15:34:22 GMT):
So @smithbk does not seem to be around. @JonathanLevi @cbf and others can you looks at fabric-ca 1.0.1 - https://gerrit.hyperledger.org/r/c/12053/

jyellick (Wed, 02 Aug 2017 17:09:39 GMT):
https://gerrit.hyperledger.org/r/#/c/11509/ <- deleting a deprecated and now unused codepath https://gerrit.hyperledger.org/r/#/c/11511/ <- largely moving files from one location to another https://gerrit.hyperledger.org/r/#/c/11513/ <- finally reaping the performance benefit of the very long series in solo All three of these could use some review love. None of them are terribly complicated.

cbf (Wed, 02 Aug 2017 17:59:26 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=JA9HvijPEeKLJqsEj) @mastersingh24 I'll change mine to a +2 if @JonathanLevi weighs in... again, what I don't know is whether it is a complete set

mastersingh24 (Wed, 02 Aug 2017 18:01:11 GMT):
I got everything tagged as 1.0.1 and only bug fixes

mastersingh24 (Wed, 02 Aug 2017 18:01:20 GMT):
So I think the list was good

rameshthoomu (Wed, 02 Aug 2017 18:09:50 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/11975/ https://gerrit.hyperledger.org/r/#/c/11249/

jimthematrix (Wed, 02 Aug 2017 19:22:06 GMT):
https://gerrit.hyperledger.org/r/#/c/12105/ - initial CR for fabric-chaincode-node, you can follow the instructions in the README to give it a try (can install/instantiate and invoke a simple chaincode.js with Init() and Invoke() methods), note that it depends on a corresponding fabric CR https://gerrit.hyperledger.org/r/#/c/11823/, see README for details. @cbf @mastersingh24 @muralisr @bretharrison @binhn @Honglei @greg.haskins

jimthematrix (Wed, 02 Aug 2017 19:22:06 GMT):
https://gerrit.hyperledger.org/r/#/c/12105/ - initial CR for fabric-chaincode-node, you can follow the instructions in the README to give it a try (can install/instantiate and invoke a simple chaincode.js with Init() and Invoke() methods), note that it depends on a corresponding fabric CR (11823, see README for details). @cbf @mastersingh24 @muralisr @bretharrison @binhn @Honglei @greg.haskins

jimthematrix (Wed, 02 Aug 2017 19:22:06 GMT):
https://gerrit.hyperledger.org/r/#/c/12105/ - initial CR for fabric-chaincode-node, you can follow the instructions in the README to give it a try (can install/instantiate and invoke a simple chaincode.js with Init() and Invoke() methods), note that it depends on a corresponding fabric CR (11823, see README for details). @cbf @mastersingh24 @muralisr @bretharrison @davidkel @binhn @Honglei @greg.haskins

jimthematrix (Wed, 02 Aug 2017 19:24:29 GMT):
it'd be good if this can be merged soon, even though 11823 is pending, so others can start their work in parallel, like @rameshthoomu can start working on the CI part. thanks!

muralisr (Wed, 02 Aug 2017 22:11:51 GMT):
@jimthematrix will definitely check it out as soon as I can

grapebaba (Thu, 03 Aug 2017 04:46:19 GMT):
https://gerrit.hyperledger.org/r/#/c/11933 @yacovm added public API and comments in changeset

mastersingh24 (Thu, 03 Aug 2017 09:43:55 GMT):
@grapebaba - Looks good. Would you mind changing the license headers for your code to the short style: ``` # Copyright IBM Corp. All Rights Reserved. # # SPDX-License-Identifier: Apache-2.0 # ```

mastersingh24 (Thu, 03 Aug 2017 09:44:04 GMT):
but otherwise looking good

grapebaba (Thu, 03 Aug 2017 09:44:38 GMT):
got it

greg.haskins (Thu, 03 Aug 2017 12:28:30 GMT):
some non-critical-path ones: https://gerrit.hyperledger.org/r/#/c/12107/

greg.haskins (Thu, 03 Aug 2017 12:28:41 GMT):
https://gerrit.hyperledger.org/r/#/c/12109/

mastersingh24 (Thu, 03 Aug 2017 12:39:27 GMT):
Easy but good one from @dsanchezseco - https://gerrit.hyperledger.org/r/#/c/12125/

dsanchezseco (Thu, 03 Aug 2017 12:39:27 GMT):
Has joined the channel.

dsanchezseco (Thu, 03 Aug 2017 18:18:34 GMT):
Please check this one https://gerrit.hyperledger.org/r/#/c/12131/ cause is related to the previous one

dsanchezseco (Thu, 03 Aug 2017 18:19:03 GMT):
i forgot to add the f after doing the merge :sweat_smile:

rameshthoomu (Thu, 03 Aug 2017 18:55:39 GMT):
@mastersingh24 @cbf Below patch set has been rebased https://gerrit.hyperledger.org/r/#/c/11975/

dsanchezseco (Thu, 03 Aug 2017 19:09:53 GMT):
as promised the getHistoryForKey example https://gerrit.hyperledger.org/r/#/c/12133/

JonathanLevi (Thu, 03 Aug 2017 19:20:45 GMT):
Hi @dsanchezseco

JonathanLevi (Thu, 03 Aug 2017 19:21:55 GMT):
Thanks for the second CR. Just to quickly point out that if you are adding a new file to Hyperledger (under Apache 2.0) that is yours... you can still retain the copyrights.

JonathanLevi (Thu, 03 Aug 2017 19:22:13 GMT):
You don't have to assign it to IBM Corp., or anyone else.

JonathanLevi (Thu, 03 Aug 2017 19:22:37 GMT):
Here, for example: https://gerrit.hyperledger.org/r/#/c/12133/1/chaincode/chaincode_history/chaincode_history_test.go

grapebaba (Fri, 04 Aug 2017 02:14:01 GMT):
https://gerrit.hyperledger.org/r/#/c/11933/ hope more experts to review

dsanchezseco (Fri, 04 Aug 2017 06:23:24 GMT):
@JonathanLevi i didnt thought of it. What about if the code it's mostly based on some code already available on the repo, even though the files are new(as is the case here, the code is 90% chaincode_example02 and the rest to execute it)? I've just add it some code.

JonathanLevi (Fri, 04 Aug 2017 06:25:04 GMT):
While I am not a legal expert (un?)fortunately... that's fair enough - if you are building on existing copyrighted material, then it make sense (to me) to keep the original copyright... especially if you don't mind.

dsanchezseco (Fri, 04 Aug 2017 06:26:36 GMT):
Yeah, it's not that elaborated to claim ownership of it hahahahaha

JonathanLevi (Fri, 04 Aug 2017 06:27:06 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=zXdwtg6MRpN9NEN3e) The main point I wanted to make, in general, is this (for future work that you do, etc. Feel free to "own" stuff that's yours. Apache 2.0 is really nice in this sense...

JonathanLevi (Fri, 04 Aug 2017 06:27:34 GMT):
Sure, sure. Having fun coding is more important, I know exactly what you mean ;-)

dsanchezseco (Fri, 04 Aug 2017 06:28:35 GMT):
I'll take it into account for the next time. Thanks for the heads up!

rameshthoomu (Fri, 04 Aug 2017 14:12:59 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/11975/

yacovm (Fri, 04 Aug 2017 16:40:27 GMT):
Mutual TLS in chaincode: https://gerrit.hyperledger.org/r/#/c/11911 has 1 +2, missing another one https://gerrit.hyperledger.org/r/#/c/11913 https://gerrit.hyperledger.org/r/#/c/11915

jyellick (Fri, 04 Aug 2017 17:17:38 GMT):
https://gerrit.hyperledger.org/r/#/c/12023/ <- Adds a log statement https://gerrit.hyperledger.org/r/#/c/12033/ <- Moves configtxgen to tools dir https://gerrit.hyperledger.org/r/#/c/12117/ <- Supports pretty printing endorsertx as JSON Three very small easy ones

dave.enyeart (Fri, 04 Aug 2017 18:39:59 GMT):
There will be a series of CRs for https://jira.hyperledger.org/browse/FAB-1151 epic, starting with: https://gerrit.hyperledger.org/r/#/c/12137/

eacoeytaux (Fri, 04 Aug 2017 19:54:56 GMT):
Has joined the channel.

jyellick (Sat, 05 Aug 2017 19:58:44 GMT):
https://gerrit.hyperledger.org/r/#/c/12033/ Needs one +2 -- small +54/-54 simple moving of a package, and fixing the imports referring to that package

jyellick (Sat, 05 Aug 2017 19:58:44 GMT):
https://gerrit.hyperledger.org/r/#/c/12033/ Needs one +2 -- small +54/-54 simply moving of a package, and fixing the imports referring to that package

jimthematrix (Sun, 06 Aug 2017 02:09:59 GMT):
https://gerrit.hyperledger.org/r/#/c/11629/ - need one more +2, enhancements to balance-transfer sample to make it possible to deploy to a non-local host environment like a cloud platform

mastersingh24 (Sun, 06 Aug 2017 12:25:10 GMT):
https://gerrit.hyperledger.org/r/#/c/12183/ - @jyellick @greg.haskins - updates the Makefile for cluster example now that configtxgen has been moved

mastersingh24 (Sun, 06 Aug 2017 13:45:22 GMT):
Folks - can we please merge the following: https://gerrit.hyperledger.org/r/#/c/12047/ (Fabric 1.0.1 release so I can then tag it) https://gerrit.hyperledger.org/r/#/c/12053/ (fabric-ca 1.0.1 patch) https://gerrit.hyperledger.org/r/#/c/12055/ (fabric-ca 1.0.1 release so I can then tag it)

yacovm (Sun, 06 Aug 2017 14:03:32 GMT):
@mastersingh24 the bootstrap.sh there is like the one in the previous release modulo the version?

mastersingh24 (Sun, 06 Aug 2017 15:35:00 GMT):
@yacovm - I hope so. I just copied the content and changed the version

mastersingh24 (Sun, 06 Aug 2017 15:35:00 GMT):
Hopefully I did not mess that up

yacovm (Sun, 06 Aug 2017 15:35:38 GMT):
I'll try to run and see if it explodes or not

yacovm (Sun, 06 Aug 2017 15:44:27 GMT):
``` ==> FABRIC IMAGE: couchdb Error response from daemon: manifest for hyperledger/fabric-couchdb:x86_64-1.0.1 not found Error response from daemon: No such image: hyperledger/fabric-couchdb:x86_64-1.0.1 ``` what am I doing wrong? running the `bootstrap-1.0.1.sh`

dsanchezseco (Mon, 07 Aug 2017 10:11:31 GMT):
Can someone please review this https://gerrit.hyperledger.org/r/#/c/12131? it fixes my previous one.

dave.enyeart (Mon, 07 Aug 2017 17:44:49 GMT):
The next in the series of side db CRs that needs a final +2: https://gerrit.hyperledger.org/r/#/c/12177/ @mastersingh24 @C0rWin

smithbk (Mon, 07 Aug 2017 20:06:41 GMT):
Pls review https://gerrit.hyperledger.org/r/#/c/11103/ : Add TLS profile to default fabric-ca config ... @mastersingh24 @yacovm

yacovm (Mon, 07 Aug 2017 20:13:03 GMT):
I put a comment @smithbk

rennman (Mon, 07 Aug 2017 20:53:22 GMT):
https://gerrit.hyperledger.org/r/#/c/9407/ : [FAB-3924] Improve test coverage of lib has been re-based and passed CI

rennman (Mon, 07 Aug 2017 20:55:14 GMT):
per last message, @mastersingh24 @JonathanLevi @smithbk

dave.enyeart (Mon, 07 Aug 2017 21:09:39 GMT):
Side DB CRs ready for final +2 review:

dave.enyeart (Mon, 07 Aug 2017 21:09:39 GMT):
Side DB CRs ready for final +2 review @mastersingh24 :

dave.enyeart (Mon, 07 Aug 2017 21:09:41 GMT):
https://gerrit.hyperledger.org/r/#/c/12177

dave.enyeart (Mon, 07 Aug 2017 21:09:48 GMT):
https://gerrit.hyperledger.org/r/#/c/12209/

dave.enyeart (Mon, 07 Aug 2017 21:09:55 GMT):
https://gerrit.hyperledger.org/r/#/c/12163/

muralisr (Tue, 08 Aug 2017 00:36:02 GMT):
ACL framework needs one more +2 https://gerrit.hyperledger.org/r/#/c/12213/ please

C0rWin (Tue, 08 Aug 2017 11:24:40 GMT):
easy for review gossip extension of state db related to private data replication via state transfer: ... https://gerrit.hyperledger.org/r/#/c/12217/ https://gerrit.hyperledger.org/r/#/c/12219/ https://gerrit.hyperledger.org/r/#/c/12221/ one more +2 to go :)

yacovm (Tue, 08 Aug 2017 11:38:28 GMT):
Can attest it is indeed easy to review

rameshthoomu (Tue, 08 Aug 2017 13:19:35 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/11975/

mastersingh24 (Tue, 08 Aug 2017 20:46:03 GMT):
[done ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=MXwPuCCukfXfdnFKn) @C0rWin

smithbk (Tue, 08 Aug 2017 22:25:04 GMT):
For fabric-ca:

smithbk (Tue, 08 Aug 2017 22:25:07 GMT):
https://gerrit.hyperledger.org/r/#/c/11567/ - Improve error handling (#1) https://gerrit.hyperledger.org/r/#/c/11569/ - Improve error handling (#2) https://gerrit.hyperledger.org/r/#/c/11571/ - Improve error handling (#3)

dsanchezseco (Wed, 09 Aug 2017 06:34:58 GMT):
this one is easy too. just two chars! https://gerrit.hyperledger.org/r/#/c/12131

muralisr (Wed, 09 Aug 2017 11:35:45 GMT):
2 CRs for the ACL work please

muralisr (Wed, 09 Aug 2017 11:36:39 GMT):
https://gerrit.hyperledger.org/r/#/c/12271/ - basic framework for calling CheckACL on providers (default and rscc) from the peer

muralisr (Wed, 09 Aug 2017 11:36:39 GMT):
https://gerrit.hyperledger.org/r/#/c/12213/ - basic framework for calling CheckACL on providers (default and rscc) from the peer

yacovm (Wed, 09 Aug 2017 11:36:40 GMT):
are you giving or asking?

muralisr (Wed, 09 Aug 2017 11:37:56 GMT):
https://gerrit.hyperledger.org/r/#/c/12271/ - the RSCC described in https://jira.hyperledger.org/browse/FAB-3621 as a provider for the above

cbf (Wed, 09 Aug 2017 12:20:04 GMT):
@kostas @jyellick any reason that https://gerrit.hyperledger.org/r/c/12007/ was not submitted? I don't see any controversy but I know you're both very deliberate so I held off merging

kostas (Wed, 09 Aug 2017 12:26:31 GMT):
@cbf: It's just that it hadn't passed CI until earlier today. Merged now, thanks for the heads up, and for checking.

cbf (Wed, 09 Aug 2017 12:26:55 GMT):
kk

C0rWin (Wed, 09 Aug 2017 12:27:10 GMT):
https://gerrit.hyperledger.org/r/#/c/12265/ adding UT to state transfer

dave.enyeart (Wed, 09 Aug 2017 13:11:02 GMT):
The next CR in the series for Side DB is ready for a final +2 review: https://gerrit.hyperledger.org/r/#/c/12163/

rennman (Wed, 09 Aug 2017 15:24:16 GMT):
the following related CRs have completed reviews for the most part ... They are listed in order, with their cumulative scores. 11485 and 9819 need a little boost. +3 https://gerrit.hyperledger.org/r/#/c/11485/ - [ FAB-5251 ] Changes to optimize fvt tests +5 https://gerrit.hyperledger.org/r/#/c/11545/ - [ FAB-5254 ] Add logging for haproxy +5 https://gerrit.hyperledger.org/r/#/c/11565/ - [ FAB-5278 ] Multi-ca fvt test +3 https://gerrit.hyperledger.org/r/#/c/9819/ - [ FAB-3982 ] TLS copy tools for fabric-ca tests +5 https://gerrit.hyperledger.org/r/#/c/9843/ [ FAB-3982 ] TLS dynamic certs for fabric-ca tests +5 https://gerrit.hyperledger.org/r/#/c/8993/ - [ FAB-1383 ] Add TLS tests for mysql +5 https://gerrit.hyperledger.org/r/#/c/12021/ - [ FAB-5521 ] Fix CI build fail x86 for slapd +5 https://gerrit.hyperledger.org/r/#/c/12073/ - [ FAB-5555 ] Improve password-masking test

smithbk (Wed, 09 Aug 2017 16:36:34 GMT):
For fabric-ca pls @mastersingh24 @yacovm

smithbk (Wed, 09 Aug 2017 16:36:36 GMT):
https://gerrit.hyperledger.org/r/#/c/11567/ - Improve error handling (#1) https://gerrit.hyperledger.org/r/#/c/11569/ - Improve error handling (#2) https://gerrit.hyperledger.org/r/#/c/11571/ - Improve error handling (#3)

rameshthoomu (Wed, 09 Aug 2017 19:13:08 GMT):
Need review on this https://gerrit.hyperledger.org/r/#/c/12275/ (Tested in CI sandbox and worked as expected)

C0rWin (Wed, 09 Aug 2017 21:51:06 GMT):
simple refactor https://gerrit.hyperledger.org/r/#/c/12285/

grapebaba (Thu, 10 Aug 2017 06:21:42 GMT):
https://gerrit.hyperledger.org/r/#/c/11933/ still need someone review

JonathanLevi (Thu, 10 Aug 2017 10:05:02 GMT):
@grapebaba: Merged.

rameshthoomu (Thu, 10 Aug 2017 14:13:08 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/11249/ https://gerrit.hyperledger.org/r/#/c/11975/

rameshthoomu (Thu, 10 Aug 2017 14:17:20 GMT):
Trivial patch to fix daily CI job failures https://gerrit.hyperledger.org/r/#/c/12275/

rameshthoomu (Thu, 10 Aug 2017 16:23:55 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/12275/

kostas (Thu, 10 Aug 2017 23:41:19 GMT):
Can we please have this merged? https://gerrit.hyperledger.org/r/#/c/11267/

mastersingh24 (Fri, 11 Aug 2017 07:52:24 GMT):
@kostas - ^^^^ done

yacovm (Fri, 11 Aug 2017 08:51:42 GMT):
https://gerrit.hyperledger.org/r/#/c/12321/ easy one

muralisr (Fri, 11 Aug 2017 12:38:20 GMT):
https://gerrit.hyperledger.org/r/#/c/12359/ easy one too

mastersingh24 (Fri, 11 Aug 2017 13:13:12 GMT):
https://gerrit.hyperledger.org/r/#/c/12243/ easy three

jyellick (Fri, 11 Aug 2017 14:06:53 GMT):
https://gerrit.hyperledger.org/r/#/c/11785/ ^ Actually not easy. Still, it's 3 weeks old and has received a fair bit of review, just needs one more +2

yacovm (Fri, 11 Aug 2017 20:38:04 GMT):
2 easy ones, were +2ed several times before and reviewed by 3 different people but alas - the +2s have been wiped out and need to be placed once more https://gerrit.hyperledger.org/r/#/c/12279/ https://gerrit.hyperledger.org/r/#/c/12281/

muralisr (Sat, 12 Aug 2017 05:25:48 GMT):
some love for the following CRs please https://gerrit.hyperledger.org/r/#/c/12223/3 https://gerrit.hyperledger.org/r/#/c/12225/3 https://gerrit.hyperledger.org/r/#/c/12227/3 https://gerrit.hyperledger.org/r/#/c/12231/7 https://gerrit.hyperledger.org/r/#/c/12291/5 https://gerrit.hyperledger.org/r/#/c/12293/4 https://gerrit.hyperledger.org/r/#/c/12295/4 https://gerrit.hyperledger.org/r/#/c/12297/5 https://gerrit.hyperledger.org/r/#/c/12317/3 https://gerrit.hyperledger.org/r/#/c/12319/2 https://gerrit.hyperledger.org/r/#/c/12327/3 https://gerrit.hyperledger.org/r/#/c/12335/4 This basically adjust policies/config code to accommodate "Resources" config in addition to existing "Channel" config. We have pulled the code and tested the integration with the ACL work for fab-3621. Will leave it to @jyellick to expand if necessary

mastersingh24 (Sat, 12 Aug 2017 11:21:28 GMT):
The last one for the 1.0.1 release - docs are still published from master so needed to pick up the doc changes - https://gerrit.hyperledger.org/r/#/c/12383/

muralisr (Sat, 12 Aug 2017 12:16:57 GMT):
@mastersingh24 done but didnt push "submit"

mastersingh24 (Sat, 12 Aug 2017 12:23:08 GMT):
Thx @muralisr - should be safe to merge

muralisr (Sat, 12 Aug 2017 12:23:55 GMT):
sure, done

jyellick (Sat, 12 Aug 2017 16:35:07 GMT):
Critical one, master is currently broken: https://gerrit.hyperledger.org/r/12387

smithbk (Sat, 12 Aug 2017 20:30:24 GMT):
https://gerrit.hyperledger.org/r/#/c/11571/ - needs one more +2

muralisr (Sun, 13 Aug 2017 13:00:53 GMT):
FAB-1632 appears to be happening more frequently in CI these days and slowing considerably. https://gerrit.hyperledger.org/r/#/c/12393/ will fix that.

yacovm (Sun, 13 Aug 2017 19:00:14 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/12395/

adc (Mon, 14 Aug 2017 08:12:29 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/12343/ and related change-sets please :)

rameshthoomu (Mon, 14 Aug 2017 14:15:03 GMT):
@jyellick fixed `curl` command issue https://gerrit.hyperledger.org/r/#/c/12369/

jyellick (Mon, 14 Aug 2017 14:16:22 GMT):
What do you think of the idea of create a no-op CR and running reverify against it several times, looking for failures, to identify any other problems?

rameshthoomu (Mon, 14 Aug 2017 14:16:48 GMT):
new url is taking 2-3 secs to download..

rameshthoomu (Mon, 14 Aug 2017 14:17:05 GMT):
Sure will test that today..

rameshthoomu (Mon, 14 Aug 2017 15:42:11 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/12369/

rameshthoomu (Mon, 14 Aug 2017 18:54:12 GMT):
simple fix https://gerrit.hyperledger.org/r/#/c/12373/

muralisr (Mon, 14 Aug 2017 19:24:25 GMT):
https://gerrit.hyperledger.org/r/#/c/12429 brings together resource/ACL work (with the policy work from https://gerrit.hyperledger.org/r/#/c/12335/ series and ledger hook from https://gerrit.hyperledger.org/r/#/c/12371).

C0rWin (Mon, 14 Aug 2017 20:20:30 GMT):
https://gerrit.hyperledger.org/r/#/c/12413/ some side db related work, needs last +2 to go

smithbk (Mon, 14 Aug 2017 20:34:58 GMT):
https://gerrit.hyperledger.org/r/#/c/12433/ - trivial debug message fix https://gerrit.hyperledger.org/r/#/c/11571/ - improved error handling (#3) - needs 1 more +2 https://gerrit.hyperledger.org/r/#/c/11969/ - role based access control (#1) https://gerrit.hyperledger.org/r/#/c/12031/ - role based access control (#2) https://gerrit.hyperledger.org/r/#/c/12337/ - role based access control (#3)

jpatchell (Tue, 15 Aug 2017 12:57:07 GMT):
Has joined the channel.

jpatchell (Tue, 15 Aug 2017 13:06:00 GMT):
https://gerrit.hyperledger.org/r/#/c/11759 - gencsr command for fabric-ca-client - needs 1 more +2

rameshthoomu (Tue, 15 Aug 2017 13:17:21 GMT):
Need some love on below patches: https://gerrit.hyperledger.org/r/#/c/12373/ (Trivial fix for byfn e2e failure) https://gerrit.hyperledger.org/r/#/c/12369/ (Improve download speed of maven package) https://gerrit.hyperledger.org/r/#/c/12425/ (Enable kafka, couchdb bddtests) https://gerrit.hyperledger.org/r/#/c/11945/ (Cleanup deadcode from bddtests/regression)

smithbk (Tue, 15 Aug 2017 15:11:58 GMT):
extremely trivial, needs 1 more +2: https://gerrit.hyperledger.org/r/#/c/12433/

C0rWin (Tue, 15 Aug 2017 15:24:50 GMT):
https://gerrit.hyperledger.org/r/#/c/12467/ another one for side db work

smithbk (Tue, 15 Aug 2017 17:16:57 GMT):
Two very simple ones for fabric-ca: @mastersingh24 @yacovm @JonathanLevi

smithbk (Tue, 15 Aug 2017 17:17:00 GMT):
https://gerrit.hyperledger.org/r/#/c/12479/ - simple change to fix CI failure https://gerrit.hyperledger.org/r/#/c/12433/ - trivial debug message fix

JonathanLevi (Tue, 15 Aug 2017 17:52:37 GMT):
@smithbk: I have just merged them both.

smithbk (Tue, 15 Aug 2017 17:54:19 GMT):
@JonathanLevi Thanks

rameshthoomu (Tue, 15 Aug 2017 18:03:56 GMT):
Need one more +2 on this patch..https://gerrit.hyperledger.org/r/#/c/12369 (Improve download speed of maven package)

rameshthoomu (Tue, 15 Aug 2017 18:03:56 GMT):
Need one more +2 on this patch.. https://gerrit.hyperledger.org/r/#/c/12369 (Improve download speed of maven package)

cbf (Tue, 15 Aug 2017 18:59:57 GMT):
https://gerrit.hyperledger.org/r/c/12323/ needs some eyes... simple doc enhancement

smithbk (Wed, 16 Aug 2017 10:34:39 GMT):
A very easy one: https://gerrit.hyperledger.org/r/#/c/12501/

yacovm (Wed, 16 Aug 2017 19:09:53 GMT):
Master branch https://gerrit.hyperledger.org/r/#/c/12511/ release branch https://gerrit.hyperledger.org/r/#/c/12495/ @binhn @C0rWin ready to be merged

binhn (Wed, 16 Aug 2017 19:11:09 GMT):
cool

yacovm (Thu, 17 Aug 2017 09:37:08 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/12525/

jimthematrix (Thu, 17 Aug 2017 15:03:09 GMT):
https://gerrit.hyperledger.org/r/#/c/12515/ - I'd like to ask for this to be reviewed and merged to enable node.js chaincode, the shim implementation is being done in the fabric-chaincode-node repo, and its latest content enables a node.js chaincode developer to test (peer in devmode) and deploy (peer in network mode) already, with the remaining work in completing the advanced shim APIs (that requires iterative requests back to the peer such as GetStateByRange(), etc.), @muralisr @mastersingh24 @binhn @yacovm @greg.haskins

jimthematrix (Thu, 17 Aug 2017 15:04:32 GMT):
if you want to test it locally, follow the readme https://github.com/hyperledger/fabric-chaincode-node to try it out

muralisr (Thu, 17 Aug 2017 15:33:50 GMT):
@jimthematrix took a quick look and looks good. Will do a deeper review by end of today

muralisr (Thu, 17 Aug 2017 15:34:23 GMT):
we will need the FSM removal code at some point too

jimthematrix (Thu, 17 Aug 2017 15:51:28 GMT):
thanks @muralisr , this code is independent of the FSM removal (CR 11867, which is not going to change ABI), I actually had a different CR that builds on top of 11867, which I've since abandoned since the two aren't tied to each other. in other words, my changes work with and without the FSM removal

muralisr (Thu, 17 Aug 2017 15:52:27 GMT):
indeed, you are right.. I don't see chaincode/handler.go there (need to get eyes checked :-) )

smithbk (Thu, 17 Aug 2017 16:04:49 GMT):
For fabric-ca serviceability: https://gerrit.hyperledger.org/r/#/c/12463/ - vendored pkg/errors https://gerrit.hyperledger.org/r/#/c/12565/ - use pkg/errors to create errors https://gerrit.hyperledger.org/r/#/c/12567/ - Integrate pkg/errors with httpErr For fabric-ca support for role-based access control: https://gerrit.hyperledger.org/r/#/c/11969/ - role based access control (#1) https://gerrit.hyperledger.org/r/#/c/12031/ - role based access control (#2) https://gerrit.hyperledger.org/r/#/c/12337/ - role based access control (#3) https://gerrit.hyperledger.org/r/#/c/12519/ - role based access control (#4)

aleksandar.likic (Thu, 17 Aug 2017 17:33:33 GMT):
Has joined the channel.

aleksandar.likic (Thu, 17 Aug 2017 17:33:41 GMT):
Hi, this CR is ready for review: https://gerrit.hyperledger.org/r/#/c/12435/. Notice that the 'behave' part of the build is currently failing because a change to CI is needed and has to be made together with the code change, but the CI change has been verified by Ramesh Babu (see his comment on Patch Set 2) and the agreement with him is that he'll make a simple change to CI at the time the change is merged. This is adding to fabric an ability to distribute precompiled chaincode in binary form. See https://jira.hyperledger.org/browse/FAB-5460. The design document is at https://docs.google.com/document/d/1kTkZEEaIB6tQJTQtWzx1YH2zR1O2PwrRhIVpTSUpLiQ/edit#heading=h.9pacqguezrqe. Thanks!

jyellick (Fri, 18 Aug 2017 15:36:32 GMT):
https://gerrit.hyperledger.org/r/#/c/12589/ <- trivial one that is only sample clients

jimthematrix (Fri, 18 Aug 2017 19:51:44 GMT):
@muralisr @greg.haskins @mastersingh24 @binhn reminder to review https://gerrit.hyperledger.org/r/#/c/12515/ - node.js chaincode support enablement, I'd like to get this merged sooner rather than later because 1) the code has been under test locally and by Ramesh's new CI and proven to work, 2) this is just the enablement part so there's no functional exposure, 3) the bulk of the work in fabric-chaincode-node is progressing well that one can already try things out in dev and network mode

jimthematrix (Fri, 18 Aug 2017 19:51:44 GMT):
@muralisr @greg.haskins @mastersingh24 @binhn reminder to review https://gerrit.hyperledger.org/r/#/c/12515/ - node.js chaincode support enablement, I'd like to ask to get this merged sooner rather than later because 1) the code has been under test locally and by Ramesh's new CI and proven to work, 2) this is just the enablement part so there's no functional exposure, 3) the bulk of the work in fabric-chaincode-node is progressing well that one can already try things out in dev and network mode

jimthematrix (Fri, 18 Aug 2017 20:17:16 GMT):
@tongli @muralisr thanks for the comments, see my responses in the CR

muralisr (Fri, 18 Aug 2017 20:19:31 GMT):
thanks @jimthematrix +1 for now waiting for others to review

muralisr (Fri, 18 Aug 2017 20:20:06 GMT):
will look for reviews over ... and if it needs a +2 to merge, will +2 merge

muralisr (Fri, 18 Aug 2017 20:20:06 GMT):
will look out for other reviews ... and if it needs a +2 to merge, will +2 merge

smithbk (Sat, 19 Aug 2017 12:54:30 GMT):
@binh @JonathanLevi @yacovm Could really use some help in getting these reviewed ... thanks

smithbk (Sat, 19 Aug 2017 12:54:30 GMT):
@binhn @JonathanLevi @yacovm Could really use some help in getting these reviewed ... thanks

smithbk (Sat, 19 Aug 2017 12:54:30 GMT):
@binhn @JonathanLevi @yacovm or anyone, could really use some help in getting these reviewed ... thanks

smithbk (Sat, 19 Aug 2017 12:54:38 GMT):
For fabric-ca serviceability: https://gerrit.hyperledger.org/r/#/c/12463/ - vendoring github.com/pkg/errors (very easy, need 1 more +2) https://gerrit.hyperledger.org/r/#/c/12565/ - use pkg/errors to create errors (very straight forward) https://gerrit.hyperledger.org/r/#/c/12567/ - Integrate pkg/errors with httpErr For fabric-ca support for role-based access control: https://gerrit.hyperledger.org/r/#/c/11969/ - role based access control (#1) - a new package to manage attributes in an x509 cert https://gerrit.hyperledger.org/r/#/c/12031/ - role based access control (#2) https://gerrit.hyperledger.org/r/#/c/12337/ - role based access control (#3) https://gerrit.hyperledger.org/r/#/c/12519/ - role based access control (#4)

smithbk (Sat, 19 Aug 2017 12:56:09 GMT):
I have one more role-based access control change set to do in fabric, but 11969 needs to be merged in fabric-ca first

cbf (Sat, 19 Aug 2017 21:44:32 GMT):
https://gerrit.hyperledger.org/r/c/12323/ please - been a while

yacovm (Sun, 20 Aug 2017 12:19:22 GMT):
2 Easy ones, each around *30 LOC* 1) Test related change set https://gerrit.hyperledger.org/r/#/c/12415/ 2) Log formatting https://gerrit.hyperledger.org/r/#/c/12617/

yacovm (Sun, 20 Aug 2017 12:19:22 GMT):
2 Easy ones, each around *30 LOC*, and have +2 (missing another one) 1) Test related change set https://gerrit.hyperledger.org/r/#/c/12415/ 2) Log formatting https://gerrit.hyperledger.org/r/#/c/12617/

yacovm (Sun, 20 Aug 2017 12:19:22 GMT):
~ 2 Easy ones, each around *30 LOC*, and have +2 (missing another one) ~ ~ 1) Test related change set https://gerrit.hyperledger.org/r/#/c/12415/ ~ ~ 2) Log formatting https://gerrit.hyperledger.org/r/#/c/12617/ ~

smithbk (Mon, 21 Aug 2017 13:50:59 GMT):
For fabric-ca serviceability: https://gerrit.hyperledger.org/r/#/c/12565/ - use pkg/errors to create errors (very straight forward) https://gerrit.hyperledger.org/r/#/c/12567/ - Integrate pkg/errors with httpErr For fabric-ca support for role-based access control: https://gerrit.hyperledger.org/r/#/c/11969/ - role-based access control (#1) - a new package to manage attributes in an x509 cert which will be used by fabric https://gerrit.hyperledger.org/r/#/c/12031/ - role-based access control (#2) https://gerrit.hyperledger.org/r/#/c/12337/ - role-based access control (#3) https://gerrit.hyperledger.org/r/#/c/12519/ - role-based access control (#4) NOTE: Once 11969 is merged, then I will be able to finish role-based access control by submitting a fabric change set which uses the fabric-ca/attrmgr package.

aambati (Mon, 21 Aug 2017 17:13:14 GMT):
@smithbk @JonathanLevi @mastersingh24 Please reeview https://gerrit.hyperledger.org/r/c/12485/ and https://gerrit.hyperledger.org/r/c/12489/.. One change set for JIRA FAB-3458 has already been merged..these are other two change sets for this JIRA

jyellick (Mon, 21 Aug 2017 19:04:23 GMT):
https://gerrit.hyperledger.org/r/#/c/12589/ <- needs one more +2

dsanchezseco (Tue, 22 Aug 2017 10:09:06 GMT):
https://gerrit.hyperledger.org/r/#/c/12133/ easy one

jimthematrix (Tue, 22 Aug 2017 16:14:53 GMT):
https://jira.hyperledger.org/browse/FAB-5823 - upgrade node.js engine in fabric-baseimage from 6.9.5 to 8.4.0. @greg.haskins @mastersingh24 @binhn @sstone1

jimthematrix (Tue, 22 Aug 2017 16:16:02 GMT):
this set up has been tested successfully in the context of the fabric-chaincode-node integration tests

adc (Wed, 23 Aug 2017 00:44:26 GMT):
Hi All, is it possible to vendor packages with MIT license?

jyellick (Wed, 23 Aug 2017 01:11:13 GMT):
@adc Looks like it is okay https://www.apache.org/legal/resolved.html#category-a

jyellick (Wed, 23 Aug 2017 01:11:13 GMT):
@adc Looks like MIT is okay https://www.apache.org/legal/resolved.html#category-a And FYI here is a list which is not okay: https://www.apache.org/legal/resolved.html#category-x there has been a discussion recently on the TSC list especially about the BSD+patents license from Facebook for React JS which is prohibited.

adc (Wed, 23 Aug 2017 01:14:20 GMT):
great, thanks a lot for the feedback :)

jimthematrix (Wed, 23 Aug 2017 12:48:10 GMT):
https://gerrit.hyperledger.org/r/#/c/12515/ need one more +2, @muralisr ? ;-)

muralisr (Wed, 23 Aug 2017 12:49:08 GMT):
looking @jimthematrix

jimthematrix (Wed, 23 Aug 2017 23:12:07 GMT):
https://gerrit.hyperledger.org/r/#/c/12697/ - easy one, adding per-request timeout support for peer proposals

grapebaba (Thu, 24 Aug 2017 12:40:56 GMT):
https://gerrit.hyperledger.org/r/#/c/12737/ metrics add statsd reporter and test

mastersingh24 (Thu, 24 Aug 2017 14:06:46 GMT):
Quick one: https://gerrit.hyperledger.org/r/#/c/12089/

jimthematrix (Thu, 24 Aug 2017 17:02:47 GMT):
https://gerrit.hyperledger.org/r/#/c/12697/ - needs one more +2

muralisr (Thu, 24 Aug 2017 17:15:36 GMT):
a easy one https://gerrit.hyperledger.org/r/#/c/12727/ please

muralisr (Thu, 24 Aug 2017 19:04:32 GMT):
anothe easy one https://gerrit.hyperledger.org/r/#/c/12763/ please

jimthematrix (Thu, 24 Aug 2017 19:14:41 GMT):
https://gerrit.hyperledger.org/r/#/c/12665/ - updating the node.js engine in fabric-baseimage to 8.4.0 (from 6.9.5). as far as i know the node.js engine in fabric-baseimage is not being used currently, so this should be a safe update. node 8.4+ is needed for node chaincode support

jimthematrix (Thu, 24 Aug 2017 19:16:44 GMT):
once this gets merged and published to docker hub, will next update the BASE_VERSION in fabric to pick it up

jimthematrix (Thu, 24 Aug 2017 19:16:44 GMT):
once this gets merged and published to docker hub, will next update the .baseimage-release in fabric to pick it up

jimthematrix (Thu, 24 Aug 2017 19:18:27 GMT):
an alternative is having a separate image dedicated to node.js runtime (baseos + node 8.4), which @mastersingh24 is working on

greg.haskins (Thu, 24 Aug 2017 19:22:34 GMT):
few easy ones: https://gerrit.hyperledger.org/r/#/c/12107/ https://gerrit.hyperledger.org/r/#/c/12109/

sudeshrshetty (Thu, 24 Aug 2017 20:01:46 GMT):
Has joined the channel.

rameshthoomu (Thu, 24 Aug 2017 20:35:29 GMT):
need one more +2 on this patch set https://gerrit.hyperledger.org/r/#/c/12763/ (Unit-test CI job is failing consistently)

adc (Fri, 25 Aug 2017 01:25:32 GMT):
sorry, is master broken? I see this: ```panic: ---empty version---(chain=mockchainid,chaincode=cscc,version=,txid=,syscc=true,proposal=0x0 [recovered] panic: ---empty version---(chain=mockchainid,chaincode=cscc,version=,txid=,syscc=true,proposal=0x0 goroutine 20 [running]: testing.tRunner.func1(0xc4203124e0) /usr/local/Cellar/go/1.8.3/libexec/src/testing/testing.go:622 +0x29d panic(0x47a2760, 0xc420309060) /usr/local/Cellar/go/1.8.3/libexec/src/runtime/panic.go:489 +0x2cf github.com/hyperledger/fabric/core/common/ccprovider.NewCCContext(0x48f64d8, 0xb, 0x48ef9bb, 0x4, 0x0, 0x0, 0x0, 0x0, 0x4d6b101, 0x0, ...) /Users/adc/golang/src/github.com/hyperledger/fabric/core/common/ccprovider/ccprovider.go:357 +0xa56 github.com/hyperledger/fabric/core/chaincode.(*ccProviderImpl).GetCCContext(0xc420309000, 0x48f64d8, 0xb, 0x48ef9bb, 0x4, 0x0, 0x0, 0x0, 0x0, 0xc420165701, ...) /Users/adc/golang/src/github.com/hyperledger/fabric/core/chaincode/ccproviderimpl.go:71 +0xb3 github.com/hyperledger/fabric/core/scc.DeDeploySysCC(0x48f64d8, 0xb, 0x4d44520, 0x6, 0x30) /Users/adc/golang/src/github.com/hyperledger/fabric/core/scc/sysccapi.go:163 +0x2f8 github.com/hyperledger/fabric/core/scc.DeDeploySysCCs(0x48f64d8, 0xb) /Users/adc/golang/src/github.com/hyperledger/fabric/core/scc/importsysccs.go:115 +0x65 github.com/hyperledger/fabric/core/chaincode.initMockPeer(0xc4200fdf78, 0x2, 0x2, 0x2, 0x3) /Users/adc/golang/src/github.com/hyperledger/fabric/core/chaincode/chaincode_support_test.go:168 +0x151 github.com/hyperledger/fabric/core/chaincode.TestCCFramework(0xc4203124e0) /Users/adc/golang/src/github.com/hyperledger/fabric/core/chaincode/chaincode_support_test.go:672 +0xb8 testing.tRunner(0xc4203124e0, 0x492b898) /usr/local/Cellar/go/1.8.3/libexec/src/testing/testing.go:657 +0x96 created by testing.(*T).Run /usr/local/Cellar/go/1.8.3/libexec/src/testing/testing.go:697 +0x2ca Process finished with exit code 2 ```

jiangyaoguo (Fri, 25 Aug 2017 11:01:07 GMT):
https://gerrit.hyperledger.org/r/#/c/9347/ add a chaincode list cmd to get chaincode info

mastersingh24 (Fri, 25 Aug 2017 11:08:40 GMT):
[cool ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=T3vR8gspjbtxNyRiR) @jiangyaoguo

muralisr (Fri, 25 Aug 2017 11:52:48 GMT):
@adc are you running with --ldflags ?

muralisr (Fri, 25 Aug 2017 11:52:48 GMT):
@adc are you running with --ldflags (see `version=,` )?

aambati (Fri, 25 Aug 2017 14:12:47 GMT):
@smithbk @JonathanLevi @mastersingh24 Can you please review FAB-3013.. it has four change sets: https://gerrit.hyperledger.org/r/c/11623/, https://gerrit.hyperledger.org/r/c/11621/, https://gerrit.hyperledger.org/r/c/11641/, https://gerrit.hyperledger.org/r/c/11627/

rennman (Fri, 25 Aug 2017 18:01:24 GMT):
@smithbk @JonathanLevi @mastersingh24 , if you would, trivial rebase of these have passed CI test: https://gerrit.hyperledger.org/r/#/c/12073/ https://gerrit.hyperledger.org/r/#/c/12021/ https://gerrit.hyperledger.org/r/#/c/8993/ https://gerrit.hyperledger.org/r/#/c/9843/ thanks!

sanchezl (Fri, 25 Aug 2017 18:13:46 GMT):
• https://gerrit.hyperledger.org/r/#/c/12649/ Updates sample Kafka images from v0.9.0.1 to v0.10.1.0 Also added section 4.1.1 to the [Fabric Compatibility document].(https://docs.google.com/document/d/1CbB8dR0GNnHi7UekIDpsySCBXkPTtKk0m53CIzJbU-A/edit?usp=sharing)

yacovm (Sun, 27 Aug 2017 05:19:26 GMT):
https://gerrit.hyperledger.org/r/#/c/12635/ just need to click submit

jyellick (Sun, 27 Aug 2017 06:16:15 GMT):
https://gerrit.hyperledger.org/r/#/c/12593/ A simple serviceability one https://gerrit.hyperledger.org/r/#/c/12563/ The tail of a long series that could use a little love

yacovm (Sun, 27 Aug 2017 10:01:16 GMT):
This has been merged into `master` - should be also merged into `release` https://gerrit.hyperledger.org/r/#/c/12495/ missing 1 +2

mastersingh24 (Sun, 27 Aug 2017 11:08:22 GMT):
@yacovm - I'm going to put together the 1.0.2 list for stuff to merge into the release branch today/tomorrow ;)

yacovm (Sun, 27 Aug 2017 11:08:53 GMT):
I just want to see 1 less item in my outgoing reviews, that's all :)

mastersingh24 (Sun, 27 Aug 2017 11:09:17 GMT):
I hear ya

mastersingh24 (Sun, 27 Aug 2017 11:09:43 GMT):
@jyellick - been working through your series. For others, Jason's series is pretty easy to review ;)

yacovm (Sun, 27 Aug 2017 11:31:40 GMT):
https://gerrit.hyperledger.org/r/#/c/11275/ Simple code removal, courtesy of @nnao

yacovm (Sun, 27 Aug 2017 11:31:40 GMT):
https://gerrit.hyperledger.org/r/#/c/11275/ Simple code cleanup, courtesy of @nnao

nnao (Sun, 27 Aug 2017 11:31:40 GMT):
Has joined the channel.

mastersingh24 (Sun, 27 Aug 2017 14:52:35 GMT):
@greg.haskins @jimthematrix (or anyone else) - can you submit https://gerrit.hyperledger.org/r/#/c/12821/ ? e2e finally passed ;)

muralisr (Sun, 27 Aug 2017 15:05:57 GMT):
done @mastersingh24

lehors (Mon, 28 Aug 2017 14:14:39 GMT):
@smithbk I rebased and updated https://gerrit.hyperledger.org/r/#/c/11639/ to use the new error package, it should be ready for a merge now

mastersingh24 (Mon, 28 Aug 2017 14:51:14 GMT):
@lehors - going to have to go over this with a fine-toothed comb ;)

mastersingh24 (Mon, 28 Aug 2017 14:51:16 GMT):
Haha

mastersingh24 (Mon, 28 Aug 2017 14:51:23 GMT):
(my way of saying hi)

lehors (Mon, 28 Aug 2017 14:51:34 GMT):
hi gari

lehors (Mon, 28 Aug 2017 14:51:44 GMT):
well, keith already came up with a couple of comments

lehors (Mon, 28 Aug 2017 14:52:42 GMT):
@smithbk I was using closeDB and you suggested Clean :)

lehors (Mon, 28 Aug 2017 14:53:24 GMT):
I thought your point about being the pendant of Init was good so I changed

lehors (Mon, 28 Aug 2017 14:53:24 GMT):
I thought your point about being the opposite (?) of Init was good so I changed

lehors (Mon, 28 Aug 2017 14:54:34 GMT):
but that's minor

smithbk (Mon, 28 Aug 2017 14:54:57 GMT):
yeh, but as I looked closer, I didn't think it was doing the opposite of Init as it doesn't delete the generate crypto

smithbk (Mon, 28 Aug 2017 14:54:57 GMT):
yeh, but as I looked closer, I didn't think it was doing the opposite of Init as it doesn't delete the generated crypto

lehors (Mon, 28 Aug 2017 14:55:14 GMT):
indeed

lehors (Mon, 28 Aug 2017 15:00:21 GMT):
@smithbk I see your point about moving the call to serve

lehors (Mon, 28 Aug 2017 15:01:38 GMT):
how do I suggest I treat the errors though? serve returns the http.Serve error

lehors (Mon, 28 Aug 2017 15:01:38 GMT):
how do you suggest I treat the errors though? serve returns the http.Serve error

lehors (Mon, 28 Aug 2017 15:02:54 GMT):
you don't treat the error returned by closeListener

lehors (Mon, 28 Aug 2017 15:03:00 GMT):
so I could do the same

lehors (Mon, 28 Aug 2017 15:03:41 GMT):
but that strategy hasn't always worked so I prefer to ask ;-)

smithbk (Mon, 28 Aug 2017 15:04:16 GMT):
I think just logging it is sufficient

smithbk (Mon, 28 Aug 2017 15:06:22 GMT):
And if there was not another error, you could also return the db close error ... but would not override an existing error

lehors (Mon, 28 Aug 2017 15:07:20 GMT):
ok

lehors (Mon, 28 Aug 2017 15:12:05 GMT):
regarding whether it should be public or not, the problem is that if one calls Init and not Start, then CloseDB must be called explicitly because you can't call Stop to get it done

smithbk (Mon, 28 Aug 2017 15:14:15 GMT):
hmm ... Init shouldn't leave the DB open

smithbk (Mon, 28 Aug 2017 15:14:15 GMT):
hmm ... Init shouldn't leave the DB open ... checking

lehors (Mon, 28 Aug 2017 15:14:38 GMT):
really?

lehors (Mon, 28 Aug 2017 15:15:35 GMT):
then the bug is different than what I understood

lehors (Mon, 28 Aug 2017 15:16:03 GMT):
I thought Init opens the db and needs to leave it open until the server is done

smithbk (Mon, 28 Aug 2017 15:17:01 GMT):
No, the purpose of Init is to create the crypto material without starting the server and is a complete operation

smithbk (Mon, 28 Aug 2017 15:17:11 GMT):
or should have been :-)

lehors (Mon, 28 Aug 2017 15:17:18 GMT):
I see :)

lehors (Mon, 28 Aug 2017 15:17:28 GMT):
ok, let me have another look at this then

lehors (Mon, 28 Aug 2017 15:18:13 GMT):
closing the db at the end of Init would certainly simplify things

smithbk (Mon, 28 Aug 2017 15:18:51 GMT):
yes, that is what it should be doing ... but doing it at the end of serve is also needed as you were doing

lehors (Mon, 28 Aug 2017 15:19:04 GMT):
yes, I realize that

lehors (Mon, 28 Aug 2017 15:19:41 GMT):
but I had to add a bunch of calls to Clean/CloseDB to the tests that can be removed if Init closes the db

lehors (Mon, 28 Aug 2017 15:19:49 GMT):
so, let me take another pass at it

lehors (Mon, 28 Aug 2017 15:19:50 GMT):
thanks

smithbk (Mon, 28 Aug 2017 15:19:59 GMT):
np

aambati (Mon, 28 Aug 2017 18:38:19 GMT):
@mastersingh24 @binhn @JonathanLevi can you pls review https://gerrit.hyperledger.org/r/c/11641/

aambati (Mon, 28 Aug 2017 18:38:45 GMT):
this is last change set that needs to go in before i can mark fab-3013 done

mastersingh24 (Mon, 28 Aug 2017 19:47:14 GMT):
@aambati - Done

mastersingh24 (Mon, 28 Aug 2017 19:47:53 GMT):
Folks: fabric v1.0.2 CRs are ready (thanks Jason and Yacov). Need another +2 for the following: https://gerrit.hyperledger.org/r/#/q/project:fabric+branch:release+(status:open+OR+status:merged)+since:%222017-08-11%22

muralisr (Mon, 28 Aug 2017 20:13:08 GMT):
a trivial bug fix https://gerrit.hyperledger.org/r/#/c/12873/ found when making sure @adc CRs work for default 1.0 ACL

muralisr (Mon, 28 Aug 2017 20:13:46 GMT):
with the above fix, @adc 's 4 CRs work with default 1.0

yacovm (Mon, 28 Aug 2017 21:46:02 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/12871/

vukolic (Tue, 29 Aug 2017 08:02:41 GMT):
Has joined the channel.

vukolic (Tue, 29 Aug 2017 08:06:19 GMT):
Hi all https://gerrit.hyperledger.org/r/#/c/12849/ is a performance-critical patch that addresses the current performance bottleneck in Fabric 1.0.1 - we would like to see it in 1.1. It fixes the issue described in https://jira.hyperledger.org/browse/FAB-5932 @mastersingh24 @yacovm @binhn @kostas @jyellick

yacovm (Tue, 29 Aug 2017 08:14:03 GMT):
@vukolic : 1) We must wait until @aso removes the WIP tag before it can be considered merge-able 2) What about pipelining? I think it's worth to have a pipeline that in the 1st part of the pipeline it does validation (CPU intensive) and in the 2nd part it does the commit (which is more IO intensive, since you write to the disk). When the validation of a block finishes, it is passed to the commit and then the CPU is free to do validation of the next block. 3) I think we must be careful not to over-commit the CPU with validation, because other components of the peer need the CPU (i.e gossip also uses validation of messages, and if you steal too many CPU cycles we'll start dropping blocks)

vukolic (Tue, 29 Aug 2017 08:16:54 GMT):
1) ack @aso 2) pipelining can be added orthogonally to this (and later on - it might complicate the CR to do it now) 3) number of goroutines in the threadpool is defaulted to 128*CPU which is certainly much less than go supports but seems sufficient to cover all txs in parallel in a majority of cases. The 128 is a configurable param.

vukolic (Tue, 29 Aug 2017 08:16:54 GMT):
1) ack @aso 2) pipelining can be added orthogonally to this (and later on - it might complicate the CR to do it now) 3) number of goroutines in the threadpool is defaulted to 128*#CPU which is certainly much less than go supports but seems sufficient to cover all txs in parallel in a majority of cases. The 128 is a configurable param.

yacovm (Tue, 29 Aug 2017 08:23:18 GMT):
3 - yeah, I'm just worried that would steal much CPU cycles from other CPU intensive code paths that the peer does. I guess the best way would be to simply evaluate

aso (Tue, 29 Aug 2017 08:54:02 GMT):
@vukolic @yacovm I've removed the WIP tag

aso (Tue, 29 Aug 2017 08:54:18 GMT):
re 2 -> I'm working on pipelining, that's a great idea

aso (Tue, 29 Aug 2017 08:54:32 GMT):
I think we can stage changes by letting this one in first and adding pipelining later, wdyt?

aso (Tue, 29 Aug 2017 08:55:15 GMT):
re 3 -> @yacovm if you think we should default to a smaller number, pls let me know, I'd be happy to change it. We picked 128 x NCPUs to maximize validator throughput

yacovm (Tue, 29 Aug 2017 09:14:15 GMT):
Of course, your change set is hard to review even now, no need to make it more complex

yacovm (Tue, 29 Aug 2017 09:14:22 GMT):
:wink:

natusenia (Tue, 29 Aug 2017 09:22:05 GMT):
Has joined the channel.

vukolic (Tue, 29 Aug 2017 09:33:44 GMT):
there is a lot of code shuffling but the logic appears (to us) simple

rameshthoomu (Tue, 29 Aug 2017 12:45:25 GMT):
Need review on this https://gerrit.hyperledger.org/r/#/c/11945/

skarim (Tue, 29 Aug 2017 14:12:16 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/12481/

aso (Tue, 29 Aug 2017 16:47:44 GMT):
*VERY* easy one https://gerrit.hyperledger.org/r/#/c/12925/ serviceability for MSP, needed for v1.1

skarim (Tue, 29 Aug 2017 17:33:12 GMT):
ready for review https://gerrit.hyperledger.org/r/#/c/12363/

jimthematrix (Tue, 29 Aug 2017 21:45:41 GMT):
https://gerrit.hyperledger.org/r/#/c/12685/ - adding node 8 support to node SDK

gennadyl (Wed, 30 Aug 2017 11:04:04 GMT):
https://gerrit.hyperledger.org/r/#/c/12865/ plz, review

rameshthoomu (Wed, 30 Aug 2017 15:03:18 GMT):
one more +2 pls https://gerrit.hyperledger.org/r/#/c/11945/

smithbk (Wed, 30 Aug 2017 15:28:25 GMT):
Need reviews for attribute-based access control:

smithbk (Wed, 30 Aug 2017 15:28:27 GMT):
https://gerrit.hyperledger.org/r/#/c/11969/ https://gerrit.hyperledger.org/r/#/c/12031/ https://gerrit.hyperledger.org/r/#/c/12337/ https://gerrit.hyperledger.org/r/#/c/12519/

latitiah (Wed, 30 Aug 2017 15:41:57 GMT):
I need 1 more +2 on this CR: https://gerrit.hyperledger.org/r/#/c/12647/ Thanks!

gennadyl (Wed, 30 Aug 2017 16:21:04 GMT):
https://gerrit.hyperledger.org/r/#/c/12911/ - plz review

jimthematrix (Wed, 30 Aug 2017 21:23:26 GMT):
https://gerrit.hyperledger.org/r/#/c/12685 - adding node 8 support to node SDK (and thanks @jyellick for the review)

rameshthoomu (Thu, 31 Aug 2017 13:04:14 GMT):
waiting for one more +2 https://gerrit.hyperledger.org/r/#/c/11945/

mastersingh24 (Thu, 31 Aug 2017 13:08:01 GMT):
fabric and fabric-ca 1.0.2 - https://gerrit.hyperledger.org/r/#/q/(project:fabric-ca+OR+project:fabric)+branch:release+status:open

mastersingh24 (Thu, 31 Aug 2017 19:42:27 GMT):
Update samples to work with 1.0.1 and 1.0.2 : https://gerrit.hyperledger.org/r/#/c/13069/

baohua (Fri, 01 Sep 2017 09:46:04 GMT):
Minor fix misusage and refine, thanks! https://gerrit.hyperledger.org/r/12655, https://gerrit.hyperledger.org/r/12693, https://gerrit.hyperledger.org/r/13077

elli-androulaki (Fri, 01 Sep 2017 11:33:39 GMT):
Hi everyone, Ale's CR on error handling for MSP is pending reviews :) https://gerrit.hyperledger.org/r/#/c/12925/

elli-androulaki (Fri, 01 Sep 2017 11:33:39 GMT):
Hi everyone, @aso 's CR on error handling for MSP is pending reviews :) https://gerrit.hyperledger.org/r/#/c/12925/

elli-androulaki (Fri, 01 Sep 2017 11:42:55 GMT):
Also these CRs on encryption shim: - https://gerrit.hyperledger.org/r/#/c/12787/ - no backward compatibility issue (has received two +2s but was not merged) - https://gerrit.hyperledger.org/r/#/c/12809/ - no backward compatibility issue (requires one more +2)

elli-androulaki (Fri, 01 Sep 2017 11:43:15 GMT):
ah!

grapebaba (Fri, 01 Sep 2017 11:55:12 GMT):
https://gerrit.hyperledger.org/r/#/c/13079/

grapebaba (Fri, 01 Sep 2017 11:55:30 GMT):
Prometheus reporter for metrics

baohua (Fri, 01 Sep 2017 13:29:45 GMT):
Fix hard-coded ChaincodeSpec Type: https://gerrit.hyperledger.org/r/13075

dave.enyeart (Fri, 01 Sep 2017 13:34:25 GMT):
These need a final +2 please:

dave.enyeart (Fri, 01 Sep 2017 13:34:27 GMT):
https://gerrit.hyperledger.org/r/#/c/12671/

dave.enyeart (Fri, 01 Sep 2017 13:34:40 GMT):
https://gerrit.hyperledger.org/r/#/c/11067/

dave.enyeart (Fri, 01 Sep 2017 13:34:54 GMT):
https://gerrit.hyperledger.org/r/#/c/11905/

greg.haskins (Fri, 01 Sep 2017 22:26:50 GMT):
final +2 please

greg.haskins (Fri, 01 Sep 2017 22:26:52 GMT):
https://gerrit.hyperledger.org/r/#/c/12107/

mastersingh24 (Fri, 01 Sep 2017 22:57:36 GMT):
@greg.haskins - done

mastersingh24 (Sat, 02 Sep 2017 17:04:00 GMT):
@greg.haskins - I think you need this one as well - https://gerrit.hyperledger.org/r/#/c/12185/

mastersingh24 (Sat, 02 Sep 2017 17:04:17 GMT):
(we moved the configxtxgen tool)

greg.haskins (Sun, 03 Sep 2017 01:59:55 GMT):
@mastersingh24 thanks mate, ill pull that in when I rebase the remaining queue

mastersingh24 (Sun, 03 Sep 2017 12:49:44 GMT):
Can we get some +2's on https://gerrit.hyperledger.org/r/#/c/13069/ ? It updates all the samples to work with v1.0.1 / v1.0.2 ;)

muralisr (Sun, 03 Sep 2017 13:22:46 GMT):
+2ed @mastersingh24 but didn't hit submit

mastersingh24 (Sun, 03 Sep 2017 13:23:14 GMT):
Feel free to submit ;)

muralisr (Sun, 03 Sep 2017 13:23:40 GMT):
done :-)

mastersingh24 (Sun, 03 Sep 2017 14:22:50 GMT):
One more for 1.0.2 - this merges master into release for fabric-samples - https://gerrit.hyperledger.org/r/#/c/13117/-1..1

mastersingh24 (Sun, 03 Sep 2017 14:23:52 GMT):
and after that 1 more +2 on https://gerrit.hyperledger.org/r/#/c/13113/ and 1.0.2 will officially be out the door

jyellick (Sun, 03 Sep 2017 15:50:52 GMT):
@mastersingh24 +2-ed, but did not click submit just in case

jyellick (Sun, 03 Sep 2017 15:50:52 GMT):
@mastersingh24 +2-ed, but did not click submit just in case (ping me if you are ready for it and I can submit, or feel free to click in my proxy)

mastersingh24 (Sun, 03 Sep 2017 16:02:07 GMT):
We are good to go. This one just the doc and link but everything else is out there!

yacovm (Sun, 03 Sep 2017 16:03:40 GMT):
looks like It's trigger happy Sunday for me

yacovm (Sun, 03 Sep 2017 16:04:31 GMT):
All left now is the email right?

mastersingh24 (Sun, 03 Sep 2017 16:14:59 GMT):
I believe so

mastersingh24 (Sun, 03 Sep 2017 16:16:31 GMT):
Yep - all looks good ;)

rjones (Mon, 04 Sep 2017 06:13:27 GMT):
Has left the channel.

skarim (Tue, 05 Sep 2017 16:18:52 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/12611/ https://gerrit.hyperledger.org/r/#/c/12761/

mastersingh24 (Tue, 05 Sep 2017 19:29:52 GMT):
Can we get this one in: https://gerrit.hyperledger.org/r/#/c/12833/ ? Updates grpc-go to latest available version

rameshthoomu (Tue, 05 Sep 2017 21:32:41 GMT):
@mastersingh24 Need your review on this.. https://gerrit.hyperledger.org/r/#/c/13167/

jimthematrix (Wed, 06 Sep 2017 04:11:27 GMT):
https://gerrit.hyperledger.org/r/#/c/13159/ - node SDK 1.0.2 release (critical updates needed by the community)

jimthematrix (Wed, 06 Sep 2017 04:14:59 GMT):
https://gerrit.hyperledger.org/r/#/c/13169/ - fixing an integration test failure in 1.1

rameshthoomu (Wed, 06 Sep 2017 16:04:24 GMT):
Please review https://gerrit.hyperledger.org/r/#/c/13167/

mastersingh24 (Wed, 06 Sep 2017 17:03:31 GMT):
[need one more ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=QuvC2nWATMf93EZhj) @rameshthoomu

mastersingh24 (Wed, 06 Sep 2017 17:07:30 GMT):
Two oldies (just rebased them so waiting for CI): https://gerrit.hyperledger.org/r/9975 https://gerrit.hyperledger.org/r/9967 (just some additional test coverage added by Liam

yacovm (Wed, 06 Sep 2017 21:12:04 GMT):
https://gerrit.hyperledger.org/r/#/c/13179/ Unit test fix due to upgrade to go1.9

yacovm (Wed, 06 Sep 2017 21:12:04 GMT):
https://gerrit.hyperledger.org/r/#/c/13179/ Unit test fix due to upgrade to go1.9 ( I know this looks like it's production code, but the change set only affects tests)

C0rWin (Wed, 06 Sep 2017 21:19:55 GMT):
https://gerrit.hyperledger.org/r/#/c/13205/

greg.haskins (Thu, 07 Sep 2017 21:06:04 GMT):
@mastersingh24 could use some love on: https://gerrit.hyperledger.org/r/#/c/13219/ https://gerrit.hyperledger.org/r/#/c/13221/ to unblock @yacovm

greg.haskins (Thu, 07 Sep 2017 21:06:13 GMT):
if you would be so kind

yacovm (Thu, 07 Sep 2017 21:08:54 GMT):
I'm not really blocked, but I thought we are going to do this?

divyank (Thu, 07 Sep 2017 22:35:40 GMT):
Has joined the channel.

JonathanLevi (Fri, 08 Sep 2017 10:42:16 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=mjtM3X7RSBRgg2Gy4) Love is in the air...

muralisr (Fri, 08 Sep 2017 13:13:34 GMT):
a simple one https://gerrit.hyperledger.org/r/#/c/12873/ please ... basically a typo correction

lehors (Fri, 08 Sep 2017 13:14:48 GMT):
lehors

jimthematrix (Fri, 08 Sep 2017 16:18:05 GMT):
https://gerrit.hyperledger.org/r/#/c/13197/ - the followup CR for node SDK's 1.0.2 release (to update version string in master)

kostas (Sun, 10 Sep 2017 20:53:56 GMT):
https://gerrit.hyperledger.org/r/c/13305/ (a very simple one)

jiangyaoguo (Mon, 11 Sep 2017 01:08:15 GMT):
https://gerrit.hyperledger.org/r/#/c/9711/ - implement a TTL gc for chaincode container

dileban (Mon, 11 Sep 2017 04:50:23 GMT):
Has joined the channel.

dileban (Mon, 11 Sep 2017 04:54:33 GMT):
Noticed a few typos in the documentation as I was reading through and thought I'd fix these and submit them. I've read through the contribution material as well as the documentation README for fabric. Could someone comment on these before I do anything: - When I create an issue on Jira, do I need to wait for a maintainer to respond before I could submit the fix for the documentation? - Whom do I list as reviewers? I can find a list of maintainers but not reviewers, are these the same people and can I pick two randomly?

yacovm (Mon, 11 Sep 2017 06:44:39 GMT):
@dileban > - When I create an issue on Jira, do I need to wait for a maintainer to respond before I could submit the fix for the documentation? No. Worst case the change will get comments and you'll need to fix something. > - Whom do I list as reviewers? I can find a list of maintainers but not reviewers, are these the same people and can I pick two randomly? The reviewers are everyone you want to review your change set. It won't get merged without maintainer votes, and you don't have to add maintainers as reviewers, although that helps to make them notice your change set.

dileban (Mon, 11 Sep 2017 08:37:50 GMT):
Thansk @yacovm

mathiasb303 (Mon, 11 Sep 2017 09:09:21 GMT):
Has joined the channel.

jyellick (Mon, 11 Sep 2017 15:31:26 GMT):
https://gerrit.hyperledger.org/r/#/c/12533/2/common/viperutil/config_util.go@320 Some other opinions would be appreciated. In summary, we use moderately strict viper parsing today, but there is a sort of 'fuzzy' parsing that can be turned on for viper which does some nice conversions automatically (like converting bool values naturally), but it comes with some other esoteric behavior which might be less desirable. I'm on the fence about whether turning it on is a good idea or not

mastersingh24 (Mon, 11 Sep 2017 20:06:20 GMT):
https://gerrit.hyperledger.org/r/#/c/13303/ - Go 1.9 based builds ;)

wlahti (Mon, 11 Sep 2017 20:06:26 GMT):
I could use a few reviews for the following serviceability-related CRs whenever any maintainers have a chance: https://gerrit.hyperledger.org/r/#/c/12701/ https://gerrit.hyperledger.org/r/#/c/13245/ https://gerrit.hyperledger.org/r/#/c/13247/

lehors (Mon, 11 Sep 2017 20:37:45 GMT):
https://gerrit.hyperledger.org/r/#/c/12837/ this now has 2+2, anyone care to merge it? thanks

mastersingh24 (Tue, 12 Sep 2017 08:30:48 GMT):
@lehors - we also have to approve it's parent

lehors (Tue, 12 Sep 2017 09:10:02 GMT):
indeed! thanks :)

mastersingh24 (Tue, 12 Sep 2017 14:51:49 GMT):
Hi - I've been waiting for a little love: https://gerrit.hyperledger.org/r/#/c/13303/ Thanks, CR 13303

yacovm (Tue, 12 Sep 2017 14:53:10 GMT):
https://gerrit.hyperledger.org/r/#/c/13303/4/common/tools/configtxlator/sanitycheck/sanitycheck.go ?

yacovm (Tue, 12 Sep 2017 14:53:13 GMT):
@mastersingh24

JonathanLevi (Tue, 12 Sep 2017 15:52:28 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=pyRrPaGAZ4ok4AZvi) Love is all we need!

JonathanLevi (Tue, 12 Sep 2017 15:52:31 GMT):
Merged.

mastersingh24 (Tue, 12 Sep 2017 18:40:33 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/13343/

kostas (Tue, 12 Sep 2017 20:37:09 GMT):
A set of easy/straightforward changesets: https://gerrit.hyperledger.org/r/#/c/13305/ https://gerrit.hyperledger.org/r/#/c/13309/ https://gerrit.hyperledger.org/r/#/c/13311/ https://gerrit.hyperledger.org/r/#/c/13325/ https://gerrit.hyperledger.org/r/#/c/13307/ https://gerrit.hyperledger.org/r/#/c/13345/

wlahti (Tue, 12 Sep 2017 22:44:52 GMT):
First of a set of event-related CRs needing review: https://gerrit.hyperledger.org/r/#/c/13257/

dileban (Wed, 13 Sep 2017 03:11:09 GMT):
Improvement to documentation: https://gerrit.hyperledger.org/r/#/c/13391/ Quick newbie question: do I need to set the Jira issue status to 'In Review' or does the proper workflow require the reviewers to do this?

jyellick (Wed, 13 Sep 2017 03:36:16 GMT):
@dileban You should set the status to "In Review" yourself. The maintainer's should handle setting it to "Done" when merged.

dileban (Wed, 13 Sep 2017 04:09:06 GMT):
Thansk @jyellick. I also didn't specify a sprint for the issue on Jira because this would have impacted the time line (Even though I submitted a fix)

jyellick (Wed, 13 Sep 2017 04:24:33 GMT):
You should be good to ignore the sprint field, this won't have any negative affect.

jyellick (Wed, 13 Sep 2017 04:24:33 GMT):
You should be good to ignore the sprint field, this won't have any negative effect.

dileban (Wed, 13 Sep 2017 04:27:53 GMT):
Cool. One last question. Should I see a link from the Jira issue to the Gerrit changeset?

jyellick (Wed, 13 Sep 2017 04:35:27 GMT):
The link is only created on merge. To help those sorting through the JIRA issue's it's appreciated if you add a comment linking to the in review CR when you move the JIRA to "In Review".

jyellick (Wed, 13 Sep 2017 04:35:27 GMT):
The link is only created on merge. To help those sorting through the JIRA issues it's appreciated if you add a comment linking to the in review CR when you move the JIRA to "In Review".

jyellick (Wed, 13 Sep 2017 04:35:27 GMT):
The link is only created automatically on merge. To help those sorting through the JIRA issues it's appreciated if you add a comment linking to the in review CR when you move the JIRA status to "In Review".

lehors (Wed, 13 Sep 2017 12:22:01 GMT):
"Apologies, I was on holiday and returned to a cat 5 hurricane targeting my home here in FL so I am behind in my email and reviews." @cbf Pretty rock solid excuse I'd say, good luck to the other maintainers for matching that one! :-)

cbf (Wed, 13 Sep 2017 13:03:36 GMT):
;-)

mastersingh24 (Wed, 13 Sep 2017 13:35:41 GMT):
I hate Java?

mastersingh24 (Wed, 13 Sep 2017 13:35:51 GMT):
It pains me to look at it ;)

mastersingh24 (Wed, 13 Sep 2017 13:36:03 GMT):
I think that is pretty good as well

mastersingh24 (Wed, 13 Sep 2017 13:36:13 GMT):
I'll try to look at it if no one else does

cbf (Wed, 13 Sep 2017 13:38:47 GMT):
https://gerrit.hyperledger.org/r/c/11371/

cbf (Wed, 13 Sep 2017 13:39:04 GMT):
https://gerrit.hyperledger.org/r/c/11841/

skarim (Wed, 13 Sep 2017 13:50:34 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/13293/

muralisr (Wed, 13 Sep 2017 13:55:14 GMT):
merged https://gerrit.hyperledger.org/r/c/11371 @cbf

cbf (Wed, 13 Sep 2017 13:55:52 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=wt7gJBsNmbhdNfWKr) @muralisr thanks!

wlahti (Wed, 13 Sep 2017 15:34:57 GMT):
I could use a few reviews for the following serviceability-related CRs whenever any maintainers have a chance: https://gerrit.hyperledger.org/r/#/c/12701 https://gerrit.hyperledger.org/r/#/c/13245 https://gerrit.hyperledger.org/r/#/c/13247

grapebaba (Thu, 14 Sep 2017 01:52:09 GMT):
https://gerrit.hyperledger.org/r/#/c/13079/ need one more+2

baohua (Thu, 14 Sep 2017 02:28:20 GMT):
welcome to review: https://gerrit.hyperledger.org/r/#/c/12655/

baohua (Thu, 14 Sep 2017 02:31:47 GMT):
https://gerrit.hyperledger.org/r/#/c/13077/

lehors (Thu, 14 Sep 2017 15:19:32 GMT):
@smithbk @jyellick https://gerrit.hyperledger.org/r/#/c/12837/ rebased - thanks

jtclark (Thu, 14 Sep 2017 15:53:45 GMT):
https://gerrit.hyperledger.org/r/#/c/13343/ - plz review

divyank (Thu, 14 Sep 2017 16:23:04 GMT):
https://gerrit.hyperledger.org/r/#/c/13369/ and https://gerrit.hyperledger.org/r/#/c/13469/ These changes build fabric dynamically. This fixes an HSM integration bug and enables Go plugins.

jimthematrix (Thu, 14 Sep 2017 17:09:54 GMT):
https://gerrit.hyperledger.org/r/#/c/13451/ - upload TLS client key/cert to container during start, @greg.haskins @yacovm @mastersingh24

wlahti (Thu, 14 Sep 2017 17:53:42 GMT):
I have a few CRs needing review if any maintainers can spare some time: https://gerrit.hyperledger.org/r/#/c/13257 - event security fix to add timewindow https://gerrit.hyperledger.org/r/#/c/13441 - "peer channel list" should output to stdout - two line bug fix https://gerrit.hyperledger.org/r/#/c/13435 - update generated proto files after Go 1.9 upgrade and the below are serviceability CRs: https://gerrit.hyperledger.org/r/#/c/12701 https://gerrit.hyperledger.org/r/#/c/13245 https://gerrit.hyperledger.org/r/#/c/13247 https://gerrit.hyperledger.org/r/#/c/13425

wlahti (Thu, 14 Sep 2017 17:53:42 GMT):
I have a few CRs needing review if any maintainers can spare some time: https://gerrit.hyperledger.org/r/#/c/13257 - event security fix to add timewindow https://gerrit.hyperledger.org/r/#/c/13441 - "peer channel list" should output to stdout - two line bug fix https://gerrit.hyperledger.org/r/#/c/13435 - update generated proto files after Go 1.9 upgrade and the below are serviceability CRs that switch fmt.Errorf() errors to the new errors package: https://gerrit.hyperledger.org/r/#/c/12701 https://gerrit.hyperledger.org/r/#/c/13245 https://gerrit.hyperledger.org/r/#/c/13247 https://gerrit.hyperledger.org/r/#/c/13425

wlahti (Thu, 14 Sep 2017 17:53:42 GMT):
I have a few CRs needing review if any maintainers can spare some time: https://gerrit.hyperledger.org/r/#/c/13257 - event security fix to add timewindow https://gerrit.hyperledger.org/r/#/c/13441 - "peer channel list" should output to stdout - two line bug fix https://gerrit.hyperledger.org/r/#/c/13435 - update generated proto files after Go 1.9 upgrade and the below are serviceability CRs that switch fmt.Errorf() errors to the new errors package: ~https://gerrit.hyperledger.org/r/#/c/12701~ https://gerrit.hyperledger.org/r/#/c/13245 https://gerrit.hyperledger.org/r/#/c/13247 https://gerrit.hyperledger.org/r/#/c/13425

wlahti (Thu, 14 Sep 2017 17:53:42 GMT):
I have a few CRs needing review if any maintainers can spare some time: https://gerrit.hyperledger.org/r/#/c/13257 - event security fix to add timewindow https://gerrit.hyperledger.org/r/#/c/13441 - "peer channel list" should output to stdout - two line bug fix https://gerrit.hyperledger.org/r/#/c/13435 - update generated proto files after Go 1.9 upgrade https://gerrit.hyperledger.org/r/#/c/13471 - update only logging modules with prefix at peer start and the below are serviceability CRs that switch fmt.Errorf() errors to the new errors package: ~https://gerrit.hyperledger.org/r/#/c/12701~ ~https://gerrit.hyperledger.org/r/#/c/13245~ ~https://gerrit.hyperledger.org/r/#/c/13247~ https://gerrit.hyperledger.org/r/#/c/13425

aambati (Fri, 15 Sep 2017 18:04:51 GMT):
@mastersingh24 @jimthematrix @elli-androulaki Can u pls review https://gerrit.hyperledger.org/r/c/13265/ (Utility to get invoker info in chaincode)

bur (Fri, 15 Sep 2017 18:20:10 GMT):
Has joined the channel.

bur (Fri, 15 Sep 2017 18:22:50 GMT):
https://gerrit.hyperledger.org/r/#/c/13473/ - fix serialized identity pem format; please review

skarim (Fri, 15 Sep 2017 19:15:17 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/12611/ https://gerrit.hyperledger.org/r/#/c/12761/ https://gerrit.hyperledger.org/r/#/c/13293/

jimthematrix (Fri, 15 Sep 2017 21:19:32 GMT):
https://gerrit.hyperledger.org/r/#/c/13451/ - TLS client key/cert upload to CC container, needs one more +2 please

muralisr (Fri, 15 Sep 2017 22:47:35 GMT):
added a couple of small comments @jimthematrix

muralisr (Fri, 15 Sep 2017 22:49:13 GMT):
also @greg.haskins can you take a peek please (assume this was instigated your concern with the way TLS material was passed) ?

muralisr (Fri, 15 Sep 2017 22:49:13 GMT):
also @greg.haskins can you take a peek please (assume this was instigated by your concern with the way TLS material was passed) ?

greg.haskins (Fri, 15 Sep 2017 22:49:55 GMT):
ive been looking forward to this patch, will review asap

mastersingh24 (Sat, 16 Sep 2017 13:11:01 GMT):
easy doc fix: https://gerrit.hyperledger.org/r/#/c/13543/

mastersingh24 (Sat, 16 Sep 2017 15:30:45 GMT):
another easy one: https://gerrit.hyperledger.org/r/#/c/13549/ (ups the prereq versions forDocker and Docker Compose)

mastersingh24 (Sat, 16 Sep 2017 15:30:45 GMT):
another easy one: https://gerrit.hyperledger.org/r/#/c/13549/ (ups the prereq versions for Docker and Docker Compose)

jimthematrix (Sat, 16 Sep 2017 17:39:40 GMT):
https://gerrit.hyperledger.org/r/#/c/13451/ is ready for review and needs one more +2

smithbk (Sun, 17 Sep 2017 02:37:29 GMT):
These need one more +2

smithbk (Sun, 17 Sep 2017 02:37:33 GMT):
https://gerrit.hyperledger.org/r/#/c/12337/ https://gerrit.hyperledger.org/r/#/c/13501/ https://gerrit.hyperledger.org/r/#/c/13447/

kostas (Sun, 17 Sep 2017 15:12:35 GMT):
All of these are trivial to review: https://gerrit.hyperledger.org/r/#/c/13305/ https://gerrit.hyperledger.org/r/#/c/13531/ https://gerrit.hyperledger.org/r/#/c/13325/

mastersingh24 (Sun, 17 Sep 2017 23:34:02 GMT):
easy one (I hope): https://gerrit.hyperledger.org/r/#/c/13569/ (just updates Go, Docker, compose, node in the devenv)

mastersingh24 (Sun, 17 Sep 2017 23:36:07 GMT):
https://gerrit.hyperledger.org/r/#/c/13407/ - easy as well - vendor updated version of cfssl to support Go 1.9

dileban (Mon, 18 Sep 2017 04:47:25 GMT):
Documentation updates on submitting changes to Gerrit: https://gerrit.hyperledger.org/r/#/c/13573/

grapebaba (Mon, 18 Sep 2017 07:35:19 GMT):
https://gerrit.hyperledger.org/r/#/c/13079/ anyone can review this patch? I'd like to submit new patch based this code base

liuwenliang0632 (Mon, 18 Sep 2017 09:19:51 GMT):
Has joined the channel.

liuwenliang0632 (Mon, 18 Sep 2017 09:20:50 GMT):
plz help me review https://gerrit.hyperledger.org/r/#/c/13493

liuwenliang0632 (Mon, 18 Sep 2017 09:20:50 GMT):
plz help me review https://gerrit.hyperledger.org/r/#/c/13493, fixed [FAB-3243]

dileban (Mon, 18 Sep 2017 11:33:09 GMT):
Documentation fix: https://gerrit.hyperledger.org/r/#/c/13541/

smithbk (Mon, 18 Sep 2017 15:06:41 GMT):
https://gerrit.hyperledger.org/r/#/c/13447/ - Bug fix for intermediate TLS certs https://gerrit.hyperledger.org/r/#/c/12337/ - ABAC enhancement for 'fabric-ca-client register' command https://gerrit.hyperledger.org/r/#/c/13501/ - ABAC enhancement for 'fabric-ca-client enroll' command https://gerrit.hyperledger.org/r/#/c/12519/ - ABAC convenience function and documentation https://gerrit.hyperledger.org/r/#/c/13265/ - ABAC chaincode library https://gerrit.hyperledger.org/r/#/c/13195/ - Docker images bundling fabric-ca-client with orderer, peer, and tools

skarim (Mon, 18 Sep 2017 19:20:40 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/13481/

wlahti (Mon, 18 Sep 2017 19:29:00 GMT):
I have a few CRs ready for review if any maintainers can spare some time: https://gerrit.hyperledger.org/r/#/c/13257 - event security fix to add timewindow https://gerrit.hyperledger.org/r/#/c/13441 - "peer channel list" should output to stdout - two line bug fix https://gerrit.hyperledger.org/r/#/c/13471 - update only logging modules with prefix at peer start

C0rWin (Tue, 19 Sep 2017 06:22:19 GMT):
https://gerrit.hyperledger.org/r/#/c/13601/ - stops gossip state transfer test from failing in CI

C0rWin (Tue, 19 Sep 2017 06:22:19 GMT):
https://gerrit.hyperledger.org/r/#/c/13601/ - stops gossip state transfer test from failing in CI, need last +2

C0rWin (Tue, 19 Sep 2017 06:22:19 GMT):
https://gerrit.hyperledger.org/r/#/c/13601/ - stops gossip state transfer test from failing in CI, needs last +2

grapebaba (Tue, 19 Sep 2017 09:20:33 GMT):
https://gerrit.hyperledger.org/r/#/c/13079/

mastersingh24 (Tue, 19 Sep 2017 13:10:08 GMT):
A little love on this one: https://gerrit.hyperledger.org/r/#/c/13407/ ? @smithbk @JonathanLevi

mastersingh24 (Tue, 19 Sep 2017 16:49:09 GMT):
This little guy is ready again: https://gerrit.hyperledger.org/r/#/c/13589

wlahti (Tue, 19 Sep 2017 20:20:45 GMT):
I have a few CRs ready for review if any maintainers can spare some time: https://gerrit.hyperledger.org/r/#/c/13257 - event security fix to add timewindow https://gerrit.hyperledger.org/r/#/c/13441 - "peer channel list" should output to stdout - two line bug fix https://gerrit.hyperledger.org/r/#/c/13471 - update only logging modules with prefix at peer start

smithbk (Wed, 20 Sep 2017 00:45:59 GMT):
Could really use some help in reviewing some of these ... thanks:

smithbk (Wed, 20 Sep 2017 00:46:03 GMT):
https://gerrit.hyperledger.org/r/#/c/12337/ - Enhance fabric-ca-client register for ABAC (Attribute-Based Access Control) (needs another +2) https://gerrit.hyperledger.org/r/#/c/13501/ - Enhance fabric-ca-client enroll for ABAC (needs another +2) https://gerrit.hyperledger.org/r/#/c/13619/ - Simply vendoring attrmgr from fabric (easy one) https://gerrit.hyperledger.org/r/#/c/13615/ - Just some doc update for ABAC https://gerrit.hyperledger.org/r/#/c/13195/ - Just modified Makefile to build docker images for orderer, peer, and tools with fabric-ca-client https://gerrit.hyperledger.org/r/#/c/13265/ - Chaincode library for ABAC https://gerrit.hyperledger.org/r/#/c/13213/ - Adding a fabric-ca end-to-end sample to fabric-samples

smithbk (Wed, 20 Sep 2017 00:51:02 GMT):
One more ... https://gerrit.hyperledger.org/r/#/c/13623/ - Delete local attrmgr and use vendor'ed version (very easy)

Jacky_Sheng (Wed, 20 Sep 2017 03:21:36 GMT):
Has joined the channel.

wlahti (Wed, 20 Sep 2017 13:49:29 GMT):
Ready for review from maintainers (already has one +1 review from the security perspective): https://gerrit.hyperledger.org/r/#/c/13257 - event security fix to add timewindow

divyank (Wed, 20 Sep 2017 19:13:50 GMT):
https://gerrit.hyperledger.org/r/#/c/13369/ and https://gerrit.hyperledger.org/r/#/c/13469/ These changes build fabric dynamically. This fixes an HSM integration issue and enables Go plugins. Discussion on FAB-6161

dileban (Thu, 21 Sep 2017 05:32:02 GMT):
Documentation fix: https://gerrit.hyperledger.org/r/13667

wlahti (Thu, 21 Sep 2017 12:15:16 GMT):
Easy CR that allows the block listener sample to work with TLS enabled: https://gerrit.hyperledger.org/r/#/c/11237/

wlahti (Thu, 21 Sep 2017 12:15:16 GMT):
Easy CR that allows the block listener sample to work with TLS enabled: https://gerrit.hyperledger.org/r/#/c/11237/ - just needs one more +2

muralisr (Thu, 21 Sep 2017 15:50:37 GMT):
a simple fix to samples to help so behave tests to work https://gerrit.hyperledger.org/r/#/c/13665/ please

kostas (Thu, 21 Sep 2017 21:34:28 GMT):
https://gerrit.hyperledger.org/r/#/c/13305/ https://gerrit.hyperledger.org/r/#/c/13325/

dileban (Fri, 22 Sep 2017 00:29:45 GMT):
https://gerrit.hyperledger.org/r/#/c/13573/ (cc @kostas)

smithbk (Fri, 22 Sep 2017 12:17:40 GMT):
Pls help with review of following:

smithbk (Fri, 22 Sep 2017 12:17:41 GMT):
https://gerrit.hyperledger.org/r/#/c/13195/ - Modified Makefile to build new docker images for orderer, peer, and tools with fabric-ca-client - @greg.haskins? https://gerrit.hyperledger.org/r/#/c/13265/ - Chaincode library for ABAC https://gerrit.hyperledger.org/r/#/c/13213/ - Adding a fabric-ca end-to-end sample to fabric-samples

jimthematrix (Fri, 22 Sep 2017 12:33:08 GMT):
https://gerrit.hyperledger.org/r/#/c/13721/ - adding python 2.7 (and linking to 'python' command) so fabric-ccenv can perform grpc post-install build during npm install for node.js chaincode.

jimthematrix (Fri, 22 Sep 2017 12:33:46 GMT):
@davidkel ^^^

jimthematrix (Fri, 22 Sep 2017 12:39:28 GMT):
@mastersingh24 I see you have https://gerrit.hyperledger.org/r/#/c/13335/ pending, I guess we could either merge it first then have 13721 rebased, or merge 13721 directly (keeping IS_RELEASE=true) so 0.4.2 gets published with the python change, then change 13335 to "prepare for 0.4.3 development". your call which way to go?

jpatchell (Fri, 22 Sep 2017 13:10:55 GMT):
https://gerrit.hyperledger.org/r/#/c/13019/ - BCCSP PKCS11 CKA_LABEL set to SKI

yacovm (Fri, 22 Sep 2017 18:29:21 GMT):
Critical bug fix https://gerrit.hyperledger.org/r/#/c/13715/

mastersingh24 (Sat, 23 Sep 2017 13:09:38 GMT):
Pretty easy one if you believe that it works (which it does): https://gerrit.hyperledger.org/r/c/13569/

muralisr (Sat, 23 Sep 2017 14:08:21 GMT):
I'll believe it works @mastersingh24 :-)

muralisr (Sat, 23 Sep 2017 14:09:07 GMT):
this is a simple one too https://gerrit.hyperledger.org/r/#/c/13665

mastersingh24 (Sat, 23 Sep 2017 14:10:20 GMT):
@muralisr - Have you completed your brainwashing (I mean on-boarding) at your new employer?

muralisr (Sat, 23 Sep 2017 14:10:56 GMT):
:-) ...that assumes some brains (thanks for that :-) )

yacovm (Sun, 24 Sep 2017 07:58:21 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/13717/

yacovm (Sun, 24 Sep 2017 07:58:21 GMT):
~ Easy one https://gerrit.hyperledger.org/r/#/c/13717/ ~ Thanks @muralisr

yacovm (Sun, 24 Sep 2017 08:04:44 GMT):
Easy but important bug fix: https://gerrit.hyperledger.org/r/#/c/13763/

yacovm (Sun, 24 Sep 2017 08:04:44 GMT):
~ Easy but important bug fix: https://gerrit.hyperledger.org/r/#/c/13763/ ~ Thanks @mastersingh24

smithbk (Sun, 24 Sep 2017 15:57:34 GMT):
https://gerrit.hyperledger.org/r/#/c/13195/ - Modified Makefile to build new docker images for orderer, peer, and tools with fabric-ca-client https://gerrit.hyperledger.org/r/#/c/13265/ - Chaincode library for ABAC https://gerrit.hyperledger.org/r/#/c/13213/ - Adding a fabric-ca end-to-end sample to fabric-samples https://gerrit.hyperledger.org/r/#/c/13773/ - Simple doc update to troubleshooting section of fabric-ca readthedocs

dileban (Mon, 25 Sep 2017 00:26:23 GMT):
Easy documentation fix: https://gerrit.hyperledger.org/r/13777

lehors (Mon, 25 Sep 2017 09:27:05 GMT):
https://gerrit.hyperledger.org/r/c/11639/ needs just a bit more love

lehors (Mon, 25 Sep 2017 09:27:50 GMT):
@mastersingh24 Gari? :-)

JonathanLevi (Mon, 25 Sep 2017 09:38:23 GMT):
Hi @lehors

lehors (Mon, 25 Sep 2017 09:38:40 GMT):
hi!

JonathanLevi (Mon, 25 Sep 2017 09:38:48 GMT):
https://gerrit.hyperledger.org/r/#/c/11639/13/lib/server.go

JonathanLevi (Mon, 25 Sep 2017 09:39:37 GMT):
Just to check, with the new implementation, do you prefer to call *err2 := s.closeDB()* even in case you already have an *err* ?

lehors (Mon, 25 Sep 2017 09:40:33 GMT):
yes, because I want to return err - the original error

lehors (Mon, 25 Sep 2017 09:41:15 GMT):
that's the root cause the user would primarily want to be aware off

lehors (Mon, 25 Sep 2017 09:41:48 GMT):
if there is also an error while closing the db it's secondary

JonathanLevi (Mon, 25 Sep 2017 09:43:10 GMT):
The issue with doing something like... *err = s.init(renew)* *if err !=nil* { err2 := s.closeDB() if err2!=nil { log. } ... return err; }

JonathanLevi (Mon, 25 Sep 2017 09:43:42 GMT):
Is that you'd still want to call *s.closeDB()* in case of an error, right?

JonathanLevi (Mon, 25 Sep 2017 09:43:42 GMT):
Is that you'd still want to call *s.closeDB()* in case of an error (*err*), right?

JonathanLevi (Mon, 25 Sep 2017 09:43:42 GMT):
Is that you'd still want to call *s.closeDB()* in case of an error ( *err* ), right?

lehors (Mon, 25 Sep 2017 09:44:05 GMT):
that's what it does

JonathanLevi (Mon, 25 Sep 2017 09:44:14 GMT):
Yup, cool. Just checking.

JonathanLevi (Mon, 25 Sep 2017 09:44:14 GMT):
Yup, cool. Thanks for confirming.

JonathanLevi (Mon, 25 Sep 2017 09:45:19 GMT):
Thank you. Merged.

yacovm (Mon, 25 Sep 2017 09:51:21 GMT):
https://gerrit.hyperledger.org/r/#/c/13769/ needs 1 more +2 any volunteers? :)

yacovm (Mon, 25 Sep 2017 09:51:21 GMT):
https://gerrit.hyperledger.org/r/#/c/13769/ needs 1 more +2 any volunteers? :) Not too hard to CR

yacovm (Mon, 25 Sep 2017 09:51:21 GMT):
~ https://gerrit.hyperledger.org/r/#/c/13769/ needs 1 more +2 any volunteers? :) ~ ~ Not too hard to CR ~ thanks @mastersingh24

wlahti (Mon, 25 Sep 2017 15:11:56 GMT):
A few simple serviceability CRs for review... I forgot to change the format verbs to %+v so they stack trace would be printed: https://gerrit.hyperledger.org/r/#/c/13679/ https://gerrit.hyperledger.org/r/#/c/13685/ https://gerrit.hyperledger.org/r/#/c/13693/

jimthematrix (Mon, 25 Sep 2017 15:28:42 GMT):
https://gerrit.hyperledger.org/r/#/c/13789/ - to pick up the new fabric-baseimage version (0.4.2)

smithbk (Tue, 26 Sep 2017 12:57:33 GMT):
https://gerrit.hyperledger.org/r/#/c/13195/ - Modified Makefile to build new docker images for orderer, peer, and tools with fabric-ca-client https://gerrit.hyperledger.org/r/#/c/13265/ - Chaincode library for ABAC (one more +2) https://gerrit.hyperledger.org/r/#/c/13213/ - Adding fabric-samples/fabric-ca sample https://gerrit.hyperledger.org/r/#/c/13773/ - Simple doc update to troubleshooting section of fabric-ca readthedocs

cbf (Tue, 26 Sep 2017 14:53:35 GMT):
https://gerrit.hyperledger.org/r/c/12995

divyank (Tue, 26 Sep 2017 16:38:15 GMT):
https://gerrit.hyperledger.org/r/#/c/13839/ completes the grpc-go upgrade to v1.5.2

yacovm (Tue, 26 Sep 2017 16:41:32 GMT):
SideDB item. https://gerrit.hyperledger.org/r/#/c/13771/ Has already 1 +2 Most of it is UT code, pretty straight forward to CR IMO

cbf (Tue, 26 Sep 2017 20:46:43 GMT):
https://gerrit.hyperledger.org/r/#/c/12995 if you are using the old Gerrit UI

jimthematrix (Tue, 26 Sep 2017 21:13:56 GMT):
https://gerrit.hyperledger.org/r/#/c/13789/ - trivial update to pick up the latest fabric-baseimage (0.4.2)

yacovm (Wed, 27 Sep 2017 12:28:27 GMT):
2 sideDB items, missing 1 +2 each. https://gerrit.hyperledger.org/r/#/c/13771/ easy one https://gerrit.hyperledger.org/r/#/c/13821/ less easy but it has lots of items based on top of it so we need to get this in ;)

smithbk (Wed, 27 Sep 2017 12:28:56 GMT):
https://gerrit.hyperledger.org/r/#/c/13265/ - Chaincode library for Attribute-Based Access Control (needs one more +2) https://gerrit.hyperledger.org/r/#/c/13213/ - Adding fabric-samples/fabric-ca sample https://gerrit.hyperledger.org/r/#/c/13773/ - Simple doc update to troubleshooting section of fabric-ca readthedocs

aambati (Wed, 27 Sep 2017 14:18:02 GMT):
@mastersingh24 Hi Gari, i have addressed your comment in https://gerrit.hyperledger.org/r/c/13707/ , pls rereview when you get a chance...thank you

skarim (Wed, 27 Sep 2017 14:19:50 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/13215/

divyank (Wed, 27 Sep 2017 14:23:48 GMT):
Updated https://gerrit.hyperledger.org/r/#/c/13369/ to make dynamic builds configurable as per @mastersingh24 's suggestion

JonathanLevi (Wed, 27 Sep 2017 16:46:03 GMT):
Some love here, please: https://gerrit.hyperledger.org/r/#/c/13865/

JonathanLevi (Wed, 27 Sep 2017 16:46:34 GMT):
It's a pretty critical fix (for https://jira.hyperledger.org/browse/FAB-6294)

aleksandar.likic (Wed, 27 Sep 2017 22:46:16 GMT):
https://gerrit.hyperledger.org/r/#/c/13851/ (https://jira.hyperledger.org/browse/FAB-6317) Split the peer into the server and the client part. The peer binary is still the server, and all client functions have been moved into the new fabriccli binary. This change enables having different build strategies for the server and the client (for example dynamic vs static build, which is important for things like go plugin and PKCS11 support). Also, this change is (hopefully) a step towards refactoring the fabric code so the fabric client protos and supporting libraries are detached from the server code. This way, the client API could be used by fabriccli and Go SDK (and potentially other Go based fabric client software) without having to depend on the whole fabric that includes the server code. Please propose another name for the fabric client binary if you don't find fabriccli suitable.

aleksandar.likic (Wed, 27 Sep 2017 22:46:16 GMT):
https://gerrit.hyperledger.org/r/#/c/13851/ (https://jira.hyperledger.org/browse/FAB-6317) Split the peer into the server and the client part. The peer binary is still the server, and all client functions have been moved into the new fabriccli binary. This change enables having different build strategies for the server and the client (for example dynamic vs static build, which is important for things like go plugin and PKCS11 support). Also, this change is (hopefully) a step towards refactoring the fabric code so the fabric client protos and supporting libraries are decoupled from the server code. This way, the client API could be used by fabriccli and Go SDK (and potentially other Go based fabric client software) without having to depend on the whole fabric that includes the server code. Please propose another name for the fabric client binary if you don't find fabriccli suitable.

aleksandar.likic (Wed, 27 Sep 2017 22:46:16 GMT):
https://gerrit.hyperledger.org/r/#/c/13851/ (https://jira.hyperledger.org/browse/FAB-6317) Split the peer into the server and the client part. The peer binary is still the server, and all client functions have been moved into the new fabriccli binary. This change enables having different build strategies for the server and the client (for example dynamic vs static build, which is important for things like support for go plugins and PKCS11). Also, this change is (hopefully) a step towards refactoring the fabric code so the fabric client protos and supporting libraries are decoupled from the server code. This way, the client API could be used by fabriccli and Go SDK (and potentially other Go based fabric client software) without having to depend on the whole fabric that includes the server code. Please propose another name for the fabric client binary if you don't find fabriccli suitable.

muralisr (Thu, 28 Sep 2017 00:17:49 GMT):
@aleksandar.likic this is something that has been talked about for a while .. the separation will also reduce confusion due to `peer` doubling as CLI . One thing, FAB-6317 would need the "review-needed" tag though to get votes, right @cbf @mastersingh24 ?

aleksandar.likic (Thu, 28 Sep 2017 00:20:39 GMT):
@muralisr Tagged with "review-needed".

bur (Thu, 28 Sep 2017 08:20:35 GMT):
@here https://jira.hyperledger.org/browse/FAB-6325 Please have a look at this

bur (Thu, 28 Sep 2017 08:44:47 GMT):
@here https://gerrit.hyperledger.org/r/#/c/13473/ Please also share your thoughts about this; I guess more discussion needed here; please have a look

yacovm (Thu, 28 Sep 2017 08:45:13 GMT):
Please stop using the @ here macro...

yacovm (Thu, 28 Sep 2017 08:47:09 GMT):
@bur I think the change set of the PEM type makes sense, but a consensus on that from @elli-androulaki @adc and @aso would be nice to have.

bur (Thu, 28 Sep 2017 08:50:42 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=WZqe4GD3Xd8EaQL5d) @yacovm True, the major concern is breaking compatibility; maybe someone else can comment on that concern?!

yacovm (Thu, 28 Sep 2017 08:51:54 GMT):
It would be nice to see how this behaves in a mixed environment of peers of different versions

yacovm (Thu, 28 Sep 2017 08:52:26 GMT):
or, one with mixed peers - ones with this patch, and ones without the patch

yacovm (Thu, 28 Sep 2017 08:52:42 GMT):
Do you want to test that?

bur (Thu, 28 Sep 2017 09:04:05 GMT):
yes, I can try set this up

yacovm (Thu, 28 Sep 2017 09:16:59 GMT):
You can use https://github.com/yacovm/fabricDeployment - I think it would fit very well to do this.

yacovm (Thu, 28 Sep 2017 09:16:59 GMT):
@bur you can use https://github.com/yacovm/fabricDeployment - I think it would fit very well to do this.

kostas (Thu, 28 Sep 2017 14:13:57 GMT):
This one's missing a +2: https://gerrit.hyperledger.org/r/#/c/13325/

dave.enyeart (Thu, 28 Sep 2017 20:37:08 GMT):
@muralisr I assume you have most context for the filtered event / event service CRs, but we could use other's review as well:

dave.enyeart (Thu, 28 Sep 2017 20:37:10 GMT):
https://gerrit.hyperledger.org/r/#/c/12115/ filtered block event - FAB-5481 https://gerrit.hyperledger.org/r/#/c/12375/ server https://gerrit.hyperledger.org/r/#/c/12377/ client https://gerrit.hyperledger.org/r/#/c/12379/ UT https://gerrit.hyperledger.org/r/#/c/12381/ channel service sample https://gerrit.hyperledger.org/r/#/c/12483/ add signedevent to rscc https://gerrit.hyperledger.org/r/#/c/13663 - add signedevent to default acl provider https://gerrit.hyperledger.org/r/#/c/12609 - implement ACL on Channel Service https://gerrit.hyperledger.org/r/#/c/13001 - channel service listener sample TLS

mastersingh24 (Fri, 29 Sep 2017 10:48:25 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/13335/ @greg.haskins ? ;)

greg.haskins (Fri, 29 Sep 2017 12:03:55 GMT):
@mastersingh24 whoa, what happened? heh

greg.haskins (Fri, 29 Sep 2017 12:04:35 GMT):
the merged commit log is confusing

greg.haskins (Fri, 29 Sep 2017 12:04:58 GMT):
did v0.4.2 get released?

greg.haskins (Fri, 29 Sep 2017 12:06:07 GMT):
ah, this seems to be the culprit: https://github.com/hyperledger/fabric-baseimage/commit/6af7f3e0f33051d96388258681bf90f20721b91c

greg.haskins (Fri, 29 Sep 2017 12:09:47 GMT):
generally speaking, I don't recommend merging release version bumps in the same CR as a logic change...

mastersingh24 (Fri, 29 Sep 2017 12:18:57 GMT):
@greg.haskins - I know, I know. We did a no-no :(

mastersingh24 (Fri, 29 Sep 2017 12:19:23 GMT):
but we were on a roll is my only defense

greg.haskins (Fri, 29 Sep 2017 12:19:40 GMT):
sure thing, merged

elli-androulaki (Fri, 29 Sep 2017 12:47:10 GMT):
Hi, all! May another pair of eyes take a look at this one please please? https://gerrit.hyperledger.org/r/#/c/13739/

aleksandar.likic (Fri, 29 Sep 2017 14:23:27 GMT):
Very easy one (I hope): https://gerrit.hyperledger.org/r/#/c/13965/ - Now that we can configure fabric to compile chaincodes dynamically (FAB-6192), let chaincode authors bundle go plugins with their chaincode.

aleksandar.likic (Fri, 29 Sep 2017 14:23:27 GMT):
Very easy one (I hope): https://gerrit.hyperledger.org/r/#/c/13965/ (FAB-6346) - Now that we can configure fabric to compile chaincodes dynamically (FAB-6192), let chaincode authors bundle go plugins with their chaincode.

jimthematrix (Fri, 29 Sep 2017 20:24:29 GMT):
https://gerrit.hyperledger.org/r/#/c/13907/ - trivial change for node.js chaincode support https://gerrit.hyperledger.org/r/#/c/13945/ - node SDK support for using .npmignore to allow chaincode developers total control of code packaging

grapebaba (Sat, 30 Sep 2017 02:25:05 GMT):
https://gerrit.hyperledger.org/r/#/c/13079/ - metrics support prometheus reporter

baohua (Sat, 30 Sep 2017 06:49:31 GMT):
Stay for quite a while, need another +2, thanks!https://gerrit.hyperledger.org/r/12693

yacovm (Sat, 30 Sep 2017 10:30:48 GMT):
@muralisr ^

yacovm (Sat, 30 Sep 2017 10:41:20 GMT):
Easy doc change https://gerrit.hyperledger.org/r/#/c/13975/ courtesy of @Amjadnz

Amjadnz (Sat, 30 Sep 2017 10:41:20 GMT):
Has joined the channel.

yacovm (Sat, 30 Sep 2017 11:03:51 GMT):
Also an easy (4 lines!) log formatting fix https://gerrit.hyperledger.org/r/#/c/13987/

mastersingh24 (Sat, 30 Sep 2017 12:23:22 GMT):
even easier one: https://gerrit.hyperledger.org/r/#/c/12961/

mastersingh24 (Sat, 30 Sep 2017 12:27:13 GMT):
this one too: https://gerrit.hyperledger.org/r/#/c/13163/

mastersingh24 (Sat, 30 Sep 2017 12:34:31 GMT):
2 more fairly easy ones: https://gerrit.hyperledger.org/r/14003 https://gerrit.hyperledger.org/r/14005

mastersingh24 (Sun, 01 Oct 2017 10:44:38 GMT):
Can we get one more pair of eyes on https://gerrit.hyperledger.org/r/#/c/13079/ ? @grapebaba has been asking for a while now

mastersingh24 (Sun, 01 Oct 2017 12:09:13 GMT):
Easy doc update: https://gerrit.hyperledger.org/r/#/c/13383/

mastersingh24 (Sun, 01 Oct 2017 12:30:54 GMT):
This one as well: https://gerrit.hyperledger.org/r/#/c/13957/ ;)

grapebaba (Mon, 02 Oct 2017 01:46:16 GMT):
@mastersingh24 @C0rWin thanks, will fix after vacation

elli-androulaki (Mon, 02 Oct 2017 07:56:41 GMT):
Hi, additional pairs of eyes to take a look at these (RSCC policies integration to SCCs)? @yacovm has already +2ed all of them. https://gerrit.hyperledger.org/r/#/c/12343/ https://gerrit.hyperledger.org/r/#/c/12347/ https://gerrit.hyperledger.org/r/#/c/12345/

elli-androulaki (Mon, 02 Oct 2017 07:56:41 GMT):
Hi, additional pairs of eyes to take a look at these (RSCC policies integration to SCCs)? @yacovm has already +2ed all of them. Thanks! https://gerrit.hyperledger.org/r/#/c/12343/ https://gerrit.hyperledger.org/r/#/c/12347/ https://gerrit.hyperledger.org/r/#/c/12345/

yacovm (Mon, 02 Oct 2017 07:58:18 GMT):
You missed https://gerrit.hyperledger.org/r/#/c/12399/ @elli-androulaki

elli-androulaki (Mon, 02 Oct 2017 07:58:47 GMT):
Thanks @yacovm, indeed!

mastersingh24 (Mon, 02 Oct 2017 10:23:55 GMT):
easy one (I hope): https://gerrit.hyperledger.org/r/#/c/13783/

skarim (Mon, 02 Oct 2017 14:11:07 GMT):
please review: https://gerrit.hyperledger.org/r/#/c/13215/

mastersingh24 (Mon, 02 Oct 2017 18:43:40 GMT):
Can we get some quick eyes on https://gerrit.hyperledger.org/r/#/c/14041/ It's a backport of a fix to the release branch (so we can include it in v1.0.3)

yacovm (Mon, 02 Oct 2017 19:24:16 GMT):
@c0

yacovm (Mon, 02 Oct 2017 19:24:34 GMT):
@C0rWin ^

jimthematrix (Mon, 02 Oct 2017 20:07:12 GMT):
https://gerrit.hyperledger.org/r/#/c/14083/ - trivial change in node.js chaincode docker build command

wlahti (Mon, 02 Oct 2017 21:54:39 GMT):
A few simple CRs for review: https://gerrit.hyperledger.org/r/#/c/13685/ - print stack trace in core/chaincode logging messages https://gerrit.hyperledger.org/r/#/c/13693/ - print stack trace in shim logging messages https://gerrit.hyperledger.org/r/#/c/14055/ - update error handling documentation now that we're using the vendored github.com/pkg/errors package

yacovm (Tue, 03 Oct 2017 08:54:40 GMT):
Trivial doc change https://gerrit.hyperledger.org/r/#/c/14113/

mastersingh24 (Tue, 03 Oct 2017 11:24:12 GMT):
fabric and fabric-ca 1.0.3: https://gerrit.hyperledger.org/r/#/q/status:open+branch:release+topic:release-1.0.3

mastersingh24 (Tue, 03 Oct 2017 11:25:10 GMT):
An easy one: https://gerrit.hyperledger.org/r/#/c/14035/ (this is a prereq to being able to support both Go 1.7 and Go 1.9 in CI)

mastersingh24 (Tue, 03 Oct 2017 12:32:10 GMT):
Need 1 +2 for this guy: https://gerrit.hyperledger.org/r/#/c/14129/

lovesh (Tue, 03 Oct 2017 14:11:04 GMT):
Has joined the channel.

mastersingh24 (Tue, 03 Oct 2017 14:57:13 GMT):
https://gerrit.hyperledger.org/r/#/q/FAB-6366 - these are prereqs for https://gerrit.hyperledger.org/r/#/c/14145/ so would appreciate a pair of (hopefully) quick reviews. Assuming all goes well with the CI changes, people will need to rebase and include this change, so the sooner we get it in the better

jyellick (Tue, 03 Oct 2017 17:48:54 GMT):
https://gerrit.hyperledger.org/r/#/c/13281/ Needs one more +2

mastersingh24 (Tue, 03 Oct 2017 20:13:19 GMT):
There little guys stepped out for lunch but they'd appreciate some love now: https://gerrit.hyperledger.org/r/#/q/fab-6366

mastersingh24 (Tue, 03 Oct 2017 20:47:11 GMT):
https://gerrit.hyperledger.org/r/#/c/14001/ - nice use of the experimental tag for Java chaincode

yacovm (Wed, 04 Oct 2017 06:56:01 GMT):
https://gerrit.hyperledger.org/r/#/c/14101/ needs 1 more +2 and is blocking my https://gerrit.hyperledger.org/r/#/c/14037/ to being reviewed / merged

yacovm (Wed, 04 Oct 2017 06:56:01 GMT):
~ https://gerrit.hyperledger.org/r/#/c/14101/ needs 1 more +2 and is blocking my https://gerrit.hyperledger.org/r/#/c/14037/ to being reviewed / merged ~ thanks @JonathanLevi !

C0rWin (Wed, 04 Oct 2017 07:04:54 GMT):
https://gerrit.hyperledger.org/r/#/c/14101/ side db related, requires last +2, really appreciated

JonathanLevi (Wed, 04 Oct 2017 07:11:28 GMT):
Merged.

sstone1 (Wed, 04 Oct 2017 07:31:07 GMT):
Has left the channel.

adc (Wed, 04 Oct 2017 08:14:17 GMT):
Hi All, please, some love to https://gerrit.hyperledger.org/r/#/c/13917/ @jyellick, any feedback on that?

mastersingh24 (Wed, 04 Oct 2017 10:48:36 GMT):
Here's the final / final CRs for the v1.0.3 release: https://gerrit.hyperledger.org/r/14187 (we still do stuff out of master - updates the docs, release notes and bootstrap in master) https://gerrit.hyperledger.org/r/14181 (merges master into release for fabric-samples) https://gerrit.hyperledger.org/r/14183 (copies release notes into master for fabric-ca - I missed this for v1.0.1 and v1.02 so included here as well)

mastersingh24 (Wed, 04 Oct 2017 10:49:32 GMT):
And then we are ready to rock and roll. The Docker images have already been published to Dockerhub. I also ran fabcar and first network samples successfully

mastersingh24 (Wed, 04 Oct 2017 10:50:16 GMT):
Also - https://gerrit.hyperledger.org/r/#/q/fab-6366 - pretty please (thx @jyellick )

mastersingh24 (Wed, 04 Oct 2017 11:02:10 GMT):
@adc - not sure it is quite the love you are looking for, but added a few comments ;) (https://chat.hyperledger.org/channel/fabric-pr-review?msg=LqFa2RYxsTAhD7ang)

smithbk (Wed, 04 Oct 2017 14:36:10 GMT):
https://gerrit.hyperledger.org/r/#/c/13265/ @mastersingh pls

smithbk (Wed, 04 Oct 2017 14:36:10 GMT):
https://gerrit.hyperledger.org/r/#/c/13265/ @mastersingh24 pls

JonathanLevi (Wed, 04 Oct 2017 20:52:48 GMT):
@mastersingh24 : https://gerrit.hyperledger.org/r/#/c/13845/

gujingxiao (Thu, 05 Oct 2017 05:59:50 GMT):
Has joined the channel.

gujingxiao (Thu, 05 Oct 2017 06:21:17 GMT):
https://gerrit.hyperledger.org/r/#/c/14001/ needs to be reviewed:grin:

wlahti (Thu, 05 Oct 2017 12:32:34 GMT):
A few simple CRs awaiting review: https://gerrit.hyperledger.org/r/#/c/13685 - print stack trace in core/chaincode logging messages https://gerrit.hyperledger.org/r/#/c/13693 - print stack trace in shim logging messages https://gerrit.hyperledger.org/r/#/c/14055 - update error handling documentation now that we're using the vendored github.com/pkg/errors package Also, this CR to mitigate relay attacks during event registration: https://gerrit.hyperledger.org/r/#/c/13257/

wlahti (Thu, 05 Oct 2017 12:32:34 GMT):
A few simple CRs awaiting review: _https://gerrit.hyperledger.org/r/#/c/13685 - print stack trace in core/chaincode logging messages_ _https://gerrit.hyperledger.org/r/#/c/13693 - print stack trace in shim logging messages_ https://gerrit.hyperledger.org/r/#/c/14055 - update error handling documentation now that we're using the vendored github.com/pkg/errors package Also, this CR to mitigate relay attacks during event registration: https://gerrit.hyperledger.org/r/#/c/13257/

wlahti (Thu, 05 Oct 2017 12:32:34 GMT):
A few simple CRs awaiting review: ~https://gerrit.hyperledger.org/r/#/c/13685 - print stack trace in core/chaincode logging messages~ ~https://gerrit.hyperledger.org/r/#/c/13693 - print stack trace in shim logging messages~ https://gerrit.hyperledger.org/r/#/c/14055 - update error handling documentation now that we're using the vendored github.com/pkg/errors package Also, this CR to mitigate relay attacks during event registration: https://gerrit.hyperledger.org/r/#/c/13257/

joe-alewine (Thu, 05 Oct 2017 17:44:51 GMT):
https://gerrit.hyperledger.org/r/c/14235/ Added literally *two spaces* to the WYFA doc.

joe-alewine (Thu, 05 Oct 2017 17:44:51 GMT):
https://gerrit.hyperledger.org/r/c/14235/ Added literally *two spaces* to the WYFA doc to fix a formatting mistake.

divyank (Thu, 05 Oct 2017 19:34:38 GMT):
https://gerrit.hyperledger.org/r/c/14091/ Enables pluggable endorser filters using Go plugins

grapebaba (Fri, 06 Oct 2017 12:11:10 GMT):
https://gerrit.hyperledger.org/r/#/c/13079/ @mastersingh24 @C0rWin

aambati (Fri, 06 Oct 2017 14:32:06 GMT):
@mastersingh24 pls re-review https://gerrit.hyperledger.org/r/c/13583/ (Add support to generate CR) when you get a chance...I welcome other reviewers to do the same..thank you

smithbk (Sun, 08 Oct 2017 00:27:04 GMT):
Pls review https://gerrit.hyperledger.org/r/#/c/13213/ - fabric-ca sample ... thanks

smithbk (Sun, 08 Oct 2017 21:14:10 GMT):
A very small change which fixes CI, needs one more +2: https://gerrit.hyperledger.org/r/#/c/14289/

smithbk (Sun, 08 Oct 2017 21:14:10 GMT):
A very small change which fixes fabric-ca CI, needs one more +2: https://gerrit.hyperledger.org/r/#/c/14289/

yacovm (Mon, 09 Oct 2017 13:13:18 GMT):
Side DB items ripe for merging @mastersingh24 @dave.enyeart https://gerrit.hyperledger.org/r/#/c/14301/ https://gerrit.hyperledger.org/r/#/c/14307/ https://gerrit.hyperledger.org/r/#/c/14319/

jyellick (Mon, 09 Oct 2017 15:06:14 GMT):
https://gerrit.hyperledger.org/r/#/c/13393/ https://gerrit.hyperledger.org/r/#/c/13395/ https://gerrit.hyperledger.org/r/#/c/13397/ https://gerrit.hyperledger.org/r/#/c/13399/ https://gerrit.hyperledger.org/r/#/c/13401/ https://gerrit.hyperledger.org/r/#/c/13403/ All need one additional +2, very simple straightforward code refactoring/simplification

jyellick (Mon, 09 Oct 2017 15:06:14 GMT):
~https://gerrit.hyperledger.org/r/#/c/13393/~ ~https://gerrit.hyperledger.org/r/#/c/13395/~ https://gerrit.hyperledger.org/r/#/c/13397/ https://gerrit.hyperledger.org/r/#/c/13399/ https://gerrit.hyperledger.org/r/#/c/13401/ https://gerrit.hyperledger.org/r/#/c/13403/ All need one additional +2, very simple straightforward code refactoring/simplification

yacovm (Mon, 09 Oct 2017 20:26:15 GMT):
@mastersingh24 shall we merge https://gerrit.hyperledger.org/r/#/c/12849/ ? @muralisr you also commented there... want to take a look?

muralisr (Mon, 09 Oct 2017 20:28:20 GMT):
yes @yacovm I'm ok with it... I initially had some concerns with it based on some primitive investigations with goroutines but have convinced myself that limiting the goroutines in a CPU intensive env is the right way to go about it (thanks to @aso and others for the patience!)

muralisr (Mon, 09 Oct 2017 20:32:06 GMT):
want to take a peek at it @greg.haskins now that its rewritten to get rid of workers ?

greg.haskins (Mon, 09 Oct 2017 20:32:38 GMT):
_looks_

smithbk (Mon, 09 Oct 2017 20:48:02 GMT):
just a vendor update ... needs another +2 pls https://gerrit.hyperledger.org/r/#/c/14239/

grapebaba (Tue, 10 Oct 2017 11:41:21 GMT):
https://gerrit.hyperledger.org/r/#/c/14361/ metrics support config @mastersingh24 @C0rWin @JonathanLevi

skarim (Tue, 10 Oct 2017 13:27:08 GMT):
Please review the following fabric-ca CRs: https://gerrit.hyperledger.org/r/#/c/13215/ https://gerrit.hyperledger.org/r/#/c/13695/ https://gerrit.hyperledger.org/r/#/c/13735/ https://gerrit.hyperledger.org/r/#/c/14033/

lehors (Tue, 10 Oct 2017 19:34:25 GMT):
Could I please get some love on these? I got 2 +2 but had to rebase in between so I'm still missing 1 :-/ https://gerrit.hyperledger.org/r/#/c/14363/ https://gerrit.hyperledger.org/r/#/c/14375/

jtclark (Tue, 10 Oct 2017 20:31:31 GMT):
Should be quick... can I get some :eyes: on https://gerrit.hyperledger.org/r/#/c/14389/ ?

smithbk (Tue, 10 Oct 2017 23:04:35 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=B3BJ94eZ2ZQ58ePF8) @lehors Done

yoheiueda (Wed, 11 Oct 2017 05:28:59 GMT):
Has joined the channel.

mastersingh24 (Thu, 12 Oct 2017 07:46:33 GMT):
For anyone who is around: https://gerrit.hyperledger.org/r/#/c/14427/ Should stop e2e from failing in CI

mastersingh24 (Thu, 12 Oct 2017 14:07:03 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/14451/ @dave.enyeart @cbf ?

adc (Thu, 12 Oct 2017 14:40:32 GMT):
Hi All, please, some love to https://gerrit.hyperledger.org/r/#/c/13917/

jyellick (Thu, 12 Oct 2017 14:53:08 GMT):
As a companion to the above: https://gerrit.hyperledger.org/r/#/c/14265/ and https://gerrit.hyperledger.org/r/#/c/14267/

mastersingh24 (Thu, 12 Oct 2017 20:22:25 GMT):
Easy one: https://gerrit.hyperledger.org/r/#/c/14417/

jimthematrix (Thu, 12 Oct 2017 20:51:57 GMT):
https://gerrit.hyperledger.org/r/#/c/14323/ - node.js chaincode samples in fabric-samples repo (thanks @Ratnakar )

jimthematrix (Thu, 12 Oct 2017 22:22:05 GMT):
https://gerrit.hyperledger.org/r/#/c/14479/ - updates to Fabric docs, adding links to node.js chaincode API Reference

divyank (Fri, 13 Oct 2017 02:46:12 GMT):
https://gerrit.hyperledger.org/r/c/14491/ - temporarily disables endorser plugin test on the unsupported ppc64le architecture

yacovm (Fri, 13 Oct 2017 07:20:27 GMT):
A pretty easy one, most volume is test code - https://gerrit.hyperledger.org/r/#/c/14217/ `[FAB-6462] Enforce PEM types for gossip identities`

yacovm (Fri, 13 Oct 2017 07:20:27 GMT):
A pretty easy one, most volume is test code - https://gerrit.hyperledger.org/r/#/c/14217/ `Enforce PEM types for gossip identities`

yacovm (Fri, 13 Oct 2017 11:42:53 GMT):
JIRA bot above me recommends merging https://gerrit.hyperledger.org/r/#/c/14217/

yacovm (Fri, 13 Oct 2017 11:42:53 GMT):
JIRA bot above me recommends merging https://gerrit.hyperledger.org/r/#/c/14217/ @mastersingh24 I have addressed your comments

mastersingh24 (Fri, 13 Oct 2017 12:05:24 GMT):
Thanks JIRA bot ;)

wlahti (Fri, 13 Oct 2017 12:44:13 GMT):
https://gerrit.hyperledger.org/r/#/c/14483/ - easy one line fix to make sure filtered block events have a nil chaincode event instead of an empty one when there is no chaincode event present

mastersingh24 (Fri, 13 Oct 2017 14:39:16 GMT):
https://gerrit.hyperledger.org/r/#/c/13553/ - pluggable bccsp ;)

mastersingh24 (Sat, 14 Oct 2017 21:25:24 GMT):
https://gerrit.hyperledger.org/r/#/c/13553/ is actually ready now. @rjones - ok to remove your -1 (CI passing)

rjones (Sat, 14 Oct 2017 21:25:24 GMT):
Has joined the channel.

rjones (Sat, 14 Oct 2017 23:20:57 GMT):
@mastersingh24 yes

adc (Mon, 16 Oct 2017 06:43:18 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/12451/ Thanks :)

grapebaba (Mon, 16 Oct 2017 09:09:50 GMT):
https://gerrit.hyperledger.org/r/c/14361/ need more loves

wlahti (Mon, 16 Oct 2017 15:15:02 GMT):
https://gerrit.hyperledger.org/r/#/c/14055/ - error handling documentation update

rameshthoomu (Mon, 16 Oct 2017 15:42:01 GMT):
minor change on fabric-test daily job https://gerrit.hyperledger.org/r/#/c/14477/

mastersingh24 (Mon, 16 Oct 2017 19:18:38 GMT):
easy one - just backporting a fix to the release branch: https://gerrit.hyperledger.org/r/#/c/14527/

muralisr (Mon, 16 Oct 2017 21:41:08 GMT):
done @mastersingh24

adc (Tue, 17 Oct 2017 11:39:11 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/14579/ Thanks :)

muralisr (Tue, 17 Oct 2017 12:20:46 GMT):
done @adc

wlahti (Tue, 17 Oct 2017 12:22:14 GMT):
Event timestamp/timewindow fix ready for (final?) reviews: https://gerrit.hyperledger.org/r/#/c/13257/

jyellick (Tue, 17 Oct 2017 18:10:38 GMT):
https://gerrit.hyperledger.org/r/#/c/14391/ <- trivial move of a package and renaming some imports https://gerrit.hyperledger.org/r/#/c/14393/ <- rearranges some of the RSCC/ACL tree structure Both of these have one +2, need one more. Are dependent CRs down the chain that have merge conflicts, but trying to avoid a rebase losing the +2s

mastersingh24 (Tue, 17 Oct 2017 21:01:00 GMT):
2 really easy ones: https://gerrit.hyperledger.org/r/14581 https://gerrit.hyperledger.org/r/14583

grapebaba (Wed, 18 Oct 2017 10:31:03 GMT):
https://gerrit.hyperledger.org/r/c/14361/ add some default values

adc (Wed, 18 Oct 2017 11:27:58 GMT):
Hi All, please lots of love to https://gerrit.hyperledger.org/r/#/c/12451/ Thanks :)

boliang (Wed, 18 Oct 2017 14:24:15 GMT):
Has joined the channel.

boliang (Wed, 18 Oct 2017 14:25:01 GMT):
Hello, anyone could help to review https://gerrit.hyperledger.org/r/#/c/13835/ ? Thanks a lot!

cbf (Wed, 18 Oct 2017 14:26:43 GMT):
https://gerrit.hyperledger.org/r/c/13213

jtclark (Wed, 18 Oct 2017 16:08:35 GMT):
Hi there, plz review https://gerrit.hyperledger.org/r/14655

wlahti (Wed, 18 Oct 2017 16:12:49 GMT):
https://gerrit.hyperledger.org/r/#/c/14617/ - modifies the structure of the filtered block event to contain filtered actions which then contain the chaincode event for the transaction https://gerrit.hyperledger.org/r/#/c/13257 - event timestamp/timewindow fix (needs one more +2) https://gerrit.hyperledger.org/r/#/c/14055/ - error handling documentation update (needs one more +2) https://gerrit.hyperledger.org/r/#/c/14595/ - update peer channel join description for external consistency

mastersingh24 (Wed, 18 Oct 2017 17:44:59 GMT):
An easy one please: https://gerrit.hyperledger.org/r/#/c/14555/

mastersingh24 (Wed, 18 Oct 2017 17:46:44 GMT):
SDK updates to match https://gerrit.hyperledger.org/r/14615 : https://gerrit.hyperledger.org/r/14635 @jimthematrix

mastersingh24 (Wed, 18 Oct 2017 17:47:12 GMT):
https://gerrit.hyperledger.org/r/14637 @jimthematrix @rickr

aleksandar.likic (Wed, 18 Oct 2017 19:57:58 GMT):
Hi, there, please review https://gerrit.hyperledger.org/r/#/c/14513/

aleksandar.likic (Wed, 18 Oct 2017 19:57:58 GMT):
Hi there, please review https://gerrit.hyperledger.org/r/#/c/14513/

scottz (Wed, 18 Oct 2017 20:21:34 GMT):
https://gerrit.hyperledger.org/r/#/c/14643/ is trivial tweak of chaincode, and ASO approved it, which allows our automated encryption testcases to validate values and pass.

grapebaba (Thu, 19 Oct 2017 08:43:13 GMT):
https://gerrit.hyperledger.org/r/c/14681/ remove deprecated grpc.WithTimeout

grapebaba (Thu, 19 Oct 2017 08:43:43 GMT):
https://gerrit.hyperledger.org/r/c/14361/ metrics option configurable

adc (Thu, 19 Oct 2017 10:01:48 GMT):
Hi All, please check https://gerrit.hyperledger.org/r/#/c/12451/ and its chain of correlated change-sets. Thanks :)

mastersingh24 (Thu, 19 Oct 2017 12:22:47 GMT):
easy one: https://gerrit.hyperledger.org/r/14555

jtclark (Thu, 19 Oct 2017 15:16:51 GMT):
Easy one: https://gerrit.hyperledger.org/r/#/c/14655/

mastersingh24 (Thu, 19 Oct 2017 16:13:45 GMT):
This little fella is still waiting: https://gerrit.hyperledger.org/r/#/c/14555/ ;)

muralisr (Thu, 19 Oct 2017 17:14:03 GMT):
https://chat.hyperledger.org/channel/fabric-pr-review?msg=Srumk5WbnjzGmkSoq

muralisr (Thu, 19 Oct 2017 17:14:34 GMT):
some love for the above please ? I cant review as I contributed to it (mainly some refactoring for UT)

rameshthoomu (Thu, 19 Oct 2017 17:26:25 GMT):
One more +2 https://gerrit.hyperledger.org/r/#/c/14477/

muralisr (Thu, 19 Oct 2017 17:48:57 GMT):
so @rameshthoomu basically other tests cover the same function as the test you are disabling above ?

mastersingh24 (Thu, 19 Oct 2017 18:31:07 GMT):
[Added a tiny comment - but otherwise looks good ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=NQN72H3XJF8ATtSLZ) @muralisr

muralisr (Thu, 19 Oct 2017 19:38:16 GMT):
thanks for catching that @mastersingh24 :-) ... will upload soon.

mastersingh24 (Thu, 19 Oct 2017 20:09:42 GMT):
Sometimes I actually read ;)

muralisr (Thu, 19 Oct 2017 20:14:58 GMT):
riiight :-) (dear reader, don't be misled :-) ^^^ )

mastersingh24 (Thu, 19 Oct 2017 20:43:05 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/14599/

muralisr (Thu, 19 Oct 2017 21:15:50 GMT):
done @mastersingh24

mastersingh24 (Fri, 20 Oct 2017 12:32:48 GMT):
easy one - needs 1 +2 : https://gerrit.hyperledger.org/r/14711/ easy one - needs 2 +2 : https://gerrit.hyperledger.org/r/14729

mastersingh24 (Fri, 20 Oct 2017 12:34:28 GMT):
Trivial: https://gerrit.hyperledger.org/r/14521 https://gerrit.hyperledger.org/r/14655

muralisr (Fri, 20 Oct 2017 14:16:44 GMT):
(on behalf of @boliang ...) another +2 for this please https://gerrit.hyperledger.org/r/#/c/13835/ ?

rameshthoomu (Fri, 20 Oct 2017 15:01:39 GMT):
@mastersingh24 @cbf @scottz https://gerrit.hyperledger.org/r/#/c/14733/ -- smoke test job in fabric... On every fabric patch set verify and merge, CI triggers this job and publish voting on gerrit request..

rameshthoomu (Fri, 20 Oct 2017 15:04:46 GMT):
@scottz could you please provide some information on smoke test suite like what type of tests we run in any of these FABs (FAB-6665 or FAB-6705)

aambati (Fri, 20 Oct 2017 15:10:15 GMT):
@mastersingh24 can you rereview https://gerrit.hyperledger.org/r/c/14023/, you had +2 this before, i had to rebase after that

aambati (Fri, 20 Oct 2017 15:10:15 GMT):
@mastersingh24 can pls you rereview https://gerrit.hyperledger.org/r/c/14023/, you had +2 this before, i had to rebase after that

aambati (Fri, 20 Oct 2017 15:10:15 GMT):
@mastersingh24 can you pls rereview https://gerrit.hyperledger.org/r/c/14023/, you had +2 this before, i had to rebase after that

scottz (Fri, 20 Oct 2017 15:33:53 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=sgNSjEBn6idLwW6JQ) @rameshthoomu Our smoke tests ensure: - protobufs accessible from our test environment - can override config env vars - can bring up networks with a channel and example02 chaincode and do invoke and query - with and without TLS - with GO chaincode and NODE chaincode - with solo and kafka - with levelDB and couchDB

scottz (Fri, 20 Oct 2017 15:33:53 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=sgNSjEBn6idLwW6JQ) @rameshthoomu Our smoke tests get latest commits from fabric-test, fabric, fabric-ca, fabric-sdk-node, cello, and ensure the following (on single platform, but later could integrate cello and remote multiple hosts): - protobufs accessible from our test environment - can override config env vars - can bring up networks with a channel and example02 chaincode and do invoke and query - with and without TLS - with GO chaincode and NODE chaincode - with solo and kafka - with levelDB and couchDB

rennman (Fri, 20 Oct 2017 18:32:26 GMT):
https://gerrit.hyperledger.org/r/#/c/13905/ would like another +2 ... should drastically reduce the size of the console logs in CI

rjones (Fri, 20 Oct 2017 19:02:03 GMT):
@rennman I'm all in favor of smaller logs

baohua (Sat, 21 Oct 2017 07:17:02 GMT):
Welcome to help review this old patchset :) https://gerrit.hyperledger.org/r/#/c/8861/

muralisr (Sat, 21 Oct 2017 14:10:29 GMT):
@baohua +1 for now inviting others review

baohua (Sun, 22 Oct 2017 16:55:46 GMT):
thanks murali!

baohua (Sun, 22 Oct 2017 16:58:09 GMT):
We now got two +1s, welcome for more comments. This patchset stands up for several months. https://gerrit.hyperledger.org/r/#/c/8861/

grapebaba (Mon, 23 Oct 2017 08:57:21 GMT):
thanks @mastersingh24 , https://gerrit.hyperledger.org/r/c/14361/ @C0rWin @JonathanLevi would you like help review?

aleksandar.likic (Mon, 23 Oct 2017 14:01:45 GMT):
https://gerrit.hyperledger.org/r/#/c/14513/ is now complete. Please review. Thanks!

skarim (Mon, 23 Oct 2017 14:02:10 GMT):
Please review fabric-ca related CRs: https://gerrit.hyperledger.org/r/#/c/13695/ https://gerrit.hyperledger.org/r/#/c/13735/ https://gerrit.hyperledger.org/r/#/c/14033/

wlahti (Mon, 23 Oct 2017 14:28:50 GMT):
Error handling documentation update needs one more +2: https://gerrit.hyperledger.org/r/#/c/14055/

wlahti (Mon, 23 Oct 2017 14:28:50 GMT):
Error handling documentation update needs one more +2: https://gerrit.hyperledger.org/r/#/c/14055/ One line CR to update peer channel join's description: https://gerrit.hyperledger.org/r/#/c/14595/ Update filtered block with filtered actions array: https://gerrit.hyperledger.org/r/#/c/14617/

divyank (Mon, 23 Oct 2017 16:46:02 GMT):
https://gerrit.hyperledger.org/r/#/c/14753/ allow loading system chaincodes as Go plugins

skarim (Mon, 23 Oct 2017 17:35:55 GMT):
Should be a straightforward one: https://gerrit.hyperledger.org/r/#/c/14763/

muralisr (Mon, 23 Oct 2017 18:44:52 GMT):
@mastersingh24 @yacovm (and anyone else of course) addressed comments - ready for review https://gerrit.hyperledger.org/r/#/c/13835/

jyellick (Mon, 23 Oct 2017 18:46:43 GMT):
https://gerrit.hyperledger.org/r/#/c/14745/ Bug fix verified by reporter, but needs some +2 love

yacovm (Mon, 23 Oct 2017 21:46:05 GMT):
@jyellick a few comments

scottz (Tue, 24 Oct 2017 00:04:24 GMT):
Still need one more +2 for our quickie fix for a chaincode parameter: https://gerrit.hyperledger.org/r/#/c/14643/

mastersingh24 (Tue, 24 Oct 2017 12:16:01 GMT):
I think this one is ready: https://gerrit.hyperledger.org/r/14773 @yacovm @kostas @jyellick

muralisr (Tue, 24 Oct 2017 13:10:36 GMT):
@mastersingh24 14773 is showing errors ...z and x seem very similar if not same .. good chance its not a random failure a reverify would correct

muralisr (Tue, 24 Oct 2017 13:11:55 GMT):
and taking this opp. remind you of https://gerrit.hyperledger.org/r/#/c/13835 @mastersingh24 :-)

skarim (Tue, 24 Oct 2017 14:00:08 GMT):
Bug fixes: https://gerrit.hyperledger.org/r/#/c/14715/ https://gerrit.hyperledger.org/r/#/c/14763/

aleksandar.likic (Tue, 24 Oct 2017 14:55:49 GMT):
One more +2 for https://gerrit.hyperledger.org/r/#/c/14513/ please. Thanks!

aleksandar.likic (Tue, 24 Oct 2017 14:55:49 GMT):
One more +2 for https://gerrit.hyperledger.org/r/#/c/14513/ please. It's only eight (8) lines of code. Thanks!

mastersingh24 (Tue, 24 Oct 2017 15:20:51 GMT):
@muralisr - yeah - 14773 is odd. Not sure what was going on. It passes the tests locally. I pulled down a prior change, modified it and re-submitted. Let's hope all goes well

muralisr (Tue, 24 Oct 2017 15:22:17 GMT):
sure thing... I wasn't too sure what was happening either. :crossfingers:

muralisr (Tue, 24 Oct 2017 15:23:20 GMT):
that didn't parse @mastersingh24 ... no cross fingers ?

mastersingh24 (Tue, 24 Oct 2017 15:24:52 GMT):
":fingers_crossed"

mastersingh24 (Tue, 24 Oct 2017 15:24:57 GMT):
:fingers_crossed:

mastersingh24 (Tue, 24 Oct 2017 15:25:02 GMT):
;)

mastersingh24 (Tue, 24 Oct 2017 15:25:27 GMT):
:fingers_crossed_tone4:

mastersingh24 (Tue, 24 Oct 2017 15:25:37 GMT):
(a bit closer to my skin tone ;) )

mastersingh24 (Tue, 24 Oct 2017 15:25:51 GMT):
:fingers_crossed_tone3:

mastersingh24 (Tue, 24 Oct 2017 15:26:06 GMT):
maybe this one - been in Boston too long and been fading

mastersingh24 (Tue, 24 Oct 2017 15:26:07 GMT):
;)

muralisr (Tue, 24 Oct 2017 15:38:57 GMT):
:-) thanks, Gari ...that was dumb of me

baohua (Tue, 24 Oct 2017 20:02:44 GMT):
@leksandar.likic add some comments, thanks

aleksandar.likic (Tue, 24 Oct 2017 20:20:12 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=8m5z6yvxCnoYoyyd7) @baohua Thanks for taking time. Not sure that I understand, there is a description of the feature in https://jira.hyperledger.org/browse/FAB-6613 (which is referred to from the CR) and there are comments in the CR commit message. What else do you think I should add?

baohua (Tue, 24 Oct 2017 21:59:18 GMT):
yes, add a new comment. thanks!

grapebaba (Wed, 25 Oct 2017 02:50:22 GMT):
https://gerrit.hyperledger.org/r/c/14361/ stay there in a while, anyone could help review?

jyellick (Wed, 25 Oct 2017 02:51:14 GMT):
https://gerrit.hyperledger.org/r/#/c/14745/ needs one more +2, is a bug

grapebaba (Wed, 25 Oct 2017 09:44:55 GMT):
https://gerrit.hyperledger.org/r/c/14361/ need one more +2, guys

troyronda (Wed, 25 Oct 2017 11:07:57 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=9fxwsPKcgR2eTwP6d) This change needs some help with reviews ... thanks in advance :).

bstasyszyn (Wed, 25 Oct 2017 12:00:51 GMT):
Has joined the channel.

bstasyszyn (Wed, 25 Oct 2017 12:03:36 GMT):
https://gerrit.hyperledger.org/r/#/c/14791/ implements the Private Data Functions in MockStub. Can someone please review? Thx.

aambati (Wed, 25 Oct 2017 16:11:34 GMT):
https://gerrit.hyperledger.org/r/c/13687/ ( Added steps to fabric-ca sample to query by a revoked user) and https://gerrit.hyperledger.org/r/c/13887/ (Added gencrl option to the fabric-ca-client revoke cmd) needs additional +2 . Please help review these two change sets and get fab-5300 1.1 preview...thanks in advance

wlahti (Wed, 25 Oct 2017 22:43:28 GMT):
This should fix the intermittent UT failures in master in core/chaincode: https://gerrit.hyperledger.org/r/#/c/14857/

wlahti (Wed, 25 Oct 2017 22:43:28 GMT):
This should fix the intermittent UT failures in master due to core/chaincode tests: https://gerrit.hyperledger.org/r/#/c/14857/

wlahti (Wed, 25 Oct 2017 22:43:28 GMT):
~This should fix the intermittent UT failures in master due to core/chaincode tests: https://gerrit.hyperledger.org/r/#/c/14857/~ Thanks, @muralisr and @yacovm!

C0rWin (Wed, 25 Oct 2017 22:52:22 GMT):
fix for FAB-6744 - https://gerrit.hyperledger.org/r/#/c/14865/, needs some love

baohua (Thu, 26 Oct 2017 04:24:41 GMT):
Welcome for review, it's a safe change to enable more strict format checking on code. Thanks: https://gerrit.hyperledger.org/r/#/c/8861/

grapebaba (Thu, 26 Oct 2017 04:45:35 GMT):
https://gerrit.hyperledger.org/r/c/14361/ need one more +2 guys

divyank (Thu, 26 Oct 2017 11:08:05 GMT):
https://gerrit.hyperledger.org/r/c/14753/ makes Fabric's pluggable components pluggable.

jyellick (Thu, 26 Oct 2017 13:44:13 GMT):
https://gerrit.hyperledger.org/r/#/c/14795/ Simple change which is a prerequisite for capability support on upgrade

joe-alewine (Thu, 26 Oct 2017 14:32:52 GMT):
https://gerrit.hyperledger.org/r/#/c/14529/ Redoing documentation on dependency of libtool

joe-alewine (Thu, 26 Oct 2017 14:51:46 GMT):
https://gerrit.hyperledger.org/r/c/14883/ Fixing a simple typo (two missing quotation marks)

joe-alewine (Thu, 26 Oct 2017 15:13:15 GMT):
https://gerrit.hyperledger.org/r/c/13947/ Deletes mkdocs.yml in light of github now using sphinx

joe-alewine (Thu, 26 Oct 2017 15:35:32 GMT):
https://gerrit.hyperledger.org/r/c/14887/ Edits Writing Your First App to reflect changes to the "fabcar" directory inside of fabric_samples

joe-alewine (Thu, 26 Oct 2017 16:18:01 GMT):
https://gerrit.hyperledger.org/r/c/13387/ Deleting out of date docs

nnao (Thu, 26 Oct 2017 16:28:28 GMT):
https://gerrit.hyperledger.org/r/#/c/14869 Deletes a duplicated pkgmap.cryptogen In Makefile

wlahti (Thu, 26 Oct 2017 16:30:03 GMT):
Already has two +2s. Ready to merge now that CI has completed successfully: https://gerrit.hyperledger.org/r/#/c/14881/

wlahti (Thu, 26 Oct 2017 16:30:03 GMT):
https://gerrit.hyperledger.org/r/#/c/14881/ - Fixes another intermittent test failure due to the recent chaincode startup timeout change. Already has two +2s. Ready to merge now that CI has completed successfully.

wlahti (Thu, 26 Oct 2017 16:30:03 GMT):
~https://gerrit.hyperledger.org/r/#/c/14881/ - Fixes another intermittent test failure due to the recent chaincode startup timeout change. Already has two +2s. Ready to merge now that CI has completed successfully.~ thanks @muralisr!

wlahti (Thu, 26 Oct 2017 16:42:25 GMT):
Error handling documentation update needs one more +2: https://gerrit.hyperledger.org/r/#/c/14055 One line CR to update peer channel join's description: https://gerrit.hyperledger.org/r/#/c/14595

biljana_lukovic (Thu, 26 Oct 2017 18:49:03 GMT):
Has joined the channel.

biljana_lukovic (Thu, 26 Oct 2017 18:51:05 GMT):
Expose the 'GetOrgOfPeer()' method through gossip interface ... https://gerrit.hyperledger.org/r/#/c/14899/

markparz (Thu, 26 Oct 2017 19:30:33 GMT):
This one too please : https://gerrit.hyperledger.org/r/c/14891/

markparz (Thu, 26 Oct 2017 19:33:49 GMT):
https://gerrit.hyperledger.org/r/11775

mastersingh24 (Thu, 26 Oct 2017 19:53:34 GMT):
Easy ones: https://gerrit.hyperledger.org/r/14883 https://gerrit.hyperledger.org/r/14885

markparz (Thu, 26 Oct 2017 20:22:24 GMT):
mine too :)

aleksandar.likic (Thu, 26 Oct 2017 20:50:22 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=t2zhp8S4S3bjG8hw8) @biljana_lukovic Eventually, https://jira.hyperledger.org/browse/FAB-5451 will provide this functionality. Until then, please merge this simple change to expose this information to the application layer. Thanks.

aleksandar.likic (Thu, 26 Oct 2017 20:50:22 GMT):
https://gerrit.hyperledger.org/r/#/c/14899/ Eventually, https://jira.hyperledger.org/browse/FAB-5451 will provide this functionality. Until then, please merge this simple change to expose GetOrgOfPeer() to the application layer. Thanks.

divyank (Thu, 26 Oct 2017 21:21:56 GMT):
Initiates upgrade to Go 1.9.2: https://gerrit.hyperledger.org/r/c/14903/

luomin (Fri, 27 Oct 2017 01:34:06 GMT):
Has joined the channel.

luomin (Fri, 27 Oct 2017 01:42:00 GMT):
@joe-alewine thanks for post. just correct the link you shared above. Deleting out of date docs. https://gerrit.hyperledger.org/r/#/c/13387/

joe-alewine (Fri, 27 Oct 2017 12:17:47 GMT):
@luomin The link I posted works for me. Are you using the new gerrit UI?

skarim (Fri, 27 Oct 2017 13:20:29 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/14763/

firas.qutishat (Fri, 27 Oct 2017 13:30:50 GMT):
Has joined the channel.

firas.qutishat (Fri, 27 Oct 2017 13:31:16 GMT):
Easy ones: https://gerrit.hyperledger.org/r/#/c/14903/

firas.qutishat (Fri, 27 Oct 2017 13:31:16 GMT):
Easy one: https://gerrit.hyperledger.org/r/#/c/14903/

jyellick (Fri, 27 Oct 2017 15:20:00 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=o9YuQAeraCBCzw9fi)

jyellick (Fri, 27 Oct 2017 15:20:19 GMT):
^ Blocking Jeff's upgrade/capability testing

muralisr (Fri, 27 Oct 2017 18:10:24 GMT):
a bit of love for this please https://gerrit.hyperledger.org/r/#/c/14919/ - fairly obvious change to use channel ID in addition to tx id for mapping to proposal context with the negative and positive UT in chaincode_support_test.go

mastersingh24 (Fri, 27 Oct 2017 18:19:04 GMT):
@muralisr - Does ^^^^^ eliminate the need for https://gerrit.hyperledger.org/r/#/c/14897/ ?

mastersingh24 (Fri, 27 Oct 2017 18:19:04 GMT):
@muralisr - Does ^^^^^ eliminate the need for https://gerrit.hyperledger.org/r/14897/ ?

muralisr (Fri, 27 Oct 2017 18:20:01 GMT):
@mastersingh24 looking...

mastersingh24 (Fri, 27 Oct 2017 18:24:22 GMT):
I know they are different, but wondering if it is covered somehow

muralisr (Fri, 27 Oct 2017 18:25:06 GMT):
@mastersingh24 right... its not covered by 14919

muralisr (Fri, 27 Oct 2017 18:25:18 GMT):
(on a side note, one of the reasons 14919 does not insist on channel ID being non empty is because there are cases where we call chaincode with "")

mastersingh24 (Fri, 27 Oct 2017 18:25:36 GMT):
ok - can you comment on it then? ;)

muralisr (Fri, 27 Oct 2017 18:26:01 GMT):
as in review 14897 ?

mastersingh24 (Fri, 27 Oct 2017 18:26:10 GMT):
Yes please ;)

muralisr (Fri, 27 Oct 2017 18:26:19 GMT):
sure thing :-)

muralisr (Fri, 27 Oct 2017 18:27:05 GMT):
I did comment on the actual JIRA a while back but will take a look at the CR

muralisr (Fri, 27 Oct 2017 18:33:54 GMT):
ah I see what you mean... responded to your comment.

yacovm (Fri, 27 Oct 2017 18:45:24 GMT):
> This prevents CC-2-CC calls where the called CC is on a different channel @muralisr @mastersingh24 so - a cross-channel CC2CC invocation doesn't ... work?

muralisr (Fri, 27 Oct 2017 18:47:40 GMT):
if the calling cc is same as called cc

muralisr (Fri, 27 Oct 2017 18:47:43 GMT):
that's the bug

muralisr (Fri, 27 Oct 2017 18:47:49 GMT):
did I state it wrong somewhere ?

yacovm (Fri, 27 Oct 2017 18:54:16 GMT):
ah I see

mastersingh24 (Sat, 28 Oct 2017 09:58:04 GMT):
Some easy ones (mostly doc/cosmetic) to clean up the CR backlog: https://gerrit.hyperledger.org/r/13131 https://gerrit.hyperledger.org/r/14939 https://gerrit.hyperledger.org/r/13777 https://gerrit.hyperledger.org/r/13957 https://gerrit.hyperledger.org/r/14941 https://gerrit.hyperledger.org/r/13957

aso (Sat, 28 Oct 2017 11:58:05 GMT):
an easy one pls https://gerrit.hyperledger.org/r/#/c/13457/ it already has a +2 (and several +1's)

baohua (Sat, 28 Oct 2017 14:41:00 GMT):
Again, would like to welcome for review on this safe changeset on enabling better code checking: https://gerrit.hyperledger.org/r/#/c/8861/. Thanks!

dave.enyeart (Sat, 28 Oct 2017 17:12:46 GMT):
https://gerrit.hyperledger.org/r/#/c/14917/ Chaincode Encryption sample from @aso is ready for final +2 review

dave.enyeart (Sat, 28 Oct 2017 17:12:46 GMT):
~https://gerrit.hyperledger.org/r/#/c/14917/~ Chaincode Encryption sample from @aso is ready for final +2 review

muralisr (Sat, 28 Oct 2017 18:04:52 GMT):
@dave.enyeart as @binhn brought this issue up will +1 for now waiting for his review

dave.enyeart (Sun, 29 Oct 2017 20:51:17 GMT):
A few doc/tutorial updates for 1.1 preview this week:

dave.enyeart (Sun, 29 Oct 2017 20:51:18 GMT):
a few doc merges needed if you could help: https://gerrit.hyperledger.org/r/#/c/14395 https://gerrit.hyperledger.org/r/#/c/14909 https://gerrit.hyperledger.org/r/#/c/14925 https://gerrit.hyperledger.org/r/#/c/14929

dave.enyeart (Sun, 29 Oct 2017 20:51:18 GMT):
https://gerrit.hyperledger.org/r/#/c/14395 https://gerrit.hyperledger.org/r/#/c/14909 https://gerrit.hyperledger.org/r/#/c/14925 https://gerrit.hyperledger.org/r/#/c/14929

dave.enyeart (Sun, 29 Oct 2017 20:51:18 GMT):
https://gerrit.hyperledger.org/r/#/c/14395 https://gerrit.hyperledger.org/r/#/c/14909 ~https://gerrit.hyperledger.org/r/#/c/14925~ ~https://gerrit.hyperledger.org/r/#/c/14929~

dave.enyeart (Sun, 29 Oct 2017 20:51:18 GMT):
~https://gerrit.hyperledger.org/r/#/c/14395~ ~https://gerrit.hyperledger.org/r/#/c/14909~ ~https://gerrit.hyperledger.org/r/#/c/14925~ ~https://gerrit.hyperledger.org/r/#/c/14929~

mastersingh24 (Mon, 30 Oct 2017 08:29:33 GMT):
A pretty easy one - needs one more +2 - https://gerrit.hyperledger.org/r/#/c/14945/ ;)

muralisr (Mon, 30 Oct 2017 19:06:55 GMT):
@mastersingh24 thanks for the +1 for https://gerrit.hyperledger.org/r/#/c/14919/ ... may I request more love please :-) once this is through, I can focus on the FSM cleanup

adc (Tue, 31 Oct 2017 07:43:27 GMT):
Hi, All. Please some love to https://gerrit.hyperledger.org/r/#/c/14573/. Thanks :)

mastersingh24 (Tue, 31 Oct 2017 11:52:15 GMT):
easy one from Will - https://gerrit.hyperledger.org/r/14595

mastersingh24 (Tue, 31 Oct 2017 12:54:21 GMT):
fairly easy one: https://gerrit.hyperledger.org/r/14981 ;)

aso (Tue, 31 Oct 2017 16:45:47 GMT):
https://gerrit.hyperledger.org/r/#/c/14535/ now unblocked by previous merge and with 2 +2's.... thx in advance!

aso (Tue, 31 Oct 2017 16:45:47 GMT):
https://gerrit.hyperledger.org/r/#/c/14535/ now unblocked by previous merge and already with 2 +2's.... thx in advance!

smithbk (Tue, 31 Oct 2017 17:35:56 GMT):
https://gerrit.hyperledger.org/r/14275 FAB-3416 Vendoring govaluate https://gerrit.hyperledger.org/r/14279 FAB-3416 Map LDAP attrs to fabric CA attrs

nickgaski (Tue, 31 Oct 2017 18:42:01 GMT):
this one is ready - https://gerrit.hyperledger.org/r/#/c/14965/

mastersingh24 (Tue, 31 Oct 2017 19:23:44 GMT):
Fabric CA v1.0.4: https://gerrit.hyperledger.org/r/15009 https://gerrit.hyperledger.org/r/15011

mastersingh24 (Tue, 31 Oct 2017 19:37:18 GMT):
@JonathanLevi @cbf @dave.enyeart ^^^

divyank (Tue, 31 Oct 2017 19:37:36 GMT):
Docs for SCC plugins: https://gerrit.hyperledger.org/r/#/c/15013/

mastersingh24 (Tue, 31 Oct 2017 20:32:36 GMT):
Fabric CA v1.0.4: https://gerrit.hyperledger.org/r/15009 https://gerrit.hyperledger.org/r/15011

mastersingh24 (Tue, 31 Oct 2017 20:32:53 GMT):
these guys are still waiting ^^^^^ :pray_tone3:

dave.enyeart (Tue, 31 Oct 2017 20:45:15 GMT):
@mastersingh24 I put a comment in 15009

dave.enyeart (Tue, 31 Oct 2017 20:46:41 GMT):
A few doc/sample items that we'd like to get in for 1.1 preview:

dave.enyeart (Tue, 31 Oct 2017 20:46:44 GMT):
https://gerrit.hyperledger.org/r/#/c/14965/

dave.enyeart (Tue, 31 Oct 2017 20:46:44 GMT):
~https://gerrit.hyperledger.org/r/#/c/14965/~

dave.enyeart (Tue, 31 Oct 2017 20:46:56 GMT):
https://gerrit.hyperledger.org/r/#/c/14467/

dave.enyeart (Tue, 31 Oct 2017 20:46:56 GMT):
~https://gerrit.hyperledger.org/r/#/c/14467/~

dave.enyeart (Tue, 31 Oct 2017 20:47:06 GMT):
https://gerrit.hyperledger.org/r/#/c/14977/

dave.enyeart (Tue, 31 Oct 2017 20:47:06 GMT):
~https://gerrit.hyperledger.org/r/#/c/14977/~

mastersingh24 (Tue, 31 Oct 2017 20:47:38 GMT):
[will respond in the CR but that's only for fabric. fabric-ca does not have that doc ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=qCqWqZyJgQ7Fbg95H) @dave.enyeart

mastersingh24 (Tue, 31 Oct 2017 20:47:38 GMT):
will respond in the CR but that's only for fabric. fabric-ca does not have that doc (https://chat.hyperledger.org/channel/fabric-pr-review?msg=qCqWqZyJgQ7Fbg95H) @dave.enyeart

dave.enyeart (Tue, 31 Oct 2017 20:49:10 GMT):
@mastersingh24 ok I +2ed them both. I'll let you have merge honors

mastersingh24 (Tue, 31 Oct 2017 20:49:54 GMT):
gracias

jyellick (Tue, 31 Oct 2017 21:03:01 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-maintainers?msg=RwvC7gaAqBPTBWoAg)

mastersingh24 (Tue, 31 Oct 2017 21:12:55 GMT):
Last 2 for v1.0.4: https://gerrit.hyperledger.org/r/15005 https://gerrit.hyperledger.org/r/15007

mastersingh24 (Tue, 31 Oct 2017 22:58:38 GMT):
OK - believe it or not I can actually make mistakes

mastersingh24 (Tue, 31 Oct 2017 22:59:10 GMT):
I used the wrong link for the bootstrap script for v1.0.4. :( This fixes it: https://gerrit.hyperledger.org/r/15043

mastersingh24 (Wed, 01 Nov 2017 11:47:14 GMT):
@cbf @dave.enyeart - https://gerrit.hyperledger.org/r/15055 (updates the doc on master to clone the master branch of fabric-samples)

mastersingh24 (Wed, 01 Nov 2017 12:07:36 GMT):
for the release branch: https://gerrit.hyperledger.org/r/15049 https://gerrit.hyperledger.org/r/15051 (they should be merged at the same time - one updates the fabric-samples and the other updates the docs)

dave.enyeart (Wed, 01 Nov 2017 13:24:52 GMT):
@mastersingh24 I've -2ed since these updates were written with 1.1 assumptions and therefore cannot be ported to release branch as-is.

dave.enyeart (Wed, 01 Nov 2017 13:25:11 GMT):
Added specific comments in the CRs

yacovm (Wed, 01 Nov 2017 13:32:19 GMT):
re-introducing a brittle test that was disabled https://gerrit.hyperledger.org/r/#/c/12419/

mastersingh24 (Wed, 01 Nov 2017 13:52:55 GMT):
@dave.enyeart - good catch on the Node CC - I somehow missed it even though I was looking for it. As for the other, I tested the updated fabcar samples with v1.0.4 images and all is good

dave.enyeart (Wed, 01 Nov 2017 13:53:10 GMT):
cool

mastersingh24 (Wed, 01 Nov 2017 13:53:39 GMT):
I posted a update to the other removing the reference to node cc

dave.enyeart (Wed, 01 Nov 2017 14:04:41 GMT):
@mastersingh24 I've +2ed them both now, and confirmed with Bret that he intended the fabcar updates to work against both 1.0.x and 1.1. However the balance-transfer sample demonstrates connection profile and therefore those updates cannot be backported to release.

dave.enyeart (Wed, 01 Nov 2017 14:04:41 GMT):
@mastersingh24 I've +2ed them both now, and confirmed with Bret that he intended the fabcar updates to work against both 1.0.x and 1.1. However the latest balance-transfer sample demonstrates connection profile and therefore those updates cannot be backported to release.

mastersingh24 (Wed, 01 Nov 2017 14:05:56 GMT):
correct

mastersingh24 (Wed, 01 Nov 2017 14:06:23 GMT):
That's why that little fella stayed in master and is what also drove my other CR for the git clone cmd ;)

mastersingh24 (Wed, 01 Nov 2017 14:06:41 GMT):
There's some method to my madness (some - not a lot ;) )

jeffgarratt (Wed, 01 Nov 2017 14:48:27 GMT):
is Jira down?

rameshthoomu (Wed, 01 Nov 2017 14:52:00 GMT):
No

mastersingh24 (Wed, 01 Nov 2017 14:54:30 GMT):
just slow sometimes @jeffgarratt

jeffgarratt (Wed, 01 Nov 2017 14:54:43 GMT):
it's back... was getting 502

jeffgarratt (Wed, 01 Nov 2017 15:38:31 GMT):
Validator related change https://gerrit.hyperledger.org/r/#/c/14961/

cbf (Wed, 01 Nov 2017 17:14:12 GMT):
@mastersingh24 @jimthematrix or @JonathanLevi the 1.1 release CRs are almost all through CI (or manually verified in the case of fabric-ca, see my comment)

cbf (Wed, 01 Nov 2017 17:15:09 GMT):
https://gerrit.hyperledger.org/r/c/15061/ https://gerrit.hyperledger.org/r/c/15065/ https://gerrit.hyperledger.org/r/c/15059/ https://gerrit.hyperledger.org/r/c/15069/ https://gerrit.hyperledger.org/r/c/15071/ https://gerrit.hyperledger.org/r/c/15077/ https://gerrit.hyperledger.org/r/c/15073/

cbf (Wed, 01 Nov 2017 17:16:16 GMT):
as @dave.enyeart noted, we received the go-ahead from @scottz and @rameshthoomu that the SVT tests all passed... as a reminder this is just a preview release not feature complete

mastersingh24 (Wed, 01 Nov 2017 17:16:33 GMT):
are you the submitter?

cbf (Wed, 01 Nov 2017 17:16:33 GMT):
we could use another +2 on each then I will merge them

cbf (Wed, 01 Nov 2017 17:16:41 GMT):
yes

cbf (Wed, 01 Nov 2017 17:16:53 GMT):
I realize that makes them all suspect;-)

mastersingh24 (Wed, 01 Nov 2017 17:21:00 GMT):
It does - but easy filter

mastersingh24 (Wed, 01 Nov 2017 17:21:11 GMT):
Although I usually filter you out

mastersingh24 (Wed, 01 Nov 2017 17:21:18 GMT):
I added some comments to https://gerrit.hyperledger.org/r/15059

mastersingh24 (Wed, 01 Nov 2017 17:21:28 GMT):
But maybe worth a quick chat here

cbf (Wed, 01 Nov 2017 17:21:53 GMT):
oh I left off https://gerrit.hyperledger.org/r/c/15067/

mastersingh24 (Wed, 01 Nov 2017 17:22:11 GMT):
For RTD, are we OK just using master/latest to be for the 1.1-preview? Or did we want to be able to have 1.1-preview as a version in RTD?

cbf (Wed, 01 Nov 2017 17:23:28 GMT):
ah yes

mastersingh24 (Wed, 01 Nov 2017 17:23:37 GMT):
If so, we should include 15055 and also update the download link before setting release = true and tagging the release. If we are good with just using master / latest, then not needed. This was the hard lesson I learned from v1.0.4

cbf (Wed, 01 Nov 2017 17:23:49 GMT):
fair enough is it ready to be merged? I can rebase and we can manually verify

cbf (Wed, 01 Nov 2017 17:23:53 GMT):
+1

mastersingh24 (Wed, 01 Nov 2017 17:24:33 GMT):
Do you have the new download link?

cbf (Wed, 01 Nov 2017 17:24:42 GMT):
I can grab one now

mastersingh24 (Wed, 01 Nov 2017 17:24:48 GMT):
I can quickly add that to 15055

dave.enyeart (Wed, 01 Nov 2017 17:25:41 GMT):
I was assuming we'd point to latest RTD rather than a 1.1-preview of the docs

dave.enyeart (Wed, 01 Nov 2017 17:26:01 GMT):
I am going to include in the announcement email the links to the doc pages of interest for preview

mastersingh24 (Wed, 01 Nov 2017 17:26:09 GMT):
I think 1.1-preview makes more sense so we can keep updating master on the way to alpha

mastersingh24 (Wed, 01 Nov 2017 17:26:43 GMT):
This all came to me last night as I was challenged by by 1.0.4 mess

mastersingh24 (Wed, 01 Nov 2017 17:26:43 GMT):
This all came to me last night as I was challenged by my 1.0.4 mess

dave.enyeart (Wed, 01 Nov 2017 17:27:03 GMT):
Yeah, I was assuming we'd keep updating master for docs. You are correct would be cleaner with 1.1-preview version of deocs

dave.enyeart (Wed, 01 Nov 2017 17:27:03 GMT):
Yeah, I was assuming we'd keep updating master for docs. You are correct would be cleaner with 1.1-preview version of RTDs

dave.enyeart (Wed, 01 Nov 2017 17:27:29 GMT):
I'm with you

cbf (Wed, 01 Nov 2017 17:27:35 GMT):
https://goo.gl/fMh2s3

cbf (Wed, 01 Nov 2017 17:27:49 GMT):
you going to update 15055

cbf (Wed, 01 Nov 2017 17:27:57 GMT):
then I can rebase mine

mastersingh24 (Wed, 01 Nov 2017 17:28:46 GMT):
yep - doing it now

mastersingh24 (Wed, 01 Nov 2017 17:30:08 GMT):
done

cbf (Wed, 01 Nov 2017 17:33:38 GMT):
@dave.enyeart we could use another +2 on https://gerrit.hyperledger.org/r/c/15055/

mastersingh24 (Wed, 01 Nov 2017 17:34:42 GMT):
fabric-ca is ready

cbf (Wed, 01 Nov 2017 17:41:47 GMT):
thx

dave.enyeart (Wed, 01 Nov 2017 17:45:43 GMT):
@cbf +2ed it

cbf (Wed, 01 Nov 2017 17:47:09 GMT):
thx

cbf (Wed, 01 Nov 2017 17:52:09 GMT):
@dave.enyeart @mastersingh24 https://gerrit.hyperledger.org/r/c/15059 and https://gerrit.hyperledger.org/r/c/15069 need +2s

kostas (Wed, 01 Nov 2017 17:59:59 GMT):
@cbf: Perhaps not a deal-breaker, but see: https://gerrit.hyperledger.org/r/c/15059/2/Makefile#40

cbf (Wed, 01 Nov 2017 18:01:09 GMT):
@kostas not worth changing at this point

cbf (Wed, 01 Nov 2017 18:01:21 GMT):
that is only used for make changelog and I don't use that

kostas (Wed, 01 Nov 2017 18:01:30 GMT):
ACK, will +2 right now.

cbf (Wed, 01 Nov 2017 18:02:37 GMT):
@jimthematrix who else can +2 chaincode-node?

mastersingh24 (Wed, 01 Nov 2017 18:03:16 GMT):
good to merge the fabric-ca CRs?

mastersingh24 (Wed, 01 Nov 2017 18:03:22 GMT):
I can hit submit

dave.enyeart (Wed, 01 Nov 2017 18:05:45 GMT):
@jimthematrix is not on rocket today (but is on slack). @bretharrison is another maintainer in chaincode-node

dave.enyeart (Wed, 01 Nov 2017 18:06:25 GMT):
@cbf @mastersingh24 why do i see these tags in master:

dave.enyeart (Wed, 01 Nov 2017 18:06:29 GMT):
```v1.0.1 v1.0.2 v1.0.3```

dave.enyeart (Wed, 01 Nov 2017 18:06:42 GMT):
master has none of these releases, right?

mastersingh24 (Wed, 01 Nov 2017 18:08:28 GMT):
tags are not against a branch

mastersingh24 (Wed, 01 Nov 2017 18:08:32 GMT):
they are against commits

dave.enyeart (Wed, 01 Nov 2017 18:09:15 GMT):
ok, so then my question is why is v1.0.4 not there?

dave.enyeart (Wed, 01 Nov 2017 18:09:55 GMT):
nevermind, see it

dave.enyeart (Wed, 01 Nov 2017 18:20:36 GMT):
@cbf Can Jim/Bret go ahead and merge https://gerrit.hyperledger.org/r/#/c/15077/ and https://gerrit.hyperledger.org/r/#/c/15067/ ?

cbf (Wed, 01 Nov 2017 18:58:10 GMT):
so, I am really thinking that we need to have release managers on as reviewers for all repos in a release - really annoying to have to chase down when there are only two for 2+2

mastersingh24 (Wed, 01 Nov 2017 19:04:42 GMT):
indeed

JonathanLevi (Wed, 01 Nov 2017 19:27:34 GMT):
I agree !

mastersingh24 (Wed, 01 Nov 2017 22:02:08 GMT):
These little guys could use one more +2 plus a merge on the release branch: https://gerrit.hyperledger.org/r/#/q/branch:release+owner:%22Gari+Singh+%253Cgari.r.singh%2540gmail.com%253E%22++status:open

baohua (Thu, 02 Nov 2017 04:39:37 GMT):
A simple and old changeset to enhance code format checking, (got three +1 before) rebased again to latest code, welcome to help review: https://gerrit.hyperledger.org/r/#/c/8861/

adc (Thu, 02 Nov 2017 12:30:56 GMT):
Hi, All. Please, some love to https://gerrit.hyperledger.org/r/#/c/12453/ Thanks :)

adc (Thu, 02 Nov 2017 12:57:52 GMT):
please, review also https://gerrit.hyperledger.org/r/#/c/12455/ :)

jeffgarratt (Thu, 02 Nov 2017 14:16:21 GMT):
@aso 's https://gerrit.hyperledger.org/r/#/c/14961/

jeffgarratt (Thu, 02 Nov 2017 14:19:37 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/14893/

jeffgarratt (Thu, 02 Nov 2017 14:20:37 GMT):
easy type fix in https://gerrit.hyperledger.org/r/#/c/14975/

jeffgarratt (Thu, 02 Nov 2017 14:20:37 GMT):
easy typo fix in https://gerrit.hyperledger.org/r/#/c/14975/

divyank (Thu, 02 Nov 2017 14:49:10 GMT):
Docs for system chaincode plugins: https://gerrit.hyperledger.org/r/#/c/15013/

divyank (Thu, 02 Nov 2017 14:49:29 GMT):

just read the instructions.jpg

muralisr (Thu, 02 Nov 2017 16:05:11 GMT):
@divyank will look

cbf (Thu, 02 Nov 2017 18:18:46 GMT):
https://gerrit.hyperledger.org/r/c/12067/

divyank (Thu, 02 Nov 2017 20:52:01 GMT):
Release baseimage with Go 1.9.2: https://gerrit.hyperledger.org/r/c/15143/

jyellick (Fri, 03 Nov 2017 03:45:36 GMT):
There is a growing stack on top of this one: https://gerrit.hyperledger.org/r/#/c/14601/ No real code changes, just proto and proto translation annotations

harsha (Fri, 03 Nov 2017 11:02:03 GMT):
Easy one :- https://gerrit.hyperledger.org/r/#/c/15163

harsha (Fri, 03 Nov 2017 11:02:03 GMT):
Easy one :- ~ https://gerrit.hyperledger.org/r/#/c/15163 ~

aso (Fri, 03 Nov 2017 13:55:30 GMT):
*1-file change* https://gerrit.hyperledger.org/r/#/c/14537/ to bring up MSPs with a type different from the default

mastersingh24 (Fri, 03 Nov 2017 14:46:33 GMT):
Added a comment (https://chat.hyperledger.org/channel/fabric-pr-review?msg=CSK7zDsxhfR4EmHNr) @aso

aso (Fri, 03 Nov 2017 14:47:14 GMT):
:thumbup: thx! I answered!

mastersingh24 (Fri, 03 Nov 2017 14:47:53 GMT):
@jyellick - couple comments on a few in the series - they are the ones with a +1 (https://chat.hyperledger.org/channel/fabric-pr-review?msg=o7v9Dw5PxTqh5WgJ6)

jyellick (Fri, 03 Nov 2017 14:49:58 GMT):
Thanks @mastersingh24 I was composing a reply on the protos one as you pinged

divyank (Fri, 03 Nov 2017 17:38:44 GMT):
Release baseimage with Go 1.9.2: https://gerrit.hyperledger.org/r/c/15143

aso (Fri, 03 Nov 2017 18:17:17 GMT):
second +2 pls on a one-file change... https://gerrit.hyperledger.org/r/#/c/14537 :innocent:

nnao (Fri, 03 Nov 2017 18:56:15 GMT):
Delete '--tls' extra arguments: https://gerrit.hyperledger.org/r/#/c/15149/

muralisr (Fri, 03 Nov 2017 19:39:15 GMT):
one more +2 https://gerrit.hyperledger.org/r/#/c/14919/ for this please

mastersingh24 (Fri, 03 Nov 2017 20:07:00 GMT):
@muralisr - maybe a pretty please? ;)

muralisr (Fri, 03 Nov 2017 20:07:26 GMT):
pretty, pretty :-)

muralisr (Fri, 03 Nov 2017 20:07:55 GMT):
@dave.enyeart suggested we hold off till we have at least node shim covered ...

muralisr (Fri, 03 Nov 2017 20:08:37 GMT):
I didn't know how widely node chaincode was getting used.

dave.enyeart (Fri, 03 Nov 2017 20:08:54 GMT):
Composer is actively using node chaincode

muralisr (Fri, 03 Nov 2017 20:09:06 GMT):
with master ?

dave.enyeart (Fri, 03 Nov 2017 20:09:09 GMT):
yes

muralisr (Fri, 03 Nov 2017 20:09:11 GMT):
ok

mastersingh24 (Fri, 03 Nov 2017 20:32:40 GMT):
https://gerrit.hyperledger.org/r/15123 - easy one from @aambati

muralisr (Fri, 03 Nov 2017 20:40:17 GMT):
done @mastersingh24 @aambati

jeffgarratt (Sat, 04 Nov 2017 01:50:45 GMT):
https://gerrit.hyperledger.org/r/#/c/15149/

jeffgarratt (Sat, 04 Nov 2017 01:50:45 GMT):
--tls issue in e2e scripting -> https://gerrit.hyperledger.org/r/#/c/15149/

jeffgarratt (Sat, 04 Nov 2017 01:55:43 GMT):
@muralisr could you look at this when you get some time.. less than 10 lines https://gerrit.hyperledger.org/r/#/c/14893/

muralisr (Sat, 04 Nov 2017 02:34:21 GMT):
done @jeffgarratt

jeffgarratt (Sat, 04 Nov 2017 02:34:28 GMT):
thank you!!!

jeffgarratt (Sat, 04 Nov 2017 02:34:28 GMT):
@muralisr thank you!!!

jeffgarratt (Sat, 04 Nov 2017 02:34:35 GMT):
also, I commented as discussed

mastersingh24 (Sat, 04 Nov 2017 10:26:53 GMT):
Trivial - https://gerrit.hyperledger.org/r/14979 @kostas @jyellick

mastersingh24 (Sat, 04 Nov 2017 10:27:47 GMT):
Trivial: https://gerrit.hyperledger.org/r/15153

mastersingh24 (Sat, 04 Nov 2017 13:40:35 GMT):
Fairly trivial: https://gerrit.hyperledger.org/r/10065 (rebased an old CR from Liam)

mastersingh24 (Sat, 04 Nov 2017 13:44:03 GMT):
Trivial: https://gerrit.hyperledger.org/r/15193 (eliminates the download status log messages from CI when maven pulls from repos)

smithbk (Sat, 04 Nov 2017 21:39:48 GMT):
https://gerrit.hyperledger.org/r/#/c/14963/ - update swagger doc (needs one more +2) @jimthematrix https://gerrit.hyperledger.org/r/#/c/15089/ - Just adding netcat to some fabric-ca images (easy review) https://gerrit.hyperledger.org/r/#/c/14855/ - Using netcat to fix timing issue in fabric-ca sample (pretty easy)

baohua (Sun, 05 Nov 2017 01:00:20 GMT):
A simple fix (9 weeks ago) on method naming: https://gerrit.hyperledger.org/r/#/c/13077/, welcome to help review

mastersingh24 (Sun, 05 Nov 2017 13:50:19 GMT):
easy one - just adds tests: https://gerrit.hyperledger.org/r/10065

muralisr (Sun, 05 Nov 2017 16:55:29 GMT):
looking @mastersingh24

baohua (Mon, 06 Nov 2017 02:11:14 GMT):
easy one: https://gerrit.hyperledger.org/r/#/c/13077/, having +1, waiting for +2, thanks!

mastersingh24 (Mon, 06 Nov 2017 10:17:40 GMT):
@baohua - I did have a comments on the name

mastersingh24 (Mon, 06 Nov 2017 10:17:40 GMT):
@baohua - I did have a comment on the name

baohua (Mon, 06 Nov 2017 13:05:30 GMT):
@mastersingh24 oh, sorry, just find, will fix

baohua (Mon, 06 Nov 2017 13:05:33 GMT):
thansk

baohua (Mon, 06 Nov 2017 13:05:33 GMT):
thanks

muralisr (Mon, 06 Nov 2017 14:32:02 GMT):
@mastersingh24 couldn't get to https://gerrit.hyperledger.org/r/10065 over the weekend (was spent on something else :-) )... will try to get to it tonight if not already taken

mastersingh24 (Mon, 06 Nov 2017 14:39:49 GMT):
No problem. It's pretty simple - I just rebased some tests created by Liam. Minimal amount of code to review

sanchezl (Mon, 06 Nov 2017 15:48:56 GMT):
https://gerrit.hyperledger.org/r/c/15207/ – (some fixes needed in java chaincode that still remains in fabric repository)

sanchezl (Mon, 06 Nov 2017 15:48:56 GMT):
https://gerrit.hyperledger.org/r/c/15207/ – (some fixes needed in the java chaincode shim that still remains in fabric repository)

divyank (Mon, 06 Nov 2017 16:15:15 GMT):
Updates baseimage to include Go 1.9.2: https://gerrit.hyperledger.org/r/c/15143/

muralisr (Mon, 06 Nov 2017 16:32:00 GMT):
thanks for the +1 @sanchezl .. let me add other maintainers for follow up review and (hopefully) +2 :-)

Ratnakar (Mon, 06 Nov 2017 16:49:14 GMT):
one more +2 please https://gerrit.hyperledger.org/r/#/c/15121/

Ratnakar (Mon, 06 Nov 2017 18:40:14 GMT):
small one https://gerrit.hyperledger.org/r/#/c/15229/

boliang (Tue, 07 Nov 2017 04:53:10 GMT):
https://gerrit.hyperledger.org/r/#/c/15217/ This CR adds chaincodeAddress to peer

baohua (Tue, 07 Nov 2017 06:12:35 GMT):
small change, welcome to give comments: https://gerrit.hyperledger.org/r/#/c/12735/

muralisr (Tue, 07 Nov 2017 15:21:05 GMT):
@boliang +1ed for now and added a few more revieers

smithbk (Tue, 07 Nov 2017 17:12:18 GMT):
Needs one more +2 pls ... https://gerrit.hyperledger.org/r/#/c/14855/ - Fix timing issue in fabric-ca sample

jyellick (Tue, 07 Nov 2017 17:36:17 GMT):
https://gerrit.hyperledger.org/r/#/c/15019 https://gerrit.hyperledger.org/r/#/c/15021 https://gerrit.hyperledger.org/r/#/c/15023 Each have one +2, none are new features, all are code cleanup and test coverage related.

muralisr (Tue, 07 Nov 2017 18:33:42 GMT):
@jyellick will look if not already taken

Baha-sk (Tue, 07 Nov 2017 19:21:29 GMT):
Has joined the channel.

Baha-sk (Tue, 07 Nov 2017 21:47:54 GMT):
https://gerrit.hyperledger.org/r/14897

Baha-sk (Tue, 07 Nov 2017 21:47:54 GMT):
scc to scc invocation fix in Fabric: https://gerrit.hyperledger.org/r/14897 please review and provide +2 if you can

boliang (Wed, 08 Nov 2017 01:10:06 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=4AYphdscBK5HeunuT) @muralisr Thanks.

smithbk (Wed, 08 Nov 2017 14:48:44 GMT):
Really easy one ... a doc update. Needs 1 more +2. https://gerrit.hyperledger.org/r/#/c/15233/

Baha-sk (Wed, 08 Nov 2017 14:50:16 GMT):
hi all.. need +2 for this fix please, unit tests were added to confirm scc to scc invoke works without a channel: https://gerrit.hyperledger.org/r/14897 thanks.

rennman (Wed, 08 Nov 2017 19:41:42 GMT):
need +2 https://gerrit.hyperledger.org/r/#/c/14721/ # increased timeout addresses CI build failures on slow VMs https://gerrit.hyperledger.org/r/#/c/15105/ # (this one is holding up https://gerrit.hyperledger.org/r/#/c/15101/)

mastersingh24 (Wed, 08 Nov 2017 19:45:40 GMT):
@rennman - you need to fix https://gerrit.hyperledger.org/r/14721 - cannot be merged - looks like it's dependent on something missing

rennman (Wed, 08 Nov 2017 19:46:50 GMT):
arg .. ok, I'll address it ... thanks

Baha-sk (Wed, 08 Nov 2017 19:50:17 GMT):
https://gerrit.hyperledger.org/r/#/c/15165/ has broken my commit (https://gerrit.hyperledger.org/r/14897) will rebase and push another patch... guys I will need your help to +2 this once done

Baha-sk (Wed, 08 Nov 2017 19:58:29 GMT):
https://gerrit.hyperledger.org/r/#/c/14897/ rebased...

rameshthoomu (Wed, 08 Nov 2017 20:51:13 GMT):
@kostas @greg.haskins I see zookeeper version reference has been updated to 3.4.10 from 3.4.9. I see most of the builds are failing with 404 not found error.. https://gerrit.hyperledger.org/r/#/c/15319/

rameshthoomu (Wed, 08 Nov 2017 20:51:13 GMT):
@kostas @greg.haskins @mastersingh24 I see zookeeper version reference has been updated to 3.4.10 from 3.4.9. I see most of the builds are failing with 404 not found error.. https://gerrit.hyperledger.org/r/#/c/15319/

yacovm (Wed, 08 Nov 2017 21:14:28 GMT):

Clipboard - November 8, 2017 11:14 PM

yacovm (Wed, 08 Nov 2017 21:14:53 GMT):
just saying.... :arrow_up:

rjones (Wed, 08 Nov 2017 21:20:08 GMT):
@yacovm what are you *just saying*?

yacovm (Wed, 08 Nov 2017 21:20:46 GMT):
That if we have cached versions of dependecies

yacovm (Wed, 08 Nov 2017 21:20:52 GMT):
Life would be good :wink:

rjones (Wed, 08 Nov 2017 21:22:12 GMT):
I don't get that from that screenshot.

yacovm (Wed, 08 Nov 2017 21:29:02 GMT):
Thays what i meant though

rennman (Wed, 08 Nov 2017 21:38:56 GMT):
@mastersingh24 @smithbk https://gerrit.hyperledger.org/r/#/c/14721/ has been re-based and passed CI

rameshthoomu (Wed, 08 Nov 2017 21:45:04 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=Kah2pLFdohBytPLRS) need quick review on this patch..

rjones (Wed, 08 Nov 2017 22:20:02 GMT):
guys we need https://gerrit.hyperledger.org/r/#/c/15319/ merged to unbreak CI

smithbk (Wed, 08 Nov 2017 22:22:18 GMT):
@rjones +2'ed

rjones (Wed, 08 Nov 2017 22:24:17 GMT):
thank you

muralisr (Wed, 08 Nov 2017 22:25:40 GMT):
done @rjones

rjones (Wed, 08 Nov 2017 22:26:14 GMT):
thank you!

muralisr (Wed, 08 Nov 2017 22:26:27 GMT):
of course!

rjones (Wed, 08 Nov 2017 22:28:08 GMT):
a lot of changes will need rebased: https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric+label:verified%253C1

rjones (Wed, 08 Nov 2017 22:28:08 GMT):
14 changes will need rebased: https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric+label:verified%253C1

jimthematrix (Thu, 09 Nov 2017 02:51:28 GMT):
https://gerrit.hyperledger.org/r/#/c/15251/ - upgrading node SDK support to node.js LTS 8.9.0

aambati (Thu, 09 Nov 2017 15:51:36 GMT):
@mastersingh24 @jimthematrix can you please review https://gerrit.hyperledger.org/r/c/13687/ (added steps to generate crl and update channel to the fabric-ca sample) and https://gerrit.hyperledger.org/r/c/13887/ (added gencrl option to the revoke command)...these two have been sitting there for a while..i appreciate if you review and give +2 if you are satisfied...Keith has already +2ed them

rameshthoomu (Thu, 09 Nov 2017 16:29:19 GMT):
@scottz updated node js version to 8.9.0 in fabric-test repo https://gerrit.hyperledger.org/r/#/c/15341/

muralisr (Thu, 09 Nov 2017 16:52:25 GMT):
@sanchezl @jimthematrix @mastersingh24 the java CRs @https://gerrit.hyperledger.org/r/#/c/15207/ and https://gerrit.hyperledger.org/r/#/c/15205/ are good to go as the dependent CRs are in

Baha-sk (Thu, 09 Nov 2017 18:20:07 GMT):
@mastersingh24 @muralisr @jimthematrix https://gerrit.hyperledger.org/r/#/c/14919/ needs to be revisited, it overrode part of core/chaincode/handler.go of https://gerrit.hyperledger.org/r/#/c/15165/

nickgaski (Thu, 09 Nov 2017 19:34:24 GMT):
this is any easy but important one; the CLI chaincode volume mounting has been changed so the manual instructions need to be updated - https://gerrit.hyperledger.org/r/#/c/15329/

bstasyszyn (Thu, 09 Nov 2017 21:22:34 GMT):
https://gerrit.hyperledger.org/r/#/c/14791/ - Implements private data methods in mock stubs

jimthematrix (Thu, 09 Nov 2017 21:54:41 GMT):
@bretharrison @davidkel trivial one https://gerrit.hyperledger.org/r/#/c/15343/ so that npm publication entry on npmjs.com will have a meaningful page

bretharrison (Thu, 09 Nov 2017 21:56:11 GMT):
@jimthematrix all set

Baha-sk (Thu, 09 Nov 2017 22:27:28 GMT):
scc to scc chainless invocation fix: https://gerrit.hyperledger.org/r/15363

baohua (Fri, 10 Nov 2017 15:38:23 GMT):
easy one, welcome to review: https://gerrit.hyperledger.org/r/#/c/13077/

rennman (Fri, 10 Nov 2017 16:38:44 GMT):
@mastersingh24 or anyone willing to take look ... +2 after re-basing ... ready to merge https://gerrit.hyperledger.org/r/14721

Ratnakar (Fri, 10 Nov 2017 18:31:32 GMT):
trivial one https://gerrit.hyperledger.org/r/#/c/15377/

mastersingh24 (Fri, 10 Nov 2017 21:48:18 GMT):
Trivial but important NodeSDK changes for master and release branches: https://gerrit.hyperledger.org/r/#/q/project:fabric-sdk-node+owner:%22Gari+Singh+%253Cgari.r.singh%2540gmail.com%253E%22+status:open

yacovm (Fri, 10 Nov 2017 22:39:30 GMT):
@mastersingh24 I merged the version but have a comment on the function switch

mastersingh24 (Sun, 12 Nov 2017 14:04:22 GMT):
https://gerrit.hyperledger.org/r/15411 - this will fix the CI failures (the sampleconfig certs expired yesterday)

mastersingh24 (Sun, 12 Nov 2017 22:49:36 GMT):
https://gerrit.hyperledger.org/r/15421 - this will fix the NodeSDK failure in the e2e CI job

boliang (Mon, 13 Nov 2017 03:36:51 GMT):
Welcome to review https://gerrit.hyperledger.org/r/#/c/15217/

mastersingh24 (Mon, 13 Nov 2017 12:37:40 GMT):
Phew - what a nightmare - expired certs all over the place leading to CI failures. Ugh. Soooo ........ @rickr - hopefully https://gerrit.hyperledger.org/r/15429 will pass and you can merge then hopefully https://gerrit.hyperledger.org/r/15411 will pass e2e then everyone gets to rebase. Fun times ahead folks

mastersingh24 (Mon, 13 Nov 2017 12:37:40 GMT):
Phew - what a nightmare - expired certs all over the place leading to CI failures. Ugh. Soooo ........ @rickr - hopefully https://gerrit.hyperledger.org/r/15429 will pass and you can merge. Then hopefully https://gerrit.hyperledger.org/r/15411 will pass e2e. Then everyone gets to rebase. Fun times ahead folks!

rickr (Mon, 13 Nov 2017 14:04:20 GMT):
Merged thanks @mastersingh24 . @ashutosh_kumar was just asking me on Friday if the JSDK was catching expired certs :) Looks like he has his negative validation testcase already written for him :)

mastersingh24 (Mon, 13 Nov 2017 14:56:49 GMT):
Indeed - that part works for sure ;)

divyank (Mon, 13 Nov 2017 21:01:42 GMT):
Release base image with Go 1.9.2 : https://gerrit.hyperledger.org/r/c/15143

sstone1 (Mon, 13 Nov 2017 22:26:09 GMT):
Has joined the channel.

sstone1 (Mon, 13 Nov 2017 22:26:36 GMT):
fix `docker-compose-e2e.yaml` provided with `byfn.sh` so it works with the script: https://gerrit.hyperledger.org/r/#/c/15453

baohua (Tue, 14 Nov 2017 02:26:47 GMT):
2 easy patchsets: https://gerrit.hyperledger.org/r/#/c/13077/, https://gerrit.hyperledger.org/r/12735, welcome to review :)

adc (Tue, 14 Nov 2017 13:23:28 GMT):
Hi All, please, some love to https://gerrit.hyperledger.org/r/#/c/12455/ Thanks :)

adc (Tue, 14 Nov 2017 13:24:18 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=bFTXvKXDXrFo65H2s) @mastersingh24 shall we have a mechanism to generate them on the fly?

adc (Tue, 14 Nov 2017 13:24:32 GMT):
For that we could leverage cryptogen :)

yacovm (Tue, 14 Nov 2017 13:33:00 GMT):
@adc we

yacovm (Tue, 14 Nov 2017 13:33:00 GMT):
@adc we're covered for the next 10 years

yacovm (Tue, 14 Nov 2017 13:33:28 GMT):
we just need to remember to re-generate them in 2027 and we're good

Chandraamit (Tue, 14 Nov 2017 16:39:08 GMT):
Has joined the channel.

knagware9 (Tue, 14 Nov 2017 16:40:48 GMT):
Has joined the channel.

Baha-sk (Tue, 14 Nov 2017 17:46:26 GMT):
https://gerrit.hyperledger.org/r/c/15363/ has been updated with minor refactoring and rebasing..

Baha-sk (Tue, 14 Nov 2017 22:02:58 GMT):
https://gerrit.hyperledger.org/r/15363 is now finally built successfully, please have a look and like it if you can

rjones (Tue, 14 Nov 2017 22:38:40 GMT):
@yacovm that logic is exactly how I ended up spamming a ton of cell phones in Europe. "this mute logic will work for ten years!"

yacovm (Tue, 14 Nov 2017 22:39:36 GMT):
heh, I was joking of course :)

yacovm (Tue, 14 Nov 2017 23:03:27 GMT):
FWIW in my UTs all the certs are generated at runtime

adc (Wed, 15 Nov 2017 10:29:13 GMT):
Hi All, please some additional love to https://gerrit.hyperledger.org/r/#/c/12455/ and https://gerrit.hyperledger.org/r/#/c/12459/ :)

yacovm (Wed, 15 Nov 2017 10:41:53 GMT):
@adc the commit https://gerrit.hyperledger.org/r/#/c/12459/ is rebased not on top of the latest https://gerrit.hyperledger.org/r/#/c/12455/

yacovm (Wed, 15 Nov 2017 10:41:53 GMT):
@adc the commit https://gerrit.hyperledger.org/r/#/c/12459/ is rebased not on top of the latest https://gerrit.hyperledger.org/r/#/c/12455/ just FYI

adc (Wed, 15 Nov 2017 11:01:21 GMT):
is the rebase necessary?

adc (Wed, 15 Nov 2017 11:01:33 GMT):
there is not conflict

yacovm (Wed, 15 Nov 2017 11:08:36 GMT):
it's not necessary but it's safer since the change set was lastly built 5 days ago...

adc (Wed, 15 Nov 2017 13:38:34 GMT):
okay, rebased

nickgaski (Wed, 15 Nov 2017 19:47:21 GMT):
Need one more here - https://gerrit.hyperledger.org/r/#/c/15327/

nickgaski (Wed, 15 Nov 2017 19:47:53 GMT):
And this is the new doc for reconfigure of BYFN - https://gerrit.hyperledger.org/r/#/c/15323/

nickgaski (Wed, 15 Nov 2017 19:48:00 GMT):
They need to go together

adc (Thu, 16 Nov 2017 08:00:53 GMT):
Hi All, please, have a look to https://gerrit.hyperledger.org/r/#/c/15483/ Thanks :)

baohua (Thu, 16 Nov 2017 08:17:19 GMT):
welcome to have some quick review: https://gerrit.hyperledger.org/r/#/c/12735/

C0rWin (Thu, 16 Nov 2017 09:11:06 GMT):
Hi, https://gerrit.hyperledger.org/r/#/c/15237/, needs one more +2 :)

Baha-sk (Thu, 16 Nov 2017 13:14:38 GMT):
hi all, https://gerrit.hyperledger.org/r/15363 needs another +2 please..

cbf (Thu, 16 Nov 2017 14:24:23 GMT):
need one more vote on https://jira.hyperledger.org/browse/FAB-6590 please

yacovm (Thu, 16 Nov 2017 14:25:04 GMT):
I'd vote but JIRA enforces double spending

yacovm (Thu, 16 Nov 2017 14:25:04 GMT):
I'd vote (again) but JIRA enforces double spending

cbf (Thu, 16 Nov 2017 14:32:13 GMT):
;-)

cbf (Thu, 16 Nov 2017 14:32:36 GMT):
@C0rWin I merged but didn't close the JIRA as I am not sure if it is complete

C0rWin (Thu, 16 Nov 2017 14:33:20 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=EWxcejiw2h57A9e3Z) @cbf thanks, this is complete...

C0rWin (Thu, 16 Nov 2017 14:33:25 GMT):
I will close the JIRA

nickgaski (Thu, 16 Nov 2017 15:35:48 GMT):
por favor - https://gerrit.hyperledger.org/r/#/c/15327 && https://gerrit.hyperledger.org/r/#/c/15323

baohua (Fri, 17 Nov 2017 02:07:05 GMT):
need one more +2: https://gerrit.hyperledger.org/r/#/c/13077/, thanks

rameshthoomu (Fri, 17 Nov 2017 14:42:32 GMT):
@scottz https://gerrit.hyperledger.org/r/#/c/15563/ trivial update

harsha (Fri, 17 Nov 2017 15:09:48 GMT):
need one more +2 : https://gerrit.hyperledger.org/r/#/c/15533/

jimthematrix (Fri, 17 Nov 2017 16:09:55 GMT):
https://gerrit.hyperledger.org/r/#/c/15549/ - adding encryption library for node.js chaincode

nickgaski (Fri, 17 Nov 2017 17:01:27 GMT):
https://gerrit.hyperledger.org/r/#/c/15323/ - the code for this is in. Can we add the doc please?

sstone1 (Fri, 17 Nov 2017 19:47:01 GMT):
can somebody review this one please? we need a BYFN CA example working so that we can publish a new Composer tutorial which shows you how to combine the two: https://gerrit.hyperledger.org/r/c/15453

sstone1 (Fri, 17 Nov 2017 19:47:01 GMT):
can somebody review this one please? we need a BYFN w/ CA example working so that we can publish a new Composer tutorial which shows you how to combine the two: https://gerrit.hyperledger.org/r/c/15453

wlahti (Fri, 17 Nov 2017 20:51:50 GMT):
https://gerrit.hyperledger.org/r/#/c/15221/ - updates a previously incorrect comment about chaincode events

smithbk (Sun, 19 Nov 2017 03:42:02 GMT):
For fabric-ca:

smithbk (Sun, 19 Nov 2017 03:42:05 GMT):
https://gerrit.hyperledger.org/r/#/c/15487/ - Add troubleshooting tip (doc only) https://gerrit.hyperledger.org/r/#/c/15439/ - Fix cert/key paths with --cacount https://gerrit.hyperledger.org/r/#/c/15373/ - Remove non-existent files from yaml https://gerrit.hyperledger.org/r/#/c/15353/ - Improve GetID function in cid library (Gari) https://gerrit.hyperledger.org/r/#/c/15139/ - Set OUs in ECerts (need another +2) https://gerrit.hyperledger.org/r/#/c/15269/ - 1. Dynamic Config Identities CLI https://gerrit.hyperledger.org/r/#/c/15277/ - 2. Dynamic Config Identities CLI(2) https://gerrit.hyperledger.org/r/#/c/15279/ - 3. Dynamic Config Identities GetIDs https://gerrit.hyperledger.org/r/#/c/15281/ - 4. Dynamic Config Identities Add/Remove https://gerrit.hyperledger.org/r/#/c/15283/ - 5. Dynamic Config Identities Modify

manxiaqu (Mon, 20 Nov 2017 06:34:51 GMT):
Has joined the channel.

manxiaqu (Mon, 20 Nov 2017 06:35:43 GMT):
https://gerrit.hyperledger.org/r/#/c/14629/ - Support the MongoDB as the stateDB

adc (Mon, 20 Nov 2017 08:36:16 GMT):
Another bit of love to https://gerrit.hyperledger.org/r/#/c/12455/ please :)

nickgaski (Mon, 20 Nov 2017 14:05:05 GMT):
Doc for reconfig of BYFN - https://gerrit.hyperledger.org/r/#/c/15323/

jimthematrix (Mon, 20 Nov 2017 14:39:50 GMT):
@adc @mastersingh24 can you please review https://gerrit.hyperledger.org/r/#/c/15549/? note that documentation will be submitted in a separate CR

rameshthoomu (Mon, 20 Nov 2017 14:50:51 GMT):
Builds are failing with KAFKA VERSION unavailability https://gerrit.hyperledger.org/r/#/c/15593/

mastersingh24 (Mon, 20 Nov 2017 21:46:41 GMT):
This poor little guy has been trying to make the cut since June: https://gerrit.hyperledger.org/r/10065

mastersingh24 (Mon, 20 Nov 2017 21:52:36 GMT):
These four could use one more +2 each: https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open

cbf (Tue, 21 Nov 2017 18:09:15 GMT):
@mastersingh24 @greg.haskins https://gerrit.hyperledger.org/r/c/15637/

jyellick (Tue, 21 Nov 2017 18:19:14 GMT):
https://gerrit.hyperledger.org/r/c/14895/ needs one more +2, just tests, has been out there for a few weeks

kostas (Tue, 21 Nov 2017 21:58:00 GMT):
https://gerrit.hyperledger.org/r/c/15643/

muralisr (Tue, 21 Nov 2017 22:13:58 GMT):
fixes a doc problem https://gerrit.hyperledger.org/r/#/c/15619/

nickgaski (Wed, 22 Nov 2017 13:50:26 GMT):
let there be a thanksgiving miracle and this guy get merged; the accompanying code went in over a week ago - https://gerrit.hyperledger.org/r/#/c/15323/

sstone1 (Wed, 22 Nov 2017 13:52:21 GMT):
on a related note, @cbf what more do i need to do with this? does it need another +2? it says "ready to submit" but i don't see a "submit" button https://gerrit.hyperledger.org/r/c/15453

mastersingh24 (Wed, 22 Nov 2017 14:24:35 GMT):
@sstone1 - see my comments on the CR (https://chat.hyperledger.org/channel/fabric-pr-review?msg=4SZ9rembEJnYHe6MN) @sstone1

sstone1 (Wed, 22 Nov 2017 14:37:29 GMT):
@mastersingh24 ah, thanks - replied in the JIRA but can i add a `docker-compose-cas.yaml` instead?

sstone1 (Wed, 22 Nov 2017 14:38:07 GMT):
i just want a network that's easy to start with byfn.sh and includes the Fabric CA :)

skarim (Wed, 22 Nov 2017 14:45:56 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/15613/

cbf (Wed, 22 Nov 2017 17:55:00 GMT):
https://gerrit.hyperledger.org/r/c/15669/ please see my review comment

sstone1 (Wed, 22 Nov 2017 19:13:41 GMT):
pushed a (hopefully) more acceptable change for `byfn.sh` that adds a `-a` flag to optionally start the Fabric CAs: https://gerrit.hyperledger.org/r/#/c/15671/

yacovm (Wed, 22 Nov 2017 21:56:04 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/15577/ Dynamic TLS certificate updates

yacovm (Wed, 22 Nov 2017 21:56:04 GMT):
~ Easy one https://gerrit.hyperledger.org/r/#/c/15577/ Dynamic TLS certificate updates ~

ysim (Wed, 22 Nov 2017 23:07:59 GMT):
Has joined the channel.

ysim (Wed, 22 Nov 2017 23:09:02 GMT):
tiny doc change: https://gerrit.hyperledger.org/r/#/c/15679 (apologies for how trivial it is, this was just me trying to get acquainted with the gerrit/git-review workflow)

yacovm (Wed, 22 Nov 2017 23:19:11 GMT):
No problem, the trivial ones are also useful. Thanks for the effort.

divyank (Thu, 23 Nov 2017 14:05:28 GMT):
Releases base image with Go 1.9.2 https://gerrit.hyperledger.org/r/#/c/15143/

ysim (Thu, 23 Nov 2017 16:19:21 GMT):
Is there anything I need to do once my change has gotten the appropriate number of reviews?

ysim (Thu, 23 Nov 2017 17:17:06 GMT):
Never mind! I just saw a comment posted about creating a JIRA entry.

ysim (Thu, 23 Nov 2017 17:49:44 GMT):
Amended my commit and pushed it up again: https://gerrit.hyperledger.org/r/#/c/15679/ Thanks for being so patient!

firas.qutishat (Thu, 23 Nov 2017 18:45:25 GMT):
configurable pulling of cc base images https://gerrit.hyperledger.org/r/#/c/15695/

nickgaski (Thu, 23 Nov 2017 19:47:26 GMT):
if anyone is feeling charitable - https://gerrit.hyperledger.org/r/#/c/15323/

jackeyliliang (Fri, 24 Nov 2017 03:00:20 GMT):
Has joined the channel.

harsha (Fri, 24 Nov 2017 11:17:06 GMT):
Introducing mongodb as stateDB via https://gerrit.hyperledger.org/r/#/c/14629/ , please help review.

skarim (Mon, 27 Nov 2017 14:48:55 GMT):
Please review the following fabric-ca dynamic configuration update change sets: https://gerrit.hyperledger.org/r/#/c/15277/ https://gerrit.hyperledger.org/r/#/c/15279/ https://gerrit.hyperledger.org/r/#/c/15281/ https://gerrit.hyperledger.org/r/#/c/15283/

nickgaski (Mon, 27 Nov 2017 14:55:37 GMT):
here's my daily panhandling for the reconfig doc - https://gerrit.hyperledger.org/r/#/c/15323/

sstone1 (Mon, 27 Nov 2017 15:06:51 GMT):
and mine for adding CA support to byfn: https://gerrit.hyperledger.org/r/#/c/15671/

bstasyszyn (Mon, 27 Nov 2017 16:05:00 GMT):
Please review https://gerrit.hyperledger.org/r/#/c/14791/

cbf (Mon, 27 Nov 2017 16:26:43 GMT):
https://gerrit.hyperledger.org/r/c/15669/ needs to have majority maintainers +1 ing because it is changing the default mainatiners list

cbf (Mon, 27 Nov 2017 19:12:11 GMT):
@here ^^ please

cbf (Mon, 27 Nov 2017 19:15:05 GMT):
also too https://gerrit.hyperledger.org/r/c/15681/

cbf (Mon, 27 Nov 2017 20:12:00 GMT):
https://gerrit.hyperledger.org/r/c/15637/ please

C0rWin (Mon, 27 Nov 2017 21:26:19 GMT):
https://gerrit.hyperledger.org/r/#/c/15579/ a small gossip improvement allows to prevent sending same message back to the sender, requires a last +2

yacovm (Tue, 28 Nov 2017 11:37:44 GMT):
https://gerrit.hyperledger.org/r/#/c/12419/ just introducing a disabled unit test

yacovm (Tue, 28 Nov 2017 11:37:44 GMT):
https://gerrit.hyperledger.org/r/#/c/12419/ just re-introducing a disabled unit test

mastersingh24 (Tue, 28 Nov 2017 12:26:11 GMT):
https://gerrit.hyperledger.org/r/15703 - easy one

C0rWin (Tue, 28 Nov 2017 13:34:43 GMT):
https://gerrit.hyperledger.org/r/#/c/15763/ scheduled code cleanups :)

C0rWin (Tue, 28 Nov 2017 13:35:01 GMT):
https://gerrit.hyperledger.org/r/#/c/15759/ another one

adc (Tue, 28 Nov 2017 14:02:49 GMT):
Hi All, some love to https://gerrit.hyperledger.org/r/#/c/15721/, please :)

adc (Tue, 28 Nov 2017 14:02:49 GMT):
Hi All, some love to https://gerrit.hyperledger.org/r/#/c/15721/, https://gerrit.hyperledger.org/r/#/c/12455/ and https://gerrit.hyperledger.org/r/#/c/15483/ please :)

aleksandar.likic (Tue, 28 Nov 2017 16:40:04 GMT):
https://gerrit.hyperledger.org/r/#/c/14791/ - a simple extension of MockStub to support Private Data functions. Important for test cases that involve Private Data. It's a small change, please review. Thanks.

cbf (Tue, 28 Nov 2017 18:43:51 GMT):
https://gerrit.hyperledger.org/r/c/15781/ restores bootstrap-1.1.0-preview.sh to master branch because the v1.1.0-preview docs reference that file in master

cbf (Tue, 28 Nov 2017 18:44:07 GMT):
needs to be restored until the docs are updated for 1.1.0-alpha

C0rWin (Tue, 28 Nov 2017 22:33:14 GMT):
https://gerrit.hyperledger.org/r/#/c/15759/, https://gerrit.hyperledger.org/r/#/c/15763/ - needs last +2

adc (Wed, 29 Nov 2017 07:47:56 GMT):
please, please, some love to https://gerrit.hyperledger.org/r/#/dashboard/self :)

C0rWin (Wed, 29 Nov 2017 07:58:39 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=SGAkSHWrrhLQKqgDF) @adc for each one this link is going to show his own CR's :) can you probably be more specific?

adc (Wed, 29 Nov 2017 07:58:58 GMT):
oh sorry

adc (Wed, 29 Nov 2017 07:58:59 GMT):
hehehehe

adc (Wed, 29 Nov 2017 07:59:13 GMT):
this one, please https://gerrit.hyperledger.org/r/#/c/12455/ :)

adc (Wed, 29 Nov 2017 12:52:33 GMT):
also https://gerrit.hyperledger.org/r/#/c/12459/, please :)

smithbk (Wed, 29 Nov 2017 14:29:30 GMT):
Pls help with these:

smithbk (Wed, 29 Nov 2017 14:29:33 GMT):
https://gerrit.hyperledger.org/r/#/c/15487 - [FAB-6993] Add troubleshooting tip https://gerrit.hyperledger.org/r/#/c/15373 - [FAB-5462] Remove non-existent files from yaml https://gerrit.hyperledger.org/r/#/c/14841 - [FAB-6321] Store CA certs in child-first order https://gerrit.hyperledger.org/r/#/c/15277 - [FAB-5726] 2. Dynamic Config Identities CLI(2) https://gerrit.hyperledger.org/r/#/c/15279 - [FAB-5726] 3. Dynamic Config Identities GetIDs https://gerrit.hyperledger.org/r/#/c/15281 - [FAB-5726] 4. Dynamic Config Identities Add/Remove https://gerrit.hyperledger.org/r/#/c/15283 - [FAB-5726] 5. Dynamic Config Identities Modify

troyronda (Wed, 29 Nov 2017 15:35:34 GMT):
small fix to check_license.sh to include newly added files in the CI check for licenses: https://gerrit.hyperledger.org/r/c/15795/

sstone1 (Wed, 29 Nov 2017 20:34:38 GMT):
update byfn.sh to optionally start Fabric CAs for the network: https://gerrit.hyperledger.org/r/c/15671/

nickgaski (Wed, 29 Nov 2017 22:25:49 GMT):
shows you how to add a new org to the default channel in the BYFN scenario - https://gerrit.hyperledger.org/r/#/c/15323/

mastersingh24 (Thu, 30 Nov 2017 09:24:00 GMT):
Trivial change: https://gerrit.hyperledger.org/r/15817 (needs one more +2)

cbf (Thu, 30 Nov 2017 17:26:04 GMT):
https://gerrit.hyperledger.org/r/c/15637/ please esp @greg.haskins @mastersingh24

rjones (Thu, 30 Nov 2017 20:19:44 GMT):
could I get this merged before I change the merge policy? thanks. https://gerrit.hyperledger.org/r/#/c/15847/

yacovm (Thu, 30 Nov 2017 22:15:09 GMT):
https://gerrit.hyperledger.org/r/#/c/15769/ this fixes the peer from crashing on `peer node start`

dsanchezseco (Fri, 01 Dec 2017 12:38:24 GMT):
Can someone give me a crash course on how to make a PR over a specific tag?

dsanchezseco (Fri, 01 Dec 2017 12:39:36 GMT):
i've found that the curl to download the daocker images on the v1.1.0-preview is 404 and i've found the replacement with this one https://goo.gl/6xS3cd

mastersingh24 (Fri, 01 Dec 2017 13:29:05 GMT):
unfortunately, there is really no way to do that

mastersingh24 (Fri, 01 Dec 2017 13:29:31 GMT):
well no easy way to do that I should say. let me see what happened to the think :(

yacovm (Fri, 01 Dec 2017 13:40:57 GMT):
https://gerrit.hyperledger.org/r/#/c/15427/ decouple TLS in chaincode service @mastersingh24 , @muralisr

yacovm (Fri, 01 Dec 2017 13:40:57 GMT):
https://gerrit.hyperledger.org/r/#/c/15427/ ecouple peer native TLS and shim @mastersingh24 , @muralisr

yacovm (Fri, 01 Dec 2017 13:40:57 GMT):
https://gerrit.hyperledger.org/r/#/c/15427/ decouple peer native TLS and shim @mastersingh24 , @muralisr

mastersingh24 (Sat, 02 Dec 2017 17:01:32 GMT):
easy one (just improves testing) https://gerrit.hyperledger.org/r/15857

sstone1 (Sun, 03 Dec 2017 22:55:05 GMT):
please can someone review this? update byfn.sh to optionally start Fabric CAs for the network: https://gerrit.hyperledger.org/r/c/15671

mastersingh24 (Mon, 04 Dec 2017 14:20:25 GMT):
2 easy ones (backports) needed for the v1.0.5 release?

yacovm (Mon, 04 Dec 2017 14:21:22 GMT):
Didn't know invisible gerrit items are a thing, @mastersingh24

skarim (Mon, 04 Dec 2017 15:11:11 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/14933/ https://gerrit.hyperledger.org/r/#/c/14935/

cbf (Mon, 04 Dec 2017 19:12:01 GMT):
https://gerrit.hyperledger.org/r/c/15863/

cbf (Mon, 04 Dec 2017 19:29:12 GMT):
https://gerrit.hyperledger.org/r/c/15323/

joe-alewine (Tue, 05 Dec 2017 14:20:24 GMT):
Conceptual documentation here dealing with identity and membership services: https://gerrit.hyperledger.org/r/c/15933/

mastersingh24 (Tue, 05 Dec 2017 15:00:37 GMT):
One more +2 please: https://gerrit.hyperledger.org/r/15903

mastersingh24 (Tue, 05 Dec 2017 15:00:58 GMT):
Then I'll rebase the last change and we'll be ready to rock and roll with Fabric v1.0.5

mastersingh24 (Tue, 05 Dec 2017 16:01:19 GMT):
Sorry folks - I screwed up - had to rebase https://gerrit.hyperledger.org/r/15903 @dave.enyeart @cbf @yacovm would 2 of you mind +2 again?

mastersingh24 (Tue, 05 Dec 2017 16:02:00 GMT):
Also need this backport for fabric-ca : https://gerrit.hyperledger.org/r/15895

rameshthoomu (Tue, 05 Dec 2017 19:28:24 GMT):
Review this pls https://gerrit.hyperledger.org/r/#/c/15861/

yacovm (Tue, 05 Dec 2017 20:31:27 GMT):
Easy one, just 9 lines of production code. https://gerrit.hyperledger.org/r/#/c/15951/ Make the peer be able to use ordering service nodes behind a load balancer without shooting itself in the foot

rameshthoomu (Tue, 05 Dec 2017 20:50:07 GMT):
trivial fix https://gerrit.hyperledger.org/r/#/c/15969/

cbf (Wed, 06 Dec 2017 10:02:10 GMT):
@rameshthoomu I think Gari already fixed this.

nickgaski (Wed, 06 Dec 2017 12:24:16 GMT):
need one more here - https://gerrit.hyperledger.org/r/#/c/15323/

rameshthoomu (Wed, 06 Dec 2017 16:33:20 GMT):
@mastersingh24 @greg.haskins need your review on https://gerrit.hyperledger.org/r/#/c/15861/ - this improves nearly 7-8 minutes build time in jenkins

greg.haskins (Wed, 06 Dec 2017 16:43:34 GMT):
done

wlahti (Thu, 07 Dec 2017 12:48:29 GMT):
Looking for reviews of these two CRs, which in addition to the previous CR in the series (already merged), enable the deliver service on the peer: https://gerrit.hyperledger.org/r/#/c/16007 https://gerrit.hyperledger.org/r/#/c/16009

grapebaba (Thu, 07 Dec 2017 13:59:52 GMT):
guys,https://gerrit.hyperledger.org/r/#/c/16015/ welcome review, add one more command in cryptogen tool so that it can support generate new artifacts on existing crypto material

skarim (Thu, 07 Dec 2017 15:03:36 GMT):
Please review the following fabric-ca related CRs: https://gerrit.hyperledger.org/r/#/c/14933/ https://gerrit.hyperledger.org/r/#/c/14935/

yacovm (Thu, 07 Dec 2017 23:45:10 GMT):
Can we get 1 more +2 please? https://gerrit.hyperledger.org/r/#/c/16033/ the master branch is broken

yacovm (Thu, 07 Dec 2017 23:45:10 GMT):
~ Can we get 1 more +2 please? https://gerrit.hyperledger.org/r/#/c/16033/ the master branch is broken ~ thanks @JonathanLevi

rjones (Fri, 08 Dec 2017 00:03:20 GMT):
@scottz ^^^

mastersingh24 (Fri, 08 Dec 2017 07:46:48 GMT):
3 easy ones (I hope) - https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open

adc (Fri, 08 Dec 2017 10:16:21 GMT):
Hi all, please, have a look at https://gerrit.hyperledger.org/r/#/c/12459/ :)

nnao (Fri, 08 Dec 2017 18:27:54 GMT):
Please review this https://gerrit.hyperledger.org/r/#/c/15737/ There is a deadlock between fabric and sdk-node. To merge the patches for fabric, it needs to change the test to accept return code 404 in sdk-node(fabric-e2e test executes sdk-node test). To get prepared for the change of test in sdk-node, it needs to change fabric. How can I fix this deadlock?

yacovm (Fri, 08 Dec 2017 18:31:20 GMT):
I guess you modify the SDK to support both

yacovm (Fri, 08 Dec 2017 18:31:27 GMT):
then re-build the fabric

yacovm (Fri, 08 Dec 2017 18:31:27 GMT):
then re-build the fabric change set

yacovm (Fri, 08 Dec 2017 18:31:38 GMT):
then re-program the SDK to support only 1

yacovm (Fri, 08 Dec 2017 18:31:42 GMT):
@nnao ^

yacovm (Fri, 08 Dec 2017 18:32:37 GMT):
but to me, this looks like a fairly large change for the SDK no?

yacovm (Fri, 08 Dec 2017 18:32:37 GMT):
but to me, this looks like a fairly large change for the SDK

yacovm (Fri, 08 Dec 2017 18:32:46 GMT):
it impacts all of error handling in node.js and in java no?

yacovm (Fri, 08 Dec 2017 18:32:46 GMT):
it impacts all of error handling in node.js and in java,

yacovm (Fri, 08 Dec 2017 18:32:55 GMT):
because the SDK uses promises and the java uses exceptions

yacovm (Fri, 08 Dec 2017 18:33:04 GMT):
this looks to me like a huge amount of code change, no?

yacovm (Fri, 08 Dec 2017 18:33:45 GMT):
by the way - I think your CR is what should have been done long, long ago, in the first place

yacovm (Fri, 08 Dec 2017 18:34:20 GMT):
not sure how to proceed at this point though, because it seems like this would make a v1.0 peer be unable to interop with a v1.1 SDK

yacovm (Fri, 08 Dec 2017 18:36:37 GMT):
maybe @muralisr and @jimthematrix can take a look since it is related to their fields (chaincode and SDK)

nnao (Fri, 08 Dec 2017 18:45:30 GMT):
@yacovm Thank you for advice. I will send the patch that supports both. In this patch, only one line is changed.

nnao (Fri, 08 Dec 2017 19:06:52 GMT):
It seems like current integration test of sdk-node does not check the response code.

joe-alewine (Fri, 08 Dec 2017 19:09:25 GMT):
Identity and MSP conceptual doc: https://gerrit.hyperledger.org/r/c/15933/

smithbk (Fri, 08 Dec 2017 20:31:04 GMT):
Need a couple of reviewers for https://gerrit.hyperledger.org/r/#/c/14383 - Sample app written in typescript

smithbk (Fri, 08 Dec 2017 20:31:07 GMT):
thanks

wlahti (Fri, 08 Dec 2017 21:21:47 GMT):
Found a bug in the deliver server logic: https://gerrit.hyperledger.org/r/#/c/16051/ - oops :)

wlahti (Fri, 08 Dec 2017 21:21:47 GMT):
Found a bug in the deliver server logic on the peer: https://gerrit.hyperledger.org/r/#/c/16051/ - oops :)

yacovm (Fri, 08 Dec 2017 21:54:07 GMT):
Nice find, @wlahti ;)

smithbk (Sat, 09 Dec 2017 00:18:09 GMT):
Easy one .. just revendoring: https://gerrit.hyperledger.org/r/#/c/16063/ - revendor cfssl

sstone1 (Sat, 09 Dec 2017 16:56:37 GMT):
please can someone review this? update byfn.sh to optionally start Fabric CAs for the network: https://gerrit.hyperledger.org/r/c/15671

grapebaba (Sun, 10 Dec 2017 15:50:00 GMT):
https://gerrit.hyperledger.org/r/#/c/16015/ @mastersingh24 @greg.haskins hope you guys review this cryptogen patch

joe-alewine (Mon, 11 Dec 2017 15:26:44 GMT):
https://gerrit.hyperledger.org/r/c/15933/ Identity and membership documentation. This was written alongside Anthony O'Dowd and has been looked over by Keith Smith.

guolidong (Tue, 12 Dec 2017 06:09:18 GMT):
Has joined the channel.

mastersingh24 (Tue, 12 Dec 2017 14:27:41 GMT):
easy one(s): https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open

mastersingh24 (Tue, 12 Dec 2017 14:28:33 GMT):
@joe-alewine - is this published to a staging site?

mastersingh24 (Tue, 12 Dec 2017 14:29:11 GMT):
[ Is this hosted on a staging site anywhere? Might be easier to review](https://chat.hyperledger.org/channel/fabric-pr-review?msg=wDYASz7YZrWDLZGcv) @joe-alewine

ysim (Tue, 12 Dec 2017 15:06:56 GMT):
I would love to get some eyes on this. I wasn't totally sure about my modifications to the tests but I'm obviously more than happy to work with someone to improve it. It'll help a lot with Kubernetes deployments. https://gerrit.hyperledger.org/r/#/c/16133/

mastersingh24 (Tue, 12 Dec 2017 15:26:55 GMT):
@ysim - the actual change looks fine. I added a comment as well

mastersingh24 (Tue, 12 Dec 2017 15:27:02 GMT):
We can help with tests if you need it

mastersingh24 (Tue, 12 Dec 2017 15:27:06 GMT):
And thanks for the change

mastersingh24 (Tue, 12 Dec 2017 15:27:11 GMT):
It looks like a good idea

ysim (Tue, 12 Dec 2017 15:29:16 GMT):
@mastersingh24 Thanks for looking at it! Yeah, some pointers for how to test without altering sampleconfig/ would be really great.

mastersingh24 (Tue, 12 Dec 2017 15:37:37 GMT):
sure thing. I'll try to add some additional hints to the CR in Gerrit. Might take a bit of time but will try to do sometime today

ysim (Tue, 12 Dec 2017 15:48:52 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=T5utGJ2eDKs5zoTKL) @mastersingh24 Thank you! :)

rjones (Tue, 12 Dec 2017 20:44:09 GMT):
@wlahti https://gerrit.hyperledger.org/r/16161

rjones (Tue, 12 Dec 2017 20:44:57 GMT):
FAB-7441

cbf (Tue, 12 Dec 2017 22:39:27 GMT):
simple one https://gerrit.hyperledger.org/r/c/16163/

cbf (Tue, 12 Dec 2017 22:39:51 GMT):
@rjones, I fixed that in the CR above

rjones (Tue, 12 Dec 2017 22:53:56 GMT):
@cbf I don't see that change in 16163

rjones (Tue, 12 Dec 2017 22:54:39 GMT):
I don't see any conflicting changes for https://gerrit.hyperledger.org/r/#/c/16161/

wlahti (Wed, 13 Dec 2017 04:20:59 GMT):
Maintainers, many of us Mac users would greatly appreciate reviews of Ry's fix: https://gerrit.hyperledger.org/r/16161

grapebaba (Wed, 13 Dec 2017 09:32:58 GMT):
https://gerrit.hyperledger.org/r/c/16171/

grapebaba (Wed, 13 Dec 2017 09:33:13 GMT):
need one more +2

yacovm (Wed, 13 Dec 2017 10:57:10 GMT):
@mastersingh24 , Kai Chen's change set above adds an ability to extend the cryptogen artifacts after changing the YAML. I gave it a run and it worked for me

mastersingh24 (Wed, 13 Dec 2017 10:57:40 GMT):
I took a quick look before - will look again in a few minutes

mastersingh24 (Wed, 13 Dec 2017 11:13:36 GMT):
done

mastersingh24 (Wed, 13 Dec 2017 11:16:58 GMT):
Easy ones IMHO (same change targeted at master and release) https://gerrit.hyperledger.org/r/16143 https://gerrit.hyperledger.org/r/16145

mastersingh24 (Wed, 13 Dec 2017 11:17:45 GMT):
https://gerrit.hyperledger.org/r/16161 from @rjones as well

mastersingh24 (Wed, 13 Dec 2017 13:27:14 GMT):
Fairly straightforward fabric-ca change from @aambati : https://gerrit.hyperledger.org/r/16085

cbf (Wed, 13 Dec 2017 13:30:21 GMT):
https://gerrit.hyperledger.org/r/c/16163/

ysim (Wed, 13 Dec 2017 18:40:24 GMT):
Have updated my CR to fix the tests so that sampleconfig/ isn't changed: https://gerrit.hyperledger.org/r/#/c/16133/ Would appreciate if someone took a look at it (especially @mastersingh24, thanks for your initial review/comments!)

joe-alewine (Wed, 13 Dec 2017 19:54:40 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=yC8PGisMzSLgaeM5m) @mastersingh24 Quite so, documentation looks terrible in gerrit. I don't have a RTD staging site so I staged the doc in the FabricTOC repo Anthony and I have been working out of: https://github.com/joealewine/FabricTOC/blob/master/docs/RST_Preview/Identitypreview.rst The wording, images, formatting, and file structure (ie, pointing at the image files) are the exactly the same as the CR. Here's the CR itself once again: https://gerrit.hyperledger.org/r/c/15933/

cbf (Wed, 13 Dec 2017 21:06:01 GMT):
yoo hoo https://gerrit.hyperledger.org/r/c/16163/ third time asking is a charm? This is an easy one

yacovm (Wed, 13 Dec 2017 22:19:56 GMT):
Pretty easy one, just a small refactoring https://gerrit.hyperledger.org/r/#/c/16191/

yacovm (Wed, 13 Dec 2017 22:19:56 GMT):
Pretty easy one, just a small refactoring https://gerrit.hyperledger.org/r/#/c/16191/ just 1 more +2 to go :)

mastersingh24 (Thu, 14 Dec 2017 11:46:06 GMT):
Pretty easy fabric-ca one: https://gerrit.hyperledger.org/r/16167 from @aambati

joe-alewine (Thu, 14 Dec 2017 19:04:25 GMT):
Peer commands doc: https://gerrit.hyperledger.org/r/c/16217/

nnao (Fri, 15 Dec 2017 02:03:19 GMT):
https://gerrit.hyperledger.org/r/#/c/16057/

manu (Fri, 15 Dec 2017 12:35:19 GMT):
https://gerrit.hyperledger.org/r/#/c/14541/ is waiting for a second +2, allows using idemix MSP from go CLI

mastersingh24 (Fri, 15 Dec 2017 14:03:20 GMT):
nice one from @sykesm : https://gerrit.hyperledger.org/r/16219

sykesm (Fri, 15 Dec 2017 14:03:20 GMT):
Has joined the channel.

rameshthoomu (Fri, 15 Dec 2017 14:41:31 GMT):
few make targets for CI https://gerrit.hyperledger.org/r/#/c/16221/

nickgaski (Fri, 15 Dec 2017 20:24:15 GMT):
can we throw these two in please - https://gerrit.hyperledger.org/r/#/c/16233/ & https://gerrit.hyperledger.org/r/#/c/16235/

nickgaski (Fri, 15 Dec 2017 20:24:47 GMT):
the first fixes the chaincode-docker-devmode sample, and the second is a tiny doc update for peer address

yacovm (Sun, 17 Dec 2017 07:19:17 GMT):
Really easy one - just 2 lines of production code! https://gerrit.hyperledger.org/r/#/c/16253/

mastersingh24 (Mon, 18 Dec 2017 21:19:24 GMT):
https://gerrit.hyperledger.org/r/16285 https://gerrit.hyperledger.org/r/16287

mastersingh24 (Mon, 18 Dec 2017 21:19:24 GMT):
Easy fabric-ca changes to fix expired certs so tests will pass: https://gerrit.hyperledger.org/r/16285 https://gerrit.hyperledger.org/r/16287

mastersingh24 (Mon, 18 Dec 2017 21:20:25 GMT):
Another easy fabric-ca change to update vendor of viper and remove workaround code: https://gerrit.hyperledger.org/r/16289

troyronda (Mon, 18 Dec 2017 21:33:35 GMT):
small fix to check_license.sh to include newly added files in the CI check for licenses: https://gerrit.hyperledger.org/r/c/15795

yacovm (Tue, 19 Dec 2017 12:00:13 GMT):
https://gerrit.hyperledger.org/r/#/c/16307/ easy one - just removing un-used code

C0rWin (Tue, 19 Dec 2017 12:16:16 GMT):
https://gerrit.hyperledger.org/r/#/c/16305/ same here a small cleanup

mastersingh24 (Tue, 19 Dec 2017 13:20:03 GMT):
easy fix: https://gerrit.hyperledger.org/r/16255

Ratnakar (Tue, 19 Dec 2017 23:29:14 GMT):
easy one : https://gerrit.hyperledger.org/r/#/c/16323/

jun (Wed, 20 Dec 2017 07:17:23 GMT):
Has joined the channel.

tsrb (Wed, 20 Dec 2017 07:22:14 GMT):
Has joined the channel.

joe-alewine (Wed, 20 Dec 2017 14:09:00 GMT):
Documenting peer commands: https://gerrit.hyperledger.org/r/c/16217

yacovm (Wed, 20 Dec 2017 22:39:11 GMT):
https://gerrit.hyperledger.org/r/#/c/16365/ and https://gerrit.hyperledger.org/r/#/c/16363/ - reverting 2 change sets for lifecycle

yacovm (Wed, 20 Dec 2017 22:39:36 GMT):
https://gerrit.hyperledger.org/r/#/c/16343/ trivial one - just 1 line of code, and a core.yaml addition

nnao (Thu, 21 Dec 2017 05:08:49 GMT):
Please review: https://gerrit.hyperledger.org/r/#/c/15737/

yacovm (Thu, 21 Dec 2017 13:38:24 GMT):
trivial typo fix https://gerrit.hyperledger.org/r/#/c/16393/

Sneljo (Thu, 21 Dec 2017 17:02:53 GMT):
Has joined the channel.

Sneljo (Thu, 21 Dec 2017 17:03:39 GMT):
Implemented a working getqueryresult in the mockstub for GO https://gerrit.hyperledger.org/r/c/16325/ (build failed cause of a network issue pulling maven)

baohua (Fri, 22 Dec 2017 05:15:09 GMT):
welcome to help review: https://gerrit.hyperledger.org/r/#/c/16313/

muralisr (Fri, 22 Dec 2017 15:44:31 GMT):
@baohua added some comments

muralisr (Fri, 22 Dec 2017 15:44:47 GMT):
some love for this https://gerrit.hyperledger.org/r/#/c/16037 please (the resource stuff is highly simplfied now ... no rscc, and aclmgmt just uses resource bundle to do ACL) and chaincode FSM removal https://gerrit.hyperledger.org/r/#/c/11867

muralisr (Fri, 22 Dec 2017 15:45:05 GMT):
(and happy holidays! :-) )

firas.qutishat (Fri, 22 Dec 2017 17:32:55 GMT):
https://gerrit.hyperledger.org/r/#/c/16409/ easy +2

blw (Fri, 22 Dec 2017 19:37:14 GMT):
Has joined the channel.

blw (Fri, 22 Dec 2017 19:44:29 GMT):
cleaned up error message for expired certs https://gerrit.hyperledger.org/r/c/15887/

baohua (Mon, 25 Dec 2017 01:19:04 GMT):
@muralisr thanks, add my comments, and happy holidays!

blw (Mon, 25 Dec 2017 19:13:12 GMT):
a little refactoring https://gerrit.hyperledger.org/r/c/16461/

mastersingh24 (Tue, 26 Dec 2017 13:30:27 GMT):
pretty easy one - just a refactor for some later CRs: https://gerrit.hyperledger.org/r/16455

Sneljo (Wed, 27 Dec 2017 08:05:14 GMT):
Please review - rich query implementation https://gerrit.hyperledger.org/r/c/16325/

Sneljo (Wed, 27 Dec 2017 08:05:14 GMT):
Please review - mockstub rich query implementation https://gerrit.hyperledger.org/r/c/16325/

yacovm (Thu, 28 Dec 2017 15:52:44 GMT):
Code coverage change set https://gerrit.hyperledger.org/r/#/c/16463/

yacovm (Thu, 28 Dec 2017 19:30:48 GMT):
https://gerrit.hyperledger.org/r/#/c/16477/ This one looks big but it's only because it contains 500 lines of test code. Missing 1 more +2 to get in

rameshthoomu (Tue, 02 Jan 2018 14:32:02 GMT):
@mastersingh24 I have addressed your comment in https://gerrit.hyperledger.org/r/#/c/16221/

Ratnakar (Tue, 02 Jan 2018 19:27:49 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/16323/ need one more +2

baohua (Wed, 03 Jan 2018 00:40:42 GMT):
An old patchset staying for a month, it is only with single change, welcome to review: https://gerrit.hyperledger.org/r/#/c/12735/

sstone1 (Wed, 03 Jan 2018 13:45:36 GMT):
@mastersingh24 can you read the comments on here plz: https://gerrit.hyperledger.org/r/c/15671

scottz (Wed, 03 Jan 2018 22:45:18 GMT):
https://gerrit.hyperledger.org/r/#/c/15715/ needs attention to be merged, to unblock some v1.1 feature testing

yacovm (Thu, 04 Jan 2018 15:12:30 GMT):
https://gerrit.hyperledger.org/r/#/c/16555/

smithbk (Thu, 04 Jan 2018 15:51:03 GMT):
For fabric-ca:

smithbk (Thu, 04 Jan 2018 15:51:05 GMT):
https://gerrit.hyperledger.org/r/14275 - [FAB-3416] Vendoring govaluate https://gerrit.hyperledger.org/r/14279 - [FAB-3416] Map LDAP attrs to fabric CA attrs https://gerrit.hyperledger.org/r/15281 - [FAB-5726] Add/Remove identities https://gerrit.hyperledger.org/r/15283 - [FAB-5726] Modify identities https://gerrit.hyperledger.org/r/15547 - [FAB-5726] Affiliation CLI https://gerrit.hyperledger.org/r/15617 - [FAB-5726] Get affiliations https://gerrit.hyperledger.org/r/15659 - [FAB-5726] Add/remove affiliations https://gerrit.hyperledger.org/r/15715 - [FAB-5726] Modify affiliations

aambati (Thu, 04 Jan 2018 16:06:11 GMT):
and this one for fabric-ca : https://gerrit.hyperledger.org/r/c/16035/

troyronda (Thu, 04 Jan 2018 17:06:35 GMT):
1 more +2 for https://gerrit.hyperledger.org/r/c/15795/

mastersingh24 (Thu, 04 Jan 2018 20:12:26 GMT):
This one looks ready to do: https://gerrit.hyperledger.org/r/16555 (mutual TLS support for CLI) @C0rWin @sykesm

rameshthoomu (Thu, 04 Jan 2018 20:21:40 GMT):
@mastersingh24 @cbf Please review this.. https://gerrit.hyperledger.org/r/#/c/16221/ This patch has to go to complete upstream and downstream job work

C0rWin (Thu, 04 Jan 2018 20:23:29 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=g6opkzYBqPd3LuL3X) @mastersingh24 have a small comment

cbf (Thu, 04 Jan 2018 20:28:05 GMT):
@rameshthoomu thanks... the one thing I would recommend is in the comments make it clear as possible that the build- targets are exclusively for CI and SHOULD NOT be used for local development testing

rameshthoomu (Thu, 04 Jan 2018 20:29:05 GMT):
sure will update this in makefile

rjones (Thu, 04 Jan 2018 20:29:23 GMT):
you could do something sneaky, like add an environment variable `ENABLE_CI_ONLY_TESTS` or similar

cbf (Thu, 04 Jan 2018 20:45:41 GMT):
I just don't want ppl running build-* and having it barf is all

cbf (Thu, 04 Jan 2018 20:45:57 GMT):
since they won't have built the images etc

JonathanLevi (Thu, 04 Jan 2018 21:03:35 GMT):
Let's discuss this ([ ](https://chat.hyperledger.org/channel/fabric-scrum?msg=ezfhHYn67sReKSE5W) ) here?

JonathanLevi (Thu, 04 Jan 2018 21:03:53 GMT):
https://gerrit.hyperledger.org/r/#/c/16533

JonathanLevi (Thu, 04 Jan 2018 21:04:04 GMT):
Thanks

muralisr (Thu, 04 Jan 2018 21:16:48 GMT):
muralisr 4:10 PM just saw Jeff's comment, will address on the CR but the bottomline is that the FSM wasn't doing anything except add indirection (channel messages to move from ready -> ready state for most part after handshake). The first CR just removes the FSM. dave.enyeart 4:11 PM I am for FSM removal...better sooner than later in my opinion. We still have a lot of system test ahead of us in 1.1 shutdown, over the course of alpha, beta, GA testing. muralisr 4:13 PM but @jeffgarratt comment `I do not think this makes the code any simpler, but reduces the ability to comprehend the state changes which still remain.` really is addressed by the CRs on top which basically say that there is just handshake followed by "ready" we needed a lot of states in 0.5 to handle serialization of "invokes" while "queries" can be concurrent I wish we had time to remove FSM along with 1.0 when it remove the need for serialization but we left the FSM in (1) reduce the changes and (2) didn't want to rock the boat too much while making sure the concurrency worked correctly the FSM just now just adds more core and increases path length (via channel messages etc) for no good reason dave.enyeart 4:16 PM @muralisr Jonathan has moved the conversation over to fabric-pr-review. Let's copy our comments there 🙂 muralisr 4:16 PM just look at the amount of code removed

dave.enyeart (Thu, 04 Jan 2018 21:16:51 GMT):
I am in favor of FSM removal...better sooner than later in my opinion. We still have a lot of system test ahead of us in 1.1 shutdown, over the course of alpha, beta, GA testing. Doing it later will only add more risk.

muralisr (Thu, 04 Jan 2018 21:17:22 GMT):
hey @jeffgarratt ^^^ (happy new year btw ! :-) )

muralisr (Thu, 04 Jan 2018 21:19:36 GMT):
I think if you look at all the 3 CRs together you'll see the rationale

wlahti (Thu, 04 Jan 2018 22:29:04 GMT):
Just need one more review of https://gerrit.hyperledger.org/r/#/c/16507/, which adds validation checks to eventhub registration messages, whenever any maintainers can spare a little time. Thanks!

JonathanLevi (Fri, 05 Jan 2018 00:19:36 GMT):
Will, so Artem and Yacov got it in. Let's push add this to 1.1 ?

JonathanLevi (Fri, 05 Jan 2018 00:19:57 GMT):
Will, so Artem and Yacov got it in. Let's push/include this in 1.1 ?

JonathanLevi (Fri, 05 Jan 2018 00:20:31 GMT):
I believe that FAB-7229 is pretty important, isn't it?

JonathanLevi (Fri, 05 Jan 2018 00:43:04 GMT):
( Assigned this to you @wlahti )

wlahti (Fri, 05 Jan 2018 00:48:54 GMT):
Yes, we've handled the most vulnerable parts of the code (eventhub/deliver) now. Not sure if we made a decision yet on doing the similar fix for all incoming messages from clients to the peer.

wlahti (Fri, 05 Jan 2018 00:48:54 GMT):
Yes, we've handled the most vulnerable parts of the code (eventhub/deliver) now. Not sure if we made the decision yet on how soon we must do similar fixes for all incoming messages from clients to the peer.

JonathanLevi (Fri, 05 Jan 2018 00:55:55 GMT):
Got you. Personally, I am happy for you to close that JIRA item then (once the build is complete)

JonathanLevi (Fri, 05 Jan 2018 00:56:21 GMT):
If we learn about some new vulnerabilities, we can re-open or create a new JIRA item.

JonathanLevi (Fri, 05 Jan 2018 00:56:25 GMT):
Fair enough?

JonathanLevi (Fri, 05 Jan 2018 00:57:06 GMT):
We are working to clear up some of the backlog... so that we get more clarify on/before Monday

wlahti (Fri, 05 Jan 2018 00:57:49 GMT):
let me check with the crypto team first and, if they agree, I'll close it. is that fair?

wlahti (Fri, 05 Jan 2018 00:58:17 GMT):
we worked closely with them to create the items and the fixes so I'd love to have their blessing first.

JonathanLevi (Fri, 05 Jan 2018 00:58:30 GMT):
Sure. Put it this way, if there are more vulnerabilities, then report it to the security team.

JonathanLevi (Fri, 05 Jan 2018 00:59:01 GMT):
At the moment, if it's not reported, it's kinda "not there". So sure, let's give it 24 hours... for them to review, etc. Thanks.

thiago-moreira (Fri, 05 Jan 2018 01:07:52 GMT):
Has joined the channel.

wlahti (Fri, 05 Jan 2018 02:14:17 GMT):
Two CRs needed to fix a recently introduced peer deliver bug: - https://gerrit.hyperledger.org/r/#/c/15183/ (Add Envelope based validation to RSCC/default ACL provider) - https://gerrit.hyperledger.org/r/#/c/16587/ (Peer deliver unusable when block event policy not defined) edit: just noticed the full scope of Murali's resource based ACL work. I'll need to rebase/refactor my CR on top of his work so I'd definitely appreciate reviews on his CR: https://gerrit.hyperledger.org/r/#/c/16037/

wlahti (Fri, 05 Jan 2018 02:14:17 GMT):
Two CRs needed to fix a recently introduced peer deliver bug: - ~https://gerrit.hyperledger.org/r/#/c/15183/ (Add Envelope based validation to RSCC/default ACL provider)~ - ~https://gerrit.hyperledger.org/r/#/c/16587/ (Peer deliver unusable when block event policy not defined)~ edit: just noticed the full scope of Murali's resource based ACL work. I'll need to rebase/refactor my CR on top of his work so I'd definitely appreciate reviews on his CR: https://gerrit.hyperledger.org/r/#/c/16037/

adc (Fri, 05 Jan 2018 16:01:53 GMT):
Hi All, please, have a look at https://gerrit.hyperledger.org/r/#/c/15483/ with lots of love :)

philviana (Fri, 05 Jan 2018 16:30:42 GMT):
Has joined the channel.

smithbk (Fri, 05 Jan 2018 19:48:09 GMT):
https://gerrit.hyperledger.org/r/#/c/14191/ - just some clean up for test code

smithbk (Fri, 05 Jan 2018 20:07:14 GMT):
https://gerrit.hyperledger.org/r/#/c/16291/ - very small change needs another +2

muralisr (Fri, 05 Jan 2018 20:41:54 GMT):
@adc will return the favor of review for helping review (and +1 :-) ) https://gerrit.hyperledger.org/r/#/c/16037/

muralisr (Fri, 05 Jan 2018 20:43:27 GMT):
I just rebased to make sure latest works (which will unfort. rub out the +1) and added `V1_1_RESOURCETREE_EXPERIMENTAL: false` to configtx.yaml

muralisr (Fri, 05 Jan 2018 20:43:56 GMT):
will follow through with a playback as promised in fabric-scrum....

muralisr (Fri, 05 Jan 2018 20:44:13 GMT):
some love for https://gerrit.hyperledger.org/r/#/c/16037 please :-)

yacovm (Sat, 06 Jan 2018 16:30:06 GMT):
https://gerrit.hyperledger.org/r/#/c/16605/ 1 more +2 to go

yacovm (Sat, 06 Jan 2018 20:08:19 GMT):
https://gerrit.hyperledger.org/r/#/c/16619/ same here, 1 more +2 to go

JonathanLevi (Sun, 07 Jan 2018 02:28:23 GMT):
Nice work. Have just merged them both... I suggest to add these two to 1.1 (alpha)

mastersingh24 (Sun, 07 Jan 2018 09:53:59 GMT):
Some pretty easy ones: https://gerrit.hyperledger.org/r/16615 (one more +2) https://gerrit.hyperledger.org/r/16621 (one more +2) https://gerrit.hyperledger.org/r/16617 (trivial Node SDK bug fix - needs some love)

ysim (Mon, 08 Jan 2018 16:07:21 GMT):
I'm trying to reply to some of the PR comments in the gerrit interface but seem to only be able to save my replies as a draft... is this normal?

ysim (Mon, 08 Jan 2018 16:38:39 GMT):
In any case - thanks to everyone who reviewed this: https://gerrit.hyperledger.org/r/#/c/16133/ I've pushed up the fixes to your comments, would really appreciate another round of reviews!

rjones (Mon, 08 Jan 2018 16:54:11 GMT):
@ysim you need to publish the comments

ysim (Mon, 08 Jan 2018 17:02:25 GMT):
@rjones Where is the publish button?

rjones (Mon, 08 Jan 2018 17:06:10 GMT):

E6C92A40-C628-4A78-AD3E-3496AE36425C.png

rjones (Mon, 08 Jan 2018 17:06:37 GMT):
Post, not pretty

joe-alewine (Mon, 08 Jan 2018 18:20:14 GMT):
Identity and membership doc (written in collaboration with Anthony O'Dowd): https://gerrit.hyperledger.org/r/15933/

joe-alewine (Mon, 08 Jan 2018 18:21:37 GMT):
Document peer commands (already have a +2 on this one, need another): https://gerrit.hyperledger.org/r/16217/

joe-alewine (Mon, 08 Jan 2018 18:21:37 GMT):
Peer commands documentation (already have a +2 on this one, need another): https://gerrit.hyperledger.org/r/16217/

rennman (Mon, 08 Jan 2018 20:36:26 GMT):
I need +2s on a couple of small items: https://gerrit.hyperledger.org/r/#/c/16001/ (Version command test) https://gerrit.hyperledger.org/r/#/c/16187/ (check_format trailing blanks) thanks

rameshthoomu (Mon, 08 Jan 2018 22:02:00 GMT):
one more +2 pls https://gerrit.hyperledger.org/r/#/c/12425/

rameshthoomu (Mon, 08 Jan 2018 22:02:00 GMT):
one more +2 pls https://gerrit.hyperledger.org/r/#/c/12425/ @jeffgarratt

muralisr (Mon, 08 Jan 2018 22:50:43 GMT):
done @rameshthoomu

smithbk (Tue, 09 Jan 2018 05:53:16 GMT):
https://gerrit.hyperledger.org/r/#/c/16669/ - simple fix to typescript sample

baohua (Tue, 09 Jan 2018 07:23:24 GMT):
refine the endorser.process() function: https://gerrit.hyperledger.org/r/#/c/12735/, thanks

ysim (Tue, 09 Jan 2018 19:55:39 GMT):
If anyone has a spare moment, could I get some help on https://gerrit.hyperledger.org/r/#/c/16133/? I've been investigating the build failure but not having much luck so far - I can't seem to reproduce the error.

baohua (Wed, 10 Jan 2018 16:03:05 GMT):
Improve documentation including how to add dependencies inside chaincode, welcome to help review: https://gerrit.hyperledger.org/r/#/c/16591/

baohua (Wed, 10 Jan 2018 21:24:39 GMT):
the ci testing seems unstable recently, saw several patchset testing failure without reason.

rameshthoomu (Thu, 11 Jan 2018 12:48:01 GMT):
@baohua could you please refer the failed builds. I will check them

baohua (Thu, 11 Jan 2018 14:27:56 GMT):
take this one for example, repeated lots of time to make ci passed: https://gerrit.hyperledger.org/r/#/c/16591/ @rameshthoomu

rameshthoomu (Thu, 11 Jan 2018 14:58:48 GMT):
Ok will go through these failures and see what went wrong at each build. Sometimes in behave or e2e tests fails due to timeout errors.

rameshthoomu (Thu, 11 Jan 2018 15:00:18 GMT):
I think we can skip voting if the patchsrt contains only documentation changes.

skarim (Thu, 11 Jan 2018 16:26:28 GMT):
Please review fabric-ca CR: https://gerrit.hyperledger.org/r/#/c/16709/

sykesm (Thu, 11 Jan 2018 18:48:22 GMT):
Hi. Can I get a second review of https://gerrit.hyperledger.org/r/c/16735/ ?

yacovm (Thu, 11 Jan 2018 18:53:08 GMT):
Yes

yacovm (Thu, 11 Jan 2018 18:54:28 GMT):
@skarim - I merged it but I think we need a protocol for cases where someone assigns itself on a JIRA and then goes MIA

yacovm (Thu, 11 Jan 2018 18:54:28 GMT):
@sykesm - I merged it but I think we need a protocol for cases where someone assigns itself on a JIRA and then goes MIA

yacovm (Thu, 11 Jan 2018 18:54:32 GMT):
@cbf ^

yacovm (Thu, 11 Jan 2018 19:01:13 GMT):
This one has been out for a long time https://gerrit.hyperledger.org/r/#/c/16645/

yacovm (Thu, 11 Jan 2018 19:01:22 GMT):
needs 1 more +2

nnao (Thu, 11 Jan 2018 19:47:51 GMT):
https://gerrit.hyperledger.org/r/#/c/15737/ - High Bug "Fix error code missing in endorser"

baohua (Thu, 11 Jan 2018 23:58:44 GMT):
documentation one, need one more +2: https://gerrit.hyperledger.org/r/16591, thanks!

smithbk (Fri, 12 Jan 2018 14:41:07 GMT):
https://gerrit.hyperledger.org/r/#/c/16709/ needs one more +2 ... @mastersingh24 @JonathanLevi @yacovm

joe-alewine (Fri, 12 Jan 2018 17:08:20 GMT):
https://gerrit.hyperledger.org/r/#/c/16217/ needs one more +2

joe-alewine (Fri, 12 Jan 2018 17:08:20 GMT):
Needs just one more +2 https://gerrit.hyperledger.org/r/#/c/16217/

joe-alewine (Fri, 12 Jan 2018 17:08:20 GMT):
Documenting peer commands. Needs just one more +2 https://gerrit.hyperledger.org/r/#/c/16217/

JonathanLevi (Fri, 12 Jan 2018 18:47:43 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=79YxjRfKGzcGAHdJ6)

JonathanLevi (Fri, 12 Jan 2018 18:48:45 GMT):
There is an objection there. There are two ways we can handle it... I am fine with either can you @smithbk and/or @skarim address/respond?

rameshthoomu (Fri, 12 Jan 2018 20:41:01 GMT):
Need review on this please https://gerrit.hyperledger.org/r/#/c/16715/

rameshthoomu (Fri, 12 Jan 2018 20:41:01 GMT):
Need review on this please https://gerrit.hyperledger.org/r/#/c/16715/ (upgrading node version `8.9.1` in fabric baseimage)

smithbk (Fri, 12 Jan 2018 21:21:04 GMT):
Any reason for not using 8.9.4?

smithbk (Fri, 12 Jan 2018 21:21:09 GMT):
https://gerrit.hyperledger.org/r/#/c/16715/

smithbk (Fri, 12 Jan 2018 21:21:09 GMT):
https://nodejs.org/download/release/v8.9.4/

rameshthoomu (Fri, 12 Jan 2018 22:08:13 GMT):
@smithbk not sure patch is based on the FAB-6770

rameshthoomu (Fri, 12 Jan 2018 22:12:07 GMT):
I think it's make sense to test and upgrade to `8.9.4`. @bretharrison @davidkel inputs pls?

bretharrison (Fri, 12 Jan 2018 22:20:05 GMT):
Yes, I would like to run with 8.9.4 for bit before upgrade

bretharrison (Fri, 12 Jan 2018 22:20:05 GMT):
Yes, I would like to run with 8.9.4 for a bit before upgrade

davidkel (Fri, 12 Jan 2018 22:35:49 GMT):
@rameshthoomu The Jira only presented an example of a version at the time of writing (and was not requesting that specific version). In fact I would expect the Jira to always remain open as a driver to ensure that when a release of fabric is to be done, a check is made to determine the versions of node available with a view to upgrade and see if any breaking problems on the latest release which might stop using that version. So in this case 8.9.4 is the latest version of node available, are there any breaking problems in it and as such is not a good candidate to go with. If for any reason it isn't a safe choice then check the previous micro release version.

davidkel (Fri, 12 Jan 2018 22:42:32 GMT):
Our builds always run with the latest LTS version and that is 8.9.4 as of now and we've not seen any problems

davidkel (Fri, 12 Jan 2018 22:42:32 GMT):
Our builds always run with the latest LTS version and that is 8.9.4 as of now and we've not seen any problems and I've not heard of any breaking issues with this version so it would seem to be good release to upgrade to

baohua (Sat, 13 Jan 2018 05:42:54 GMT):
Welcome to help review the doc change: https://gerrit.hyperledger.org/r/#/c/16591/, thanks!

philviana (Sat, 13 Jan 2018 14:04:15 GMT):
@nickgaski Can you review this change? https://gerrit.hyperledger.org/r/#/c/15747/

philviana (Sat, 13 Jan 2018 14:06:57 GMT):
@cbf @mastersingh24 Could you review this change? https://gerrit.hyperledger.org/r/#/c/16095/

lehors (Mon, 15 Jan 2018 14:32:37 GMT):
hi there

lehors (Mon, 15 Jan 2018 14:33:10 GMT):
dear maintainers: it would be nice not to have to beg for attention for every CR

lehors (Mon, 15 Jan 2018 14:35:55 GMT):
I realize that my contributions aren't among the most important ones but on the other hand I try hard to keep them small and well documented so they are easy to review

lehors (Mon, 15 Jan 2018 14:36:25 GMT):
yet they tend to be simply ignored for weeks until I cry for attention (which isn't my style)

lehors (Mon, 15 Jan 2018 14:37:11 GMT):
https://gerrit.hyperledger.org/r/#/q/status:open+lehors

lehors (Mon, 15 Jan 2018 14:37:26 GMT):
thanks in advance for your attention :)

dave.enyeart (Mon, 15 Jan 2018 16:45:51 GMT):
Need another review on proto fix for filtered events: https://gerrit.hyperledger.org/r/#/c/16839/

philviana (Mon, 15 Jan 2018 19:31:06 GMT):
I need a review for https://gerrit.hyperledger.org/r/#/c/16095/

philviana (Tue, 16 Jan 2018 14:14:32 GMT):
@muralisr I just replied to your comments on my change above. Thanks.

muralisr (Tue, 16 Jan 2018 14:14:57 GMT):
thanks @philviana will look soon

philviana (Tue, 16 Jan 2018 14:15:21 GMT):
np, thanks for reviewing!

muralisr (Tue, 16 Jan 2018 14:59:23 GMT):
@philviana hmmm I don't see any response on the CR. It could be my browser but I did try to get the latest...can you double check please ?

philviana (Tue, 16 Jan 2018 15:07:52 GMT):
@muralisr Sorry, I'd forgotten to submit the change as review. Can you pls check now?

muralisr (Tue, 16 Jan 2018 15:08:10 GMT):
no worries.. let me check

muralisr (Tue, 16 Jan 2018 15:15:00 GMT):
makes sense @philviana ... just a +1 from me for now.

philviana (Tue, 16 Jan 2018 15:19:32 GMT):
:+1: Thank you

smithbk (Tue, 16 Jan 2018 17:05:21 GMT):
https://gerrit.hyperledger.org/r/#/c/15859/ needs one more +2. @mastersingh24 has already +2'ed. @JonathanLevi or @yacovm could you help?

yacovm (Tue, 16 Jan 2018 17:06:25 GMT):
I thought we are in feature freeze, @smithbk

yacovm (Tue, 16 Jan 2018 17:06:39 GMT):
is this a bug?

smithbk (Tue, 16 Jan 2018 17:07:04 GMT):
Yes, is a bug

yacovm (Tue, 16 Jan 2018 17:07:15 GMT):
also - the last time the build passed was 5/12/17

yacovm (Tue, 16 Jan 2018 17:07:20 GMT):
not really safe to merge as it

yacovm (Tue, 16 Jan 2018 17:07:33 GMT):
can you rebase and ask @mastersingh24 to re-(+2) ?

smithbk (Tue, 16 Jan 2018 17:07:54 GMT):
ok

joe-alewine (Tue, 16 Jan 2018 17:08:10 GMT):
Documenting peer commands. Needs just one more +2 https://gerrit.hyperledger.org/r/#/c/16217

yacovm (Tue, 16 Jan 2018 17:09:19 GMT):
oh looks like @JonathanLevi saved you :)

smithbk (Tue, 16 Jan 2018 17:09:34 GMT):
yes, thanks @JonathanLevi

joe-alewine (Tue, 16 Jan 2018 17:09:46 GMT):
Identity and membership doc (written with Anthony O'Dowd): https://gerrit.hyperledger.org/r/#/c/15933/

smithbk (Tue, 16 Jan 2018 17:21:08 GMT):
https://gerrit.hyperledger.org/r/#/c/16749/ - needs one more +2. It is a backport to the release stream of https://gerrit.hyperledger.org/r/#/c/16585 which is already merged

JonathanLevi (Tue, 16 Jan 2018 17:27:03 GMT):
Merged them both...

JonathanLevi (Tue, 16 Jan 2018 17:27:38 GMT):
But now we should try to respect the code freeze that Dave announced, so that we let the testers have a good round testing phase

JonathanLevi (Tue, 16 Jan 2018 17:30:16 GMT):
OK, approved and merged them both. Now we should probably try to respect the code freeze that was announced... and start a clean testing cycle (or a few of these)... fair enough?

JonathanLevi (Tue, 16 Jan 2018 17:31:06 GMT):
[Docs and newly found bugs aside]

smithbk (Tue, 16 Jan 2018 19:37:02 GMT):
@Jonathan Thanks for review/merge. I thought we just had a feature freeze and not code freeze, according to Dave's last note to #fabric-release channel

skarim (Tue, 16 Jan 2018 20:44:31 GMT):
https://gerrit.hyperledger.org/r/#/c/16871/ Should be a quick one, only a few lines

C0rWin (Wed, 17 Jan 2018 07:02:39 GMT):
a bugfix: https://gerrit.hyperledger.org/r/#/c/16883/

rameshthoomu (Wed, 17 Jan 2018 15:59:20 GMT):
@mastersingh24 @chris.elder upgrade couchdb version from 2.0.0 to 2.1.1 https://gerrit.hyperledger.org/r/#/c/16905/

rameshthoomu (Wed, 17 Jan 2018 16:00:47 GMT):
to publish this to dockerhub we have to create a release tag in fabric-baseimage repo

nnao (Wed, 17 Jan 2018 18:02:01 GMT):
Please review for https://gerrit.hyperledger.org/r/#/c/15737/

skarim (Thu, 18 Jan 2018 15:32:39 GMT):
Bugfix: https://gerrit.hyperledger.org/r/#/c/16559/ . Looks big, but most of the lines are test code

harsha (Fri, 19 Jan 2018 15:14:04 GMT):
Request for review, https://gerrit.hyperledger.org/r/16993/ https://gerrit.hyperledger.org/r/16989

skarim (Fri, 19 Jan 2018 18:08:54 GMT):
Small bug fix, only a couple lines. https://gerrit.hyperledger.org/r/#/c/16987/

skarim (Fri, 19 Jan 2018 18:08:54 GMT):
Small bug fix, only a couple lines. https://gerrit.hyperledger.org/r/#/c/16987/ @mastersingh24 @yacovm @JonathanLevi

aambati (Fri, 19 Jan 2018 20:09:18 GMT):
@mastersingh24 @yacovm @JonathanLevi can you please review https://gerrit.hyperledger.org/r/c/16759/ and https://gerrit.hyperledger.org/r/c/16915/ ...Keith has +2ed them, need one more +2

yacovm (Fri, 19 Jan 2018 20:47:02 GMT):
I merged 2 out of the 3

yacovm (Fri, 19 Jan 2018 21:04:25 GMT):
Trying to figure out something I'm missing w.r.t the 3rd

yacovm (Fri, 19 Jan 2018 21:24:56 GMT):
ok got it, merged the 3rd

Brucepark (Sat, 20 Jan 2018 06:15:47 GMT):
Has joined the channel.

armujahid (Sun, 21 Jan 2018 06:19:42 GMT):
Has joined the channel.

armujahid (Sun, 21 Jan 2018 06:23:31 GMT):
@yacovm and @mastersingh24 kindly review https://gerrit.hyperledger.org/r/#/c/17027/

mastersingh24 (Sun, 21 Jan 2018 08:27:31 GMT):
@armujahid - Code looks good. Please see my comment about entering a JIRA. You can also see http://hyperledger-fabric.readthedocs.io/en/latest/Gerrit/changes.html for how to format the commit messages. But the actual code is good

armujahid (Sun, 21 Jan 2018 09:01:38 GMT):
@mastersingh24 I will do that and will update you

armujahid (Sun, 21 Jan 2018 09:20:40 GMT):
@mastersingh24 I have created FAB-7836. I have also updated commit message

harsha (Sun, 21 Jan 2018 13:00:45 GMT):
One more +2 https://gerrit.hyperledger.org/r/#/c/16989/

rameshthoomu (Mon, 22 Jan 2018 13:20:29 GMT):
one more +2 https://gerrit.hyperledger.org/r/#/c/17041/ @jyellick @kostas

mastersingh24 (Mon, 22 Jan 2018 15:23:56 GMT):
Can we get these merged for NodeSDK: https://gerrit.hyperledger.org/r/#/q/project:fabric-sdk-node+status:open+owner:%22Gari+Singh+%253Cgari.r.singh%2540gmail.com%253E%22

mastersingh24 (Mon, 22 Jan 2018 15:24:00 GMT):
Please

joe-alewine (Mon, 22 Jan 2018 16:30:25 GMT):
Doc on CouchDB as state database (required minor shuffling/taking stuff out of Ledger doc and moving rest to concepts section) -- https://gerrit.hyperledger.org/r/#/c/17057/ @dave.enyeart

mastersingh24 (Mon, 22 Jan 2018 16:46:12 GMT):
Anyone? Pretty please? @cbf ? (https://chat.hyperledger.org/channel/fabric-pr-review?msg=HyJmPXDo5n3nNDkv6)

rameshthoomu (Mon, 22 Jan 2018 21:46:47 GMT):
review this pls https://gerrit.hyperledger.org/r/#/c/17063/

rameshthoomu (Mon, 22 Jan 2018 22:56:14 GMT):
@scottz please review this https://gerrit.hyperledger.org/r/#/c/17059/

philviana (Mon, 22 Jan 2018 23:39:40 GMT):
Can someone please review this? https://gerrit.hyperledger.org/r/#/c/16095/

philviana (Mon, 22 Jan 2018 23:39:46 GMT):
It's only one code review to go

ankitkamra (Tue, 23 Jan 2018 08:09:26 GMT):
Has joined the channel.

mastersingh24 (Tue, 23 Jan 2018 09:08:25 GMT):
Nice one from @john.d.sheehan - https://gerrit.hyperledger.org/r/16897 (easy as well)

john.d.sheehan (Tue, 23 Jan 2018 09:08:25 GMT):
Has joined the channel.

joe-alewine (Tue, 23 Jan 2018 14:52:34 GMT):
Fix broken links in CouchDB doc: https://gerrit.hyperledger.org/r/#/c/17095/

mastersingh24 (Wed, 24 Jan 2018 14:19:45 GMT):
Some bug fixes for master and release for fabric-sdk-node: https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open+project:fabric-sdk-node

odowdaibm (Wed, 24 Jan 2018 18:00:15 GMT):
Looking for some +1s on https://gerrit.hyperledger.org/r/#/c/17145/ Allows markdown to be added to fabric documentation

odowdaibm (Wed, 24 Jan 2018 18:01:14 GMT):
want to add some new documentation using markdown, but need this as pre-req feature/ @mastersingh24 @cbf

odowdaibm (Wed, 24 Jan 2018 18:02:08 GMT):
@rameshthoomu - thanks for collaborating on this small but helpful change https://gerrit.hyperledger.org/r/#/c/17145 would appreciate a +1 on it

rameshthoomu (Wed, 24 Jan 2018 18:14:49 GMT):
sure.. checking quickly

rameshthoomu (Wed, 24 Jan 2018 18:18:42 GMT):
@odowdaibm did you test this change in RTD..

rameshthoomu (Wed, 24 Jan 2018 18:19:21 GMT):
I see pip install command is failing.. Also you have add (pip install .. ) in docs/requirements.txt file

rameshthoomu (Wed, 24 Jan 2018 18:35:58 GMT):
Added comment https://gerrit.hyperledger.org/r/#/c/17145/

rameshthoomu (Wed, 24 Jan 2018 18:35:58 GMT):
Added comment in https://gerrit.hyperledger.org/r/#/c/17145/

cbf (Wed, 24 Jan 2018 19:36:24 GMT):
is there a staging doc build for https://gerrit.hyperledger.org/r/c/17145/ @rameshthoomu

rameshthoomu (Wed, 24 Jan 2018 19:37:03 GMT):
@cbf http://ramesh.readthedocs.io/en/latest/

rennman (Wed, 24 Jan 2018 21:17:26 GMT):
need +2 for trivial formatting CR https://gerrit.hyperledger.org/r/#/c/17151/

rennman (Wed, 24 Jan 2018 21:17:28 GMT):
thanks

wlahti (Wed, 24 Jan 2018 21:40:11 GMT):
Peer event documentation needs further review before alpha: https://gerrit.hyperledger.org/r/#/c/17139/ . Thanks!

philviana (Thu, 25 Jan 2018 01:13:29 GMT):
need +1 for improvements to the bootstrap script marked as help wanted @cbf could you pls take a look? it' s already got +1 https://gerrit.hyperledger.org/r/#/c/16095

mastersingh24 (Thu, 25 Jan 2018 09:41:59 GMT):
Trivial fix for Node SDK (master and release): https://gerrit.hyperledger.org/r/17133 https://gerrit.hyperledger.org/r/17135

rameshthoomu (Thu, 25 Jan 2018 15:48:16 GMT):
@cbf @mastersingh24 could you please review this https://gerrit.hyperledger.org/r/#/c/17181/

cbf (Thu, 25 Jan 2018 15:58:04 GMT):
@rameshthoomu see my comment

cbf (Thu, 25 Jan 2018 15:58:08 GMT):
good catch though!

C0rWin (Thu, 25 Jan 2018 16:04:25 GMT):
https://gerrit.hyperledger.org/r/#/c/16919/

skarim (Thu, 25 Jan 2018 16:18:32 GMT):
Bug fix: https://gerrit.hyperledger.org/r/#/c/17107/ @mastersingh24 @JonathanLevi @yacovm

mastersingh24 (Thu, 25 Jan 2018 17:16:33 GMT):
Did you check with the Java SDK on this? I know we don't have all of this in the NodeSDK at this point (https://chat.hyperledger.org/channel/fabric-pr-review?msg=bdRvbDkq8unnsv42e) @skarim

skarim (Thu, 25 Jan 2018 17:17:07 GMT):
yeah, Rick is aware

rameshthoomu (Thu, 25 Jan 2018 17:42:55 GMT):
@cbf I have replied to comment.. Could you please check https://gerrit.hyperledger.org/r/#/c/17181/

joe-alewine (Thu, 25 Jan 2018 22:06:55 GMT):
TLS documentation: https://gerrit.hyperledger.org/r/#/c/17229/

joe-alewine (Thu, 25 Jan 2018 22:11:31 GMT):
Upgrade to 1.1 documentation: https://gerrit.hyperledger.org/r/#/c/17223/

rameshthoomu (Fri, 26 Jan 2018 14:06:42 GMT):
Need one more +2 on this https://gerrit.hyperledger.org/r/#/c/17145/

mastersingh24 (Sat, 27 Jan 2018 14:37:48 GMT):
some easy doc fixes: https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric+branch:master+topic:doc-fixes

dsanchezseco (Mon, 29 Jan 2018 12:16:31 GMT):
Has left the channel.

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - https://gerrit.hyperledger.org/r/#/c/17299/

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - https://gerrit.hyperledger.org/r/#/c/17299/ (eventhub registration unexpectedly fails) - https://gerrit.hyperledger.org/r/#/c/17313/ (same fix as above, just for deliver servers) - https://gerrit.hyperledger.org/r/#/c/17317/ (peer not respecting --logging-level)

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - https://gerrit.hyperledger.org/r/#/c/17299/ (eventhub registration unexpectedly fails) -~ https://gerrit.hyperledger.org/r/#/c/17313/ (same fix as above, just for deliver servers)~ - https://gerrit.hyperledger.org/r/#/c/17317/ (peer not respecting --logging-level)

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - https://gerrit.hyperledger.org/r/#/c/17299/ (eventhub registration unexpectedly fails) -~https://gerrit.hyperledger.org/r/#/c/17313/ (same fix as above, just for deliver servers)~ - https://gerrit.hyperledger.org/r/#/c/17317/ (peer not respecting --logging-level)

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - https://gerrit.hyperledger.org/r/#/c/17299/ (eventhub registration unexpectedly fails) -~https://gerrit.hyperledger.org/r/#/c/17313/~ (same fix as above, just for deliver servers)~ - https://gerrit.hyperledger.org/r/#/c/17317/ (peer not respecting --logging-level)

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - https://gerrit.hyperledger.org/r/#/c/17299/ (eventhub registration unexpectedly fails) - ~https://gerrit.hyperledger.org/r/#/c/17313/~ (same fix as above, just for deliver servers)~ - https://gerrit.hyperledger.org/r/#/c/17317/ (peer not respecting --logging-level)

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - https://gerrit.hyperledger.org/r/#/c/17299/ (eventhub registration unexpectedly fails) - ~https://gerrit.hyperledger.org/r/#/c/17313/~ (same fix as above, just for deliver servers) - https://gerrit.hyperledger.org/r/#/c/17317/ (peer not respecting --logging-level)

wlahti (Tue, 30 Jan 2018 18:06:48 GMT):
A few peer bug fixes ready for review: - ~https://gerrit.hyperledger.org/r/#/c/17299/~ (eventhub registration unexpectedly fails) - ~https://gerrit.hyperledger.org/r/#/c/17313/~ (same fix as above, just for deliver servers) - ~https://gerrit.hyperledger.org/r/#/c/17317/~ (peer not respecting --logging-level)

rameshthoomu (Wed, 31 Jan 2018 17:58:12 GMT):
pls review this one https://gerrit.hyperledger.org/r/#/c/17275/

muralisr (Wed, 31 Jan 2018 18:04:31 GMT):
@rameshthoomu @dave.enyeart don;t we need a JIRA for this ^^^ ?

dave.enyeart (Wed, 31 Jan 2018 18:05:48 GMT):
Yes. I put a comment in there... There should be a [FAB-XXXX] at the beginning of the commit message, pointing to a Jira that describes the intent of the CR. But I'll give my +2 for now as this is blocking CI for other CRs.

muralisr (Wed, 31 Jan 2018 18:07:11 GMT):
sounds good

dave.enyeart (Wed, 31 Jan 2018 18:51:43 GMT):
A few easy reviews: https://gerrit.hyperledger.org/r/#/c/17317/ https://gerrit.hyperledger.org/r/#/c/17067/ https://gerrit.hyperledger.org/r/#/c/17275/ https://gerrit.hyperledger.org/r/#/c/17339/

dave.enyeart (Wed, 31 Jan 2018 18:52:27 GMT):
https://gerrit.hyperledger.org/r/#/c/16719/

dave.enyeart (Wed, 31 Jan 2018 19:16:54 GMT):
https://gerrit.hyperledger.org/r/#/c/17275/

dave.enyeart (Wed, 31 Jan 2018 19:19:12 GMT):
https://gerrit.hyperledger.org/r/#/c/17381/

lehors (Wed, 31 Jan 2018 21:35:54 GMT):
https://gerrit.hyperledger.org/r/16371 and https://gerrit.hyperledger.org/r/16373 are pretty straightforward and have been sitting there for over a month... can somebody please take these out of their misery?

divyank (Wed, 31 Jan 2018 21:40:47 GMT):
Removes a workaround for an issue that was fixed with Go 1.9.2 https://gerrit.hyperledger.org/r/c/17391/

muralisr (Wed, 31 Jan 2018 21:43:17 GMT):
@lehors :-)

muralisr (Wed, 31 Jan 2018 21:43:41 GMT):
will check later tonight if that works ?

cotofei (Thu, 01 Feb 2018 13:33:23 GMT):
Has joined the channel.

wlahti (Thu, 01 Feb 2018 18:23:01 GMT):
peer CLI fetch command bug fix: https://gerrit.hyperledger.org/r/#/c/17423/

wlahti (Thu, 01 Feb 2018 18:23:01 GMT):
~peer CLI fetch command bug fix: https://gerrit.hyperledger.org/r/#/c/17423/~

wlahti (Thu, 01 Feb 2018 21:59:56 GMT):
enhance peer logging for (endorsement) policy evaluation failure - usability bug fix : https://gerrit.hyperledger.org/r/#/c/17451/

wlahti (Thu, 01 Feb 2018 21:59:56 GMT):
enhance peer logging for (endorsement) policy evaluation failure - usability bug fix : https://gerrit.hyperledger.org/r/c/17451/

skarim (Fri, 02 Feb 2018 12:38:22 GMT):
bug fix: https://gerrit.hyperledger.org/r/#/c/17419/

rameshthoomu (Fri, 02 Feb 2018 13:18:55 GMT):
one more +2 pls https://gerrit.hyperledger.org/r/#/c/17275/

joe-alewine (Fri, 02 Feb 2018 19:51:22 GMT):
Identity conceptual information (new CR, split off from Membership topic): https://gerrit.hyperledger.org/r/#/c/17481/ Staged here: http://joestaging-fabric.readthedocs.io/en/latest/Identity/Identity.html

rameshthoomu (Fri, 02 Feb 2018 21:27:08 GMT):
@joe-alewine once this patch is merged (https://gerrit.hyperledger.org/r/#/c/17275/) you can see the output of docs patch set in jenkins log server

rameshthoomu (Fri, 02 Feb 2018 21:27:08 GMT):
@odowdaibm @joe-alewine once this patch is merged (https://gerrit.hyperledger.org/r/#/c/17275/) you can see the output of docs patch set in jenkins log server

rameshthoomu (Fri, 02 Feb 2018 21:29:09 GMT):
click on html link here https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-rtd-verify-master/14/

rameshthoomu (Fri, 02 Feb 2018 21:29:17 GMT):
from this job build https://jenkins.hyperledger.org/me/my-views/view/All/job/fabric-rtd-verify-master/

rameshthoomu (Fri, 02 Feb 2018 21:29:17 GMT):
from this job build https://jenkins.hyperledger.org/me/my-views/view/All/job/fabric-rtd-verify-master/ (Build #14)

janb87 (Mon, 05 Feb 2018 15:14:04 GMT):
Has joined the channel.

janb87 (Mon, 05 Feb 2018 15:14:47 GMT):
Hi, can one of the node.js chaincode maintainers have a look at https://jira.hyperledger.org/browse/FAB-8068 and https://jira.hyperledger.org/browse/FAB-7001

janb87 (Mon, 05 Feb 2018 15:15:16 GMT):
we've created for both issues a merge request in gerrit

daanporon (Mon, 05 Feb 2018 15:18:04 GMT):
Has joined the channel.

yacovm (Mon, 05 Feb 2018 18:04:49 GMT):
Easy one, only test code affected https://gerrit.hyperledger.org/r/#/c/17529/ needs 1 more +2

skarim (Tue, 06 Feb 2018 15:11:52 GMT):
https://gerrit.hyperledger.org/r/#/c/17255/ Please review, contains test code only @mastersingh24 @yacovm This is preventing merging of the following CRs: https://gerrit.hyperledger.org/r/#/c/17419/ https://gerrit.hyperledger.org/r/#/c/17377/

rameshthoomu (Tue, 06 Feb 2018 22:22:39 GMT):
@scottz could you please review this and merge https://gerrit.hyperledger.org/r/#/c/17587/

scottz (Wed, 07 Feb 2018 01:24:31 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=ncP42tpmTuki3iLB3) @rameshthoomu Done.

yacovm (Wed, 07 Feb 2018 07:59:25 GMT):
Critical bug fix, 1 for `master`: https://gerrit.hyperledger.org/r/#/c/17601/ 1 for `release`: https://gerrit.hyperledger.org/r/#/c/17599/

yacovm (Wed, 07 Feb 2018 09:04:25 GMT):
@mastersingh24 the release one is ready for merge

yacovm (Wed, 07 Feb 2018 09:04:25 GMT):
@mastersingh24 or @C0rWin the release one is ready for merge

yacovm (Wed, 07 Feb 2018 09:04:25 GMT):
@mastersingh24 or @C0rWin (or any other maintainer) the release one https://gerrit.hyperledger.org/r/#/c/17599/ is ready for merge

mastersingh24 (Wed, 07 Feb 2018 11:18:31 GMT):
https://gerrit.hyperledger.org/r/17619 needs one more

mastersingh24 (Wed, 07 Feb 2018 15:05:03 GMT):
https://gerrit.hyperledger.org/r/17621 @dave.enyeart @muralisr - here's an alternative update to cryptogen to aid with NodeOUs

dave.enyeart (Wed, 07 Feb 2018 15:07:10 GMT):
Thanks @mastersingh24 , check it out @adc @elli-androulaki

mastersingh24 (Wed, 07 Feb 2018 15:08:04 GMT):
basically a hard-coding of the OUs and an option to enable generating them in the config

mastersingh24 (Wed, 07 Feb 2018 15:08:16 GMT):
The KISS principle

jtclark (Wed, 07 Feb 2018 22:08:07 GMT):
plz review: https://gerrit.hyperledger.org/r/#/c/17649/

davidkhala (Thu, 08 Feb 2018 03:43:11 GMT):
Has joined the channel.

divyank (Thu, 08 Feb 2018 14:55:33 GMT):
removes a workaround that's no longer required: https://gerrit.hyperledger.org/r/c/17391/

lehors (Thu, 08 Feb 2018 19:00:56 GMT):
@mastersingh24 https://gerrit.hyperledger.org/r/#/c/16373/ is the update to the doc corresponding to the CR you just merged https://gerrit.hyperledger.org/r/#/c/16371/

lehors (Thu, 08 Feb 2018 19:00:58 GMT):
thanks

mastersingh24 (Thu, 08 Feb 2018 19:02:24 GMT):
cool - for some reason it did not show up for me. who knows - I blame gerrit

lehors (Thu, 08 Feb 2018 19:13:11 GMT):
wow, 2 my CRs merged, it's Xmas! ;-)

lehors (Thu, 08 Feb 2018 19:13:11 GMT):
wow, 2 of my CRs merged, it's Xmas! ;-)

lehors (Thu, 08 Feb 2018 19:13:11 GMT):
wow, 2 of my CRs merged, plus 1 yesterday, it's Xmas! ;-)

lehors (Thu, 08 Feb 2018 19:13:11 GMT):
wow, 2 of my CRs merged, plus 1 yesterday: it's Xmas! ;-)

mastersingh24 (Thu, 08 Feb 2018 20:21:26 GMT):
:cry:

aambati (Fri, 09 Feb 2018 15:36:12 GMT):
@mastersingh24 @yacovm can one of you please review following change sets that already have a +2, https://gerrit.hyperledger.org/r/c/17349/, https://gerrit.hyperledger.org/r/c/17037/, https://gerrit.hyperledger.org/r/c/15455/

yacovm (Fri, 09 Feb 2018 15:54:45 GMT):
I merged the first 2

aambati (Fri, 09 Feb 2018 15:58:56 GMT):
thank you Yacov!!

joe-alewine (Fri, 09 Feb 2018 16:27:50 GMT):
Easy one here, just renaming a doc: https://gerrit.hyperledger.org/r/#/c/17727/

aambati (Sat, 10 Feb 2018 00:07:13 GMT):
@mastersingh24 @yacovm another one pls review https://gerrit.hyperledger.org/r/c/17319/

cbf (Mon, 12 Feb 2018 11:59:11 GMT):
https://gerrit.hyperledger.org/r/c/17635/

cbf (Tue, 13 Feb 2018 14:33:52 GMT):
https://gerrit.hyperledger.org/r/c/13023/

dave.enyeart (Tue, 13 Feb 2018 17:44:28 GMT):
https://gerrit.hyperledger.org/r/#/c/17425/ - handle couchdb index creation failures more gracefully

dave.enyeart (Tue, 13 Feb 2018 18:39:03 GMT):
https://gerrit.hyperledger.org/r/#/c/17657/ - validate against reserved fields in couchdb json

luomin (Wed, 14 Feb 2018 03:04:35 GMT):
can anyone review this? https://gerrit.hyperledger.org/r/#/c/16719/ document error. verified by two.

davidkhala (Wed, 14 Feb 2018 03:41:33 GMT):
https://gerrit.hyperledger.org/r/#/c/17889/ node-sdk change about eslint rules update in gulpjs

kostas (Wed, 14 Feb 2018 14:44:08 GMT):
A quick one that addresses the bug noted on the mailing list yesterday: https://gerrit.hyperledger.org/r/c/17901/

dave.enyeart (Wed, 14 Feb 2018 17:45:58 GMT):
quick doc update: https://gerrit.hyperledger.org/r/#/c/17371/

daveryIBM (Thu, 15 Feb 2018 14:01:54 GMT):
Has left the channel.

kostas (Thu, 15 Feb 2018 18:49:28 GMT):
The folks working on the ordering service took a stab at a FAQ. Review when you get a moment? https://gerrit.hyperledger.org/r/c/14971/

kostas (Thu, 15 Feb 2018 18:49:28 GMT):
Ordering service folks took a stab at a FAQ. Review when you get a moment? https://gerrit.hyperledger.org/r/c/14971/

rameshthoomu (Thu, 15 Feb 2018 20:28:47 GMT):
@scottz could you please review this https://gerrit.hyperledger.org/r/#/c/17949/

joe-alewine (Thu, 15 Feb 2018 23:21:28 GMT):
Documenting the new script for "Adding an Org to a Channel" (formerly known as "Reconfiguring Your First Network"): https://gerrit.hyperledger.org/r/#/c/17967/

kostas (Fri, 16 Feb 2018 15:26:30 GMT):
https://gerrit.hyperledger.org/r/c/17241/

kostas (Fri, 16 Feb 2018 15:26:58 GMT):
https://gerrit.hyperledger.org/r/c/17891/

jyellick (Fri, 16 Feb 2018 16:32:45 GMT):
This one has been waiting on a second +2 for a couple days now https://gerrit.hyperledger.org/r/c/17891/

jyellick (Fri, 16 Feb 2018 16:32:45 GMT):
~This one has been waiting on a second +2 for a couple days now https://gerrit.hyperledger.org/r/c/17891/~

harsha (Mon, 19 Feb 2018 14:53:18 GMT):
https://gerrit.hyperledger.org/r/#/c/18059/ :- Update go version in fabric-baseaimge

harsha (Mon, 19 Feb 2018 14:53:18 GMT):
https://gerrit.hyperledger.org/r/#/c/18059/ :- Update go version in fabric-baseimage

philviana (Mon, 19 Feb 2018 15:23:11 GMT):
https://gerrit.hyperledger.org/r/#/c/16095/ - Improvements to the bootstrap script. This was uploaded on Dec 10

philviana (Mon, 19 Feb 2018 15:24:07 GMT):
@muralisr Could you help put some traction on this one? It's already got +1 from you. It's been over 2 months. Thanks

rameshthoomu (Tue, 20 Feb 2018 00:47:43 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/18041/

rameshthoomu (Tue, 20 Feb 2018 00:48:02 GMT):
Ready to go https://gerrit.hyperledger.org/r/#/c/18039/

Ratnakar (Tue, 20 Feb 2018 15:01:19 GMT):
https://gerrit.hyperledger.org/r/#/c/18075/

philviana (Tue, 20 Feb 2018 19:35:12 GMT):
https://gerrit.hyperledger.org/r/#/c/16095 -

joe-alewine (Wed, 21 Feb 2018 12:43:43 GMT):
Updating a Channel Configuration: https://gerrit.hyperledger.org/r/#/c/18113/ Staged here: http://joestaging-fabric.readthedocs.io/en/latest/config_update.html

Sneljo (Wed, 21 Feb 2018 15:31:40 GMT):
Testing for rich queries, still needs a +2 https://gerrit.hyperledger.org/r/c/16325/

Sneljo (Wed, 21 Feb 2018 15:36:26 GMT):
Testing rich queries would be cool, just saying

baohua (Thu, 22 Feb 2018 05:44:12 GMT):
the pkcs11 vendor lib break fabric-ca with golang 1.9.4. this patchset update the version to the same one with the fabric codebase, welcome to help review, thanks! https://gerrit.hyperledger.org/r/#/c/18197

baohua (Thu, 22 Feb 2018 05:44:12 GMT):
the pkcs11 vendor lib breaks fabric-ca with golang 1.9.4. this patchset update the version to the same one with the fabric codebase, welcome to help review, thanks! https://gerrit.hyperledger.org/r/#/c/18197

skarim (Thu, 22 Feb 2018 12:58:05 GMT):
https://gerrit.hyperledger.org/r/#/c/18105 Easy fix on fabric-ca sample, needs one more +2

rameshthoomu (Thu, 22 Feb 2018 14:25:32 GMT):
https://gerrit.hyperledger.org/r/#/c/18179/

jyellick (Thu, 22 Feb 2018 15:44:52 GMT):
https://gerrit.hyperledger.org/r/c/18159/ https://gerrit.hyperledger.org/r/c/18161/ ^ Two relatively short command summary docs

jyellick (Thu, 22 Feb 2018 15:48:59 GMT):
https://gerrit.hyperledger.org/r/c/18183/ ^ Needs a second +2, note, this is for the release branch

cbf (Thu, 22 Feb 2018 18:23:59 GMT):
@jyellick @weeds @rameshthoomu @bmos299 https://jira.hyperledger.org/browse/FAB-8013?focusedCommentId=40582&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-40582

jyellick (Thu, 22 Feb 2018 18:24:29 GMT):
Perfect, thanks @cbf!

cbf (Thu, 22 Feb 2018 18:24:37 GMT):
we'll use a config/ directory sibling of bin/ in the tarball

cbf (Thu, 22 Feb 2018 18:25:05 GMT):
pls work with @rameshthoomu to implement

rameshthoomu (Thu, 22 Feb 2018 18:25:30 GMT):
ok will work with @jyellick and include them in the release process

cbf (Thu, 22 Feb 2018 18:25:35 GMT):
danke

wlahti (Thu, 22 Feb 2018 19:51:56 GMT):
Two peer CLI documents ready for review: - https://gerrit.hyperledger.org/r/c/18213/ (peer chaincode doc)

wlahti (Thu, 22 Feb 2018 19:51:56 GMT):
Two peer CLI documents ready for review: - https://gerrit.hyperledger.org/r/c/18213/ (peer chaincode doc) - https://gerrit.hyperledger.org/r/c/18223/ (peer logging doc)

cbf (Fri, 23 Feb 2018 01:10:33 GMT):
https://gerrit.hyperledger.org/r/c/18233/ @odowdaibm @mastersingh24 @dave.enyeart

cbf (Fri, 23 Feb 2018 18:13:53 GMT):
needs another https://gerrit.hyperledger.org/r/c/18175/

joe-alewine (Fri, 23 Feb 2018 18:53:54 GMT):
Capability Requirements doc (not related to upgrade as that will be covered in upgrade) now available for review: https://gerrit.hyperledger.org/r/#/c/18291 Content here is very similar to what was already merged in this doc -- http://hyperledger-fabric.readthedocs.io/en/latest/upgrade_to_one_point_one.html -- but with some material taken out that will be incorporated in the upcoming "Upgrading Components" doc/tutorial, and a little reorganizing

baohua (Sat, 24 Feb 2018 13:16:11 GMT):
https://gerrit.hyperledger.org/r/#/c/12735/, welcome to help review :)

dave.enyeart (Sat, 24 Feb 2018 13:34:40 GMT):
Need one more +2 for supporting dots and dashes in MSP IDs: https://jira.hyperledger.org/browse/FAB-8453 https://gerrit.hyperledger.org/r/18323 https://gerrit.hyperledger.org/r/18325 https://gerrit.hyperledger.org/r/18329

dave.enyeart (Sat, 24 Feb 2018 13:37:34 GMT):
@muralisr ^^^^^ We are approaching code freeze, but if you agree it is low risk and helpful we could merge it.

dave.enyeart (Sat, 24 Feb 2018 13:37:52 GMT):
Need one more +2 for supporting dots and dashes in MSP IDs: https://jira.hyperledger.org/browse/FAB-8453 https://gerrit.hyperledger.org/r/18323 https://gerrit.hyperledger.org/r/18325 https://gerrit.hyperledger.org/r/18329

muralisr (Sat, 24 Feb 2018 14:11:15 GMT):
@dave.enyeart will look and respond today

muralisr (Sat, 24 Feb 2018 14:20:14 GMT):
@dave.enyeart @baohua no exertnal changes to https://gerrit.hyperledger.org/r/#/c/12735, merged

rameshthoomu (Sat, 24 Feb 2018 20:17:24 GMT):
https://gerrit.hyperledger.org/r/#/c/18345/ https://gerrit.hyperledger.org/r/#/c/18349/

rameshthoomu (Sat, 24 Feb 2018 20:17:24 GMT):
https://gerrit.hyperledger.org/r/#/c/18345/ https://gerrit.hyperledger.org/r/#/c/18349/ https://gerrit.hyperledger.org/r/#/c/18353/

davidkhala (Sun, 25 Feb 2018 08:55:21 GMT):
https://gerrit.hyperledger.org/r/#/c/18369/ fix some existing eslint error

mastersingh24 (Sun, 25 Feb 2018 10:55:41 GMT):
https://gerrit.hyperledger.org/r/18371 I marked it as an improvement (which it is) but we might want to consider merging it. The JIRA and commit message have the details, but basically it makes cryptogen NodeOUs match those used by fabric-ca

cbf (Sun, 25 Feb 2018 16:09:00 GMT):
@muralisr you need to sign-off on https://gerrit.hyperledger.org/r/c/18213/10 please

cbf (Sun, 25 Feb 2018 16:10:34 GMT):
otherwise, GTG

muralisr (Sun, 25 Feb 2018 16:21:57 GMT):
oops, will do that @cbf

mastersingh24 (Sun, 25 Feb 2018 17:24:27 GMT):
NodeSDK support for packaging chaincode metadata: https://gerrit.hyperledger.org/r/18385

cbf (Sun, 25 Feb 2018 18:34:26 GMT):
https://gerrit.hyperledger.org/r/c/18213/ needs one more +2

mastersingh24 (Sun, 25 Feb 2018 21:27:37 GMT):
Both of these now needed: https://gerrit.hyperledger.org/r/#/q/owner:gari.r.singh%2540gmail.com+status:open (https://chat.hyperledger.org/channel/fabric-pr-review?msg=ewwjFJL7qZvc6BfaB)

davidkhala (Mon, 26 Feb 2018 07:36:27 GMT):
@mastersingh24 https://gerrit.hyperledger.org/r/#/c/18393/ successfully verified. Please review

mastersingh24 (Mon, 26 Feb 2018 11:00:19 GMT):
@davidkhala - added a comment

dave.enyeart (Mon, 26 Feb 2018 18:55:11 GMT):
A few easy doc reviews:

dave.enyeart (Mon, 26 Feb 2018 18:55:14 GMT):
https://gerrit.hyperledger.org/r/#/c/18167/

dave.enyeart (Mon, 26 Feb 2018 18:55:20 GMT):
https://gerrit.hyperledger.org/r/#/c/18169/

dave.enyeart (Mon, 26 Feb 2018 18:55:28 GMT):
https://gerrit.hyperledger.org/r/#/c/18225/

yacovm (Mon, 26 Feb 2018 19:05:10 GMT):
@dave.enyeart - the bottom one has falsities. Nevertheless I decide to merge it, as 2 others are rebased on top of it.

yacovm (Mon, 26 Feb 2018 19:05:34 GMT):
I suggest @aambati or someone else pushes an update that fixes the `node start` doc

dave.enyeart (Mon, 26 Feb 2018 19:43:02 GMT):
@muralisr Could you take a look at the comments in https://gerrit.hyperledger.org/r/#/c/18167/ ? Thanks @yacovm for identifying.

muralisr (Mon, 26 Feb 2018 19:43:37 GMT):
@dave.enyeart will do soon

muralisr (Mon, 26 Feb 2018 21:46:24 GMT):
@dave.enyeart @yacovm responded

dave.enyeart (Mon, 26 Feb 2018 21:47:10 GMT):
@muralisr thanks. And I responded to your response with a CR: https://gerrit.hyperledger.org/r/#/c/18441/ :)

dave.enyeart (Mon, 26 Feb 2018 21:47:16 GMT):
could you review?

muralisr (Mon, 26 Feb 2018 22:05:36 GMT):
perfect, merged @dave.enyeart

dave.enyeart (Mon, 26 Feb 2018 22:11:17 GMT):
quick one: https://gerrit.hyperledger.org/r/#/c/18437/

dave.enyeart (Mon, 26 Feb 2018 22:11:41 GMT):
@smithbk or anybody ^^^^^^^

dave.enyeart (Mon, 26 Feb 2018 22:11:41 GMT):
@smithbk ^^^^^^^

C0rWin (Mon, 26 Feb 2018 22:20:46 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=r8jaoB8kqDyBdoD4A) @dave.enyeart has CI failures

dave.enyeart (Mon, 26 Feb 2018 22:52:13 GMT):
@smithbk @skarim @aambati Can you look at the CI failure? I think we'll want the domain experts to all take a close look at these last minute changes.

davidkhala (Tue, 27 Feb 2018 06:24:45 GMT):
@mastersingh24 Dear Gari , please review my new patch, Thanks. https://gerrit.hyperledger.org/r/#/c/18393/

davidkhala (Tue, 27 Feb 2018 08:44:01 GMT):
@mastersingh24 https://gerrit.hyperledger.org/r/#/c/18393 I created a new patch set. Welcome comment

Sneljo (Tue, 27 Feb 2018 13:01:07 GMT):
what do I need to do to get this change merged? https://gerrit.hyperledger.org/r/c/16325/

joe-alewine (Tue, 27 Feb 2018 20:39:53 GMT):
Identity.md was accidentally kicked out of the TOC when Membership.md was merged. This fixes that: https://gerrit.hyperledger.org/r/#/c/18493/

dave.enyeart (Tue, 27 Feb 2018 23:51:51 GMT):
@davidkhala @Sneljo we can consider those for 1.2 after we cut 1.1 release. release candidate 1 should get cut this week and then 1.1 GA likely in a couple weeks.

dave.enyeart (Tue, 27 Feb 2018 23:52:32 GMT):
@mastersingh24 and others... Mutual TLS for Node SDK ready for review: https://gerrit.hyperledger.org/r/#/c/18087/

cbf (Wed, 28 Feb 2018 01:16:59 GMT):
not that it is critical for 1.1, but given I was trying to debug WTF was going on with BYFN and the output generated is so unhelpful to actually, you know, debugging, I have submitted this CR to improve the UX https://gerrit.hyperledger.org/r/18499

cbf (Wed, 28 Feb 2018 01:18:07 GMT):
basically, adds shell debug logging of all fabric commands in the CLI and modifies CORE_LOGGING_LEVEL to ERROR... also, I updated .gitignore to ignore all the new crap we are adding

davidkhala (Wed, 28 Feb 2018 05:13:12 GMT):
@dave.enyeart Dear David, I saw https://gerrit.hyperledger.org/r/#/c/18087/ and found the commit is singed by two authors. As a new contributor, I am curious about how to do this. Is there any guideline about invite and cooperate with other contributors in single CR?

dave.enyeart (Wed, 28 Feb 2018 06:22:47 GMT):
@davidkhala Simply reach out to the initial contributor either via rocket.chat or gerrit review or jira to coordinate, and then you can Checkout the latest patch under gerrit Download link, make your updates, `git commit -s --amend` to update and sign the commit, then push as normal.

dave.enyeart (Wed, 28 Feb 2018 07:32:35 GMT):
https://gerrit.hyperledger.org/r/#/c/18455/ Version checking for BYFN - recommended for 1.1.

dave.enyeart (Wed, 28 Feb 2018 08:05:41 GMT):
https://gerrit.hyperledger.org/r/#/c/18509/ BYFN persistence

dave.enyeart (Wed, 28 Feb 2018 08:47:06 GMT):
https://gerrit.hyperledger.org/r/#/c/18515/ BYFN: Fix IMAGE_TAG for couchdb

Sneljo (Wed, 28 Feb 2018 10:01:00 GMT):
@dave.enyeart allright, cool

yacovm (Wed, 28 Feb 2018 13:42:58 GMT):
Tune down logging severity from WARN to DEBUG to not scare users https://gerrit.hyperledger.org/r/#/c/18517/

joe-alewine (Wed, 28 Feb 2018 14:47:12 GMT):
Sunsetting the "Procedure to Upgrade to 1.1" from the TOC as the material is now covered in other merged docs: https://gerrit.hyperledger.org/r/#/c/18521/

philviana (Wed, 28 Feb 2018 15:14:39 GMT):
https://gerrit.hyperledger.org/r/#/c/16095/

philviana (Wed, 28 Feb 2018 15:14:43 GMT):
Can someone please look into this?

joe-alewine (Wed, 28 Feb 2018 16:07:53 GMT):
Put correct Channel Update doc ("Adding an Org to a Channel") doc in TOC: https://gerrit.hyperledger.org/r/#/c/18523/

joe-alewine (Wed, 28 Feb 2018 18:01:24 GMT):
Fixing links in Identity and Membership documentation: https://gerrit.hyperledger.org/r/c/18531/

joe-alewine (Wed, 28 Feb 2018 18:26:19 GMT):
Add link to Fabric-CA upgrade material in Upgrading Your Network Components doc: https://gerrit.hyperledger.org/r/c/18533/

cbf (Thu, 01 Mar 2018 01:42:24 GMT):
these two need one more +2 https://gerrit.hyperledger.org/r/c/18525/ and https://gerrit.hyperledger.org/r/c/18499/

davidkhala (Thu, 01 Mar 2018 10:43:50 GMT):
Dear maintianers, I am interested to be one of you. Is there any requirements I should meet besides of nomination mechanism?

davidkhala (Thu, 01 Mar 2018 10:47:34 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=qg38pLfAemyix6YMS) @dave.enyeart thanks it works

cbf (Thu, 01 Mar 2018 13:53:42 GMT):
https://gerrit.hyperledger.org/r/18589 needs one more to address minor format issue

wlahti (Thu, 01 Mar 2018 15:56:21 GMT):
Noticed one minor detail we were missing in the channel update tutorial to make the tutorial and log output consistent for end users: https://gerrit.hyperledger.org/r/c/18597/

cbf (Fri, 02 Mar 2018 14:34:43 GMT):
https://gerrit.hyperledger.org/r/c/18679/ please

mastersingh24 (Sat, 03 Mar 2018 14:38:32 GMT):
quick one if anyone around: https://gerrit.hyperledger.org/r/18703 (my efforts to make amcl compatible with dep)

sudheesh001 (Mon, 05 Mar 2018 08:56:28 GMT):
Has joined the channel.

sudheesh001 (Mon, 05 Mar 2018 08:57:08 GMT):
If anyone is around from the maintainers of #fabric-sdk-node Requesting review on JIRA-8651 , Patch for review at https://gerrit.hyperledger.org/r/#/c/18721/

yacovm (Mon, 05 Mar 2018 20:08:51 GMT):
a simple one https://gerrit.hyperledger.org/r/#/c/17947/

cbf (Mon, 05 Mar 2018 20:59:42 GMT):
https://chat.hyperledger.org/channel/fabric-documentation?msg=6EKhg5uAhQ2vA5J9K

cbf (Mon, 05 Mar 2018 21:16:00 GMT):
here's the build output https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-rtd-verify-master/314/html/

rjones (Tue, 06 Mar 2018 02:17:27 GMT):
cbf

rjones (Tue, 06 Mar 2018 02:17:31 GMT):
mastersingh24

rjones (Tue, 06 Mar 2018 02:17:36 GMT):
dave.enyeart

rjones (Tue, 06 Mar 2018 02:17:44 GMT):
Has left the channel.

nirro (Tue, 06 Mar 2018 13:42:00 GMT):
Has joined the channel.

Sneljo (Wed, 07 Mar 2018 13:47:21 GMT):
https://gerrit.hyperledger.org/r/#/c/18725/ could we merge node-fabric-shim typings to master?

yacovm (Wed, 07 Mar 2018 16:14:54 GMT):
2 bug fixes in gossip :( https://gerrit.hyperledger.org/r/#/c/18819/ `master` https://gerrit.hyperledger.org/r/#/c/18821/ `release`

rameshthoomu (Wed, 07 Mar 2018 16:51:17 GMT):
https://gerrit.hyperledger.org/r/#/c/18467/ - supports docker multi-arch/platform

rennman (Wed, 07 Mar 2018 16:55:07 GMT):
https://gerrit.hyperledger.org/r/#/c/18399/ -- fabric-samples allow custom affiliations -- tested/ verified needs merge ... thanks

dave.enyeart (Wed, 07 Mar 2018 18:08:41 GMT):
quick doc fix:

dave.enyeart (Wed, 07 Mar 2018 18:08:54 GMT):
https://gerrit.hyperledger.org/r/#/c/18831/ `release-1.1`

dave.enyeart (Wed, 07 Mar 2018 18:08:54 GMT):
https://gerrit.hyperledger.org/r/#/c/18831/

dave.enyeart (Wed, 07 Mar 2018 18:09:16 GMT):
https://gerrit.hyperledger.org/r/#/c/18829/

wlahti (Wed, 07 Mar 2018 20:28:56 GMT):
Small update to the channel update tutorial regarding gossip leader election: https://gerrit.hyperledger.org/r/c/18833/. Once this one is ready, I'll cherry-pick it to the `release-1.1` branch

philviana (Wed, 07 Mar 2018 21:24:49 GMT):
https://gerrit.hyperledger.org/r/#/c/18855/

philviana (Wed, 07 Mar 2018 21:25:33 GMT):
This is a `help-wanted` item that I committed on Dec 10 but never got a +2 and others committed on top of my change. I just rewrote my change. Please review asap so my work is not wasted. Thank you!

cbf (Thu, 08 Mar 2018 00:52:14 GMT):
https://gerrit.hyperledger.org/r/c/18749/ please

sudheesh001 (Thu, 08 Mar 2018 10:13:49 GMT):
https://gerrit.hyperledger.org/r/#/c/18867/ for review please. The log of the node8s machine seems to be unrelated to the change, Can someone help retrigger the CI for that or point me to where I might be making a mistake? `fabric-sdk-node`

philviana (Thu, 08 Mar 2018 15:56:34 GMT):
https://gerrit.hyperledger.org/r/#/c/18855/ for review. Marked as help-wanted

mastersingh24 (Thu, 08 Mar 2018 19:49:34 GMT):
Two easy ones: https://gerrit.hyperledger.org/r/18837 https://gerrit.hyperledger.org/r/18839

cbf (Thu, 08 Mar 2018 21:33:26 GMT):
an easy one please (only asked four times now)) needs to be cherry-picked to both 1.2 and 1.1

sheehan (Thu, 08 Mar 2018 21:53:40 GMT):
Most may already have it installed, but if you need to install Sphinx on High Sierra to review the doc CRs, there were some hoops I had to jump through. The procedure was ``` sudo pip install Sphinx --ignore-installed six sudo -H pip install sphinx_rtd_theme sudo pip install recommonmark ```

cbf (Thu, 08 Mar 2018 21:59:25 GMT):
note that Jenkins actually builds docs now;-) https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-rtd-verify-master/314/html/

cbf (Thu, 08 Mar 2018 21:59:39 GMT):
though it won't stick around for too long, it is still there

dave.enyeart (Thu, 08 Mar 2018 22:44:49 GMT):
Fix error handling in byfn, HIgh priority to fix CI failures: https://gerrit.hyperledger.org/r/#/c/18885/

sudheesh001 (Fri, 09 Mar 2018 06:03:12 GMT):
An easy one here: https://gerrit.hyperledger.org/r/#/c/18917/ :) Thanks

sudheesh001 (Fri, 09 Mar 2018 09:53:56 GMT):
This was an old change request which hasn't received attention, Could someone maintaining `fabric-samples` take a look at this? https://gerrit.hyperledger.org/r/#/c/16541/

philviana (Fri, 09 Mar 2018 14:40:09 GMT):
https://gerrit.hyperledger.org/r/#/c/18855/ very easy one, just need to run the bootstrap script to download files. Takes 2 minutes. Appreciate it

wlahti (Fri, 09 Mar 2018 15:46:21 GMT):
Small doc update to clarify the node chaincode install path from peer CLI: https://gerrit.hyperledger.org/r/c/18927/ . Once this has been reviewed, I'll cherry-pick this to the `release-1.1` branch.

dave.enyeart (Fri, 09 Mar 2018 21:33:12 GMT):
Fix for chaincode TLS: https://jira.hyperledger.org/browse/FAB-8757 . Could the certificate experts take a look please @yacovm @elli-androulaki @adc @aso @smithbk

yacovm (Fri, 09 Mar 2018 21:34:41 GMT):
sure, especially since I knew this one was on the way ;)

yacovm (Fri, 09 Mar 2018 21:36:54 GMT):
I commented on both change sets (1.1, maser) @sanchezl

yacovm (Fri, 09 Mar 2018 21:38:46 GMT):
I have to say i didn't expect the java x509 library to puke a TLS certificate with no subject... the node.js and golang were fine with it :/

yacovm (Fri, 09 Mar 2018 21:42:28 GMT):
I have to say, had i been a certificate expert i'd expect the java x509 library to puke a TLS certificate with no subject... and not think that since the node.js and golang were fine with it, it's OK :/

wlahti (Fri, 09 Mar 2018 22:13:57 GMT):
Realized we also need to update the description of the path flag for the CLI `peer chaincode package` command: https://gerrit.hyperledger.org/r/c/18987/ . This one should also be cherry-picked to `release-1.1`.

dave.enyeart (Fri, 09 Mar 2018 23:14:00 GMT):
@wlahti +2ed and cherry picked. Note that you as the submitter can cherry pick yourself in Gerrit UI :)

dave.enyeart (Fri, 09 Mar 2018 23:14:26 GMT):
1.1 docs are still open for business

wlahti (Fri, 09 Mar 2018 23:14:47 GMT):
yep, I know :) you maintainers just did it before I did today.

wlahti (Fri, 09 Mar 2018 23:15:18 GMT):
and thanks!

dave.enyeart (Fri, 09 Mar 2018 23:15:29 GMT):
happy weekend everybody

sanchezl (Sat, 10 Mar 2018 06:21:44 GMT):
• https://gerrit.hyperledger.org/r/c/19005/ - the experimental java chaincode support was never updated for mutual TLS.

cbf (Sat, 10 Mar 2018 13:24:41 GMT):
This is getting old, people. Asking AGAIN for a review to merge this change. I shouldn't need to ask. No one should. https://gerrit.hyperledger.org/r/c/18749/

cbf (Sat, 10 Mar 2018 13:25:53 GMT):
https://gerrit.hyperledger.org/r/c/18975/ is cherry-picked CR for 1.1

philviana (Sat, 10 Mar 2018 14:39:48 GMT):
@cbf I saw several code reviews for 18749. How many are necessary?

philviana (Sat, 10 Mar 2018 14:39:52 GMT):
I just gave it +1

C0rWin (Mon, 12 Mar 2018 08:30:45 GMT):
https://gerrit.hyperledger.org/r/#/c/19045/ removing ledger dependencies from gossip state UT (pretty trivial one)

C0rWin (Mon, 12 Mar 2018 08:42:15 GMT):
https://gerrit.hyperledger.org/r/#/c/19049/ parallelization of gossip state UT

rjones (Mon, 12 Mar 2018 23:36:40 GMT):
Has joined the channel.

rjones (Mon, 12 Mar 2018 23:37:46 GMT):
Builds subsequent to today will allow you to hide Jenkins spew in the Gerrit UI natively. You need to be using the old UI. use the "hide tagged comments" button. if you want to see how it works, examine this change using the old UI: https://gerrit.hyperledger.org/r/#/c/19059/

davidkhala (Tue, 13 Mar 2018 13:12:45 GMT):
working on https://gerrit.hyperledger.org/r/#/c/19087/, welcome comment on the design idea.

susmita (Tue, 13 Mar 2018 13:43:21 GMT):
Has joined the channel.

susmita (Tue, 13 Mar 2018 13:46:24 GMT):
https://gerrit.hyperledger.org/r/#/c/18285/ please review

rjones (Tue, 13 Mar 2018 14:21:08 GMT):
Has left the channel.

mastersingh24 (Tue, 13 Mar 2018 17:10:21 GMT):
This looks scarier than it is: https://gerrit.hyperledger.org/r/19113 moves us from govendor to dep and cleans up the vendor folder in the process would be good to get this one in soon

philviana (Tue, 13 Mar 2018 21:29:42 GMT):
https://gerrit.hyperledger.org/r/#/c/16095/

philviana (Tue, 13 Mar 2018 21:29:51 GMT):
please review

C0rWin (Tue, 13 Mar 2018 23:41:22 GMT):
https://gerrit.hyperledger.org/r/#/c/19049/

C0rWin (Tue, 13 Mar 2018 23:41:40 GMT):
https://gerrit.hyperledger.org/r/#/c/18027/

dsanchezseco (Wed, 14 Mar 2018 13:38:42 GMT):
Has joined the channel.

dsanchezseco (Wed, 14 Mar 2018 13:39:07 GMT):
easy one: 2 if's https://gerrit.hyperledger.org/r/#/c/19155/

dave.enyeart (Wed, 14 Mar 2018 16:10:46 GMT):
important one to review for 1.1: https://gerrit.hyperledger.org/r/#/c/19157/

dave.enyeart (Wed, 14 Mar 2018 21:02:01 GMT):
fix doc links:

dave.enyeart (Wed, 14 Mar 2018 21:02:06 GMT):
https://gerrit.hyperledger.org/r/#/c/19161/

dave.enyeart (Wed, 14 Mar 2018 21:02:18 GMT):
https://gerrit.hyperledger.org/r/#/c/19159/

mastersingh24 (Wed, 14 Mar 2018 21:50:59 GMT):
@dave.enyeart - merged the one for release-1.1 but I think the one for master should reference "master" docs?

dave.enyeart (Wed, 14 Mar 2018 22:20:43 GMT):
@mastersingh24 moved the discussion to https://gerrit.hyperledger.org/r/#/c/19159/

davidkhala (Thu, 15 Mar 2018 06:53:23 GMT):
https://gerrit.hyperledger.org/r/#/c/19087/ updated

davidkhala (Fri, 16 Mar 2018 03:44:37 GMT):
@zhaochy helped you to rebase that https://gerrit.hyperledger.org/r/#/c/18717/

zhaochy (Fri, 16 Mar 2018 03:44:37 GMT):
Has joined the channel.

cbf (Fri, 16 Mar 2018 14:27:52 GMT):
easy one https://gerrit.hyperledger.org/r/c/19271/

davidkhala (Fri, 16 Mar 2018 15:40:23 GMT):
@mastersingh24 created a simple readme for amcl https://gerrit.hyperledger.org/r/#/c/19291/

cbf (Fri, 16 Mar 2018 16:45:37 GMT):
https://gerrit.hyperledger.org/r/c/19293/ please - fixes broken links - will need cherry-picking

VinayChaudhary (Sat, 17 Mar 2018 15:51:09 GMT):
Has joined the channel.

cbf (Sat, 17 Mar 2018 18:47:56 GMT):
reminder ^^ please - easy one

rjones (Sun, 18 Mar 2018 13:46:59 GMT):
Has joined the channel.

rjones (Sun, 18 Mar 2018 13:47:09 GMT):
trivial update: https://gerrit.hyperledger.org/r/#/c/19351/

rjones (Sun, 18 Mar 2018 13:47:09 GMT):
https://gerrit.hyperledger.org/r/#/c/19351/

rjones (Mon, 19 Mar 2018 01:21:38 GMT):
trivial updates: https://gerrit.hyperledger.org/r/#/c/19361/ (master) https://gerrit.hyperledger.org/r/#/c/19363/ (release-1.1)

davidkhala (Mon, 19 Mar 2018 04:57:14 GMT):
https://gerrit.hyperledger.org/r/#/c/19375/

davidkhala (Mon, 19 Mar 2018 08:42:00 GMT):
it is weird that node8z CI fail repeatedly.

rameshthoomu (Mon, 19 Mar 2018 19:01:58 GMT):
@davidkhala I see `curl` is failed to download required artifacts to build fabric-orderer image.. ```00:06:01.146 curl: (18) transfer closed with 1018494 bytes remaining to read 00:06:01.150

rameshthoomu (Mon, 19 Mar 2018 19:02:20 GMT):
Could you please retrigger again with `reverify-node8z`

C0rWin (Mon, 19 Mar 2018 21:56:28 GMT):
https://gerrit.hyperledger.org/r/#/c/19359/ moving `vsccValidator` into separate file

davidkhala (Tue, 20 Mar 2018 01:50:38 GMT):
https://gerrit.hyperledger.org/r/#/c/19375/ @rameshthoomu thanks and build passed

davidkhala (Tue, 20 Mar 2018 02:03:14 GMT):
https://gerrit.hyperledger.org/r/#/c/19423/ remove node 6 badge in readme

pandrejko (Tue, 20 Mar 2018 13:56:24 GMT):
Has joined the channel.

wjzheng (Tue, 20 Mar 2018 19:03:14 GMT):
Has joined the channel.

wjzheng (Tue, 20 Mar 2018 19:06:18 GMT):
https://gerrit.hyperledger.org/r/#/c/19489/ typo correction in readwrite.rst file for documentation

rameshthoomu (Tue, 20 Mar 2018 20:25:35 GMT):
@smithbk https://gerrit.hyperledger.org/r/#/c/19457/ - minor change

smithbk (Tue, 20 Mar 2018 21:13:39 GMT):
@rameshthoomu done

sanchezl (Wed, 21 Mar 2018 13:43:54 GMT):
• https://gerrit.hyperledger.org/r/c/18963/

sanchezl (Wed, 21 Mar 2018 13:47:02 GMT):
• https://gerrit.hyperledger.org/r/c/18965/

rameshthoomu (Wed, 21 Mar 2018 14:10:14 GMT):
Maven binary source change in javaenv dockerimage: https://gerrit.hyperledger.org/r/#/c/19529/ https://gerrit.hyperledger.org/r/#/c/19531/

sanchezl (Wed, 21 Mar 2018 19:09:12 GMT):
• https://gerrit.hyperledger.org/r/c/19535/

alexliu (Thu, 22 Mar 2018 04:22:05 GMT):
Has joined the channel.

alexliu (Thu, 22 Mar 2018 05:33:42 GMT):
https://gerrit.hyperledger.org/r/#/c/19583/ modify function clearContainers in byfn.sh

mrkiouak (Thu, 22 Mar 2018 14:40:38 GMT):
https://gerrit.hyperledger.org/r/#/c/19597/ minor chaintool improvement supporting protobuf "oneof" type

alexliu (Thu, 22 Mar 2018 15:05:28 GMT):
https://gerrit.hyperledger.org/r/#/c/19583/ updated

joe-alewine (Thu, 22 Mar 2018 18:19:05 GMT):
Add disclaimer to NCAP doc: https://gerrit.hyperledger.org/r/c/19599/

joe-alewine (Thu, 22 Mar 2018 18:20:11 GMT):
Final cleanup of Identity.md and Membership.md: https://gerrit.hyperledger.org/r/c/19547/ https://gerrit.hyperledger.org/r/c/19573/

joe-alewine (Thu, 22 Mar 2018 18:20:11 GMT):
Final cleanup of Identity and Membership concept docs: https://gerrit.hyperledger.org/r/c/19547/ https://gerrit.hyperledger.org/r/c/19573/

rjones (Thu, 22 Mar 2018 19:04:27 GMT):
Has left the channel.

pandrejko (Thu, 22 Mar 2018 19:43:39 GMT):
Glossary updates for Org, member, consortium, anchor peer and ledger https://gerrit.hyperledger.org/r/#/c/19617/

sanchezl (Thu, 22 Mar 2018 20:36:08 GMT):
• https://gerrit.hyperledger.org/r/c/19535/ [FAB-9028] marshall client.key in PKCS#8 format

mastersingh24 (Fri, 23 Mar 2018 14:44:24 GMT):
Two easy ones .... https://gerrit.hyperledger.org/r/#/q/owner:%22Rob+Day%22+status:open

pandrejko (Fri, 23 Mar 2018 15:55:22 GMT):
Fixed some Note formatting and removed a bad reference to a swimlane https://gerrit.hyperledger.org/r/#/c/19681/diagram

rjones (Fri, 23 Mar 2018 16:37:56 GMT):
Has joined the channel.

rjones (Fri, 23 Mar 2018 16:38:21 GMT):
@cbf @dave.enyeart @mastersingh24 I need a hand. https://gerrit.hyperledger.org/r/#/c/19637/ https://gerrit.hyperledger.org/r/#/c/19635/

rjones (Fri, 23 Mar 2018 16:39:15 GMT):
Also see: https://chat.hyperledger.org/channel/fabric-maintainers?msg=dmMukLemWP3SbqLB5

joe-alewine (Fri, 23 Mar 2018 17:55:04 GMT):
We get a lot of questions about anchor peers. In addition to the glossary updates (see Pam's post above), we thought it would be a good idea to add a short section on anchor peers to the gossip dissemination protocol doc. https://gerrit.hyperledger.org/r/#/c/19689/

pandrejko (Fri, 23 Mar 2018 18:32:22 GMT):
(Corrected Link) Fixed some Note formatting and removed a bad reference to a swimlane https://gerrit.hyperledger.org/r/#/c/19681/

rameshthoomu (Fri, 23 Mar 2018 19:58:17 GMT):
Update Base and Prev version in fabric and fabric-ca master branches https://gerrit.hyperledger.org/r/#/q/FAB-9043

rameshthoomu (Fri, 23 Mar 2018 20:03:00 GMT):
https://gerrit.hyperledger.org/r/#/c/19531/

rjones (Fri, 23 Mar 2018 20:50:40 GMT):
help make builds slightly faster: https://gerrit.hyperledger.org/r/#/c/19531/

mastersingh24 (Sat, 24 Mar 2018 13:22:14 GMT):
Can someone look at this: https://gerrit.hyperledger.org/r/19155 ? It's easy and need a +2

mastersingh24 (Sat, 24 Mar 2018 16:09:32 GMT):
some easy ones please: https://gerrit.hyperledger.org/r/#/q/status:open+owner:gari+singh+branch:master

sh777 (Sat, 24 Mar 2018 17:16:54 GMT):
Has joined the channel.

alexliu (Mon, 26 Mar 2018 04:29:32 GMT):
Could review this https://gerrit.hyperledger.org/r/#/c/19583/

alexliu (Mon, 26 Mar 2018 04:30:21 GMT):
need one +2, and I am a little bit confuse the comment of Gari

mastersingh24 (Mon, 26 Mar 2018 11:30:18 GMT):
@alexliu - updated my comments

alexliu (Mon, 26 Mar 2018 12:12:54 GMT):
thx, will update soon

rameshthoomu (Mon, 26 Mar 2018 12:59:20 GMT):
Need one +2 https://gerrit.hyperledger.org/r/#/c/19457/

cbf (Mon, 26 Mar 2018 13:00:54 GMT):
done

cbf (Mon, 26 Mar 2018 21:07:14 GMT):
https://gerrit.hyperledger.org/r/c/19251/

alexliu (Tue, 27 Mar 2018 03:45:21 GMT):
@mastersingh24 @jyellick https://gerrit.hyperledger.org/r/#/c/19583/ updated

joe-alewine (Tue, 27 Mar 2018 16:24:47 GMT):
Final cleanup of Identity and Membership concept docs: https://gerrit.hyperledger.org/r/c/19547/ https://gerrit.hyperledger.org/r/c/19573/

muralisr (Wed, 28 Mar 2018 04:00:43 GMT):
https://gerrit.hyperledger.org/r/#/c/19845/ and https://gerrit.hyperledger.org/r/#/c/19847/ please

pandrejko (Wed, 28 Mar 2018 15:33:53 GMT):
Glossary updates (anchor peer, consortium, ledger, member, organization) still need +2 https://gerrit.hyperledger.org/r/#/c/19617/

sykesm (Wed, 28 Mar 2018 17:39:18 GMT):
https://gerrit.hyperledger.org/r/c/19285/ and https://gerrit.hyperledger.org/r/c/19821/ please

joe-alewine (Wed, 28 Mar 2018 18:56:22 GMT):
Add "teardown" steps to Write Your First Application: https://gerrit.hyperledger.org/r/#/c/19869/ Document that consensus type cannot be changed after network has been bootstrapped: https://gerrit.hyperledger.org/r/#/c/19863/

sykesm (Thu, 29 Mar 2018 12:27:45 GMT):
gm - any chance I can get an additional review on https://gerrit.hyperledger.org/r/c/19285/ ? There are other work items related to the makefiles that would ideally be done after this CR is merged.

yacovm (Thu, 29 Mar 2018 12:28:34 GMT):
I'll +2 it if you solve the merge conflict, @sykesm

sykesm (Thu, 29 Mar 2018 12:29:39 GMT):
You'll have to help me with the how since the only conflicts I see are pending CRs and nothing that's actually merged.

yacovm (Thu, 29 Mar 2018 12:29:42 GMT):
ditto on the next one

yacovm (Thu, 29 Mar 2018 12:29:51 GMT):
but gerrit shows it is conflicted

yacovm (Thu, 29 Mar 2018 12:29:59 GMT):
i think maybe if you click rebase

yacovm (Thu, 29 Mar 2018 12:30:08 GMT):
it will remove the red text

yacovm (Thu, 29 Mar 2018 12:30:12 GMT):
but it may not

yacovm (Thu, 29 Mar 2018 12:30:46 GMT):
> the only conflicts I see are pending CRs This is weird because I don't see pending CRs that are in conflict to your change set

yacovm (Thu, 29 Mar 2018 12:30:57 GMT):

Clipboard - March 29, 2018 3:30 PM

yacovm (Thu, 29 Mar 2018 12:31:13 GMT):
if there had been such, it would show another column of "conflicting change sets: " to the right of the "related changes"

sykesm (Thu, 29 Mar 2018 12:32:04 GMT):
My view shows 3 conflicts and all three are unrelated. I will rebase (and then spend most of the day on the reverify-x dance). thanks

sykesm (Thu, 29 Mar 2018 12:37:38 GMT):
rebase is complete. Implication is that all three CRs have lost the review and require builds et al.

yacovm (Thu, 29 Mar 2018 12:37:45 GMT):
I know, already +2ed

rjones (Thu, 29 Mar 2018 15:17:05 GMT):
https://gerrit.hyperledger.org/r/#/c/13225/ good candidate for rebase/merge?

rjones (Thu, 29 Mar 2018 15:17:23 GMT):
it has one +2 and no conflicts

rjones (Thu, 29 Mar 2018 15:18:31 GMT):
https://gerrit.hyperledger.org/r/#/c/15575/ needs a small commit message edit

rjones (Thu, 29 Mar 2018 15:20:13 GMT):
has two +1: https://gerrit.hyperledger.org/r/#/c/13643/

rjones (Thu, 29 Mar 2018 15:52:50 GMT):
Doc update: https://gerrit.hyperledger.org/r/#/c/15575/ cherry picked to: https://gerrit.hyperledger.org/r/#/c/19927/

joe-alewine (Thu, 29 Mar 2018 15:57:00 GMT):
Introduction doc had not been updated in a while. Needed some trims and minor fixes, as well as links to "where to learn more" docs that now exist. Also, latest images were never added (for some reason), so this adds those: https://gerrit.hyperledger.org/r/#/c/19929/

rjones (Thu, 29 Mar 2018 16:06:54 GMT):
easy spelling fix: https://gerrit.hyperledger.org/r/#/c/19895/

cbf (Thu, 29 Mar 2018 17:43:23 GMT):
https://gerrit.hyperledger.org/r/c/16541/

cbf (Thu, 29 Mar 2018 22:57:08 GMT):
https://gerrit.hyperledger.org/r/c/19617/

rjones (Thu, 29 Mar 2018 23:19:06 GMT):
_rattles the tin cup for https://chat.hyperledger.org/channel/fabric-pr-review?msg=T8CJCZERfPRBhcaAT_

rjones (Thu, 29 Mar 2018 23:24:21 GMT):
sorry, @yacovm , I wiped out your votes on https://gerrit.hyperledger.org/r/#/c/19927/ when I took your edit

yacovm (Thu, 29 Mar 2018 23:24:52 GMT):
i know, np. i re-added

rjones (Thu, 29 Mar 2018 23:26:48 GMT):
https://gerrit.hyperledger.org/r/#/c/19469/ and https://gerrit.hyperledger.org/r/#/c/19473/ have one +2 in `fabric-samples`.

rjones (Thu, 29 Mar 2018 23:35:07 GMT):
@cbf I updated the commit message on https://gerrit.hyperledger.org/r/#/c/15663/

cbf (Fri, 30 Mar 2018 13:07:56 GMT):
https://gerrit.hyperledger.org/r/c/11771/

cbf (Fri, 30 Mar 2018 13:09:00 GMT):
@rjones thanks

cbf (Fri, 30 Mar 2018 13:12:21 GMT):
pretty please https://gerrit.hyperledger.org/r/c/19949/

muralisr (Fri, 30 Mar 2018 13:17:23 GMT):
^^^ +2ed, @cbs

cbf (Fri, 30 Mar 2018 13:19:41 GMT):
thx

negupta (Fri, 30 Mar 2018 18:47:43 GMT):
Has joined the channel.

wjzheng (Fri, 30 Mar 2018 19:59:56 GMT):
Reorganized topics in TOC: https://gerrit.hyperledger.org/r/#/c/19999/

mastersingh24 (Sat, 31 Mar 2018 10:17:13 GMT):
these two fix some flaky tests in core/comm: https://gerrit.hyperledger.org/r/19977 https://gerrit.hyperledger.org/r/20015

mastersingh24 (Sat, 31 Mar 2018 18:37:32 GMT):
https://gerrit.hyperledger.org/r/20015 needs one more +2 please

yacovm (Sat, 31 Mar 2018 18:38:49 GMT):
needs 2 +2s please https://gerrit.hyperledger.org/r/#/c/18005/

mastersingh24 (Sat, 31 Mar 2018 18:39:43 GMT):
@yacovm - quite the chore getting that things through CI :(

mastersingh24 (Sat, 31 Mar 2018 18:39:43 GMT):
@yacovm - quite the chore getting that one through CI :(

mastersingh24 (Sat, 31 Mar 2018 18:40:08 GMT):
+2 from me

yacovm (Sat, 31 Mar 2018 18:41:08 GMT):
I have a feeling that it broke something because I can't figure out why `TestStartCmd` was flaky in my change set but not in others

yacovm (Sat, 31 Mar 2018 18:41:17 GMT):
but I just moved files to a diff. package...

yacovm (Sat, 31 Mar 2018 18:46:12 GMT):
I actually think we just need to remove that test altogether.

yacovm (Sat, 31 Mar 2018 18:46:19 GMT):
that "pid file" is useless

mastersingh24 (Sat, 31 Mar 2018 18:46:30 GMT):
it really is

yacovm (Sat, 31 Mar 2018 18:46:32 GMT):
I can figure out what is the process id of the peer without a pid file just fine

yacovm (Sat, 31 Mar 2018 18:46:40 GMT):
I just use `top` :joy:

mastersingh24 (Sat, 31 Mar 2018 18:46:55 GMT):
You are truly an advanced user LOL

yacovm (Sat, 31 Mar 2018 18:47:03 GMT):
and in a container - it is always `1`

mastersingh24 (Sat, 31 Mar 2018 19:17:05 GMT):
sorry guys - https://gerrit.hyperledger.org/r/19977 had to be rebased for some reason ... @yacovm @C0rWin would you mind +2 again?

yacovm (Sat, 31 Mar 2018 19:17:37 GMT):
oh this is cool

yacovm (Sat, 31 Mar 2018 19:17:50 GMT):
you rebased and the green +1s from jenkins are still there

yacovm (Sat, 31 Mar 2018 19:17:58 GMT):
quick, someone merge before it notices

mastersingh24 (Sat, 31 Mar 2018 19:18:03 GMT):
hehe

mastersingh24 (Sat, 31 Mar 2018 19:18:10 GMT):
my thoughts exactly

C0rWin (Sat, 31 Mar 2018 19:56:58 GMT):
done

cbf (Sat, 31 Mar 2018 20:49:23 GMT):
https://gerrit.hyperledger.org/r/c/19987/

yacovm (Sat, 31 Mar 2018 20:53:42 GMT):
https://gerrit.hyperledger.org/r/#/c/18007/ pretty please @mastersingh24 @C0rWin

yacovm (Sat, 31 Mar 2018 20:54:06 GMT):
I've been `Run UnitTest`ing it all day :sweat:

cbf (Sat, 31 Mar 2018 21:16:03 GMT):
sigh

cbf (Sat, 31 Mar 2018 21:16:08 GMT):
we need to clean up the fakes

cbf (Sat, 31 Mar 2018 21:16:08 GMT):
we need to clean up the flakes

cbf (Sat, 31 Mar 2018 21:17:21 GMT):
merged

cbf (Sat, 31 Mar 2018 21:19:47 GMT):
https://gerrit.hyperledger.org/r/c/19757/

yacovm (Sat, 31 Mar 2018 21:22:38 GMT):
thanks much @cbf

cbf (Sat, 31 Mar 2018 21:23:23 GMT):
return the favor? https://gerrit.hyperledger.org/r/c/19987/

yacovm (Sat, 31 Mar 2018 21:23:34 GMT):
`Remove peer pidfile` had a UT which I removed that failed all day for me

cbf (Sat, 31 Mar 2018 21:23:36 GMT):
I'd like to cherry pick before I go for seder

cbf (Sat, 31 Mar 2018 21:26:29 GMT):
thanks

cbf (Sat, 31 Mar 2018 21:26:33 GMT):
https://gerrit.hyperledger.org/r/c/20035

yacovm (Sat, 31 Mar 2018 22:50:06 GMT):
merge please https://gerrit.hyperledger.org/r/#/c/20033/ :) @cbf

rjones (Sat, 31 Mar 2018 23:02:07 GMT):
@yacovm since you have 2+2 why not click the `submit` button yourself?

rjones (Sat, 31 Mar 2018 23:02:25 GMT):
oh, Artem merged it

yacovm (Sat, 31 Mar 2018 23:02:29 GMT):
it is a custom that we don't merge our own stuff

rjones (Sat, 31 Mar 2018 23:02:47 GMT):
OK. I was unaware that was a custom. Thank you.

yacovm (Sat, 31 Mar 2018 23:03:11 GMT):
well I think there are exceptions like doc changes, etc.

rjones (Sun, 01 Apr 2018 00:07:20 GMT):
https://gerrit.hyperledger.org/r/#/c/20035/

rjones (Sun, 01 Apr 2018 00:07:45 GMT):
https://gerrit.hyperledger.org/r/#/c/19843/

cbf (Sun, 01 Apr 2018 12:50:09 GMT):
https://gerrit.hyperledger.org/r/c/20049/

cbf (Sun, 01 Apr 2018 12:55:37 GMT):
https://gerrit.hyperledger.org/r/c/19757/

cbf (Sun, 01 Apr 2018 21:44:39 GMT):
https://gerrit.hyperledger.org/r/c/20035/ cherry-picked from a merged item, please

muralisr (Mon, 02 Apr 2018 14:15:48 GMT):
https://gerrit.hyperledger.org/r/#/c/19845/ and https://gerrit.hyperledger.org/r/#/c/19847/ please (@cbf one of your +2 got wiped out by rebase)

cbf (Mon, 02 Apr 2018 16:29:00 GMT):
https://gerrit.hyperledger.org/r/c/19999/

davidkhala (Tue, 03 Apr 2018 09:51:52 GMT):
@bretharrison Hi Bret, I update it as your suggestion https://gerrit.hyperledger.org/r/#/c/19803/

cbf (Tue, 03 Apr 2018 14:03:22 GMT):
https://gerrit.hyperledger.org/r/c/20081/

rjones (Tue, 03 Apr 2018 17:30:03 GMT):
https://gerrit.hyperledger.org/r/#/c/16581/ I cleaned up the commit message

rjones (Tue, 03 Apr 2018 19:04:34 GMT):
ready to merge: https://gerrit.hyperledger.org/r/#/c/19951/ (someone just needs to click `submit`)

mastersingh24 (Tue, 03 Apr 2018 23:19:19 GMT):
easy one now that the Go 1.10 / base image 0.47 has been merged: https://gerrit.hyperledger.org/r/20085

cbf (Wed, 04 Apr 2018 11:48:06 GMT):
https://gerrit.hyperledger.org/r/c/20081/

pandrejko (Wed, 04 Apr 2018 16:32:48 GMT):
Updated instructions for a local doc build https://gerrit.hyperledger.org/r/#/c/20147/

cbf (Thu, 05 Apr 2018 12:54:39 GMT):
https://gerrit.hyperledger.org/r/c/20139/ easy one

rjones (Thu, 05 Apr 2018 15:59:07 GMT):
well-reviewed doc update: https://gerrit.hyperledger.org/r/#/c/18813/

rjones (Thu, 05 Apr 2018 16:00:39 GMT):
there is no CI for this repo, and this will be the first commit. https://gerrit.hyperledger.org/r/#/c/20153/

cbf (Thu, 05 Apr 2018 16:57:06 GMT):
https://gerrit.hyperledger.org/r/c/20179/

cbf (Thu, 05 Apr 2018 16:59:18 GMT):
https://gerrit.hyperledger.org/r/c/20159/

cbf (Thu, 05 Apr 2018 16:59:49 GMT):
https://gerrit.hyperledger.org/r/c/20163/

cbf (Thu, 05 Apr 2018 17:54:54 GMT):
https://gerrit.hyperledger.org/r/c/20165/

cbf (Thu, 05 Apr 2018 18:30:50 GMT):
@manish-sethi @dave.enyeart https://gerrit.hyperledger.org/r/q/status:open+and+age:2mon+and+owner:%2522Manish+Sethi+%253Cmanish.sethi%2540gmail.com%253E%2522 can probably be moved forward, been dormant for 2+ months

rjones (Thu, 05 Apr 2018 20:05:29 GMT):
I'm going to bounce gerrit due to 500 errors in the UI

rjones (Thu, 05 Apr 2018 20:08:09 GMT):
gerrit is restarted.

rjones (Thu, 05 Apr 2018 20:24:46 GMT):
Jenkins will bounce soon.

manish-sethi (Thu, 05 Apr 2018 23:36:46 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=n9wafCHWgujACQxLa) @cbf These CRs are indeed long pending. I think that the issue is that there is no clear agreement yet on merging these but at the same time some folks are using these as cherry picks...

cbf (Fri, 06 Apr 2018 00:08:30 GMT):
we should either get agreement snd merge or abandon... can’t let stuff fester

rjones (Fri, 06 Apr 2018 00:12:30 GMT):
here's the list (after I tried the new CI on them): https://gerrit.hyperledger.org/r/#/q/owner:manish.sethi%2540gmail.com+status:open+label:f2-smoketest%253C0

pandrejko (Fri, 06 Apr 2018 11:29:59 GMT):
The comments have died down for the glossary change set now and I believe I've addressed all the comments: https://gerrit.hyperledger.org/r/#/c/19617/

cbf (Fri, 06 Apr 2018 12:34:56 GMT):
https://gerrit.hyperledger.org/r/c/19757/

mastersingh24 (Fri, 06 Apr 2018 13:40:07 GMT):
easy one: https://gerrit.hyperledger.org/r/19825

rjones (Fri, 06 Apr 2018 14:51:37 GMT):
_Extremely_ well reviewed doc change: https://gerrit.hyperledger.org/r/#/c/18813/

rjones (Fri, 06 Apr 2018 15:11:19 GMT):
thank you @mastersingh24

rjones (Fri, 06 Apr 2018 15:13:13 GMT):
this change removes an inaccurate comment: https://gerrit.hyperledger.org/r/#/c/19081/ and has one +2

rjones (Fri, 06 Apr 2018 15:15:01 GMT):
trivial change: https://gerrit.hyperledger.org/r/#/c/20181/ needs one +2 and merged

rjones (Fri, 06 Apr 2018 15:16:00 GMT):
trivial change: https://gerrit.hyperledger.org/r/#/c/20167/

rjones (Fri, 06 Apr 2018 15:18:33 GMT):
TBH, all of these that contain the phrase `" add.*md"`: https://gerrit.hyperledger.org/r/#/q/owner:chris.ferris%2540gmail.com+status:open

bstasyszyn (Sat, 07 Apr 2018 18:22:25 GMT):
@yacovm Please review https://gerrit.hyperledger.org/r/#/c/20289/ Thx!

yacovm (Sat, 07 Apr 2018 18:41:06 GMT):
I did

yacovm (Sat, 07 Apr 2018 18:43:53 GMT):
I don't understand why there is no JIRA for the change set though, @bstasyszyn ?

bstasyszyn (Sat, 07 Apr 2018 19:09:21 GMT):
@yacovm Sorry - here it is: https://jira.hyperledger.org/browse/FAB-9405

cbf (Sat, 07 Apr 2018 19:49:34 GMT):
https://gerrit.hyperledger.org/r/c/20075/

rameshthoomu (Mon, 09 Apr 2018 15:59:22 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/19825/

joe-alewine (Mon, 09 Apr 2018 18:08:31 GMT):
Clean up/update of Introduction doc. Need one more +2 https://gerrit.hyperledger.org/r/#/c/19929/

rjones (Tue, 10 Apr 2018 15:00:08 GMT):
trivial typo fix in `fabric-samples`: https://gerrit.hyperledger.org/r/#/c/20301/

Chandraamit (Wed, 11 Apr 2018 07:23:11 GMT):
While initiating the chaincode in Peer,I am getting the below error message.I have taken the fabric images of version 1.0.5.Could anyone help me to solve it.

Chandraamit (Wed, 11 Apr 2018 07:23:40 GMT):

Error screen shot 1

Chandraamit (Wed, 11 Apr 2018 07:24:13 GMT):

Error screen shot 2

rjones (Wed, 11 Apr 2018 14:47:27 GMT):
@Chandraamit please ask in #fabric-questions

rjones (Wed, 11 Apr 2018 14:48:08 GMT):
extremely trivial review with one +2 (thank you @yacovm ): https://gerrit.hyperledger.org/r/#/c/20301/ as this is a first commit to the project I want to get this done done done thanks

rjones (Wed, 11 Apr 2018 16:50:38 GMT):
Thank you @mastersingh24

mastersingh24 (Wed, 11 Apr 2018 17:43:45 GMT):
https://gerrit.hyperledger.org/r/20447 easy one - just cherrypicks the above to 1.1 as well

sanchezl (Wed, 11 Apr 2018 18:07:07 GMT):
https://gerrit.hyperledger.org/r/c/17433

pandrejko (Wed, 11 Apr 2018 20:58:10 GMT):
CouchDB Tutorial https://gerrit.hyperledger.org/r/#/c/20469/

jyellick (Thu, 12 Apr 2018 03:46:22 GMT):
@cbf At I believe it was you one point you had pasted a very nice query for checking gerrit for reviews: https://gerrit.hyperledger.org/r/q/is:open%20label:Verified%2B1%20%20NOT%20label:Code-Review-1%20NOT%20label:Code-Review-2%20is:mergeable Do you have a similar magic query for the new CI?

rjones (Thu, 12 Apr 2018 03:51:28 GMT):
https://gerrit.hyperledger.org/r/#/q/is:open%20label:F3-UnitTest=1%20is:mergeable

rjones (Thu, 12 Apr 2018 03:52:18 GMT):
I suppose there is a corner case there, @jyellick, where something could fail the documentation build but pass the functional builds. In practice, I haven't seen that.

jyellick (Thu, 12 Apr 2018 03:52:52 GMT):
Perfect, thanks!

rjones (Thu, 12 Apr 2018 03:52:56 GMT):
https://gerrit.hyperledger.org/r/#/q/is:open%20label:F3-UnitTest=1%20is:mergeable%20label:F2-DocBuild=1

rjones (Thu, 12 Apr 2018 03:52:59 GMT):
would be more explicit.

rjones (Thu, 12 Apr 2018 04:34:39 GMT):
Trivial documentation cleanup: https://gerrit.hyperledger.org/r/#/c/20479/ on 1.1 branch: https://gerrit.hyperledger.org/r/#/c/20481/

rjones (Thu, 12 Apr 2018 12:42:36 GMT):
Reminder: outage in about 10 hours: https://chat.hyperledger.org/channel/infra-support?msg=Lgno5LZYh7bBTr4Tc

mastersingh24 (Thu, 12 Apr 2018 12:56:07 GMT):
https://gerrit.hyperledger.org/r/20453 - fairly easy one

pandrejko (Thu, 12 Apr 2018 15:24:42 GMT):
https://gerrit.hyperledger.org/r/#/c/20495/

joe-alewine (Thu, 12 Apr 2018 16:30:40 GMT):
Cleanup of identity.md (newly rebased) -- https://gerrit.hyperledger.org/r/c/19547/ Cleanup of membership.md -- https://gerrit.hyperledger.org/r/c/19573/

mastersingh24 (Thu, 12 Apr 2018 19:03:50 GMT):
need one more +2 on this one: https://gerrit.hyperledger.org/r/20405 (just a vendor update for fabric-ca for Go 1.10 )

lehors (Thu, 12 Apr 2018 23:33:08 GMT):
hi there, https://gerrit.hyperledger.org/r/#/c/19381/ is feeling very much unloved after 3 weeks of being ignored by our dear maintainers

lehors (Thu, 12 Apr 2018 23:34:22 GMT):
I'm actually surprised it still stands without requiring a rebase after all that time but that can't possibly last so I would appreciate a bit of love. thank you

yacovm (Thu, 12 Apr 2018 23:36:35 GMT):
is there no other way to put the silence thing in the caller to that function, @lehors ?

yacovm (Thu, 12 Apr 2018 23:36:44 GMT):
perhaps then we could put it in less files?

yacovm (Thu, 12 Apr 2018 23:38:41 GMT):
also... you didn't add anyone as reviewer so it sank to the bottom

yacovm (Thu, 12 Apr 2018 23:38:41 GMT):
also... you didn't add anyone as reviewer so it sank to the bottom of the gerrit ocean

rjones (Fri, 13 Apr 2018 00:16:59 GMT):
@lehors I would retrigger CI so it got the new flags set, but I'd hate to break it :(

lehors (Fri, 13 Apr 2018 00:26:43 GMT):
well, there is only one way to find out, right? :)

rjones (Fri, 13 Apr 2018 00:28:04 GMT):
The rebase button tempted me, but you should push it :)

lehors (Fri, 13 Apr 2018 00:48:17 GMT):
well, I pushed it but I don't see anything really happening

rjones (Fri, 13 Apr 2018 00:50:02 GMT):
@lehors it carried all of your `0` votes due to a trivial rebase :) I manually triggered it

lehors (Fri, 13 Apr 2018 00:50:36 GMT):
ah :)

lehors (Fri, 13 Apr 2018 00:50:39 GMT):
thanks

yacovm (Fri, 13 Apr 2018 15:07:32 GMT):
Easy one- https://gerrit.hyperledger.org/r/#/c/20499/ just a small refactoring to the discovery client - 16 lines of production code

rjones (Fri, 13 Apr 2018 16:07:02 GMT):
Refactored shell script: https://gerrit.hyperledger.org/r/#/c/20441/ has +2 and 2*+1

pandrejko (Fri, 13 Apr 2018 18:24:12 GMT):
Glossary addition: World State https://gerrit.hyperledger.org/r/#/c/20549/

latitiah (Fri, 13 Apr 2018 18:37:36 GMT):
Very very simple CR: https://gerrit.hyperledger.org/r/#/c/20551/

cbf (Fri, 13 Apr 2018 18:40:13 GMT):
https://gerrit.hyperledger.org/r/c/20081/

rjones (Fri, 13 Apr 2018 18:45:41 GMT):
I pray further votes from community members: https://gerrit.hyperledger.org/r/#/c/20521/ please +1 or -1 AA if you are a fabric committer TYVM

yacovm (Sat, 14 Apr 2018 12:07:27 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/20555/ fixes flaky test

rjones (Sat, 14 Apr 2018 15:48:38 GMT):
@yacovm you are the wind beneath my wings

rjones (Sat, 14 Apr 2018 15:53:29 GMT):
https://gerrit.hyperledger.org/r/#/c/20503/

rjones (Sat, 14 Apr 2018 15:54:06 GMT):
https://gerrit.hyperledger.org/r/#/c/20493/

yacovm (Sat, 14 Apr 2018 16:27:59 GMT):
what did i do?

rjones (Sat, 14 Apr 2018 16:29:40 GMT):
@yacovm fixing flaky tests!

yacovm (Sat, 14 Apr 2018 16:30:13 GMT):
oh, but this is my fault to begin with... and I have much more flaky tests that are my fault than I fixed

rjones (Sat, 14 Apr 2018 16:30:37 GMT):
opportunity rich codebase!

yacovm (Sun, 15 Apr 2018 12:46:33 GMT):
add local (channel-less) queries to service discovery https://gerrit.hyperledger.org/r/#/c/20445/ 1 more +2 needed

cbf (Sun, 15 Apr 2018 13:30:59 GMT):
been looking at this

C0rWin (Sun, 15 Apr 2018 20:55:02 GMT):
simple fix: https://gerrit.hyperledger.org/r/#/c/20483/

pandrejko (Mon, 16 Apr 2018 16:11:10 GMT):
https://gerrit.hyperledger.org/r/#/c/20495/ moved API reference to Contributions Welcome!

wlahti (Mon, 16 Apr 2018 17:35:44 GMT):
https://gerrit.hyperledger.org/r/c/19767/ and the follow-up CR https://gerrit.hyperledger.org/r/c/19769/ together will make a big difference on running `go test ./...` locally and improve the development experience

sanchezl (Mon, 16 Apr 2018 17:46:29 GMT):
• https://gerrit.hyperledger.org/r/c/17433/ (needs another +2 and merge) • https://gerrit.hyperledger.org/r/c/20633/ (back port of above to release-1.0)

pandrejko (Mon, 16 Apr 2018 18:58:32 GMT):
https://gerrit.hyperledger.org/r/#/c/20627/ fixed the Getting Started TOC

rjones (Mon, 16 Apr 2018 19:52:30 GMT):
Am I misunderstanding something? it looks like this was a zero-content change that got merged: https://gerrit.hyperledger.org/r/#/c/20593/ @mastersingh24

rjones (Mon, 16 Apr 2018 19:53:32 GMT):
OIC. This commit should have been squashed into the above commit: https://gerrit.hyperledger.org/r/#/c/20605/

wlahti (Mon, 16 Apr 2018 22:44:15 GMT):
and here's one more CR that gets us closer to having all of the fabric repository unit tests pass when running `go test ./...`: https://gerrit.hyperledger.org/r/c/20651

cbf (Tue, 17 Apr 2018 12:58:24 GMT):
https://gerrit.hyperledger.org/r/c/20081/ and https://gerrit.hyperledger.org/r/c/20081/ please

nnao (Tue, 17 Apr 2018 22:34:02 GMT):
Please - https://gerrit.hyperledger.org/r/c/20525/ (needs another +2) - https://gerrit.hyperledger.org/r/c/20467/ (needs another +2) - https://gerrit.hyperledger.org/r/c/20421/

muralisr (Wed, 18 Apr 2018 15:13:23 GMT):
needs one more +2 https://gerrit.hyperledger.org/r/#/c/20621/ (@cbf @mastersingh24 this is part of the series you had reviewed)

yacovm (Wed, 18 Apr 2018 15:15:46 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/20721/ only 35 LOC

muralisr (Wed, 18 Apr 2018 15:22:22 GMT):
done @yacovm ...perhaps you can take a look at mine above :-)

yacovm (Wed, 18 Apr 2018 15:22:39 GMT):
sure

wlahti (Wed, 18 Apr 2018 17:27:01 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=qKCXtPKRAYqzfvaBa) these two are still sitting around

wlahti (Wed, 18 Apr 2018 17:27:01 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=qKCXtPKRAYqzfvaBa) these two are still sitting around and could use some reviews. thanks!

jyellick (Thu, 19 Apr 2018 05:42:50 GMT):
https://gerrit.hyperledger.org/r/c/20441/ <- a very trivial one which has been hanging out for a while

pandrejko (Thu, 19 Apr 2018 14:37:10 GMT):
Need just 1 more +2 on API Doc Ref content move https://gerrit.hyperledger.org/r/#/c/20495/

wlahti (Thu, 19 Apr 2018 15:34:11 GMT):
One more review needed for each of these: - https://gerrit.hyperledger.org/r/c/19767/ (CouchDB runner for test) - https://gerrit.hyperledger.org/r/c/19769 (use CouchDB runner when needed for tests - enables local running of tests requiring a couchdb container) - https://gerrit.hyperledger.org/r/c/20379/ (add multiple endorsement support to the peer CLI) - https://gerrit.hyperledger.org/r/c/20381/ (update e2e_cli to use AND endorsement policy)

jyellick (Thu, 19 Apr 2018 17:02:30 GMT):
+1 ^ These should be ready to go and could really use some attention

pandrejko (Thu, 19 Apr 2018 17:12:20 GMT):
https://gerrit.hyperledger.org/r/#/c/20777/ Just 2 items in Glossary: Added Smart Contract and updated definition of Chaincode.

cbf (Thu, 19 Apr 2018 17:18:10 GMT):
https://gerrit.hyperledger.org/r/c/20081/ easy one, been languishing for a while, basically turns down the volume of noise in the logs for the samples

rameshthoomu (Fri, 20 Apr 2018 02:18:45 GMT):
missing this change (https://gerrit.hyperledger.org/r/#/c/20641/) in release-1.0 causing fabric docs build fail.

rjones (Fri, 20 Apr 2018 02:23:09 GMT):
Has left the channel.

rameshthoomu (Fri, 20 Apr 2018 02:26:43 GMT):
SafeSql scan check - https://gerrit.hyperledger.org/r/#/c/20695/

jyellick (Fri, 20 Apr 2018 05:37:34 GMT):
https://gerrit.hyperledger.org/r/c/19767/ https://gerrit.hyperledger.org/r/c/19769/ ^ These are test only, no risk to production code, but allow unit tests to run locally. They have been ready for weeks at this point and could really use a second +2

jyellick (Fri, 20 Apr 2018 05:37:34 GMT):
https://gerrit.hyperledger.org/r/c/19767/ https://gerrit.hyperledger.org/r/c/19769/ ^ These are test only, no risk to production code, but allow unit tests to run locally. They have been ready for a few weeks at this point and could really use a second +2

nnao (Fri, 20 Apr 2018 17:47:13 GMT):
https://gerrit.hyperledger.org/r/c/15737/ (fix response of a peer when chaincode error) This CR effects some test(fabric-test/fabric-sdk-node). So This CR needs to ACK from fabric and fabric-sdk-node maintainers. (the fabric-test case that affects is skipped)

cbf (Sat, 21 Apr 2018 11:58:29 GMT):
this is getting old. I have requested multiple times to have it reviewed. It is a pretty easy review https://gerrit.hyperledger.org/r/c/20081/

yacovm (Sat, 21 Apr 2018 22:16:51 GMT):
2 *easy* change sets: 1) 18 LOC - Simple test hardening https://gerrit.hyperledger.org/r/#/c/20805/ ;) 2) Add cc2cc and collections to service discovery protobuf https://gerrit.hyperledger.org/r/#/c/20669/

yacovm (Sat, 21 Apr 2018 22:17:01 GMT):
1 +2 missing for each

yacovm (Sun, 22 Apr 2018 00:04:06 GMT):
https://gerrit.hyperledger.org/r/#/c/20563/ it's not as scary as it looks, most of it is a rewrite of a test

yacovm (Sun, 22 Apr 2018 00:04:06 GMT):
https://gerrit.hyperledger.org/r/#/c/20563/ it's not as scary as it looks, most of it is a rewrite of a test. i need it for service discovery to work properly though :wink:

yacovm (Sun, 22 Apr 2018 00:08:04 GMT):
Also started writing up a service discovery overview section... https://gerrit.hyperledger.org/r/#/c/20859/ @joe-alewine feel free to edit the change set and append you signed-off-by and also please tell me what is missing / what has too much detail

yacovm (Sun, 22 Apr 2018 00:08:04 GMT):
Also started writing up a service discovery overview section... https://gerrit.hyperledger.org/r/#/c/20859/ Putting here so that people be aware and can chime into the CR and comment @joe-alewine feel free to edit the change set and append you signed-off-by and also please tell me what is missing / what has too much detail

yacovm (Sun, 22 Apr 2018 00:08:04 GMT):
Also started writing up a service discovery overview section... https://gerrit.hyperledger.org/r/#/c/20859/ Putting here so that people be aware and can chime into the CR and comment @joe-alewine feel free to edit the change set and append your signed-off-by and also please tell me what is missing / what has too much detail

cbf (Sun, 22 Apr 2018 12:28:05 GMT):
https://gerrit.hyperledger.org/r/c/20851/

joe-alewine (Sun, 22 Apr 2018 13:09:56 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=KQ2RDcTcJdgu2xxxE) @yacovm :thumbsup:

rameshthoomu (Mon, 23 Apr 2018 13:33:43 GMT):
patch to update sphinx version https://gerrit.hyperledger.org/r/#/c/20889/

cbf (Mon, 23 Apr 2018 18:45:22 GMT):
https://gerrit.hyperledger.org/r/c/20855/

bstasyszyn (Mon, 23 Apr 2018 22:14:29 GMT):
https://gerrit.hyperledger.org/r/#/c/14791/ Has been in review for a while

joe-alewine (Wed, 25 Apr 2018 12:49:32 GMT):
Service discovery initial doc: https://gerrit.hyperledger.org/r/#/c/20859/

cbf (Wed, 25 Apr 2018 14:26:05 GMT):
need 1 more +2 https://gerrit.hyperledger.org/r/c/20875/

cbf (Wed, 25 Apr 2018 17:51:26 GMT):
simple doc fix https://gerrit.hyperledger.org/r/c/20993/

cbf (Wed, 25 Apr 2018 18:05:39 GMT):
still need one more +2 on https://gerrit.hyperledger.org/r/c/20875/

yacovm (Wed, 25 Apr 2018 23:16:02 GMT):
1 line bug fix https://gerrit.hyperledger.org/r/#/c/21029/

cbf (Thu, 26 Apr 2018 00:40:25 GMT):
https://gerrit.hyperledger.org/r/c/20855/

cbf (Thu, 26 Apr 2018 00:40:56 GMT):
https://gerrit.hyperledger.org/r/c/20911/

pandrejko (Thu, 26 Apr 2018 13:40:55 GMT):
https://gerrit.hyperledger.org/r/c/20777/ Glossary Smart Contract

rjones (Thu, 26 Apr 2018 14:35:11 GMT):
Has joined the channel.

rjones (Thu, 26 Apr 2018 14:36:15 GMT):
I pray for +1 votes from Fabric maintainers: https://gerrit.hyperledger.org/r/#/c/20521/

cbf (Thu, 26 Apr 2018 20:05:25 GMT):
easy one https://gerrit.hyperledger.org/r/c/21063/

cbf (Thu, 26 Apr 2018 20:08:52 GMT):
another https://gerrit.hyperledger.org/r/c/21043/

chainsaw (Fri, 27 Apr 2018 15:53:43 GMT):
Has joined the channel.

cbf (Fri, 27 Apr 2018 19:18:00 GMT):
https://gerrit.hyperledger.org/r/c/20993/

pandrejko (Fri, 27 Apr 2018 19:41:41 GMT):
https://gerrit.hyperledger.org/r/#/c/21147/ Fix for Search in ReadTheDocs

C0rWin (Fri, 27 Apr 2018 20:39:50 GMT):
easy fix for e2e script: https://gerrit.hyperledger.org/r/#/c/21121/ need last +2

kostas (Fri, 27 Apr 2018 21:59:02 GMT):
Has left the channel.

jtclark (Mon, 30 Apr 2018 10:51:03 GMT):
plz review: https://gerrit.hyperledger.org/r/#/c/20695/ - Adds the run_safesql_scan script to the fabric-ca repo

jtclark (Mon, 30 Apr 2018 10:51:21 GMT):
plz review: https://gerrit.hyperledger.org/r/#/c/20681/ - Adds the fabric-ca-safesql-weekly job to Jenkins

mastersingh24 (Mon, 30 Apr 2018 14:41:32 GMT):
easy one for release-1.0 branch: https://gerrit.hyperledger.org/r/21191

jyellick (Mon, 30 Apr 2018 21:00:28 GMT):
https://gerrit.hyperledger.org/r/c/20811/ <- Has been sitting there for a while, only deletions

C0rWin (Mon, 30 Apr 2018 23:08:26 GMT):
https://gerrit.hyperledger.org/r/#/c/21201/ + https://gerrit.hyperledger.org/r/#/c/21209/ - adding gossip support for dynamic collections

mastersingh24 (Tue, 01 May 2018 13:57:23 GMT):
https://gerrit.hyperledger.org/r/21189 - just trying to keep grpc-go up to date while we are still in dev mode for 1.2

C0rWin (Tue, 01 May 2018 15:12:16 GMT):
https://gerrit.hyperledger.org/r/#/c/21175/ adding ability for transient store to persist simulation block heigh and collection config info for underlined private data

cbf (Tue, 01 May 2018 15:29:53 GMT):
I'd like to get this moving along, please https://gerrit.hyperledger.org/r/c/21079/ and https://gerrit.hyperledger.org/r/c/21087/2

rjones (Tue, 01 May 2018 15:42:14 GMT):
@cbf should https://gerrit.hyperledger.org/r/#/c/19999/ be abandoned?

rjones (Tue, 01 May 2018 15:49:56 GMT):
https://gerrit.hyperledger.org/r/#/c/19939/ has one +2

cbf (Wed, 02 May 2018 00:03:01 GMT):
https://gerrit.hyperledger.org/r/c/20993/

cbf (Wed, 02 May 2018 00:03:15 GMT):
https://gerrit.hyperledger.org/r/c/21239/

cbf (Wed, 02 May 2018 00:03:36 GMT):
https://gerrit.hyperledger.org/r/c/21275/

muralisr (Wed, 02 May 2018 01:22:41 GMT):
some love to close out resource ACL for 1.2 ... has one +2

davidkhala (Wed, 02 May 2018 03:33:04 GMT):
urgent: grpc 1.11 in incompatible https://gerrit.hyperledger.org/r/#/c/21281/

cbf (Wed, 02 May 2018 15:37:58 GMT):
https://gerrit.hyperledger.org/r/c/21299/ this is an easy one - basically, I messed up with the initial CR and every paragraph was on its own line. I have reformatted so that it follows our <80 char line length constraint - no other changes.

wlahti (Wed, 02 May 2018 18:00:25 GMT):
https://gerrit.hyperledger.org/r/c/21307/ adds multiple endorsement support to the first-network samples (BYFN and EYFN)

cbf (Wed, 02 May 2018 19:58:15 GMT):
https://gerrit.hyperledger.org/r/c/21299/ needs one more please

rameshthoomu (Wed, 02 May 2018 21:21:24 GMT):
@smithbk @cbf could you please review and merge this change.. https://gerrit.hyperledger.org/r/#/c/20695/

rameshthoomu (Wed, 02 May 2018 21:21:34 GMT):
this is long pending CR..

jtclark (Wed, 02 May 2018 21:21:54 GMT):
@rameshthoomu yes it is. :-)

jtclark (Wed, 02 May 2018 21:22:59 GMT):
@smithbk you reviewed this once before, but I've provided some commentary since then..

cbf (Wed, 02 May 2018 22:21:54 GMT):
I +2'ed but will let @smithbk merge or -2 given his comment - I am ok adding this to the codebase

smithbk (Wed, 02 May 2018 22:23:08 GMT):
ok, given the recent comments, I'm ok also and will merge now

smithbk (Wed, 02 May 2018 22:23:52 GMT):
done

smithbk (Wed, 02 May 2018 22:25:51 GMT):
@jtclark I hope there will be future work to support ignoring false positives so that it will be more useful

jtclark (Wed, 02 May 2018 22:45:53 GMT):
We are well aware of the false positives but the safesql tool doesn’t easily allow us to filter them, hence the non voting job.

jtclark (Wed, 02 May 2018 22:46:06 GMT):
But we can explore what options we have.

kevin-s-wang (Thu, 03 May 2018 02:37:49 GMT):
Has joined the channel.

sudheesh001 (Thu, 03 May 2018 06:03:49 GMT):
https://gerrit.hyperledger.org/r/#/c/16541/ needs one more review please :)

sudheesh001 (Thu, 03 May 2018 06:13:17 GMT):
https://gerrit.hyperledger.org/r/#/c/21359/ Needs review please

lehors (Thu, 03 May 2018 08:52:45 GMT):
how about trying to reduce the number of open CRs and JIRAs with an easy one? :-) https://gerrit.hyperledger.org/r/#/c/20959/

rjones (Thu, 03 May 2018 13:58:26 GMT):
fabric-samples has a few in flight: https://gerrit.hyperledger.org/r/#/q/project:fabric-samples+label:verified%253D1+status:open+label:code-review%253E-1

rjones (Thu, 03 May 2018 13:59:16 GMT):
Not sure why this change in fabric-samples isn't merged: https://gerrit.hyperledger.org/r/#/c/16541/ it's also pretty simple

wlahti (Thu, 03 May 2018 18:39:31 GMT):
A couple of related changes: - https://gerrit.hyperledger.org/r/c/21307/ adds multiple endorsement support to the first-network samples (BYFN and EYFN) - https://gerrit.hyperledger.org/r/c/21335/ updates the docs to use AND (...) endorsement policies now that the CLI supports multiple endorsements for invoke - https://gerrit.hyperledger.org/r/c/21375/ improves the e2e_cli's multiple endorsement functionality

cbf (Thu, 03 May 2018 20:17:23 GMT):
https://gerrit.hyperledger.org/r/c/21363/

cbf (Thu, 03 May 2018 22:14:00 GMT):
bunch of doc fixes from Rob could be merged https://gerrit.hyperledger.org/r/q/owner:rpjday%2540crashcourse.ca+status:open

cbf (Fri, 04 May 2018 12:46:12 GMT):
https://gerrit.hyperledger.org/r/c/21363/

wlahti (Fri, 04 May 2018 15:39:52 GMT):
Now that the first-network sample has been updated with multiple endorsement support, it would be great to get this doc update in soon: https://gerrit.hyperledger.org/r/c/21335/

rameshthoomu (Fri, 04 May 2018 17:15:20 GMT):
Need one more +2 on this https://gerrit.hyperledger.org/r/#/c/21403/

pandrejko (Fri, 04 May 2018 17:29:26 GMT):
CouchDB Tutorial https://gerrit.hyperledger.org/r/#/c/20469/

rameshthoomu (Fri, 04 May 2018 20:29:18 GMT):
This change has to go.. this will fix fabric merge e2e job failures . https://gerrit.hyperledger.org/r/#/c/21403/

rjones (Fri, 04 May 2018 20:36:30 GMT):
jingle jingle this change needs a +2 from someone other than cbf to be merged. simple, low-risk change. :point_up: :point_up: :point_up:

joe-alewine (Fri, 04 May 2018 21:37:54 GMT):
Service discovery doc (Yacov wrote this one and I helped edit): https://gerrit.hyperledger.org/r/c/20859/ Cleanup of Membership concept doc (Elli has looked at this one and I've incorporated her suggestions): https://gerrit.hyperledger.org/r/c/19573/ Cleanup of Identity concept doc: https://gerrit.hyperledger.org/r/c/19547/

joe-alewine (Fri, 04 May 2018 21:37:54 GMT):
Service discovery doc (Yacov wrote this one and I edited it): https://gerrit.hyperledger.org/r/c/20859/ Cleanup of Membership concept doc (Elli has looked at this one and I've incorporated her suggestions): https://gerrit.hyperledger.org/r/c/19573/ Cleanup of Identity concept doc: https://gerrit.hyperledger.org/r/c/19547/

dave.enyeart (Mon, 07 May 2018 10:36:20 GMT):
Pluggable endorsement and validation CRs ready for review from Yacov: https://gerrit.hyperledger.org/r/#/q/owner:yacovm%2540il.ibm.com+status:open

cbf (Tue, 08 May 2018 23:00:12 GMT):
need one more on this easy doc fix https://gerrit.hyperledger.org/r/c/21363/

yacovm (Tue, 08 May 2018 23:03:28 GMT):
@cbf will trade it for https://gerrit.hyperledger.org/r/#/c/21539/

yacovm (Tue, 08 May 2018 23:03:51 GMT):
(just kidding, merged. but can anyone please take a look ? ^ )

yacovm (Tue, 08 May 2018 23:04:08 GMT):
I need it for both service discovery collection support, and for pluggable validation.

rjones (Tue, 08 May 2018 23:13:25 GMT):
Horse trading for commits! 🍻

cbf (Tue, 08 May 2018 23:17:11 GMT):
done

JonathanLevi (Tue, 08 May 2018 23:21:35 GMT):
Actually, @cbf, if you are around

JonathanLevi (Tue, 08 May 2018 23:22:04 GMT):
Mind taking a look at this? https://gerrit.hyperledger.org/r/#/c/21155/

cbf (Tue, 08 May 2018 23:22:11 GMT):
you calling me fat?

JonathanLevi (Tue, 08 May 2018 23:22:43 GMT):
Yes, but that was in a different window ;-)

cbf (Tue, 08 May 2018 23:24:10 GMT):
lol

cbf (Tue, 08 May 2018 23:24:15 GMT):
a bit light on tests

cbf (Tue, 08 May 2018 23:25:45 GMT):
we add a couple of methods and no tests for Verify one?

yacovm (Tue, 08 May 2018 23:28:07 GMT):
I agree with Chris FWIW

yacovm (Wed, 09 May 2018 09:28:40 GMT):
can we merge this https://gerrit.hyperledger.org/r/#/c/20859/ please?

yacovm (Wed, 09 May 2018 09:28:53 GMT):
thanks @JonathanLevi for the +2, need 1 more

wlahti (Wed, 09 May 2018 18:39:11 GMT):
one additional recover from panic for configtxgen: https://gerrit.hyperledger.org/r/c/21621/

wlahti (Wed, 09 May 2018 18:39:11 GMT):
short CR that adds one additional recover from panic for configtxgen: https://gerrit.hyperledger.org/r/c/21621/ . This is blocking some of the new integration test work so it would be great to get this in asap.

yacovm (Wed, 09 May 2018 22:16:33 GMT):
pretty please - *just a trivial protobuf change* https://gerrit.hyperledger.org/r/#/c/21647/

yacovm (Wed, 09 May 2018 22:27:09 GMT):
It's the last one for this release :pray_tone1:

yacovm (Wed, 09 May 2018 22:27:39 GMT):
pretty please - *just a trivial protobuf change* https://gerrit.hyperledger.org/r/#/c/21647/ It's the last one for this release :pray_tone1:

jtclark (Thu, 10 May 2018 15:28:11 GMT):
Can we get https://gerrit.hyperledger.org/r/#/c/21641/ merged, please?

jtclark (Thu, 10 May 2018 15:31:15 GMT):
@rjones thank you

rameshthoomu (Thu, 10 May 2018 19:22:47 GMT):
@bretharrison https://gerrit.hyperledger.org/r/#/c/21659/

cbf (Fri, 11 May 2018 06:50:45 GMT):
easy one https://gerrit.hyperledger.org/r/c/20675/

cbf (Fri, 11 May 2018 06:51:24 GMT):
another https://gerrit.hyperledger.org/r/c/19509/

mastersingh24 (Mon, 14 May 2018 13:35:52 GMT):
fairly easy bug fix: https://gerrit.hyperledger.org/r/21735

jtclark (Mon, 14 May 2018 20:13:16 GMT):
plz review: https://gerrit.hyperledger.org/r/#/c/21751/

wlahti (Tue, 15 May 2018 13:25:43 GMT):
Easy doc updates to endorsement policies, switching them from using OR(...) to AND(...) now that the peer CLI supports endorsements from multiple peers

wlahti (Tue, 15 May 2018 13:25:43 GMT):
Easy doc updates to endorsement policies, switching them from using OR(...) to AND(...) now that the peer CLI supports endorsements from multiple peers: https://gerrit.hyperledger.org/r/c/21335/

joe-alewine (Tue, 15 May 2018 14:43:32 GMT):
Easy one: getting previously merged IdeMix documentation into the TOC: https://gerrit.hyperledger.org/r/#/c/21685/

joe-alewine (Tue, 15 May 2018 15:03:18 GMT):
Clean up membership concept doc (have incorporated Elli's comments here): https://gerrit.hyperledger.org/r/c/19573/

jtclark (Tue, 15 May 2018 18:31:56 GMT):
plz review: https://gerrit.hyperledger.org/r/#/c/21751/ -super easy @C0rWin, @gennadyl

dave.enyeart (Tue, 15 May 2018 19:22:36 GMT):
@here I will be highlighting daily the priority CR reviews required to get to v1.2 code completion, as well as proposed reviewers (although all maintainers should review daily). Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21397/ https://gerrit.hyperledger.org/r/#/c/21737/ https://gerrit.hyperledger.org/r/#/c/21753/ Pluggable endorsement (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21465/ Service Discovery (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21723/ https://gerrit.hyperledger.org/r/#/c/21745/ https://gerrit.hyperledger.org/r/#/c/21747/ https://gerrit.hyperledger.org/r/#/c/21807/ Identity Mixer Fabric (Jonathan) https://gerrit.hyperledger.org/r/#/c/21155/ https://gerrit.hyperledger.org/r/#/c/21157/ https://gerrit.hyperledger.org/r/#/c/21159/ https://gerrit.hyperledger.org/r/#/c/20529/ (comments to address) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20089/ https://gerrit.hyperledger.org/r/#/c/21353/ https://gerrit.hyperledger.org/r/#/c/21409/ https://gerrit.hyperledger.org/r/#/c/21513/ https://gerrit.hyperledger.org/r/#/c/21357/ https://gerrit.hyperledger.org/r/#/c/21681/ https://gerrit.hyperledger.org/r/#/c/21677/ Fabric CA REST APIs (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20455/ https://gerrit.hyperledger.org/r/#/c/21771/ e2e test framework (all) https://gerrit.hyperledger.org/r/#/c/21451/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21453/ https://gerrit.hyperledger.org/r/#/c/21505/ https://gerrit.hyperledger.org/r/#/c/21405/ https://gerrit.hyperledger.org/r/#/c/21715/ https://gerrit.hyperledger.org/r/#/c/21507/ https://gerrit.hyperledger.org/r/#/c/21683/

dave.enyeart (Tue, 15 May 2018 19:22:36 GMT):
@here I will be highlighting daily the priority CR reviews required to get to v1.2 code completion, as well as proposed reviewers based on context (although all maintainers should help review daily). Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21397/ https://gerrit.hyperledger.org/r/#/c/21737/ https://gerrit.hyperledger.org/r/#/c/21753/ Pluggable endorsement (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21465/ Service Discovery (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21723/ https://gerrit.hyperledger.org/r/#/c/21745/ https://gerrit.hyperledger.org/r/#/c/21747/ https://gerrit.hyperledger.org/r/#/c/21807/ Identity Mixer Fabric (Jonathan) https://gerrit.hyperledger.org/r/#/c/21155/ https://gerrit.hyperledger.org/r/#/c/21157/ https://gerrit.hyperledger.org/r/#/c/21159/ https://gerrit.hyperledger.org/r/#/c/20529/ (comments to address) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20089/ https://gerrit.hyperledger.org/r/#/c/21353/ https://gerrit.hyperledger.org/r/#/c/21409/ https://gerrit.hyperledger.org/r/#/c/21513/ https://gerrit.hyperledger.org/r/#/c/21357/ https://gerrit.hyperledger.org/r/#/c/21681/ https://gerrit.hyperledger.org/r/#/c/21677/ Fabric CA REST APIs (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20455/ https://gerrit.hyperledger.org/r/#/c/21771/ e2e test framework (all) https://gerrit.hyperledger.org/r/#/c/21451/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21453/ https://gerrit.hyperledger.org/r/#/c/21505/ https://gerrit.hyperledger.org/r/#/c/21405/ https://gerrit.hyperledger.org/r/#/c/21715/ https://gerrit.hyperledger.org/r/#/c/21507/ https://gerrit.hyperledger.org/r/#/c/21683/

dave.enyeart (Tue, 15 May 2018 19:22:36 GMT):
@here I will be highlighting daily the priority CR reviews required to get to v1.2 code completion, as well as proposed reviewers based on context (although all maintainers should help review daily). Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21397/ https://gerrit.hyperledger.org/r/#/c/21737/ https://gerrit.hyperledger.org/r/#/c/21753/ Pluggable endorsement (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21465/ Service Discovery (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21723/ https://gerrit.hyperledger.org/r/#/c/21745/ https://gerrit.hyperledger.org/r/#/c/21747/ https://gerrit.hyperledger.org/r/#/c/21807/ Identity Mixer Fabric (Jonathan) https://gerrit.hyperledger.org/r/#/c/21155/ https://gerrit.hyperledger.org/r/#/c/21157/ https://gerrit.hyperledger.org/r/#/c/21159/ https://gerrit.hyperledger.org/r/#/c/20529/ (comments to address) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20089/ https://gerrit.hyperledger.org/r/#/c/21353/ https://gerrit.hyperledger.org/r/#/c/21409/ https://gerrit.hyperledger.org/r/#/c/21513/ https://gerrit.hyperledger.org/r/#/c/21357/ https://gerrit.hyperledger.org/r/#/c/21681/ https://gerrit.hyperledger.org/r/#/c/21677/ Fabric CA REST APIs (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20455/ https://gerrit.hyperledger.org/r/#/c/21771/ e2e test framework (Matt and all maintainers) https://gerrit.hyperledger.org/r/#/c/21451/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21453/ https://gerrit.hyperledger.org/r/#/c/21505/ https://gerrit.hyperledger.org/r/#/c/21405/ https://gerrit.hyperledger.org/r/#/c/21715/ https://gerrit.hyperledger.org/r/#/c/21507/ https://gerrit.hyperledger.org/r/#/c/21683/

dave.enyeart (Tue, 15 May 2018 19:22:36 GMT):
@here I will be highlighting daily the priority CR reviews required to get to v1.2 code completion, as well as proposed reviewers based on context (although all maintainers should help review daily). Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21397/ https://gerrit.hyperledger.org/r/#/c/21737/ https://gerrit.hyperledger.org/r/#/c/21753/ Pluggable endorsement (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21465/ Service Discovery (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21723/ https://gerrit.hyperledger.org/r/#/c/21745/ https://gerrit.hyperledger.org/r/#/c/21747/ https://gerrit.hyperledger.org/r/#/c/21807/ Identity Mixer Fabric (Jonathan) https://gerrit.hyperledger.org/r/#/c/21155/ https://gerrit.hyperledger.org/r/#/c/21157/ https://gerrit.hyperledger.org/r/#/c/21159/ https://gerrit.hyperledger.org/r/#/c/20529/ (comments to address) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20089/ https://gerrit.hyperledger.org/r/#/c/21353/ https://gerrit.hyperledger.org/r/#/c/21409/ https://gerrit.hyperledger.org/r/#/c/21513/ https://gerrit.hyperledger.org/r/#/c/21357/ https://gerrit.hyperledger.org/r/#/c/21681/ https://gerrit.hyperledger.org/r/#/c/21677/ Fabric CA REST APIs (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20455/ https://gerrit.hyperledger.org/r/#/c/21771/ e2e test framework (Matt, Jason, Kostas) https://gerrit.hyperledger.org/r/#/c/21451/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21453/ https://gerrit.hyperledger.org/r/#/c/21505/ https://gerrit.hyperledger.org/r/#/c/21405/ https://gerrit.hyperledger.org/r/#/c/21715/ https://gerrit.hyperledger.org/r/#/c/21507/ https://gerrit.hyperledger.org/r/#/c/21683/

wlahti (Tue, 15 May 2018 19:24:25 GMT):
CI is currently failing due to a peer integration runner test. This CR fixes it and just needs one more +2: https://gerrit.hyperledger.org/r/c/21829/

wlahti (Tue, 15 May 2018 19:24:25 GMT):
CI is currently failing due to a peer integration runner test. This CR fixes the two root causes and just needs one more +2: https://gerrit.hyperledger.org/r/c/21829/

dave.enyeart (Tue, 15 May 2018 19:25:23 GMT):
@wlahti will merge once unit tests pass

wlahti (Tue, 15 May 2018 19:26:39 GMT):
Oops, thought it already had, but it's still running through gossip. Jumped the gun a little there. :)

sykesm (Tue, 15 May 2018 19:29:39 GMT):
https://gerrit.hyperledger.org/r/21839 excludes integration from units.

dave.enyeart (Tue, 15 May 2018 19:30:30 GMT):
@sykesm why exclude them? are they run elsewhere?

sykesm (Tue, 15 May 2018 19:30:43 GMT):
they aren't unit tests.

dave.enyeart (Tue, 15 May 2018 19:31:03 GMT):
dont we want CI to check integration tests? do we need another CI job for them?

sykesm (Tue, 15 May 2018 19:31:09 GMT):
yes and yes

dave.enyeart (Tue, 15 May 2018 19:31:25 GMT):
until the trigger is pulled on that, shouldnt we keep them in unit?

sykesm (Tue, 15 May 2018 19:31:27 GMT):
https://gerrit.hyperledger.org/r/c/21715/

sykesm (Tue, 15 May 2018 19:32:40 GMT):
units are flakey enough. I don't think we need to pile on. Would like to see CI updated though.

dave.enyeart (Tue, 15 May 2018 19:33:53 GMT):
@wlahti https://gerrit.hyperledger.org/r/c/21829/ is merged

sykesm (Tue, 15 May 2018 20:41:03 GMT):
I rebased Latitia's CR's on current master and re-ordered a couple of easy ones to the bottom of the stack - including the one that introduces the integration test make target.

sykesm (Tue, 15 May 2018 20:41:41 GMT):
https://gerrit.hyperledger.org/r/c/21715/7 https://gerrit.hyperledger.org/r/c/21405/25 are both pretty straightforward. Would be great to see them get some love.

latitiah (Tue, 15 May 2018 21:04:05 GMT):
Also I've updated CI to have them add this make target to the Jenkins job

latitiah (Tue, 15 May 2018 21:04:29 GMT):
They've added it to their queue for running in their sandbox env

rameshthoomu (Tue, 15 May 2018 21:11:26 GMT):
@latitiah the integration tests are working as expected when I run `make integration-test` target but when I try to run these tests by pulling images from nexus we are seeing failures

rameshthoomu (Tue, 15 May 2018 21:11:54 GMT):
@sambhavdutt could you please provide the sandbox reference link

sambhavdutt (Tue, 15 May 2018 21:11:54 GMT):
Has joined the channel.

rameshthoomu (Tue, 15 May 2018 21:12:17 GMT):
I see the failures are related to timeout but I see that is happening consistently

sambhavdutt (Tue, 15 May 2018 21:14:29 GMT):
@latitiah @rameshthoomu https://jenkins.hyperledger.org/sandbox/job/fabric-verify-unit-tests-x86_64/

latitiah (Tue, 15 May 2018 21:18:02 GMT):
Ah, actually, this failure looks like it may be due to the vscc addition to the core.yaml for the peers. I'm fixing that and will push an update

gennadyl (Wed, 16 May 2018 06:14:50 GMT):
@rjones Can you review https://gerrit.hyperledger.org/r/#/c/20857/ - I fixed it according to your comment.

rjones (Wed, 16 May 2018 07:28:59 GMT):
@gennadyl I'm not sure your commit message makes sense. Nothing in this commit has to do with ```Chaincode jar packed inside codepackage.tgz file, instead of chaincode source.``` any more, does it?

rjones (Wed, 16 May 2018 07:30:09 GMT):
Maybe say `removed jar file build` or something? am I misunderstanding your change?

rjones (Wed, 16 May 2018 07:30:09 GMT):
Maybe say ```removed jar file build``` or something? am I misunderstanding your change?

gennadyl (Wed, 16 May 2018 07:30:17 GMT):
No, it all this commit about - to change from packing chaincode source to work with chaincode jar.

gennadyl (Wed, 16 May 2018 07:31:08 GMT):
Ok, I will update message

rjones (Wed, 16 May 2018 07:31:17 GMT):
if I misunderstand your change, please tell me

gennadyl (Wed, 16 May 2018 07:31:30 GMT):
It indeed removed chaincode jar build from instantiate flow

rjones (Wed, 16 May 2018 07:31:31 GMT):
I do not have strong feelings about the commit message, I am trying to understand it.

gennadyl (Wed, 16 May 2018 07:32:26 GMT):
Originally chaincode source was packed inside codepackage.tgz, now chaincode jar packed inside codepackage.tzg

gennadyl (Wed, 16 May 2018 07:32:51 GMT):
This is what first line of commit message about.

gennadyl (Wed, 16 May 2018 07:33:21 GMT):
Second line state that now chaincode not build during instantiate

rjones (Wed, 16 May 2018 07:33:29 GMT):
@gennadyl I see a more serious problem now

gennadyl (Wed, 16 May 2018 07:33:35 GMT):
?

rjones (Wed, 16 May 2018 07:33:49 GMT):
@gennadyl you cannot just strip DTCC's copyright from these files

rjones (Wed, 16 May 2018 07:34:23 GMT):
If you want to add an IBM copyright stanza, go ahead I guess, but you should not strip the DTCC copyright

gennadyl (Wed, 16 May 2018 07:35:40 GMT):
Ah, got it. Should it return it?

gennadyl (Wed, 16 May 2018 07:35:51 GMT):
I think it was breaking build

rjones (Wed, 16 May 2018 07:36:41 GMT):
I left comments

rjones (Wed, 16 May 2018 07:37:15 GMT):
It's great to add your three or four line IBM copyright with the SPDX header. I'm on board with SPDX headers.

rjones (Wed, 16 May 2018 07:37:24 GMT):
you just can't strip DTCC's copyright, though

gennadyl (Wed, 16 May 2018 07:37:46 GMT):
Ok, will return DTCC copyright

rjones (Wed, 16 May 2018 07:38:01 GMT):
OK thank you

gennadyl (Wed, 16 May 2018 07:38:19 GMT):
Before or after SPDX?

rjones (Wed, 16 May 2018 07:38:50 GMT):
please read my notes

rjones (Wed, 16 May 2018 07:39:09 GMT):
put the IBM header with SPDX at the top of the file

gennadyl (Wed, 16 May 2018 07:40:15 GMT):
I saw your note and will update change set.

gennadyl (Wed, 16 May 2018 07:40:22 GMT):
Thanks

rjones (Wed, 16 May 2018 07:40:33 GMT):
sure thing. thank you for being understanding.

gennadyl (Wed, 16 May 2018 07:40:47 GMT):
Sure thing

gennadyl (Wed, 16 May 2018 08:01:52 GMT):
@rjones Fixed copyright issue and updated commit message.

gennadyl (Wed, 16 May 2018 08:02:02 GMT):
Can you review?

rjones (Wed, 16 May 2018 08:02:08 GMT):
already did

gennadyl (Wed, 16 May 2018 08:02:35 GMT):
Thanks

kostas (Wed, 16 May 2018 12:15:06 GMT):
Has joined the channel.

kostas (Wed, 16 May 2018 12:16:09 GMT):
Will have all of Latitia's test-related CRs reviewed by EOD today.

dave.enyeart (Wed, 16 May 2018 13:29:26 GMT):
Here's today's priorities for v1.2 Epic CR reviews:

dave.enyeart (Wed, 16 May 2018 13:29:29 GMT):
Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21841/ https://gerrit.hyperledger.org/r/#/c/21753/ (comments to address) Pluggable endorsement (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21465/ Service Discovery (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/21807/ Identity Mixer Fabric (Jonathan) https://gerrit.hyperledger.org/r/#/c/21155/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21157/ https://gerrit.hyperledger.org/r/#/c/21159/ https://gerrit.hyperledger.org/r/#/c/20529/ (comments to address) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20089/ https://gerrit.hyperledger.org/r/#/c/21353/ https://gerrit.hyperledger.org/r/#/c/21409/ https://gerrit.hyperledger.org/r/#/c/21513/ https://gerrit.hyperledger.org/r/#/c/21357/ https://gerrit.hyperledger.org/r/#/c/21681/ https://gerrit.hyperledger.org/r/#/c/21677/ Fabric CA REST APIs (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/20455/ https://gerrit.hyperledger.org/r/#/c/21771/ (comments to address) e2e test framework (Matt, Jason, Kostas) https://gerrit.hyperledger.org/r/#/c/21451/ https://gerrit.hyperledger.org/r/#/c/21453/ https://gerrit.hyperledger.org/r/#/c/21505/ https://gerrit.hyperledger.org/r/#/c/21405/ https://gerrit.hyperledger.org/r/#/c/21683/ (comments to address)

cbf (Wed, 16 May 2018 13:47:53 GMT):
a bunch here ready for one more +2 (or just merge with parent)

cbf (Wed, 16 May 2018 13:47:56 GMT):
https://gerrit.hyperledger.org/r/q/status:open+project:fabric+label:Code-Review%253D2+is:mergeable

gennadyl (Wed, 16 May 2018 14:05:19 GMT):
@cbf Hi Cris.

cbf (Wed, 16 May 2018 14:05:29 GMT):
hi

gennadyl (Wed, 16 May 2018 14:05:55 GMT):
Regarding copyright notice in https://gerrit.hyperledger.org/r/#/c/20857/

gennadyl (Wed, 16 May 2018 14:06:13 GMT):
What should I put there?

gennadyl (Wed, 16 May 2018 14:06:44 GMT):
Original copyright message broke the build

cbf (Wed, 16 May 2018 14:07:07 GMT):
so, we need to not touch the copyright

cbf (Wed, 16 May 2018 14:07:24 GMT):
the copyright itself is JUST the line that has "Copyright..."

cbf (Wed, 16 May 2018 14:07:33 GMT):
the prose AFTER that is the license header

cbf (Wed, 16 May 2018 14:07:48 GMT):
that is being replaced by the SPDX line

gennadyl (Wed, 16 May 2018 14:07:54 GMT):
Ok, will change it

cbf (Wed, 16 May 2018 14:07:57 GMT):
and we should not add IBM copyright

gennadyl (Wed, 16 May 2018 14:08:12 GMT):
Got it

jyellick (Wed, 16 May 2018 14:10:23 GMT):
A request to other maintainers. I know we are looking to get this CR backlog closed, but I've seen some CRs merged which still had outstanding comments. Let's be careful to ensure that we're not discarding reviews for expediency.

gennadyl (Wed, 16 May 2018 14:12:06 GMT):
@cbf Fixed it

sarathkumar (Wed, 16 May 2018 14:42:38 GMT):
Has joined the channel.

cbf (Wed, 16 May 2018 14:49:43 GMT):
thx

cbf (Wed, 16 May 2018 14:50:48 GMT):
+2ed

yacovm (Wed, 16 May 2018 14:54:11 GMT):
can anyone please merge https://gerrit.hyperledger.org/r/#/c/21465/ ? need 1 more +2.... :pray:

yacovm (Wed, 16 May 2018 14:54:11 GMT):
~ can anyone please merge https://gerrit.hyperledger.org/r/#/c/21465/ ? need 1 more +2.... :pray: ~

cbf (Wed, 16 May 2018 14:59:56 GMT):
done

yacovm (Wed, 16 May 2018 15:00:30 GMT):
thanks much

yacovm (Wed, 16 May 2018 15:51:41 GMT):
@rjones https://gerrit.hyperledger.org/r/#/c/16693/ he added the sso

yacovm (Wed, 16 May 2018 15:52:14 GMT):
and also - a general question - if the delta between patch set `i` to patch set `i+1` is only auto-generated code, do you 100% have to add a signed-off-by?

yacovm (Wed, 16 May 2018 15:52:18 GMT):
that was the case here, btw

yacovm (Wed, 16 May 2018 15:52:34 GMT):
because, technically speaking - the code wasn't written by him, but by a tool

yacovm (Wed, 16 May 2018 15:52:56 GMT):
so wondering.... @cbf maybe you can also answer this?

rjones (Wed, 16 May 2018 15:53:46 GMT):
Someone is committing the code. They need to attest to that

yacovm (Wed, 16 May 2018 15:54:16 GMT):
well, but if you do a rebase - we don't enforce that

yacovm (Wed, 16 May 2018 15:54:20 GMT):
right?

rjones (Wed, 16 May 2018 15:54:46 GMT):
On trivial rebar, correct

rjones (Wed, 16 May 2018 15:54:46 GMT):
On trivial rebase, correct

rjones (Wed, 16 May 2018 15:56:19 GMT):
There is no code change for a trivial rebase. If you do a rebase -i to solve merge conflicts you would need to sign

yacovm (Wed, 16 May 2018 15:57:05 GMT):
ok

yacovm (Wed, 16 May 2018 18:01:13 GMT):
https://gerrit.hyperledger.org/r/#/c/21807/ pretty please - the last CR in the SD series that provides server-side features

cbf (Wed, 16 May 2018 18:39:08 GMT):
looking at it now

jyellick (Wed, 16 May 2018 21:04:35 GMT):
https://gerrit.hyperledger.org/r/c/21859/ Easy one for the integration tests

yacovm (Wed, 16 May 2018 21:53:43 GMT):
https://gerrit.hyperledger.org/r/#/c/21807/ pretty please - the last CR in the SD series that provides server-side features already got 1 +2 ...

yacovm (Thu, 17 May 2018 10:38:21 GMT):
https://gerrit.hyperledger.org/r/#/c/21807/ pretty please - the last CR in the SD series that provides server-side features already got 1 +2 ...

yacovm (Thu, 17 May 2018 10:38:21 GMT):
~ https://gerrit.hyperledger.org/r/#/c/21807/ pretty please - the last CR in the SD series that provides server-side features already got 1 +2 ... ~

yacovm (Thu, 17 May 2018 10:38:21 GMT):
~ https://gerrit.hyperledger.org/r/#/c/21807/ pretty please - the last CR in the SD series that provides server-side features ~ ~ already got 1 +2 ... ~

yacovm (Thu, 17 May 2018 10:54:28 GMT):
thanks much @mastersingh24 !

yacovm (Thu, 17 May 2018 11:00:13 GMT):
also - easy CR from @manu https://gerrit.hyperledger.org/r/#/c/16775/

yacovm (Thu, 17 May 2018 11:19:06 GMT):
also - a trivial one, just 1 LOC in test code https://gerrit.hyperledger.org/r/#/c/21891/

sykesm (Thu, 17 May 2018 13:34:06 GMT):
https://gerrit.hyperledger.org/r/c/21893/ - fix invalid yaml in stamples by reordering stanzas https://gerrit.hyperledger.org/r/c/21895/ - fix invalid yaml in fabric by reordering stanzas

sykesm (Thu, 17 May 2018 13:34:06 GMT):
https://gerrit.hyperledger.org/r/c/21893/ - fix invalid yaml in samples by reordering stanzas https://gerrit.hyperledger.org/r/c/21895/ - fix invalid yaml in fabric by reordering stanzas

wlahti (Thu, 17 May 2018 13:38:28 GMT):
Trivial change that switches the two outlier peer CLI calls that logged their success messages at debug instead of info: https://gerrit.hyperledger.org/r/c/21863/

wlahti (Thu, 17 May 2018 13:38:28 GMT):
~Trivial change that switches the two outlier peer CLI calls that logged their success messages at debug instead of info: https://gerrit.hyperledger.org/r/c/21863/~ :ballot_box_with_check:

skarim (Thu, 17 May 2018 13:43:37 GMT):
https://gerrit.hyperledger.org/r/c/20455/ - Needs one more +2

joe-alewine (Thu, 17 May 2018 15:44:00 GMT):
Getting previously merged material about IdeMix into the TOC: https://gerrit.hyperledger.org/r/c/21685/

dave.enyeart (Thu, 17 May 2018 16:35:46 GMT):
Today's CR review priorities for v1.2 epics:

dave.enyeart (Thu, 17 May 2018 16:35:47 GMT):
Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21841/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21753/ (comments to address) Identity Mixer Fabric (Jonathan) https://gerrit.hyperledger.org/r/#/c/21155/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21157/ https://gerrit.hyperledger.org/r/#/c/21159/ Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/21353/ https://gerrit.hyperledger.org/r/#/c/21409/ https://gerrit.hyperledger.org/r/#/c/21513/ (merge conflicts) https://gerrit.hyperledger.org/r/#/c/21357/ (merge conflicts) https://gerrit.hyperledger.org/r/#/c/21681/ (merge conflicts) https://gerrit.hyperledger.org/r/#/c/21677/ (merge conflicts) Fabric CA REST APIs (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/21771/ e2e test framework (Matt, Jason, Kostas) https://gerrit.hyperledger.org/r/#/c/21683/

pandrejko (Thu, 17 May 2018 17:50:24 GMT):
https://gerrit.hyperledger.org/r/#/c/21915/ update of help text for peer channel create command

JonathanLevi (Thu, 17 May 2018 17:54:32 GMT):
https://gerrit.hyperledger.org/r/#/c/21353/ (Merge Conflict/Merge Required) https://gerrit.hyperledger.org/r/#/c/21409/ (Merge Conflict/Merge Required)

joe-alewine (Thu, 17 May 2018 18:07:01 GMT):
ACL doc: https://gerrit.hyperledger.org/r/c/21447/

joe-alewine (Thu, 17 May 2018 18:33:07 GMT):
Making current version of identity and membership docs available in 1.1 branch (easy one, no edits to current content which was already merged): https://gerrit.hyperledger.org/r/c/21921/

joe-alewine (Thu, 17 May 2018 19:22:32 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=98cbKxXwEKKnZEQW8) Need one more +2

dave.enyeart (Fri, 18 May 2018 13:36:09 GMT):
Today's CR priorities for v1.2 Epics:

dave.enyeart (Fri, 18 May 2018 13:36:11 GMT):
Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21841/ (CI re-running) https://gerrit.hyperledger.org/r/#/c/21753/ (comments to address) Identity Mixer Fabric (Jonathan) https://gerrit.hyperledger.org/r/#/c/21155/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21157/ https://gerrit.hyperledger.org/r/#/c/21159/ (comments to address) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/21357/ part5 https://gerrit.hyperledger.org/r/#/c/21681/ part6 https://gerrit.hyperledger.org/r/#/c/21677/ part7 https://gerrit.hyperledger.org/r/#/c/21727/ https://gerrit.hyperledger.org/r/#/c/21845/ https://gerrit.hyperledger.org/r/#/c/21847/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21849/ (comments to address) Identity Mixer Java SDK (Jonathan, Keith, Rick) https://gerrit.hyperledger.org/r/#/c/15367/ https://gerrit.hyperledger.org/r/#/c/15369/ (CI failures) https://gerrit.hyperledger.org/r/#/c/16481/ (CI failures and comments to address) https://gerrit.hyperledger.org/r/#/c/20753/ (CI failures) https://gerrit.hyperledger.org/r/#/c/20755/ (CI failures and comments to address) e2e test framework (Matt, Jason, Kostas) https://gerrit.hyperledger.org/r/#/c/21683/ (comments to address)

rjones (Sat, 19 May 2018 00:45:48 GMT):
https://gerrit.hyperledger.org/r/#/c/21997/ doc cleanup

SjirNijssen (Sat, 19 May 2018 07:50:54 GMT):
Has joined the channel.

manu (Mon, 21 May 2018 08:53:04 GMT):
a super easy one related to identity mixer, changes two lines of comments: https://gerrit.hyperledger.org/r/#/c/22051/.

baohua (Mon, 21 May 2018 09:04:44 GMT):
https://gerrit.hyperledger.org/r/#/c/16313/

baohua (Mon, 21 May 2018 09:32:24 GMT):
https://gerrit.hyperledger.org/r/#/c/22049/

dave.enyeart (Mon, 21 May 2018 13:32:48 GMT):
Today's CR priorities for v1.2 Epics:

dave.enyeart (Mon, 21 May 2018 13:32:50 GMT):
Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21753/ (comments to address) Identity Mixer Fabric (Jonathan, Keith, Gari) https://gerrit.hyperledger.org/r/#/c/20529/ https://gerrit.hyperledger.org/r/#/c/20533/ https://gerrit.hyperledger.org/r/#/c/20987/ (smoke test failing) https://gerrit.hyperledger.org/r/#/c/20989/ https://gerrit.hyperledger.org/r/#/c/21111/ (failing smoke test) 5 https://gerrit.hyperledger.org/r/#/c/21161/ https://gerrit.hyperledger.org/r/#/c/22051/ (merge conflict) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/21847/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21849/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22025/ (comments to address) Identity Mixer Java SDK (Jonathan, Keith, Rick) https://gerrit.hyperledger.org/r/#/c/15369/ (CI failures) https://gerrit.hyperledger.org/r/#/c/16481/ (CI failures and comments to address) https://gerrit.hyperledger.org/r/#/c/20753/ (CI failures) https://gerrit.hyperledger.org/r/#/c/20755/ (CI failures and comments to address)

dave.enyeart (Mon, 21 May 2018 13:32:50 GMT):
Service Discovery (Artem/Gari) https://gerrit.hyperledger.org/r/#/c/22043/ Side DB private data (Dave/Manish) https://gerrit.hyperledger.org/r/#/c/21753/ (comments to address) Identity Mixer Fabric (Jonathan, Keith, Gari) https://gerrit.hyperledger.org/r/#/c/20529/ https://gerrit.hyperledger.org/r/#/c/20533/ https://gerrit.hyperledger.org/r/#/c/20987/ (smoke test failing) https://gerrit.hyperledger.org/r/#/c/20989/ https://gerrit.hyperledger.org/r/#/c/21111/ (failing smoke test) 5 https://gerrit.hyperledger.org/r/#/c/21161/ https://gerrit.hyperledger.org/r/#/c/22051/ (merge conflict) Identity Mixer Fabric-CA (Jonathan, Keith) https://gerrit.hyperledger.org/r/#/c/21847/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21849/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22025/ (comments to address) Identity Mixer Java SDK (Jonathan, Keith, Rick) https://gerrit.hyperledger.org/r/#/c/15369/ (CI failures) https://gerrit.hyperledger.org/r/#/c/16481/ (CI failures and comments to address) https://gerrit.hyperledger.org/r/#/c/20753/ (CI failures) https://gerrit.hyperledger.org/r/#/c/20755/ (CI failures and comments to address)

dave.enyeart (Mon, 21 May 2018 13:32:50 GMT):
*Service Discovery (primary reviewers Artem/Gari)* https://gerrit.hyperledger.org/r/#/c/22043/ *Side DB private data (primary reviewers Dave/Manish)* https://gerrit.hyperledger.org/r/#/c/21753/ (comments to address) *Identity Mixer Fabric (reviewers Jonathan, Keith, Gari)* https://gerrit.hyperledger.org/r/#/c/22051/ (merge conflict) https://gerrit.hyperledger.org/r/#/c/21161/ - Although revocation support is deferred from v1.2, Maria would like this to get merged but simply not call it in v1.2 timeframe (use NO_REVOCATION). BCCSP CRs are deferred from v1.2: https://gerrit.hyperledger.org/r/#/c/20529/ https://gerrit.hyperledger.org/r/#/c/20533/ https://gerrit.hyperledger.org/r/#/c/20987/ (smoke test failing) https://gerrit.hyperledger.org/r/#/c/20989/ https://gerrit.hyperledger.org/r/#/c/21111/ (failing smoke test) *Identity Mixer Fabric-CA (reviewers Jonathan, Keith)* https://gerrit.hyperledger.org/r/#/c/22025/ (comments to address) https://gerrit.hyperledger.org/r/#/c/21847/ (ready for merge) https://gerrit.hyperledger.org/r/#/c/21849/ (ready for merge) *Identity Mixer Java SDK (reviewers Jonathan, Keith, Rick)* https://gerrit.hyperledger.org/r/#/c/15369/ (CI failures) https://gerrit.hyperledger.org/r/#/c/16481/ (CI failures) https://gerrit.hyperledger.org/r/#/c/20753/ (CI failures) https://gerrit.hyperledger.org/r/#/c/20755/ (CI failures and comments to address) and then finally, SDK needs to invoke CA

wenjian (Mon, 21 May 2018 13:54:39 GMT):
Has joined the channel.

Maria (Mon, 21 May 2018 15:10:34 GMT):
https://gerrit.hyperledger.org/r/#/c/21847/ has 2 +2 - ready to be merged

Maria (Mon, 21 May 2018 15:10:48 GMT):
https://gerrit.hyperledger.org/r/#/c/20529/ https://gerrit.hyperledger.org/r/#/c/20533/ https://gerrit.hyperledger.org/r/#/c/20987/ (smoke test failing) https://gerrit.hyperledger.org/r/#/c/20989/ https://gerrit.hyperledger.org/r/#/c/21111/ (failing smoke test) 5

Maria (Mon, 21 May 2018 15:11:07 GMT):
these are BCCSP integration CRs - deferred to 1.3

xixuejia (Tue, 22 May 2018 06:18:47 GMT):
https://gerrit.hyperledger.org/r/#/c/21045/ fabric -metrics for https://jira.hyperledger.org/browse/FAB-9496

baohua (Tue, 22 May 2018 07:00:18 GMT):
https://gerrit.hyperledger.org/r/22103

baohua (Tue, 22 May 2018 07:00:29 GMT):
https://gerrit.hyperledger.org/r/16313

yacovm (Tue, 22 May 2018 08:45:50 GMT):
Trivial one from @manu - https://gerrit.hyperledger.org/r/#/c/22051/ just changes a comment in the code

manu (Tue, 22 May 2018 12:37:58 GMT):
another easy one, making the idemix proto follow the proto style, needs a 2nd +2. https://gerrit.hyperledger.org/r/#/c/22113/

smithbk (Tue, 22 May 2018 13:45:10 GMT):
@dave.enyeart https://gerrit.hyperledger.org/r/#/c/22025/ is abandoned

dave.enyeart (Tue, 22 May 2018 13:57:28 GMT):
@smithbk @JonathanLevi here's the updated list of Identity Mixer CRs:

dave.enyeart (Tue, 22 May 2018 13:57:31 GMT):
*Identity Mixer Fabric (reviewers Jonathan, Keith, Gari)* https://gerrit.hyperledger.org/r/#/c/22113/ *Identity Mixer Fabric-CA (reviewers Jonathan, Keith)* https://gerrit.hyperledger.org/r/#/c/21849/ *Identity Mixer Java SDK (reviewers Jonathan, Keith, Rick)* https://gerrit.hyperledger.org/r/#/c/15369/ https://gerrit.hyperledger.org/r/#/c/16481/ https://gerrit.hyperledger.org/r/#/c/22117/ (resubmitted - CI failures) https://gerrit.hyperledger.org/r/#/c/20755/ (need to rebase on above CR) and then finally, SDK needs to invoke CA

joe-alewine (Tue, 22 May 2018 15:38:26 GMT):
Document ACLs: https://gerrit.hyperledger.org/r/c/21447/

pandrejko (Tue, 22 May 2018 15:46:24 GMT):
https://gerrit.hyperledger.org/r/c/22137/ super quick one

mastersingh24 (Tue, 22 May 2018 19:29:09 GMT):
^^^ done ... but I also backported it to v1.1 - https://gerrit.hyperledger.org/r/22165

sykesm (Tue, 22 May 2018 19:51:57 GMT):
https://gerrit.hyperledger.org/r/c/22143/2 <- super quick (removal of debug log messages) https://gerrit.hyperledger.org/r/c/22145/2 <- relatively quick (reorder two calls to fix a logic race - not a data race) https://gerrit.hyperledger.org/r/c/22097/5 <- slightly less quick (restore policy and acl evaluation on cc-2-cc test)

Ratnakar (Tue, 22 May 2018 21:22:48 GMT):
https://gerrit.hyperledger.org/r/#/c/22157/ - easy one

rameshthoomu (Tue, 22 May 2018 21:49:04 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=TL9Nqh6pxSyWrdjDL) @Ratnakar This will fix the broken e2e cli test.. We have tested this in sandbox and it's working as expected.

rameshthoomu (Tue, 22 May 2018 22:11:37 GMT):
need one more +2 on this change https://gerrit.hyperledger.org/r/#/c/22157/

cbf (Tue, 22 May 2018 22:58:28 GMT):
https://gerrit.hyperledger.org/r/c/22153/

grapebaba (Wed, 23 May 2018 01:58:37 GMT):
https://gerrit.hyperledger.org/r/#/c/22037/ a node sdk patch

jyellick (Wed, 23 May 2018 02:54:10 GMT):
https://gerrit.hyperledger.org/r/c/22169/ trivial one just fixing some vet style errors, no logical change

baohua (Wed, 23 May 2018 07:09:20 GMT):
https://gerrit.hyperledger.org/r/16313

Maria (Wed, 23 May 2018 11:11:40 GMT):
https://gerrit.hyperledger.org/r/#/c/21849/ - the last one for Idemix for fabric CA - has +2 and +1 already

sykesm (Wed, 23 May 2018 13:33:45 GMT):
https://gerrit.hyperledger.org/r/c/22081/ - needed to progress on integration test work

jtclark (Wed, 23 May 2018 13:50:12 GMT):
https://gerrit.hyperledger.org/r/#/c/22173/ - plz review - re: FAB-10259

sykesm (Wed, 23 May 2018 16:01:35 GMT):
bump: https://gerrit.hyperledger.org/r/c/22081/

sykesm (Wed, 23 May 2018 16:01:35 GMT):
~bump: https://gerrit.hyperledger.org/r/c/22081/ ~

pandrejko (Wed, 23 May 2018 16:15:16 GMT):
https://gerrit.hyperledger.org/r/#/c/22197/ quick one

jyellick (Wed, 23 May 2018 18:44:36 GMT):
https://gerrit.hyperledger.org/r/c/22181/ Needs one +2

cbf (Wed, 23 May 2018 19:00:36 GMT):
https://gerrit.hyperledger.org/r/c/22153/

joe-alewine (Wed, 23 May 2018 21:17:20 GMT):
ACL documentation: https://gerrit.hyperledger.org/r/c/21447/

rjones (Wed, 23 May 2018 22:26:59 GMT):
Has left the channel.

baohua (Thu, 24 May 2018 02:24:36 GMT):
https://gerrit.hyperledger.org/r/#/c/16313/

latitiah (Thu, 24 May 2018 14:50:41 GMT):
https://gerrit.hyperledger.org/r/#/c/22015/ - 1 more +2 and merge needed

wlahti (Thu, 24 May 2018 16:26:32 GMT):
fixes a test that fails when run on MacOS: https://gerrit.hyperledger.org/r/c/22261/ - just need one more +2

wlahti (Thu, 24 May 2018 16:26:32 GMT):
~fixes a test that fails when run on MacOS: https://gerrit.hyperledger.org/r/c/22261/ - just need one more +2~ :ballot_box_with_check:

sykesm (Thu, 24 May 2018 19:22:40 GMT):
https://gerrit.hyperledger.org/r/c/22275/ <-- prefix kafka/zk output in integration test https://gerrit.hyperledger.org/r/c/22299/ <-- fail fast when images needed by test are missing https://gerrit.hyperledger.org/r/c/22303/ <-- remove dead code

sykesm (Fri, 25 May 2018 12:55:29 GMT):
https://gerrit.hyperledger.org/r/c/22315/2 https://gerrit.hyperledger.org/r/c/22321/2 https://gerrit.hyperledger.org/r/c/22323/1

dave.enyeart (Fri, 25 May 2018 14:51:29 GMT):
Today’s CR priorities to get end-to-end content working *Identity Mixer Fabric-CA (reviewers Jonathan, Keith)* https://gerrit.hyperledger.org/r/#/c/22227/ (needs review) https://gerrit.hyperledger.org/r/#/c/22273/ (needs review) https://gerrit.hyperledger.org/r/#/c/22305/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22341/ (needs review) *Identity Mixer Java SDK (reviewers Jonathan, Keith, Rick, Gari)* https://gerrit.hyperledger.org/r/#/c/15369/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/22245/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/16481/ (needs review) https://gerrit.hyperledger.org/r/#/c/22117/ (review comments being discussed) https://gerrit.hyperledger.org/r/#/c/22129/ (needs review) https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working)

dave.enyeart (Fri, 25 May 2018 14:51:29 GMT):
Today’s CR priorities to get end-to-end content working *Identity Mixer Fabric-CA (reviewers @JonathanLevi @smithbk )* https://gerrit.hyperledger.org/r/#/c/22227/ (needs review) https://gerrit.hyperledger.org/r/#/c/22273/ (needs review) https://gerrit.hyperledger.org/r/#/c/22305/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22341/ (needs review) *Identity Mixer Java SDK (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/15369/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/22245/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/16481/ (needs review) https://gerrit.hyperledger.org/r/#/c/22117/ (review comments being discussed) https://gerrit.hyperledger.org/r/#/c/22129/ (needs review) https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working)

sklymenko (Sat, 26 May 2018 08:23:33 GMT):
Has joined the channel.

cbf (Sun, 27 May 2018 12:39:40 GMT):
needs one more https://gerrit.hyperledger.org/r/c/22153/

rameshthoomu (Mon, 28 May 2018 03:40:36 GMT):
https://gerrit.hyperledger.org/r/#/c/22419/ https://gerrit.hyperledger.org/r/#/c/22409/

adc (Mon, 28 May 2018 12:46:25 GMT):
@rickr, please, have a look at https://gerrit.hyperledger.org/r/#/c/22117/ I have changed the code towards your request. The change-set has merge conflicts but I will address later cause there are change-sets in the stack that need to be finished first. Thanks for your time.

rickr (Tue, 29 May 2018 11:07:30 GMT):
@adc What is the state of this .. I'm seeing everything needs either rebasing or is based off of something that is not current.

rickr (Tue, 29 May 2018 11:07:45 GMT):

Clipboard - May 29, 2018 7:07 AM

rickr (Tue, 29 May 2018 11:09:16 GMT):
builds still failing

rickr (Tue, 29 May 2018 11:10:22 GMT):
@smithbk Do we have on this stack a full end to end working ?

rickr (Tue, 29 May 2018 11:10:22 GMT):
@smithbk Do we have on this stack that _fully current_ with a full end to end working ?

smithbk (Tue, 29 May 2018 11:30:18 GMT):
@rickr No, see my last update to https://gerrit.hyperledger.org/r/#/c/22189/ for the latest status of end-to-end

rickr (Tue, 29 May 2018 11:55:34 GMT):
BTW I have change set too needing review @mastersingh24 I keep them update date an rebased on current commits https://gerrit.hyperledger.org/r/#/c/22091/ https://gerrit.hyperledger.org/r/#/c/21831/ AND have passing tests

rickr (Tue, 29 May 2018 12:53:21 GMT):
@adc I tried to rebase to get everything current but came to a point where couldn't rebase

dave.enyeart (Tue, 29 May 2018 13:13:24 GMT):
Today’s CR priorities to get end-to-end Identity Mixer content working *Identity Mixer Fabric-CA (reviewers @JonathanLevi @smithbk )* https://gerrit.hyperledger.org/r/#/c/22227/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/22273/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22305/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/22341/ (reviewed, ready for merge) *Identity Mixer Java SDK (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/15369/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/22245/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/16481/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/22117/ (merge conflict and needs review) https://gerrit.hyperledger.org/r/#/c/22129/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working)

Maria (Tue, 29 May 2018 14:23:30 GMT):
just fyi - https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working) is an e2e test that tests ca, sdk and fabric core, we identified the issue (in the encodings of attributes and keys between different components, so not crypto-related issues) and completing the fix now. but to fix that we need to update the whole stack of commits in sdk, thus some CRs are not rebased yes, since we have to do them one-by-one.

Maria (Tue, 29 May 2018 14:23:30 GMT):
just fyi - https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working) is an e2e test that tests ca, sdk, and fabric core all together. We identified the issue (in the encodings of attributes and keys between different components, so not crypto-related issues) and completing the fix now. but to fix that we need to update the whole stack of commits in sdk, thus some CRs are not rebased yes, since we have to do them one-by-one.

Maria (Tue, 29 May 2018 14:23:30 GMT):
just fyi - https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working) is an e2e test that tests ca, sdk, and fabric core all together. We identified the issue (in the encodings of attributes and keys between different components, so not crypto-related issues) and completing the fix now. But to fix that we need to update the whole stack of commits in sdk, thus some CRs are not rebased yes, since we have to do them one-by-one.

Maria (Tue, 29 May 2018 14:23:30 GMT):
just fyi - https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working) is an e2e test that tests ca, sdk, and fabric core all together. We identified the issue (in the encodings of attributes and keys between different components, so not crypto-related issues) and completing the fix now. But to fix that we need to update the whole stack of commits in sdk, thus some CRs are not rebased yet, since we have to do them one-by-one.

Maria (Tue, 29 May 2018 14:23:30 GMT):
just fyi - https://gerrit.hyperledger.org/r/#/c/22189/ (not yet working) is an e2e test that tests ca, sdk, and fabric core all together. We identified the issue (in the encodings of revealed attribute values and keys between different components, so not crypto-related issues) and completing the fix now. But to fix that we need to update the whole stack of commits in sdk, thus some CRs are not rebased yet, since we have to do them one-by-one.

rameshthoomu (Tue, 29 May 2018 15:58:43 GMT):
Minor change https://gerrit.hyperledger.org/r/#/c/22467/

yacovm (Tue, 29 May 2018 18:04:17 GMT):
Simple merge https://gerrit.hyperledger.org/r/#/c/22465/

yacovm (Tue, 29 May 2018 18:04:51 GMT):
just 1 LOC

xixuejia (Wed, 30 May 2018 01:32:59 GMT):
https://gerrit.hyperledger.org/r/#/c/21045/ fabric metrics

dave.enyeart (Wed, 30 May 2018 13:20:44 GMT):
Today’s CR priorities to get end-to-end Identity Mixer content working *Identity Mixer Fabric-CA (reviewers @JonathanLevi @smithbk )* https://gerrit.hyperledger.org/r/#/c/22305/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22341/ (reviewed, ready for merge) *Identity Mixer Java SDK (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/15369/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22245/ (reviewed, ready for merge) https://gerrit.hyperledger.org/r/#/c/16481/ (needs review) https://gerrit.hyperledger.org/r/#/c/22117/ (needs review) https://gerrit.hyperledger.org/r/#/c/22129/ (needs review) https://gerrit.hyperledger.org/r/#/c/22189/ (e2e CR - not yet working)

rameshthoomu (Wed, 30 May 2018 13:53:04 GMT):
Minor change https://gerrit.hyperledger.org/r/#/c/22467/

rickr (Wed, 30 May 2018 14:05:35 GMT):
@dave.enyeart @mastersingh24 And what about https://gerrit.hyperledger.org/r/#/c/22091/ https://gerrit.hyperledger.org/r/#/c/21831/ ? They've been up todate and have working testcases too.

dave.enyeart (Wed, 30 May 2018 14:15:25 GMT):
@rickr Indeed, those are also priorities for review

Maria (Wed, 30 May 2018 14:24:12 GMT):
an update from e2e CR - idemix testing sdk, ca, and fabric in one go - we found all issues - it works now - we are polishing the code now and will update the corresponding CRs asap

joe-alewine (Wed, 30 May 2018 14:31:25 GMT):
ACL doc (already has a +2 from Jason, needs another) --- https://gerrit.hyperledger.org/r/c/21447/

karmicway (Wed, 30 May 2018 15:44:34 GMT):
Has joined the channel.

dave.enyeart (Wed, 30 May 2018 21:14:35 GMT):
private data chaincode sample: https://gerrit.hyperledger.org/r/#/c/22255/

rameshthoomu (Wed, 30 May 2018 23:37:44 GMT):
one more +2 required https://gerrit.hyperledger.org/r/#/c/22467/

Maria (Thu, 31 May 2018 11:40:19 GMT):
https://gerrit.hyperledger.org/r/#/c/22559/ needs a second +2 - just removes a crypto check for revocation (since revocation is not supported, not needed for 1.3 revocation backwards compatibility)

Maria (Thu, 31 May 2018 11:53:22 GMT):
https://gerrit.hyperledger.org/r/#/c/22341/ needs another +2 for CA (Create keystore dir if does not exist since Idemix is not supported by HSM)

Maria (Thu, 31 May 2018 11:56:13 GMT):
https://gerrit.hyperledger.org/r/#/c/22301/ - the last fix for idemix for fabric based on fvt - just fixing encoding for storing keys.

dave.enyeart (Thu, 31 May 2018 11:57:51 GMT):
@Maria I think this is the latest for the full stack:

dave.enyeart (Thu, 31 May 2018 11:57:54 GMT):
CR priorities for Identity Mixer: *Identity Mixer Fabric (reviewers Jonathan, Keith, Gari)* https://gerrit.hyperledger.org/r/#/c/22301/ (needs review) https://gerrit.hyperledger.org/r/#/c/22559/ (reviewed, ready for merge) *Identity Mixer Fabric-CA (reviewers @JonathanLevi @smithbk )* https://gerrit.hyperledger.org/r/#/c/22341/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/22355/ (needs review) https://gerrit.hyperledger.org/r/#/c/22487/ (verification failures) *Identity Mixer Java SDK (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/15369/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22245/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/16481/ (needs review) https://gerrit.hyperledger.org/r/#/c/22117/ (needs review) https://gerrit.hyperledger.org/r/#/c/22129/ (needs review) https://gerrit.hyperledger.org/r/#/c/22567/ (needs review) https://gerrit.hyperledger.org/r/#/c/22189/ (e2e CR - Verification failures)

dave.enyeart (Thu, 31 May 2018 11:57:54 GMT):
CR priorities for Identity Mixer: *Identity Mixer Fabric (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/22301/ (needs review) https://gerrit.hyperledger.org/r/#/c/22559/ (reviewed, ready for merge) *Identity Mixer Fabric-CA (reviewers @JonathanLevi @smithbk )* https://gerrit.hyperledger.org/r/#/c/22341/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/22355/ (needs review) https://gerrit.hyperledger.org/r/#/c/22487/ (verification failures) *Identity Mixer Java SDK (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/15369/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22245/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/16481/ (needs review) https://gerrit.hyperledger.org/r/#/c/22117/ (needs review) https://gerrit.hyperledger.org/r/#/c/22129/ (needs review) https://gerrit.hyperledger.org/r/#/c/22567/ (needs review) https://gerrit.hyperledger.org/r/#/c/22189/ (e2e CR - Verification failures)

dave.enyeart (Thu, 31 May 2018 11:57:54 GMT):
CR priorities for Identity Mixer: *Identity Mixer Fabric (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/22301/ (needs review) https://gerrit.hyperledger.org/r/#/c/22559/ (reviewed, ready for merge) *Identity Mixer Fabric-CA (reviewers @JonathanLevi @smithbk )* https://gerrit.hyperledger.org/r/#/c/22341/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/22355/ (needs review) https://gerrit.hyperledger.org/r/#/c/22487/ (verification failures) *Identity Mixer Java SDK (reviewers @JonathanLevi @smithbk @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/15369/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22245/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/16481/ (needs review) https://gerrit.hyperledger.org/r/#/c/22117/ (needs review) https://gerrit.hyperledger.org/r/#/c/22129/ (needs review) https://gerrit.hyperledger.org/r/#/c/22567/ (needs review) https://gerrit.hyperledger.org/r/#/c/22189/ (e2e CR - Verification failures)

dave.enyeart (Thu, 31 May 2018 11:57:54 GMT):
CR priorities for Identity Mixer: *Identity Mixer Fabric (reviewers @JonathanLevi @smithbk @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/22301/ (needs review) https://gerrit.hyperledger.org/r/#/c/22559/ (reviewed, ready for merge) *Identity Mixer Fabric-CA (reviewers @JonathanLevi @smithbk )* https://gerrit.hyperledger.org/r/#/c/22341/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/22355/ (needs review) https://gerrit.hyperledger.org/r/#/c/22487/ (verification failures) *Identity Mixer Java SDK (reviewers @JonathanLevi @smithbk @rickr @mastersingh24 )* https://gerrit.hyperledger.org/r/#/c/15369/ (comments to address) https://gerrit.hyperledger.org/r/#/c/22245/ (needs one more review) https://gerrit.hyperledger.org/r/#/c/16481/ (needs review) https://gerrit.hyperledger.org/r/#/c/22117/ (needs review) https://gerrit.hyperledger.org/r/#/c/22129/ (needs review) https://gerrit.hyperledger.org/r/#/c/22567/ (needs review) https://gerrit.hyperledger.org/r/#/c/22189/ (e2e CR - Verification failures)

Maria (Thu, 31 May 2018 12:01:01 GMT):
https://gerrit.hyperledger.org/r/#/c/22189/ (e2e CR - Verification failures) - we are modifying now 2 tests that are failing - to accommodate idemix behavior for user/enrollment due to its different nature

Maria (Thu, 31 May 2018 12:01:33 GMT):
but the e2e demo is working now successfully - I am preparing a full status update on Idemix.

pandrejko (Thu, 31 May 2018 14:08:30 GMT):
https://gerrit.hyperledger.org/r/22587 easy one

nagap (Thu, 31 May 2018 16:15:32 GMT):
Has joined the channel.

wlahti (Thu, 31 May 2018 17:44:56 GMT):
Fixes compilation issues in the ACL function tests after a recently merged CR: https://gerrit.hyperledger.org/r/c/22599/

dave.enyeart (Thu, 31 May 2018 20:08:40 GMT):
private data chaincode sample: https://gerrit.hyperledger.org/r/#/c/22255/

dave.enyeart (Thu, 31 May 2018 20:08:40 GMT):
private data chaincode sample: ~https://gerrit.hyperledger.org/r/#/c/22255/~

dave.enyeart (Thu, 31 May 2018 20:09:33 GMT):
It's not as big as it seems, as most of the chaincode sample is copy/paste from the existing marbles02 sample, just updated to use private data APIs rather than traditional chaincode apis

rjones (Thu, 31 May 2018 22:28:54 GMT):
Has joined the channel.

rjones (Thu, 31 May 2018 22:31:57 GMT):
update homebrew: https://gerrit.hyperledger.org/r/#/c/22657/

yacovm (Fri, 01 Jun 2018 07:41:13 GMT):
Easy bug fix... 1 line of code https://gerrit.hyperledger.org/r/#/c/22663/ need 1 more +2

yacovm (Fri, 01 Jun 2018 07:41:13 GMT):
~ Easy bug fix... 1 line of code https://gerrit.hyperledger.org/r/#/c/22663/ need 1 more +2 ~ thanks @dave.enyeart !

joe-alewine (Fri, 01 Jun 2018 17:50:13 GMT):
Removing IdeMix docs from TOC: https://gerrit.hyperledger.org/r/c/22683/

joe-alewine (Fri, 01 Jun 2018 17:50:13 GMT):
Easy one. Removing IdeMix docs from TOC: https://gerrit.hyperledger.org/r/c/22683/

joe-alewine (Fri, 01 Jun 2018 17:50:13 GMT):
Easy one. Removing IdeMix docs from TOC: https://gerrit.hyperledger.org/r/c/22683/ (Done, thanks Gari and Dave!)

cbf (Sun, 03 Jun 2018 13:25:24 GMT):
https://gerrit.hyperledger.org/r/c/22445/

dave.enyeart (Mon, 04 Jun 2018 10:06:13 GMT):
One more needed on https://gerrit.hyperledger.org/r/#/c/22253/ please

dave.enyeart (Mon, 04 Jun 2018 10:06:13 GMT):
One more needed on https://gerrit.hyperledger.org/r/#/c/22253/ and https://gerrit.hyperledger.org/r/#/c/22685/ please

dave.enyeart (Mon, 04 Jun 2018 10:06:13 GMT):
One more needed on ~https://gerrit.hyperledger.org/r/#/c/22253/~ and ~https://gerrit.hyperledger.org/r/#/c/22685/~ please

pandrejko (Mon, 04 Jun 2018 13:56:20 GMT):
Need 1 more +2 on https://gerrit.hyperledger.org/r/#/c/22587/

pandrejko (Mon, 04 Jun 2018 15:21:49 GMT):
Need 1 more +2 on glossary update https://gerrit.hyperledger.org/r/#/c/22597/

rjones (Mon, 04 Jun 2018 15:28:49 GMT):
[s][ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=cuWQYd63T6DwwmaHH) please take a look at this small change for the Homebrew tap

rjones (Mon, 04 Jun 2018 15:28:49 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=cuWQYd63T6DwwmaHH) please take a look at this small change for the Homebrew tap

yacovm (Mon, 04 Jun 2018 19:58:18 GMT):
easy one https://gerrit.hyperledger.org/r/#/c/22741/

C0rWin (Tue, 05 Jun 2018 11:20:03 GMT):
two simple fixes for pvt data: https://gerrit.hyperledger.org/r/#/c/22763/ and https://gerrit.hyperledger.org/r/#/c/22765/ need last +2 for each

dave.enyeart (Tue, 05 Jun 2018 13:52:38 GMT):
@C0rWin I +2ed the latter, and am doing tests on the former

dave.enyeart (Tue, 05 Jun 2018 14:35:45 GMT):
Both merged now

pandrejko (Tue, 05 Jun 2018 14:59:28 GMT):
https://gerrit.hyperledger.org/r/c/20469/ CouchDB Tutorial

rameshthoomu (Tue, 05 Jun 2018 15:02:10 GMT):
two minor patchsets https://gerrit.hyperledger.org/r/#/c/22781/ https://gerrit.hyperledger.org/r/#/c/22783/

rameshthoomu (Tue, 05 Jun 2018 16:13:26 GMT):
@bretharrison https://gerrit.hyperledger.org/r/#/c/22101/ - Upgrade nodejs to 8.11.2 in baseimage

cbf (Tue, 05 Jun 2018 16:25:48 GMT):
@bretharrison you verified this ^^

cbf (Tue, 05 Jun 2018 16:25:50 GMT):
?

rjones (Tue, 05 Jun 2018 16:33:44 GMT):
~[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=nF48T6jTjuhhSebom)I need one more +2 to upgrade the homebrew packages~

rjones (Tue, 05 Jun 2018 16:33:44 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=nF48T6jTjuhhSebom) I need one more +2 to upgrade the homebrew packages

rjones (Tue, 05 Jun 2018 16:33:44 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=nF48T6jTjuhhSebom)[s] I need one more +2 to upgrade the homebrew packages[/s]

jyellick (Tue, 05 Jun 2018 18:09:11 GMT):
https://gerrit.hyperledger.org/r/c/22475/ https://gerrit.hyperledger.org/r/c/22477/ ^ Been hanging out for a while, both purely add tests

rjones (Tue, 05 Jun 2018 18:42:26 GMT):
thank you @dave.enyeart

nirro (Wed, 06 Jun 2018 11:54:50 GMT):
@rjones can you please review https://gerrit.hyperledger.org/r/#/c/22773/ ? it's a very simple CR, I just added small things to peer runner that I need in order to complete private data (side db) e2e tests..

wlahti (Wed, 06 Jun 2018 13:36:20 GMT):
one line change in terms of actual code to change a logging message from info level to debug: https://gerrit.hyperledger.org/r/c/22779/

wlahti (Wed, 06 Jun 2018 13:36:20 GMT):
one line change in terms of actual code to change a logging message from info level to debug, at the request of one of the performance testers: https://gerrit.hyperledger.org/r/c/22779/

wlahti (Wed, 06 Jun 2018 13:36:20 GMT):
~one line change in terms of actual code to change a logging message from info level to debug, at the request of one of the performance testers: https://gerrit.hyperledger.org/r/c/22779/~ :ballot_box_with_check:

latitiah (Wed, 06 Jun 2018 18:36:40 GMT):
Please review - pretty simple: https://gerrit.hyperledger.org/r/#/c/22731/

rjones (Wed, 06 Jun 2018 18:52:40 GMT):
@nirro I'm not really a reviewer for Fabric :)

rjones (Wed, 06 Jun 2018 18:52:40 GMT):
@nirro O

pandrejko (Thu, 07 Jun 2018 17:31:14 GMT):
https://gerrit.hyperledger.org/r/#/c/20469/

yacovm (Thu, 07 Jun 2018 21:52:43 GMT):
Quick and easy to review bug fix https://gerrit.hyperledger.org/r/#/c/22553/ only 5 lines of production code

wlahti (Fri, 08 Jun 2018 14:02:17 GMT):
Fix for a flake in the integration tests: https://gerrit.hyperledger.org/r/c/22825/

wlahti (Fri, 08 Jun 2018 14:02:17 GMT):
~Fix for a flake in the integration tests: https://gerrit.hyperledger.org/r/c/22825/~:ballot_box_with_check:

wlahti (Fri, 08 Jun 2018 17:07:20 GMT):
And a fix of my own for another flakey part in the integration test config used by the e2e tests: https://gerrit.hyperledger.org/r/c/22883/

wlahti (Fri, 08 Jun 2018 17:07:20 GMT):
~And a fix of my own for another flakey part in the integration test config used by the e2e tests: https://gerrit.hyperledger.org/r/c/22883/~ :ballot_box_with_check:

jyellick (Fri, 08 Jun 2018 20:38:40 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=HygXivFDoKtLndiNC)

jyellick (Fri, 08 Jun 2018 20:39:06 GMT):
^ +1 can we get this merged? It's small/simple change and it is fixing a flake (one that flakes consistently on my laptop)

rameshthoomu (Mon, 11 Jun 2018 15:32:06 GMT):
Two minor change sets -- logo issue fix https://gerrit.hyperledger.org/r/#/c/22781/ https://gerrit.hyperledger.org/r/#/c/22783/

rameshthoomu (Mon, 11 Jun 2018 16:12:22 GMT):
@cbf Jenkinfile change in fabric-samples repo https://gerrit.hyperledger.org/r/#/c/22443/

cbf (Mon, 11 Jun 2018 16:14:43 GMT):
missing license headers

cbf (Mon, 11 Jun 2018 16:15:30 GMT):
@rameshthoomu @jwagantall

rameshthoomu (Mon, 11 Jun 2018 16:16:09 GMT):
Oh missed it..

rameshthoomu (Mon, 11 Jun 2018 16:20:26 GMT):
done

cbf (Mon, 11 Jun 2018 16:25:05 GMT):
thx

cbf (Mon, 11 Jun 2018 16:28:27 GMT):
don't think the jenkinsfile is a bash script @rameshthoomu

cbf (Mon, 11 Jun 2018 16:28:39 GMT):
think it wants a // style comment

wlahti (Mon, 11 Jun 2018 16:57:12 GMT):
https://gerrit.hyperledger.org/r/c/22867 - adds function aliases for some LSCC calls for consistency with other system chaincodes (to allow cleaner testing of system chaincode ACLs)

wlahti (Mon, 11 Jun 2018 16:57:12 GMT):
~https://gerrit.hyperledger.org/r/c/22867 - adds function aliases for some LSCC calls for consistency with other system chaincodes (to allow cleaner testing of system chaincode ACLs)~ :ballot_box_with_check:

wlahti (Mon, 11 Jun 2018 18:38:43 GMT):
system chaincode ACL function tests ready for review: https://gerrit.hyperledger.org/r/c/22541/ and https://gerrit.hyperledger.org/r/c/22471/12

wlahti (Mon, 11 Jun 2018 18:38:43 GMT):
system chaincode ACL function tests ready for review: https://gerrit.hyperledger.org/r/c/22541/ and https://gerrit.hyperledger.org/r/c/22471

wlahti (Mon, 11 Jun 2018 18:38:43 GMT):
system chaincode ACL function tests ready for review: ~https://gerrit.hyperledger.org/r/c/22541/~ and https://gerrit.hyperledger.org/r/c/22471

rameshthoomu (Mon, 11 Jun 2018 21:39:06 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/22443/

cbf (Tue, 12 Jun 2018 19:49:11 GMT):
https://gerrit.hyperledger.org/r/c/22961/ and https://gerrit.hyperledger.org/r/c/22981/

cbf (Tue, 12 Jun 2018 19:49:11 GMT):
https://gerrit.hyperledger.org/r/c/22961/ and https://gerrit.hyperledger.org/r/c/22959/

cbf (Tue, 12 Jun 2018 20:04:36 GMT):
https://gerrit.hyperledger.org/r/22993 @mastersingh24 @rameshthoomu @kostas @greg.haskins this CR adds a new metadata property to track the commit sha, it also hard codes the version so that we can pursue the stable image strategy. It also has a side effect that it resolves FAB-8559 to the extent that was an issue (it had a workaround).

cbf (Tue, 12 Jun 2018 20:06:36 GMT):
note that this could have been DRYed up but will reserve that for post 1.2 because there is likely to be other refactoring of the commandline tools anywho

yacovm (Tue, 12 Jun 2018 20:18:14 GMT):
https://gerrit.hyperledger.org/r/#/c/22509/ need 1 more +2... any takers? :pray: we need this in for the FVT

cbf (Tue, 12 Jun 2018 20:37:56 GMT):
done

yacovm (Tue, 12 Jun 2018 20:40:50 GMT):
thanks much @cbf !

cbf (Tue, 12 Jun 2018 20:42:07 GMT):
yep

yacovm (Tue, 12 Jun 2018 20:42:39 GMT):
Next one in line, a documentation for the discovery CLI - can be seen here https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-docs-build-x86_64/426/html/discovery-cli.html https://gerrit.hyperledger.org/r/#/c/22905/ need 1 more +2

cbf (Tue, 12 Jun 2018 20:42:57 GMT):
https://chat.hyperledger.org/channel/fabric-pr-review?msg=wXZ4ahYmfHdhc2XXt

wlahti (Tue, 12 Jun 2018 20:46:32 GMT):
https://gerrit.hyperledger.org/r/c/22471/ - likely the final system chaincode ACL FVT test for v1.2

rameshthoomu (Tue, 12 Jun 2018 20:48:35 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/22443/

cbf (Wed, 13 Jun 2018 21:15:59 GMT):
need one more on this https://gerrit.hyperledger.org/r/c/22959/

cbf (Wed, 13 Jun 2018 21:17:31 GMT):
https://gerrit.hyperledger.org/r/c/22981/

wlahti (Wed, 13 Jun 2018 21:27:03 GMT):
Still need one more review for this system chaincode ACL function test: https://gerrit.hyperledger.org/r/c/22471/

wlahti (Wed, 13 Jun 2018 21:27:03 GMT):
~Still need one more review for this system chaincode ACL function test: https://gerrit.hyperledger.org/r/c/22471/ ~ :ballot_box_with_check:

cbf (Thu, 14 Jun 2018 11:14:30 GMT):
need one more on https://gerrit.hyperledger.org/r/c/22959/

cbf (Thu, 14 Jun 2018 12:42:19 GMT):
easy one please - restores a skipped test https://gerrit.hyperledger.org/r/c/23019/

cbf (Thu, 14 Jun 2018 13:21:59 GMT):
need some reviews of this please https://gerrit.hyperledger.org/r/c/22981/

cbf (Thu, 14 Jun 2018 13:22:16 GMT):
and this https://gerrit.hyperledger.org/r/c/22995/

kostas (Thu, 14 Jun 2018 15:57:28 GMT):
A fabric-ca CR: https://gerrit.hyperledger.org/r/c/21843/

cbf (Thu, 14 Jun 2018 15:58:29 GMT):
https://gerrit.hyperledger.org/r/c/22995/

cbf (Thu, 14 Jun 2018 16:06:29 GMT):
@kostas @smithbk @mastersingh24 https://gerrit.hyperledger.org/r/c/21843/ had to be tweaked to fix license headers

dave.enyeart (Fri, 15 Jun 2018 16:56:08 GMT):
If anybody wants to build a track record of reviews for fabric-sdk-java, the service discovery support is still awaiting review: https://gerrit.hyperledger.org/r/#/c/21583/

harsha (Sat, 16 Jun 2018 04:28:03 GMT):
Java Version Update :- https://gerrit.hyperledger.org/r/c/23217/

dave.enyeart (Sat, 16 Jun 2018 14:18:36 GMT):
Two 'high' defect fixes are ready for final review and merge. I've tested both of them:

dave.enyeart (Sat, 16 Jun 2018 14:18:36 GMT):
Three 'high' sev defect fixes are ready for final review and merge. I've reviewed and tested each of them:

dave.enyeart (Sat, 16 Jun 2018 14:18:39 GMT):
https://gerrit.hyperledger.org/r/#/c/23059/

dave.enyeart (Sat, 16 Jun 2018 14:18:39 GMT):
~https://gerrit.hyperledger.org/r/#/c/23059/~

dave.enyeart (Sat, 16 Jun 2018 14:19:02 GMT):
https://gerrit.hyperledger.org/r/#/c/22909/

dave.enyeart (Sat, 16 Jun 2018 14:19:02 GMT):
~https://gerrit.hyperledger.org/r/#/c/22909/~

dave.enyeart (Sat, 16 Jun 2018 17:20:45 GMT):
https://gerrit.hyperledger.org/r/#/c/22887/

dave.enyeart (Sat, 16 Jun 2018 17:20:45 GMT):
~https://gerrit.hyperledger.org/r/#/c/22887/~

gennadyl (Sun, 17 Jun 2018 13:03:49 GMT):
https://gerrit.hyperledger.org/r/#/c/22813/

gennadyl (Sun, 17 Jun 2018 13:05:17 GMT):
Just small integration test

yacovm (Sun, 17 Jun 2018 14:20:33 GMT):
Easy one https://gerrit.hyperledger.org/r/#/c/23223/

yacovm (Sun, 17 Jun 2018 14:20:48 GMT):
Just adding an an additional field print to the discovery CLI

dave.enyeart (Sun, 17 Jun 2018 17:43:42 GMT):
CouchDB Tutorial: https://gerrit.hyperledger.org/r/#/c/20469/

yacovm (Sun, 17 Jun 2018 17:49:45 GMT):
easy doc change https://gerrit.hyperledger.org/r/#/c/23225/

dave.enyeart (Sun, 17 Jun 2018 18:58:04 GMT):
Private data key concepts: https://gerrit.hyperledger.org/r/#/c/22505/

dave.enyeart (Sun, 17 Jun 2018 18:58:04 GMT):
Private data key concepts: ~https://gerrit.hyperledger.org/r/#/c/22505/~

dave.enyeart (Sun, 17 Jun 2018 21:43:52 GMT):
Private data architecture: https://gerrit.hyperledger.org/r/#/c/22817/

dave.enyeart (Sun, 17 Jun 2018 21:43:52 GMT):
Private data architecture: ~https://gerrit.hyperledger.org/r/#/c/22817/~

dave.enyeart (Sun, 17 Jun 2018 21:47:13 GMT):
Private data tutorial: https://gerrit.hyperledger.org/r/#/c/22357/

dave.enyeart (Sun, 17 Jun 2018 21:47:13 GMT):
Private data tutorial: ~https://gerrit.hyperledger.org/r/#/c/22357/~

nirro (Mon, 18 Jun 2018 08:19:10 GMT):
Discovery Service runner in order to perform e2e tests - https://gerrit.hyperledger.org/r/#/c/23237/

nirro (Mon, 18 Jun 2018 11:49:43 GMT):
extension of peer runner and struct to include collection config in order to test private data - https://gerrit.hyperledger.org/r/#/c/23241/

nirro (Mon, 18 Jun 2018 14:08:04 GMT):
private data e2e test - add org to collection config - https://gerrit.hyperledger.org/r/#/c/22585/

joe-alewine (Mon, 18 Jun 2018 16:04:56 GMT):
Fix a few broken links in Private Data docs: https://gerrit.hyperledger.org/r/c/23249/

joe-alewine (Mon, 18 Jun 2018 16:04:56 GMT):
Easy one. Just fixing a few broken links in Private Data docs: https://gerrit.hyperledger.org/r/c/23249/

dave.enyeart (Mon, 18 Jun 2018 16:13:37 GMT):
return correct couchdb errors: https://gerrit.hyperledger.org/r/#/c/22943/

mrkiouak (Mon, 18 Jun 2018 20:31:07 GMT):
I _think_ theres currently a freeze in place for the 1.2 release, but I'd be curious to hear feedback on https://gerrit.hyperledger.org/r/#/c/23273/, i outlined a few options I could think of in the associated jira, but I think ensuring the cli tooling gives actionable error messages is an area that could use additional improvement.

joe-alewine (Mon, 18 Jun 2018 20:33:33 GMT):
Another easy one: change other text in the docs that refers to upgrading to v1.1 (as well as making the name of a doc generic): https://gerrit.hyperledger.org/r/c/23275/

joe-alewine (Mon, 18 Jun 2018 20:33:33 GMT):
Another easy one: change other text in the docs that refers to upgrading to v1.1 (as well as making the name of a doc generic): see new gerrit below

davidkhala (Tue, 19 Jun 2018 06:58:34 GMT):
@bretharrison https://gerrit.hyperledger.org/r/#/c/23175/ I updated the commit, please review if you have time

nirro (Tue, 19 Jun 2018 15:19:02 GMT):
hi, I have several CRs waiting for review, regarding pvtdata and discovery service e2e tests, please review: https://gerrit.hyperledger.org/r/#/c/23241/ https://gerrit.hyperledger.org/r/#/c/23237/ https://gerrit.hyperledger.org/r/#/c/22585/ https://gerrit.hyperledger.org/r/#/c/22703/ https://gerrit.hyperledger.org/r/#/c/22857/ https://gerrit.hyperledger.org/r/#/c/22973/

joe-alewine (Tue, 19 Jun 2018 16:06:16 GMT):
Easy one. New version of changing "other" upgrade documentation that refers to 1.0 and 1.1 instead of 1.2: https://gerrit.hyperledger.org/r/c/23329/

dave.enyeart (Tue, 19 Jun 2018 17:05:27 GMT):
One more +2 needed on CouchDB tutorial please: https://gerrit.hyperledger.org/r/#/c/20469/

joe-alewine (Tue, 19 Jun 2018 18:15:39 GMT):
Another easy one. Just some formatting and a broken link in the Private Data tutorial: https://gerrit.hyperledger.org/r/c/23337/3

wlahti (Tue, 19 Jun 2018 19:36:05 GMT):
Serviceability CR - adds logging of client address to eventhub: https://gerrit.hyperledger.org/r/c/23177/

wlahti (Tue, 19 Jun 2018 19:36:05 GMT):
~Serviceability CR - adds logging of client address to eventhub: https://gerrit.hyperledger.org/r/c/23177/~:ballot_box_with_check:

cbf (Tue, 19 Jun 2018 19:44:54 GMT):
need one more on Will's CR above

gennadyl (Wed, 20 Jun 2018 13:53:10 GMT):
https://gerrit.hyperledger.org/r/#/c/22813/ - somebody, please

joe-alewine (Wed, 20 Jun 2018 15:32:07 GMT):
Upgrade doc: https://gerrit.hyperledger.org/r/c/23209/ Naga has updated the commands here where needed. Still waiting for the CRs to get out there for the scripts as well as a small change to BYFN itself.

joe-alewine (Wed, 20 Jun 2018 15:32:07 GMT):
Upgrade doc: https://gerrit.hyperledger.org/r/c/23209/ Naga has updated the commands here where needed and tested the flow. Still waiting for the CRs to get out there for the scripts as well as a small change to BYFN itself.

rameshthoomu (Wed, 20 Jun 2018 19:36:07 GMT):
need one more +2 on this https://gerrit.hyperledger.org/r/#/c/23401/

rameshthoomu (Wed, 20 Jun 2018 19:44:44 GMT):
https://gerrit.hyperledger.org/r/#/c/23411/ - minor change

joe-alewine (Wed, 20 Jun 2018 19:53:11 GMT):
Here are the code changes (the scripts, the change to BYFN, etc) for Upgrade: https://gerrit.hyperledger.org/r/c/23385/

wlahti (Wed, 20 Jun 2018 22:28:04 GMT):
Even though the deliver service is the preferred event method these days, the eventhub is nevertheless still part of the project and used. This CR attempts to fix a major issue where the flow of events from the eventhub can completely stop for all clients if a single problematic client connection holds on to the grpc connection: https://gerrit.hyperledger.org/r/c/23179/

grapebaba (Thu, 21 Jun 2018 10:26:13 GMT):
@kostas @jyellick I submit a big patch which is tendermint ordering service https://gerrit.hyperledger.org/r/#/c/21313/, it may be not mature, feel free to give feedback. The design doc I have updated https://docs.google.com/document/d/1dJ1ifMmts1JKHl-QrI--jIkhwK2uu2a7qsj24Y4stN0/edit#

pandrejko (Thu, 21 Jun 2018 14:23:37 GMT):
https://gerrit.hyperledger.org/r/#/c/23349/

dave.enyeart (Thu, 21 Jun 2018 15:14:43 GMT):
https://gerrit.hyperledger.org/r/#/c/23443/ - must-fix for private data scenarios

dave.enyeart (Thu, 21 Jun 2018 15:14:43 GMT):
~https://gerrit.hyperledger.org/r/#/c/23443/~ - must-fix for private data scenarios

rameshthoomu (Thu, 21 Jun 2018 16:49:34 GMT):
https://gerrit.hyperledger.org/r/#/c/23343/ - Integration tests are failing inconsistently in nightly builds due to the timeout issue.. This merge unblocks nightly builds to publish with out re-triggering multiple times..

dave.enyeart (Thu, 21 Jun 2018 18:48:55 GMT):
easy doc link fix: https://gerrit.hyperledger.org/r/#/c/23463/

latitiah (Thu, 21 Jun 2018 18:50:25 GMT):
Needs 1 more +2 and merge: https://gerrit.hyperledger.org/r/#/c/23343/

dave.enyeart (Thu, 21 Jun 2018 19:04:44 GMT):
event hub fix: https://gerrit.hyperledger.org/r/#/c/23179/

dave.enyeart (Thu, 21 Jun 2018 20:01:17 GMT):
deliver fix: https://gerrit.hyperledger.org/r/#/c/23455/ @kostas you've already +2ed once...

davidkhala (Fri, 22 Jun 2018 06:30:09 GMT):
@bretharrison ready to merge https://gerrit.hyperledger.org/r/#/c/23437/

rjones (Fri, 22 Jun 2018 15:27:28 GMT):
Has left the channel.

cbf (Fri, 22 Jun 2018 16:44:26 GMT):
Fabric CA MERGE FREEZE END

pandrejko (Fri, 22 Jun 2018 17:10:51 GMT):
docs: https://gerrit.hyperledger.org/r/#/c/23551/ && https://gerrit.hyperledger.org/r/#/c/23545/ (same change, one for release 1.2 branch and one for master branch)

pandrejko (Fri, 22 Jun 2018 18:56:13 GMT):
docs: adding a folder of images which can be used as a visual vocab in glossary and to build illustrations: https://gerrit.hyperledger.org/r/#/c/23473/

pandrejko (Fri, 22 Jun 2018 19:32:28 GMT):
docs: https://gerrit.hyperledger.org/r/#/c/23561/

pandrejko (Fri, 22 Jun 2018 19:32:28 GMT):
docs: https://gerrit.hyperledger.org/r/#/c/23561/ && https://gerrit.hyperledger.org/r/#/c/23563/

bur (Mon, 25 Jun 2018 07:17:14 GMT):
Needs one more +2: GetGecorations support for MockStub: https://gerrit.hyperledger.org/r/#/c/23541/

dave.enyeart (Mon, 25 Jun 2018 10:17:55 GMT):
must-fix for v1.2:

dave.enyeart (Mon, 25 Jun 2018 10:18:03 GMT):
https://gerrit.hyperledger.org/r/#/c/23591/ https://gerrit.hyperledger.org/r/#/c/23593/

dave.enyeart (Mon, 25 Jun 2018 10:18:03 GMT):
~https://gerrit.hyperledger.org/r/#/c/23591/~ ~https://gerrit.hyperledger.org/r/#/c/23593/~

dave.enyeart (Mon, 25 Jun 2018 12:38:13 GMT):
Another must-fix for phantom read invalidation:

dave.enyeart (Mon, 25 Jun 2018 12:38:14 GMT):
https://gerrit.hyperledger.org/r/23503

dave.enyeart (Mon, 25 Jun 2018 12:38:14 GMT):
https://gerrit.hyperledger.org/r/23503 (master)

dave.enyeart (Mon, 25 Jun 2018 12:38:14 GMT):
~https://gerrit.hyperledger.org/r/23503~ (master)

dave.enyeart (Mon, 25 Jun 2018 12:38:21 GMT):
https://gerrit.hyperledger.org/r/#/c/23595/

dave.enyeart (Mon, 25 Jun 2018 12:38:21 GMT):
https://gerrit.hyperledger.org/r/#/c/23595/ (release-1.2)

dave.enyeart (Mon, 25 Jun 2018 12:38:21 GMT):
~https://gerrit.hyperledger.org/r/#/c/23595/~ (release-1.2)

dave.enyeart (Mon, 25 Jun 2018 14:54:58 GMT):
Fix release links in README:

dave.enyeart (Mon, 25 Jun 2018 14:55:00 GMT):
https://gerrit.hyperledger.org/r/#/c/23601/ (master) https://gerrit.hyperledger.org/r/#/c/23603/ (release-1.2)

dave.enyeart (Tue, 26 Jun 2018 11:31:55 GMT):
The phantom read defect is must-fix and needs to get merged for system test please:

dave.enyeart (Tue, 26 Jun 2018 11:32:08 GMT):
https://gerrit.hyperledger.org/r/23503 (master) https://gerrit.hyperledger.org/r/#/c/23595/ (release-1.2)

dave.enyeart (Tue, 26 Jun 2018 11:32:08 GMT):
~https://gerrit.hyperledger.org/r/23503~ (master) ~https://gerrit.hyperledger.org/r/#/c/23595/~ (release-1.2)

dave.enyeart (Tue, 26 Jun 2018 11:32:48 GMT):
I've added an explanation of phantom reads to the Jira to make the review easier: https://jira.hyperledger.org/browse/FAB-10788?focusedCommentId=46484&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-46484

wlahti (Tue, 26 Jun 2018 16:57:10 GMT):
Minor doc bug in the `peer channel` docs: release-1.2 branch: https://gerrit.hyperledger.org/r/c/23667 master branch: https://gerrit.hyperledger.org/r/c/23665

wlahti (Tue, 26 Jun 2018 16:57:10 GMT):
Minor doc bug in the `peer channel` CLI docs: release-1.2 branch: https://gerrit.hyperledger.org/r/c/23667 master branch: https://gerrit.hyperledger.org/r/c/23665

rameshthoomu (Tue, 26 Jun 2018 20:48:32 GMT):
https://gerrit.hyperledger.org/r/#/c/23689/

rameshthoomu (Wed, 27 Jun 2018 16:20:09 GMT):
one more +2 https://gerrit.hyperledger.org/r/#/c/23695/

rameshthoomu (Wed, 27 Jun 2018 19:35:15 GMT):
https://gerrit.hyperledger.org/r/#/c/23749/ https://gerrit.hyperledger.org/r/#/c/23513/

rameshthoomu (Wed, 27 Jun 2018 20:50:28 GMT):
@mastersingh24 https://gerrit.hyperledger.org/r/#/c/23753/

dave.enyeart (Wed, 27 Jun 2018 21:52:18 GMT):
@rameshthoomu @mastersingh24 @cbf let's increment to 0.4.10 baseimage first, this one needs to be merged next: https://gerrit.hyperledger.org/r/#/c/23297/

rameshthoomu (Thu, 28 Jun 2018 00:49:48 GMT):
This has to go as soon as possible.. s390x builds are broken and it's a showstopper for 1.2 release..

rameshthoomu (Thu, 28 Jun 2018 03:41:25 GMT):
Thanks @kostas

rameshthoomu (Thu, 28 Jun 2018 03:41:48 GMT):
@dave.enyeart I have rebased my change now.. https://gerrit.hyperledger.org/r/#/c/23753/

cbf (Thu, 28 Jun 2018 09:45:12 GMT):
https://gerrit.hyperledger.org/r/c/23555/ easy one

dave.enyeart (Thu, 28 Jun 2018 09:54:20 GMT):
@cbf +2ed. Do you need the same change in release-1.2?

cbf (Thu, 28 Jun 2018 09:54:50 GMT):
yes

cbf (Thu, 28 Jun 2018 09:56:04 GMT):
https://gerrit.hyperledger.org/r/c/23783

rameshthoomu (Thu, 28 Jun 2018 17:54:16 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/23695/

rameshthoomu (Thu, 28 Jun 2018 20:53:41 GMT):
@dave.enyeart patch to revert couchdb changes in baseimage https://gerrit.hyperledger.org/r/#/c/23845/

rameshthoomu (Thu, 28 Jun 2018 20:53:41 GMT):
@dave.enyeart patch to revert couchdb and nodejs version changes in baseimage https://gerrit.hyperledger.org/r/#/c/23845/

dave.enyeart (Thu, 28 Jun 2018 22:11:38 GMT):
@rameshthoomu +2

dave.enyeart (Thu, 28 Jun 2018 22:11:50 GMT):
One of the last must-fix defects: https://gerrit.hyperledger.org/r/#/c/23785/

dave.enyeart (Thu, 28 Jun 2018 22:11:50 GMT):
One of the last must-fix defects needs a second +2: https://gerrit.hyperledger.org/r/#/c/23785/

mastersingh24 (Fri, 29 Jun 2018 05:12:13 GMT):
@dave.enyeart - added a comment

mastersingh24 (Fri, 29 Jun 2018 05:12:50 GMT):
I'll merge ... but interested in the answer

dave.enyeart (Fri, 29 Jun 2018 05:23:45 GMT):
@mastersingh24 add my response to https://gerrit.hyperledger.org/r/#/c/23785/

dave.enyeart (Fri, 29 Jun 2018 05:23:45 GMT):
@mastersingh24 added my response to https://gerrit.hyperledger.org/r/#/c/23785/

dave.enyeart (Sat, 30 Jun 2018 13:54:42 GMT):
Clarify private data docs:

dave.enyeart (Sat, 30 Jun 2018 13:54:44 GMT):
https://gerrit.hyperledger.org/r/#/c/23911/ release-1.2 https://gerrit.hyperledger.org/r/#/c/23909/ master

dave.enyeart (Sat, 30 Jun 2018 13:54:44 GMT):
~https://gerrit.hyperledger.org/r/#/c/23911/~ release-1.2 ~https://gerrit.hyperledger.org/r/#/c/23909/~ master

dave.enyeart (Sat, 30 Jun 2018 13:55:32 GMT):
Fix release links in README: https://gerrit.hyperledger.org/r/#/c/23601/ (master) https://gerrit.hyperledger.org/r/#/c/23603/ (release-1.2)

dave.enyeart (Sat, 30 Jun 2018 13:55:32 GMT):
Fix release links in README: ~https://gerrit.hyperledger.org/r/#/c/23601/~ (master) ~https://gerrit.hyperledger.org/r/#/c/23603/~ (release-1.2)

cbf (Mon, 02 Jul 2018 12:25:38 GMT):
easy one https://gerrit.hyperledger.org/r/c/23517/

rameshthoomu (Mon, 02 Jul 2018 13:42:19 GMT):
need more +2 https://gerrit.hyperledger.org/r/#/c/23749/

sstone1 (Mon, 02 Jul 2018 14:38:47 GMT):
hopefully a small one - just moving some code around: https://gerrit.hyperledger.org/r/c/23937/

andrew-coleman (Tue, 03 Jul 2018 08:22:45 GMT):
Has joined the channel.

cbf (Tue, 03 Jul 2018 16:56:24 GMT):
need one more on this one, please https://gerrit.hyperledger.org/r/c/23981/

jyellick (Tue, 03 Jul 2018 17:48:28 GMT):
Done, will let you (@cbf) click the merge button though in case you are not ready

cbf (Tue, 03 Jul 2018 17:48:41 GMT):
thx!

cbf (Tue, 03 Jul 2018 17:50:44 GMT):
@jyellick if you wouldn't mind helping with the follow-on CR? https://gerrit.hyperledger.org/r/c/23981/

cbf (Tue, 03 Jul 2018 17:50:44 GMT):
@jyellick if you wouldn't mind helping with the follow-on CR? https://gerrit.hyperledger.org/r/c/24003/

jyellick (Tue, 03 Jul 2018 17:51:28 GMT):
Done

cbf (Tue, 03 Jul 2018 17:55:13 GMT):
thanks

jyellick (Tue, 03 Jul 2018 19:46:19 GMT):
If anyone is feeling ambitious, https://gerrit.hyperledger.org/r/c/21985/ is much easier to review than it looks: 519 lines generated mocks 356 lines of new test files -311 old test file +60/-64 of switching function pointers to interfaces to work with the new more idiomatic tests

rameshthoomu (Tue, 03 Jul 2018 21:42:11 GMT):
one more +2 https://gerrit.hyperledger.org/r/#/c/24019/ - minor change

rameshthoomu (Tue, 03 Jul 2018 21:42:11 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/24019/ - minor change

yacovm (Wed, 04 Jul 2018 09:44:17 GMT):
trivial change set https://gerrit.hyperledger.org/r/#/c/23989/ just 8 lines of production code, the rest is test

cbf (Wed, 04 Jul 2018 10:46:31 GMT):
need one more and this can be merged, and we can lift the merge freeze

cbf (Wed, 04 Jul 2018 10:46:33 GMT):
https://gerrit.hyperledger.org/r/c/23979/

cbf (Wed, 04 Jul 2018 11:08:08 GMT):
thanks

dave.enyeart (Thu, 05 Jul 2018 14:02:10 GMT):
A few cleanup things for the 1.2.0 release:

dave.enyeart (Thu, 05 Jul 2018 14:02:13 GMT):
https://gerrit.hyperledger.org/r/#/c/24085/ release-1.2 https://gerrit.hyperledger.org/r/#/c/24083/ master

dave.enyeart (Thu, 05 Jul 2018 14:02:13 GMT):
~https://gerrit.hyperledger.org/r/#/c/24085/ release-1.2~ https://gerrit.hyperledger.org/r/#/c/24083/ master

dave.enyeart (Thu, 05 Jul 2018 14:02:13 GMT):
~https://gerrit.hyperledger.org/r/#/c/24085/ release-1.2~ ~https://gerrit.hyperledger.org/r/#/c/24083/ master~

dave.enyeart (Thu, 05 Jul 2018 14:02:26 GMT):
https://gerrit.hyperledger.org/r/#/c/24087/

dave.enyeart (Thu, 05 Jul 2018 14:02:26 GMT):
https://gerrit.hyperledger.org/r/#/c/24087/ master

dave.enyeart (Thu, 05 Jul 2018 14:02:26 GMT):
~https://gerrit.hyperledger.org/r/#/c/24087/~ master

dave.enyeart (Thu, 05 Jul 2018 14:02:26 GMT):
~https://gerrit.hyperledger.org/r/#/c/24087/ master~

cbf (Thu, 05 Jul 2018 15:15:58 GMT):
https://gerrit.hyperledger.org/r/c/24059/

cbf (Fri, 06 Jul 2018 11:46:40 GMT):
https://gerrit.hyperledger.org/r/c/24059/

cbf (Fri, 06 Jul 2018 14:07:13 GMT):
ahem... the one above is an easy one... please review

yacovm (Fri, 06 Jul 2018 14:29:36 GMT):
@cbf Gari commented...

mastersingh24 (Mon, 09 Jul 2018 15:08:54 GMT):
easy one: https://gerrit.hyperledger.org/r/24225

jyellick (Mon, 09 Jul 2018 15:51:48 GMT):
There is a tall stack of changes prepping the codebase for lifecycle improvements. The bottom five are here: https://gerrit.hyperledger.org/r/c/22277/ https://gerrit.hyperledger.org/r/c/22279/ https://gerrit.hyperledger.org/r/c/22281/ https://gerrit.hyperledger.org/r/c/22283/ https://gerrit.hyperledger.org/r/c/22285/ Nothing in the series adds new function, it is all refactor, so most of it should review quite easily.

joe-alewine (Mon, 09 Jul 2018 15:55:01 GMT):
Add a "What's new in v1.2" doc: https://gerrit.hyperledger.org/r/c/24247

joe-alewine (Mon, 09 Jul 2018 15:55:01 GMT):
Adding a "What's new in v1.2" doc (to help people find new documentation and learn about new features): https://gerrit.hyperledger.org/r/c/24247

cbf (Mon, 09 Jul 2018 18:40:47 GMT):
https://gerrit.hyperledger.org/r/c/24063/

jyellick (Mon, 09 Jul 2018 18:50:18 GMT):
@cbf What's the policy here? I originally wrote the change, but you cherry-picked it. Are we both not allowed to +2? Only one of us?

pandrejko (Mon, 09 Jul 2018 20:25:19 GMT):
https://gerrit.hyperledger.org/r/#/c/24263/ Visual Vocab images in Glossary

cbf (Mon, 09 Jul 2018 21:08:31 GMT):
@jyellick for cherrypick, think we are covered... go ahead and review

joe-alewine (Mon, 09 Jul 2018 21:22:35 GMT):
Adding a line about Service Discovery to the "What's new" doc: https://gerrit.hyperledger.org/r/c/24279/

joe-alewine (Mon, 09 Jul 2018 21:22:35 GMT):
Adding a line about the Service Discovery CLI to the "What's new" doc: https://gerrit.hyperledger.org/r/c/24279/

pandrejko (Mon, 09 Jul 2018 21:54:22 GMT):
https://gerrit.hyperledger.org/r/#/c/24269/ Added video link in SideDB tutorial

cbf (Tue, 10 Jul 2018 12:42:07 GMT):
@pandrejko see comment

cbf (Tue, 10 Jul 2018 14:52:26 GMT):
https://gerrit.hyperledger.org/r/c/24063/ please

cbf (Tue, 10 Jul 2018 14:52:39 GMT):
easy one, was cherry pick of a merged commit

cbf (Tue, 10 Jul 2018 14:53:25 GMT):
another easy one https://gerrit.hyperledger.org/r/c/24069/

pandrejko (Tue, 10 Jul 2018 15:33:07 GMT):
@cbf try now: https://gerrit.hyperledger.org/r/#/c/24269/ Added video link in SideDB tutorial

pandrejko (Tue, 10 Jul 2018 15:33:07 GMT):
@cbf try now: https://gerrit.hyperledger.org/r/#/c/24269/ Added video link in SideDB tutorial Thanks for the suggestion!

baohua (Wed, 11 Jul 2018 03:15:50 GMT):
Fix linter checking: https://gerrit.hyperledger.org/r/#/c/24141/, welcome to help review, thanks!

baohua (Wed, 11 Jul 2018 05:12:24 GMT):
Fix chaincode name checking: https://gerrit.hyperledger.org/r/#/c/24281/, welcome to help review, thanks!

NoLimitHoldem (Wed, 11 Jul 2018 06:18:11 GMT):
Has joined the channel.

jyellick (Wed, 11 Jul 2018 14:52:36 GMT):
https://chat.hyperledger.org/channel/fabric-pr-review?msg=o8C3ieJZ5WumSaYry

jyellick (Wed, 11 Jul 2018 14:52:39 GMT):
Not to spam, but, it's a tall stack, so would like to start making some progress on it. ^

baohua (Thu, 12 Jul 2018 01:35:05 GMT):
one more +2 needed, thanks! https://gerrit.hyperledger.org/r/#/c/24141/

baohua (Thu, 12 Jul 2018 01:35:31 GMT):
https://gerrit.hyperledger.org/r/#/c/24307/

jyellick (Thu, 12 Jul 2018 19:16:57 GMT):
https://gerrit.hyperledger.org/r/c/24343/ ^ This one simply adds some tests, would appreciate getting this in quickly so that some changes on top of it can be rebased elsewhere

baohua (Fri, 13 Jul 2018 01:06:49 GMT):
Fix chaincode name checking: https://gerrit.hyperledger.org/r/#/c/24281/, welcome to help review, thanks!

baohua (Fri, 13 Jul 2018 01:07:19 GMT):
Fix linter checking: https://gerrit.hyperledger.org/r/#/c/24141/, welcome to help review, thanks!

baohua (Fri, 13 Jul 2018 01:07:19 GMT):
1 more +2 needed: https://gerrit.hyperledger.org/r/#/c/24141/, welcome to help review, thanks!

bestbeforetoday (Mon, 16 Jul 2018 12:11:16 GMT):
Has joined the channel.

dave.enyeart (Mon, 16 Jul 2018 13:52:38 GMT):
I'm testing the auto-transition, could you +2 this one: https://gerrit.hyperledger.org/r/#/c/24439/

dave.enyeart (Mon, 16 Jul 2018 13:52:38 GMT):
I'm testing auto-transition of Jira states, could you +2 this one: https://gerrit.hyperledger.org/r/#/c/24439/

C0rWin (Mon, 16 Jul 2018 14:04:38 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=NuHtTn6fwb8RR6bCg) @dave.enyeart shall it be merged or +2 will be enough?

sykesm (Mon, 16 Jul 2018 15:21:46 GMT):
hi, can someone take a look at https://gerrit.hyperledger.org/r/c/24349/ ? Needs a second +2 - enables all vet checks.

scottz (Tue, 17 Jul 2018 00:30:56 GMT):
Can someone re-review this tweak to fabric-samples/balance-transfer to show use of 2 endorsements @cbf @dave.enyeart ? https://gerrit.hyperledger.org/r/#/c/18285/

ashutosh_kumar (Tue, 17 Jul 2018 01:17:51 GMT):
Need some love https://gerrit.hyperledger.org/r/#/c/24465/

dave.enyeart (Tue, 17 Jul 2018 10:01:25 GMT):
Fix doc bug and also tests Jira auto-transition to Done: https://gerrit.hyperledger.org/r/#/c/24475/

jyellick (Wed, 18 Jul 2018 13:55:23 GMT):
https://gerrit.hyperledger.org/r/c/24513/ <- Easy one which fixes broken CI

jyellick (Wed, 18 Jul 2018 19:28:50 GMT):
https://gerrit.hyperledger.org/r/c/24515/ <- Another very easy one which enables more linting

dave.enyeart (Wed, 18 Jul 2018 22:28:09 GMT):
Fix doc bug and also tests Jira auto-transition to Done: https://gerrit.hyperledger.org/r/#/c/24475/ <-- Even easier

dave.enyeart (Wed, 18 Jul 2018 22:28:09 GMT):
Fix doc bug and also tests Jira auto-transition to Done: https://gerrit.hyperledger.org/r/#/c/24475/ <-- Even easier, so I'll give myself one +2... just need one more

baohua (Thu, 19 Jul 2018 01:11:32 GMT):
+1 ! @dave.enyeart

baohua (Thu, 19 Jul 2018 01:12:57 GMT):
Welcome to help review https://gerrit.hyperledger.org/r/#/c/24281/. One more +2 needed, thanks!

wlahti (Thu, 19 Jul 2018 20:18:02 GMT):
https://gerrit.hyperledger.org/r/c/24301/ - serviceability CR - update errors in protos/utils https://gerrit.hyperledger.org/r/c/24325/ - utility function to convert ChaincodeDeploymentSpec to new ChaincodeInstallPackage https://gerrit.hyperledger.org/r/c/24367/ - increase peer CLI timeout for successful unit tests to avoid flakey CI failures https://gerrit.hyperledger.org/r/c/24251/ - retrieve hash of persisted ChaincodeInstallPackage

dave.enyeart (Fri, 20 Jul 2018 01:29:12 GMT):
Fix doc bug and also tests Jira auto-transition to Done: https://gerrit.hyperledger.org/r/#/c/24475/ <-- Third times a charm...

mastersingh24 (Fri, 20 Jul 2018 12:47:53 GMT):
@dave.enyeart - done and the trigger worked

mastersingh24 (Fri, 20 Jul 2018 12:48:22 GMT):
or did you manually change it?

dave.enyeart (Fri, 20 Jul 2018 12:55:40 GMT):
@mastersingh24 I didn't change it manually... the trigger to auto-transition Jira to Done worked!

yacovm (Fri, 20 Jul 2018 12:57:26 GMT):
in 1990 people predicted flying cars by 2018 but I bet no one predicted auto-triggering for JIRA!

mastersingh24 (Fri, 20 Jul 2018 13:07:52 GMT):
:rofl:

mastersingh24 (Fri, 20 Jul 2018 13:08:23 GMT):
https://en.wikipedia.org/wiki/Flying_car

wlahti (Fri, 20 Jul 2018 20:21:34 GMT):
Eventhub CRs for release-1.0 and release-1.1 branch: additional logging: https://gerrit.hyperledger.org/r/c/23169/ and https://gerrit.hyperledger.org/r/c/23549/ add timeout to avoid problematic client connections stopping flow of events: https://gerrit.hyperledger.org/r/c/23171/ and https://gerrit.hyperledger.org/r/c/23553/ And speaking of the eventhub, this CR removes it from the peer in the master branch: https://gerrit.hyperledger.org/r/c/24593/

mastersingh24 (Fri, 20 Jul 2018 23:23:29 GMT):
The death of eventhub? Say it ain't so

mastersingh24 (Fri, 20 Jul 2018 23:23:30 GMT):
;)

mastersingh24 (Fri, 20 Jul 2018 23:24:00 GMT):
Will there be a funeral service? Where shall I send flowers?

yacovm (Sun, 22 Jul 2018 17:40:09 GMT):
Easy refactoring https://gerrit.hyperledger.org/r/#/c/24639/ change set - only `+35/-16` LOC

yacovm (Sun, 22 Jul 2018 17:40:27 GMT):
Easy refactoring change set https://gerrit.hyperledger.org/r/#/c/24639/ - only `+35/-16` LOC

yacovm (Sun, 22 Jul 2018 17:40:42 GMT):
Easy refactoring change set https://gerrit.hyperledger.org/r/#/c/24639/ - only `+35,-16` LOC

davidkhala (Mon, 23 Jul 2018 04:51:28 GMT):
@zhaochy Dear chaoyi, welcome comment on https://gerrit.hyperledger.org/r/#/c/24609/

ashutosh_kumar (Mon, 23 Jul 2018 13:56:19 GMT):
Got +2 from Gari. Need one more +2 on https://gerrit.hyperledger.org/r/#/c/24465/ . Thanks.

latitiah (Mon, 23 Jul 2018 21:13:05 GMT):
Need +2s por favor: https://gerrit.hyperledger.org/r/#/c/24597/

mastersingh24 (Tue, 24 Jul 2018 12:32:54 GMT):
No hablo espanol

davidkhala (Tue, 24 Jul 2018 14:01:46 GMT):
@zhaochy https://gerrit.hyperledger.org/r/#/c/24663/ looks good to me

rameshthoomu (Tue, 24 Jul 2018 14:59:14 GMT):
@mastersingh24 @dave.enyeart please approve this change https://gerrit.hyperledger.org/r/#/c/24427/

rameshthoomu (Tue, 24 Jul 2018 15:00:01 GMT):
new baseimage release is required to update 8.11.2 and point the same in master branch..

rameshthoomu (Tue, 24 Jul 2018 15:00:01 GMT):
new baseimage release is required to update 8.11.2 and point the same in fabric master branch..

latitiah (Tue, 24 Jul 2018 18:12:16 GMT):
@mastersingh24: this guy still needs love https://gerrit.hyperledger.org/r/#/c/24597/ (Thx @dave.enyeart!)

cbf (Tue, 24 Jul 2018 18:42:56 GMT):
https://gerrit.hyperledger.org/r/c/24067/ simple one - cherry pick

cbf (Tue, 24 Jul 2018 19:05:45 GMT):
https://gerrit.hyperledger.org/r/c/24069/

cbf (Tue, 24 Jul 2018 19:06:11 GMT):
https://gerrit.hyperledger.org/r/c/23313/

yacovm (Tue, 24 Jul 2018 19:28:04 GMT):
https://gerrit.hyperledger.org/r/#/c/24697/ easy one

grapebaba (Wed, 25 Jul 2018 08:19:07 GMT):
https://gerrit.hyperledger.org/r/#/c/24737/ @jyellick @kostas tendermint orderer protobuf definition

davidkhala (Wed, 25 Jul 2018 09:29:55 GMT):
@cbf also apply patch to release1.2 about remove eventHub https://gerrit.hyperledger.org/r/#/c/24739/

yacovm (Thu, 26 Jul 2018 10:18:33 GMT):
simple doc change https://gerrit.hyperledger.org/r/#/c/24771/

yacovm (Thu, 26 Jul 2018 10:18:33 GMT):
simple doc change https://gerrit.hyperledger.org/r/#/c/24771/ need 1 more +2

wlahti (Thu, 26 Jul 2018 16:21:24 GMT):
removes the EventHub from the peer: https://gerrit.hyperledger.org/r/c/24593/ retrieves the hash of a persisted ChaincodeInstallPackage: https://gerrit.hyperledger.org/r/c/24251 functions to convert (Signed)ChaincodeDeploymentSpecs to ChaincodeInstallPackages: https://gerrit.hyperledger.org/r/c/24325/

rameshthoomu (Thu, 26 Jul 2018 17:52:21 GMT):
https://gerrit.hyperledger.org/r/#/c/24647/ - CI pipeline change on fabric-sdk-node (master branch)

jimthematrix (Fri, 27 Jul 2018 01:16:26 GMT):
@bretharrison @Ratnakar a trivial PR for your review in fabric-samples: https://gerrit.hyperledger.org/r/#/c/24819/

jimthematrix (Fri, 27 Jul 2018 01:17:09 GMT):
(for hotfix'ing release-1.2 branch)

Ratnakar (Fri, 27 Jul 2018 01:30:55 GMT):
@jimthematrix Thanks for the CR. @bretharrison has already addressed that issue with https://gerrit.hyperledger.org/r/#/c/24583/ and that has been merged this morning. A similar change has been made on release-1.2 branch aswell https://gerrit.hyperledger.org/r/#/c/24739/ yet to be merged.

jimthematrix (Fri, 27 Jul 2018 02:36:12 GMT):
@Ratnakar @bretharrison Can I suggest that https://gerrit.hyperledger.org/r/#/c/24739/ be enhanced to change the `unstable` version strings to `1.2.x` for both fabric-client and fabric-ca-client. this way for the majority of the developers who are picking up the public `1.2.0` versions from npm, they can checkout the release-1.2 branch and be assured that it supports the versions they have

rameshthoomu (Fri, 27 Jul 2018 03:20:05 GMT):
https://gerrit.hyperledger.org/r/#/c/24765/ https://gerrit.hyperledger.org/r/#/c/24767/

rameshthoomu (Fri, 27 Jul 2018 03:20:05 GMT):
Trivial PR's - Just update the image version https://gerrit.hyperledger.org/r/#/c/24765/ https://gerrit.hyperledger.org/r/#/c/24767/

rameshthoomu (Fri, 27 Jul 2018 03:21:40 GMT):
Minor fix to archive the build artifacts.. Need one more +2 https://gerrit.hyperledger.org/r/#/c/23805/

rameshthoomu (Fri, 27 Jul 2018 03:21:40 GMT):
Minor fix to archive the build artifacts.. Need one more +2 ~https://gerrit.hyperledger.org/r/#/c/23805/~

cbf (Fri, 27 Jul 2018 14:33:13 GMT):
come on people https://gerrit.hyperledger.org/r/c/24069/ https://gerrit.hyperledger.org/r/c/24067/ I've asked multiple times for these simple reviews

cbf (Fri, 27 Jul 2018 14:33:13 GMT):
come on people ~https://gerrit.hyperledger.org/r/c/24069/~ ~https://gerrit.hyperledger.org/r/c/24067/~ I've asked multiple times for these simple reviews

cbf (Fri, 27 Jul 2018 14:33:42 GMT):
https://gerrit.hyperledger.org/r/c/24725/ another easy one

cbf (Fri, 27 Jul 2018 14:33:42 GMT):
~https://gerrit.hyperledger.org/r/c/24725/~ another easy one

cbf (Fri, 27 Jul 2018 14:56:57 GMT):
thanks

rameshthoomu (Fri, 27 Jul 2018 19:00:55 GMT):
Code for fabric-sdk-node pipeline job configuration is ready https://gerrit.hyperledger.org/r/#/c/24841/

dave.enyeart (Sun, 29 Jul 2018 01:44:11 GMT):
Need to get integration tests passing again: https://gerrit.hyperledger.org/r/#/c/24891/

yacovm (Sun, 29 Jul 2018 14:53:43 GMT):
2 easy change sets that just change protobufs : 1) Protobuf fix https://gerrit.hyperledger.org/r/#/c/24917/ 2) Prepare discovery for state based endorsement https://gerrit.hyperledger.org/r/#/c/24915/

zjubfd (Mon, 30 Jul 2018 01:57:43 GMT):
Has joined the channel.

zjubfd (Mon, 30 Jul 2018 02:01:28 GMT):
A simple chang request , Integrtion tests passed: https://gerrit.hyperledger.org/r/#/c/24887/

zjubfd (Mon, 30 Jul 2018 02:01:35 GMT):
thks

C0rWin (Mon, 30 Jul 2018 08:12:30 GMT):
more UT for private data: https://gerrit.hyperledger.org/r/#/c/23929/

C0rWin (Mon, 30 Jul 2018 08:12:30 GMT):
more UT for private data: https://gerrit.hyperledger.org/r/#/c/23929/, need last +2

rameshthoomu (Mon, 30 Jul 2018 09:05:00 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=THxby8bYaCKpQTJ4M) any takers?

dave.enyeart (Mon, 30 Jul 2018 11:08:53 GMT):
updates for couchdb image: https://gerrit.hyperledger.org/r/#/c/24427/

wlahti (Mon, 30 Jul 2018 14:52:27 GMT):
a couple of eventhub fixes that would be great to get into the release-1.0 and release-1.1 branches (these fixes were reviewed and included in 1.2): https://gerrit.hyperledger.org/r/c/23171/ https://gerrit.hyperledger.org/r/c/23549/ https://gerrit.hyperledger.org/r/c/23553/

pandrejko (Mon, 30 Jul 2018 19:29:53 GMT):
Two quick ones: https://gerrit.hyperledger.org/r/#/c/24953/ , https://gerrit.hyperledger.org/r/#/c/24949/

jyellick (Mon, 30 Jul 2018 20:37:42 GMT):
https://gerrit.hyperledger.org/r/c/24585/ https://gerrit.hyperledger.org/r/c/24251/ ^ Fairly straightforward with good test coverage, have been hanging out for quite a while

zhaochy (Tue, 31 Jul 2018 08:49:01 GMT):
updates for retrieve collections config: https://gerrit.hyperledger.org/r/#/c/24735/

zjubfd (Tue, 31 Jul 2018 10:29:36 GMT):
https://gerrit.hyperledger.org/r/#/c/24977/ https://gerrit.hyperledger.org/r/#/c/24979/

zjubfd (Tue, 31 Jul 2018 10:29:48 GMT):
Another two simple ones

mastersingh24 (Tue, 31 Jul 2018 13:17:32 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=AH8qHHK5SkY9akmGs) @jyellick couple of questions / comments

mastersingh24 (Tue, 31 Jul 2018 13:17:32 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=AH8qHHK5SkY9akmGs) @jyellick @wlahti couple of questions / comments added

jg507 (Tue, 31 Jul 2018 23:34:26 GMT):
Has joined the channel.

davidkhala (Wed, 01 Aug 2018 05:49:49 GMT):
Could any one help to merge this? https://gerrit.hyperledger.org/r/#/c/24739/

odowdaibm (Wed, 01 Aug 2018 09:45:11 GMT):
Hi -- I'd like to get https://gerrit.hyperledger.org/r/c/22595 merged please. It's an update to the network topic. Lots of folks have reviewed, but I'd like a +2. @jyellick @cbf @yacovm if you get some time. Happy to address any updates - @SjirNijssen has quite a few folks asking for the material contained within. Thanks!

jtclark (Wed, 01 Aug 2018 14:29:19 GMT):
https://gerrit.hyperledger.org/r/#/c/25009/ - plz review

wlahti (Wed, 01 Aug 2018 15:39:50 GMT):
https://gerrit.hyperledger.org/r/c/24325/ - utility functions to convert ChaincodeDeploymentSpecs and SignedChaincodeDeploymentSpecs to the new ChaincodeInstallPackage a couple of eventhub fixes that would be great to get into the release-1.0 and release-1.1 branches (these fixes were reviewed and included in 1.2): https://gerrit.hyperledger.org/r/c/23171/ https://gerrit.hyperledger.org/r/c/23549/ https://gerrit.hyperledger.org/r/c/23553/

yacovm (Thu, 02 Aug 2018 20:00:23 GMT):
https://gerrit.hyperledger.org/r/#/c/25069/ easy one - just reverting a proto change

lehors (Fri, 03 Aug 2018 14:06:37 GMT):
could someone please give that one another +2? thanks. https://gerrit.hyperledger.org/r/#/c/24839/

lehors (Fri, 03 Aug 2018 14:36:50 GMT):
thanks @mastersingh24 :-)

zmaro (Fri, 03 Aug 2018 15:24:10 GMT):
Has joined the channel.

firas.qutishat (Fri, 03 Aug 2018 17:05:17 GMT):
I can't login to gerrit

firas.qutishat (Fri, 03 Aug 2018 17:05:19 GMT):
Authentication unavailable at this time.

firas.qutishat (Fri, 03 Aug 2018 17:05:32 GMT):
anyone has same issue

rameshthoomu (Fri, 03 Aug 2018 17:41:07 GMT):
https://gerrit.hyperledger.org/r/#/c/25115/ - CI pipeline change for fabric-chaincode-evm project

rameshthoomu (Mon, 06 Aug 2018 12:28:34 GMT):
https://gerrit.hyperledger.org/r/#/c/24841/ - CI pipeline change for fabric-sdk-node project

joe-alewine (Tue, 07 Aug 2018 12:50:05 GMT):
https://gerrit.hyperledger.org/r/c/25175/ Add note about transactions failing if the chaincode container is starting to FAQ section to `release-1.2` version of the docs

rameshthoomu (Tue, 07 Aug 2018 14:46:51 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/25169/

firas.qutishat (Tue, 07 Aug 2018 16:33:40 GMT):
ready for review https://gerrit.hyperledger.org/r/c/24619/

cbf (Tue, 07 Aug 2018 20:20:35 GMT):
https://gerrit.hyperledger.org/r/c/25191/

dave.enyeart (Wed, 08 Aug 2018 10:51:45 GMT):
Need one more +2 for storing state-based endorsement as metadata in ledger:

dave.enyeart (Wed, 08 Aug 2018 10:51:49 GMT):
https://gerrit.hyperledger.org/r/#/c/21775/ https://gerrit.hyperledger.org/r/#/c/21779/ https://gerrit.hyperledger.org/r/#/c/21781/

wlahti (Wed, 08 Aug 2018 15:07:51 GMT):
still looking for +2s on a couple of eventhub fixes. would be great to get these into the release-1.0 and release-1.1 branches as soon as possible (these fixes were reviewed and included in 1.2): https://gerrit.hyperledger.org/r/c/23171/ https://gerrit.hyperledger.org/r/c/23549/ https://gerrit.hyperledger.org/r/c/23553/

rameshthoomu (Wed, 08 Aug 2018 16:07:16 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/25169/

jtclark (Thu, 09 Aug 2018 12:35:23 GMT):
https://gerrit.hyperledger.org/r/25055, https://gerrit.hyperledger.org/r/25053 - plz review

troyronda (Thu, 09 Aug 2018 12:58:25 GMT):
Needs one more +2 https://gerrit.hyperledger.org/r/c/24619/

troyronda (Thu, 09 Aug 2018 16:36:47 GMT):
([FAB-11247] Add configuration to create _global_changes)

odowdaibm (Thu, 09 Aug 2018 17:32:04 GMT):
Hi @cbf @yacov, addressed Yacov's comments and others. Would appreciate a +2 if possible. ty much. Anthony

odowdaibm (Thu, 09 Aug 2018 17:32:27 GMT):
and thanks to @yacovm for comments too

ashutosh_kumar (Fri, 10 Aug 2018 18:57:08 GMT):
Need some more love https://gerrit.hyperledger.org/r/#/c/24877/. Thanks Gari for +2

davidkhala (Sat, 11 Aug 2018 01:15:12 GMT):
https://gerrit.hyperledger.org/r/#/c/24739/ Rebase is done, please review

dave.enyeart (Mon, 13 Aug 2018 13:33:26 GMT):
For state-based endorsement, we still need another review for the ledger underpinnings: https://gerrit.hyperledger.org/r/#/c/21775/ https://gerrit.hyperledger.org/r/#/c/21779/ https://gerrit.hyperledger.org/r/#/c/21781/

rameshthoomu (Mon, 13 Aug 2018 16:19:15 GMT):
https://gerrit.hyperledger.org/r/#/c/25411/ - pipeline configuration for fabric-chaincode-node

rameshthoomu (Mon, 13 Aug 2018 16:19:21 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/25169/

rameshthoomu (Mon, 13 Aug 2018 16:20:21 GMT):
https://gerrit.hyperledger.org/r/#/c/24841/ - pipeline configuration for fabric-sdk-node

wlahti (Wed, 15 Aug 2018 15:53:44 GMT):
I'd appreciate maintainers taking a quick look at https://gerrit.hyperledger.org/r/c/25569/ which disables a flakey integration test spec.

wlahti (Wed, 15 Aug 2018 15:53:44 GMT):
~I'd appreciate maintainers taking a quick look at https://gerrit.hyperledger.org/r/c/25569/ which disables a flakey integration test spec.~:ballot_box_with_check:

wlahti (Wed, 15 Aug 2018 17:20:20 GMT):
Also https://gerrit.hyperledger.org/r/c/24957/ needs one more +2

wlahti (Wed, 15 Aug 2018 17:20:20 GMT):
Also - https://gerrit.hyperledger.org/r/c/24957/ needs one more +2 - https://gerrit.hyperledger.org/r/c/25171/ needs one more +2 (hygiene CR) And the eventhub fixes for release-1.0 and release-1.1 branches (these fixes were reviewed and included in 1.2) that are still just sitting around: https://gerrit.hyperledger.org/r/c/23171/ https://gerrit.hyperledger.org/r/c/23549/ https://gerrit.hyperledger.org/r/c/23553/

mastersingh24 (Wed, 15 Aug 2018 23:42:34 GMT):
easy one from @ashutosh_kumar which removes dead code : https://gerrit.hyperledger.org/r/24877

mastersingh24 (Wed, 15 Aug 2018 23:42:34 GMT):
easy one from @ashutosh_kumar which removes dead code : ~https://gerrit.hyperledger.org/r/24877~

adc (Thu, 16 Aug 2018 07:55:05 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/24849/ :)

rameshthoomu (Thu, 16 Aug 2018 13:10:59 GMT):
@bretharrison @davidkhala this is a long pending CR.. Could you please merge this change https://gerrit.hyperledger.org/r/#/c/24841/

rameshthoomu (Thu, 16 Aug 2018 13:11:31 GMT):
this one too (fabric-chaincode-node) https://gerrit.hyperledger.org/r/#/c/25411/

rameshthoomu (Thu, 16 Aug 2018 13:16:31 GMT):
These patches are well tested in sandbox

rameshthoomu (Thu, 16 Aug 2018 16:56:56 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/25169/

wlahti (Thu, 16 Aug 2018 18:26:06 GMT):
This series of lifecycle CRs from @jyellick is ready for review: - https://gerrit.hyperledger.org/r/c/25303 - Create new SCC for new lifecycle - https://gerrit.hyperledger.org/r/c/25541 - Add new tar gz chaincode package format - https://gerrit.hyperledger.org/r/c/25543 - Have package-provider parse fs bytes - https://gerrit.hyperledger.org/r/c/25305 - Add implementation for ChaincodeInstall - https://gerrit.hyperledger.org/r/c/25307 - Have chaincode store return hash on save - https://gerrit.hyperledger.org/r/c/25309 - Add lifecycle SCC InstallChaincode func - https://gerrit.hyperledger.org/r/c/25311 - Lifecycle SCC QueryInstalledChaincode - https://gerrit.hyperledger.org/r/c/25313 - Convert lifecycle SCC to use dispatcher - https://gerrit.hyperledger.org/r/c/25397 - Add query installed chaincodes SCC func

wlahti (Thu, 16 Aug 2018 18:26:06 GMT):
This series of lifecycle CRs from @jyellick is ready for review: - ~https://gerrit.hyperledger.org/r/c/25303 - Create new SCC for new lifecycle~ - https://gerrit.hyperledger.org/r/c/25541 - Add new tar gz chaincode package format - https://gerrit.hyperledger.org/r/c/25543 - Have package-provider parse fs bytes - https://gerrit.hyperledger.org/r/c/25305 - Add implementation for ChaincodeInstall - https://gerrit.hyperledger.org/r/c/25307 - Have chaincode store return hash on save - https://gerrit.hyperledger.org/r/c/25309 - Add lifecycle SCC InstallChaincode func - https://gerrit.hyperledger.org/r/c/25311 - Lifecycle SCC QueryInstalledChaincode - https://gerrit.hyperledger.org/r/c/25313 - Convert lifecycle SCC to use dispatcher - https://gerrit.hyperledger.org/r/c/25397 - Add query installed chaincodes SCC func

wangdong (Fri, 17 Aug 2018 13:56:33 GMT):
Has joined the channel.

pankajcheema (Fri, 17 Aug 2018 17:22:35 GMT):
Has joined the channel.

harsha (Fri, 17 Aug 2018 20:32:54 GMT):
https://gerrit.hyperledger.org/r/#/c/25637/ - increase default timeout.

davidkhala (Sat, 18 Aug 2018 14:20:03 GMT):
@aambati Anil, please review https://gerrit.hyperledger.org/r/#/c/25655/

davidkhala (Sat, 18 Aug 2018 14:56:31 GMT):
@bretharrison @andrew-coleman https://gerrit.hyperledger.org/r/#/c/25661/ verified, and let's discuss

muralisr (Sun, 19 Aug 2018 12:45:37 GMT):
@jyellick @wlahti will try to go through the above lifecycle PRs today

rameshthoomu (Mon, 20 Aug 2018 04:47:27 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/25169/

baohua (Mon, 20 Aug 2018 07:59:42 GMT):
need one more +2 https://gerrit.hyperledger.org/r/25403

baohua (Mon, 20 Aug 2018 07:59:50 GMT):
https://gerrit.hyperledger.org/r/#/c/25481/

jtclark (Mon, 20 Aug 2018 13:17:52 GMT):
https://gerrit.hyperledger.org/r/#/c/25591/ - plz review

jtclark (Mon, 20 Aug 2018 13:17:52 GMT):
https://gerrit.hyperledger.org/r/#/c/25591/ - plz review/+2

dave.enyeart (Mon, 20 Aug 2018 16:18:12 GMT):
Next step for operational metrics: https://gerrit.hyperledger.org/r/#/c/21045/

harsha (Mon, 20 Aug 2018 22:20:47 GMT):
https://gerrit.hyperledger.org/r/#/c/25735/ -- Addresses a Fabric UT.

harsha (Mon, 20 Aug 2018 22:20:47 GMT):
https://gerrit.hyperledger.org/r/#/c/25735/ -- Addresses a failing Fabric UT.

adc (Wed, 22 Aug 2018 11:13:04 GMT):
hi, please, some love to https://gerrit.hyperledger.org/r/#/c/25193/

rameshthoomu (Wed, 22 Aug 2018 20:19:30 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/25773/

nrohith (Thu, 23 Aug 2018 13:57:53 GMT):
Has joined the channel.

dave.enyeart (Thu, 23 Aug 2018 19:27:36 GMT):
For state-based endorsement, we still need another review for the ledger underpinnings: https://gerrit.hyperledger.org/r/#/c/21775/ https://gerrit.hyperledger.org/r/#/c/21779/ https://gerrit.hyperledger.org/r/#/c/21781/

JonathanLevi (Thu, 23 Aug 2018 20:44:26 GMT):
Hi, something is off with the build...

JonathanLevi (Thu, 23 Aug 2018 20:44:27 GMT):
https://gerrit.hyperledger.org/r/#/c/21775/

JonathanLevi (Thu, 23 Aug 2018 20:44:49 GMT):
It allowed @mastersingh24 to merge... but post-rebase it's failing.

JonathanLevi (Thu, 23 Aug 2018 20:45:06 GMT):
I can't tell yet whether it's the CI or the latest master.

JonathanLevi (Thu, 23 Aug 2018 20:45:46 GMT):
Merged a few things too... so if we can get some other pairs of eyes on it, it would be great.

JonathanLevi (Thu, 23 Aug 2018 20:46:03 GMT):
Trying to "reverify" post-merge too.

yacovm (Thu, 23 Aug 2018 20:49:11 GMT):
``` 20:04:09 core/ledger/kvledger/txmgmt/validator/valinternal/val_internal_test.go:127:20: not enough arguments in call to pahu.ApplyWriteSet 20:04:09 have (*rwsetutil.TxRwSet, *version.Height) 20:04:09 want (*rwsetutil.TxRwSet, *version.Height, privacyenabledstate.DB) ```

yacovm (Thu, 23 Aug 2018 20:50:55 GMT):
@dave.enyeart @manish-sethi

yacovm (Thu, 23 Aug 2018 20:50:55 GMT):
@dave.enyeart @manish-sethi :arrow_up:

yacovm (Thu, 23 Aug 2018 20:51:06 GMT):
:arrow_up:

JonathanLevi (Thu, 23 Aug 2018 20:51:25 GMT):
I think the issue is with the auto-rebase... the current trunk is broken, right?

yacovm (Thu, 23 Aug 2018 20:51:44 GMT):
ys

yacovm (Thu, 23 Aug 2018 20:51:50 GMT):
yes.

yacovm (Thu, 23 Aug 2018 20:51:57 GMT):
at least for unit tests

manish-sethi (Thu, 23 Aug 2018 21:25:44 GMT):
Submitted a quick fix here - https://gerrit.hyperledger.org/r/#/c/25841/

dave.enyeart (Thu, 23 Aug 2018 22:10:21 GMT):
merged! (I got no patience for CI today)

dave.enyeart (Fri, 24 Aug 2018 01:04:57 GMT):
https://gerrit.hyperledger.org/r/#/c/25435/ - cherry picked to release-1.2

dave.enyeart (Fri, 24 Aug 2018 01:04:57 GMT):
https://gerrit.hyperledger.org/r/#/c/25827/ - cherry picked to release-1.2

dave.enyeart (Fri, 24 Aug 2018 01:04:57 GMT):
https://gerrit.hyperledger.org/r/#/c/25827/ - cherry picked to release-1.2 ( @mastersingh24 you had reviewed the change in master previously)

dave.enyeart (Fri, 24 Aug 2018 01:04:57 GMT):
~https://gerrit.hyperledger.org/r/#/c/25827/~ - cherry picked to release-1.2 ( @mastersingh24 you had reviewed the change in master previously)

dave.enyeart (Fri, 24 Aug 2018 01:05:11 GMT):
https://gerrit.hyperledger.org/r/#/c/25435/ - master, and will also need to be cherry picked to release-1.2

dave.enyeart (Fri, 24 Aug 2018 01:05:11 GMT):
https://gerrit.hyperledger.org/r/#/c/25435/ - master, and will also need to be cherry picked to release-1.2 (related to the above)

rameshthoomu (Fri, 24 Aug 2018 17:57:06 GMT):
need one more +2 on this https://gerrit.hyperledger.org/r/#/c/25773/ to kick off 0.4.11 baseimage release CR

jtclark (Mon, 27 Aug 2018 10:52:07 GMT):
plz review: https://gerrit.hyperledger.org/r/#/c/25277/

dave.enyeart (Mon, 27 Aug 2018 14:18:45 GMT):
state-based endorsement validation CRs: https://gerrit.hyperledger.org/r/#/c/21345/ https://gerrit.hyperledger.org/r/#/c/21309/ https://gerrit.hyperledger.org/r/#/c/25275/

joe-alewine (Mon, 27 Aug 2018 18:48:46 GMT):
Add term "migration/migrate" to docs: https://gerrit.hyperledger.org/r/c/25909/ https://gerrit.hyperledger.org/r/c/25906/

zhangtailin (Tue, 28 Aug 2018 05:36:11 GMT):
Has joined the channel.

EvansChang (Tue, 28 Aug 2018 05:39:55 GMT):
Has joined the channel.

zhangtailin (Tue, 28 Aug 2018 05:41:45 GMT):
@sheehan hi,please review #FAB-11419 https://gerrit.hyperledger.org/r/#/c/25922/

Maria (Tue, 28 Aug 2018 12:23:13 GMT):
https://gerrit.hyperledger.org/r/#/c/22247/ would appreciate a review - already has two +1 :) Many thanks!

Maria (Tue, 28 Aug 2018 12:25:31 GMT):
and this one - https://gerrit.hyperledger.org/r/#/c/25139/ - one of a few left for Idemix

EdProsser (Wed, 29 Aug 2018 15:38:28 GMT):
Has joined the channel.

EdProsser (Wed, 29 Aug 2018 15:41:04 GMT):
https://gerrit.hyperledger.org/r/c/25952/ <--- Adding a section specifying the new function determination possible using node.js

pandrejko (Thu, 30 Aug 2018 21:17:33 GMT):
easy one - fixing a link: v1.1: https://gerrit.hyperledger.org/r/26005 v1.2: https://gerrit.hyperledger.org/r/#/c/26010/ master: https://gerrit.hyperledger.org/r/26007

EvansChang (Fri, 31 Aug 2018 09:17:38 GMT):
@sheehan hi,i had fixed FAB-11418, please help me review it https://gerrit.hyperledger.org/r/#/c/25801/

mastersingh24 (Fri, 31 Aug 2018 09:19:05 GMT):
@EvansChang - I think you mean https://gerrit.hyperledger.org/r/26018 ?

EvansChang (Fri, 31 Aug 2018 09:19:29 GMT):
sorry，i had copy a wrong link

EvansChang (Fri, 31 Aug 2018 09:19:53 GMT):
@sheehan hi,i had fixed FAB-11418, please help me review it https://gerrit.hyperledger.org/r/#/c/26018/

EvansChang (Fri, 31 Aug 2018 09:20:39 GMT):
@mastersingh24 yes,you are right,it's my mistake

mastersingh24 (Fri, 31 Aug 2018 09:21:01 GMT):
no problem

EvansChang (Fri, 31 Aug 2018 09:22:51 GMT):
:grin:

odowdaibm (Fri, 31 Aug 2018 17:33:59 GMT):
Hi -- I've added the first part of the new commercial paper sample in https://gerrit.hyperledger.org/r/c/25864/ I've kept it small, and would like a +2 for it please

odowdaibm (Fri, 31 Aug 2018 17:35:23 GMT):
This sample is referred to by the next docs section "Developing Apps". Again, I've kept this quite small, and I'd like a review for it please: https://gerrit.hyperledger.org/r/c/25111/

odowdaibm (Fri, 31 Aug 2018 17:36:04 GMT):
With these two merged, we have a very good start for the docs and sample referring to the programming model work for 1.3

odowdaibm (Fri, 31 Aug 2018 17:38:47 GMT):
@dave.enyeart @cbf @mastersingh24 I know you're busy, but the CR https://gerrit.hyperledger.org/r/c/25864/ should be a formality, as it just shows an example for fabric-contract-api. I understand that https://gerrit.hyperledger.org/r/c/25111/ is a little more involved, but it's really only the smartcontract.md file that contains technical detail. The other sections (scenario.md, analysis.md and developingapps.rst are descriptive in nature -- important to be right, but they have been reviewed by lots of folks). Thanks if you can approve or point at right folks!

odowdaibm (Fri, 31 Aug 2018 17:40:12 GMT):
@joe-alewine @pandrejko if you can look over the above also, that would be very kind. I'd like to focus on documenting new SDK API next week, and adding to the sample.

nrohith (Fri, 31 Aug 2018 18:20:46 GMT):
Hi, I am Rohith, a new hire at DTCC. Please let me know what you think of my first CR: https://gerrit.hyperledger.org/r/c/26011

sstone1 (Fri, 31 Aug 2018 20:24:38 GMT):
howdy - can someone review my CR to fix some unreliable e2e tests in the node chaincode support please? thanks! https://gerrit.hyperledger.org/r/c/26032/

dave.enyeart (Fri, 31 Aug 2018 21:25:34 GMT):
@davidkel @bretharrison @zhaochy ^^^^^^^^^^^

davidkhala (Sat, 01 Sep 2018 14:47:43 GMT):
@zhaochy https://gerrit.hyperledger.org/r/#/c/26035/, cherry pick, could be merged to `release-1.2`

harsha (Sun, 02 Sep 2018 18:22:54 GMT):
https://gerrit.hyperledger.org/r/#/c/26045/ - Fixes an intermittent failure, request for review

yacovm (Sun, 02 Sep 2018 19:46:32 GMT):
easy one - just 2 LOC https://gerrit.hyperledger.org/r/#/c/26042/ and its v1.2 twin: https://gerrit.hyperledger.org/r/#/c/26043/

yacovm (Sun, 02 Sep 2018 19:46:32 GMT):
easy one - just 10 LOC https://gerrit.hyperledger.org/r/#/c/26042/ and its v1.2 twin: https://gerrit.hyperledger.org/r/#/c/26043/

zhangtailin (Tue, 04 Sep 2018 02:45:53 GMT):
@sheehan hi,please help review https://gerrit.hyperledger.org/r/#/c/26060, thanks!

EvansChang (Tue, 04 Sep 2018 06:51:11 GMT):
@sheehan Hi, I had fixed FAB-11418, please help me review it https://gerrit.hyperledger.org/r/c/26063/

EvansChang (Tue, 04 Sep 2018 09:25:05 GMT):
@sheehan Hi,please help review https://gerrit.hyperledger.org/r/c/26067

yacovm (Tue, 04 Sep 2018 11:05:24 GMT):
easy one - just 10 LOC https://gerrit.hyperledger.org/r/#/c/26042/ and its v1.2 twin: https://gerrit.hyperledger.org/r/#/c/26043/ @mastersingh24 perhaps?

sheehan (Tue, 04 Sep 2018 14:06:56 GMT):
@zhangtailin @EvansChang thanks, was on vacation yesterday. Will try to look at these this afternoon

joe-alewine (Tue, 04 Sep 2018 14:09:24 GMT):
State based endorsement documentation: https://gerrit.hyperledger.org/r/c/25595/13

EvansChang (Tue, 04 Sep 2018 14:16:26 GMT):
@sheehan ok:ok_hand:

yacovm (Wed, 05 Sep 2018 06:58:26 GMT):
easy change set - https://gerrit.hyperledger.org/r/#/c/26083/ just test code

EvansChang (Wed, 05 Sep 2018 09:58:13 GMT):
@sheehan Hi,please hepl review https://gerrit.hyperledger.org/r/c/26067

rameshthoomu (Wed, 05 Sep 2018 19:36:30 GMT):
@dave.enyeart Prepare for 0.4.12 baseimage release https://gerrit.hyperledger.org/r/#/c/26115/

dave.enyeart (Wed, 05 Sep 2018 19:37:31 GMT):
+2 , over to @cbf

rameshthoomu (Wed, 05 Sep 2018 21:51:10 GMT):
pushed CR's to update baseimage version (0.4.11) https://gerrit.hyperledger.org/r/#/q/status:open+topic:0.4.11

EvansChang (Thu, 06 Sep 2018 06:01:20 GMT):
@sheehan Hi,please help review https://gerrit.hyperledger.org/r/c/26067/

harsha (Thu, 06 Sep 2018 12:19:05 GMT):
https://gerrit.hyperledger.org/r/#/c/26131/ - Kindly review.

joe-alewine (Thu, 06 Sep 2018 15:50:01 GMT):
State based endorsement documentation https://gerrit.hyperledger.org/r/c/25595/13

joe-alewine (Thu, 06 Sep 2018 15:50:12 GMT):
Would like to get this one squared away before last minute docs come in

dave.enyeart (Thu, 06 Sep 2018 18:05:10 GMT):
@joe-alewine I've added comments

joe-alewine (Thu, 06 Sep 2018 18:23:51 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=unGMYKyx8XxqXfwZv) @dave.enyeart :thumbsup:

EvansChang (Fri, 07 Sep 2018 04:01:21 GMT):
@sheehan I have updated, please help review https://gerrit.hyperledger.org/r/c/26067/

sykesm (Fri, 07 Sep 2018 13:12:08 GMT):
two very, very small ones: https://gerrit.hyperledger.org/r/c/26110/ https://gerrit.hyperledger.org/r/c/26107/

aso (Fri, 07 Sep 2018 13:38:42 GMT):
can we pls merge this (https://gerrit.hyperledger.org/r/#/c/26161/)? It's already got a +2 and it fixes possible UnitTest failures

aso (Fri, 07 Sep 2018 16:57:15 GMT):
test changes only -> https://gerrit.hyperledger.org/r/#/c/26135/

troyronda (Fri, 07 Sep 2018 18:48:39 GMT):
release-1.2 cherry pick needs another +2: https://gerrit.hyperledger.org/r/c/26071/

troyronda (Fri, 07 Sep 2018 18:48:39 GMT):
release-1.2 cherry pick (allow META-INF during validation) needs another +2: https://gerrit.hyperledger.org/r/c/26071/

EvansChang (Mon, 10 Sep 2018 07:34:54 GMT):
@sheehan Hi,please help review https://gerrit.hyperledger.org/r/c/26067

aso (Mon, 10 Sep 2018 13:10:44 GMT):
folks, pls review - test only https://gerrit.hyperledger.org/r/#/c/26135/

jtclark (Mon, 10 Sep 2018 14:27:51 GMT):
plz review - https://gerrit.hyperledger.org/r/#/c/26157/

JonathanLevi (Mon, 10 Sep 2018 15:38:02 GMT):
Good morning ladies & gents. Can somebody quickly review this? I've +2'ed. https://gerrit.hyperledger.org/r/#/c/25952/

aso (Wed, 12 Sep 2018 13:04:44 GMT):
second +2 pls - test changes only https://gerrit.hyperledger.org/r/#/c/26223/

rameshthoomu (Wed, 12 Sep 2018 16:13:01 GMT):
One more +2 https://gerrit.hyperledger.org/r/#/c/26117/

rameshthoomu (Wed, 12 Sep 2018 16:13:01 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/26117/

harsha (Thu, 13 Sep 2018 05:50:55 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/26250/

sykesm (Thu, 13 Sep 2018 12:41:06 GMT):
3 CR's - 2 tiny, 1 important https://gerrit.hyperledger.org/r/c/26262/ - update mocks https://gerrit.hyperledger.org/r/c/26263/ - remove a dead field https://gerrit.hyperledger.org/r/c/26267/ - address long standing tx rejection during cc launch

JonathanLevi (Thu, 13 Sep 2018 18:04:50 GMT):
What's going on with our modest CI ?

cbf (Thu, 13 Sep 2018 18:32:52 GMT):
easy one https://gerrit.hyperledger.org/r/c/25821/

yacovm (Thu, 13 Sep 2018 19:20:29 GMT):
Pretty straight forward one https://gerrit.hyperledger.org/r/#/c/26253/ only affects integration tests, and we need it for expediting of Raft orderer development

yacovm (Thu, 13 Sep 2018 19:20:41 GMT):
also - already +2d, missing one more ;)

cbf (Thu, 13 Sep 2018 19:29:19 GMT):
@yacovm merged

yacovm (Thu, 13 Sep 2018 19:33:59 GMT):
thanks!

sykesm (Fri, 14 Sep 2018 13:32:56 GMT):
https://gerrit.hyperledger.org/r/c/26267/ - address long standing tx rejection during launch

jtclark (Fri, 14 Sep 2018 13:41:01 GMT):
https://gerrit.hyperledger.org/r/#/c/26254/ - plz review (adding javaenv to pull_build_artifacts.sh)

latitiah (Fri, 14 Sep 2018 13:57:00 GMT):
https://gerrit.hyperledger.org/r/#/c/26226/ - fabric-ca should be using fabric 1.3 images *not* fabric 1.2 images

suryalanka (Sat, 15 Sep 2018 00:48:58 GMT):
https://gerrit.hyperledger.org/r/#/c/26168/ - upgrade from v1.2.x to v1.3.x in fabric-samples

suryalanka (Sat, 15 Sep 2018 00:48:58 GMT):
https://gerrit.hyperledger.org/r/#/c/26168/ - please review (upgrade from v1.2.x to v1.3.x in fabric-samples)

suryalanka (Sat, 15 Sep 2018 00:50:25 GMT):
@jyellick @dave.enyeart

dave.enyeart (Sat, 15 Sep 2018 05:26:47 GMT):
https://gerrit.hyperledger.org/r/#/c/26174/ - need one more +2 for history query bug fix

joe-alewine (Mon, 17 Sep 2018 19:41:01 GMT):
Adding references to Java CC in the docs: https://gerrit.hyperledger.org/r/c/26355/

jtclark (Tue, 18 Sep 2018 14:32:40 GMT):
https://gerrit.hyperledger.org/r/#/c/26254/ - Plz review (adding javaenv to pull_build_artifacts.sh)

bstasyszyn (Tue, 18 Sep 2018 17:22:00 GMT):
https://gerrit.hyperledger.org/r/#/c/26163/ - ready for review

rameshthoomu (Tue, 18 Sep 2018 18:09:45 GMT):
@dave.enyeart @cbf https://gerrit.hyperledger.org/r/#/c/26354/

joe-alewine (Tue, 18 Sep 2018 18:44:57 GMT):
"Upgrade to v1.3" doc (Jason Y has +2ed, need one more) ---> https://gerrit.hyperledger.org/r/c/26171/9

joe-alewine (Tue, 18 Sep 2018 18:45:58 GMT):
Update various docs to include references to Java CC ---> https://gerrit.hyperledger.org/r/c/26355/

rameshthoomu (Tue, 18 Sep 2018 21:29:07 GMT):
Update Baseimage in fabric-ca and fabric-sdk-node https://gerrit.hyperledger.org/r/#/q/status:open+branch:master+topic:0.4.12

yacovm (Tue, 18 Sep 2018 22:14:37 GMT):
Cherry picked from master branch to v1.2.1 https://gerrit.hyperledger.org/r/#/c/26380/

dave.enyeart (Wed, 19 Sep 2018 00:35:12 GMT):
https://gerrit.hyperledger.org/r/#/c/26375/ - update fabric-ca to use latest baseimage @cbf or @smithbk or anybody

jtclark (Wed, 19 Sep 2018 14:53:59 GMT):
https://gerrit.hyperledger.org/r/#/c/26254/ - Plz review (adding javaenv to pull_build_artifacts.sh)

harsha (Wed, 19 Sep 2018 18:07:03 GMT):
https://gerrit.hyperledger.org/r/#/c/26394/ - Simple fix, request for review.

rameshthoomu (Wed, 19 Sep 2018 19:30:09 GMT):
https://gerrit.hyperledger.org/r/#/c/26373/ - Update Makefile to pull javaenv

dave.enyeart (Wed, 19 Sep 2018 20:10:12 GMT):
https://gerrit.hyperledger.org/r/#/c/22395/ - one more +2 needed

dave.enyeart (Wed, 19 Sep 2018 20:10:12 GMT):
https://gerrit.hyperledger.org/r/#/c/22395/ - easy one, one more +2 needed

skarim (Thu, 20 Sep 2018 15:23:48 GMT):
https://gerrit.hyperledger.org/r/c/26326/ Please review fabric-ca sample CR

rameshthoomu (Fri, 21 Sep 2018 18:32:35 GMT):
https://gerrit.hyperledger.org/r/#/c/26433/ - ignore pulling s390x javaenv images

tkuhrt (Fri, 21 Sep 2018 18:41:27 GMT):
Has left the channel.

dave.enyeart (Fri, 21 Sep 2018 18:56:07 GMT):
I have +2ed for now to get things moving. @cbf we could use another. @gennadyl @C0rWin can you remind us why we don't have javaenv on s390? I think it's ok for v1.3.0, but I'd like to understand the issue and the plan.

dave.enyeart (Fri, 21 Sep 2018 18:56:07 GMT):
I have +2ed for now to get things moving, as this is blocking some nightly tests required for v1.3 delivery. @cbf @mastersingh24 @C0rWin we could use another +2 before tonight's tests. @gennadyl @C0rWin can you remind us why we don't have javaenv on s390? I think it's ok for v1.3.0, but I'd like to understand the issue and the plan.

gennadyl (Sat, 22 Sep 2018 17:37:43 GMT):
Dave, I think I opened jira for that. Ib 1.3.0 we just didn't get there

gennadyl (Sat, 22 Sep 2018 17:37:47 GMT):
:(

dave.enyeart (Sun, 23 Sep 2018 02:37:07 GMT):
https://gerrit.hyperledger.org/r/#/c/26383/ Improve block processing logging for operators

dave.enyeart (Sun, 23 Sep 2018 02:37:07 GMT):
~https://gerrit.hyperledger.org/r/#/c/26383/~ Improve block processing logging for operators

dave.enyeart (Sun, 23 Sep 2018 15:58:23 GMT):
https://gerrit.hyperledger.org/r/#/c/26113/ fix up app capabilities for V1_3

dave.enyeart (Sun, 23 Sep 2018 15:58:23 GMT):
~https://gerrit.hyperledger.org/r/#/c/26113/~ fix up app capabilities for V1_3

dave.enyeart (Sun, 23 Sep 2018 16:18:47 GMT):
https://gerrit.hyperledger.org/r/#/c/26482/ fix fabric-ca sample

dave.enyeart (Sun, 23 Sep 2018 16:18:47 GMT):
https://gerrit.hyperledger.org/r/#/c/26482/ fix fabric-ca sample @smithbk @cbf

dave.enyeart (Sun, 23 Sep 2018 16:18:47 GMT):
~https://gerrit.hyperledger.org/r/#/c/26482/~ fix fabric-ca sample @smithbk @cbf

dave.enyeart (Sun, 23 Sep 2018 16:52:24 GMT):
https://gerrit.hyperledger.org/r/#/c/26171/ upgrade doc. Thanks @wlahti for the final re-test!

dave.enyeart (Sun, 23 Sep 2018 16:52:24 GMT):
~https://gerrit.hyperledger.org/r/#/c/26171/~ upgrade doc. Thanks @wlahti for the final re-test and @joe-alewine for quick turnaround!

sureshtedla (Sun, 23 Sep 2018 17:19:27 GMT):
Has joined the channel.

skarim (Mon, 24 Sep 2018 00:25:41 GMT):
https://gerrit.hyperledger.org/r/c/26490/ easy one

dave.enyeart (Mon, 24 Sep 2018 02:28:19 GMT):
https://gerrit.hyperledger.org/r/#/c/26396/ channel event hub doc for node sdk @andrew-coleman @zhaochy

dave.enyeart (Mon, 24 Sep 2018 02:28:19 GMT):
~https://gerrit.hyperledger.org/r/#/c/26396/~ channel event hub doc for node sdk @andrew-coleman @zhaochy

dave.enyeart (Mon, 24 Sep 2018 02:56:55 GMT):
https://gerrit.hyperledger.org/r/#/c/26491/ reduce some gossip info logging

dave.enyeart (Mon, 24 Sep 2018 02:56:55 GMT):
~https://gerrit.hyperledger.org/r/#/c/26491/~ reduce some gossip info logging

joe-alewine (Mon, 24 Sep 2018 16:02:33 GMT):
Two last minute doc things: "What's New in v1.3": https://gerrit.hyperledger.org/r/c/26511/ Removing reference to old event hub in "Understanding Fabcar Network" doc: https://gerrit.hyperledger.org/r/c/26512/

jucah (Mon, 24 Sep 2018 16:43:59 GMT):
Has joined the channel.

cbf (Mon, 24 Sep 2018 17:09:26 GMT):
merged

rmorbach (Mon, 24 Sep 2018 18:39:37 GMT):
Has joined the channel.

coolsvap (Tue, 25 Sep 2018 07:46:48 GMT):
please review https://gerrit.hyperledger.org/r/#/c/26272/

JanRzepecki (Tue, 25 Sep 2018 13:18:29 GMT):
Has joined the channel.

Ryan2 (Wed, 26 Sep 2018 13:11:28 GMT):
Has joined the channel.

cbf (Wed, 26 Sep 2018 14:39:47 GMT):
merge freeze is ended per @dave.enyeart in #fabric-maintainers

dave.enyeart (Thu, 27 Sep 2018 11:52:37 GMT):
https://gerrit.hyperledger.org/r/#/c/26635/ doc fix

dave.enyeart (Thu, 27 Sep 2018 11:52:49 GMT):
https://gerrit.hyperledger.org/r/#/c/26636/ doc fix

sykesm (Fri, 28 Sep 2018 13:16:05 GMT):
Need second review for CRs in chain ending with https://gerrit.hyperledger.org/r/c/26469/23 .

rmorbach (Fri, 28 Sep 2018 14:18:37 GMT):
Has left the channel.

sykesm (Fri, 28 Sep 2018 16:31:56 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=ruB8ADPhKeKHeRGp3) Thank you, Chris, Yacov, Gari, and Jason.

rameshthoomu (Fri, 28 Sep 2018 16:44:03 GMT):
https://gerrit.hyperledger.org/r/#/c/26619/ - update stable version in fabric-samples master branch

rameshthoomu (Fri, 28 Sep 2018 20:29:05 GMT):
https://gerrit.hyperledger.org/r/#/c/26629/ -release-1.0

rameshthoomu (Fri, 28 Sep 2018 20:29:05 GMT):
https://gerrit.hyperledger.org/r/#/c/26629/ - Add docker-thirdparty make target in release-1.0

awjh (Mon, 01 Oct 2018 12:16:00 GMT):
Has joined the channel.

mbwhite (Mon, 01 Oct 2018 12:19:50 GMT):
Has joined the channel.

awjh (Mon, 01 Oct 2018 12:20:44 GMT):
I have a CR that is attempting to implement the new transaction methods in chaincode and remove the need for a developer to write their own routing in init/invoke in the Go chaincode (https://gerrit.hyperledger.org/r/#/c/25801/) (https://jira.hyperledger.org/browse/FAB-11246). Is the solution I have come to something which feels appropriate for Go? There has been a CR for the node chaincode following a similar structure gone in. Also it has failed the smoke tests with cryptogen tool not found is there anywhere I could find help on this?

dave.enyeart (Mon, 01 Oct 2018 15:49:00 GMT):
https://gerrit.hyperledger.org/r/#/c/26679/ pull javaenv in fabric bootstrap script

dave.enyeart (Mon, 01 Oct 2018 17:19:32 GMT):
https://gerrit.hyperledger.org/r/#/c/26490/ update tls error message. Also, @skarim this is minor enough I think it can be cherry picked to release-1.3 for the release.

skarim (Mon, 01 Oct 2018 17:20:30 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=K4jGof6AuuxscXtwY) @dave.enyeart ok

dave.enyeart (Mon, 01 Oct 2018 17:52:45 GMT):
https://gerrit.hyperledger.org/r/#/c/26697/ https://gerrit.hyperledger.org/r/#/c/26698/ simple bootstrap fix

jyellick (Mon, 01 Oct 2018 19:59:08 GMT):
https://gerrit.hyperledger.org/r/c/26696/ fixes broken e2e daily tests, already has one +2

sstone1 (Tue, 02 Oct 2018 10:10:06 GMT):
https://gerrit.hyperledger.org/r/#/c/26714/ fairly trivial rename of "node" chaincode samples to "javascript" instead (to allow for "typescript" samples)

rameshthoomu (Tue, 02 Oct 2018 17:17:59 GMT):
Need one more +2 here https://gerrit.hyperledger.org/r/#/c/26650/

rameshthoomu (Tue, 02 Oct 2018 17:23:47 GMT):
https://gerrit.hyperledger.org/r/#/c/26619/ - Update stable version in fabric-samples master

pandrejko (Tue, 02 Oct 2018 19:46:58 GMT):
FAQ update: https://gerrit.hyperledger.org/r/#/c/26724/ https://gerrit.hyperledger.org/r/#/c/26727/ https://gerrit.hyperledger.org/r/#/c/26728/

harsha (Wed, 03 Oct 2018 02:24:15 GMT):
https://gerrit.hyperledger.org/r/#/c/26736/ -- Addresses Few of failing couchdb UTs.

rameshthoomu (Wed, 03 Oct 2018 03:02:20 GMT):
Increase MAX_RETRIES to 10 to fix the byfn couchdb tests https://gerrit.hyperledger.org/r/#/c/26734/ https://gerrit.hyperledger.org/r/#/c/26733/

rameshthoomu (Wed, 03 Oct 2018 03:02:20 GMT):
Increase MAX_RETRIES to 10 to fix the byfn couchdb test fails with max retries errors. https://gerrit.hyperledger.org/r/#/c/26734/ https://gerrit.hyperledger.org/r/#/c/26733/

rameshthoomu (Wed, 03 Oct 2018 14:17:06 GMT):
above two changes are ready to go..

dave.enyeart (Wed, 03 Oct 2018 14:24:13 GMT):
merged

dave.enyeart (Wed, 03 Oct 2018 14:24:13 GMT):
merged. note that underlying issue will be resolved in https://jira.hyperledger.org/browse/FAB-12023 , the fixes from Harsha and Ramesh are just workarounds to avoid the intermittent failures in CI.

harsha (Sat, 06 Oct 2018 16:53:12 GMT):
https://gerrit.hyperledger.org/r/#/c/26814/ -- Makefile target updates https://gerrit.hyperledger.org/r/#/c/26815/ -- Makefile target updates ^^^ @cbf @mastersingh24 @dave.enyeart request for your review.

dave.enyeart (Mon, 08 Oct 2018 18:13:53 GMT):
@cbf @mastersingh24 what do you think about re-enabling for power architecture? I don't have a good view of the demand...

cbf (Mon, 08 Oct 2018 19:14:14 GMT):
we removed it because it was causing build errors that were not being resolved quickly and there was not much community demand

cbf (Mon, 08 Oct 2018 19:14:55 GMT):
I don't see adding it back at this point given that it has not been thoroughly tested

cbf (Mon, 08 Oct 2018 19:15:06 GMT):
@mastersingh24 what say you?

mastersingh24 (Tue, 09 Oct 2018 10:43:57 GMT):
I would not do it for 1.3 based on where we are. We can consider it for 1.4

sstone1 (Tue, 09 Oct 2018 16:32:34 GMT):
nudging for a +2 again ;-) https://gerrit.hyperledger.org/r/#/c/26714/ fairly trivial rename of "node" chaincode samples to "javascript" instead (to allow for "typescript" samples)

coolsvap (Wed, 10 Oct 2018 07:04:44 GMT):
please review https://gerrit.hyperledger.org/r/#/c/26877/ doc fix

14gracel (Wed, 10 Oct 2018 12:13:25 GMT):
Has joined the channel.

adc (Thu, 11 Oct 2018 11:25:23 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/25567/ :)

adc (Thu, 11 Oct 2018 12:15:10 GMT):
please, also to this one: https://gerrit.hyperledger.org/r/#/c/25567/

dave.enyeart (Fri, 12 Oct 2018 13:52:52 GMT):
@here could use another +2 on update to go 1.11.1 from @sykesm : https://gerrit.hyperledger.org/r/#/c/26772/

rameshthoomu (Fri, 12 Oct 2018 16:01:14 GMT):
@cbf @mastersingh24 could you please review this patch https://gerrit.hyperledger.org/r/#/c/26814/

rameshthoomu (Fri, 12 Oct 2018 16:02:22 GMT):
I see the unit and e2e tests are passing.. Unit-tests are taking 17 mins and e2e tests are taking ~38 mins which is almost equal to z builds.. So build processing time is much improved

rameshthoomu (Fri, 12 Oct 2018 18:10:53 GMT):
@dave.enyeart @sykesm https://gerrit.hyperledger.org/r/#/c/26952/

dave.enyeart (Fri, 12 Oct 2018 18:12:56 GMT):
@rameshthoomu let's rebase on top of https://gerrit.hyperledger.org/r/#/c/26949/ ( @sykesm please merge)

sykesm (Fri, 12 Oct 2018 19:30:01 GMT):
merged @dave.enyeart's CR and rebased @rameshthoomu's on top

sykesm (Fri, 12 Oct 2018 19:30:23 GMT):
Ramesh's will need another +2 and a merge

dave.enyeart (Fri, 12 Oct 2018 19:37:06 GMT):
@sykesm @rameshthoomu I +2ed https://gerrit.hyperledger.org/r/#/c/26952/ , but it failed Verify

sykesm (Fri, 12 Oct 2018 19:38:46 GMT):
``` 00:00:13.973 make: go: Command not found 00:00:13.973 make: go: Command not found 00:00:13.974 Makefile:58: *** "Architecture \"\" is unsupported". Stop. ```

dave.enyeart (Sat, 13 Oct 2018 03:04:46 GMT):
@sykesm @rameshthoomu @cbf baseimage 0.4.14 tagged, prepare for next 0.4.15 CR: https://gerrit.hyperledger.org/r/#/c/26973/

dave.enyeart (Sat, 13 Oct 2018 12:42:38 GMT):
update repos to use baseimage 0.4.14:

dave.enyeart (Sat, 13 Oct 2018 12:42:43 GMT):
https://gerrit.hyperledger.org/r/#/c/26975/ fabric https://gerrit.hyperledger.org/r/#/c/26976/ fabric-ca https://gerrit.hyperledger.org/r/#/c/26977/ fabric-sdk-node https://gerrit.hyperledger.org/r/#/c/26978/ fabric-chaincode-java

dave.enyeart (Sat, 13 Oct 2018 12:44:54 GMT):
@sykesm I realize you have another fabric CR to pick up 0.4.14: https://gerrit.hyperledger.org/r/#/c/26962/ - whichever one you can get to pass Verify is fine by me...

kostas (Sat, 13 Oct 2018 20:20:03 GMT):
Has left the channel.

jtclark (Mon, 15 Oct 2018 11:04:31 GMT):
Plz review: https://gerrit.hyperledger.org/r/#/c/26947/

adc (Mon, 15 Oct 2018 13:23:32 GMT):
Hi All, some love to https://gerrit.hyperledger.org/r/#/c/25567/, it got already a +2 and a +1 :)

mastersingh24 (Mon, 15 Oct 2018 13:53:46 GMT):
https://gerrit.hyperledger.org/r/#/c/26986/ - needed so we can get fabric-ca CRs back on track ;)

sstone1 (Mon, 15 Oct 2018 14:06:27 GMT):
https://gerrit.hyperledger.org/r/c/26714/ - has a +1, looking for a +2

mbwhite (Mon, 15 Oct 2018 14:44:36 GMT):
Likewise some CRs looking for the +2 https://gerrit.hyperledger.org/r/#/c/26929/ https://gerrit.hyperledger.org/r/#/c/26947/

sykesm (Mon, 15 Oct 2018 15:38:02 GMT):
https://gerrit.hyperledger.org/r/c/26997/2 - minor update to nwo.Network https://gerrit.hyperledger.org/r/c/26962/6 - move to go 1.11

sykesm (Mon, 15 Oct 2018 15:38:02 GMT):
~https://gerrit.hyperledger.org/r/c/26997/2 - minor update to nwo.Network~ (thanks, yacov) https://gerrit.hyperledger.org/r/c/26962/6 - move to go 1.11

sykesm (Mon, 15 Oct 2018 15:38:02 GMT):
~https://gerrit.hyperledger.org/r/c/26997/2 - minor update to nwo.Network~ (thanks, yacov) ~https://gerrit.hyperledger.org/r/c/26962/6 - move to go 1.11~ merged

mbwhite (Tue, 16 Oct 2018 17:25:26 GMT):
https://jira.hyperledger.org/browse/FAB-12482 waiting on a +2

adc (Wed, 17 Oct 2018 13:46:47 GMT):
Hi All, please some love to https://gerrit.hyperledger.org/r/#/c/26329/ thanks :)

yacovm (Wed, 17 Oct 2018 14:55:16 GMT):
@adc I reviewed... IMO all that is needed is to replace the marshal with marshalOrPanic and it's good to go

yacovm (Wed, 17 Oct 2018 14:55:34 GMT):
we should never mark transactions invalid if we fail to *marshal*.

yacovm (Wed, 17 Oct 2018 14:55:58 GMT):
if you fail to *marshal* a protobuf then something is wrong with your binary and it smells like none determinism to me

yacovm (Wed, 17 Oct 2018 19:38:04 GMT):
bug fix https://gerrit.hyperledger.org/r/#/c/27066/

rameshthoomu (Wed, 17 Oct 2018 19:52:38 GMT):
@bretharrison @andrew-coleman Could you please look into pipeline changes for fabric-sdk-node https://gerrit.hyperledger.org/r/#/q/topic:pipeline+(status:open+OR+status:open)+project:fabric-sdk-node

yacovm (Wed, 17 Oct 2018 22:30:16 GMT):
https://gerrit.hyperledger.org/r/#/c/26956/ update anchor peers in fabric samples, courtesy of @yuki-kon

yuki-kon (Wed, 17 Oct 2018 22:30:16 GMT):
Has joined the channel.

dave.enyeart (Wed, 17 Oct 2018 22:49:01 GMT):
@yacovm I liked it so much I cherry picked it to release-1.3: https://gerrit.hyperledger.org/r/#/c/27074/

dave.enyeart (Wed, 17 Oct 2018 22:49:01 GMT):
@yacovm @yuki-kon I liked it so much I cherry picked it to release-1.3: https://gerrit.hyperledger.org/r/#/c/27074/

yuki-kon (Wed, 17 Oct 2018 22:52:43 GMT):
@dave.enyeart Thank you for your quick review and cherry picking to release-1.3.

rameshthoomu (Thu, 18 Oct 2018 00:23:58 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/27065/

jtclark (Thu, 18 Oct 2018 03:41:42 GMT):
https://gerrit.hyperledger.org/r/#/c/27070/ - plz review

jtclark (Thu, 18 Oct 2018 16:48:01 GMT):
@andrew-coleman @bretharrison - https://gerrit.hyperledger.org/r/#/c/27070/ - can either of you review this patchset please?

yacovm (Thu, 18 Oct 2018 23:40:52 GMT):
easy one... just 9 lines of code https://gerrit.hyperledger.org/r/#/c/27096/

AndrewNRise (Fri, 19 Oct 2018 08:21:45 GMT):
Has joined the channel.

rameshthoomu (Fri, 19 Oct 2018 11:38:06 GMT):
minor change here https://gerrit.hyperledger.org/r/#/c/27107/

harsha (Fri, 19 Oct 2018 12:30:34 GMT):
This has been sitting for review for sometime, would request for review https://gerrit.hyperledger.org/r/#/c/26814/

dave.enyeart (Sat, 20 Oct 2018 15:15:42 GMT):
https://gerrit.hyperledger.org/r/#/c/27120/ - Fix daily tests by updating vendored packages

dave.enyeart (Sat, 20 Oct 2018 15:15:42 GMT):
~https://gerrit.hyperledger.org/r/#/c/27120/ - Fix daily tests by updating vendored packages~

dave.enyeart (Sat, 20 Oct 2018 17:11:43 GMT):
https://gerrit.hyperledger.org/r/#/c/27077/ - Private data doc improvements

dave.enyeart (Sat, 20 Oct 2018 17:11:43 GMT):
https://gerrit.hyperledger.org/r/#/c/27077/ https://gerrit.hyperledger.org/r/#/c/27125/ (release-1.3) - Private data doc improvements

dave.enyeart (Sat, 20 Oct 2018 17:11:43 GMT):
~https://gerrit.hyperledger.org/r/#/c/27077/ https://gerrit.hyperledger.org/r/#/c/27125/ (release-1.3) - Private data doc improvements~

dave.enyeart (Sun, 21 Oct 2018 14:03:16 GMT):
https://gerrit.hyperledger.org/r/#/c/27126/ cherry pick private data doc improvement to release-1.3

dave.enyeart (Sun, 21 Oct 2018 14:03:16 GMT):
https://gerrit.hyperledger.org/r/#/c/27126/ cherry pick one more private data doc improvement to release-1.3

sstone1 (Mon, 22 Oct 2018 09:10:14 GMT):
copy and pasting to the bottom since it's been sat there for a while; https://gerrit.hyperledger.org/r/c/26714/ - has a +1, looking for a +2

vivganes (Mon, 22 Oct 2018 12:13:40 GMT):
Has joined the channel.

vivganes (Mon, 22 Oct 2018 12:14:36 GMT):
Newbie here.. I have a change waiting to be merged (Has a +2 already) : https://gerrit.hyperledger.org/r/#/c/27050/

yacovm (Mon, 22 Oct 2018 12:40:27 GMT):
merged. thanks @vivganes

adc (Mon, 22 Oct 2018 13:08:05 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/26508/ :)

adc (Mon, 22 Oct 2018 13:08:05 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/26508/ It got already a +1 and a +2 :)

harsha (Wed, 24 Oct 2018 04:32:47 GMT):
https://gerrit.hyperledger.org/r/#/c/27161/ - Make UTs under cluster_test more resilient

harsha (Wed, 24 Oct 2018 04:32:47 GMT):
https://gerrit.hyperledger.org/r/#/c/27161/ - Make UTs under package cluster_test more resilient

adc (Wed, 24 Oct 2018 04:59:34 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/20529/ :)

vijay.bP (Wed, 24 Oct 2018 18:09:27 GMT):
Has joined the channel.

harsha (Thu, 25 Oct 2018 05:19:19 GMT):
https://gerrit.hyperledger.org/r/#/c/27161/ -- Has already 2 +2's can someone merge this ?

adc (Thu, 25 Oct 2018 06:05:44 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/20529/ Thanks :)

ashutosh_kumar (Thu, 25 Oct 2018 17:10:45 GMT):
small doc update https://gerrit.hyperledger.org/r/#/c/27067/. Gari has done +2. need one more +2.

ashutosh_kumar (Thu, 25 Oct 2018 17:10:45 GMT):
small doc update https://gerrit.hyperledger.org/r/#/c/27067/. Gari has done +2. need one more +2. Thanks.

rameshthoomu (Fri, 26 Oct 2018 02:57:41 GMT):
https://gerrit.hyperledger.org/r/#/c/27213/ https://gerrit.hyperledger.org/r/#/c/27212/ https://gerrit.hyperledger.org/r/#/c/27199/

rameshthoomu (Fri, 26 Oct 2018 02:57:58 GMT):
@dave.enyeart ^^

adc (Fri, 26 Oct 2018 07:54:27 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/20529/ :)

adc (Fri, 26 Oct 2018 07:54:27 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/20529/ :) It got a +2 and a +1

bretharrison (Fri, 26 Oct 2018 13:18:22 GMT):
https://gerrit.hyperledger.org/r/#/c/26446/

adc (Mon, 29 Oct 2018 08:09:46 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/26508/

adc (Tue, 30 Oct 2018 07:31:35 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/20529/

ashutosh_kumar (Tue, 30 Oct 2018 17:50:20 GMT):
@dave.enyeart I incorporated your comment in https://gerrit.hyperledger.org/r/#/c/27067/. Can you please approve and merge ? Thanks.

ashutosh_kumar (Tue, 30 Oct 2018 19:37:05 GMT):
Need one more +2 on https://gerrit.hyperledger.org/r/#/c/27067/. @mastersingh24 ? ?

jtclark (Tue, 30 Oct 2018 21:21:19 GMT):
plz review - https://gerrit.hyperledger.org/r/#/c/24933/

adc (Wed, 31 Oct 2018 08:40:39 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/20529/ :)

dave.enyeart (Wed, 31 Oct 2018 16:49:14 GMT):
Fix s390x CI: https://gerrit.hyperledger.org/r/#/c/27286/

rameshthoomu (Wed, 31 Oct 2018 20:07:12 GMT):
need one more +2 here https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric-samples+topic:pipeline-samples

rameshthoomu (Wed, 31 Oct 2018 20:07:36 GMT):
this will enable pipeline in fabric-samples (master, release-1.3 and release-1.2)

vijay.bP (Wed, 31 Oct 2018 21:46:22 GMT):
https://gerrit.hyperledger.org/r/#/c/27291/

rameshthoomu (Thu, 01 Nov 2018 22:41:21 GMT):
Need one more +2 on this https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric-samples+topic:pipeline-samples

Hangyu (Mon, 05 Nov 2018 00:21:13 GMT):
Please kindly review need one more +2 on this https://gerrit.hyperledger.org/r/#/c/27103/ Thanks!

adc (Mon, 05 Nov 2018 08:30:27 GMT):
hi all, please some love to https://gerrit.hyperledger.org/r/#/c/20533/ :)

sambhavdutt (Mon, 05 Nov 2018 16:11:56 GMT):
Can some review FABN-996 https://jira.hyperledger.org/browse/FABN-996 The e2e daily tests have been failing thrice in a row due to this.

dave.enyeart (Mon, 05 Nov 2018 17:24:25 GMT):
fix download instructions for v1.1: https://gerrit.hyperledger.org/r/#/c/27324/ (later releases already fixed)

pandrejko (Mon, 05 Nov 2018 22:09:36 GMT):
fixed broken links failing the link checker: https://gerrit.hyperledger.org/r/#/c/27347/

adc (Tue, 06 Nov 2018 10:22:06 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/20533/ It has a +2 and a +1 :)

adc (Tue, 06 Nov 2018 14:41:40 GMT):
thanks for the love to https://gerrit.hyperledger.org/r/#/c/20533/ :)

adc (Tue, 06 Nov 2018 15:19:39 GMT):
now, please, more love to https://gerrit.hyperledger.org/r/#/c/25775/, https://gerrit.hyperledger.org/r/#/c/27041/, https://gerrit.hyperledger.org/r/#/c/27094/, https://gerrit.hyperledger.org/r/#/c/27159/ They should be just merged cause, as agreed with @sykesm, we will addressed the comments posted on https://gerrit.hyperledger.org/r/#/c/27227/ with additional change-sets. Thanks for the support :)

adc (Tue, 06 Nov 2018 15:19:39 GMT):
(fabtoken-related work) now, please, more love to https://gerrit.hyperledger.org/r/#/c/25775/, https://gerrit.hyperledger.org/r/#/c/27041/, https://gerrit.hyperledger.org/r/#/c/27094/, https://gerrit.hyperledger.org/r/#/c/27159/ They should be just merged cause, as agreed with @sykesm, we will addressed the comments posted on https://gerrit.hyperledger.org/r/#/c/27227/ with additional change-sets. Thanks for the support :)

sambhavdutt (Tue, 06 Nov 2018 16:14:21 GMT):
Can someone take a look at this https://gerrit.hyperledger.org/r/#/c/27267/ , if it is required or we can ignore it

rameshthoomu (Tue, 06 Nov 2018 18:45:28 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/27379/

rameshthoomu (Wed, 07 Nov 2018 02:58:12 GMT):
@bretharrison @mbwhite Could you please review these changes.. This will avoid building fabric, ca images from release-* branches

rameshthoomu (Wed, 07 Nov 2018 02:58:15 GMT):
https://gerrit.hyperledger.org/r/#/q/topic:FAB-12735+(status:open)

adc (Wed, 07 Nov 2018 08:17:43 GMT):
(fabtoken-related work) now, please, more love to https://gerrit.hyperledger.org/r/#/c/25775/, https://gerrit.hyperledger.org/r/#/c/27041/, https://gerrit.hyperledger.org/r/#/c/27094/, https://gerrit.hyperledger.org/r/#/c/27159/ They should be just merged cause, as agreed with @sykesm, we will addressed the comments posted on https://gerrit.hyperledger.org/r/#/c/27227/ with additional change-sets. Thanks for the support :)

harsha (Wed, 07 Nov 2018 08:33:56 GMT):
https://gerrit.hyperledger.org/r/#/c/26814/10 -- Request for review

bretharrison (Wed, 07 Nov 2018 09:00:20 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=7HuM64h2f2rxnGHQG) @rameshthoomu all set

KaoutarEL (Wed, 07 Nov 2018 12:23:48 GMT):
Has joined the channel.

adc (Thu, 08 Nov 2018 06:17:37 GMT):
(fabtoken-related work) now, please, more love to https://gerrit.hyperledger.org/r/#/c/25775/, https://gerrit.hyperledger.org/r/#/c/27041/, https://gerrit.hyperledger.org/r/#/c/27094/, https://gerrit.hyperledger.org/r/#/c/27159/ They should be just merged cause, as agreed with @sykesm, we will addressed the comments posted on https://gerrit.hyperledger.org/r/#/c/27227/ with additional change-sets. Thanks for the support 🙂

adc (Thu, 08 Nov 2018 06:17:51 GMT):
some love also to this https://gerrit.hyperledger.org/r/#/c/20989/ please :)

pandrejko (Thu, 08 Nov 2018 13:22:04 GMT):
https://gerrit.hyperledger.org/r/#/c/27347/

KaoutarEL (Fri, 09 Nov 2018 14:22:36 GMT):
(fabtoken-related work) please review the following CR https://gerrit.hyperledger.org/r/#/c/26876/

skarim (Fri, 09 Nov 2018 14:52:57 GMT):
Please review, needs another set of +2s https://gerrit.hyperledger.org/r/c/18643/ https://gerrit.hyperledger.org/r/c/26603/

odowdaibm (Fri, 09 Nov 2018 15:44:34 GMT):
The tutorial doc https://gerrit.hyperledger.org/r/c/26813/ and fabric-sample tutorial https://gerrit.hyperledger.org/r/c/27168/ are also ready for +2 -- been tried out by lots of users and really important for 1.4 beta users to try out new SDK functionality. Thanks for a +2 on these please!

odowdaibm (Fri, 09 Nov 2018 15:45:21 GMT):
Also, very straightforward reviews on the following doc changes please -- thanks much: https://gerrit.hyperledger.org/r/c/26306/ and https://gerrit.hyperledger.org/r/c/26051/

odowdaibm (Fri, 09 Nov 2018 15:45:45 GMT):
really appreciate these for 1.4, given we have beta of SDK available with these features -- thanks again.

adc (Sat, 10 Nov 2018 09:04:38 GMT):
dear maintainers, please some love to: https://gerrit.hyperledger.org/r/#/c/27192/

adc (Sat, 10 Nov 2018 09:04:38 GMT):
dear maintainers, please some love to (idemix-bccsp) https://gerrit.hyperledger.org/r/#/c/27192/

adc (Sat, 10 Nov 2018 09:05:45 GMT):
and to the (fabtoken) stack starting from https://gerrit.hyperledger.org/r/#/c/25775/ @sykesm, please, may you +2 again the stack so we get it merged and we can start quickly to address your comments

adc (Sat, 10 Nov 2018 09:07:40 GMT):
let's not forget also (idemix-doc) https://gerrit.hyperledger.org/r/#/c/27417/, and (fabtoken-chaincode interoperation) https://gerrit.hyperledger.org/r/#/c/27460/ :)

adc (Sun, 11 Nov 2018 07:07:02 GMT):
dear maintainers, some love to https://gerrit.hyperledger.org/r/#/c/27417/ (idemix-docs). Thanks :)

harsha (Mon, 12 Nov 2018 07:43:40 GMT):
https://gerrit.hyperledger.org/r/#/c/26814/10 -- Makefile Target Updates.

harsha (Mon, 12 Nov 2018 07:43:40 GMT):
https://gerrit.hyperledger.org/r/#/c/26814/11 -- Makefile Target Updates.

adc (Mon, 12 Nov 2018 14:32:36 GMT):
dear maintainers, please give a look and love at https://gerrit.hyperledger.org/r/#/c/26493/, please :)

yacovm (Mon, 12 Nov 2018 14:50:33 GMT):
@adc you have a merge conflict

adc (Mon, 12 Nov 2018 14:57:28 GMT):
I know, I know, but apart that, that change-set never received a review. Would be possible to review it in the meantime that the merge conflict is resolved? :)

adc (Mon, 12 Nov 2018 15:17:13 GMT):
please, some love to https://gerrit.hyperledger.org/r/#/c/27041/ :)

lnuon (Mon, 12 Nov 2018 16:08:37 GMT):
Has joined the channel.

jtclark (Mon, 12 Nov 2018 17:10:55 GMT):
show some +2 love to https://gerrit.hyperledger.org/r/#/c/27504/

jtclark (Mon, 12 Nov 2018 17:10:55 GMT):
ready for review. please show some +2 love to https://gerrit.hyperledger.org/r/#/c/27504/

rameshthoomu (Tue, 13 Nov 2018 00:24:49 GMT):
@bretharrison @mbwhite https://gerrit.hyperledger.org/r/#/c/27475/

jtclark (Tue, 13 Nov 2018 01:53:25 GMT):
ready for review. please show some +2 love to https://gerrit.hyperledger.org/r/#/c/27511/

rameshthoomu (Tue, 13 Nov 2018 02:07:07 GMT):
@cbf need one more +2 here https://gerrit.hyperledger.org/r/#/c/27515/

sheetal-hlf (Tue, 13 Nov 2018 04:45:48 GMT):
Has joined the channel.

adc (Tue, 13 Nov 2018 07:43:05 GMT):
dear maintainers, please some love to https://gerrit.hyperledger.org/r/#/c/27041/ (fabtoken)

adc (Tue, 13 Nov 2018 13:07:19 GMT):
dear maintainers, please some love to https://gerrit.hyperledger.org/r/#/c/27461/ (bccsp keystore), please :heart_eyes:

sambhavdutt (Tue, 13 Nov 2018 14:03:13 GMT):
@rameshthoomu @dave.enyeart Can I request you to check on this CR. The changes made are working fine on my local machine. https://gerrit.hyperledger.org/r/#/c/27516/

jtclark (Tue, 13 Nov 2018 17:54:08 GMT):
Looking for +2 on https://gerrit.hyperledger.org/r/#/c/27504/ thx! :-)

jtclark (Wed, 14 Nov 2018 15:19:29 GMT):
https://gerrit.hyperledger.org/r/#/c/27511/ - plz review. thx!

kostas (Thu, 15 Nov 2018 19:37:36 GMT):
Has joined the channel.

kostas (Thu, 15 Nov 2018 19:37:54 GMT):
Does anyone have any idea what's going on here? https://gerrit.hyperledger.org/r/c/27532/#message-f7a8c9c2_75d2ce71

yacovm (Thu, 15 Nov 2018 20:59:35 GMT):
maybe the dep version in v1.2 is not the same one you run? :/

yacovm (Thu, 15 Nov 2018 20:59:41 GMT):
@kostas

yacovm (Thu, 15 Nov 2018 20:59:52 GMT):
Maybe @sykesm would know

kostas (Thu, 15 Nov 2018 21:21:01 GMT):
@yacovm: Thanks, that _might_ be it. Downgraded to 0.4.1, getting a different `Gopkg.lock`, and trying again now.

aso (Fri, 16 Nov 2018 15:40:20 GMT):
second +2 for https://gerrit.hyperledger.org/r/#/c/27461/ pls... thanks!

harsha (Mon, 19 Nov 2018 05:03:26 GMT):
https://gerrit.hyperledger.org/r/#/c/26814/ -- Have been asking for review for sometime, appreciate feedback/review.

dave.enyeart (Mon, 19 Nov 2018 19:41:21 GMT):
Commercial Paper tutorial fixes: https://gerrit.hyperledger.org/r/#/c/27628/

huxiangdong (Tue, 20 Nov 2018 00:34:52 GMT):
Has joined the channel.

sstone1 (Wed, 21 Nov 2018 15:17:48 GMT):
https://gerrit.hyperledger.org/r/c/27691/ - update to fabcar sample script

adc (Wed, 21 Nov 2018 18:25:57 GMT):
dear maintainers, please some love to https://gerrit.hyperledger.org/r/#/c/26493/ It has already a +2 :)

aso (Thu, 22 Nov 2018 16:27:48 GMT):
second review for https://gerrit.hyperledger.org/r/#/c/26892/ please...

odowdaibm (Thu, 22 Nov 2018 18:50:16 GMT):
Looking for doc review -- +2 on https://gerrit.hyperledger.org/r/c/27508/ Already +1ed by quite a few folks, so would like to merge. Ty!

EvansChang (Fri, 23 Nov 2018 02:58:22 GMT):
second +2 for https://gerrit.hyperledger.org/r/#/c/27281/ pls,thanks

odowdaibm (Mon, 26 Nov 2018 17:43:56 GMT):
Hi @aso Updated gerrit.hyperledger.org/r/c/27508/ as requested. If you could +2 that would be great -- lots of +1s already

odowdaibm (Mon, 26 Nov 2018 17:43:58 GMT):
ty

aso (Mon, 26 Nov 2018 18:12:37 GMT):
done, thx @odowdaibm

aso (Mon, 26 Nov 2018 18:26:29 GMT):
pls second review for https://gerrit.hyperledger.org/r/#/c/27252/ (fabtoken, already a +2 and +1)

jtclark (Mon, 26 Nov 2018 20:26:27 GMT):
@dave.enyeart can you re-review https://gerrit.hyperledger.org/r/#/c/27504/ ? I've got some comments added in there. thanks

JordyBaylac (Tue, 27 Nov 2018 05:06:05 GMT):
Has joined the channel.

odowdaibm (Tue, 27 Nov 2018 06:31:37 GMT):
Thanks @aso -- appreciated

aso (Tue, 27 Nov 2018 17:06:05 GMT):
pls second review for https://gerrit.hyperledger.org/r/#/c/27300/23 (fabtoken, already a +2 and +1)

aso (Tue, 27 Nov 2018 17:06:05 GMT):
pls second review for https://gerrit.hyperledger.org/r/#/c/27300/ (fabtoken, already a +2 and +1)

harsha (Wed, 28 Nov 2018 03:21:54 GMT):
https://gerrit.hyperledger.org/r/#/c/27759/ - Fix for pkcs11 UT failures.

sstone1 (Wed, 28 Nov 2018 11:00:51 GMT):
https://gerrit.hyperledger.org/r/c/27691/ - got a +1, needs some +2s - needed in order to deploy the new fabcar contract samples using the new programming model

JonathanLevi (Wed, 28 Nov 2018 11:37:44 GMT):
Merged. Looks good

sstone1 (Wed, 28 Nov 2018 11:49:48 GMT):
Thanks @dave.enyeart @JonathanLevi

KaoutarEL (Wed, 28 Nov 2018 12:41:38 GMT):
please review https://gerrit.hyperledger.org/r/#/c/27539/

mne (Wed, 28 Nov 2018 14:14:38 GMT):
Has joined the channel.

mne (Wed, 28 Nov 2018 14:15:16 GMT):
please - if somebody finds time: https://gerrit.hyperledger.org/r/#/c/27437/ (configuring MSP through a YAML file)

joe-alewine (Wed, 28 Nov 2018 14:50:32 GMT):
Small fix, adding EXTERNAL_ENDPOINT to discovery service docs: https://gerrit.hyperledger.org/r/c/27780/

joe-alewine (Wed, 28 Nov 2018 14:55:58 GMT):
Another (even smaller) fix, changing the "commitment" glossary entry to "commit": https://gerrit.hyperledger.org/r/c/27781/

rameshthoomu (Wed, 28 Nov 2018 15:05:34 GMT):
@mbwhite @bretharrison Could you please look into this https://gerrit.hyperledger.org/r/#/c/27742/

rameshthoomu (Wed, 28 Nov 2018 15:05:54 GMT):
Thanks @vijay.bP for the change

bretharrison (Wed, 28 Nov 2018 15:47:03 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=tSPwLmRBQ5nieLGPS) @rameshthoomu All set

harsha (Wed, 28 Nov 2018 17:03:24 GMT):
https://gerrit.hyperledger.org/r/#/c/27759/ - Fix for pkcs11 UT failures. -- Needs one more +2.

wlahti (Wed, 28 Nov 2018 17:12:01 GMT):
https://gerrit.hyperledger.org/r/c/27786/ - fixes the integration test failure seen for all CRs that were rebased after https://gerrit.hyperledger.org/r/c/27103/ was merged yesterday.

dave.enyeart (Wed, 28 Nov 2018 17:31:47 GMT):
The fix for the download script: https://gerrit.hyperledger.org/r/#/c/27782/

jtclark (Wed, 28 Nov 2018 18:02:14 GMT):
https://gerrit.hyperledger.org/r/#/c/27787/ - @pandrejko, @odowdaibm, @dave.enyeart plz review

sykesm (Wed, 28 Nov 2018 20:11:12 GMT):
https://gerrit.hyperledger.org/r/c/27670 - @kostas

aso (Thu, 29 Nov 2018 09:16:01 GMT):
second review for https://gerrit.hyperledger.org/r/#/c/27437/ please (MSP config changes for 1.4)

sstone1 (Thu, 29 Nov 2018 11:55:10 GMT):
can i get some +2's for https://gerrit.hyperledger.org/r/c/27801/3 please? it's just a bump to various package versions in a package.json file

sstone1 (Thu, 29 Nov 2018 11:55:10 GMT):
can i get some +2's for https://gerrit.hyperledger.org/r/c/27801/ please? it's just a bump to various package versions in a package.json file

mne (Thu, 29 Nov 2018 12:24:37 GMT):
https://gerrit.hyperledger.org/r/#/c/26232/ please - fabric sample for state based endorsement

sstone1 (Thu, 29 Nov 2018 13:22:16 GMT):
can i get some +2's for https://gerrit.hyperledger.org/r/c/27802/ please? this is the new fabcar application written in TS, using the new programming model

sstone1 (Thu, 29 Nov 2018 13:23:08 GMT):
and also https://gerrit.hyperledger.org/r/c/27693/, which adds automated CI tests for the fabcar sample - @rameshthoomu can you look at this one please?

joe-alewine (Thu, 29 Nov 2018 14:09:50 GMT):
Adding endpoint info to gossip doc: https://gerrit.hyperledger.org/r/c/27810/2

joe-alewine (Thu, 29 Nov 2018 14:09:50 GMT):
Adding endpoint info to gossip doc: https://gerrit.hyperledger.org/r/c/27810/

joe-alewine (Thu, 29 Nov 2018 14:10:15 GMT):
^^^ content taken from a Stack Overflow answer given by Gari/Yacov, so content should be pretty solid

sykesm (Thu, 29 Nov 2018 17:44:19 GMT):
https://gerrit.hyperledger.org/r/c/27648/ https://gerrit.hyperledger.org/r/c/27640/ - couch metrics

jtclark (Thu, 29 Nov 2018 18:00:46 GMT):
looking for +2 on https://gerrit.hyperledger.org/r/#/c/27787/. thanks!

odowdaibm (Fri, 30 Nov 2018 07:45:05 GMT):
Hi, could I get a +2 for https://gerrit.hyperledger.org/r/c/27638/ gateway doc please? Content built here: https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-docs-build-x86_64/1033/html/developapps/gateway.html Thanks to @SjirNijssen and @IsaacWong and @joe-alewine for reviews to get into such good shape.

IsaacWong (Fri, 30 Nov 2018 07:45:06 GMT):
Has joined the channel.

sheetal-hlf (Fri, 30 Nov 2018 08:58:28 GMT):
Please review - https://gerrit.hyperledger.org/r/#/c/27568/ (private data sample) - https://gerrit.hyperledger.org/r/#/c/27836/ (EP doc correction)

sheetal-hlf (Fri, 30 Nov 2018 08:58:28 GMT):
Please review - https://gerrit.hyperledger.org/r/#/c/27568/ (private data sample) - https://gerrit.hyperledger.org/r/#/c/27836/ (State-based EP doc correction)

pandrejko (Fri, 30 Nov 2018 14:15:09 GMT):
https://gerrit.hyperledger.org/r/#/c/27343/

wenjian (Fri, 30 Nov 2018 16:29:12 GMT):
please review https://gerrit.hyperledger.org/r/#/c/27447/ (fabtoken)

wenjian (Fri, 30 Nov 2018 17:56:20 GMT):
https://gerrit.hyperledger.org/r/#/c/27617/ - ready to submit, can someone merge it?

harsha (Sun, 02 Dec 2018 02:47:53 GMT):
https://gerrit.hyperledger.org/r/#/c/27759/ - Fix for pkcs11 UT failures. -- @dave.enyeart @aso ^^

dave.enyeart (Sun, 02 Dec 2018 13:24:08 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=Cce5DhSJScRiu9e3B) @harsha @rameshthoomu I believe you wanted to review before it was merged...

harsha (Sun, 02 Dec 2018 14:48:48 GMT):
@dave.enyeart Yes Dave, I have tested this patch on Z got my observations captured here https://hastebin.com/koyesurupu.rb

dave.enyeart (Sun, 02 Dec 2018 15:00:08 GMT):
@harsha thanks. Does it require developers to install a new dependency on their machines? @rameshthoomu I believe wanted to consider this further...

sstone1 (Mon, 03 Dec 2018 10:07:03 GMT):
can someone merge this - it's got the 2 +2s, but I can't seem to merge it myself: https://gerrit.hyperledger.org/r/c/27693/

sheetal-hlf (Mon, 03 Dec 2018 12:13:07 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=tqo7TqysWooL5ZzyM) Could anyone please review - https://gerrit.hyperledger.org/r/#/c/27568/ (private data sample) ?

sstone1 (Mon, 03 Dec 2018 14:10:58 GMT):
some more "fabcar sample uses new programming model" reviews, this time the apps: https://gerrit.hyperledger.org/r/c/27802/ (TypeScript) https://gerrit.hyperledger.org/r/c/27876/ (JavaScript) both are covered by new automated tests

manish-sethi (Mon, 03 Dec 2018 14:43:12 GMT):
This CR has already one +2. Request for one more +2 - https://gerrit.hyperledger.org/r/#/c/27798/

manish-sethi (Mon, 03 Dec 2018 14:50:02 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=yBWYjZrsqwPqMazxQ) Just to update - got Artem to review this.

wenjian (Mon, 03 Dec 2018 18:06:13 GMT):
Request for one more +2 https://gerrit.hyperledger.org/r/#/c/27588/ - alreayd got one +2

jyellick (Mon, 03 Dec 2018 21:03:24 GMT):
Would prefer for https://gerrit.hyperledger.org/r/c/27834/ @sykesm to sign off on this one, but, also would like for it to make the feature freeze.

harsha (Tue, 04 Dec 2018 08:09:54 GMT):
Thanks to @wlahti Fix handlers/validation UT failure on ppc64le - https://gerrit.hyperledger.org/r/#/c/27888/ - Request for review.

harsha (Tue, 04 Dec 2018 14:38:14 GMT):
https://gerrit.hyperledger.org/r/#/c/27913/ -- Add ppc64le to multiarch

harsha (Tue, 04 Dec 2018 14:38:14 GMT):
https://gerrit.hyperledger.org/r/#/c/27913/ -- Add ppc64le to multiarch - Request for review.

rameshthoomu (Tue, 04 Dec 2018 15:52:40 GMT):
@dave.enyeart @cbf @mastersingh24 This patch https://gerrit.hyperledger.org/r/#/c/27917/ updates the multiarch script to publish docker images with m.n(1.3 or 1.4)version. This avoids updating docker_image_tag in SDK docker-compose files to newer version.

rameshthoomu (Tue, 04 Dec 2018 15:53:05 GMT):
@bretharrison @andrew-coleman could you please review this change https://gerrit.hyperledger.org/r/#/c/27900/

skarim (Wed, 05 Dec 2018 14:53:58 GMT):
please review ca bugs: https://gerrit.hyperledger.org/r/c/27929/ https://gerrit.hyperledger.org/r/c/27811/ https://gerrit.hyperledger.org/r/c/27928/ https://gerrit.hyperledger.org/r/c/27927/

wlahti (Wed, 05 Dec 2018 15:20:55 GMT):
https://gerrit.hyperledger.org/r/c/27304/ - updates fabric-samples to use the new logging environment variable.

sykesm (Wed, 05 Dec 2018 16:13:18 GMT):
https://gerrit.hyperledger.org/r/c/27934/ reverts the softhsm change

joe-alewine (Wed, 05 Dec 2018 17:16:14 GMT):
Doc needing reviews: Private data (adding section about reconciliation and access control): https://gerrit.hyperledger.org/r/c/27968/ Gossip doc (a few additional clarifications): https://gerrit.hyperledger.org/r/c/27892/ CouchDB (adding "tips and tricks" section): https://gerrit.hyperledger.org/r/c/27939/ BYFN (cleaning up environment variables wording): https://gerrit.hyperledger.org/r/c/27889/

wenjian (Wed, 05 Dec 2018 19:21:07 GMT):
Please review below CRs for token client:

wenjian (Wed, 05 Dec 2018 19:21:20 GMT):
https://gerrit.hyperledger.org/r/#/c/27926/ and https://gerrit.hyperledger.org/r/#/c/27956/

joe-alewine (Wed, 05 Dec 2018 21:06:02 GMT):
Surya has push his changes to fabric-samples for Upgrade, which means the doc can now be reviewed: https://gerrit.hyperledger.org/r/c/27883/

joe-alewine (Wed, 05 Dec 2018 21:10:12 GMT):
Want to shill for reviews for Simon's two updates to the Fabcar doc, one for JavaScript (https://gerrit.hyperledger.org/r/c/27876/) and the other for Typescript (https://gerrit.hyperledger.org/r/c/27802/)

joe-alewine (Wed, 05 Dec 2018 21:10:12 GMT):
Want to shill for reviews for Simon's two updates to Fabcar, one for JavaScript (https://gerrit.hyperledger.org/r/c/27876/) and the other for Typescript (https://gerrit.hyperledger.org/r/c/27802/)

joe-alewine (Wed, 05 Dec 2018 21:10:23 GMT):
We have doc updates we want to do for this as well

mne (Thu, 06 Dec 2018 11:01:19 GMT):
please review https://gerrit.hyperledger.org/r/#/c/26232/ - fabric sample for state-based endorsement

harsha (Thu, 06 Dec 2018 12:49:21 GMT):
https://gerrit.hyperledger.org/r/#/c/27953/ -- Update JAVA_VERSION - fabric-baseimage https://gerrit.hyperledger.org/r/#/c/27913/ -- Add ppc64le to multiarch - fabric-baseimage https://gerrit.hyperledger.org/r/#/c/27980/ -- Add ppc64le to multiarch - fabric

harsha (Thu, 06 Dec 2018 12:49:21 GMT):
Please help review following : https://gerrit.hyperledger.org/r/#/c/27953/ -- Update JAVA_VERSION - fabric-baseimage https://gerrit.hyperledger.org/r/#/c/27913/ -- Add ppc64le to multiarch - fabric-baseimage https://gerrit.hyperledger.org/r/#/c/27980/ -- Add ppc64le to multiarch - fabric

mne (Thu, 06 Dec 2018 15:51:36 GMT):
also please review https://gerrit.hyperledger.org/r/#/c/27437/ - MSP configuration through YAML with certs in PEM format now

mbwhite (Fri, 07 Dec 2018 10:10:27 GMT):
https://jira.hyperledger.org/browse/FAB-13175 - < fabcar typescript samples updated with latest annotations

odowdaibm (Fri, 07 Dec 2018 11:01:01 GMT):
@aso @dave.enyeart @JonathanLevi if one of you could +2 this topic on gateway, it would be very helpful. https://gerrit.hyperledger.org/r/c/27638/ Got a few +1s, it's a short topic, and noting too controversial. Thanks to @joe-alewine

JonathanLevi (Fri, 07 Dec 2018 12:18:56 GMT):
We've approved and @aso just merged it, with one comment.

JonathanLevi (Fri, 07 Dec 2018 12:19:18 GMT):
Happy days ;-)

pandrejko (Fri, 07 Dec 2018 17:34:44 GMT):
https://gerrit.hyperledger.org/r/#/c/27992/ for Murali

dave.enyeart (Sat, 08 Dec 2018 19:03:19 GMT):
https://gerrit.hyperledger.org/r/#/c/28016/ simple metric help text

dave.enyeart (Sat, 08 Dec 2018 19:03:19 GMT):
~https://gerrit.hyperledger.org/r/#/c/28016/ simple metric help text~

dave.enyeart (Sat, 08 Dec 2018 19:17:17 GMT):
https://gerrit.hyperledger.org/r/#/c/28011/ simple log spec content type

dave.enyeart (Sat, 08 Dec 2018 19:17:17 GMT):
~https://gerrit.hyperledger.org/r/#/c/28011/ simple log spec content type~

dave.enyeart (Sun, 09 Dec 2018 19:49:10 GMT):
https://gerrit.hyperledger.org/r/#/c/28008/ operations doc looks ready to merge

dave.enyeart (Sun, 09 Dec 2018 19:49:10 GMT):
~https://gerrit.hyperledger.org/r/#/c/28008/ operations doc looks ready to merge~

dave.enyeart (Mon, 10 Dec 2018 00:59:17 GMT):
https://gerrit.hyperledger.org/r/#/c/27883/ upgrade doc is ready for merge

dave.enyeart (Mon, 10 Dec 2018 00:59:17 GMT):
~https://gerrit.hyperledger.org/r/#/c/27883/ upgrade doc is ready for merge~

dave.enyeart (Mon, 10 Dec 2018 00:59:47 GMT):
here's the generated RTD from the last doc build link: https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-docs-build-x86_64/1101/html/upgrading_your_network_tutorial.html

dave.enyeart (Mon, 10 Dec 2018 03:44:51 GMT):
https://gerrit.hyperledger.org/r/#/c/27998/ What's New for v1.4 doc

dave.enyeart (Mon, 10 Dec 2018 03:44:51 GMT):
~https://gerrit.hyperledger.org/r/#/c/27998/ What's New for v1.4 doc~

dave.enyeart (Mon, 10 Dec 2018 03:44:54 GMT):
https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-docs-build-x86_64/1104/html/whatsnew.html Generated doc

dave.enyeart (Mon, 10 Dec 2018 03:44:54 GMT):
https://logs.hyperledger.org/production/vex-yul-hyp-jenkins-3/fabric-docs-build-x86_64/1112/html/whatsnew.html Generated doc

sstone1 (Mon, 10 Dec 2018 13:49:24 GMT):
three new FabCar sample CRs, all been +1'ed by a peer, would appreciate some +2s please! https://gerrit.hyperledger.org/r/28035 (correct the discovery options) https://gerrit.hyperledger.org/r/28036 (remove a dependency from package.json) https://gerrit.hyperledger.org/r/28038 (remove the old JavaScript samples)

dave.enyeart (Mon, 10 Dec 2018 14:30:02 GMT):
@sstone1 +2ed the first two, -1ed the last one, see comments.

yacovm (Mon, 10 Dec 2018 14:33:06 GMT):
easy one - just removal of unused code https://gerrit.hyperledger.org/r/#/c/28040/

dave.enyeart (Mon, 10 Dec 2018 14:41:58 GMT):
@yacovm any reason that should go into v1.4 release today?

yacovm (Mon, 10 Dec 2018 15:23:23 GMT):
no reason....

yacovm (Mon, 10 Dec 2018 15:23:43 GMT):
it can also not go into any release, I don't need it, @dave.enyeart

yacovm (Mon, 10 Dec 2018 15:25:02 GMT):
it has no effect on anything

joe-alewine (Mon, 10 Dec 2018 15:38:28 GMT):
One more doc change (referencing the TLS CA) to the Operations doc: https://gerrit.hyperledger.org/r/c/28043/ Small fix, changing the link in the Upgrade doc to point to release notes: https://gerrit.hyperledger.org/r/c/28044/

joe-alewine (Mon, 10 Dec 2018 15:38:28 GMT):
One more doc change (referencing the CA) to the Operations doc: https://gerrit.hyperledger.org/r/c/28043/ Small fix, changing the link in the Upgrade doc to point to release notes: https://gerrit.hyperledger.org/r/c/28044/

aso (Mon, 10 Dec 2018 21:56:44 GMT):
second review for the release notes pls - https://gerrit.hyperledger.org/r/#/c/28050/

mne (Tue, 11 Dec 2018 13:03:03 GMT):
https://gerrit.hyperledger.org/r/#/c/27437/ please - configuring the MSP via a YAML file

KaoutarEL (Wed, 12 Dec 2018 18:16:21 GMT):
please review https://gerrit.hyperledger.org/r/#/c/27300/ and https://gerrit.hyperledger.org/r/#/c/27539/

C0rWin (Thu, 13 Dec 2018 09:15:18 GMT):
https://gerrit.hyperledger.org/r/#/c/28055/ taking care of some ut flakes

pandrejko (Thu, 13 Dec 2018 20:58:30 GMT):
Minor fix to commercial paper tutorial: https://gerrit.hyperledger.org/r/#/c/28161/ https://gerrit.hyperledger.org/r/#/c/28162/

dave.enyeart (Thu, 13 Dec 2018 22:46:22 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=YmjCBHfpEBrRkNKXY) @C0rWin You can also cherry pick to release-1.4... might as well keep the tests in sync and flake-free as long as possible

dave.enyeart (Thu, 13 Dec 2018 22:46:58 GMT):
I've done it for you on this one...

dave.enyeart (Thu, 13 Dec 2018 22:46:58 GMT):
I've done it for you: https://gerrit.hyperledger.org/r/#/c/28169/

dave.enyeart (Fri, 14 Dec 2018 03:26:19 GMT):
fix to BYFN manual steps:

dave.enyeart (Fri, 14 Dec 2018 03:26:26 GMT):
https://gerrit.hyperledger.org/r/#/c/28167/ master

dave.enyeart (Fri, 14 Dec 2018 03:26:36 GMT):
https://gerrit.hyperledger.org/r/#/c/28174/ release-1.4

C0rWin (Fri, 14 Dec 2018 10:33:49 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=fCXJ2nWiW5yamfGMR) @dave.enyeart do we need also to backport for 1.3 as well?

knagware9 (Fri, 14 Dec 2018 11:20:49 GMT):
Commercial paper tutorial doc and sample code is not in sync, https://hyperledger-fabric.readthedocs.io/en/release-1.4/developapps/application.html

knagware9 (Fri, 14 Dec 2018 11:21:50 GMT):
Towards the top of application.js, you’ll see two Fabric classes are brought into scope , application.js file not available

pandrejko (Fri, 14 Dec 2018 12:25:50 GMT):
https://gerrit.hyperledger.org/r/#/c/28167/ https://gerrit.hyperledger.org/r/#/c/28164/

dave.enyeart (Fri, 14 Dec 2018 12:51:59 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=ZpLBHg6AvJnzEmLbe) @C0rWin If it is a simple conflict-free Cherry Pick from gerrit UI, makes sense to backport to release-1.3. If there is more effort involved, don't worry about it.

dave.enyeart (Fri, 14 Dec 2018 12:52:24 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=R45YBkdFdasfCfe9i) @knagware9 Thanks, this problem is being tracked in https://jira.hyperledger.org/browse/FAB-13271

knagware9 (Fri, 14 Dec 2018 14:32:03 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=Mu9KRf2btgfPtsixZ) @dave.enyeart Actually I also raised one JIRA for this

rameshthoomu (Fri, 14 Dec 2018 14:43:52 GMT):
@mbwhite @bretharrison could you please review this change https://gerrit.hyperledger.org/r/#/c/28131/

aso (Fri, 14 Dec 2018 14:44:00 GMT):
second +2 for https://gerrit.hyperledger.org/r/#/c/28174/ pls

dave.enyeart (Fri, 14 Dec 2018 15:13:53 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=06705ec8-b8fa-4c35-919c-9827b9a351e5) @knagware9 Thank you, let's keep all the comments in https://jira.hyperledger.org/browse/FAB-13271 , I've marked the other as a duplicate.

wenjian (Fri, 14 Dec 2018 17:20:22 GMT):
Can you code review https://gerrit.hyperledger.org/r/#/c/28178/ and https://gerrit.hyperledger.org/r/#/c/28180/?

wenjian (Fri, 14 Dec 2018 17:20:25 GMT):
^^ for commerical paper tutorial and sample code

kostas (Sat, 15 Dec 2018 22:08:37 GMT):
Has left the channel.

rameshthoomu (Mon, 17 Dec 2018 15:48:22 GMT):
@mbwhite @bretharrison Could you please check this change https://gerrit.hyperledger.org/r/#/c/28219/

rameshthoomu (Mon, 17 Dec 2018 15:48:22 GMT):
@mbwhite @bretharrison Could you please check this change ~https://gerrit.hyperledger.org/r/#/c/28219/~

rameshthoomu (Mon, 17 Dec 2018 15:57:53 GMT):
This is pull the latest build artifacts from nexus repo https://gerrit.hyperledger.org/r/#/c/28210/

rameshthoomu (Mon, 17 Dec 2018 19:18:32 GMT):
@mbwhite minor change here https://jira.hyperledger.org/browse/FAB-13323

rameshthoomu (Mon, 17 Dec 2018 19:18:32 GMT):
@mbwhite minor change here https://gerrit.hyperledger.org/r/#/c/28224/

odowdaibm (Mon, 17 Dec 2018 19:20:46 GMT):
Hi @aso @JonathanLevi @dave.enyeart If you get a moment, can you +2 https://gerrit.hyperledger.org/r/c/27728/ It's been reviewed by quite a few folks, and is now in good shape. Thanks to @andrew-coleman @SjirNijssen @IsaacWong for reviews - much appreciated.

rameshthoomu (Mon, 17 Dec 2018 19:30:28 GMT):
@bretharrison https://gerrit.hyperledger.org/r/#/c/28227/

sambhavdutt (Mon, 17 Dec 2018 21:02:47 GMT):
@dave.enyeart @C0rWin @rameshthoomu https://gerrit.hyperledger.org/r/#/c/28206/ Can you take a look when you are free

rameshthoomu (Mon, 17 Dec 2018 21:43:21 GMT):
@dave.enyeart https://gerrit.hyperledger.org/r/#/c/27902/

odowdaibm (Tue, 18 Dec 2018 07:47:57 GMT):
Hi @aso Sorry to nag, I'm backing up a little with another CR, so if you could manage to get a look that would be great -- as I say, it's not too contentious. Thanks much

odowdaibm (Tue, 18 Dec 2018 07:57:14 GMT):
Hi @manish-sethi @dave.enyeart I've pushed CR for https://gerrit.hyperledger.org/r/c/28217/ Run through it a few times to check all links. Hopefully you're able to provide comments and +2 -- I've got some additions to contract namespace topic that need this in first. Thanks again, Anthony

aso (Tue, 18 Dec 2018 10:06:21 GMT):
Hi @odowdaibm! re. https://gerrit.hyperledger.org/r/#/c/27728/ a couple of easy comments and then I'll +2 right away. thanks!

aso (Tue, 18 Dec 2018 10:09:13 GMT):
ah, though I just realised that you'd like to address comments in the next CR to avoid rebasing yet again - in that case I can +2 right away, and you can address comments at the top of your change stack

aso (Tue, 18 Dec 2018 15:41:25 GMT):
should we cherry-pick https://gerrit.hyperledger.org/r/#/c/27728/ to 1.4?

dave.enyeart (Tue, 18 Dec 2018 16:25:14 GMT):
@aso yes we should cherry pick all doc CRs to release-1.4 once they are reviewed in master

dave.enyeart (Tue, 18 Dec 2018 16:25:52 GMT):
I've just +2ed this one in master

dave.enyeart (Tue, 18 Dec 2018 16:26:42 GMT):
cant cherry pick due to merge conflict... ideally we keep master and release-1.4 in sync for now

dave.enyeart (Tue, 18 Dec 2018 16:26:42 GMT):
cant cherry pick due to merge conflict... ideally we keep master and release-1.4 doc in sync for now

dave.enyeart (Tue, 18 Dec 2018 16:30:35 GMT):
@aso @odowdaibm we need to cherry pick the other connection profile topic first... i've just done that to get things in sync again: https://gerrit.hyperledger.org/r/#/c/28252/

aso (Tue, 18 Dec 2018 18:12:56 GMT):
@dave.enyeart , @odowdaibm : I've cherry picked it and resolved conflicts

aso (Tue, 18 Dec 2018 18:13:01 GMT):
https://gerrit.hyperledger.org/r/28254

aso (Tue, 18 Dec 2018 18:13:52 GMT):
@odowdaibm : pls confirm that the cherry-pick was successful

odowdaibm (Tue, 18 Dec 2018 19:30:36 GMT):
@aso will do

odowdaibm (Tue, 18 Dec 2018 19:37:55 GMT):
@aso, @dave.enyeart confirmed in Master it looks great. Thanks again guys

mne (Wed, 19 Dec 2018 10:11:50 GMT):
related to the commercial paper sample: https://gerrit.hyperledger.org/r/#/c/28176/ extends the docs wrt trust relationships / endorsement policies at a conceptual level

mbwhite (Wed, 19 Dec 2018 15:46:32 GMT):
https://gerrit.hyperledger.org/r/#/c/28294/ Is an update to the x509 library for the node chaincode

sambhavdutt (Mon, 31 Dec 2018 13:41:06 GMT):
Can I request for this CR to be approved, https://gerrit.hyperledger.org/r/#/c/28368/ I have made some changes in jenkinsfile and script to get the required images and run the BYFN, Fabcar tests, I got a +1 on this

rameshthoomu (Wed, 02 Jan 2019 20:06:57 GMT):
Need one more +2 on this change https://gerrit.hyperledger.org/r/#/c/28368/

baohua (Thu, 03 Jan 2019 02:52:49 GMT):
https://gerrit.hyperledger.org/r/#/c/28453/

baohua (Thu, 03 Jan 2019 02:52:49 GMT):
Expose more peer keep-alive options: https://gerrit.hyperledger.org/r/#/c/28453/

rameshthoomu (Thu, 03 Jan 2019 14:39:16 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=mDnYXMBzZTYH724iY) need one more +2 on this

rameshthoomu (Thu, 03 Jan 2019 20:40:12 GMT):
Need one more +2 on this https://gerrit.hyperledger.org/r/#/c/28370/ - changes to CI pipeline scripts

rameshthoomu (Thu, 03 Jan 2019 20:40:12 GMT):
Need one more +2 on this https://gerrit.hyperledger.org/r/#/c/28370/ https://gerrit.hyperledger.org/r/#/c/28372/ - changes to CI pipeline scripts https://gerrit.hyperledger.org/r/#/c/28206/ - pull latest binaries from nexus

rameshthoomu (Thu, 03 Jan 2019 20:40:12 GMT):
Need one more +2 on these: https://gerrit.hyperledger.org/r/#/c/28368/ - CI should use patchset dependencies (master) https://gerrit.hyperledger.org/r/#/c/28370/ - CI should use patchset dependencies (release-1.3) https://gerrit.hyperledger.org/r/#/c/28372/ - CI should use patchset dependencies (release-1.2) https://gerrit.hyperledger.org/r/#/c/28206/ - pull latest binaries from nexus (master)

rameshthoomu (Fri, 04 Jan 2019 16:29:33 GMT):
@chrispoole Could you please review this change https://gerrit.hyperledger.org/r/#/c/28381/

chrispoole (Fri, 04 Jan 2019 16:29:33 GMT):
Has joined the channel.

rameshthoomu (Fri, 04 Jan 2019 16:30:30 GMT):
@nfrunza Pipeline changes for Blockchain Explorer project https://gerrit.hyperledger.org/r/#/c/28364/

nfrunza (Fri, 04 Jan 2019 16:30:30 GMT):
Has joined the channel.

Ratnakar (Fri, 04 Jan 2019 19:12:55 GMT):
https://gerrit.hyperledger.org/r/#/c/28469/ Part of testing, add couple of functions (getPut and getPutPrivate) which provides the capability to perform a common usecase of read/write on public/private dbs

Ratnakar (Fri, 04 Jan 2019 19:12:55 GMT):
https://gerrit.hyperledger.org/r/#/c/28469/ Part of testing, added couple of functions (getPut and getPutPrivate) which provides the capability to perform a common usecase of read/write on public/private dbs

Ratnakar (Fri, 04 Jan 2019 19:12:55 GMT):
https://gerrit.hyperledger.org/r/#/c/28469/ Part of testing, added couple of functions (*getPut* and *getPutPrivate*) which provides the capability to perform a common usecase of read/write on public/private dbs

Ratnakar (Fri, 04 Jan 2019 19:12:55 GMT):
https://gerrit.hyperledger.org/r/#/c/28469/ Part of testing, added couple of functions ( *getPut* and *getPutPrivate*) which provides the capability to perform a common usecase of read/write on public/private dbs

dave.enyeart (Fri, 04 Jan 2019 19:18:10 GMT):
@Ratnakar +2ed. I assume you also want to cherry pick to release-1.4

dave.enyeart (Fri, 04 Jan 2019 19:18:10 GMT):
@Ratnakar +2ed. I assume you also want to cherry pick to release-1.4 (you can do that in gerrit UI itself)

Ratnakar (Fri, 04 Jan 2019 19:19:09 GMT):
Thanks @dave.enyeart. Sure I shall cherry pick to release-1.4 aswell

Ratnakar (Fri, 04 Jan 2019 19:20:03 GMT):
here is the link for release-1.4 branch https://gerrit.hyperledger.org/r/#/c/28489/

Ratnakar (Fri, 04 Jan 2019 19:20:03 GMT):
here is the Gerrit link for release-1.4 branch https://gerrit.hyperledger.org/r/#/c/28489/

baohua (Mon, 07 Jan 2019 02:25:58 GMT):
Need one more +2, please help review https://gerrit.hyperledger.org/r/#/c/28453/, thanks!

mne (Mon, 07 Jan 2019 08:04:21 GMT):
https://gerrit.hyperledger.org/r/#/c/28176/ extends the docs for the commercial paper sample wrt trust relationships / endorsement policies

mne (Mon, 07 Jan 2019 08:04:58 GMT):
https://gerrit.hyperledger.org/r/#/c/28458/ demonstrates how to use service discovery together with state-based endorsement in the interest-rate-swap sample

firas.qutishat (Mon, 07 Jan 2019 18:59:03 GMT):
please help review https://gerrit.hyperledger.org/r/#/c/28532/

firas.qutishat (Mon, 07 Jan 2019 18:59:09 GMT):
small change

firas.qutishat (Mon, 07 Jan 2019 19:00:32 GMT):
https://gerrit.hyperledger.org/r/#/c/28534/

sykesm (Tue, 08 Jan 2019 21:41:41 GMT):
If anyone has cycles, would be great to have someone review https://gerrit.hyperledger.org/r/c/28191/

baohua (Wed, 09 Jan 2019 01:37:59 GMT):
Welcome to help review https://gerrit.hyperledger.org/r/#/c/28453/, already got an +2, thanks!

baohua (Wed, 09 Jan 2019 01:38:59 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=NRpFPmiPZFPKYkkTh) @sykesm +1!

firas.qutishat (Thu, 10 Jan 2019 19:10:20 GMT):
please review https://gerrit.hyperledger.org/r/#/c/28532/

odowdaibm (Thu, 10 Jan 2019 20:06:56 GMT):
Sorry to ask, as you've both been so buys recently, but any chance of a +2 for https://gerrit.hyperledger.org/r/c/28247/ @aso @dave.enyeart ? Lots of +1s as support, but very happy to include comments/feedback. Thanks to @SjirNijssen @gormand @IsaacWong @mgk @Yogendrasri @carl for input and reviews.

carl (Thu, 10 Jan 2019 20:06:57 GMT):
Has joined the channel.

Yogendrasri (Thu, 10 Jan 2019 20:06:57 GMT):
Has joined the channel.

pandrejko (Thu, 10 Jan 2019 20:10:31 GMT):
https://gerrit.hyperledger.org/r/#/c/28531/

pandrejko (Thu, 10 Jan 2019 20:10:31 GMT):
https://gerrit.hyperledger.org/r/#/c/28531/ << Once this is merged I will create similar updates for the other branches

mne (Fri, 11 Jan 2019 12:25:47 GMT):
https://gerrit.hyperledger.org/r/#/c/28653/ - bugfix for FAB-13450, FAB-13223 and FAB-13593

mne (Fri, 11 Jan 2019 12:25:47 GMT):
https://gerrit.hyperledger.org/r/#/c/28653/ please - bugfix for FAB-13450, FAB-13223 and FAB-13593

dave.enyeart (Fri, 11 Jan 2019 13:26:16 GMT):
@mne +2ed. Also please cherry pick test improvements to release-1.4.

davidkel (Fri, 11 Jan 2019 14:40:42 GMT):
Has left the channel.

awjh (Mon, 14 Jan 2019 11:31:29 GMT):
Hey, I've been working on [FAB-12430](https://jira.hyperledger.org/browse/FAB-12430) @mbwhite will review the changes for this in fabric-chaincode-node could someone here take a look at the changes in fabric (https://gerrit.hyperledger.org/r/#/c/28694/)

pandrejko (Mon, 14 Jan 2019 14:03:16 GMT):
https://gerrit.hyperledger.org/r/#/c/28531/

rameshthoomu (Mon, 14 Jan 2019 16:26:50 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/28571/

awjh (Tue, 15 Jan 2019 13:07:38 GMT):
https://gerrit.hyperledger.org/r/#/c/28694 <- could I get a review on this please?

mne (Tue, 15 Jan 2019 15:32:21 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=5GQdmBATpxCxgbL6Y) @dave.enyeart @dave.enyeart done - @aso also +2ed, wanna re-add yours? :)

mne (Tue, 15 Jan 2019 15:32:21 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=5GQdmBATpxCxgbL6Y) @dave.enyeart done - @aso also +2ed, wanna re-add yours? :)

rameshthoomu (Tue, 15 Jan 2019 15:56:55 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=y3WuSY9jwF7oFgHGk) this is getting old now.. one more +2 pls

jyellick (Tue, 15 Jan 2019 17:50:42 GMT):
@rameshthoomu Knowing very little about our Jenkins infrastructure, I'm reluctant to +2 (not because I doubt that your patch is good, just because I try never to +2 something I don't understand). Can you give a quick summary of how we're confident that this change is positive/valid?

rameshthoomu (Tue, 15 Jan 2019 17:52:25 GMT):
@jyellick as this is on release branches, this change is to pull docker images from dockerhub instead of nexus..

jyellick (Tue, 15 Jan 2019 18:17:23 GMT):
Done

awjh (Wed, 16 Jan 2019 10:03:42 GMT):
https://gerrit.hyperledger.org/r/#/c/28694 @dave.enyeart who would be a good person to review this?

aso (Wed, 16 Jan 2019 14:42:03 GMT):
second +2 for https://gerrit.hyperledger.org/r/#/c/28247/ pls - a+2 and lots of +1's already

dave.enyeart (Thu, 17 Jan 2019 00:43:45 GMT):
@aso +2ed and merged, also cherry picked to release-1.4, one final +2 please: https://gerrit.hyperledger.org/r/#/c/28772/

gaijinviki (Thu, 17 Jan 2019 05:01:22 GMT):
Has joined the channel.

aso (Thu, 17 Jan 2019 06:40:23 GMT):
thx Dave

awjh (Thu, 17 Jan 2019 13:03:37 GMT):
Any chance someone could review this? https://gerrit.hyperledger.org/r/#/c/28694

dave.enyeart (Thu, 17 Jan 2019 13:16:43 GMT):
@awjh @sstone1 @mbwhite @odowdaibm I think the reason you are having trouble getting a review is that most of the maintainers do not understand the programming model and node.js chaincode plans for v2.0. nodeenv, inversion of control, and other enhancements. I think a design review / playback on the overall plans would help get everybody on the same page.

sstone1 (Thu, 17 Jan 2019 13:22:16 GMT):
@dave.enyeart okay, we've already got plans to set up a review for some of the other items so we'll add IoC to the agenda (@mbwhite @andrew-coleman)

sstone1 (Thu, 17 Jan 2019 13:22:40 GMT):
nodeenv wasn't us - that was done with the alpine images - i assume there was a design review / playback of that? ;-)

dave.enyeart (Thu, 17 Jan 2019 13:25:12 GMT):
nope... you're right they should have gotten a design review, I think the nodeenv aspect would be more important than alpine to cover

dave.enyeart (Thu, 17 Jan 2019 13:26:34 GMT):
and nodeenv seems to make sense to cover along with the other node.js chaincode updates

mastersingh24 (Thu, 17 Jan 2019 18:53:53 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=9TpK9Di3nJLq7jyNm) @dave.enyeart My bad ... except most people don't even know how ccenv or any of that works anyway. ;)

pandrejko (Fri, 18 Jan 2019 20:49:20 GMT):
Formatting change to the Fabric README requested by @rameshthoomu The CR for release-1.2 has already been merged. This is the change for all the other branches to link to the correct branch of the docs: release-1.0: https://gerrit.hyperledger.org/r/28823 release-1.1: https://gerrit.hyperledger.org/r/28822 release-1.3: https://gerrit.hyperledger.org/r/28824 release-1.4: https://gerrit.hyperledger.org/r/28820 master: https://gerrit.hyperledger.org/r/28825

kostas (Fri, 18 Jan 2019 20:57:03 GMT):
Has joined the channel.

kostas (Fri, 18 Jan 2019 20:58:51 GMT):
There's a CR stack starting from this one https://gerrit.hyperledger.org/r/c/28428/ that we'd like to get in ASAP. Parts of it might be a too domain-specific, but I hope that in general it's not too hard to follow along.

kostas (Fri, 18 Jan 2019 20:58:51 GMT):
There's a CR stack starting from this one https://gerrit.hyperledger.org/r/c/28428/ that we'd like to get in ASAP. Parts of it might be a bit too domain-specific, but I hope that in general it's not too hard to follow along.

rameshthoomu (Tue, 22 Jan 2019 16:36:43 GMT):
https://gerrit.hyperledger.org/r/#/c/28789/ - Update multiarch script to publish fabric-baseos to Dockerhub

negupta (Tue, 22 Jan 2019 18:01:26 GMT):
@dave.enyeart @chris.elder https://gerrit.hyperledger.org/r/#/c/28644/ - Update to add query examples to couchDB tutorial.

rameshthoomu (Tue, 22 Jan 2019 21:13:14 GMT):
https://gerrit.hyperledger.org/r/#/c/28898/ - Update to publish images with make targets

rameshthoomu (Tue, 22 Jan 2019 21:39:07 GMT):
https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric+topic:makefile - minor changes on fabric makefile

odowdaibm (Wed, 23 Jan 2019 10:27:08 GMT):
Hi @aso @dave.enyeart Lots of +1s for new contract names topic, which also incorporated updated ledger key concept and new smart contract/chaincode key concept topic. Thanks to @SjirNijssen @IsaacWong @carl @Yogendrasri @joe-alewine @NikhilGupta @alask

odowdaibm (Wed, 23 Jan 2019 10:27:08 GMT):
Hi @aso @dave.enyeart CR is https://gerrit.hyperledger.org/r/c/27579/ looking for a +2. Lots of +1s for new contract names topic, which also incorporated updated ledger key concept and new smart contract/chaincode key concept topic. Thanks to @SjirNijssen @IsaacWong @carl @Yogendrasri @joe-alewine @NikhilGupta @alaskadd for comments, content -- much appreciated. Happy to take comments too @aso, @dave.enyeart !

NikhilGupta (Wed, 23 Jan 2019 10:27:09 GMT):
Has joined the channel.

odowdaibm (Wed, 23 Jan 2019 13:00:40 GMT):
@cmgabriel thanks to Chris Gabriel for CR is https://gerrit.hyperledger.org/r/c/27579/ likewise!

cmgabriel (Wed, 23 Jan 2019 13:00:40 GMT):
Has joined the channel.

lehors (Mon, 28 Jan 2019 15:02:53 GMT):
I have pushed several CRs that are in need of love: https://gerrit.hyperledger.org/r/#/q/author:lehors+status:open thanks!

baohua (Wed, 30 Jan 2019 21:56:58 GMT):
https://gerrit.hyperledger.org/r/#/c/28996/, one more +2 needed, thanks!

baohua (Wed, 30 Jan 2019 21:57:41 GMT):
[ ](https://chat.hyperledger.org/channel/fabric-pr-review?msg=4Ztx9wsb8cS6WPoYS) @lehors +1 to one of them ;-)

rameshthoomu (Fri, 01 Feb 2019 14:20:08 GMT):
Minor changes to fabric makefile (release-1.2 and release-1.3 branches) https://gerrit.hyperledger.org/r/#/c/28899/ https://gerrit.hyperledger.org/r/#/c/28900/

sambhavdutt (Mon, 04 Feb 2019 18:40:31 GMT):
I have enabled Jenkinsfile for r-1.0 and r-1.1 branch in `fabric-samples` Can you approve this if ok https://gerrit.hyperledger.org/r/#/c/28491/ https://gerrit.hyperledger.org/r/#/c/28540/

cbf (Mon, 04 Feb 2019 22:58:53 GMT):
all, as we start to move towards automated management of the CR aging policy, here is a list of CRs that have not had any review comments since the last patchset was published and are at least two weeks old

cbf (Mon, 04 Feb 2019 22:58:56 GMT):
----

cbf (Mon, 04 Feb 2019 23:00:53 GMT):
https://gist.github.com/christo4ferris/7e414832895ece50041f7d59a08763a5

cbf (Mon, 04 Feb 2019 23:00:56 GMT):
----

cbf (Mon, 04 Feb 2019 23:01:21 GMT):
@all please review this list and chip in to start getting these reviewed thanks

cbf (Mon, 04 Feb 2019 23:09:13 GMT):
note that as you review these, if they are so stale that they need to be updated, please make that point in your comments and apologize for the delay in reviewing

cbf (Mon, 04 Feb 2019 23:09:44 GMT):
we need to get back to a position where we are actually reviewing things in "real time" as they are submitted or updated

aso (Tue, 05 Feb 2019 08:04:15 GMT):
second +2 for https://gerrit.hyperledger.org/r/#/c/28803/ pls

bestbeforetoday (Tue, 05 Feb 2019 10:43:40 GMT):
Has left the channel.

cbf (Tue, 05 Feb 2019 20:54:43 GMT):
so, we made zero progress on the backlog of unreviewed CRs I posted yesterday. ahem

jyellick (Wed, 06 Feb 2019 05:32:25 GMT):
Going through these CRs, there are a number of them which have received no reply to comments for weeks or months. I know we had talked about having a script/bot which automatically reminds and then abandons on these. I hope this happens at some point, but is there an official process for human intervention in the meantime?

rameshthoomu (Wed, 06 Feb 2019 14:38:00 GMT):
need one more +2 https://gerrit.hyperledger.org/r/#/c/28898/

suchith.arodi (Fri, 08 Feb 2019 16:03:43 GMT):
Has joined the channel.

bpbuch (Fri, 08 Feb 2019 16:17:13 GMT):
Has joined the channel.

rameshthoomu (Mon, 11 Feb 2019 14:35:45 GMT):
https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric+topic:makefile - Minor changes on fabric makefile (release-1.2 and release-1.3 branches)

rameshthoomu (Mon, 11 Feb 2019 21:25:48 GMT):
One more +2 required https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric+topic:makefile

rameshthoomu (Mon, 11 Feb 2019 21:25:48 GMT):
One more +2 required ~https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric+topic:makefile~

dave.enyeart (Tue, 12 Feb 2019 16:10:14 GMT):
One more +2 please for better fabcar error handling: https://gerrit.hyperledger.org/r/#/c/28539/

suppandi (Thu, 14 Feb 2019 20:02:14 GMT):
Has joined the channel.

danacr (Thu, 14 Feb 2019 20:05:11 GMT):
Has left the channel.

suppandi (Thu, 14 Feb 2019 20:06:36 GMT):
Hi @rameshthoomu, i made the changes you suggested in https://gerrit.hyperledger.org/r/#/c/29245/. could you please have another look.

dave.enyeart (Tue, 19 Feb 2019 17:41:59 GMT):
Update java to get baseimage CI to pass: https://gerrit.hyperledger.org/r/#/c/27953/

dave.enyeart (Tue, 19 Feb 2019 17:41:59 GMT):
~Update java to get baseimage CI to pass: https://gerrit.hyperledger.org/r/#/c/27953/~

dave.enyeart (Tue, 19 Feb 2019 21:45:56 GMT):
One more +2 please for better fabcar error handling: https://gerrit.hyperledger.org/r/#/c/28539/

dave.enyeart (Tue, 19 Feb 2019 21:46:26 GMT):
Pin fabric-samples to node.js master "unstable" modules : https://gerrit.hyperledger.org/r/#/c/29267/

rameshthoomu (Thu, 21 Feb 2019 14:15:28 GMT):
byfn e2e tests are broken - fix is here https://gerrit.hyperledger.org/r/#/c/29421/

rameshthoomu (Thu, 21 Feb 2019 17:51:39 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/c/29421/

lehors (Fri, 22 Feb 2019 09:29:51 GMT):
Could somebody please review and merge this CR which isn't from me but is a perfect example of a super simple fix that is left liggering around and will discourage further contributions. Thanks. https://gerrit.hyperledger.org/r/#/c/28937/

lehors (Fri, 22 Feb 2019 09:29:51 GMT):
Could somebody please review and merge this CR which isn't from me but is a perfect example of a super simple fix that is left lingering around and will discourage further contributions. Thanks. https://gerrit.hyperledger.org/r/#/c/28937/

sstone1 (Fri, 22 Feb 2019 12:07:25 GMT):
I've +1'ed it as well

sstone1 (Fri, 22 Feb 2019 14:41:45 GMT):
please can someone review this CR - updates to BYFN to allow service discovery to work both inside and outside of Docker: https://gerrit.hyperledger.org/r/#/c/29481/

kostas (Fri, 22 Feb 2019 14:42:13 GMT):
This should be relatively easy to review w/o domain knowledge and will allow us to re-run SVT before the weekend: https://gerrit.hyperledger.org/r/c/29477/

sstone1 (Fri, 22 Feb 2019 20:38:13 GMT):
Can I get two +2’s on this cherry pick of my BYFN fix above to release-1.4 please: https://gerrit.hyperledger.org/r/#/c/29496/

dave.enyeart (Mon, 25 Feb 2019 06:00:43 GMT):
fix eyfn: https://gerrit.hyperledger.org/r/#/c/29528/

sstone1 (Mon, 25 Feb 2019 12:03:10 GMT):
couple of simple CRs for review please - add connection profiles to BYFN/EFYN for use by the Fabric SDKs: https://gerrit.hyperledger.org/r/#/c/29532/ (master) https://gerrit.hyperledger.org/r/#/c/29533/ (release-1.4)

negupta (Mon, 25 Feb 2019 15:22:55 GMT):
Adding indexing examples to the couchDB tutorial. https://gerrit.hyperledger.org/r/#/c/28644/ +1's from the doc team and chris elder. @dave.enyeart could you review?

negupta (Tue, 26 Feb 2019 16:52:53 GMT):
Indexing examples. Ready for two +2's https://gerrit.hyperledger.org/r/#/c/28644/

cbf (Tue, 26 Feb 2019 21:42:10 GMT):
there are currently about 60 CRs needing review, or that should be abandoned. https://gist.github.com/christo4ferris/7b40209dcecbc4530babbad4c1e46cae

cbf (Tue, 26 Feb 2019 21:42:48 GMT):
@here ^^ I made a significant dent in some of the older ones and pinged a few people to address...

cbf (Tue, 26 Feb 2019 21:43:15 GMT):
Please take a look and help get this down to a reasonable number so I can start automating this process

suppandi (Tue, 26 Feb 2019 21:47:04 GMT):
@sykesm @mastersingh24 ready for +2s https://gerrit.hyperledger.org/r/#/c/29245/

lehors (Wed, 27 Feb 2019 00:02:02 GMT):
@cbf: again, we can't abandon CRs that have merely been neglected by the maintainers. For instance, as far as I can tell, https://gerrit.hyperledger.org/r/#/c/25653/ is ready to be merged and just need maintainers to act on it...

lehors (Wed, 27 Feb 2019 00:02:50 GMT):
so, please, be careful not to be too quick with abandoning CRs :)

cbf (Wed, 27 Feb 2019 14:02:12 GMT):
I am not suggesting we do, but CRs that have build failures, or unresolved review comments are fair game

kostas (Wed, 27 Feb 2019 18:49:52 GMT):
Has left the channel.

sstone1 (Fri, 01 Mar 2019 08:28:20 GMT):
bumping to the top ;-) couple of simple CRs for review please - add connection profiles to BYFN/EFYN for use by the Fabric SDKs (this is part of the work to rebase FabCar onto BYFN under FAB-12876): https://gerrit.hyperledger.org/r/#/c/29532/ (master) https://gerrit.hyperledger.org/r/#/c/29533/ (release-1.4)

mbwhite (Fri, 01 Mar 2019 09:54:41 GMT):
Mentioned on the mailing list, the update to the Node v10 as the Node.js chaincode runtime.. https://gerrit.hyperledger.org/r/#/c/29420/ Will add release notes to the node-chaincode - but @dave.enyeart is there a general fabric release notes we could mention this in? Thanks!!

dave.enyeart (Fri, 01 Mar 2019 12:10:43 GMT):
@mbwhite I've pushed an initial skeleton of the release notes for v2.0.0 and mentioned Node.js 10.15.1. Everybody can make further updates, either before or after the initial merge of it. https://gerrit.hyperledger.org/r/#/c/29734/1/release_notes/v2.0.0.txt@52

mbwhite (Fri, 01 Mar 2019 12:42:37 GMT):
thanks @dave.enyeart

joe-alewine (Fri, 01 Mar 2019 20:29:33 GMT):
Orderer concept doc: https://gerrit.hyperledger.org/r/c/29449/10

negupta (Mon, 04 Mar 2019 21:03:05 GMT):
Back porting the couchDB index examples in master to the 1.4,1.3, and 1.2 release docs: https://gerrit.hyperledger.org/r/#/c/29797/, https://gerrit.hyperledger.org/r/#/c/29789/,https://gerrit.hyperledger.org/r/#/c/29788/

pandrejko (Tue, 05 Mar 2019 13:41:02 GMT):
Simple update to BYFN: 1.1 https://gerrit.hyperledger.org/r/#/c/29796/ 1.2 https://gerrit.hyperledger.org/r/#/c/29795/ 1.3 https://gerrit.hyperledger.org/r/#/c/29794/ 1.4 https://gerrit.hyperledger.org/r/#/c/29792/ master: https://gerrit.hyperledger.org/r/29791

sstone1 (Wed, 06 Mar 2019 13:45:42 GMT):
fixes to the docs to reflect port changes i made to BYFN: https://gerrit.hyperledger.org/r/#/c/29882/ (master) https://gerrit.hyperledger.org/r/#/c/29883/ (release-1.4)

KyunghoKim (Tue, 12 Mar 2019 03:10:39 GMT):
Has joined the channel.

Pradeep_Pentakota (Tue, 12 Mar 2019 12:43:13 GMT):
Has joined the channel.

rameshthoomu (Wed, 13 Mar 2019 19:03:11 GMT):
https://gerrit.hyperledger.org/r/#/c/30067/ - minor fix.. This fix will unblock publishing images to nexus from nightly job..

binhn (Thu, 14 Mar 2019 22:07:19 GMT):
@dave.enyeart @sykesm @muralisr these 2 PRs are the base for the new cc model we discussed. Please review and merge ASAP to avoid conflicts, which I had to rebase twice already. Thanks. https://gerrit.hyperledger.org/r/#/c/29391/ https://gerrit.hyperledger.org/r/#/c/29498/

cbf (Fri, 15 Mar 2019 15:07:49 GMT):
@all we're getting a bit more caught up on delinquent CRs, but we still have a bunch

cbf (Fri, 15 Mar 2019 15:08:20 GMT):
here's a set from January (we are almost all caught up with 2018!)

cbf (Fri, 15 Mar 2019 15:08:23 GMT):
https://gerrit.hyperledger.org/r/#/c/27631 --- [FAB-12913] Atomic swap e2e test --- mathiasb303 --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/27985 --- [FAB-12259] TMS Verifier: atomic swap --- mathiasb303 --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/26784 --- [FAB-12261] TMS Transactor: atomic swap --- elli-androulaki --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/27465 --- [FAB-12790] Chaincode API for Token Expectation --- angelo.decaro --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/21855 --- opt: Reduce exclusive lock time during commit --- Senthil1 --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/28282 --- recon: separate missingPvtData code from txmgr --- Senthil1 --- Fri Jan 04 2019 https://gerrit.hyperledger.org/r/#/c/27527 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27529 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27525 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27528 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/29005 --- [FABC-798] Add mysql runner integration test --- latitiah --- Tue Jan 29 2019 https://gerrit.hyperledger.org/r/#/c/28826 --- [FAB-13769] Add UT code to ABAC sample Chaincode --- yuki-kon --- Fri Jan 18 2019 https://gerrit.hyperledger.org/r/#/c/28491 --- FAB-13545 - Add pipeline jobs for release-1.1 --- sambhavdutt --- Tue Jan 15 2019 https://gerrit.hyperledger.org/r/#/c/28540 --- FAB-13545 - Add pipeline jobs for release-1.0 --- sambhavdutt --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/27098 --- [FAB-12535] balance-transfer: Use service discovery --- yuki-kon --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/19557 --- [FAB-9033] TypeScript sample uses latest type defs --- shimos --- Fri Jan 04 2019 https://gerrit.hyperledger.org/r/#/c/28458 --- [FAB-13448] SBE ListOrgs() and service discovery --- mne --- Fri Jan 04 2019 https://gerrit.hyperledger.org/r/#/c/29023 --- [FABN-1123] Fix identity update maxEnrollments --- GuillaumeCisco --- Wed Jan 30 2019 https://gerrit.hyperledger.org/r/#/c/28115 --- [FABN-1064] Add connect method to peer, orderer --- davidkhala --- Mon Jan 21 2019 https://gerrit.hyperledger.org/r/#/c/28446 --- [FABN-870] minor jsdoc fix in channel.js --- davidkhala --- Mon Jan 14 2019

cbf (Fri, 15 Mar 2019 15:09:17 GMT):
Now, I realize that some of these are deferred or WIP, but let's try to get some of these reviewed and merged if apprpriate

cbf (Fri, 15 Mar 2019 15:09:17 GMT):
Now, I realize that some of these are deferred or WIP, but let's try to get some of these reviewed and merged if appropriate

dave.enyeart (Sat, 16 Mar 2019 15:47:20 GMT):
Release updated baseimage, to be used with v1.4.1: https://gerrit.hyperledger.org/r/#/c/30137/

gaijinviki (Mon, 18 Mar 2019 03:06:26 GMT):
Has left the channel.

joe-alewine (Mon, 18 Mar 2019 14:08:11 GMT):
Orderer service concept doc (includes Raft concepts): https://gerrit.hyperledger.org/r/c/29449/ Configure Raft doc: https://gerrit.hyperledger.org/r/c/30010/

negupta (Mon, 18 Mar 2019 14:20:08 GMT):
Token operational documentation for 2.0 alpha available for review: https://gerrit.hyperledger.org/r/#/c/29266/

cbf (Mon, 18 Mar 2019 14:34:26 GMT):
@all The january backlog improved, but is still a problem... we also need to take care of February, but let's beat down the backlog. Thanks!

cbf (Mon, 18 Mar 2019 14:34:29 GMT):
https://gerrit.hyperledger.org/r/#/c/27631 --- [FAB-12913] Atomic swap e2e test --- mathiasb303 --- Thu Jan 10 2019 https://gerrit.hyperledger.org/r/#/c/27985 --- [FAB-12259] TMS Verifier: atomic swap --- mathiasb303 --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/26784 --- [FAB-12261] TMS Transactor: atomic swap --- elli-androulaki --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/21855 --- opt: Reduce exclusive lock time during commit --- Senthil1 --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/28282 --- recon: separate missingPvtData code from txmgr --- Senthil1 --- Fri Jan 04 2019 https://gerrit.hyperledger.org/r/#/c/27527 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27529 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27528 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/28826 --- [FAB-13769] Add UT code to ABAC sample Chaincode --- yuki-kon --- Fri Jan 18 2019 https://gerrit.hyperledger.org/r/#/c/28491 --- FAB-13545 - Add pipeline jobs for release-1.1 --- sambhavdutt --- Tue Jan 15 2019 https://gerrit.hyperledger.org/r/#/c/28540 --- FAB-13545 - Add pipeline jobs for release-1.0 --- sambhavdutt --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/27098 --- [FAB-12535] balance-transfer: Use service discovery --- yuki-kon --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/19557 --- [FAB-9033] TypeScript sample uses latest type defs --- shimos --- Fri Jan 04 2019 https://gerrit.hyperledger.org/r/#/c/28458 --- [FAB-13448] SBE ListOrgs() and service discovery --- mne --- Fri Jan 04 2019 https://gerrit.hyperledger.org/r/#/c/29023 --- [FABN-1123] Fix identity update maxEnrollments --- GuillaumeCisco --- Wed Jan 30 2019

joe-alewine (Mon, 18 Mar 2019 14:59:55 GMT):
Glossary updates for Raft: https://gerrit.hyperledger.org/r/c/30182/

joe-alewine (Mon, 18 Mar 2019 15:20:08 GMT):
Adding links to Kafka doc: https://gerrit.hyperledger.org/r/c/30183/ (also did a lot of reformatting here to conform to line length standards)

joe-alewine (Mon, 18 Mar 2019 17:27:01 GMT):
Add Raft to "What's new" doc: https://gerrit.hyperledger.org/r/c/30187/

joe-alewine (Mon, 18 Mar 2019 17:59:08 GMT):
Small change here to update text in "Intro" doc (about Raft): https://gerrit.hyperledger.org/r/c/30189/

joe-alewine (Mon, 18 Mar 2019 20:01:51 GMT):
Add some text about Raft to the "Upgrade" doc: https://gerrit.hyperledger.org/r/c/30196/

davidkhala (Tue, 19 Mar 2019 08:27:10 GMT):
@cbf @bretharrison hope it is not too late, https://gerrit.hyperledger.org/r/#/c/28446/

davidkhala (Tue, 19 Mar 2019 08:28:54 GMT):
https://gerrit.hyperledger.org/r/#/c/29917/ one originated in BootCampHK :woo:

davidkhala (Tue, 19 Mar 2019 11:02:03 GMT):
@bretharrison rebased https://gerrit.hyperledger.org/r/#/c/28115/

firas.qutishat (Tue, 19 Mar 2019 16:26:49 GMT):
please review https://gerrit.hyperledger.org/r/#/c/30094/

dave.enyeart (Tue, 19 Mar 2019 19:46:59 GMT):
Upgrade fabric to use the new baseimage 0.4.15: https://gerrit.hyperledger.org/r/#/c/30211/ (master) https://gerrit.hyperledger.org/r/#/c/30239/ (release-1.4)

joe-alewine (Tue, 19 Mar 2019 19:54:12 GMT):
Document that your app needs to actively listen for events (especially with Raft): https://gerrit.hyperledger.org/r/c/30237/ Add short paragraph to BYFN (in release1.4 branch) about option to use Raft with BYFN: https://gerrit.hyperledger.org/r/c/30238/ FYI, tutorial for the above still in development

joe-alewine (Tue, 19 Mar 2019 21:59:27 GMT):
Documenting how to stand up an orderer (regardless of its ultimately implementation). Compiling the binary, MSPs, etc. With linking out to other relevant docs. https://gerrit.hyperledger.org/r/c/30242/

joe-alewine (Tue, 19 Mar 2019 21:59:27 GMT):
Raft doc CRs: A small number of these have open comments against them, but most do not, and most are pretty small changes (in some cases, only a few words). Here's a rundown: Orderer concept: https://gerrit.hyperledger.org/r/c/29449/ Configure Raft: https://gerrit.hyperledger.org/r/c/30010/ Glossary updates: https://gerrit.hyperledger.org/r/c/30182/ Stand up orderer node (implementation agnostic): https://gerrit.hyperledger.org/r/c/30242/ Add Raft option to BYFN (checked out against `release-1.4`): https://gerrit.hyperledger.org/r/c/30238/ Add Raft to Intro doc: https://gerrit.hyperledger.org/r/c/30189/ Add Raft to What's New doc: https://gerrit.hyperledger.org/r/c/30187/ Add Raft to Upgrade: https://gerrit.hyperledger.org/r/c/30196/ Add links to Kafka doc: https://gerrit.hyperledger.org/r/c/30183/ There's still one more doc to come --- the tutorial doc, which I'm working on.

aso (Wed, 20 Mar 2019 14:16:33 GMT):
easy one: 13-line change with a +2 already https://gerrit.hyperledger.org/r/#/c/30246/

aso (Wed, 20 Mar 2019 14:16:33 GMT):
~easy one: 13-line change with a +2 already https://gerrit.hyperledger.org/r/#/c/30246/~

joe-alewine (Wed, 20 Mar 2019 17:34:29 GMT):
Raft doc CRs: A small number of these have open comments against them, but most do not, and most are pretty small changes (in some cases, only a few words). Here's a rundown: Orderer concept: https://gerrit.hyperledger.org/r/c/29449/ Configure Raft: https://gerrit.hyperledger.org/r/c/30010/ Glossary updates: https://gerrit.hyperledger.org/r/c/30182/ Stand up orderer node (implementation agnostic): https://gerrit.hyperledger.org/r/c/30242/ Add Raft option to BYFN (checked out against `release-1.4`): https://gerrit.hyperledger.org/r/c/30238/ Add Raft to Intro doc: https://gerrit.hyperledger.org/r/c/30189/ Add Raft to What's New doc: https://gerrit.hyperledger.org/r/c/30187/ Add Raft to Upgrade: https://gerrit.hyperledger.org/r/c/30196/ Add links to Kafka doc: https://gerrit.hyperledger.org/r/c/30183/ There's still one more doc to come --- the tutorial doc, which I'm working on.

rameshthoomu (Wed, 20 Mar 2019 21:42:23 GMT):
CI pipeline scripts and doc for fabric-ca https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric-ca+topic:pipeline-ca

dave.enyeart (Thu, 21 Mar 2019 02:31:50 GMT):
Update fabric v1.4 to use recent baseimage 0.4.15: https://gerrit.hyperledger.org/r/#/c/30239/

davidkhala (Thu, 21 Mar 2019 10:31:25 GMT):
https://gerrit.hyperledger.org/r/#/c/30272/

negupta (Thu, 21 Mar 2019 12:49:58 GMT):
Updating endorsement policy operations guide for lifecycle: https://gerrit.hyperledger.org/r/#/c/29939/

rameshthoomu (Thu, 21 Mar 2019 19:05:59 GMT):
https://gerrit.hyperledger.org/r/#/c/30074/ - CI pipeline script for fabric-samples

firas.qutishat (Thu, 21 Mar 2019 22:51:29 GMT):
https://gerrit.hyperledger.org/r/#/c/30294/ fix go_tags bug

joe-alewine (Fri, 22 Mar 2019 19:39:23 GMT):
Open Raft-lated doc CRs: Raft tutorial: https://gerrit.hyperledger.org/r/c/30332/ (newest push, has no comments yet) Orderer concept: https://gerrit.hyperledger.org/r/c/29449/ (has gone through several rounds of comments) Configure Raft: https://gerrit.hyperledger.org/r/c/30010/ (has gone through several rounds of comments, though decisions about what should go in doc are still pending) Glossary updates: https://gerrit.hyperledger.org/r/c/30182/ (wording here taken from concept doc --- if you feel good about the concept doc, you should feel good about this) Stand up orderer node (implementation agnostic): https://gerrit.hyperledger.org/r/c/30242/ (could use more help) Add Raft option to BYFN (checked out against `release-1.4`): https://gerrit.hyperledger.org/r/c/30238/ (small change) Add Raft to Intro doc: https://gerrit.hyperledger.org/r/c/30189/ (tiny change) Add Raft to What's New doc: https://gerrit.hyperledger.org/r/c/30187/ (summary of major docs being pushed here) Add Raft to Upgrade: https://gerrit.hyperledger.org/r/c/30196/ (small references to Raft) Add links to Kafka doc: https://gerrit.hyperledger.org/r/c/30183/ (small change --- majority is formatting changes) As I've said before, many of these CRs are rather small. In some cases, only a few words followed by a link. I very much appreciate everyone's comments so far, and to come.

dave.enyeart (Sun, 24 Mar 2019 18:10:15 GMT):
@joe-alewine Reviewed, edited, and +2ed most of them. Let's get as many merged as possible so that we can focus on the few remaining ones early this week.

dave.enyeart (Sun, 24 Mar 2019 18:10:15 GMT):
@joe-alewine I reviewed, edited, and +2ed most of them. Let's get as many merged as possible so that we can focus on the few remaining ones early this week.

dave.enyeart (Sun, 24 Mar 2019 18:10:15 GMT):
@joe-alewine I reviewed, edited, and +2ed most of them. Folks, let's get as many merged as possible so that we can focus on the few remaining ones early this week.

aso (Mon, 25 Mar 2019 08:42:10 GMT):
https://gerrit.hyperledger.org/r/#/c/27754/ is ready to be merged - second +2 please..

negupta (Mon, 25 Mar 2019 22:40:50 GMT):
May be a bit too early, but many chaincode lifecycle docs are ready to review: Chaincode for operators: https://gerrit.hyperledger.org/r/#/c/30109/

negupta (Mon, 25 Mar 2019 22:40:50 GMT):
May be a bit too early, but many chaincode lifecycle docs are ready to review: Chaincode for operators: https://gerrit.hyperledger.org/r/#/c/30109/ Chaincode for developers: https://gerrit.hyperledger.org/r/#/c/30124/ Endorsement guide: https://gerrit.hyperledger.org/r/#/c/29939/ System chaincode pluggins tutorial: https://gerrit.hyperledger.org/r/#/c/30288/ Pluggable endorsement operations guide: https://gerrit.hyperledger.org/r/#/c/30289/ BYFN: https://gerrit.hyperledger.org/r/#/c/29611/

joe-alewine (Tue, 26 Mar 2019 17:32:12 GMT):
Thanks @dave.enyeart! A few Raft docs have been merged. Here is what is in need of reviews (all comments have been addressed): Add Raft to BYFN (with commands and more context): https://gerrit.hyperledger.org/r/c/30426/ Orderer concept: https://gerrit.hyperledger.org/r/c/29449/ Configure Raft: https://gerrit.hyperledger.org/r/c/30010/ Glossary updates: https://gerrit.hyperledger.org/r/c/30182/ Stand up orderer node (implementation agnostic): https://gerrit.hyperledger.org/r/c/30242/ Add Raft to What's New doc: https://gerrit.hyperledger.org/r/c/30187/ (needs one more +2)

davidkhala (Wed, 27 Mar 2019 08:06:18 GMT):
Dear Gari @mastersingh24 , https://gerrit.hyperledger.org/r/#/c/30450/ a fabric-sdk-node cleanup patch

sstone1 (Wed, 27 Mar 2019 09:21:41 GMT):
@davidkhala I've commented on your CR

davidkhala (Wed, 27 Mar 2019 09:26:17 GMT):
@sstone1 Simon, what is your opinion that removing gulp watch entirely?

sstone1 (Wed, 27 Mar 2019 09:55:40 GMT):
@davidkhala I don't personally use it - maybe @andrew-coleman @bretharrison @bestbeforetoday @nkl199 have an opinion?

nkl199 (Wed, 27 Mar 2019 09:55:40 GMT):
Has joined the channel.

bestbeforetoday (Wed, 27 Mar 2019 09:55:40 GMT):
Has joined the channel.

nkl199 (Wed, 27 Mar 2019 09:57:37 GMT):
I'm generally in favour of removing anything that isn't necessary ...

davidkhala (Wed, 27 Mar 2019 10:03:13 GMT):
I agree with Nick. And in this case, the CR will be a little bigger in lines, apolygize it first.

rameshthoomu (Wed, 27 Mar 2019 15:33:41 GMT):
fabric-samples - Pipeline changes with documentation on master and release-1.4 https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric-samples+topic:pipeline-samples

davidkhala (Wed, 27 Mar 2019 16:58:38 GMT):
https://gerrit.hyperledger.org/r/#/c/30449/ fix a npm audit vunerability

jyellick (Thu, 28 Mar 2019 03:51:19 GMT):
A simple and easily reviewable shell change https://gerrit.hyperledger.org/r/c/30480/

negupta (Mon, 01 Apr 2019 14:26:16 GMT):
Token documentation for the 2.0 Alpha: Operations guide: https://gerrit.hyperledger.org/r/#/c/29266/ Glossary Updates: https://gerrit.hyperledger.org/r/#/c/30509/

joe-alewine (Mon, 01 Apr 2019 20:15:04 GMT):
Add Raft to BYFN in master branch: https://gerrit.hyperledger.org/r/c/30606/ Small fixes to BYFN in release-1.4: https://gerrit.hyperledger.org/r/c/30608/

negupta (Mon, 01 Apr 2019 20:33:58 GMT):
Token CLI docs: https://gerrit.hyperledger.org/r/#/c/30511/

davidkhala (Wed, 03 Apr 2019 01:20:51 GMT):
https://gerrit.hyperledger.org/r/#/c/30450/ [Refactor][fabric-sdk-node] move duplicated files in fabric-ca-client, fabric-client and fabrirc-network to fabric-common

rameshthoomu (Wed, 03 Apr 2019 14:01:05 GMT):
Fabric-samples CI pipeline scripts - https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric-samples+topic:pipeline-samples

cbf (Wed, 03 Apr 2019 14:32:13 GMT):
@here as discussed on the maintainers call this morning, here are the outstanding CRs that have not been updated since January

cbf (Wed, 03 Apr 2019 14:32:16 GMT):
https://gerrit.hyperledger.org/r/#/c/27631 --- [FAB-12913] Atomic swap e2e test --- mathiasb303 --- Thu Jan 10 2019 https://gerrit.hyperledger.org/r/#/c/27985 --- [FAB-12259] TMS Verifier: atomic swap --- mathiasb303 --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/26784 --- [FAB-12261] TMS Transactor: atomic swap --- elli-androulaki --- Wed Jan 09 2019 https://gerrit.hyperledger.org/r/#/c/21855 --- opt: Reduce exclusive lock time during commit --- Senthil1 --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/28282 --- recon: separate missingPvtData code from txmgr --- Senthil1 --- Fri Jan 04 2019 https://gerrit.hyperledger.org/r/#/c/27527 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27529 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27528 --- FAB-12844 ACL library package update --- Tecnalia --- Thu Jan 03 2019 https://gerrit.hyperledger.org/r/#/c/27098 --- [FAB-12535] balance-transfer: Use service discovery --- yuki-kon --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/19557 --- [FAB-9033] TypeScript sample uses latest type defs --- shimos --- Fri Jan 04 2019

cbf (Wed, 03 Apr 2019 14:32:31 GMT):
The list for February is a bit longer

cbf (Wed, 03 Apr 2019 14:32:45 GMT):
https://gerrit.hyperledger.org/r/#/c/25183 --- [FAB-11336] Add UT for txmgmt/validator --- diizuka --- Wed Feb 27 2019 https://gerrit.hyperledger.org/r/#/c/29366 --- [FAB-13713] Adding new org integration test --- latitiah --- Wed Feb 27 2019 https://gerrit.hyperledger.org/r/#/c/22889 --- [FAB-10439] Chaincode and Smart Contract Concept --- cmgabriel --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/27437 --- [FAB-12682] Configure MSP based on a YAML file --- mne --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/27830 --- [FAB-9527] Use of Idemix-based BCCSP in Idemixgen --- pnovotny --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/27713 --- [FAB-12979] Addressing tms verifier comments --- mathiasb303 --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/27499 --- [FAB-9527] Use of Idemix-based BCCSP in Idemixgen --- pnovotny --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/24603 --- [FAB-11241] Move Profiling init Service external --- baohua --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/26943 --- [FAB-10520] Define state access APIs by composite key --- yuki-kon --- Thu Feb 21 2019 https://gerrit.hyperledger.org/r/#/c/22739 --- FAB-9444 Add visual vocabulary to glossary --- odowdaibm --- Wed Feb 20 2019 https://gerrit.hyperledger.org/r/#/c/28948 --- FAB-13844 Advanced Commercial Paper --- odowdaibm --- Wed Feb 20 2019 https://gerrit.hyperledger.org/r/#/c/17731 --- [FAB-8156] Add CouchDB partial index support --- chris.elder --- Wed Feb 20 2019 https://gerrit.hyperledger.org/r/#/c/29132 --- wip - dependencies for new validation/commit path --- manish-sethi --- Mon Feb 11 2019 https://gerrit.hyperledger.org/r/#/c/28694 --- [FAB-12430] configure for inversion of control --- awjh-ibm --- Thu Feb 07 2019 https://gerrit.hyperledger.org/r/#/c/28004 --- [FAB-13188] Idemix MSP Configuration, Epoch support --- angelo.decaro --- Mon Feb 04 2019 https://gerrit.hyperledger.org/r/#/c/27871 --- [FAB-13105] Idemix Signature-based Revocation --- angelo.decaro --- Mon Feb 04 2019 https://gerrit.hyperledger.org/r/#/c/28148 --- Remove existing containers before starting --- zRich --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/27635 --- [FAB-12873] fix samples version, instead of latest. --- nicezic --- Mon Feb 25 2019 https://gerrit.hyperledger.org/r/#/c/28521 --- [FAB-13533] use right version of Fabric. --- nicezic --- Fri Feb 22 2019 https://gerrit.hyperledger.org/r/#/c/28967 --- Fix balance-transfer script --- preminem --- Fri Feb 22 2019 https://gerrit.hyperledger.org/r/#/c/29321 --- [FAB-14193] missing fabric-samples volume --- ping40 --- Fri Feb 15 2019 https://gerrit.hyperledger.org/r/#/c/28067 --- [FABJ-394] Signature-based whitelisting --- angelo.decaro --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/28324 --- FABN-1084 X509 library locked to 0.3.3 --- andrew-coleman --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/20531 --- [FAB-9500] Add missing function to typescript type --- Sneljo --- Wed Feb 20 2019 https://gerrit.hyperledger.org/r/#/c/29037 --- [FAB-13849] Release1.3 npm correction --- mbwhite --- Tue Feb 26 2019 https://gerrit.hyperledger.org/r/#/c/28695 --- [FAB-12430] update node image to include fabric-shim --- awjh-ibm --- Wed Feb 06 2019

cbf (Wed, 03 Apr 2019 14:33:39 GMT):
I'd appreciate people's help in reviewing these and either getting constructive comments (with apologies to contributors for the delay)

cbf (Wed, 03 Apr 2019 14:33:46 GMT):
or getting them merged

cbf (Wed, 03 Apr 2019 14:34:35 GMT):
before we can fully automate this process, we really need to burn down our backlog

davidkhala (Thu, 04 Apr 2019 09:05:58 GMT):
@cbf Thanks Chris for you reminds

davidkhala (Thu, 04 Apr 2019 09:15:15 GMT):
@cbf https://gerrit.hyperledger.org/r/#/c/28324 --- FABN-1084 X509 library locked to 0.3.3 --- andrew-coleman --- Tue Feb 26 2019 >> this is fixed in another way by @mbwhite already.

wlahti (Thu, 04 Apr 2019 13:54:18 GMT):
https://gerrit.hyperledger.org/r/c/30688/ - sampleconfig/configtx.yaml is missing Application V2_0 capabilities flag

davidkhala (Thu, 04 Apr 2019 16:18:36 GMT):
https://gerrit.hyperledger.org/r/30738 Readme: confluence page link fix

rolsonquadras (Thu, 04 Apr 2019 20:29:58 GMT):
Has joined the channel.

rolsonquadras (Thu, 04 Apr 2019 20:32:00 GMT):
Hi Team - I have created a PR https://gerrit.hyperledger.org/r/#/c/30747/ for JIRA https://gerrit.hyperledger.org/r/#/c/30747/. Could you please review this ?

yacovm (Thu, 04 Apr 2019 20:39:50 GMT):
@rolsonquadras why do we need to calculate the time it takes to update the ledger height?

joe-alewine (Thu, 04 Apr 2019 20:50:19 GMT):
Really need to get some reviews from maintainers on the Token doc: https://gerrit.hyperledger.org/r/c/29266/ Thanks

joe-alewine (Thu, 04 Apr 2019 20:50:19 GMT):
Really need to get some reviews from maintainers on the Token doc, as it must be merged before the Alpha can be cut: https://gerrit.hyperledger.org/r/c/29266/ Thanks

rolsonquadras (Thu, 04 Apr 2019 21:01:19 GMT):
@yacovm Thanks for the feedback. In hindsight, you are right. we don't need to log that duration. I'll update the jira/pr.

cbf (Fri, 05 Apr 2019 13:09:18 GMT):
@dave.enyeart @manish-sethi can we either get these reviewed or abandon them until they are ready to be reviewed?

cbf (Fri, 05 Apr 2019 13:09:19 GMT):
https://gerrit.hyperledger.org/r/#/c/21855 --- opt: Reduce exclusive lock time during commit --- Senthil1 --- Mon Jan 07 2019 https://gerrit.hyperledger.org/r/#/c/28282 --- recon: separate missingPvtData code from txmgr --- Senthil1 --- Fri Jan 04 2019

manish-sethi (Fri, 05 Apr 2019 13:43:34 GMT):
Sure @cbf - I'll ask Senthil to abandon these two for now - thanks

lehors (Fri, 05 Apr 2019 16:53:07 GMT):
https://gerrit.hyperledger.org/r/#/c/30320/ and https://gerrit.hyperledger.org/r/#/c/30411/ could use some love...

lehors (Fri, 05 Apr 2019 16:53:32 GMT):
pretty straightforward

rameshthoomu (Fri, 05 Apr 2019 23:56:08 GMT):
Need one more +2 https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric-samples+topic:pipeline-samples

rameshthoomu (Fri, 05 Apr 2019 23:56:08 GMT):
Need one more +2 or Ready to merge https://gerrit.hyperledger.org/r/#/q/status:open+project:fabric-samples+topic:pipeline-samples

negupta (Mon, 08 Apr 2019 13:13:22 GMT):
For the 2.0 Alpha, reviews are needed of the token documentation Operations guide: https://gerrit.hyperledger.org/r/#/c/29266/ Glossary Updates: https://gerrit.hyperledger.org/r/#/c/30509/ Token CLI docs: https://gerrit.hyperledger.org/r/#/c/30511/

negupta (Mon, 08 Apr 2019 19:13:14 GMT):
Whats new in the 2.0 Alpha release: https://gerrit.hyperledger.org/r/#/c/30693/

negupta (Tue, 09 Apr 2019 12:38:01 GMT):
Last doc reviews for alpha: Fabtoken to glossary: https://gerrit.hyperledger.org/r/#/c/30509/

negupta (Tue, 09 Apr 2019 12:40:09 GMT):
Looking for one more plus two on these docs: Token CLI: https://gerrit.hyperledger.org/r/#/c/30511/ Token operations guide: https://gerrit.hyperledger.org/r/#/c/29266/ BYFN updates: https://gerrit.hyperledger.org/r/#/c/30817/

negupta (Tue, 09 Apr 2019 19:33:21 GMT):
Quick link fix for alpha. Need one more +2

negupta (Tue, 09 Apr 2019 19:33:22 GMT):
https://gerrit.hyperledger.org/r/#/c/30832/

negupta (Tue, 09 Apr 2019 19:33:36 GMT):
The fabtoken glossary entry has also yet to be merged.

davidkhala (Wed, 10 Apr 2019 14:43:04 GMT):
https://gerrit.hyperledger.org/r/#/c/30738/ Confluence link fix for Readme

davidkhala (Thu, 11 Apr 2019 17:39:19 GMT):
https://gerrit.hyperledger.org/r/#/c/30897/ same for release-1.4

baohua (Thu, 18 Apr 2019 13:15:44 GMT):
https://gerrit.hyperledger.org/r/#/c/30924/

suppandi (Wed, 24 Apr 2019 15:06:09 GMT):
https://gerrit.hyperledger.org/r/#/c/30964/ - could someone have a look at this please.

levinem (Wed, 22 May 2019 16:42:17 GMT):
Has joined the channel.

baohua (Wed, 29 May 2019 00:21:52 GMT):
https://gerrit.hyperledger.org/r/#/c/fabric/+/31519/

negupta (Thu, 06 Jun 2019 18:22:15 GMT):
One more +2 needed on some fixes for the private data tutorial: https://gerrit.hyperledger.org/r/#/c/fabric/+/31048/

wlahti (Mon, 24 Jun 2019 17:05:14 GMT):
Fix for a build break on the current master: https://gerrit.hyperledger.org/r/c/fabric/+/32050

wlahti (Wed, 03 Jul 2019 14:18:35 GMT):
Any active `fabric-samples` maintainers have a little time to take a look at this CR? https://gerrit.hyperledger.org/r/c/fabric-samples/+/32162 For context, we recently renamed a _lifecycle function from `QueryApprovalStatus` to `SimulateCommitChaincodeDefinition` to accurately reflect that the function is only expected to be used as a dry-run of committing a chaincode definition to see if it's expected to commit successfully.

sstone1 (Wed, 03 Jul 2019 14:44:57 GMT):
@wlahti done :+1:

wlahti (Wed, 03 Jul 2019 15:03:47 GMT):
Thanks, Simon!

negupta (Mon, 15 Jul 2019 17:47:55 GMT):
Doc CR for the 1.4.2 release, updating the node OU section of the MSP operations guide: https://gerrit.hyperledger.org/r/#/c/fabric/+/32235/

pandrejko (Sun, 21 Jul 2019 18:30:48 GMT):
@joe-alewine, @negupta and I have been collaborating on a key concept topic about policies in our weekly Documentation working group. https://gerrit.hyperledger.org/r/#/c/fabric/+/30110/ It would be great to some feedback on it.

huxiangdong (Mon, 22 Jul 2019 02:04:05 GMT):
any `fabric-sdk-node` maintainers can help to review? it's a simple syntax error fix but will block usage with HSM if not fixed...thanks! https://gerrit.hyperledger.org/r/c/fabric-sdk-node/+/32318

yuki-kon (Tue, 23 Jul 2019 16:37:37 GMT):
Please review this CR. https://gerrit.hyperledger.org/r/#/c/fabric/+/32419/ This is not my CR but it’s very important for application developers to use v1.4.2. The bootstrap script for v1.4.2 has not been merged yet. The current script pulls v1.4.1 images.

huxd (Thu, 25 Jul 2019 05:38:00 GMT):
Has joined the channel.

sstone1 (Mon, 29 Jul 2019 10:49:43 GMT):
can someone review this CR please? it updates the CLI to run endorsements across multiple peers concurrently (should help resolve some sample CI failures): https://gerrit.hyperledger.org/r/c/fabric/+/32531

jyellick (Tue, 30 Jul 2019 20:09:58 GMT):
Is anyone aware of and working on the fact that master is broken right now?

jyellick (Tue, 30 Jul 2019 20:10:55 GMT):
Looks like fe96878a1a9150b135021ac85b731cdd250e495c causes `github.com/hyperledger/fabric/internal/peer/chaincode` `TestQueryCmdEndorsementFailure` to fail

jyellick (Tue, 30 Jul 2019 20:27:05 GMT):
https://gerrit.hyperledger.org/r/c/fabric/+/32595

yacovm (Tue, 30 Jul 2019 20:35:35 GMT):
how did it pass CI?

jyellick (Tue, 30 Jul 2019 20:37:29 GMT):
Basically, the optimization introduced by fe96878 seeks endorsements in parallel. So, the order they are returned in is arbitrary. In this test, there are two endorsements, and the code simply checks the first one. On my machine, the second seems to be consistently chosen, but I guess CI got (un)lucky and ordered them the other way.

yacovm (Tue, 30 Jul 2019 20:38:21 GMT):
> On my machine, the second seems to be consistently chosen, wow... your `/dev/random` is broken, Jason

yacovm (Tue, 30 Jul 2019 20:38:21 GMT):
> On my machine, the second seems to be consistently chosen, wow... your `/dev/urandom` is broken, Jason

yacovm (Tue, 30 Jul 2019 20:38:24 GMT):
;)

jyellick (Tue, 30 Jul 2019 20:41:14 GMT):
Must be the low entropy qualities of `/dev/urandom`, I'll have to submit a patch upstream so that `go` uses `/dev/random` in its scheduler just to be sure :)

sstone1 (Wed, 31 Jul 2019 09:17:59 GMT):
oops - thanks for fixing @jyellick !

sstone1 (Wed, 31 Jul 2019 09:18:28 GMT):
the test isn't really valid either - you can only use `peer chaincode query` against a single peer

sstone1 (Wed, 31 Jul 2019 15:57:17 GMT):
please can I get a review of this backport to 1.4 (includes the fix discussed above): https://gerrit.hyperledger.org/r/c/fabric/+/32610

sstone1 (Wed, 31 Jul 2019 15:57:41 GMT):
and i've got another CLI fix here for review: https://gerrit.hyperledger.org/r/c/fabric/+/32605

jtonline (Tue, 13 Aug 2019 14:48:20 GMT):
Has joined the channel.

jtonline (Tue, 13 Aug 2019 14:49:16 GMT):
Hi, https://gerrit.hyperledger.org/r/c/fabric/+/32739 is in need of one more +2 if anyone can help. Cheers

jtonline (Tue, 13 Aug 2019 14:49:16 GMT):
~Hi, https://gerrit.hyperledger.org/r/c/fabric/+/32739 is in need of one more +2 if anyone can help. Cheers~ Merged, thanks

rodolfoleal (Thu, 15 Aug 2019 16:38:26 GMT):
Has joined the channel.

davidkhala (Sun, 18 Aug 2019 07:59:51 GMT):
Hi, https://gerrit.hyperledger.org/r/c/fabric-sdk-node/+/32205/ need a review (as a fabric-sdk-node PR)

mbwhite (Mon, 19 Aug 2019 08:29:38 GMT):
Hello could I get some +1 / +2 for the Java Chaincode docs updates please 🙂 https://gerrit.hyperledger.org/r/c/fabric/+/32640

galaxystar (Tue, 20 Aug 2019 01:24:25 GMT):
Has joined the channel.

shitaibin (Thu, 22 Aug 2019 12:16:44 GMT):
Has joined the channel.

sstone1 (Fri, 23 Aug 2019 09:22:48 GMT):
can I get some +2 for these 1.4 backports please: https://gerrit.hyperledger.org/r/c/fabric/+/32663 https://gerrit.hyperledger.org/r/c/fabric/+/32666 https://gerrit.hyperledger.org/r/c/fabric/+/32610

dave.enyeart (Fri, 23 Aug 2019 16:16:08 GMT):
@sstone1 I commented on the latter one.

dave.enyeart (Fri, 23 Aug 2019 22:46:11 GMT):
@sstone1 (or anybody), this will make fabric-samples fabcar pass without the CLI changes in release-1.4: https://gerrit.hyperledger.org/r/#/c/fabric-samples/+/33172/

conanoc (Thu, 29 Aug 2019 05:26:51 GMT):
Has joined the channel.

conanoc (Thu, 29 Aug 2019 05:35:33 GMT):
@jyellick There are three CR's waiting for your review. Please take a look. https://gerrit.hyperledger.org/r/c/fabric/+/32780 https://gerrit.hyperledger.org/r/c/fabric/+/33156 https://gerrit.hyperledger.org/r/c/fabric/+/32984

conanoc (Fri, 30 Aug 2019 06:41:12 GMT):
@jyellick Thanks. https://gerrit.hyperledger.org/r/c/fabric/+/33156 is rebased and can be merged now.

sykesm (Tue, 03 Sep 2019 14:54:11 GMT):
Can I get some eyes on https://gerrit.hyperledger.org/r/c/fabric/+/33273 ? Once that goes in, I can start updating repos with go.mod/go.sum instead of all vendored deps

dongming (Fri, 06 Sep 2019 14:42:50 GMT):
Has joined the channel.

dongming (Fri, 06 Sep 2019 14:45:07 GMT):
can I get another +2 for https://gerrit.hyperledger.org/r/#/c/fabric/+/33124/ https://gerrit.hyperledger.org/r/#/c/fabric/+/33256/

sstone1 (Thu, 12 Sep 2019 14:57:09 GMT):
please can i get some +2s for these simple doc changes that remove references to Composer? https://gerrit.hyperledger.org/r/c/fabric/+/33486 (master) and https://gerrit.hyperledger.org/r/c/fabric/+/33487 (1.4)

shitaibin (Thu, 19 Sep 2019 07:35:44 GMT):
Hi, https://gerrit.hyperledger.org/r/c/fabric/+/33595 need a review for fabric example doc updates

negupta (Tue, 24 Sep 2019 20:58:47 GMT):
Hi, New HSM doc for review: https://gerrit.hyperledger.org/r/#/c/fabric/+/32298/

negupta (Tue, 24 Sep 2019 20:59:10 GMT):
Also, updates to the fabric concept docs for lifecycle: https://gerrit.hyperledger.org/r/#/c/fabric/+/31512/

negupta (Tue, 24 Sep 2019 20:59:19 GMT):
https://gerrit.hyperledger.org/r/#/c/fabric/+/32650/

rjones (Wed, 25 Sep 2019 19:06:03 GMT):
Has joined the channel.

rjones (Wed, 25 Sep 2019 19:06:17 GMT):
Please take a look at these and merge as possible: https://gerrit.hyperledger.org/r/q/%2522%255Bin-68%255D%2522

rjones (Wed, 25 Sep 2019 19:06:53 GMT):
If you want to see what it would look like in practice: https://github.com/hyperledger-cicd/iroha/security/policy

BrettLogan (Tue, 01 Oct 2019 21:01:22 GMT):
Has joined the channel.

BrettLogan (Tue, 01 Oct 2019 21:01:22 GMT):
Looking for some help with this to get GitHub Contribution doc in: https://gerrit.hyperledger.org/r/c/fabric/+/33817

davidkhala (Sat, 12 Oct 2019 04:24:16 GMT):
Will PR about document changes still be accepted at this moment on gerrit？

BrettLogan (Sat, 12 Oct 2019 04:55:19 GMT):
They will

davidkhala (Sat, 12 Oct 2019 06:41:18 GMT):
https://gerrit.hyperledger.org/r/c/fabric/+/33956 a kafka migration guideline fixing.

mastersingh24 (Tue, 15 Oct 2019 19:42:22 GMT):
merged in release-1.4 and I cherry-picked it to master as well

shitaibin (Fri, 18 Oct 2019 23:52:09 GMT):
https://gerrit.hyperledger.org/r/c/fabric/+/34010 a typo errors fixing in documents, needs +2 review

baohua (Thu, 24 Oct 2019 21:19:56 GMT):
Available for review for 10 days, please help review, thanks! https://gerrit.hyperledger.org/r/#/c/fabric/+/33276/

davidkhala (Sun, 27 Oct 2019 05:26:16 GMT):
! [remote rejected] HEAD -> refs/for/master (prohibited by Gerrit: project state does not permit write) we see this on fabric-node-chaincode, is it freezed to commit?

BrettLogan (Sun, 27 Oct 2019 06:21:52 GMT):
@davidkhala per the email from the Fabric mailing list, chaincode node has moved to GitHub and away from Gerrit. Please open your Gerrit CR as GitHub Pull Request instead

rjones (Sun, 27 Oct 2019 18:26:03 GMT):
@SamYuan1990 https://chat.hyperledger.org/channel/general?msg=kSnwZcKWtZrErBEbw

SamYuan1990 (Sun, 27 Oct 2019 18:26:03 GMT):
Has joined the channel.

rjones (Sun, 27 Oct 2019 18:26:09 GMT):
I added some reviewers

BrettLogan (Sun, 27 Oct 2019 20:21:25 GMT):
@SamYuan1990 you should have amended your original CR instead of putting a separate change in to fix the linting error. Doing it the way you did will cause the merge to fail in CI with the same linting error, as well as making git bisects harder to achieve. Please pull your latest commit and squash them into a single CR

BrettLogan (Sun, 27 Oct 2019 20:21:25 GMT):
@SamYuan1990 you should have amended your original CR instead of putting a separate change in to fix the linting error. Doing it the way you did will cause the merge to fail in CI with the same linting error, as well as making got bisects easier to achieve. Please pull your latest commit and squash them into a single CR

SamYuan1990 (Mon, 28 Oct 2019 04:25:17 GMT):
thanks @rjones , @BrettLogan , I just squash the commits and push the CR again, in progress of jenkins workfolow.

SamYuan1990 (Tue, 29 Oct 2019 12:51:48 GMT):
cloud some help with https://github.com/hyperledger/fabric-chaincode-go/pull/9?

baohua (Wed, 06 Nov 2019 04:45:16 GMT):
One more approval needed, thanks! https://gerrit.hyperledger.org/r/#/c/fabric/+/33276/

rameshthoomu (Thu, 07 Nov 2019 19:44:59 GMT):
One more +2 needed https://gerrit.hyperledger.org/r/#/c/fabric/+/34158/

rjones (Fri, 15 Nov 2019 21:20:03 GMT):
This is trivial, in prep for the move to GitHub: https://gerrit.hyperledger.org/r/#/c/fabric/+/34414/

rameshthoomu (Mon, 18 Nov 2019 18:20:54 GMT):
Need one more +2 on this https://gerrit.hyperledger.org/r/#/c/fabric/+/34158/

rjones (Wed, 27 Nov 2019 20:24:41 GMT):
For your consideration (disabling Stalebot on fabric-ca): https://github.com/hyperledger/fabric-ca/pull/71

SamYuan1990 (Sun, 01 Dec 2019 12:54:03 GMT):
can someone help with https://github.com/hyperledger/fabric/pull/334?

joe-alewine (Thu, 19 Dec 2019 02:04:51 GMT):
Easy doc change: https://hyperledger-fabric.readthedocs.io/en/master/enable_cc_lifecycle.html

joe-alewine (Thu, 19 Dec 2019 17:48:54 GMT):
Another easy doc change (building on an earlier one): https://github.com/hyperledger/fabric/pull/437

rjones (Sat, 21 Dec 2019 18:17:07 GMT):
Adding a maintainer: https://github.com/hyperledger/fabric-sdk-node/pull/83

pandrejko (Fri, 03 Jan 2020 20:41:14 GMT):
Easy doc change: https://jira.hyperledger.org/browse/FAB-17235

pandrejko (Fri, 03 Jan 2020 20:41:14 GMT):
Easy doc change:https://github.com/hyperledger/fabric/pull/451

rjones (Tue, 07 Jan 2020 19:07:17 GMT):
I would appreciate some eyes on this change: https://github.com/hyperledger/homebrew-fabric/pull/11 if I'm wrong in renaming the older Formula files, I'll undo that part

smithbk (Thu, 09 Jan 2020 20:24:17 GMT):
Has left the channel.

rjones (Thu, 09 Jan 2020 23:01:07 GMT):
Could I get this reviewed? https://github.com/hyperledger/fabric-samples/pull/95

rjones (Thu, 09 Jan 2020 23:02:54 GMT):
Also, I have a +1 on this - could I get a merge? https://github.com/hyperledger/homebrew-fabric/pull/11

pandrejko (Mon, 13 Jan 2020 13:14:48 GMT):
Update to the MSP Key Concepts doc is ready for broader review now: https://github.com/hyperledger/fabric/pull/307

rjones (Tue, 14 Jan 2020 19:02:33 GMT):
https://github.com/hyperledger/fabric-chaintool/pull/6 simple license fix

negupta (Wed, 15 Jan 2020 15:49:31 GMT):
There are quite a few outstanding PRs in the fabric samples directory. I have two out:

negupta (Wed, 15 Jan 2020 15:50:13 GMT):
small update to the interest rate readme: https://github.com/hyperledger/fabric-samples/pull/96

negupta (Wed, 15 Jan 2020 15:51:13 GMT):
Bug fixes and features for the test network: https://github.com/hyperledger/fabric-samples/pull/91

bestbeforetoday (Thu, 16 Jan 2020 11:39:56 GMT):
Please could I get a review of this update to the Wallet overview in the Developing Applications section of the docs: https://github.com/hyperledger/fabric/pull/506

pandrejko (Thu, 23 Jan 2020 19:44:44 GMT):
Would be good to get some more Maintainers on this one: (The new Documentation merge process) https://github.com/hyperledger/fabric/pull/526

rjones (Thu, 23 Jan 2020 21:03:14 GMT):
@pandrejko small change needed: https://github.com/hyperledger/fabric/pull/526

rjones (Fri, 24 Jan 2020 04:29:08 GMT):
It would be nice to get more maintainers to vote here: https://github.com/hyperledger/fabric/pull/526 https://chat.hyperledger.org/channel/fabric-pr-review?msg=oPfPaDb6A5dGaFQg6

tatsu-sato (Mon, 27 Jan 2020 18:52:17 GMT):
Has joined the channel.

tatsu-sato (Mon, 27 Jan 2020 19:21:37 GMT):
Could you please review this CR. https://github.com/hyperledger/fabric-protos/pull/25 This is a sub-task of FAB-17434. I hope that merging FAB-17434 into v2.0.0 will help Fabric admin to manage Fabric with new chaincode lifecycle.

tatsu-sato (Mon, 27 Jan 2020 19:21:37 GMT):
Could you please review this CR. https://github.com/hyperledger/fabric-protos/pull/25 This is a sub-task of FAB-17401. I hope that merging FAB-17401 into v2.0.0 will help Fabric admin to manage Fabric with new chaincode lifecycle.

awjh (Thu, 30 Jan 2020 15:59:43 GMT):
@BrettLogan if you get chance could you merge the PR matthew has approved in fabric-test for the chaincode integration tool? I would also appreciate it if you got a chance to review my PR for adding a release process for the integration tool. Thanks :) https://github.com/hyperledger/fabric-test/pull/74 https://github.com/hyperledger/fabric-test/pull/75

awjh (Mon, 03 Feb 2020 12:30:20 GMT):
@BrettLogan sorry to be a bother again but could you merge PRs 77 and 79 in fabric-test for me? The latter is blocking Go from releasing as ideally we want to have the integration tests up and running before we go https://github.com/hyperledger/fabric-test/pull/77 https://github.com/hyperledger/fabric-test/pull/79

BrettLogan (Mon, 03 Feb 2020 12:58:27 GMT):
@awjh merged. I will try to get the automation setup today so you and Matt can take ownership of merging PR's

awjh (Mon, 03 Feb 2020 12:58:42 GMT):
Brilliant - Thanks :)

rjones (Mon, 03 Feb 2020 16:55:47 GMT):
@BrettLogan the reason https://github.com/hyperledger/fabric/pull/620 won't build is Nexus no longer exists - does it matter?

BrettLogan (Mon, 03 Feb 2020 17:04:34 GMT):
It doesn't matter. It's not tested anyway But I do have a PR out to fix the problem

rjones (Mon, 03 Feb 2020 17:08:24 GMT):
well, I mean, it's 1.4

rjones (Mon, 03 Feb 2020 17:08:40 GMT):
should this change also be on 2.0?

BrettLogan (Mon, 03 Feb 2020 17:40:00 GMT):
No. The artifact it was grabbing from Nexus was for the old car chaincode type which we removed from 2.0

BrettLogan (Mon, 03 Feb 2020 17:40:30 GMT):
there is a reference to Nexus in the makefile in master branch but it doesn't do anything I just need to remove the line

BrettLogan (Mon, 03 Feb 2020 17:40:30 GMT):
there is a reference to Nexus in the make file in master branch but it doesn't do anything I just need to remove the line

MHBauer (Tue, 04 Feb 2020 19:45:21 GMT):
Has joined the channel.

rjones (Tue, 04 Feb 2020 19:58:01 GMT):
https://github.com/hyperledger/fabric-chaincode-node/pull/84 this adds a README.md so that people who end up at the git repo on the `gh-pages` branch have something to click.

troyronda (Fri, 14 Feb 2020 15:07:24 GMT):
FABG-933 Gateway package for Go SDK https://github.com/hyperledger/fabric-sdk-go/pull/51

rjones (Wed, 19 Feb 2020 21:38:20 GMT):
Trivial one: https://github.com/hyperledger/homebrew-fabric/pull/12

rjones (Wed, 26 Feb 2020 16:33:05 GMT):
https://github.com/hyperledger/homebrew-fabric/pull/13 please

pandrejko (Thu, 27 Feb 2020 13:34:27 GMT):
@dave.enyeart Could we get this Fabric CA doc PR merged: https://github.com/hyperledger/fabric-ca/pull/93#pullrequestreview-365681058

dave.enyeart (Thu, 27 Feb 2020 14:33:00 GMT):
@pandrejko thanks for poking since I don't often check CA backlog. I added one more comment. Also, do you want to setup doc maintainers on fabric-ca as well?

rjones (Thu, 27 Feb 2020 15:19:23 GMT):
@dave.enyeart @pandrejko if you do set up a new group over there, let me know

pandrejko (Thu, 27 Feb 2020 15:25:58 GMT):
@dave.enyeart

pandrejko (Thu, 27 Feb 2020 15:25:58 GMT):
@dave.enyeart @rjones I thought Chris G already submitted a PR for that. I'll check and submit it if it is not there

rjones (Thu, 27 Feb 2020 15:26:42 GMT):
https://github.com/hyperledger/homebrew-fabric/pull/13 if I could get this merged thanks

rjones (Thu, 27 Feb 2020 15:39:13 GMT):
@pandrejko https://github.com/hyperledger/fabric-ca/pull/107

rjones (Thu, 27 Feb 2020 15:46:53 GMT):
GitHub is having turbulence

rjones (Mon, 02 Mar 2020 18:32:39 GMT):
Create doc maintainers group for fabric-ca: https://github.com/hyperledger/fabric-ca/pull/107

ahmedsajid (Wed, 04 Mar 2020 13:57:51 GMT):
Has joined the channel.

ahmedsajid (Wed, 04 Mar 2020 13:59:03 GMT):
Good Morning. Can I get someone to review this https://github.com/hyperledger/fabric/pull/769 ?

BrettLogan (Wed, 04 Mar 2020 14:30:44 GMT):
@ahmedsajid reviews are a little light this week, the Hyperledger Global Forum is taking place in Phoenix and the vast majority of project maintainers are there

ahmedsajid (Wed, 04 Mar 2020 14:31:17 GMT):
Ah ok. that makes sense. Thanks @BrettLogan

ahmedsajid (Tue, 10 Mar 2020 17:50:15 GMT):
Hi, PRs are still open for review from maintainers. https://github.com/hyperledger/fabric/pull/769 (release-1.4) https://github.com/hyperledger/fabric/pull/821 (release-2.0) https://github.com/hyperledger/fabric/pull/822 (master) JIRA: https://jira.hyperledger.org/browse/FAB-17517

ahmedsajid (Tue, 10 Mar 2020 17:50:15 GMT):
Hi, PRs are still pending review from maintainers. https://github.com/hyperledger/fabric/pull/769 (release-1.4) https://github.com/hyperledger/fabric/pull/821 (release-2.0) https://github.com/hyperledger/fabric/pull/822 (master) JIRA: https://jira.hyperledger.org/browse/FAB-17517

ahmedsajid (Tue, 10 Mar 2020 17:50:15 GMT):
Hi, PRs are pending review from maintainers. https://github.com/hyperledger/fabric/pull/769 (release-1.4) https://github.com/hyperledger/fabric/pull/821 (release-2.0) https://github.com/hyperledger/fabric/pull/822 (master) JIRA: https://jira.hyperledger.org/browse/FAB-17517

tatsu-sato (Wed, 11 Mar 2020 23:08:05 GMT):
Could you please review this CR. https://github.com/hyperledger/fabric-protos/pull/25 This is a sub-task of FAB-17401. I hope that merging FAB-17401 into v2.0.x will help Fabric admin to manage Fabric with new chaincode lifecycle. On JIRA, the status is “IN CR REVIEW”. However, on github, it seems that the reviewers have been unassigned from this CR.

rjones (Wed, 11 Mar 2020 23:13:46 GMT):
@tatsu-sato I just added a couple. Your branch is out of date - could you rebase to the tip of the branch and force push?

tatsu-sato (Wed, 11 Mar 2020 23:33:09 GMT):
@rjones Thank you for your help. I rebased and forced push just now.

ahmedsajid (Tue, 24 Mar 2020 15:20:54 GMT):
Hi All. Hope everyone is doing OK. I pushed 2 PRs to fabric-ca. This has already been merged in fabric repo. https://github.com/hyperledger/fabric-ca/pull/113 https://github.com/hyperledger/fabric-ca/pull/112

rjones (Fri, 27 Mar 2020 00:56:22 GMT):
Could we get a review on https://github.com/hyperledger/fabric-protos/pull/25 please?

rjones (Fri, 03 Apr 2020 17:04:58 GMT):
please take a look at this CA PR: https://github.com/hyperledger/fabric-ca/pull/118

matanyahu (Mon, 06 Apr 2020 17:46:27 GMT):
Has left the channel.

lehors (Mon, 20 Apr 2020 16:19:35 GMT):
could somebody please merge https://github.com/hyperledger/fabric-samples/pull/164 so that the CI works again? @dave.enyeart

rjones (Wed, 22 Apr 2020 11:40:49 GMT):
Could I get https://github.com/hyperledger/fabric-ca/pull/138 merged to unblock CI? thanks.

rjones (Wed, 22 Apr 2020 11:40:49 GMT):
Could I get https://github.com/hyperledger/fabric-ca/pull/141 merged to unblock CI? thanks.

rjones (Wed, 22 Apr 2020 11:41:30 GMT):
@sykesm @mastersingh24 ^^^

BrettLogan (Wed, 22 Apr 2020 15:55:58 GMT):
Done, and everything was adjusted, it should all be working correctly again, thanks Ry

lehors (Tue, 28 Apr 2020 18:03:43 GMT):
hi folks, I've got a bunch of PRs against fabric-samples waiting for some attention, please check them out if you have a moment: https://github.com/hyperledger/fabric-samples/pulls

lehors (Tue, 28 Apr 2020 18:10:48 GMT):
also, I have to say that I find it rather worrisome to see that PRs related to https://jira.hyperledger.org/browse/FAB-17401 have yet to be reviewed

lehors (Tue, 28 Apr 2020 18:11:02 GMT):
this is really bad community building folks

lehors (Tue, 28 Apr 2020 18:12:03 GMT):
those PRs were posted over 2 months ago!

rjones (Mon, 11 May 2020 15:15:52 GMT):
@C0rWin @jtonline could I get this merged? thanks. https://github.com/hyperledger/fabric-chaincode-java/pull/109

nkl199 (Mon, 01 Jun 2020 13:56:54 GMT):
Has left the channel.

dtomczyk (Thu, 11 Jun 2020 15:49:29 GMT):
Has joined the channel.

SamYuan1990 (Fri, 12 Jun 2020 12:23:03 GMT):
em... I am not sure if I found a bug or not, https://github.com/hyperledger/fabric-samples/pull/207 can someone please take a look at?

davidkhala (Sat, 13 Jun 2020 03:13:25 GMT):
https://github.com/hyperledger/fabric-sdk-node/pull/239 ready for review

BrunoVavala (Thu, 25 Jun 2020 18:38:01 GMT):
Has joined the channel.

SamYuan1990 (Tue, 30 Jun 2020 13:16:07 GMT):
hi， can anyone help with https://github.com/hyperledger/fabric-samples/pull/217?

cbf (Thu, 20 Aug 2020 14:30:10 GMT):
Has left the channel.

msteiner (Wed, 02 Sep 2020 19:39:00 GMT):
Has joined the channel.

tongli (Wed, 16 Sep 2020 12:13:16 GMT):
Has left the channel.

BrunoVavala (Tue, 13 Oct 2020 23:29:13 GMT):
Has left the channel.

troyronda (Wed, 28 Oct 2020 17:40:43 GMT):
Has left the channel.

SamYuan1990 (Sun, 07 Feb 2021 07:50:59 GMT):
hello, can anyone help with https://github.com/hyperledger/fabric-samples/pull/412?

SamYuan1990 (Mon, 08 Feb 2021 15:44:32 GMT):
hi nikhil550, lindluni, it's nearly mid night for my timezone, I hope https://github.com/hyperledger/fabric-samples/pull/412 it works if there any change request, I will follow up tomorrow local time. Thx.

SamYuan1990 (Mon, 08 Feb 2021 15:44:32 GMT):
hi @NikhilGupta , @BrettLogan, it's nearly mid night for my timezone, I hope https://github.com/hyperledger/fabric-samples/pull/412 it works if there any change request, I will follow up tomorrow local time. Thx.

rjones (Mon, 08 Feb 2021 15:48:59 GMT):
Howdy. I propose archiving `fabric-baseimage` since it's been two years since 1.4 was declared LTS. https://github.com/hyperledger/fabric-baseimage/pull/14

davidkhala (Fri, 23 Apr 2021 06:52:36 GMT):
ready to review https://github.com/hyperledger/fabric-sdk-node/pull/449

davidkhala (Fri, 23 Apr 2021 06:52:36 GMT):
sdk-node: prune fabric-client as devDependency as no longer LTS later, ready to review https://github.com/hyperledger/fabric-sdk-node/pull/449

jimthematrix (Mon, 07 Jun 2021 16:00:59 GMT):
Has left the channel.