rjones (Tue, 10 Jul 2018 00:08:43 GMT):
ChrisSpanton
rjones (Tue, 10 Jul 2018 00:09:19 GMT):
use your powers ~*for*~ ~*good*~ to invite people as you wish
rjones (Tue, 10 Jul 2018 00:10:18 GMT):
Has left the channel.
kelly_ (Tue, 10 Jul 2018 00:11:57 GMT):
Has joined the channel.
kelly_ (Tue, 10 Jul 2018 00:12:07 GMT):
:wave:
kelly_ (Tue, 10 Jul 2018 00:12:59 GMT):
@boydjohnson @dplumb @dan
boydjohnson (Tue, 10 Jul 2018 00:12:59 GMT):
Has joined the channel.
dplumb (Tue, 10 Jul 2018 00:12:59 GMT):
Has joined the channel.
kelly_ (Tue, 10 Jul 2018 00:14:08 GMT):
@grkvlt and @mikezaccardo
grkvlt (Tue, 10 Jul 2018 00:14:09 GMT):
Has joined the channel.
mikezaccardo (Tue, 10 Jul 2018 00:14:09 GMT):
Has joined the channel.
Dan (Tue, 10 Jul 2018 00:16:06 GMT):
Has joined the channel.
Dan (Tue, 10 Jul 2018 00:16:30 GMT):
thanks @rjones .. Even though @kelly_ tried to hide this from me. ;)
rjones (Tue, 10 Jul 2018 00:16:30 GMT):
Has joined the channel.
rjones (Tue, 10 Jul 2018 00:17:16 GMT):
I offered to fix your nick in Minneapolis :)
rjones (Tue, 10 Jul 2018 00:17:31 GMT):
Dan
ChrisSpanton (Tue, 10 Jul 2018 00:18:39 GMT):
:laughing:
Dan (Tue, 10 Jul 2018 00:18:43 GMT):
Why would I want more DMs :D
Dan (Tue, 10 Jul 2018 00:18:43 GMT):
Why would I want more DMs? :D
ChrisSpanton (Tue, 10 Jul 2018 00:18:55 GMT):
^
ChrisSpanton (Tue, 10 Jul 2018 00:18:56 GMT):
that
kodonnel (Mon, 16 Jul 2018 16:33:30 GMT):
Has joined the channel.
zath (Wed, 25 Jul 2018 07:22:38 GMT):
Has joined the channel.
amundson (Thu, 26 Jul 2018 05:37:58 GMT):
Has joined the channel.
mtn206 (Tue, 07 Aug 2018 17:03:50 GMT):
Has joined the channel.
praspadm (Thu, 09 Aug 2018 09:40:07 GMT):
Has joined the channel.
jon_s (Thu, 09 Aug 2018 10:30:03 GMT):
Has joined the channel.
lcinacio (Fri, 10 Aug 2018 18:01:12 GMT):
Has joined the channel.
Jeankevi (Sat, 11 Aug 2018 00:44:54 GMT):
Has joined the channel.
kodonnel (Mon, 13 Aug 2018 16:46:29 GMT):
Is this the right channel to ask for a review of some pull requests on sawtooth-next-directory? Just some minor changes for easing builds https://github.com/hyperledger/sawtooth-next-directory/pull/15 https://github.com/hyperledger/sawtooth-next-directory/pull/14
agoldingay (Wed, 15 Aug 2018 17:40:20 GMT):
Has joined the channel.
agoldingay (Wed, 15 Aug 2018 17:43:04 GMT):
Hello, I am T-Mobile scrum master assigned to this project. Two things: need access to create a 'Project'. Hoping this chat thread can help me get started.
agoldingay (Wed, 15 Aug 2018 17:44:09 GMT):
second ask, i want to test an issue so it can be exported to Aha then integrated in Rally.
agoldingay (Wed, 15 Aug 2018 19:05:39 GMT):
@rjones Can you tell me who the owner for this URL is? Hoping to start a project
agoldingay (Wed, 15 Aug 2018 19:06:19 GMT):
URL: https://github.com/hyperledger/sawtooth-next-directory
kelly_ (Wed, 15 Aug 2018 19:19:03 GMT):
@Dan ^^
ChrisSpanton (Wed, 15 Aug 2018 19:57:36 GMT):
Thanks @kelly_ / @Dan! We're spinning into high gear, expect some noise :)
ChrisSpanton (Wed, 15 Aug 2018 20:03:57 GMT):
@kodonnel - I reviewd and approved the changes, as well as adding additional reviewers, that should kick-start things!
Dan (Wed, 15 Aug 2018 20:31:40 GMT):
@agoldingay not sure what you are asking but happy to try to help. We use Jira for managing most projects at hyperledger. You might want to coordinate with @mfford on how we use jira for sawtooth.
mfford (Wed, 15 Aug 2018 20:31:40 GMT):
Has joined the channel.
agoldingay (Wed, 15 Aug 2018 20:46:49 GMT):
@Dan @ChrisSpanton took care of it for me. He's my PO. Awesome, possom!
jon_s (Thu, 16 Aug 2018 13:02:00 GMT):
Has left the channel.
Gabe (Mon, 20 Aug 2018 04:16:12 GMT):
Has joined the channel.
kthblmfld (Mon, 20 Aug 2018 20:19:18 GMT):
Has joined the channel.
AlyOwens13 (Mon, 20 Aug 2018 21:29:49 GMT):
Has joined the channel.
agoldingay (Mon, 20 Aug 2018 22:02:14 GMT):
Hello #sawtooth-next-directory followers! We at T-Mobile are spinning up this project. Our first stand up is tomorrow, Tuesday, August 20th, 11:30-12pm PST. Those interested are welcome to join. https://zoom.us/j/2738727621
ChrisSpanton (Mon, 20 Aug 2018 22:24:48 GMT):
@agoldingay I think I can make the stand up tomorrow, despite my previous decline. Looking forward to kicking off this process, and hoping to see anyone from the community feel free to join for a day, a sprint, or a lifetime.
adamgering (Mon, 20 Aug 2018 23:50:27 GMT):
Has joined the channel.
ncriss (Tue, 21 Aug 2018 15:59:34 GMT):
Has joined the channel.
kthblmfld (Tue, 21 Aug 2018 19:04:48 GMT):
Hello all
devsatishm (Tue, 21 Aug 2018 19:05:35 GMT):
Has joined the channel.
danintel (Tue, 21 Aug 2018 20:27:35 GMT):
Has joined the channel.
danintel (Tue, 21 Aug 2018 20:30:05 GMT):
I just cloned the github repo and typed `docker-compose up` on Ubuntu LTS 16.04.5:
`Status: Downloaded newer image for rethinkdb:2.3
ERROR: no such image: rbac-tp-production:: invalid reference format`
Any ideas?
danintel (Tue, 21 Aug 2018 20:30:05 GMT):
I just cloned the github repo and typed `docker-compose up` on Ubuntu LTS 16.04.5:
```. . . Status: Downloaded newer image for rethinkdb:2.3
ERROR: no such image: rbac-tp-production:: invalid reference format```
Any ideas?
mtn206 (Tue, 21 Aug 2018 21:25:21 GMT):
Hi Dan - have you tried running `docker-compose down` command? If not, try to run that command and run the `docker-compose up` command again.
kthblmfld (Tue, 21 Aug 2018 22:40:01 GMT):
I am seeing the same
kthblmfld (Tue, 21 Aug 2018 22:47:27 GMT):
No change after running docker-compose up ... down, also not with adding -f docker-compose.yaml
danintel (Tue, 21 Aug 2018 23:33:57 GMT):
OK--my mistake, but thanks for the tips. I now created `server/config.py` from `config.py.example` unmodified (I don't care about insecure keys yet). I get a warning and the same error after` docker-compose down` and `docker-compose up` :
```$ docker-compose down
WARNING: The ISOLATION_ID variable is not set. Defaulting to a blank string.
Removing network sawtooth-next-directory_default
$ docker-compose up
WARNING: The ISOLATION_ID variable is not set. Defaulting to a blank string.
Creating network "sawtooth-next-directory_default" with the default driver
ERROR: no such image: rbac-tp-production:: invalid reference format```
danintel (Tue, 21 Aug 2018 23:33:57 GMT):
OK--my mistake, but thanks for the tips. I now created `server/config.py` from `config.py.example` unmodified (I don't care about insecure keys yet). I get a warning and the same error after `docker-compose down` and `docker-compose up` :
```$ docker-compose down
WARNING: The ISOLATION_ID variable is not set. Defaulting to a blank string.
Removing network sawtooth-next-directory_default
$ docker-compose up
WARNING: The ISOLATION_ID variable is not set. Defaulting to a blank string.
Creating network "sawtooth-next-directory_default" with the default driver
ERROR: no such image: rbac-tp-production:: invalid reference format```
yunhangc (Wed, 22 Aug 2018 16:05:58 GMT):
Has joined the channel.
danintel (Wed, 22 Aug 2018 18:26:19 GMT):
Just a data point update. I followed the instructions for the Dev containers and get the same error:
```$ docker-compose -f docker-compose-de
v.yaml up
WARNING: The ISOLATION_ID variable is not set. Defaulting to a blank string.
Creating network "sawtooth-next-directory_default" with the default driver
Pulling rethink (rethinkdb:2.3)...
2.3: Pulling from library/rethinkdb . . . (omitted "Pull complete" messages) . . .
Digest: sha256:58c8066d8292f46bbf9303bb35e6e7ec72d1e11d7ffcd721f83844bed87baba4
Status: Downloaded newer image for rethinkdb:2.3
ERROR: no such image: rbac-tp-dev:: invalid reference format```
mtn206 (Wed, 22 Aug 2018 23:37:29 GMT):
Hello @danintel - I found a fix for the issue and created pull request #21 to apply the fix to the repo. As you can see, you are receiving the warning `The ISOLATION_ID variable is not set. Defaulting to a blank string.` It appears the the repo was missing the .env file. The .env file sets the environment variables for the project and because the file was missing, the ISOLATION_ID variable was not set and defaulted to a blank string. I have added the .env file in PR#21 and once the PR has merged with master, you should be able to successfully run `docker-compose up` command.
alchmeina (Thu, 23 Aug 2018 14:17:06 GMT):
Has joined the channel.
danintel (Thu, 23 Aug 2018 16:21:10 GMT):
@mtn206. That works for me. Thanks. Here's a workaround until it's integrated, for the benefit of others:
```cd /path/to/sawtooth-next-directory
echo "ISOLATION_ID=latest">.env```
kthblmfld (Thu, 23 Aug 2018 23:14:57 GMT):
Got it. Thanks!
agoldingay (Fri, 24 Aug 2018 19:40:20 GMT):
URL and dial-in for daily stand-up starting Monday, 8/27, 11:30-12noon PST. https://zoom.us/j/2738727621
BretStateham (Fri, 24 Aug 2018 21:59:01 GMT):
Has joined the channel.
agoldingay (Mon, 27 Aug 2018 15:55:34 GMT):
Notification: Cancelled - Standup for today, Mon, 8/27/18. Next standup Tue, 8/28 11:30am PST https://zoom.us/j/2738727621
ChrisSpanton (Mon, 27 Aug 2018 16:00:43 GMT):
Thanks @agoldingay! Team - as we get a backlog filled into the project, we'll keep a regular daily cadence. Today we're cancelling to do some planning and break down features into backlog items.
ChrisSpanton (Mon, 27 Aug 2018 16:01:33 GMT):
Tomorrow morning @ 9:00 AM PST, we'll be holding an architecture and design session which, as with all our efforts on this project, is open to the community.
ChrisSpanton (Mon, 27 Aug 2018 16:05:46 GMT):
We'll have our UI/UX team driving the conversation, and working through data flows to accomplish the goal of understanding individual backlog items. Join by phone at 1-844-202-5500 Conference ID: 41692573
agoldingay (Tue, 28 Aug 2018 19:31:29 GMT):
thanks for attending today's standup. We'll meet again tomorrow. same time and dial in. :grinning:
agoldingay (Tue, 28 Aug 2018 20:08:51 GMT):
As a follow up to a topic during today's standup: we are reviewing the current contribution guidelines to ensure we're following best practices.
adamgering (Tue, 28 Aug 2018 22:52:40 GMT):
A note, the integration tests require installation of Python 3.x and the PyYAML module (pip3 install PyYAML), if not already installed.
kthblmfld (Tue, 28 Aug 2018 22:56:16 GMT):
Yep. We sould probably update the README to include the specific required dependencies. I see this note above the test section:
kthblmfld (Tue, 28 Aug 2018 22:56:16 GMT):
Yep. We should probably update the README to include the specific required dependencies. I see this note above the test section:
kthblmfld (Tue, 28 Aug 2018 22:56:19 GMT):
\* _Dependencies that may need to be locally installed include Sawtooth
dependencies like the`sawtooth_sdk`, as well as some `pip3` modules._
kthblmfld (Tue, 28 Aug 2018 22:57:00 GMT):
But I don't recall needing to install sawtooth_sdk.
ChrisSpanton (Wed, 29 Aug 2018 16:17:12 GMT):
It sounds a lot like you just volunteered @kthblmfld :wink: Do we need to create an issue to make sure this is tracked?
kthblmfld (Wed, 29 Aug 2018 16:56:41 GMT):
@ChrisSpanton Yes, please. We hit a few setup steps yesterday and will need to assemble them into meaningful documentation.
kthblmfld (Wed, 29 Aug 2018 17:06:16 GMT):
Creating issue...
adamgering (Thu, 30 Aug 2018 00:07:09 GMT):
It would be great to do a roll call.
adamgering (Thu, 30 Aug 2018 00:07:19 GMT):
Adam Gering - contributor
ChrisSpanton (Thu, 30 Aug 2018 15:06:57 GMT):
Chris Spanton: T-Mobile Product Owner
mtn206 (Thu, 30 Aug 2018 16:56:59 GMT):
Michael Nguyen - Contributor
kthblmfld (Thu, 30 Aug 2018 17:11:29 GMT):
Keith Bloomfield - Contributor
adamgering (Thu, 30 Aug 2018 18:42:38 GMT):
With regards to the integration tests:
bin/run_docker_test integration_tests/blockchain/docker-compose.yaml
bin/run_docker_test integration_tests/api/docker-compose.yaml
adamgering (Thu, 30 Aug 2018 18:43:29 GMT):
I am getting this error on some images. I'm debugging why, but if anyone knows what may cause this?
ImportError: No module named 'rbac_processor.protobuf'
adamgering (Thu, 30 Aug 2018 19:03:05 GMT):
FYI, "bin/build -p" must also be run prior to the integration tests. I'll add that to the docs.
sureshtedla (Fri, 31 Aug 2018 17:32:21 GMT):
Has joined the channel.
yunhangc (Fri, 31 Aug 2018 17:47:18 GMT):
putting in a new PR to fix request manager change confirmation.
yunhangc (Fri, 31 Aug 2018 17:48:10 GMT):
the fix will contain all the changes of PR18. so we could merge that first before we merge the new fix
kthblmfld (Fri, 31 Aug 2018 20:57:32 GMT):
@yunhangc I just merged PR18 with comment regarding @adamgering having no review access at this time. We have iterated on the PR and approved verbally in the meantime.
kthblmfld (Fri, 31 Aug 2018 20:57:32 GMT):
@yunhangc I just merged PR18 with comment regarding @adamgering having no review access at this time. We have iterated on the PR and approved verbally in the interim.
kthblmfld (Tue, 04 Sep 2018 18:52:46 GMT):
I am seeing lots of "Copyright 2017 *** Corp.." headers on files and wondering if these are simply generated by IDE, copied over from Sawtooth-core, or otherwise required for some reason.
kthblmfld (Tue, 04 Sep 2018 18:53:32 GMT):
I am going to skip on the copyright and licensing in every single file for the time being.
Dan (Tue, 04 Sep 2018 20:26:17 GMT):
I've seen before where people have just copied files to get started and incorrectly kept the intel copyright header.
You can look at the git history for a particular file though and see who committed it. If it came from a t-mobile address for example, then the banner should be updated.
The Linux Foundation gave guidance in the spring, that for new files you are welcome to use something like "Hyperledger Sawtooth project & maintainers" rather than specific companies. We asked for further clarification and I think we expect some update in the next few weeks.
agoldingay (Tue, 04 Sep 2018 23:15:33 GMT):
Hi folks! FYI, I just pushed a issue template for use on NEXT project
agoldingay (Tue, 04 Sep 2018 23:25:29 GMT):
deleted template
kthblmfld (Wed, 05 Sep 2018 03:13:21 GMT):
Thanks @Dan. Please keep us posted when the update comes in so we can refactor the headers.
kthblmfld (Wed, 05 Sep 2018 03:13:21 GMT):
Thanks @Dan. Please keep us posted when the update comes in and we will refactor the headers.
adamgering (Wed, 05 Sep 2018 18:24:10 GMT):
Usernames and the ability to log in via username instead of userId was a great update. That goodness for that.
devsatishm (Wed, 05 Sep 2018 18:57:44 GMT):
@agoldingay I don't have access to edit the issue or assign it to myself within the github repo. Can you fix this for me ? Thanks!
AlyOwens13 (Wed, 05 Sep 2018 19:58:52 GMT):
hi guys, I'm Aly Owens, I work with @ChrisSpanton and @agoldingay. Could you, please, add me as a contributor or moderator? I would need to integrate github with Aha! app to track all our progress and create roadmaps.
kthblmfld (Wed, 05 Sep 2018 22:03:36 GMT):
Hi Aly, do you have a github handle/id?
kthblmfld (Wed, 05 Sep 2018 22:14:04 GMT):
@devsatishm What is your git id?
devsatishm (Wed, 05 Sep 2018 22:14:30 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=Yepwbhbw23maa55k9) @kthblmfld devsatishm
devsatishm (Wed, 05 Sep 2018 22:14:43 GMT):
Thanks Keith.
kthblmfld (Wed, 05 Sep 2018 22:15:11 GMT):
Uhoh I was afraid of that. Ok
agoldingay (Wed, 05 Sep 2018 22:19:39 GMT):
@adamgering I emailed you the list with everybody and their Git IDs
kthblmfld (Wed, 05 Sep 2018 22:34:13 GMT):
Sorry folks. We are still experiencing some issues in adding contributors to the group :(
kthblmfld (Wed, 05 Sep 2018 22:55:18 GMT):
Renamed the team to match the repo: https://github.com/orgs/hyperledger/teams/sawtooth-next-contributors
devsatishm (Wed, 05 Sep 2018 23:29:56 GMT):
@kthblmfld Should we reach to someone to get the access issues resolved?
kthblmfld (Wed, 05 Sep 2018 23:40:16 GMT):
@devsatishm Adam has the list and is hashing through with an owner who is currently juggling a bunch of requests. Please stand by
adamgering (Wed, 05 Sep 2018 23:49:14 GMT):
Can everyone who needs access request to join https://github.com/orgs/hyperledger/teams/sawtooth-next-contributors/members ?
AlyOwens13 (Thu, 06 Sep 2018 00:20:06 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=ucmdS7F7Bs548vqyw) @kthblmfld yes, codingalyona
AlyOwens13 (Thu, 06 Sep 2018 00:21:35 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=eTZLfQFA7him797zM) @adamgering 404 error message
chimpuz (Thu, 06 Sep 2018 02:45:35 GMT):
Has joined the channel.
agoldingay (Thu, 06 Sep 2018 16:44:37 GMT):
All, starting today, Thur, 9/6/18, daily standup is via Skype: https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L dial in: 1-844-202-5500,,4191791129#
kthblmfld (Thu, 06 Sep 2018 16:45:52 GMT):
@AlyOwens13 have you requested access to the repo yet?: https://github.com/orgs/hyperledger/teams/sawtooth-next-contributors/members ?
AlyOwens13 (Thu, 06 Sep 2018 16:47:47 GMT):
Capture.PNG
AlyOwens13 (Thu, 06 Sep 2018 16:47:57 GMT):
this is what I get when I click on the link
kthblmfld (Thu, 06 Sep 2018 16:48:29 GMT):
ok working on it
adamgering (Thu, 06 Sep 2018 16:48:46 GMT):
Can you see this: https://github.com/orgs/hyperledger/teams ?
AlyOwens13 (Thu, 06 Sep 2018 16:50:31 GMT):
yes
adamgering (Thu, 06 Sep 2018 17:44:43 GMT):
Option 1:
Team: "sawtooth-next-contributors" should have WRITE to sawtooth-next-directory
Repo: sawtooth-next-directory
Settings/Branches
- master
X Require pull request reviews before merging
X Restrict who can push to matching branches
Team: "sawtooth-next-committers"
I think that accomplishes the intended security restrictions of locking down merge permissions to the repo to only a few people but giving the entire team access to Issues, Project and Wiki.
adamgering (Thu, 06 Sep 2018 17:47:52 GMT):
Option 2:
Team: "sawtooth-next-contributors" should have READ to sawtooth-next-directory
Team: "sawtooth-next-committers" should have WRITE to sawtooth-next-directory
Repo: sawtooth-next-directory
Settings/Branches
- master
X Require pull request reviews before merging
X Restrict who can push to matching branches
Team: "sawtooth-next-committers"
In this option, only "sawtooth-next-committers" members have ability to assign and review issues, edit Project and edit Wiki. That would make Project and Wiki un-usable (Wiki could be used still if you want to allow "public" write access).
adamgering (Thu, 06 Sep 2018 17:47:52 GMT):
----
Option 2:
Team: "sawtooth-next-contributors" should have READ to sawtooth-next-directory
Team: "sawtooth-next-committers" should have WRITE to sawtooth-next-directory
Repo: sawtooth-next-directory
Settings/Branches
- master
X Require pull request reviews before merging
X Restrict who can push to matching branches
Team: "sawtooth-next-committers"
In this option, only "sawtooth-next-committers" members have ability to assign and review issues, edit Project and edit Wiki. That would make Project and Wiki un-usable (Wiki could be used still if you want to allow "public" write access).
adamgering (Thu, 06 Sep 2018 17:48:22 GMT):
----
In either option, we need to determine a list of people who should be in the "sawtooth-next-committers" subteam (merge access to the repo).
adamgering (Thu, 06 Sep 2018 17:52:17 GMT):
All other Hyperledger projects use the Hyperledger JIRA instead of GitHub Issues/Projects/Wiki, so they have not had to consider the lack of granular permissions on GitHub for those features.
adamgering (Thu, 06 Sep 2018 17:52:17 GMT):
----
All other Hyperledger projects use the Hyperledger JIRA instead of GitHub Issues/Projects/Wiki, so they have not had to consider the lack of granular permissions on GitHub for those features.
https://jira.hyperledger.org/secure/BrowseProjects.jspa?selectedCategory=all&selectedProjectType=all
kthblmfld (Thu, 06 Sep 2018 17:52:47 GMT):
@agoldingay What do you think about switching to Jira?
adamgering (Thu, 06 Sep 2018 17:59:02 GMT):
----
Option 3:
Source Repo: sawtooth-next-directory
Project Repo: sawtooth-next-directory-project
Team: "sawtooth-next-contributors" should have WRITE to sawtooth-next-directory-project
Team: "sawtooth-next-committers" should have WRITE to sawtooth-next-directory
Repo: sawtooth-next-directory
Settings/Branches
- master
X Require pull request reviews before merging
X Restrict who can push to matching branches
Team: "sawtooth-next-committers"
In this option, we have two repos, one for the source code and another for the project.
adamgering (Thu, 06 Sep 2018 17:59:02 GMT):
----
Option 3:
Source Repo: sawtooth-next-directory
Project Repo: sawtooth-next-directory-project
Team: "sawtooth-next-contributors" should have WRITE to sawtooth-next-directory-project and READ to sawtooth-next-directory
Team: "sawtooth-next-committers" should have WRITE to sawtooth-next-directory
Repo: sawtooth-next-directory
Settings/Branches
- master
X Require pull request reviews before merging
X Restrict who can push to matching branches
Team: "sawtooth-next-committers"
In this option, we have two repos, one for the source code and another for the project.
agoldingay (Thu, 06 Sep 2018 18:00:12 GMT):
@kthblmfld I prefer to defer to @ChrisSpanton. He was going to directly talk to HL to settle the permissions/roles at large. more to come...
kthblmfld (Thu, 06 Sep 2018 18:00:54 GMT):
Ok deal
jiettu (Thu, 06 Sep 2018 18:30:38 GMT):
Has joined the channel.
agoldingay (Thu, 06 Sep 2018 20:25:40 GMT):
All, for those who attend standup in person, next week's (9/10-9/14) standup rooms will vary each day. Please note the updates I sent in the Outlook invites. same Skype https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L and dial in - 1-844-202-5500,,4191791129# Cheers!
nihalpimpale (Thu, 06 Sep 2018 21:13:26 GMT):
Has joined the channel.
devsatishm (Thu, 06 Sep 2018 21:44:36 GMT):
I now see edit buttons everywhere in the repo.. Wooho!
ChrisSpanton (Thu, 06 Sep 2018 22:03:47 GMT):
Yes - the group (sawtooth-next-contributors) should now be appropriately permissioned - anyone needing to have issues assigned, etc, will need to request access
YukiTruckServices (Thu, 06 Sep 2018 23:52:48 GMT):
Has joined the channel.
kthblmfld (Fri, 07 Sep 2018 00:24:53 GMT):
Hi all. It looks like this merge broke the tests in the project: https://github.com/hyperledger/sawtooth-next-directory/pull/13
kthblmfld (Fri, 07 Sep 2018 00:25:19 GMT):
I approved the changes so it's on me to fix
kthblmfld (Fri, 07 Sep 2018 00:29:29 GMT):
There are a number of improvements we are spotting here and they are becoming too numerous for a single PR, so I will be creating issues for the changes that are simple changes but also changes that touch lots of files
kthblmfld (Fri, 07 Sep 2018 00:30:03 GMT):
Also we are restoring the tests
adamgering (Fri, 07 Sep 2018 01:18:43 GMT):
@ChrisSpanton when you get Admin permission on the repo we should set:
Settings/Branches
- master
X Require pull request reviews before merging
Or I can ask Tim to do so?
There shouldn't be any direct commits to the repo, only pull requests and approved merges of pull requests.
adamgering (Fri, 07 Sep 2018 01:38:07 GMT):
Does anyone know best practice for rebasing and/or squashing these pull requests so we don't pollute the commit history?
LedgerXYZ (Fri, 07 Sep 2018 02:15:12 GMT):
Has joined the channel.
LedgerXYZ (Fri, 07 Sep 2018 02:20:11 GMT):
Hello all. I have just ran this project using `docker-compose up`. Before that, I configured the config.py to include necessary keys.
LedgerXYZ (Fri, 07 Sep 2018 02:21:51 GMT):
I can view the login page, signup page, reset password page. However, those page do not progress
LedgerXYZ (Fri, 07 Sep 2018 02:23:22 GMT):
Meaning when I click the login or signup up button, nothing happens
LedgerXYZ (Fri, 07 Sep 2018 02:24:02 GMT):
Is there something I should do or configure to get this to work?
kthblmfld (Fri, 07 Sep 2018 02:26:33 GMT):
Hello @LedgerXYZ. Anything in your console?
kthblmfld (Fri, 07 Sep 2018 02:27:03 GMT):
Try instead running *docker-compose up --build*
kthblmfld (Fri, 07 Sep 2018 02:27:58 GMT):
Just a heads up: Development has just continued on this project and we are still stabilizing it
kthblmfld (Fri, 07 Sep 2018 02:28:50 GMT):
We have test failures and instability due to a recent merge
kthblmfld (Fri, 07 Sep 2018 02:29:42 GMT):
We are actively working on improving build process, test automation, stabilizing sources, improving documentation, adding new features
kthblmfld (Fri, 07 Sep 2018 02:30:39 GMT):
It should be stabilized within a week
LedgerXYZ (Fri, 07 Sep 2018 02:31:13 GMT):
I'm thoroughly impressed. This project snuck up on me
LedgerXYZ (Fri, 07 Sep 2018 02:31:26 GMT):
I will try the docker-compose up --build
kthblmfld (Fri, 07 Sep 2018 02:31:32 GMT):
It did?
LedgerXYZ (Fri, 07 Sep 2018 02:32:03 GMT):
Yes it did. I have been actively working with sawtooth since Nov 2017
kthblmfld (Fri, 07 Sep 2018 02:32:08 GMT):
Glad to hear you are impressed. In the next few weeks it should get much better
kthblmfld (Fri, 07 Sep 2018 02:32:19 GMT):
Oh ok
kthblmfld (Fri, 07 Sep 2018 02:33:09 GMT):
We have a number of new contributors and stakeholders on this project and are all collaborating on it
LedgerXYZ (Fri, 07 Sep 2018 02:33:31 GMT):
Ultimately, who owns this project
kthblmfld (Fri, 07 Sep 2018 02:33:33 GMT):
We have an open daily standup at 11:30 PST
LedgerXYZ (Fri, 07 Sep 2018 02:33:44 GMT):
is this being open sourced by T-MOBILE?
kthblmfld (Fri, 07 Sep 2018 02:33:44 GMT):
Ha! Good question.
kthblmfld (Fri, 07 Sep 2018 02:36:25 GMT):
I defer to @ChrisSpanton and Nicholas Criss (both T-Mobile) for direction and consider them the owners
LedgerXYZ (Fri, 07 Sep 2018 02:36:52 GMT):
Ok I will try to get involved
kthblmfld (Fri, 07 Sep 2018 02:36:56 GMT):
But there are contributors from Microsoft, Intel, Moonraft
kthblmfld (Fri, 07 Sep 2018 02:37:02 GMT):
Great!
LedgerXYZ (Fri, 07 Sep 2018 02:37:08 GMT):
with the community
LedgerXYZ (Fri, 07 Sep 2018 02:37:18 GMT):
Wow, you have a strong backing on this
LedgerXYZ (Fri, 07 Sep 2018 02:37:29 GMT):
This project couldn't have come at a better time
kthblmfld (Fri, 07 Sep 2018 02:37:49 GMT):
Yea but we could definitely use more hands-on with a veteran contributor
LedgerXYZ (Fri, 07 Sep 2018 02:37:54 GMT):
I think I pushed the supply-chain to its limit and this offers a lot of the control I need
kthblmfld (Fri, 07 Sep 2018 02:38:23 GMT):
Yea we could definitely use any help you can give
LedgerXYZ (Fri, 07 Sep 2018 02:38:38 GMT):
I will help however I can. I am more than greatful for you and your teams intiative here
kthblmfld (Fri, 07 Sep 2018 02:38:43 GMT):
I have to run now. Creat to meet you!
kthblmfld (Fri, 07 Sep 2018 02:38:43 GMT):
I have to run now. Great to meet you!
LedgerXYZ (Fri, 07 Sep 2018 02:39:27 GMT):
Thanks, enjoy your evening
LedgerXYZ (Fri, 07 Sep 2018 03:00:31 GMT):
To the sawtooth-next team, this is what appears in my console during a login request for example:
LedgerXYZ (Fri, 07 Sep 2018 03:00:59 GMT):
Clipboard - September 6, 2018 10:00 PM
LedgerXYZ (Fri, 07 Sep 2018 03:02:43 GMT):
I tried the suggestion that @kthblmfld offered: Use `docker-compose up --build`. Still no luck
ChrisSpanton (Fri, 07 Sep 2018 15:35:11 GMT):
@kthblmfld mud on my face too RE: 13. Thanks for digging into that
ChrisSpanton (Fri, 07 Sep 2018 15:35:41 GMT):
@adamgering I'll make sure we get that set... thanks for the awareness.
ChrisSpanton (Fri, 07 Sep 2018 15:40:09 GMT):
@LedgerXYZ thanks for the interest - this is definitely a community owned project. It was envisioned to solve problems and improve IAM related processes at T-Mobile, but is being designed to solve the broader open use cases around this space
ChrisSpanton (Fri, 07 Sep 2018 15:41:24 GMT):
I'd be happy to sync up and chat about it any time, or alternatively as @kthblmfld mentioned, we host a daily standup that is open to the community. You are more than welcome to come join in via that process, or by whichever means feel right to you
LedgerXYZ (Fri, 07 Sep 2018 15:41:28 GMT):
That's why I can't wait to see what's behind the pages
ChrisSpanton (Fri, 07 Sep 2018 15:41:56 GMT):
ha! let me see if I can repro the issues you're seeing
LedgerXYZ (Fri, 07 Sep 2018 15:42:24 GMT):
Yes, I will attend your stands up. I used to be an SM before I crossed over to the dark side
LedgerXYZ (Fri, 07 Sep 2018 15:43:14 GMT):
Oh thanks for trying to repro my error
ChrisSpanton (Fri, 07 Sep 2018 15:43:17 GMT):
right on! Lots of work going forward now, checking out the issues / project board in GH should reveal some more about where we are today, and whats on the short-term agenda
LedgerXYZ (Fri, 07 Sep 2018 15:43:56 GMT):
What's a good link to your stand up
ChrisSpanton (Fri, 07 Sep 2018 15:44:36 GMT):
should be here in chat... lemme find it
LedgerXYZ (Fri, 07 Sep 2018 15:44:50 GMT):
I'll find. I should've checked first
ChrisSpanton (Fri, 07 Sep 2018 15:45:10 GMT):
from @agoldingay (SM)
LedgerXYZ (Fri, 07 Sep 2018 15:46:28 GMT):
I have this link https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L
agoldingay (Fri, 07 Sep 2018 15:47:50 GMT):
@LedgerXYZ that's it! Glad to have you join us! :)
LedgerXYZ (Fri, 07 Sep 2018 15:48:13 GMT):
My pleasure @agoldingay
LedgerXYZ (Fri, 07 Sep 2018 15:48:39 GMT):
So really quick @agoldingay Who exactly owns this project
LedgerXYZ (Fri, 07 Sep 2018 15:49:52 GMT):
Clearly T-Mobile is plays a major role. Is T-Mobile developing this open sourced. Hence the open collaboration?
ChrisSpanton (Fri, 07 Sep 2018 15:51:12 GMT):
@LedgerXYZ yes. :)
ChrisSpanton (Fri, 07 Sep 2018 15:51:43 GMT):
This project was my vision.
ChrisSpanton (Fri, 07 Sep 2018 15:52:22 GMT):
On the T-Mobile side, im the product owner and lead our blockchain efforts. Everything here however is open source first, as you see donated to Hyperledger
LedgerXYZ (Fri, 07 Sep 2018 15:52:38 GMT):
No way!
ChrisSpanton (Fri, 07 Sep 2018 15:52:51 GMT):
Chat, standup, issue tracking and project management are all open efforts.
ChrisSpanton (Fri, 07 Sep 2018 15:53:13 GMT):
We strive to have no "closed door" processes here, and allow the community to be actively engaged
LedgerXYZ (Fri, 07 Sep 2018 15:53:59 GMT):
What led you to this
LedgerXYZ (Fri, 07 Sep 2018 15:54:17 GMT):
I read the article from Nov about the need for a project like this
ChrisSpanton (Fri, 07 Sep 2018 15:57:00 GMT):
The vision came out of work that I've done at T-Mobile building our cloud business over the last few years. I built the N-Scale IAM and RBAC self-service platform that supports our work. It's a relatively messy closed-source collection of API's, automations, UI's, etc. As I looked at how to improve those solutions in the future, it became clear to me that a Sawtooth blockchain could dramatically improve the governance posture and auditing confidence
ChrisSpanton (Fri, 07 Sep 2018 15:58:07 GMT):
So, we worked with the Intel team to build the first version of this last year, and announced it at AWS re:Invent. We've been driving it towards a production ready version (at varying speeds) since
LedgerXYZ (Fri, 07 Sep 2018 15:59:01 GMT):
Life is weird because it makes you work hard first, then it offers a simpler and more effective way
LedgerXYZ (Fri, 07 Sep 2018 16:01:31 GMT):
I started with the blockchain last year with an identity management goal. I hated Ethereum platform because I perceived it as incompatible with widespread devices today. Then it became a marijuana blockchain to track marijuana from seed to sale after I found the Sawtooth-supply chain.
LedgerXYZ (Fri, 07 Sep 2018 16:02:50 GMT):
All along the way, I found myself doing more architectural research than actual coding. One of the reasons was how to authenticate and authorize users on a blockchain in a fluid manner
LedgerXYZ (Fri, 07 Sep 2018 16:03:03 GMT):
Then 2 days ago, I stumble into NEXT!!!
LedgerXYZ (Fri, 07 Sep 2018 16:03:26 GMT):
To say this was a miracle is truly an understatement. Thank you all so much for doing this
chimpuz (Fri, 07 Sep 2018 16:11:00 GMT):
We are having a discussion on the first cut concepts for NEXT Directory at : https://moonraft.my.webex.com/moonraft.my/e.php?MTID=mccc9586d14a62d0c03e15d4b0f0b3c90
ChrisSpanton (Fri, 07 Sep 2018 16:11:14 GMT):
You'll see both native AAA as well as LDAP and GraphAPI providers for integration with MS AD and Azure AD
LedgerXYZ (Fri, 07 Sep 2018 17:01:18 GMT):
Wow the presentation at the standup today was quite an appetizer
LedgerXYZ (Fri, 07 Sep 2018 17:02:25 GMT):
In mean time can someone try to reproduce my error that I posted about earlier
LedgerXYZ (Fri, 07 Sep 2018 17:03:05 GMT):
I've tried running this on both my local machine as well as the google cloud shell without success. Thank you all
mtn206 (Fri, 07 Sep 2018 17:27:24 GMT):
Hello @LedgerXYZ ! Can you provide us with a copy of the command line output after you run the `docker-compose up --build` command and you attempt to perform a login request?
mtn206 (Fri, 07 Sep 2018 17:28:44 GMT):
If you could run the command on your local machine first, that would be most helpful.
ChrisSpanton (Fri, 07 Sep 2018 17:41:08 GMT):
Thanks for following up on this @mtn206!
rjones (Fri, 07 Sep 2018 18:14:21 GMT):
Has left the channel.
LedgerXYZ (Fri, 07 Sep 2018 19:21:30 GMT):
@mtn206 Sorry about the delay, I'm booting up now and will report back with the logs
LedgerXYZ (Fri, 07 Sep 2018 19:47:48 GMT):
@mtn206 unfortunately I do not have access to my local machine right now. I was able to rebuild using `local` setup on the cloud shell and here is the output (caution this is very long):
LedgerXYZ (Fri, 07 Sep 2018 19:47:57 GMT):
```
```
LedgerXYZ (Fri, 07 Sep 2018 19:58:59 GMT):
There are too many lines of code to load it here
LedgerXYZ (Fri, 07 Sep 2018 19:59:14 GMT):
I have it loaded to: https://file.io/79Hq8n
LedgerXYZ (Fri, 07 Sep 2018 19:59:34 GMT):
Please advise if external links are not permitted then I will figure something else out
mtn206 (Fri, 07 Sep 2018 20:01:52 GMT):
Thank you for the output, I'll check it out and see if I can find anything interesting.
LedgerXYZ (Fri, 07 Sep 2018 20:03:34 GMT):
@mtn206 Thank you
From what I have learned so far, there is a conflict with my configuration: `localhost` and the URL that cloud shell serves the localhost with: `https://
LedgerXYZ (Fri, 07 Sep 2018 20:04:38 GMT):
However I don't see how this should affect it especially if a widely used service like `ngrok` works in similar use case
adamgering (Fri, 07 Sep 2018 20:14:52 GMT):
I believe you want to rebase your feature branch and then squash commits into a single commit (if more than one) prior to submitting a pull request (PR).
See https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
adamgering (Fri, 07 Sep 2018 20:15:26 GMT):
And then the pull request itself, after two approvals, should be a Rebase & Commit, not a Merge Commit.
adamgering (Fri, 07 Sep 2018 20:15:38 GMT):
That should keep the commit history clean.
amundson (Sat, 08 Sep 2018 17:26:28 GMT):
this is generally what we use as a guide for Sawtooth commits - https://chris.beams.io/posts/git-commit/
amundson (Sat, 08 Sep 2018 17:30:26 GMT):
splitting commits up properly is as common and important as squashing them. the goal isn't one commit per PR, but good well-formed commits. For repos where we have release branches, a good question to ask is "is this broken up in a way that can be easily cherry-picked later"
kthblmfld (Mon, 10 Sep 2018 05:12:18 GMT):
@adamgering @amundson Thanks for sharing. Looks like I need to make the switch from the IDE to the CLI, start using imperative form messages limited to 72 chars with subject line, etc. Ok, starting down that path.
kthblmfld (Mon, 10 Sep 2018 05:39:22 GMT):
I looked into the licensing matter and found the LICENSE doc at the root is standard for Apache 2.0 and they recommend for each source file the "boilerplate" license found in the appendix. The copyright section with year and owner seems vague. Maybe there is a legal reason. I see in Kubernetes that owner is described as "The Kubernetes Authors".
kelly_ (Mon, 10 Sep 2018 19:03:09 GMT):
Hey All
kelly_ (Mon, 10 Sep 2018 19:03:20 GMT):
Just getting the Next-Directory spun up
kthblmfld (Mon, 10 Sep 2018 19:03:26 GMT):
Hello
kelly_ (Mon, 10 Sep 2018 19:04:09 GMT):
I got it running in Docker and most everything works
kelly_ (Mon, 10 Sep 2018 19:04:19 GMT):
however when I went to approve a user into a new group I had an issue
kelly_ (Mon, 10 Sep 2018 19:04:25 GMT):
this is what I have in my logs
kelly_ (Mon, 10 Sep 2018 19:04:49 GMT):
`validator_1 | [2018-09-10 19:01:49.491 DEBUG publisher] Batch 27504a24db56ef69a6dedfc60c169a0c3a7ae897d07ef8748966ac69e2fa9c6d25eb1db3801220bbf7c2ab4637c7c2d7a4b50ac4c7e86885feabad9f02c4afa0 invalid, not added to block.
validator_1 | [2018-09-10 19:01:49.491 DEBUG publisher] Abandoning block (5, S:, P:38cac1ed): no batches added
`
kelly_ (Mon, 10 Sep 2018 19:05:07 GMT):
so for some reason the approval created an invalid batch
kthblmfld (Mon, 10 Sep 2018 19:06:14 GMT):
@yunhangc @mtn206 Did you two sort out the revert change made last week?
kthblmfld (Mon, 10 Sep 2018 19:06:52 GMT):
We had to revert a validation that was removed due to failing tests
kelly_ (Mon, 10 Sep 2018 19:06:53 GMT):
going to try a docker compose down/up and retry just to get come cleaner logs
kthblmfld (Mon, 10 Sep 2018 19:07:00 GMT):
Ok
yunhangc (Mon, 10 Sep 2018 19:08:18 GMT):
yes. Adam told me that. @kthblmfld Keith and Adam, you already reverted it right?
kthblmfld (Mon, 10 Sep 2018 19:08:29 GMT):
Yes. https://github.com/hyperledger/sawtooth-next-directory/pull/53
kthblmfld (Mon, 10 Sep 2018 19:08:43 GMT):
It fixes tests but likely creates a failure at runtime
yunhangc (Mon, 10 Sep 2018 19:09:06 GMT):
cool. will keep it that way. I will fix the runtime no worries.
yunhangc (Mon, 10 Sep 2018 19:09:08 GMT):
thanks
kthblmfld (Mon, 10 Sep 2018 19:10:00 GMT):
Thank you. There are a number of improvements to test coming down the pipe. Not sure if this is what @kelly_ is experiencing now
kthblmfld (Mon, 10 Sep 2018 19:10:00 GMT):
Thank you. There are a number of improvements to tests coming down the pipe. Not sure if this is what @kelly_ is experiencing now
kelly_ (Mon, 10 Sep 2018 19:11:06 GMT):
yep same thing - here are the logs
kelly_ (Mon, 10 Sep 2018 19:11:12 GMT):
rbac-tp_1 | [2018-09-10 19:10:27.113 DEBUG core] received message of type: TP_PROCESS_REQUEST
rbac-tp_1 | [2018-09-10 19:10:27.117 WARNING core] Invalid Transaction The proposal 8cbf5aaf-f7d7-4a2c-8010-5a15a1e71b26 does not exist or is not open
rbac-server_1 | Bad Request: The proposal 8cbf5aaf-f7d7-4a2c-8010-5a15a1e71b26 does not exist or is not open
rbac-server_1 | Traceback (most recent call last):
rbac-server_1 | File "/usr/local/lib/python3.5/dist-packages/sanic/app.py", line 603, in handle_request
rbac-server_1 | response = await response
rbac-server_1 | File "/usr/lib/python3.5/asyncio/coroutines.py", line 105, in __next__
rbac-server_1 | return self.gen.send(None)
rbac-server_1 | File "/project/tmobile-rbac/server/api/auth.py", line 51, in decorated_function
rbac-server_1 | response = await func(request, *args, **kwargs)
rbac-server_1 | File "/usr/lib/python3.5/asyncio/coroutines.py", line 105, in __next__
rbac-server_1 | return self.gen.send(None)
rbac-server_1 | File "/project/tmobile-rbac/server/api/proposals.py", line 208, in update_proposal
rbac-server_1 | request.app.config.TIMEOUT)
rbac-server_1 | File "/usr/lib/python3.5/asyncio/coroutines.py", line 105, in __next__
rbac-server_1 | return self.gen.send(None)
rbac-server_1 | File "/project/tmobile-rbac/server/api/utils.py", line 217, in send
rbac-server_1 | 'Bad Request: {}'.format(resp.invalid_transactions[0].message)
rbac-server_1 | api.errors.ApiBadRequest: Bad Request: The proposal 8cbf5aaf-f7d7-4a2c-8010-5a15a1e71b26 does not exist or is not open
rbac-server_1 | [2018-09-10 19:10:27 +0000] - (sanic.access)[INFO][172.23.0.1:48982]: PATCH http://localhost:8000/api/proposals/8cbf5aaf-f7d7-4a2c-8010-5a15a1e71b26 400 117
validator_1 | [2018-09-10 19:10:27.210 DEBUG publisher] Batch 68911c82496fb918ccc8c3ece95e532d009aa81227ef648d28d90fb314458ce877d66f0056320796c3c90527cdb8490e0b3c4bdfcd66abb0cca412cb2a1b7dc1 invalid, not added to block.
validator_1 | [2018-09-10 19:10:27.212 DEBUG publisher] Abandoning block (5, S:, P:2886a836): no batches added
kelly_ (Mon, 10 Sep 2018 19:12:37 GMT):
so looks like `The proposal 8cbf5aaf-f7d7-4a2c-8010-5a15a1e71b26 does not exist or is not open`
kthblmfld (Mon, 10 Sep 2018 19:15:14 GMT):
Got it
kelly_ (Mon, 10 Sep 2018 19:16:41 GMT):
if it helps I can throw it up as an issue on github? not sure if thats what you guys are using to track issues
kthblmfld (Mon, 10 Sep 2018 19:17:21 GMT):
It is reported as #47: https://github.com/hyperledger/sawtooth-next-directory/issues
kthblmfld (Mon, 10 Sep 2018 19:17:47 GMT):
I *think*
kelly_ (Mon, 10 Sep 2018 19:17:49 GMT):
fantastic, thanks!
kthblmfld (Mon, 10 Sep 2018 19:18:19 GMT):
The issue could be clarified to include steps for restoration
kthblmfld (Mon, 10 Sep 2018 19:21:02 GMT):
@kelly_ This project is (as of the past few weeks) picking up momentum after some time on the shelf. We are still iterating on backlog and issues and have a Project board here: https://github.com/hyperledger/sawtooth-next-directory/projects/1
kelly_ (Mon, 10 Sep 2018 19:21:02 GMT):
the one other comment I would make, is that the UI hangs when this error happens
kthblmfld (Mon, 10 Sep 2018 19:21:33 GMT):
Yep. There is another team demoing/reimplementing the UI in React
kthblmfld (Mon, 10 Sep 2018 19:24:25 GMT):
@chimpuz, @jiettu are some POCs on that front
kthblmfld (Mon, 10 Sep 2018 19:25:42 GMT):
In the meantime, we have some new changes going into the NG UI but mostly happy path feature demo
kthblmfld (Mon, 10 Sep 2018 19:26:11 GMT):
We have yet to sort out when and how the cutover will take place
yunhangc (Mon, 10 Sep 2018 20:06:26 GMT):
@kelly_ proposal_exists_and_open method can be very deceiving
yunhangc (Mon, 10 Sep 2018 20:06:54 GMT):
if the "get_state_entry" throws an error it does not throw the error but return
yunhangc (Mon, 10 Sep 2018 20:07:01 GMT):
return False
yunhangc (Mon, 10 Sep 2018 20:07:20 GMT):
which will give you the error that the proposal does not exisit or not open
yunhangc (Mon, 10 Sep 2018 20:07:41 GMT):
the proposal could be just there and just open.
kthblmfld (Tue, 11 Sep 2018 17:33:19 GMT):
Ouch github issues today :(
AlyOwens13 (Tue, 11 Sep 2018 18:44:30 GMT):
Hi, we need help from an admin perspective side to approve Travis CI. Who should I reach out to?
kthblmfld (Tue, 11 Sep 2018 18:54:56 GMT):
@ChrisSpanton has been working on getting admin rights to the repo. He is at the Seattle Blockchain Conference today though. Ideally he will receive the privileges to make these repo changes so the turnaround time will improve.
arsulegai (Tue, 11 Sep 2018 18:58:52 GMT):
Has joined the channel.
agoldingay (Tue, 11 Sep 2018 19:05:14 GMT):
All, thanks for your participation in today's standup. As an update to the community, NEXT Standup has changed from Zoom to Skype. still same time, daily 11:30am PST. Dial in is 1-844-202-5500,,4191791129# (Northwest) https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L.
AlyOwens13 (Tue, 11 Sep 2018 20:17:25 GMT):
@kthblmfld I know that. I'm just worried our sprint is halfway gone and hoping to get #hyperledger team to help @ChrisSpanton get that permission sooner than later
kthblmfld (Tue, 11 Sep 2018 20:27:45 GMT):
Looking through the history of this chat, the project has received help from @Dan, @mfford, @rjones , and @tijohnson
tijohnson (Tue, 11 Sep 2018 20:27:46 GMT):
Has joined the channel.
rjones (Tue, 11 Sep 2018 20:27:46 GMT):
Has joined the channel.
rjones (Tue, 11 Sep 2018 20:38:49 GMT):
Hi
rjones (Tue, 11 Sep 2018 20:42:32 GMT):
@AlyOwens13 what's up
rjones (Tue, 11 Sep 2018 20:44:22 GMT):
I'm logged in to travis-ci and I can activate it, is that all you need? are there a bunch of environment variables that need set?
AlyOwens13 (Tue, 11 Sep 2018 20:44:58 GMT):
@devsatishm , you just need it to be approved, correct?
rjones (Tue, 11 Sep 2018 20:45:53 GMT):
https://travis-ci.org/hyperledger/sawtooth-next-directory/builds/427390762
rjones (Tue, 11 Sep 2018 20:46:05 GMT):
it claims to have passed
rjones (Tue, 11 Sep 2018 20:51:12 GMT):
https://travis-ci.org/hyperledger/sawtooth-next-directory/pull_requests says my bunk PR passed
rjones (Tue, 11 Sep 2018 20:51:36 GMT):
https://github.com/hyperledger/sawtooth-next-directory/pull/59 says travis passed (DCO failed by design)
rjones (Tue, 11 Sep 2018 20:51:45 GMT):
if you need more help reach out
rjones (Tue, 11 Sep 2018 20:51:52 GMT):
Has left the channel.
AlyOwens13 (Tue, 11 Sep 2018 20:54:16 GMT):
thank you, @ry. you made my day ;)
kthblmfld (Tue, 11 Sep 2018 20:59:57 GMT):
Thanks @rjones
rjones (Tue, 11 Sep 2018 20:59:58 GMT):
Has joined the channel.
rjones (Tue, 11 Sep 2018 21:45:58 GMT):
Has left the channel.
amundson (Wed, 12 Sep 2018 14:38:36 GMT):
@ChrisSpanton @kthblmfld @AlyOwens13 Next directory seems to be ignoring the community norms and going off on it's own direction (Travis instead of the Sawtooth Jenkins, github issues instead of HL JIRA, github wiki instead of sphinx-doc, ignoring established maintainer and github access conventions, etc.). Do you guys see next directory as related to Sawtooth or as a separate project? Should next directory move to labs or apply to be a separate top-level project?
Dan (Wed, 12 Sep 2018 16:12:44 GMT):
I think some of this is tribal knowledge (preferred tooling etc.). Maybe we can discuss some at the tech forum. I don't think you will be there though @amundson ?
kelly_ (Wed, 12 Sep 2018 16:13:59 GMT):
I would see issue tracking and CI could be specific to a certain subproject/application. for example we use Burrow as an application but that doesnt mean that we use their same documentation setup
kelly_ (Wed, 12 Sep 2018 16:14:53 GMT):
so to the extent that next-directory is just consuming sawtooth-core components to build an application, it seems like their project could follow their own conventions
agoldingay (Wed, 12 Sep 2018 16:40:28 GMT):
@amundson thank you for your feedback. I've let he team you've addressed in your 7:38am thread review your concerns.
agoldingay (Wed, 12 Sep 2018 16:40:28 GMT):
@amundson thank you for your feedback. I've informed the team you've addressed in your 7:38am thread review your concerns.
agoldingay (Wed, 12 Sep 2018 16:40:28 GMT):
@amundson thank you for your feedback. I've informed the team you've addressed in your 7:38am thread to review your concerns.
ChrisSpanton (Wed, 12 Sep 2018 17:02:25 GMT):
@amundson we're taking a community-based approach to driving this project. We'd love for you to join the effort! We obviously have an open chat forum here where we're actively engaged, and hold a daily stand-up thats open to the community. After traditional stand-up I'm sure we can find time to discuss community issues
amundson (Wed, 12 Sep 2018 17:10:19 GMT):
@Dan unfortunately, no, I'll be traveling
amundson (Wed, 12 Sep 2018 17:13:13 GMT):
@ChrisSpanton if you feel I've not been involved enough with Sawtooth, please do tell
kelly_ (Wed, 12 Sep 2018 17:13:34 GMT):
@amundson, I think @ChrisSpanton was referring to next-directory
kelly_ (Wed, 12 Sep 2018 17:13:54 GMT):
when you say the team is 'ignoring' that comes off as if they did something knowing/malicious
kelly_ (Wed, 12 Sep 2018 17:14:14 GMT):
I think @ChrisSpanton was offering to discuss their approach with you
kelly_ (Wed, 12 Sep 2018 17:14:47 GMT):
as an open source project I think we should take a look at where there needs to be strong consistency among repos and where their may be room for choice
ChrisSpanton (Wed, 12 Sep 2018 17:15:48 GMT):
@amundson @ kelly_ thats certainly accurate. I wouldn't presume to comment on your participation in Sawtooth.
ChrisSpanton (Wed, 12 Sep 2018 17:17:01 GMT):
Next Directory is a standalone application built on Sawtooth. Its concerning to think that anyone considering building on Sawtooth need follow the decisions that were made for that codebase... I'd love for you to participate in NEXT, but certainly feel a need to defend our projects ability to make choices that fit
kelly_ (Wed, 12 Sep 2018 17:17:20 GMT):
sawtooth benefits from consistency but also from accessibility and broad participation, so i think we need to strike a balance between those things
amundson (Wed, 12 Sep 2018 17:19:37 GMT):
@ChrisSpanton ok, so you agree it should be it's own project. then it should go to Labs or propose to be a HL project. if it's a component of Sawtooth (as implied by the name and repo), then I think we should all be using the same tooling and processes.
kelly_ (Wed, 12 Sep 2018 17:20:05 GMT):
@amundson I think that's a discussion worth having vs. a unilateral decision
adamgering (Wed, 12 Sep 2018 17:25:40 GMT):
We do plan to use sphinx-doc, not Wiki, for permanent documentation.
amundson (Wed, 12 Sep 2018 17:27:04 GMT):
@kelly_ that was a stated opinion, not a decision, obviously
adamgering (Wed, 12 Sep 2018 17:28:05 GMT):
Hyperledger JIRA has been brought up. Who would be the person to create the JIRA project and setup permissions?
adamgering (Wed, 12 Sep 2018 17:29:28 GMT):
Continuous Integration is in progress of being brought up, so whatever works best. I do want to get integration testing built into that.
adamgering (Wed, 12 Sep 2018 17:32:02 GMT):
GitHub branch permissions/settings are used to maintain same effective maintainer + Pull Request contribution model.
adamgering (Wed, 12 Sep 2018 17:32:53 GMT):
GitHub otherwise lacked granular permissions to the Wiki and Issues, which we found useful.
adamgering (Wed, 12 Sep 2018 17:33:44 GMT):
Happy to incorporate all Hyperledger best practices and would love help and guidance in doing so.
ChrisSpanton (Wed, 12 Sep 2018 17:34:14 GMT):
@kelly_ @amundson The questions here for me are: Are there defined standards that have been documented and agreed on which are being ignored here, or are we breaking some unspoken rules by allowing the project team to utilize tools that work best for them? If the former, please do share, and we can make a decision on whether its appropriate to conform or move the project. If the latter, then as I suggested I'll definitely defend our project teams ability to make decisions that fit.
kelly_ (Wed, 12 Sep 2018 17:41:20 GMT):
agreed, I think there is certainly a way we are doing it now, but I'm not yet convinced that all repos need to use the same issues tracking, documentation, or CI system. I certainly think it's worth us having a discussion about the pros/cons of each and where it makes sense. I can see an argument for both directions. conformity/consistency helps people move among different projects under the sawtooth banner at the same time some repos have their own communities and from an accessibility perspective there could be an argument to not unnecessarily raise the barrier to entry for them.
kelly_ (Wed, 12 Sep 2018 17:41:43 GMT):
it probably also depends on how closely that repository is linked to sawtooth
amundson (Wed, 12 Sep 2018 17:43:09 GMT):
@ChrisSpanton of course, its not that boolean. The reason I asked about how you see the project, is that we should not bother having tooling debates if our starting point is that it's two separate projects with completely separate communities.
amundson (Wed, 12 Sep 2018 17:45:24 GMT):
@kelly_ we don't have a project per-repo, we have one project (Sawtooth) with mulitple components that we have broken up into multiple repos for technical reasons. and a few apps (Supply Chain, Next Directory, ...) that are essentially examples currently.
kelly_ (Wed, 12 Sep 2018 17:46:56 GMT):
I understand that, but different repos have different communities
amundson (Wed, 12 Sep 2018 17:47:37 GMT):
different teams, not different communities, because there is a lot of overlap on those teams
amundson (Wed, 12 Sep 2018 17:48:52 GMT):
currently, if I contribute to any of the repos, the rules are all the same (implied or explicit). different maintainers, but I don't have to learn a new culture.
kelly_ (Wed, 12 Sep 2018 17:49:34 GMT):
yup I understand that
kelly_ (Wed, 12 Sep 2018 17:49:59 GMT):
I'm saying in the future there could be different communities
kelly_ (Wed, 12 Sep 2018 17:50:26 GMT):
you have projects like geth, and parity, and aleth (c++) under the ethereum community
kelly_ (Wed, 12 Sep 2018 17:50:33 GMT):
each of those is part of the ethereum community
kelly_ (Wed, 12 Sep 2018 17:50:47 GMT):
but probably use different tools as an example
kelly_ (Wed, 12 Sep 2018 17:50:58 GMT):
or what if someone wants to submit a new consensus engine
kelly_ (Wed, 12 Sep 2018 17:51:26 GMT):
should they have to use jira instead of github? I'm not convinced of that yet. not saying they don't i just haven't heard the pros/cons articulated
kelly_ (Wed, 12 Sep 2018 17:52:22 GMT):
I get you are saying 'you don't want to have to learn a new culture' that is also true for new contributors/repos perhaps
kelly_ (Wed, 12 Sep 2018 17:52:31 GMT):
anyway we should just be specific about what items are part of the culture
amundson (Wed, 12 Sep 2018 17:52:33 GMT):
@ChrisSpanton there is a governance structure - https://github.com/hyperledger/sawtooth-rfcs/ - which we setup so @kelly_ and I can have good debates a lot :)
amundson (Wed, 12 Sep 2018 17:54:29 GMT):
@kelly_ I think that's what HL is itself though, with different projects having different communities and structures and goals for each.
kelly_ (Wed, 12 Sep 2018 17:57:05 GMT):
well you made a comment about 'community' and 'teams'
kelly_ (Wed, 12 Sep 2018 17:57:27 GMT):
and people can be in the same community but on separate and overlapping or non-overlapping teams
kelly_ (Wed, 12 Sep 2018 17:57:33 GMT):
e.g. ethereum and geth vs parity
kthblmfld (Wed, 12 Sep 2018 17:57:34 GMT):
Hi folks. Please bear with us. We are new to this project and ramping up on several fronts.
amundson (Wed, 12 Sep 2018 17:58:04 GMT):
To be clear, I care more about unity within our project than about specific tools. We could have a discussion about transitioning to use github issues instead of JIRA, using Travis CI instead of Jenkins, etc. I also have no opinions about what non-Sawtooth projects use. So don't feel I'm a big JIRA or Jenkins advocate here.
kelly_ (Wed, 12 Sep 2018 17:58:30 GMT):
ethereum as a community is prescriptive about some things (e.g. the EVM spec) but not about others (e.g. issue tracking)
kelly_ (Wed, 12 Sep 2018 17:59:04 GMT):
my 2 cents anyway
kelly_ (Wed, 12 Sep 2018 17:59:48 GMT):
but @amundson probably means we should have some biweekly or something scheduled 'governance' calls to discuss these topics on a regular cadence
kelly_ (Wed, 12 Sep 2018 18:00:30 GMT):
there are probably some items that should be *must* do and some items that are *should* do
kelly_ (Wed, 12 Sep 2018 18:01:41 GMT):
a good starting point would probably be documenting today's conventions for the majority of sawtooth repos
amundson (Wed, 12 Sep 2018 18:04:20 GMT):
yeah... I think everyone is clear we use Jenkins and JIRA, so I'm not sure what you are asking for in terms of documentation, especially if you are advocating that not even being a strict rule.
kelly_ (Wed, 12 Sep 2018 18:04:56 GMT):
are those the only conventions @amundson
kelly_ (Wed, 12 Sep 2018 18:05:00 GMT):
I suspect there are unspoken ones
amundson (Wed, 12 Sep 2018 18:05:01 GMT):
we could flush out the maintainers stuff more, but it is documented as new maintainers added by consensus vote of existing maintainers
kelly_ (Wed, 12 Sep 2018 18:05:42 GMT):
e.g. size of commits, linting, etc.
amundson (Wed, 12 Sep 2018 18:05:44 GMT):
the anti-wiki thing is by convention, I don't think that is documented anywhere
amundson (Wed, 12 Sep 2018 18:06:41 GMT):
just enforced by turning it off consistently
kelly_ (Wed, 12 Sep 2018 18:06:42 GMT):
naming convention could be another for builds/images, etc
kelly_ (Wed, 12 Sep 2018 18:07:01 GMT):
I agree with @dan that there is probably a lot of 'tribal knowledge'
kelly_ (Wed, 12 Sep 2018 18:08:02 GMT):
also I'm not suggesting that you document it. i'm just suggesting that as a team we should consider documenting the things that are conventions, and then determine which ones are must and which are should
kthblmfld (Wed, 12 Sep 2018 18:09:39 GMT):
Whatever direction we move in is doable. Travis or Jenkins, Jira or Github. I am glad you are chipping in because we have been moving ahead while catching up. Any direction, advice, documentation is welcome and we will put it to action.
kelly_ (Wed, 12 Sep 2018 18:09:46 GMT):
lines wrapped at 80 chars is another that i don't think is documented
kelly_ (Wed, 12 Sep 2018 18:10:03 GMT):
@kthblmfld :thumbsup:
amundson (Wed, 12 Sep 2018 18:10:33 GMT):
@kelly_ it's a strict rule you have to wrap your markdown text :)
kelly_ (Wed, 12 Sep 2018 18:10:57 GMT):
:) also capitalization is not allowed in file names? that's another one I got dinged for that wasn't documented
amundson (Wed, 12 Sep 2018 18:11:04 GMT):
most of that stuff we try and document via linting rules so there isn't debate. so we can rely on our tooling.
amundson (Wed, 12 Sep 2018 18:11:22 GMT):
yeah, but at least I let you know :)
kelly_ (Wed, 12 Sep 2018 18:12:27 GMT):
anyway, i think you get the point. I'll start a list in #sawtooth-governance and then we can at least let @kthblmfld know the conventions today. if there are areas that are difficult to change than we can have a conversation about what is must/should
kthblmfld (Wed, 12 Sep 2018 18:13:49 GMT):
@amundson @kelly_ Deal. Please get us a list asap and we will start the conversations internally. Thanks!
kthblmfld (Wed, 12 Sep 2018 18:14:52 GMT):
Travis -> Jenkins. Github -> Jira
amundson (Wed, 12 Sep 2018 18:14:56 GMT):
@kelly_ a general rule that might help is "try and be consistent with sawtooth-core and other repos unless there is a reason to deviate". will cut down on what you have to try and write up.
kelly_ (Wed, 12 Sep 2018 18:15:58 GMT):
@kthblmfld the one other @amundson mentioned is that we use sphinx for publishing documetation
kelly_ (Wed, 12 Sep 2018 18:16:03 GMT):
https://github.com/hyperledger/sawtooth-core/tree/master/docs/source
kelly_ (Wed, 12 Sep 2018 18:16:17 GMT):
.rst files get published into this - https://sawtooth.hyperledger.org/docs/core/releases/1.0.5/
kthblmfld (Wed, 12 Sep 2018 18:16:28 GMT):
Ah yeas
kthblmfld (Wed, 12 Sep 2018 18:16:28 GMT):
Oh yea
kthblmfld (Wed, 12 Sep 2018 18:16:49 GMT):
Sphinx is on the roadmap
amundson (Wed, 12 Sep 2018 18:17:09 GMT):
one of our uncompleted projects is figuring out how to publish all the component docs together in some good way. still recovering from our rapid repo splitting.
kthblmfld (Wed, 12 Sep 2018 18:17:20 GMT):
I bet
amundson (Wed, 12 Sep 2018 18:17:45 GMT):
but it's pretty easy to publish using different URLs. for some core stuff, it's too separate.
kthblmfld (Wed, 12 Sep 2018 18:17:59 GMT):
Deferring to @ChrisSpanton to ultimately sort out where this fits relative to Sawtooth
kthblmfld (Wed, 12 Sep 2018 18:23:41 GMT):
Judging by the RFCs, NEXT looks to be a consumer of Sawtooth: A use case. I doubt we will be making any changes to Sawtooth Core or SDKs, etc
amundson (Wed, 12 Sep 2018 18:24:24 GMT):
for maintainer (write/merge permission), our current process has been: "1. before adding anyone new, generate a MAINTAINER.md file based on the commit history, excluding infrequent contributors; 2. any new maintainers need to be approved by all other maintainers; 3) github maintainers group for that repo should match the maintainers in the file" Usually I go adjust those maintainer groups. I'd like to bring this repo back into compliance with this so it's not an exception. So I propose we figure out that maintainer list based on historical activity and then vote new folks in.
kthblmfld (Wed, 12 Sep 2018 18:25:55 GMT):
Got it. Will add MAINTAINER.md
amundson (Wed, 12 Sep 2018 18:26:39 GMT):
I guess it's plural MAINTAINERS.md
amundson (Wed, 12 Sep 2018 18:26:42 GMT):
example - https://github.com/hyperledger/sawtooth-core/blob/master/MAINTAINERS.md
kelly_ (Wed, 12 Sep 2018 18:27:14 GMT):
@amundson the 'general rule' of go try to figure out the existing undocumented conventions is a burden on new contributors and increases the likelihood that they won't be 'conforming'. so probably better to be specific where you can
adamgering (Wed, 12 Sep 2018 18:29:45 GMT):
What's a good practice for work-in-progress documentation, wireframes, diagrams, etc? We want to drop docs into sphinx-doc, but not ephemeral stuff and don't want to slow down collaborative editing with pull requests.
kthblmfld (Wed, 12 Sep 2018 18:38:43 GMT):
It would be great if we incorporate/contribute any findings to the Hyperledger ecosystem to simplify the process for future teams.
kelly_ (Wed, 12 Sep 2018 18:40:43 GMT):
@kthblmfld I think for real time WIP documentation the closest collaborative tool we've used is google docs
kelly_ (Wed, 12 Sep 2018 18:43:22 GMT):
other than that it is the RFC process in sawtooth-rfcs
amundson (Wed, 12 Sep 2018 18:45:22 GMT):
it's currently a struggle, because we try not to put half-baked/unmaintained docs out for consumption, but that makes it harder to be inclusive in discussions. we tend to shoot things around chat a lot in addition to google docs.
amundson (Wed, 12 Sep 2018 18:45:36 GMT):
the RFC process has been good for design docs
amundson (Wed, 12 Sep 2018 18:46:01 GMT):
there are a lot of supply chain RFCs which are essentially app RFCs
kthblmfld (Wed, 12 Sep 2018 18:53:48 GMT):
Ok. I have some research to do on the RFC process.
kthblmfld (Wed, 12 Sep 2018 18:55:31 GMT):
We have a lot of fluctuation happening internally in the project as well. I get the impression there is lots of evolution underway in the Hyperledger ecosystem. As such, we need to be flexible and adaptive.
kelly_ (Wed, 12 Sep 2018 18:59:03 GMT):
probably too heavy of a lift at this point, it's more important onces a project reaches a more 'mature' status with a number of participants invested in the project
kelly_ (Wed, 12 Sep 2018 18:59:10 GMT):
so that the community can provide discussion aroudn it
kthblmfld (Wed, 12 Sep 2018 19:18:53 GMT):
Agreed
adamgering (Wed, 12 Sep 2018 19:23:09 GMT):
I liked that GitHub Wiki supports reStructuredText, so it's easy to copy stuff into Sphinx-Doc. Using a separate repo for WIP docs and RFCs, with or without the Wiki, may be the way to go.
kthblmfld (Wed, 12 Sep 2018 19:24:42 GMT):
I am interested in better understand how the build pipelines are set up. Most of what I see now is built around Fabric.
kthblmfld (Wed, 12 Sep 2018 19:24:42 GMT):
I am interested in better understanding how the build pipelines are set up. Most of what I see now is built around Fabric.
kthblmfld (Wed, 12 Sep 2018 19:24:42 GMT):
I am interested in better understanding how the build pipelines operate. Most of what I see now is built around Fabric.
Dan (Wed, 12 Sep 2018 19:29:45 GMT):
Yeah only fabric was using the LF resources for build until recently.
Dan (Wed, 12 Sep 2018 19:30:26 GMT):
We had a gating issue in sawtooth core that our jenkins approach didn't use jenkins job builder. We recently updated for that and plan to move our build on to the LF build servers soon.
Dan (Wed, 12 Sep 2018 19:32:27 GMT):
The Jenkins file in sawtooth core should be a start.
I don't have strong feeling about CI conformity. For me getting over to LF maintenance was motivated mostly by cost. No need for us to pay for extra hardware. Most of the administration still relies on the project but the LF does have some administrative support.
kthblmfld (Wed, 12 Sep 2018 19:33:11 GMT):
Nice. I will check it out. Thanks @Dan
mtn206 (Wed, 12 Sep 2018 22:56:19 GMT):
Hi @kelly_ - just wanted to let you know I recorded your issue in the github repo as issue #63 and I have a PR pending that will fix the issue once it gets merged.
kelly_ (Wed, 12 Sep 2018 23:20:46 GMT):
@mtn206 awesome thanks!
VipinB (Thu, 13 Sep 2018 15:04:41 GMT):
Has joined the channel.
adamgering (Thu, 13 Sep 2018 15:17:47 GMT):
I'd like to propose a secondary repository, sawtooth-next-directory-wg (working group) for the purposes RFCs and work-in-progress documentation. Any comments or objections or support of that?
adamgering (Thu, 13 Sep 2018 15:17:47 GMT):
I'd like to propose a secondary repository, sawtooth-next-directory-wg (working group) for the purposes RFCs and work-in-progress documentation. Any comments or objections? If not, I'll open a helpdesk request to create that.
adamgering (Thu, 13 Sep 2018 15:20:25 GMT):
Similar to the sawtooth-rfcs repo, but not scoped solely for RFCs.
VipinB (Thu, 13 Sep 2018 15:20:39 GMT):
I have to run. Thanks @ChrisSpanton, your presentation is publicly available? If so, we might use some of this to represent the Enterprise view point
VipinB (Thu, 13 Sep 2018 15:21:54 GMT):
In the Identity WG paper-please let me know if is OK?
Dan (Thu, 13 Sep 2018 15:28:48 GMT):
@adamgering the term 'working group' might be confused with the higher level working groups at hyperledger. Maybe 'design'? (That said I can see that anything is going to be a long repo name). Regardless of that think about using branches for intermediate work on docs.
kthblmfld (Thu, 13 Sep 2018 15:30:00 GMT):
sawtooth-next-directory-wip?
adamgering (Thu, 13 Sep 2018 15:49:04 GMT):
https://jira.hyperledger.org
adamgering (Thu, 13 Sep 2018 15:49:04 GMT):
https://jira.hyperledger.org (Hyperledger JIRAs)
colincmcc (Thu, 13 Sep 2018 15:49:05 GMT):
Has joined the channel.
amundson (Thu, 13 Sep 2018 15:52:46 GMT):
@adamgering you can attach files to jira tickets, which would provide a central place to collab on a specific feature without creating PRs.
adamgering (Thu, 13 Sep 2018 15:53:50 GMT):
Great, thanks, that will work for specific use cases.
amundson (Thu, 13 Sep 2018 15:56:46 GMT):
what are the other uses cases you are trying to solve?
agoldingay (Thu, 13 Sep 2018 16:18:14 GMT):
Good morning All! Info for daily stand-up at 11:30am PST dial in/link: 1-844-202-5500,,4191791129# https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L
amundson (Thu, 13 Sep 2018 16:32:23 GMT):
@adamgering before you request a repo, probably good to drop a note in #sawtooth-governance; not sure everyone is able to monitor all the channels. we could call a root team vote. thats what we do before accepting new components too (I am going to propose a vote to create a pbft repo later in the week, for example)
ChrisSpanton (Thu, 13 Sep 2018 17:53:59 GMT):
@VipinB the presentation I shared is public information, but I'm not confident there's a link somewhere... let me share one here.
ChrisSpanton (Thu, 13 Sep 2018 17:57:02 GMT):
NEXT Directory Project Overview (from Hyperledger Technical Forum 9/13) - https://www.dropbox.com/s/tokhdfn8btv3nwk/NEXT%20Identity%20Platform%20-%20Overview.pptx?dl=0
adamgering (Thu, 13 Sep 2018 18:01:37 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=BbLCkFKPTr23EITznw) @amundson Great, thanks, we'll do that. I'm first evaluating whether a long-running docs branch on the main repo will suffice.
adamgering (Thu, 13 Sep 2018 18:01:37 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=BbLCkFKPTr23EITznw) @amundson Great, thanks, we'll do that.
adamgering (Thu, 13 Sep 2018 22:18:24 GMT):
Is @ChrisSpanton the owner of the sawtooth-next-directory repo yet? If not, what do we need to do make that happen? Do we need to post a proposal to #sawtooth-governance ?
adamgering (Thu, 13 Sep 2018 22:21:03 GMT):
Github UI doesn't separate pull requests by branch. We could setup a docs only branch that allows for direct editing for the GitHub web UI and not use PRs for that branch. Any reason not to do that?
kthblmfld (Fri, 14 Sep 2018 00:30:12 GMT):
@adamgering Ok with me. Got a POC?
agoldingay (Fri, 14 Sep 2018 17:51:04 GMT):
All, Happy Friday! Info for daily stand-up at 11:30am PST dial in/link: 1-844-202-5500,,4191791129# https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L
agoldingay (Fri, 14 Sep 2018 17:53:16 GMT):
No standup Monday, 9/17/18. :eyeglasses:
PhuocDo (Mon, 17 Sep 2018 05:48:44 GMT):
Has joined the channel.
PhuocDo (Mon, 17 Sep 2018 05:50:33 GMT):
I just downloaded the project, loaded the web ui, but can't sign up. Dev console prints an error.
PhuocDo (Mon, 17 Sep 2018 05:50:41 GMT):
Screen Shot 2018-09-16 at 10.49.11 PM.png
kthblmfld (Mon, 17 Sep 2018 16:15:33 GMT):
Hi @PhuocDo . I have a PR out to address that. In the meantime, you will need to rename server/config.py.example -> server/config.py
amundson (Mon, 17 Sep 2018 16:54:55 GMT):
@adamgering what's the use case for the docs-only branch? is that to use one branch like a wiki (essentially)?
adamgering (Mon, 17 Sep 2018 16:58:37 GMT):
Yes, exactly. I don't see a good way of filtering pull requests, thus for building up documentation from scratch, direct edits on a docs branch instead of PRs will avoid polluting our PRs with documentation updates. Docs branch can be a superset of the documentation that will be copied over to the /docs folder in master for official release.
amundson (Mon, 17 Sep 2018 17:10:42 GMT):
why not just build them up in master as part of the normal development flow?
amundson (Mon, 17 Sep 2018 17:12:51 GMT):
one of the nice things we have (in most the repos anyway) is that the master docs tend to track master pretty well, so during release time, there isn't a lot of extra work to do (some, but it is usually relatively minor at that point). plus, when we publish docs, then we can have latest master / nightly URL which reflects content in master instead of a release branch/version.
amundson (Mon, 17 Sep 2018 17:13:12 GMT):
for example, for core, our latest release is 1.0.5 - https://sawtooth.hyperledger.org/docs/core/releases/latest/
amundson (Mon, 17 Sep 2018 17:13:55 GMT):
but we also have latest master nightly docs - https://sawtooth.hyperledger.org/docs/core/nightly/master/
amundson (Mon, 17 Sep 2018 17:15:08 GMT):
this let us work on 1.1.x while keeping the release docs fixed at 1.0, which has worked fairly well
amundson (Mon, 17 Sep 2018 17:15:33 GMT):
and once we do the 1.1 release, we will still have 1.0 docs, 1.1 docs, and master (which is now 1.2.x)
amundson (Mon, 17 Sep 2018 17:17:10 GMT):
we very much take a docs-as-code approach for this so we get the same PR review, commit history, etc.
amundson (Mon, 17 Sep 2018 17:21:42 GMT):
kind of related - we are working on updating the website (https://sawtooth.hyperledger.org/) so that we can do non-docs publishing there too. (for example, maybe want to add some sabre or supply chain or next directory webpages there that aren't derived from the docs). this is also meant to help with our publishing of content that is really cross-component that doesn't really have a good home now.
ChrisSpanton (Mon, 17 Sep 2018 17:25:30 GMT):
Thanks @amundson for filling in the docs approach - seems rather sensible. @adamgering does this address your concerns? Raise any? The website would be valuable I'm sure to provide landing-page type content as well. Will stay tuned there.
amundson (Mon, 17 Sep 2018 17:33:39 GMT):
re:website - basically we are doing these things 1) get existing content mostly in the repo - finishing this PR -
https://github.com/hyperledger/sawtooth-website/pull/3; 2) add some docker/docker-compose stuff so we can all spin up the website; 3) define a publishing/build mechanism for markdown using jekyll to make it easier to modify; 4) maybe some linting stuff; 5) longer term - try and merge docs from different repos in a better way, at least for "platform" components that run alongside core like PoET, Raft, PBFT, Sabre, etc.
amundson (Mon, 17 Sep 2018 17:34:07 GMT):
after (3), it should be pretty easy to add subpages to the site
amundson (Mon, 17 Sep 2018 17:35:20 GMT):
my biggest concern is after we do all those technical things, getting it looking flashy enough
amundson (Mon, 17 Sep 2018 17:35:44 GMT):
i.e. write really good templates for jekyll
amundson (Mon, 17 Sep 2018 17:36:38 GMT):
re: landing-page - exactly
amundson (Mon, 17 Sep 2018 17:39:18 GMT):
it will also be a reasonable place to but slides and other marketing-like artifacts that we want folks do be able to download but don't currently have a great home
amundson (Mon, 17 Sep 2018 17:44:21 GMT):
@ChrisSpanton @adamgering from a roadmap perspective, it might be good for next directory to support deployment on Sabre eventually, because the management story is much better from a deployment standpoint. would require rewriting the TP though in (probably) Rust. we recently rewrite supply chain TP so it is Sabre-compatible. so currently supply chain can run as either a stand alone TP or as a sabre smart contract.
adamgering (Mon, 17 Sep 2018 17:47:31 GMT):
I've been going through the supply chain source code. Indeed that will be something worth considering.
adamgering (Mon, 17 Sep 2018 17:50:05 GMT):
For the docs, Sphinx is still the primary documentation platform? How does Jekyll plug in?
amundson (Mon, 17 Sep 2018 17:57:45 GMT):
yes, sphinx is the standard for docs. we plan on using jekyll for sawtooth-website because we want to enable building a better website (and currently perceive it as enabling that more than sphinx). sphinx has worked well, and its cool we can generate PDFs and such (which, BTW, I think we should expose to users but right now we just build). as long as every component is using sphinx, when we get to step (5) and try and merge docs in some more creative ways I think we will be fairly successful at getting what we want as an end result.
amundson (Mon, 17 Sep 2018 17:58:22 GMT):
we aren't using jekyll yet, that's a new thing we are going to try and enable this week in the website repo
adamgering (Mon, 17 Sep 2018 17:59:35 GMT):
Ok, excellent. I will be watching docs repo on core and taking some hints from there.
amundson (Mon, 17 Sep 2018 17:59:53 GMT):
for docs, I think of it as "we are trying to write a book" and try and set our expectations at that level in terms of review
adamgering (Mon, 17 Sep 2018 18:00:21 GMT):
How is sawtooth.hyperledger.org hosted?
amundson (Mon, 17 Sep 2018 18:01:23 GMT):
via apache currently
amundson (Mon, 17 Sep 2018 18:01:50 GMT):
the idea was to allow us to put rewrite rules to keep urls working, though we haven't done a lot of that yet
adamgering (Mon, 17 Sep 2018 18:04:24 GMT):
Let us know when you are looking to "merge docs from different repos" and we can make sure NEXT Directory docs is compatible for merging, just in case it makes sense to do so (I'm not sure it does).
amundson (Mon, 17 Sep 2018 18:05:49 GMT):
probably before that we can just publish them like we do supply chain - https://sawtooth.hyperledger.org/docs/
amundson (Mon, 17 Sep 2018 18:07:54 GMT):
we have some script-fu that grabs the tar balls from jenkins (once a night for nightly, on command for releases)
amundson (Mon, 17 Sep 2018 18:08:33 GMT):
those scripts will make it into the website repo too, just not as interesting to talk about :)
adamgering (Mon, 17 Sep 2018 18:31:06 GMT):
rbac-server is presently failing on a python exception.
"rbac-server_1 | "Cannot subscript an existing Union. Use Union[u, t] instead.")
rbac-server_1 | TypeError: Cannot subscript an existing Union. Use Union[u, t] instead."
It appears this is being caused by a breaking change in a python library dependency and not any recent commit.
adamgering (Mon, 17 Sep 2018 18:31:28 GMT):
Anyone able to take a look at that?
PhuocDo (Mon, 17 Sep 2018 18:59:18 GMT):
@kthblmfld do you mean move config.py.example to config.py instead of copy? I tried that, same error.
kthblmfld (Mon, 17 Sep 2018 18:59:47 GMT):
Actually, it looks like a defect was merged into master last week
adamgering (Mon, 17 Sep 2018 21:40:43 GMT):
It appears sanic is broken.
adamgering (Mon, 17 Sep 2018 21:40:44 GMT):
https://github.com/huge-success/sanic/issues/1321
adamgering (Mon, 17 Sep 2018 21:41:22 GMT):
It does bring up the issue of how to lock down python dependencies to a known working version. Suggestions?
adamgering (Mon, 17 Sep 2018 21:41:22 GMT):
It does bring up the issue of how to lock down python dependencies to known working versions. Suggestions?
adamgering (Mon, 17 Sep 2018 21:41:22 GMT):
It does bring up the issue of locking down python dependencies to known working versions.
adamgering (Mon, 17 Sep 2018 23:26:29 GMT):
I put PR #110 on master, as develop is a commit behind. How do we merge master to develop or vice versus with the repo branch constraints?
adamludvik (Tue, 18 Sep 2018 02:38:12 GMT):
Has joined the channel.
ZorbaGrue (Tue, 18 Sep 2018 13:49:03 GMT):
Has joined the channel.
agoldingay (Tue, 18 Sep 2018 14:44:20 GMT):
Good morning, today's standup is cancelled. Will meet again tomorrow. Thanks!
adamgering (Tue, 18 Sep 2018 17:14:50 GMT):
Zoom: 273-872-7621
adamgering (Tue, 18 Sep 2018 17:15:06 GMT):
https://zoom.us/j/2738727621
pgobin (Tue, 18 Sep 2018 20:43:14 GMT):
Has joined the channel.
ChrisSpanton (Tue, 18 Sep 2018 22:49:25 GMT):
@kthblmfld I havent seen a PR yet for the MAINTAINERS.md addition... have you started to work on that? I'll do so if not
kthblmfld (Tue, 18 Sep 2018 22:50:26 GMT):
Hey @ChrisSpanton No, haven't started on it but we need one
kthblmfld (Tue, 18 Sep 2018 22:51:34 GMT):
@adamgering was looking for Phil's handle earlier
ChrisSpanton (Tue, 18 Sep 2018 22:52:17 GMT):
Got it. Expect some chatter as we flesh out the initial list. Per @amundson we should follow the standard of requiring existing maintainers to approve the commit to change it before the HL team grants the permissions
kthblmfld (Tue, 18 Sep 2018 22:52:41 GMT):
Deal
ChrisSpanton (Tue, 18 Sep 2018 23:06:03 GMT):
@all OK folks - proposal was to vote folks in to MAINTAINERS.md. Once we work get the base list identified, I'll work with the HL team to get the group set and permissions assigned. I'd like to suggest the following (please let me know if I'm missing anyone, or should remove anyone):
ChrisSpanton (Tue, 18 Sep 2018 23:06:48 GMT):
| Name | GitHub | RocketChat |
| --- | --- | --- |
| Chris Spanton | chrisspanton | ChrisSpanton |
| Keith Bloomfield | kthblmfld | kthblmfld |
| Yunhang Chen | yunhangc | yunhangc |
| Michael Nguyen | mtn217 | mtn206 |
| Satish Malireddi | devsatishm | devsatishm |
| Adam Gering | adamgering | adamgering |
ChrisSpanton (Tue, 18 Sep 2018 23:07:27 GMT):
We have additional contributors who were active early in the project, though havent been lately. I'm certainly open to including them if it seems appropriate, but will defer to the greater team
kthblmfld (Tue, 18 Sep 2018 23:08:48 GMT):
This looks like a good start. Trying to think of who else I've seen contribute recently. Nick?
ChrisSpanton (Tue, 18 Sep 2018 23:10:28 GMT):
I'm not sure Nick has made any commits...
ChrisSpanton (Tue, 18 Sep 2018 23:10:36 GMT):
I'll leave this here for a bit to hear from anyone else before I take action
kthblmfld (Tue, 18 Sep 2018 23:10:39 GMT):
No commits
amundson (Tue, 18 Sep 2018 23:12:08 GMT):
```% git shortlog -s -n
56 Boyd Johnson
40 Zac Delventhal
40 Darian Plumb
17 dplumb94
12 Michael Nguyen
11 Chris Spanton
11 Yunhang Chen
8 Andrew Donald Kennedy
7 Mike Zaccardo
6 Adam Gering
5 Richard Chen
5 cianx
4 Kevin O'Donnell
3 keithbloomfield
3 Keith Bloomfield
3 Cian Montgomery
2 Griffin Howlett
2 Ry Jones
2 Satish Malireddi
1 Nicholas Criss
1 Adam Ludvik```
amundson (Tue, 18 Sep 2018 23:14:25 GMT):
the approach we took in other repos was to base the initial maintainer list on committers
ChrisSpanton (Tue, 18 Sep 2018 23:14:57 GMT):
Right. Valuable to have the list there as we build the initial list. Thoughts about recency bias, given the desire to have approval from all before modifying?
amundson (Tue, 18 Sep 2018 23:19:00 GMT):
we did not vote on previous lists of maintainers per-se, we agreed on reasonable rules for constructing the list based on who had written code (based on commits). so we could say "top 5 committers", which would be Boyd, Zac, Darian, Michael, Chris, Yunhang (6, because 5th is tied)
kthblmfld (Tue, 18 Sep 2018 23:19:06 GMT):
Some of those folks are either long gone or otherwise unresponsive
ChrisSpanton (Tue, 18 Sep 2018 23:22:19 GMT):
We can certainly establish guidelines to make this currently relevant (definitely would love to hear what other projects have done however for precedent)
ChrisSpanton (Tue, 18 Sep 2018 23:23:10 GMT):
Suppose we make an attempt to reach the folks who fit that description (top 5), and if we don't hear back bump down the line, and if we do confirm whether they would like to be an active maintainer or defer their spot
amundson (Tue, 18 Sep 2018 23:23:58 GMT):
none of these people are long gone from a Sawtooth perspective
ChrisSpanton (Tue, 18 Sep 2018 23:24:02 GMT):
IMHO that would give proper acknowledgement of the contributions from those folks, follow a defined standard, and allow us to build a list of actively engaged maintainers
kthblmfld (Tue, 18 Sep 2018 23:29:49 GMT):
I would love to open the dialog with the previous maintainers of this repo. They could help us ramp up on it and we could share our findings.
amundson (Tue, 18 Sep 2018 23:29:58 GMT):
yeah, you should add them as reviewers too, they might give good input even if it's been a while since they wrote the code
ChrisSpanton (Tue, 18 Sep 2018 23:30:52 GMT):
Alright - unless I hear objections, I'll follow that rule set, and reach out to the folks on the list starting tomorrow
kthblmfld (Tue, 18 Sep 2018 23:32:01 GMT):
My only concern is how many votes we need to add a new contributor. Will we need sign-off from everybody moving forward?
kthblmfld (Tue, 18 Sep 2018 23:32:45 GMT):
I ask because we have one more person onboarding in the next few weeks and I am hoping they get the access they need
amundson (Tue, 18 Sep 2018 23:32:57 GMT):
Yes, everyone has to agree.
kthblmfld (Tue, 18 Sep 2018 23:33:03 GMT):
Ok
ChrisSpanton (Tue, 18 Sep 2018 23:33:05 GMT):
certainly people will be able to contribute without being a maintainer
kthblmfld (Tue, 18 Sep 2018 23:33:18 GMT):
But they can still open PRs
kthblmfld (Tue, 18 Sep 2018 23:33:20 GMT):
Right
ChrisSpanton (Tue, 18 Sep 2018 23:33:22 GMT):
correct
kthblmfld (Tue, 18 Sep 2018 23:33:26 GMT):
Yea that should be ok
amundson (Tue, 18 Sep 2018 23:35:14 GMT):
As an open source project, you should never add people as a maintainer just because you hired them; it should be driven by contributions. They should have a track record of commits and everyone should be comfortable they know the community norms, etc. It does mean that a maintainer has to click 'Merge' for them until they get to that point.
kthblmfld (Tue, 18 Sep 2018 23:35:37 GMT):
Yep
kthblmfld (Tue, 18 Sep 2018 23:35:40 GMT):
That makes sense
amundson (Tue, 18 Sep 2018 23:35:50 GMT):
I've onboarded many new employees since we put this in place and it's kind of annoying but seems appropriate.
kthblmfld (Tue, 18 Sep 2018 23:36:25 GMT):
Nah it seems fair, just a few adjustments for me coming from the closed source enterprise background
kthblmfld (Tue, 18 Sep 2018 23:36:25 GMT):
Nah it seems fair, just a few adjustments for me coming from the closed source enterprise backgroundYe
kthblmfld (Tue, 18 Sep 2018 23:36:25 GMT):
Yea it seems fair, just a few adjustments for me coming from the closed source enterprise backgroundYe
kthblmfld (Tue, 18 Sep 2018 23:36:25 GMT):
Yea it seems fair, just a few adjustments for me coming from the closed source enterprise background
amundson (Tue, 18 Sep 2018 23:38:26 GMT):
the other annoying thing is that they can't set reviewers, but there is a file you can add for that - let me find an example
amundson (Tue, 18 Sep 2018 23:39:02 GMT):
https://github.com/hyperledger/sawtooth-seth/blob/master/CODEOWNERS
amundson (Tue, 18 Sep 2018 23:39:42 GMT):
we were piloting that in the seth repo, because knkski was doing a lot of work before he was a maintainer. that helped a lot.
kthblmfld (Tue, 18 Sep 2018 23:39:52 GMT):
Hmmm
amundson (Tue, 18 Sep 2018 23:40:10 GMT):
probably fair to roll it out to the rest of the repos. it's nice that when you create a PR it adds all the maintainers for you.
kthblmfld (Tue, 18 Sep 2018 23:41:13 GMT):
Does it add contributors to maintainers? Auto-assign code reviewers? Both?
amundson (Tue, 18 Sep 2018 23:42:23 GMT):
that list matches what is in MAINTAINER.md. it's a file solely for github and auto-assigns code reviewers. You can use the file in other ways, but thus far we are avoiding that complexity (this all seems complex enough) and just using it because it gives us auto-assignment.
amundson (Tue, 18 Sep 2018 23:43:10 GMT):
it also then matches the associated github maintainers group since that also matches MAINTAINERS.md
ChrisSpanton (Tue, 18 Sep 2018 23:47:43 GMT):
Thanks for the input putting this process together @amundson - definitely appreciated.
amundson (Tue, 18 Sep 2018 23:48:02 GMT):
@ChrisSpanton I can update the github permissions once this is checked in so it's all consistent with the other repos.
ChrisSpanton (Tue, 18 Sep 2018 23:48:59 GMT):
Perfect. I'll start connecting with people tomorrow, and figure they should have a few days to respond? I'll shoot for a commit EOW
amundson (Tue, 18 Sep 2018 23:49:12 GMT):
for anyone else that isn't in that maintainers list, we need to make sure they are added to another read-only group so that they can do code reviews, etc.
amundson (Tue, 18 Sep 2018 23:50:11 GMT):
(including new developers)
amundson (Tue, 18 Sep 2018 23:51:28 GMT):
that other group is cross-project so when we add someone they can be added as a reviewer for any sawtooth repo. so actually, all the maintainers need to be in that list too. I can try and verify all this when I update it.
amundson (Tue, 18 Sep 2018 23:52:04 GMT):
@ChrisSpanton you could just create the file with that list, then ask them to approve the PR, and if you get all 5/6 approvals, then merge it
amundson (Tue, 18 Sep 2018 23:52:20 GMT):
if someone wants to op out or something, just update the PR
ChrisSpanton (Tue, 18 Sep 2018 23:52:35 GMT):
touche
amundson (Tue, 18 Sep 2018 23:53:01 GMT):
some of us non-maintainers can throw on our not-important approvals too if we want, showing our support :)
ChrisSpanton (Tue, 18 Sep 2018 23:53:22 GMT):
:)
PhuocDo (Tue, 18 Sep 2018 23:53:32 GMT):
@adamgering @kthblmfld latest master is broken, I got validator errors.
PhuocDo (Tue, 18 Sep 2018 23:53:36 GMT):
Screen Shot 2018-09-18 at 4.53.02 PM.png
PhuocDo (Tue, 18 Sep 2018 23:54:05 GMT):
sanic change?
kthblmfld (Tue, 18 Sep 2018 23:55:11 GMT):
That one looks new
ChrisSpanton (Tue, 18 Sep 2018 23:56:05 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=NdmRTQiaYwCnxxAqz) @PhuocDo yes, @adamgering indicated earlier that it appears a sanic change broke it...
kthblmfld (Tue, 18 Sep 2018 23:56:44 GMT):
We merged a change that sets the version of Sanic to an earlier release
kthblmfld (Tue, 18 Sep 2018 23:56:57 GMT):
@PhuocDo have you synced with master?
ChrisSpanton (Tue, 18 Sep 2018 23:57:04 GMT):
Ah, perfect
kthblmfld (Tue, 18 Sep 2018 23:58:11 GMT):
There is an issue that comes up when you have too many docker images built
PhuocDo (Tue, 18 Sep 2018 23:58:45 GMT):
@kthblmfld could be
kthblmfld (Tue, 18 Sep 2018 23:58:49 GMT):
Still haven't narrowed down the specific root cause, but deleting the containers/images and rebuilding helps
kthblmfld (Tue, 18 Sep 2018 23:59:01 GMT):
bring down the app
kthblmfld (Tue, 18 Sep 2018 23:59:07 GMT):
do a docker-compose down
kthblmfld (Tue, 18 Sep 2018 23:59:28 GMT):
docker rm -vf $(docker ps -a -q)
kthblmfld (Tue, 18 Sep 2018 23:59:35 GMT):
docker rmi -f $(docker images -a -q)
kthblmfld (Tue, 18 Sep 2018 23:59:44 GMT):
And then
kthblmfld (Tue, 18 Sep 2018 23:59:50 GMT):
docker-compose up --build
PhuocDo (Wed, 19 Sep 2018 00:00:02 GMT):
trying it
agoldingay (Wed, 19 Sep 2018 16:53:24 GMT):
good morning! stand-up details: https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L 1-844-202-5500,,4191791129# (Northwest) English (United States). thanks!
boydjohnson (Wed, 19 Sep 2018 17:58:24 GMT):
Hey @ChrisSpanton looking forward to the Maintainers PR. Do you have an expected timeline?
ChrisSpanton (Wed, 19 Sep 2018 18:06:46 GMT):
@boydjohnson definitely! should push that in today, im tied up for the next bit this morning
boydjohnson (Wed, 19 Sep 2018 18:07:00 GMT):
Thanks!
ChrisSpanton (Wed, 19 Sep 2018 18:16:23 GMT):
@agoldingay stand-up is at 11:30 AM PST, correct? Might be good to include that with the link!
agoldingay (Wed, 19 Sep 2018 18:21:50 GMT):
@ChrisSpanton correct 11:30AM PST. Thanks!
adamgering (Wed, 19 Sep 2018 23:54:12 GMT):
Any reason not to name all the containers?
ahadi (Thu, 20 Sep 2018 01:14:29 GMT):
Has joined the channel.
PhuocDo (Thu, 20 Sep 2018 05:08:15 GMT):
@kthblmfld i got the UI to run after image cleanup, thanks!
kthblmfld (Thu, 20 Sep 2018 05:08:31 GMT):
Awesome! Glad to hear that
kthblmfld (Thu, 20 Sep 2018 05:09:13 GMT):
It is a workaround until we can get to the bottom of why it is happening in the first place
pankajgoyal (Thu, 20 Sep 2018 08:43:35 GMT):
Has joined the channel.
agoldingay (Thu, 20 Sep 2018 16:12:32 GMT):
Good morning! Today's standup 11:30am PST, https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L, 1-844-202-5500,,4191791129# (Northwest) English (United States)
ChrisSpanton (Thu, 20 Sep 2018 20:38:02 GMT):
I've made comments to PR #119 - Add MAINTAINERS.md. Would love to see some dialog from those listed there. Everyone on the list has been added as a reviewer, so should have visibility.
kelly_ (Thu, 20 Sep 2018 21:20:06 GMT):
@zac @dplumb ^
zac (Thu, 20 Sep 2018 21:20:07 GMT):
Has joined the channel.
dplumb (Thu, 20 Sep 2018 21:41:14 GMT):
Hi team! I approved the PR. Focused on other work right now, but I'm happy to help answer questions and review PRs.
pgobin (Thu, 20 Sep 2018 22:47:06 GMT):
ui scaffolding feature branch wip: https://github.com/pgobin/sawtooth-next-directory/tree/scaffolding. would love some feedback. thanks!
pgobin (Thu, 20 Sep 2018 22:52:04 GMT):
split travis build into two stages: https://github.com/pgobin/sawtooth-next-directory/commit/0dd9e3b5d415ce97aa02780a098bded6310b8daf
kthblmfld (Thu, 20 Sep 2018 23:35:29 GMT):
Hello @dplumb. Thanks! Glad to have you checking out PRs.
kthblmfld (Thu, 20 Sep 2018 23:35:29 GMT):
Hello @dplumb . Thanks! Glad to have you checking out PRs.
kthblmfld (Thu, 20 Sep 2018 23:36:35 GMT):
Hello @pgobin . The Travis change looks good. Will need to checkout and deploy the ui scaffolding change to check it out, but the sooner it happens, the better
kthblmfld (Thu, 20 Sep 2018 23:36:35 GMT):
Hello @pgobin . The Travis change looks good. Will need to checkout and deploy the ui scaffolding change to test drive the features, but the sooner it happens, the better
adamgering (Fri, 21 Sep 2018 18:11:20 GMT):
What systems do people want to use for development, staging and production log analytics?
adamgering (Fri, 21 Sep 2018 18:12:46 GMT):
@devsatishm @ChrisSpanton what do you guys want/intend to use for production log analytics and health monitoring?
amundson (Sat, 22 Sep 2018 01:55:25 GMT):
@adamgering it's not log analytics, but we use grafana for Sawtooth metrics collection/display a lot and it's been pretty nice. for reference - https://github.com/hyperledger/sawtooth-core/tree/master/docker/grafana https://github.com/hyperledger/sawtooth-core/tree/master/docker/influxdb
amundson (Sat, 22 Sep 2018 01:55:53 GMT):
also, telegraf for os metrics - https://github.com/hyperledger/sawtooth-core/blob/master/docker/telegraf.conf
danintel (Sat, 22 Sep 2018 02:16:33 GMT):
https://sawtooth.hyperledger.org/docs/core/nightly/master/sysadmin_guide/grafana_configuration.html
agoldingay (Mon, 24 Sep 2018 17:42:06 GMT):
Good morning! Daily stand-up details: M-F unless otherwise posted in this chat forum, 11:30am PST, https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L, 1-844-202-5500,,4191791129# (Northwest) English (United States). All are welcome!
pgobin (Mon, 24 Sep 2018 19:03:18 GMT):
hey everyone. i'd like to leverage sauce labs (https://saucelabs.com/products/open-source-frameworks/selenium) for automated ui tests. it's advertised as free for open source projects, however there is a 5-day approval process. does anyone have any suggestions/objections about whether this is something we might use? more broadly, how does the team feel generally about cloud-based ui testing for this project?
amundson (Mon, 24 Sep 2018 19:09:56 GMT):
it is more community-friendly to avoid proprietary solutions to the extent possible (though we have several exceptions - github, JIRA)
kthblmfld (Mon, 24 Sep 2018 19:10:59 GMT):
@pgobin I am onboard with any level of additional automated testing we can shim in. Saucelabs would help ensure responsive design on the UI. It will require hosting the app somewhere, and managing the data in such a way as to allow multiple (and possible parallel) test runs
kthblmfld (Mon, 24 Sep 2018 19:10:59 GMT):
@pgobin I am onboard with any level of additional automated testing we can shim in. Saucelabs would help ensure responsive design on the UI. It will require hosting the app somewhere, and managing the data in such a way as to allow multiple (and possibly parallel) test runs
kthblmfld (Mon, 24 Sep 2018 19:11:37 GMT):
I haven't given much though to UI compatibility
kthblmfld (Mon, 24 Sep 2018 19:11:37 GMT):
I haven't given much thought to UI compatibility
kthblmfld (Mon, 24 Sep 2018 19:12:45 GMT):
Considering the amount of weirdness we are experiencing in the UI, regressions and videos would come in handy
kthblmfld (Mon, 24 Sep 2018 19:13:37 GMT):
Are you thinking full e3e tests or testing the UI in isolation from the rest api?
kthblmfld (Mon, 24 Sep 2018 19:13:37 GMT):
Are you thinking full e2e tests or testing the UI in isolation from the rest api?
amundson (Mon, 24 Sep 2018 19:15:45 GMT):
@pgobin whatever you come up with, it would be cool to see a demo of it as you go; we have other components and/or apps that this would be relevant to
bobonana (Mon, 24 Sep 2018 19:33:10 GMT):
Has joined the channel.
pgobin (Mon, 24 Sep 2018 22:22:02 GMT):
@kthblmfld i am thinking full e2e, api included.
kthblmfld (Mon, 24 Sep 2018 22:40:09 GMT):
Ok great
rockyr1 (Wed, 26 Sep 2018 18:02:03 GMT):
Has joined the channel.
pgobin (Wed, 26 Sep 2018 19:15:02 GMT):
sauce labs requires: a text link and/or logo + link on the repo.
pgobin (Wed, 26 Sep 2018 19:15:24 GMT):
yoursaucelabsopensauceaccountrequesthasbeenapproved.zip
pgobin (Wed, 26 Sep 2018 20:34:13 GMT):
i've just opened pr #138 (https://github.com/hyperledger/sawtooth-next-directory/pull/138). i would love to see feedback/suggestions. thanks everyone.
kthblmfld (Wed, 26 Sep 2018 21:00:17 GMT):
@pgobin It looks great. Thanks for getting it out there. Looking forward to cutting over the the shiny new React UI
pgobin (Wed, 26 Sep 2018 21:51:58 GMT):
does anyone have an opinion on whose email is best to use to create our Sauce Labs account?
agoldingay (Wed, 26 Sep 2018 22:52:58 GMT):
If you could use NEXT Identify that way it's organization agnostic in some way, shape or form. my 2 cents.
agoldingay (Wed, 26 Sep 2018 23:06:07 GMT):
Identity
kthblmfld (Thu, 27 Sep 2018 00:40:41 GMT):
I am thinking @ChrisSpanton's email would be good so he can own/manage it over time. I think we can create subaccounts under it
kthblmfld (Thu, 27 Sep 2018 00:40:41 GMT):
@ChrisSpanton's email would be good so he can own/manage it over time. I think we can create subaccounts under it
kthblmfld (Thu, 27 Sep 2018 00:41:21 GMT):
Maybe... It has been so long since I've used Saucelabs
ChrisSpanton (Thu, 27 Sep 2018 00:56:22 GMT):
I wonder if there’s opportunity to use a LF/Hyperledger DL and add the maintainers to it? I’d hate to centralize this on me if we can distribute it somehow.
pgobin (Thu, 27 Sep 2018 02:08:58 GMT):
@kthblmfld i was told we get 2 sub-accounts.
kthblmfld (Thu, 27 Sep 2018 02:09:53 GMT):
Ah great
adamgering (Thu, 27 Sep 2018 19:53:25 GMT):
Who is coming to the design session?
adamgering (Thu, 27 Sep 2018 19:53:43 GMT):
Keith & i are in the NP5 Cafe.
agoldingay (Thu, 27 Sep 2018 19:57:47 GMT):
coming...on a call.
agoldingay (Thu, 27 Sep 2018 19:57:53 GMT):
look for Abishek and Phil, Ned and Michael
adamgering (Thu, 27 Sep 2018 20:02:00 GMT):
We’re with Ned and Michael
bobonana (Thu, 27 Sep 2018 23:50:18 GMT):
Hey, sorry if this isn't the right place to post this, but I've been looking through the linting errors for issue 101 and am mostly seeing a lot of import errors. I've noticed that we have a lot of empty __init__.py files in subdirectories, but can't seem to find a __init__.py file for the whole package in the root project directory. Do we consider the whole project to be one python package, with all of our subdirectories as modules?
kthblmfld (Fri, 28 Sep 2018 00:56:51 GMT):
Hey @bobonana, this is a fine place for such a question. I am seeing mostly indentation, spacing, tabs vs spaces, trailing whitespace, (oops, my bad) invalid constant naming. Regarding the top-level init.py: I don't think it needs one since some subdirectories are not Python (React, protobuf, tests...)
agoldingay (Fri, 28 Sep 2018 17:03:27 GMT):
All, please note. Monday's standup will be held adjacent to Sprint 3 planning that Aly will be facilitating while I'm out. This time will be used for retrospective. Also, please get all your S2 commitments shored up. I'm going to pull all the data and do reporting on it today. so, I have backlog items for the S3 planning. Also, No standup next Tue, 10/2. ty!
kthblmfld (Fri, 28 Sep 2018 17:14:58 GMT):
Thanks @agoldingay. There are 3 PRs that could go in today with some group effort. The 4th ( MAINTAINERS ) needs a bit more discussion about who will be on the list
kthblmfld (Fri, 28 Sep 2018 17:15:58 GMT):
@mtn206 It looks like you have addressed @adamgering 's concerns about defaulting to localhost, but there is a conflict on your branch. Please merge in changes from master so we can get it in.
mtn206 (Fri, 28 Sep 2018 17:16:42 GMT):
Let me get that fixed right now
mtn206 (Fri, 28 Sep 2018 17:16:47 GMT):
Thank you @kthblmfld
kthblmfld (Fri, 28 Sep 2018 17:17:18 GMT):
Also, please review #141 and #139
kthblmfld (Fri, 28 Sep 2018 17:18:48 GMT):
I will work with @adamgering to revisit #139. It may need some reverts and follow-up with HL folks. We shall see!
kthblmfld (Fri, 28 Sep 2018 17:28:57 GMT):
My bad, looks like squash/merge will do for #146. Approved!
bobonana (Fri, 28 Sep 2018 20:15:18 GMT):
Hey, I noticed we have a setup.cfg file in the root project directory, is there a setup.py that uses it or requirements.txt?
bobonana (Fri, 28 Sep 2018 20:34:44 GMT):
If not, should we switch to using one? It looks like our DockerFiles are running `pip install
bobonana (Fri, 28 Sep 2018 20:35:23 GMT):
going off of this: https://jpetazzo.github.io/2013/12/01/docker-python-pip-requirements/
adamgering (Fri, 28 Sep 2018 20:36:02 GMT):
go ahead and try it out, see if you get that working
bobonana (Fri, 28 Sep 2018 23:28:24 GMT):
this was in .pylintrc `missing-docstring,no-member,no-self-use,unused-argument,too-many-arguments,duplicate-code` It doesn't currently work because you need to use specific error codes, not the human-readable error title, but do we want to ignore all of these?
bobonana (Fri, 28 Sep 2018 23:29:41 GMT):
I was planning on ignoring missing docstrings for now, as discussed this morning, but the rest of these strike me as a little extreme, should I go through and fix those errors, or set them to be ignored in .pylintrc?
kthblmfld (Sat, 29 Sep 2018 04:31:16 GMT):
*disclaimer: opinions* In the case of unused arg, I would remove the arg. Duplicate code and too many args are usually code smells/indications of a need for refactoring. Missing docstring seems picky since some functions are self-descriptive enough.
kthblmfld (Sat, 29 Sep 2018 04:31:16 GMT):
*disclaimer: opinions ahead* In the case of unused arg, I would remove the arg. Duplicate code and too many args are usually code smells/indications of a need for refactoring. Missing docstring seems picky since some functions are self-descriptive enough.
kthblmfld (Sat, 29 Sep 2018 04:31:16 GMT):
*disclaimer: opinions ahead::* In the case of unused arg, I would remove the arg. Duplicate code and too many args are usually code smells/indications of a need for refactoring. Missing docstring seems picky since some functions are self-descriptive enough.
bobonana (Mon, 01 Oct 2018 18:48:53 GMT):
That's fair, Docstrings can be redundant a lot of the time, but it allows greater integration with IDEs (if that's something we want, if not then no biggie). I kinda feel like it'd take a long time to add docstrings to everything, so for now should we just ignore them? What about any of those other ignore statements?
bobonana (Mon, 01 Oct 2018 19:24:40 GMT):
I think the simplest solution would be to use Pylint to find actual coding errors, and use black to auto format style. Black is getting pretty popular and won't break our code, I've tested on a few files already and had good results. We can set Pylint to only report errors and ignore conventions, refactors, and possibly warnings. Would that be okay?
adamgering (Tue, 02 Oct 2018 14:41:16 GMT):
Tests should expose all errors, lint is mostly for maintaining uniform code formatting conventions. So whatever looks like best practice.
adamgering (Tue, 02 Oct 2018 18:34:14 GMT):
Technical Feature Planning: https://zoom.us/j/2738727621
bobonana (Tue, 02 Oct 2018 20:19:49 GMT):
so should we ignore all errors with the linter and only show warnings?
dplumb (Tue, 02 Oct 2018 20:53:08 GMT):
@bobonana Some of those lint disables may have been added so that builds didnt fail if some components were stubbed out but not finished. I would recommend eliminating them and see if you get any errors
dplumb (Tue, 02 Oct 2018 20:53:35 GMT):
the `too-many-arguments` is disabled because of the transaction creation methods I would guess
bobonana (Wed, 03 Oct 2018 17:43:02 GMT):
That makes sense. PR #164 should handle all of that. If it gets approved we'll be using Black to auto format any python code, pylint has refactor and convention alerts disabled, so it'll report warnings and errors.
AlyOwens13 (Wed, 03 Oct 2018 18:31:14 GMT):
morning :) standup time, people
amundson (Wed, 03 Oct 2018 22:27:32 GMT):
the too-many-* are disabled because they are bad defaults
ChrisSpanton (Thu, 04 Oct 2018 17:18:51 GMT):
FYI - I'm not going to make standup today. I'll be back for the magic tomorrow.
adamgering (Thu, 04 Oct 2018 17:23:41 GMT):
:thumbsup:
AlyOwens13 (Thu, 04 Oct 2018 18:24:56 GMT):
morning. For the documentation topic - it looks like we are adding docs to https://sawtooth.hyperledger.org/docs/core/releases/latest/
AlyOwens13 (Thu, 04 Oct 2018 18:25:56 GMT):
should we follow the same flow of documentation, roadmaps, releases, etc. as https://github.com/hyperledger/fabric ?
AlyOwens13 (Thu, 04 Oct 2018 18:26:33 GMT):
we may want to get rid of Wiki completely or add the correct link to the docs
adamgering (Thu, 04 Oct 2018 22:25:16 GMT):
Docs are actually here: https://sawtooth.hyperledger.org/docs/
adamgering (Thu, 04 Oct 2018 22:25:16 GMT):
Docs are actually here: https://sawtooth.hyperledger.org/, not fabric.
adamgering (Thu, 04 Oct 2018 22:26:38 GMT):
https://github.com/hyperledger/sawtooth-core/tree/master/docs
adamgering (Thu, 04 Oct 2018 22:30:03 GMT):
Were you suggesting we look at Fabric documentation as a model instead? https://hyperledger-fabric.readthedocs.io
adamgering (Thu, 04 Oct 2018 22:31:03 GMT):
They both are built using Sphinx.
adamgering (Fri, 05 Oct 2018 15:22:18 GMT):
I can't install either one of these. Anyone else able or unable to install these dependencies? (Python 3.7 / OSX)
sawtooth_sdk==1.0.5
sawtooth_signing==1.0.5
kthblmfld (Fri, 05 Oct 2018 16:42:18 GMT):
No
kthblmfld (Fri, 05 Oct 2018 16:42:41 GMT):
I have seen others raise the issue. Has to do with scep256k1
kthblmfld (Fri, 05 Oct 2018 16:42:41 GMT):
I have seen others raise the issue. Has to do with secp256k1
kthblmfld (Fri, 05 Oct 2018 16:43:19 GMT):
requires pkg-config
bobonana (Fri, 05 Oct 2018 18:21:51 GMT):
check here: https://github.com/hyperledger/sawtooth-next-directory/pull/166
>@mtn217 and I fixed his issue by running sudo apt-get install pkg-config libsecp256k1-dev
while some of our imported python packages/libraries depend on them, they are not available through pip and so wouldn't be in requirements.txt.
I don't think we could specify them in a setup.py file either. Should it be added to the contributor/developer documentation as a requirement?
kthblmfld (Fri, 05 Oct 2018 18:23:40 GMT):
Yes. If you have a procedure for installing them, then please capture it.
bobonana (Fri, 05 Oct 2018 18:30:34 GMT):
I'm not sure if there's an OS agnostic way to install them
bobonana (Fri, 05 Oct 2018 18:31:32 GMT):
should we just have links to their respective webpages in our documentation and let developers go from there?
adamgering (Fri, 05 Oct 2018 18:33:56 GMT):
He ran "sudo apt-get install pkg-config libsecp256k1-dev" on OSX?
kthblmfld (Fri, 05 Oct 2018 18:54:42 GMT):
It would be valuable to at least capture the issue so non-OSX folks can work with it and OSX folks have a checkpoint to continue from
kthblmfld (Fri, 05 Oct 2018 18:55:41 GMT):
Otherwise each person will end up spending hours in the rabbit hole
adamgering (Fri, 05 Oct 2018 18:57:50 GMT):
As far as I can tell, these don't work anywhere:
sawtooth_sdk==1.0.5
sawtooth_signing==1.0.5
On OSX they fail. In the docker environment the dependencies are installed via apt-get instead and trying to switch some of them to pip does not work. I don't know any environment where installing these via pip works.
pgobin (Fri, 05 Oct 2018 18:58:35 GMT):
Github aliases/names of team members who need access: *Akashkotian7* (Akash A) *abhisheknairofficial* (Abhishek P)
kthblmfld (Fri, 05 Oct 2018 19:01:16 GMT):
Thanks @pgobin . Do you also have their email addresses?
pgobin (Fri, 05 Oct 2018 19:05:40 GMT):
@kthblmfld *abhishek@moonraft.com* and *akash.a@moonraft.com*
kthblmfld (Fri, 05 Oct 2018 19:06:52 GMT):
Thanks
bobonana (Fri, 05 Oct 2018 19:30:41 GMT):
@adamgering, Michael ran it in Ubuntu. They are not available through pip. I think you'll need to either go here:
https://www.freedesktop.org/wiki/Software/pkg-config/
and here:
https://github.com/bitcoin/secp256k1
to build from scratch, or use a package manager like Homebrew (MacOS), APT/etc.(Unix), or Chocolatey(Windows), etc. to install them.
bobonana (Fri, 05 Oct 2018 19:36:17 GMT):
I'll add these instructions to the readme.md or contributors.md (whichever is appropriate) and add it to PR #174, but I don't think there's a way to automatically install these for developers, we'll just need to document it, similarly to how we document what version of python we're using, etc.
rbuysse (Fri, 05 Oct 2018 19:36:38 GMT):
Has joined the channel.
rberg2 (Fri, 05 Oct 2018 19:40:14 GMT):
Has joined the channel.
rbuysse (Fri, 05 Oct 2018 19:40:46 GMT):
@adamgering Are you getting an error when trying to install sawtooth-signing and sawtooth-sdk?
rbuysse (Fri, 05 Oct 2018 19:40:56 GMT):
It seems to work ok in xenial with pip3
rbuysse (Fri, 05 Oct 2018 19:40:56 GMT):
It seems to work ok for me in xenial with pip3
adamgering (Fri, 05 Oct 2018 21:21:55 GMT):
With regards to OSX, they are either incompatible or require libsecp256k1 to built from source.
adamgering (Fri, 05 Oct 2018 21:23:21 GMT):
With regards to the docker environment and linux environments, they come already with apt-get install python3-sawtooth-sdk python3-sawtooth-rest-api, and don't need to be installed again via pip3.
adamgering (Fri, 05 Oct 2018 21:30:57 GMT):
I did attempt to remove apt-get python3-sawtooth-sdk in favor of the pip installed dependency, and that did not work. Didn't have a reason to investigate further.
adamgering (Fri, 05 Oct 2018 21:30:57 GMT):
I did attempt to remove apt-get python3-sawtooth-sdk in favor of the pip installed dependency, and that did not work. Didn't have a reason to investigate further. This was, however, tested on a python base container instead of a sawtooth base container, so that may have been the culprit.
adamgering (Fri, 05 Oct 2018 21:30:57 GMT):
I did attempt to remove apt-get python3-sawtooth-sdk in favor of the pip installed dependency, and that did not work. Didn't have a reason to investigate further.
bobonana (Mon, 08 Oct 2018 18:00:50 GMT):
works on my machine running osx, there is a difference between the pip install pkgconfig and the required pkg-config dependency.
https://pypi.org/project/pkgconfig/
if you want to go full python for portability and ease of installation @adamgering we could try use pykg-config, which is meant as a drop in replacement for pkg-config
https://pypi.org/project/pykg-config/
agoldingay (Mon, 08 Oct 2018 18:07:01 GMT):
This week's standup details: M-F, 11:30am PST, 1-844-202-5500,,4191791129# (Northwest), https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L :keyboard: :watch:
kthblmfld (Mon, 08 Oct 2018 20:58:20 GMT):
We are experiencing rejections from Github while attempting to push changes. Is anybody aware of any permissions changes made today?
kthblmfld (Mon, 08 Oct 2018 20:59:12 GMT):
In this case, the changes are reverts
amundson (Mon, 08 Oct 2018 20:59:42 GMT):
@kthblmfld I'm not aware of any changes
amundson (Mon, 08 Oct 2018 20:59:45 GMT):
what's the error?
kthblmfld (Mon, 08 Oct 2018 20:59:57 GMT):
It looks like the initial reverting push made it, but the amending signed commit push fails
kthblmfld (Mon, 08 Oct 2018 21:00:14 GMT):
@mtn206 Please share the details
amundson (Mon, 08 Oct 2018 21:00:49 GMT):
you wouldn't be pushing directly to the upstream repo anyway, presumably, you would push to a fork repo and create a PR?
kthblmfld (Mon, 08 Oct 2018 21:01:21 GMT):
That might be it
kthblmfld (Mon, 08 Oct 2018 21:01:50 GMT):
Thanks @amundson . Giving it a try
nadiab22 (Mon, 08 Oct 2018 21:28:38 GMT):
Has joined the channel.
adamgering (Tue, 09 Oct 2018 00:00:04 GMT):
phil
adamgering (Tue, 09 Oct 2018 00:00:11 GMT):
pbobin
pgobin (Tue, 09 Oct 2018 14:22:12 GMT):
needs one more approver: https://github.com/hyperledger/sawtooth-next-directory/pull/200
bobonana (Tue, 09 Oct 2018 18:07:37 GMT):
I can approve this if you wanna add me
bobonana (Tue, 09 Oct 2018 18:07:37 GMT):
I can approve this if you wanna add me @pgobin
pgobin (Tue, 09 Oct 2018 18:17:24 GMT):
@bobonana added as reviewer. thanks. :)
bobonana (Tue, 09 Oct 2018 18:19:28 GMT):
no worries
bobonana (Tue, 09 Oct 2018 18:20:47 GMT):
@adamgering @kthblmfld @mtn206 can we get some reviews of PR #205 so I can close Issue #187?
bobonana (Tue, 09 Oct 2018 18:23:25 GMT):
and @pgobin
pgobin (Tue, 09 Oct 2018 18:26:06 GMT):
pgobin (Tue, 09 Oct 2018 18:26:29 GMT):
NavList is just a React component
bobonana (Tue, 09 Oct 2018 18:38:23 GMT):
we're using both angular and react?
bobonana (Tue, 09 Oct 2018 18:38:23 GMT):
@pgobin we're using both angular and react?
kthblmfld (Tue, 09 Oct 2018 18:40:32 GMT):
Soon ng should go away, correct?
pgobin (Tue, 09 Oct 2018 18:44:16 GMT):
@kthblmfld yes
bobonana (Tue, 09 Oct 2018 20:45:29 GMT):
should we merge Issue #199?
bobonana (Tue, 09 Oct 2018 20:45:29 GMT):
should we merge PR #199?
ChrisSpanton (Tue, 09 Oct 2018 21:17:48 GMT):
Hold a moment there - why did we remove the request to have Zac approve? I'd like the record to show that he's not being pushed out, but has generously bowed out to allow other active contributors to fill that role
ChrisSpanton (Tue, 09 Oct 2018 21:18:23 GMT):
:)
kthblmfld (Tue, 09 Oct 2018 22:20:51 GMT):
Looks like he may not have been added initially, but is there now
ChrisSpanton (Tue, 09 Oct 2018 22:38:16 GMT):
Good good! We'll merge that in once he approves. Next step, will be integrating that to the branching strategy, so we can limit merge permissions to master.
ChrisSpanton (Tue, 09 Oct 2018 22:39:08 GMT):
@kthblmfld @devsatishm I suppose I should look at the issue, but I'll just ask here - is that piece moving forward?
adamgering (Tue, 09 Oct 2018 22:44:00 GMT):
I removed and added him so he'd be notified again. Otherwise someone can ping him on RocketChat.
adamgering (Tue, 09 Oct 2018 22:44:50 GMT):
develop branch requires identifying the repo owner. I moved that to in-progress. Roll call: which of the maintainer's owns the repo?
adamgering (Tue, 09 Oct 2018 22:45:08 GMT):
If no one owns the repo, we should know who the owners are, who are not in the maintainers.md.
adamgering (Tue, 09 Oct 2018 22:45:08 GMT):
If no maintainers owns the repo, we should know who the owners are, who are not in the maintainers.md.
adamgering (Tue, 09 Oct 2018 22:46:00 GMT):
Failing that, we have to funnel all requests to Linux Foundation HelpDesk.
adamgering (Tue, 09 Oct 2018 22:46:23 GMT):
What's Hyperledger policy? Who are the owners of the Sawtooth Core repo, etc?
ChrisSpanton (Tue, 09 Oct 2018 23:27:15 GMT):
Good questions... @boydjohnson @dplumb any insight into ownership on Sawtooth Core?
dplumb (Wed, 10 Oct 2018 14:34:39 GMT):
Did Zac mention that he no longer wished to be a maintainer of the repo? If we want to get Adam in as a maintainer, we can split that PR up into one that adds Adam and another that removes Zac (if thats what he wanted)
dplumb (Wed, 10 Oct 2018 14:34:53 GMT):
I don't think there's a limit to how many maintainers we can have on the repo
dplumb (Wed, 10 Oct 2018 14:37:19 GMT):
Regarding the ownership question, the repos under `hyperledger/...` are owned by the Hyperledger github organization. So I think the owners of the organization have admin rights on the repo
dplumb (Wed, 10 Oct 2018 14:37:19 GMT):
Regarding the ownership question, the repos under `hyperledger/...` are owned by the Hyperledger github organization. So I think the owners/admins of the organization have admin rights on the repo
boydjohnson (Wed, 10 Oct 2018 14:47:18 GMT):
I don't have ownership rights on sawtooth-next-directory. Various of the senior maintainers are owners of the sawtooth-core repo.
ChrisSpanton (Wed, 10 Oct 2018 16:26:47 GMT):
@dplumb I chatted with Zac, and he indicated that he could be available to consult as needed, but that he wouldn’t be actively engaged in this project. He said he was good with being removed from the maintainers list.
ChrisSpanton (Wed, 10 Oct 2018 16:27:15 GMT):
The hope is to keep the list healthy - you’re right, size doesn’t much matter
dplumb (Wed, 10 Oct 2018 16:29:18 GMT):
Cool with me
adamgering (Wed, 10 Oct 2018 16:57:36 GMT):
I'd like to break out next- into some topic or purpose specific channels. Take a look at fabric-* as an example.
sawtooth-next-directory can stick around as announcements, community engagement and high level conversation.
adamgering (Wed, 10 Oct 2018 16:57:50 GMT):
suggestions on initial channels?
adamgering (Wed, 10 Oct 2018 17:15:44 GMT):
next-dev-env
next-dev
next-documentation
next-infra
next-pr-review
next-scrum
adamgering (Wed, 10 Oct 2018 17:16:13 GMT):
next-ui
adamgering (Wed, 10 Oct 2018 17:16:28 GMT):
That's my suggestion. Comments, additions or removals?
adamgering (Wed, 10 Oct 2018 17:17:49 GMT):
Those are based on fabric-* or sawtooth-* channels of the same name format, with the addition of next-ui
mtn206 (Wed, 10 Oct 2018 17:17:52 GMT):
How about next-administration to discuss things like repo Maintainers
adamgering (Wed, 10 Oct 2018 17:18:58 GMT):
next-maintainers -- I'm not sure that has much need vs next-pr-review, but if so, that's the channel name convention.
mtn206 (Wed, 10 Oct 2018 17:21:04 GMT):
I can see that falling under next-pr-review
kthblmfld (Wed, 10 Oct 2018 17:25:10 GMT):
I think we should cross that bridge once communication on this channel becomes too noisy. Currently, my primary source of noise are github notifications
kthblmfld (Wed, 10 Oct 2018 17:25:10 GMT):
I think we should cross that bridge once communication on this channel becomes too noisy. Currently, my primary source of noise is github notifications
ChrisSpanton (Wed, 10 Oct 2018 17:36:13 GMT):
I think I’m with Keith. To me this feels like valuable conversation that’s not too noisy. I think with several channels we’d have a bunch of crickets hanging out right now...
adamgering (Wed, 10 Oct 2018 18:10:09 GMT):
I believe a single channel is causing a lack of discussion on specific issues that are happening instead in DM and emails, so I'd like to get everything into relevant channels.
adamgering (Wed, 10 Oct 2018 18:10:55 GMT):
If you don't feel very strongly differently, then we should move ahead, but we can certainly start with fewer than above.
yunhangc (Wed, 10 Oct 2018 18:12:00 GMT):
that works. but i could start my habit discussing here as well
adamgering (Wed, 10 Oct 2018 18:13:24 GMT):
The problem with a single channel isn't so much as creating too much noise for our part-time maintainers, but rather it becomes hard to find discussions on specific topics.
adamgering (Wed, 10 Oct 2018 18:14:06 GMT):
noise-signal and scrolling problem
yunhangc (Wed, 10 Oct 2018 18:14:14 GMT):
i agree it could be a lot noise and not specific enough.
adamgering (Wed, 10 Oct 2018 18:14:37 GMT):
```
next-dev-env
next-dev
next-documentation
next-infra
next-pr-review
next-scrum
next-ui
```
adamgering (Wed, 10 Oct 2018 18:14:42 GMT):
consider pls
yunhangc (Wed, 10 Oct 2018 18:15:49 GMT):
looks like good splits to me
yunhangc (Wed, 10 Oct 2018 18:17:38 GMT):
@adamgering on the approval issue, "on behalf of" will be stored as part of the proposal?
yunhangc (Wed, 10 Oct 2018 18:18:00 GMT):
how do you suggest we figure out "on behalf of" person
adamgering (Wed, 10 Oct 2018 18:18:30 GMT):
Correct, store both the approver (user_id) and the behalf_of (user_id).
yunhangc (Wed, 10 Oct 2018 18:29:33 GMT):
so the on_behalf_of is passed in from the ui ?
bobonana (Wed, 10 Oct 2018 18:56:28 GMT):
I noticed these new branches when I ran `fetch upstream` this morning, are they new?
```
wabelhlp0310149:sawtooth-next-directory bobonana$ git fetch upstream
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Total 7 (delta 4), reused 4 (delta 4), pack-reused 3
Unpacking objects: 100% (7/7), done.
From https://github.com/hyperledger/sawtooth-next-directory
* [new branch] 191 -> upstream/191
* [new branch] dev-ui -> upstream/dev-ui
* [new branch] develop -> upstream/develop
* [new branch] master -> upstream/master
* [new branch] revert-201-documentation -> upstream/revert-201-documentation
```
mtn206 (Wed, 10 Oct 2018 19:00:29 GMT):
`revert-201-documentation` was a branch that was created when I tried to revert a PR. Can one of the repo owners delete that branch?
kthblmfld (Wed, 10 Oct 2018 19:04:34 GMT):
Hmmm. Who has permission to delete the additional branches?
adamgering (Wed, 10 Oct 2018 19:12:19 GMT):
Rebo owner. Issue #125
adamgering (Wed, 10 Oct 2018 19:12:19 GMT):
Repo owner. Issue #125
kthblmfld (Wed, 10 Oct 2018 19:12:56 GMT):
We should also configure default reviewers on the repo, and have a POC to make adjustments to those reviewers over time.
adamgering (Wed, 10 Oct 2018 19:15:32 GMT):
There shouldn't be any branches on the main repo except master and develop. Everything else must be a PR on a fork.
nadiab22 (Wed, 10 Oct 2018 19:22:04 GMT):
This is the wiki for Developer-Setup https://github.com/hyperledger/sawtooth-next-directory/wiki/Developer-Setup Please Review and let me know if you have issues so I can try to help.
Nonj (Wed, 10 Oct 2018 20:35:02 GMT):
Has joined the channel.
Nonj (Wed, 10 Oct 2018 20:35:51 GMT):
Hey team!
anasatkeeva (Wed, 10 Oct 2018 21:23:41 GMT):
Has joined the channel.
anasatkeeva (Wed, 10 Oct 2018 21:24:49 GMT):
Hey guys!
bobonana (Wed, 10 Oct 2018 21:25:02 GMT):
Hey everyone Non and Ana are two part-time developers on our team here at T-Mo. Ana has been here a while and Non just joined, they're awesome people and really excited to start contributing to Next!
ChrisSpanton (Wed, 10 Oct 2018 21:35:09 GMT):
Welcome Non and Ana! Great to see the team grow :)
adamgering (Wed, 10 Oct 2018 21:35:21 GMT):
Welcome! Are you guys joining us next week at the Microsoft event?
ChrisSpanton (Wed, 10 Oct 2018 21:35:44 GMT):
Open question right now - reaching out to MSFT to see if there's space to add them
ChrisSpanton (Wed, 10 Oct 2018 21:39:19 GMT):
Maintainers should have just received an email, the DockerHub repo is now up at https://hub.docker.com/r/hyperledger/sawtooth-next-directory/
kthblmfld (Wed, 10 Oct 2018 21:41:51 GMT):
Welcome, @Nonj and @anasatkeeva !
kthblmfld (Wed, 10 Oct 2018 21:47:12 GMT):
Can a non-Dev9er review my PR: https://github.com/hyperledger/sawtooth-next-directory/pull/216 ? It is a rather large refactor (no changes to project functionality whatsoever) and I am spending more time keeping it in sync with master at this point than I am in writing unit tests. Please help me out!
mtn206 (Wed, 10 Oct 2018 21:49:08 GMT):
I'm looking through it right now - sorry it's taking a while
kthblmfld (Wed, 10 Oct 2018 21:49:24 GMT):
Ah ok
kthblmfld (Wed, 10 Oct 2018 21:50:02 GMT):
Thanks @mtn206
ChrisSpanton (Wed, 10 Oct 2018 21:57:05 GMT):
Only got half way through before I ran outa time yesterday... made just one comment. Mostly looking good though :)
ChrisSpanton (Wed, 10 Oct 2018 21:57:16 GMT):
thanks @mtn206
adamgering (Wed, 10 Oct 2018 22:00:26 GMT):
We're waiting on PR review: https://github.com/hyperledger/sawtooth-next-directory/pull/216 @mtn206 @ChrisSpanton @yunhangc
ChrisSpanton (Wed, 10 Oct 2018 22:10:34 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=mSxx9BSCX6Fb5aGzD) @adamgering :)
amundson (Thu, 11 Oct 2018 03:17:17 GMT):
After talking to @adamgering, I removed some branches from sawtooth-next-directory repo (191, dev-ui, revert-201-documentation), because they were created there by mistake. If this in in err, let me know.
adamgering (Thu, 11 Oct 2018 03:18:12 GMT):
Thanks @amundson
amundson (Thu, 11 Oct 2018 03:21:22 GMT):
The repo currently has very liberal write permissions that aren't consistent with Sawtooth norms. Now that we have maintainers defined, I'd like to adjust those permissions to match the maintainers list. This impacts who can press merge, but not who can create PRs. It also impacts whether an individual's checkmark is green or grey (two green checkmarks required to merge).
kthblmfld (Thu, 11 Oct 2018 04:45:05 GMT):
Great! Having the 2 approval policy in there will help, as will the designated maintainers. Thanks for deleting the branches.
ChrisSpanton (Thu, 11 Oct 2018 15:03:26 GMT):
Absolutely! We've been driving towards that end, via the deployment of maintainers, and the development of branching strategy. We're happy to be moving towards tighter controls here :)
kthblmfld (Thu, 11 Oct 2018 16:43:14 GMT):
@amundson FYI we still have a PR out with a pending change to the maintainers list. @ChrisSpanton If you are ok with extending the size of the maintainers I'd be happy to be a part of sorting out merges as well.
bobonana (Thu, 11 Oct 2018 18:22:42 GMT):
talked to @nadiab22 a bit and we can get all of our developer dependencies installed through pip except for the sawtooth-rest-api. I found the package here https://github.com/hyperledger/sawtooth-core/tree/master/rest_api
bobonana (Thu, 11 Oct 2018 18:25:40 GMT):
it's available as a build package through APT as `python3-sawtooth-rest-api, but not through pip. it's all there though, so could we ask someone from hyperledger to make this available through pip, or do it ourselves?
bobonana (Thu, 11 Oct 2018 18:26:37 GMT):
this would streamline things for us, we'd be able to use requirements.dev.txt for all developer dependencies, and it would be completely portable
kthblmfld (Thu, 11 Oct 2018 18:27:22 GMT):
@bobonana How does this compare/contrast to what @nadiab22 is working on?
bobonana (Thu, 11 Oct 2018 18:28:28 GMT):
using only requirements.dev.txt would be OS agnostic
bobonana (Thu, 11 Oct 2018 18:29:41 GMT):
doesn't matter if a dev is using a mac, windows machine, ubuntu, etc. as long as they have a good version of pip running they'd be able to install all dependencies and be ready to go with `pip3 install -r requirements.txt` in a virtualenv
bobonana (Thu, 11 Oct 2018 18:31:04 GMT):
we can get drop-in replacements for that secp binary and pkg-config through pip, same with the sawtooth-sdk and sawtooth-signing, the only thing we can't get past is sawtooth-rest-api
bobonana (Thu, 11 Oct 2018 18:31:58 GMT):
if we can get that we can streamline the setup process for devs and simplify our documentation (since we don't have to have any OS-specific instructions).
kthblmfld (Thu, 11 Oct 2018 18:35:50 GMT):
Is this happening soon? I spend some time haggling with the linter yesterday in support of this: https://github.com/hyperledger/sawtooth-next-directory/issues/98
bobonana (Thu, 11 Oct 2018 18:36:38 GMT):
I'd like it to, if it did it'd fix our linting issues like now
amundson (Thu, 11 Oct 2018 20:11:12 GMT):
@bobonana we only publish the SDK to pypi; for the rest API and validator, we package debian packages and docker images. rest api will be rewritten in rust at some point, so focusing on python distribution mechanisms isn't necessarily the best long-term option
amundson (Thu, 11 Oct 2018 20:12:05 GMT):
to support dev on the different platforms, most of us use docker
bobonana (Thu, 11 Oct 2018 20:12:55 GMT):
@amundson so how should developers run `./bin/run_lint` locally as documented if project code uses the sawtooth-rest-api package?
bobonana (Thu, 11 Oct 2018 20:13:17 GMT):
same with setting up a linter for their IDE
amundson (Thu, 11 Oct 2018 20:13:49 GMT):
are you modifying the rest api? I'm not sure why you would care about linting the sawtooth rest api unless you are coding on it.
amundson (Thu, 11 Oct 2018 20:14:23 GMT):
it's not library code
amundson (Thu, 11 Oct 2018 20:15:45 GMT):
also, doesn't next directory provide an application domain rest api? if so, do you really need the sawtooth rest api as a dependency?
bobonana (Thu, 11 Oct 2018 20:30:36 GMT):
we import it and use it in our code, which is causing import errors
bobonana (Thu, 11 Oct 2018 20:31:12 GMT):
would it be more appropriate to list teh sawtooth-rest-api modules under `--ignored-modules` in the pylint settings in `./setup.cfg`?
bobonana (Thu, 11 Oct 2018 20:32:01 GMT):
I'm down for whatever works, haha. I just want to make sure that we get to a point where the linter returns no errors when run locally in an environment built as per our instructions
bobonana (Thu, 11 Oct 2018 20:48:22 GMT):
```
(sawtooth) tm0493806:sawtooth-next-directory bobonana$ bin/run_lint
addressing/rbac_addressing
--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
transaction_creation
************* Module rbac_transaction_creation.common
transaction_creation/rbac_transaction_creation/common.py:19:0: E0401: Unable to import 'sawtooth_rest_api.protobuf' (import-error)
transaction_creation/rbac_transaction_creation/common.py:20:0: E0401: Unable to import 'sawtooth_rest_api.protobuf' (import-error)
------------------------------------------------------------------
Your code has been rated at 9.69/10 (previous run: 9.69/10, +0.00)
processor/rbac_processor
--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
server
************* Module api.utils
server/api/utils.py:28:0: E0401: Unable to import 'sawtooth_rest_api.protobuf' (import-error)
server/api/utils.py:29:0: E0401: Unable to import 'sawtooth_rest_api.protobuf' (import-error)
************* Module api.main
server/api/main.py:30:0: E0401: Unable to import 'sawtooth_rest_api.messaging' (import-error)
------------------------------------------------------------------
Your code has been rated at 9.81/10 (previous run: 9.81/10, +0.00)
ledger_sync/rbac_ledger_sync
--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
tests
************* Module tests.blockchain.rbac_client
tests/blockchain/rbac_client.py:10:0: E0401: Unable to import 'sawtooth_cli.rest_client' (import-error)
************* Module tests.transactions.user
tests/transactions/user.py:20:0: E0401: Unable to import 'sawtooth_rest_api.protobuf' (import-error)
tests/transactions/user.py:21:0: E0401: Unable to import 'sawtooth_rest_api.protobuf' (import-error)
------------------------------------------------------------------
Your code has been rated at 9.86/10 (previous run: 9.86/10, +0.00)
```
bobonana (Thu, 11 Oct 2018 20:58:49 GMT):
@adamgering @kthblmfld can I get a quick opinion on this? https://github.com/hyperledger/sawtooth-next-directory/issues/217
kthblmfld (Thu, 11 Oct 2018 21:07:36 GMT):
No opinions yet. Just more questions. What does the future have in store for the python-based sawtooth rest client? What would it take to decouple the client, exceptions, whatever else we are trying to pull in?
kthblmfld (Thu, 11 Oct 2018 21:07:36 GMT):
No opinions yet. Just more questions. What does the future have in store for the python-based sawtooth rest client? What would it take to decouple from the client, exceptions, whatever else we are trying to pull in?
bobonana (Thu, 11 Oct 2018 21:56:32 GMT):
@amundson?
boydjohnson (Thu, 11 Oct 2018 22:04:17 GMT):
For the protobuf you will find the same protobuf packages in sawtooth_sdk.protobuf.
boydjohnson (Thu, 11 Oct 2018 22:04:17 GMT):
For the protobuf you will find the same protobuf packages in sawtooth_sdk.protobuf as in sawtooth_rest_api.protobuf.
kthblmfld (Thu, 11 Oct 2018 23:31:35 GMT):
@ChrisSpanton re: #226 Looks like @bobonana has taken this on. Deferring to him to see it through
kthblmfld (Thu, 11 Oct 2018 23:37:52 GMT):
@agoldingay There was a misshap in the handling of #226 this morning.
bobonana (Thu, 11 Oct 2018 23:37:54 GMT):
@boydjohnson right, but the linter doesn't see them, we don't get these errors running in containers with the python3-sawtooth-rest-api installed, so I thought that was why the liver was reporting them?
kthblmfld (Thu, 11 Oct 2018 23:39:59 GMT):
I agreed in standup to look into it, but then it was assigned to @bobonana and @nadiab22 .
kthblmfld (Thu, 11 Oct 2018 23:41:22 GMT):
Anyways, I will be more diligent about updating events like this during standup as they come up
kthblmfld (Fri, 12 Oct 2018 05:36:50 GMT):
@bobonana We are thinking about separating build protos from copy/generation to provide stable refs to them, and moving generation to be manual/on-demand when the message schemas change. How does that sound?
kthblmfld (Fri, 12 Oct 2018 15:58:56 GMT):
After some cleanup of the rbac_processor, I have found a few operations that were never implemented (removals of role removal confirmations/rejections). Dropping in placeholder functions with TODOs and creating an issue to revisit.
kthblmfld (Fri, 12 Oct 2018 15:58:56 GMT):
After some cleanup of the rbac_processor, I have found a few operations that were never implemented (removals of role removal confirmations/rejections). Dropping in placeholder functions that throw TODOs and creating an issue to revisit.
nadiab22 (Fri, 12 Oct 2018 20:26:55 GMT):
Updated squash help in documentation here: https://github.com/hyperledger/sawtooth-next-directory/wiki/Git-Pull-Requests
kthblmfld (Fri, 12 Oct 2018 20:31:17 GMT):
Thanks for doing that. Having the PR rebase steps documented will save time for future contributors.
Dan (Fri, 12 Oct 2018 20:58:30 GMT):
cool. i tweaked the instructions to allow for multiple commits per PR.
amundson (Sat, 13 Oct 2018 03:02:17 GMT):
@kthblmfld checking in auto-generated code is very bad practice. it encourages one-off procedures others can not replicate, besides making git history contain meaningless garbage (for example, in comparison of two commit ids in history, if an intermediate diff is a garbage update-auto-gen code commit, it is not helpful).
amundson (Sat, 13 Oct 2018 03:04:51 GMT):
if by "copy" you mean duplicate the proto files you need into next-directory repo, I don't see a problem with that, they are relatively stable and even if they get out of sync, it won't be a problem because the validator should remain backward compatible
kthblmfld (Sat, 13 Oct 2018 03:42:49 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=tMuCscgtw3fhcEi3x) @amundson There has been ongoing discussion about the generated files, and I have taken the same position as you since I once dealt with a gen-on-demand maven package requiring a hacky solution using a few plug-ins. My biggest concern is that we might still be targeting the committed directories. This could lead to collisions and side effects. On the other hand, not generating on every build reduces build time and solidifies the imports in python. If it goes sideways then we will revert. Thanks
kthblmfld (Sat, 13 Oct 2018 03:44:10 GMT):
I am not much of a fan of code generation to begin with, but protobufs offer some nice messaging perf improvements
agoldingay (Mon, 15 Oct 2018 15:32:35 GMT):
All, no Stand-up today through Thursday. Will resume Friday. Thanks!
ChrisSpanton (Mon, 15 Oct 2018 16:17:48 GMT):
Alright folks, I've heard the complaint that "hierarchical" is a silly word that nobody understands or can spell. Any proposals for another name for this feature?
ChrisSpanton (Mon, 15 Oct 2018 16:19:01 GMT):
laddered approval, managerial approval, something totally different? I feel like there's a good idea out there, and I dont have it. :)
kthblmfld (Mon, 15 Oct 2018 16:51:05 GMT):
Tough question. "Managerial approval" describes the function but has been branded in retail as a required operation. Approval override?
kthblmfld (Mon, 15 Oct 2018 16:52:04 GMT):
Parent approval?
kthblmfld (Mon, 15 Oct 2018 16:54:53 GMT):
We are describing the case where the approver's manager voluntarily approves on the approver's behalf - not the case where a neglected proposal notifies the next layer up the org hierarchy, correct?
kthblmfld (Mon, 15 Oct 2018 16:55:23 GMT):
Whatever distinguishes those two scenarios more succintly...
kthblmfld (Mon, 15 Oct 2018 16:55:23 GMT):
Whatever distinguishes those two scenarios more succinctly...
ChrisSpanton (Mon, 15 Oct 2018 16:55:29 GMT):
It covers both IMHO
ChrisSpanton (Mon, 15 Oct 2018 16:56:05 GMT):
its the translation of the business process that says a manager CAN approve on behalf of their subordinates, the scenarios could vary as described
ChrisSpanton (Mon, 15 Oct 2018 16:56:47 GMT):
And I guess in reality there are two questions here - first, what are these functions called in code, and second how is the capability branded in retail
ChrisSpanton (Mon, 15 Oct 2018 16:57:56 GMT):
I was just reviewing a PR where we inconsistently spelled it wrong, so I figured if even we dont get it right, it maybe should be changed.
kthblmfld (Mon, 15 Oct 2018 17:05:25 GMT):
Haha I have seen 'hierarchical' get fumbled in other projects.
kthblmfld (Mon, 15 Oct 2018 17:09:55 GMT):
depth-first approval, layered approval
kthblmfld (Mon, 15 Oct 2018 17:10:18 GMT):
My vote so far: Managerial approval
ChrisSpanton (Mon, 15 Oct 2018 20:15:42 GMT):
If you haven't seen it, pretty cool to see the Azure team highlighting NEXT with the release of Azure Confidential Computing! https://azure.microsoft.com/en-us/blog/protect-data-in-use-with-the-public-preview-of-azure-confidential-computing/
boydjohnson (Tue, 16 Oct 2018 15:11:50 GMT):
Really cool ^.
adamgering (Wed, 17 Oct 2018 17:31:23 GMT):
Can I get some reviews on this PR: https://github.com/hyperledger/sawtooth-next-directory/pull/290
adamgering (Wed, 17 Oct 2018 18:35:29 GMT):
Management approval and delegate approval are effectively the same feature with a different verification function. Both are approval by proxy.
adamgering (Wed, 17 Oct 2018 18:36:08 GMT):
Management approval > hierarchical approval
agoldingay (Thu, 18 Oct 2018 17:26:39 GMT):
GM All! I have sent invites to Zenhub for those that have issues assigned to them on the NEXT project board. It is free to all open sourced projects on Github and comes built in with burn down, velocity reporting and you can estimate points. thanks @kthblmfld for suggesting this tool.
agoldingay (Thu, 18 Oct 2018 17:26:39 GMT):
GM All! I have sent invites to Zenhub for those that have issues assigned to them on the NEXT project board. It is free to all open sourced projects on Github and comes built in with burn down, velocity reporting and you can estimate points there. thanks @kthblmfld for suggesting this tool.
adamgering (Thu, 18 Oct 2018 20:04:37 GMT):
Can I get some reviews on PR: https://github.com/hyperledger/sawtooth-next-directory/pull/303
agoldingay (Fri, 19 Oct 2018 17:14:09 GMT):
TGIF! Please ensure you have accepted the Zenhub invite from me. Direct message me if you didn't receive my email. Thanks!
kthblmfld (Fri, 19 Oct 2018 20:41:55 GMT):
@agoldingay Did you reserve a room for us to be there Mon or are we doing the 1hr task management discussion online?
agoldingay (Fri, 19 Oct 2018 21:00:49 GMT):
sending meeting shortly. Yes, got a room reserved already. Thanks @kthblmfld
kthblmfld (Fri, 19 Oct 2018 21:01:01 GMT):
Great! See you then
kthblmfld (Fri, 19 Oct 2018 22:05:45 GMT):
Zenhub decomposes its projects into epics and tasks, and anything finer-grained goes into the task as a Markdown checklist.
kthblmfld (Fri, 19 Oct 2018 22:06:49 GMT):
I am trying to associate tasks under a story, but the association is all manual
kthblmfld (Fri, 19 Oct 2018 22:08:51 GMT):
It also has bulk update capability in "Select issues". Nice!
kthblmfld (Fri, 19 Oct 2018 22:10:43 GMT):
I am doing it wrong for my current story. Will try issues with checklists for the next one
warren13245 (Sat, 20 Oct 2018 12:54:21 GMT):
Has joined the channel.
warren13245 (Sat, 20 Oct 2018 13:03:36 GMT):
nextd.png
warren13245 (Sat, 20 Oct 2018 13:05:06 GMT):
demo.png
warren13245 (Sat, 20 Oct 2018 13:05:49 GMT):
@adamgering you said i should ask here about windows dev env setup
warren13245 (Sat, 20 Oct 2018 13:37:22 GMT):
nd.png
warren13245 (Sat, 20 Oct 2018 14:11:32 GMT):
solved the problem: checked the shared drives in the docker settings. both are working now
ChrisSpanton (Mon, 22 Oct 2018 16:37:12 GMT):
@warren13245 Awesome! Glad you were able to work through that. Keep an eye on this project space - big changes coming to NEXT over the coming weeks! The UI currently included is rapidly being replaced, and new functionality will come with it.
mtn206 (Tue, 23 Oct 2018 16:15:18 GMT):
Hello all - I found that ZenHub has a browser extension that will allow the ZenHub board be integrated into the Sawtooth Repo repo page. You should check it out as it! With the extension you wouldn't need to navigate to zenhub.com to manage the issues.
adamgering (Tue, 23 Oct 2018 16:29:48 GMT):
Is there any benefit to maintaining a "non-dev" environment that copies rather than mounts the files?
adamgering (Tue, 23 Oct 2018 16:30:14 GMT):
I don't see any benefit. This was inherited. I'm inclined to get rid of it, unless there are any objections or rationales.
agoldingay (Tue, 23 Oct 2018 16:53:26 GMT):
Thanks @mtn206! When I open up the project repo Zenhub is it's own tab now. So, I don't have to open up another browser for Zenhub.
kthblmfld (Tue, 23 Oct 2018 17:49:19 GMT):
@adamgering Agreed on consolidating the two. My only concern is WIN machines, is it just a matter of sharing drives as @warren13245 mentioned?
yunhangc (Tue, 23 Oct 2018 17:53:03 GMT):
@adamgering I am trying to fix the broken test from hierarchical approval, the code require db connection access to get user resource. so will probably have to mock something. do we have a mock framework in place for unit testing?
adamgering (Tue, 23 Oct 2018 17:53:29 GMT):
Those are integration tests, not unit tests. You run them from rbac-shell
adamgering (Tue, 23 Oct 2018 17:53:53 GMT):
docker exec -it rbac-shell bash
adamgering (Tue, 23 Oct 2018 17:54:02 GMT):
pytest
adamgering (Tue, 23 Oct 2018 17:54:10 GMT):
Or non-interactively via:
adamgering (Tue, 23 Oct 2018 17:54:13 GMT):
bin/build -t
adamgering (Tue, 23 Oct 2018 18:00:19 GMT):
Travis uses bin/build -t
yunhangc (Tue, 23 Oct 2018 18:04:07 GMT):
as in the approval transaction creation, we need to get a hierarchy of users to put into the headers, so will have to get the head block and db connection object into the test object
adamgering (Tue, 23 Oct 2018 18:08:07 GMT):
I don't think that has anything to do with test.
You mean to say, you need the list of input addresses?
yunhangc (Tue, 23 Oct 2018 18:08:27 GMT):
@adamgering in your integration testing framework, is the rethinkdb connector exposed somewhere
yunhangc (Tue, 23 Oct 2018 18:08:43 GMT):
seems all data access are through api_request
adamgering (Tue, 23 Oct 2018 18:09:53 GMT):
we should code in a way that doesn't depend upon rethink, but I see your problem.
adamgering (Tue, 23 Oct 2018 18:10:47 GMT):
Firstly, fix the broken integration test, that's a non-hierarchical proposal and confirmation.
adamgering (Tue, 23 Oct 2018 18:11:22 GMT):
To test hierarchical approval, you'll need to create the hierarchy of users, and get the inputs. There's already a hierarchy there.
yunhangc (Tue, 23 Oct 2018 18:11:30 GMT):
ya, i think i can move the test to before so that the pr can go in first
adamgering (Tue, 23 Oct 2018 18:18:11 GMT):
To answer the question about DB connection, there's no rethink container in the test docker-compose.
adamgering (Tue, 23 Oct 2018 18:18:50 GMT):
We can add one, but blockchain tests should work with only the validator and processor.
adamgering (Tue, 23 Oct 2018 18:19:23 GMT):
Testing rethink will require an async test library. pytest-sanic may work.
yunhangc (Tue, 23 Oct 2018 18:20:27 GMT):
ya, it feels odd adding rethink into the blockchain package.
agoldingay (Tue, 23 Oct 2018 18:25:37 GMT):
Today's standup details: 11:30am PST, https://meet.t-mobile.com/agnes.goldingay1/TB9YZ36L, 1-844-202-5500,,4191791129# (Northwest). A reminder, those contributing please ensure I or any NEXT team members have invited you to Zenhub, we are tracking sprints in there starting with this current sprint (Sprint 4). Talk to you soon!
yunhangc (Tue, 23 Oct 2018 18:42:55 GMT):
on another meeting. sorry could not join
adamgering (Tue, 23 Oct 2018 18:51:34 GMT):
the projects starts using: ```bin/build -d``` (dev mode)
adamgering (Tue, 23 Oct 2018 18:51:34 GMT):
the projects starts using: ```bin/start -d``` (dev mode)
adamgering (Tue, 23 Oct 2018 18:53:27 GMT):
Not sure what Nattanon is stuck on?
adamgering (Tue, 23 Oct 2018 18:54:05 GMT):
to rebuild, use ```bin/start -d -b```
adamgering (Tue, 23 Oct 2018 18:54:27 GMT):
those are just shortcuts to the docker-compose commands
bobonana (Tue, 23 Oct 2018 20:23:20 GMT):
the issues are with getting docker running properly on his windows machine. I think he's having similar issues to what James had when we went to Microsoft. @kthblmfld do you remember what you guys did to get James up and running? Or does our current documentation already reflect those steps?
bobonana (Tue, 23 Oct 2018 20:28:35 GMT):
http://coderbro.com/docker/2017/10/24/docker-volumes-vs-copy.html @adamgering @kthblmfld It looks like it makes a difference when building the image, but not sure if it'll make a difference once we have prebuilt images in dockerhub for non-dev
kthblmfld (Tue, 23 Oct 2018 21:30:14 GMT):
@bobonana The developer setup pages in the Wiki ought to cover all of the blockers I hit with James
kthblmfld (Tue, 23 Oct 2018 21:30:49 GMT):
I think I even added a blurb about checking out and committing as-is (ie any CRLF/LF issues)
kthblmfld (Tue, 23 Oct 2018 21:31:52 GMT):
The protobufs were in an inaccessible state in non-dev mode, and there he was having issues in dev mode dues to the mounting of volumes
kthblmfld (Tue, 23 Oct 2018 21:32:17 GMT):
So I created a branch that reverted the protobuf refactor and he deployed that
kthblmfld (Tue, 23 Oct 2018 21:33:45 GMT):
Not sure where things stand regarding dev/non-dev mode and protos at this moment. But I saw @warren13245 seemed to get the app running by granting drive access permissions to Docker
kthblmfld (Tue, 23 Oct 2018 21:34:15 GMT):
What are y'all seeing?
kthblmfld (Tue, 23 Oct 2018 21:36:04 GMT):
On another note: Anybody else seeing this intermittently while doing a 'bin/build -p'?: Step 1/7 : FROM hyperledger/sawtooth-validator:1.0
Get https://registry-1.docker.io/v2/hyperledger/sawtooth-validator/manifests/1.0: unauthorized: incorrect username or password
kthblmfld (Tue, 23 Oct 2018 21:36:04 GMT):
On another note: Anybody else seeing this intermittently while doing a 'bin/build -p'?: Step 1/7 : FROM hyperledger/sawtooth-validator:1.0
Get https://registry-1.docker.io/v2/hyperledger/sawtooth-validator/manifests/1.0: unauthorized: incorrect username or password
kthblmfld (Tue, 23 Oct 2018 21:36:04 GMT):
On another note: Anybody else seeing this intermittently while doing a 'bin/build -p'?:
Step 1/7 : FROM hyperledger/sawtooth-validator:1.0
Get https://registry-1.docker.io/v2/hyperledger/sawtooth-validator/manifests/1.0: unauthorized: incorrect username or password
mtn206 (Tue, 23 Oct 2018 21:42:16 GMT):
@kthblmfld - you might need to login to docker
mtn206 (Tue, 23 Oct 2018 21:42:27 GMT):
through the command line
kthblmfld (Tue, 23 Oct 2018 21:42:53 GMT):
Into dockerhub?
kthblmfld (Tue, 23 Oct 2018 21:43:22 GMT):
Ok testing
mtn206 (Tue, 23 Oct 2018 21:43:52 GMT):
Use `docker login` command
kthblmfld (Tue, 23 Oct 2018 21:45:07 GMT):
Interesting. Getting auth fail there t'oo.
kthblmfld (Tue, 23 Oct 2018 21:45:07 GMT):
Interesting. Getting auth fail there too.
mtn206 (Tue, 23 Oct 2018 21:45:22 GMT):
Did you try logging in with your docker ID instead of your email address?
kthblmfld (Tue, 23 Oct 2018 21:45:34 GMT):
Yet I can sign in via browser using the same creds
kthblmfld (Tue, 23 Oct 2018 21:45:59 GMT):
Ah there it goes
kthblmfld (Tue, 23 Oct 2018 21:46:04 GMT):
username, not email
kthblmfld (Tue, 23 Oct 2018 21:46:09 GMT):
Thanks @mtn206
mtn206 (Tue, 23 Oct 2018 21:46:13 GMT):
You're welcome!
ra_w (Wed, 24 Oct 2018 12:44:25 GMT):
Has joined the channel.
adamgering (Wed, 24 Oct 2018 18:13:07 GMT):
https://github.com/docker/for-win/issues/77
SumanPapanaboina (Sat, 27 Oct 2018 04:20:54 GMT):
Has joined the channel.
SumanPapanaboina (Sat, 27 Oct 2018 04:21:31 GMT):
Hello, from sawtooth next directory github readme i can see it has Role based Access control mechanism. does any one know if it supports simple Access control list or Attribute based access control mechanism ?
Hello, from sawtooth next directory github readme i can see it has Role based Access control mechanism. does any one know if it supports simple Access control list or Attribute based access control mechanism ?
SumanPapanaboina (Sat, 27 Oct 2018 04:22:02 GMT):
Hello, from sawtooth next directory github readme i can see it has Role based Access control mechanism. does any one know if it supports simple Access control list or Attribute based access control mechanism ?
kthblmfld (Sun, 28 Oct 2018 22:31:17 GMT):
@SumanPapanaboina The current focus is an RBAC solution that integrates with Active Directory, Azure Active Directory and overlays a proposal/approval structure. On the short term roadmap are multi-approvals and hierarchical approvals. There is no support for ACL/ABAC models at this time.
kthblmfld (Sun, 28 Oct 2018 22:31:51 GMT):
That said: You are free to add a feature request/enhancement issue to the backlog
kthblmfld (Sun, 28 Oct 2018 22:31:51 GMT):
That said: You are free to add a feature request/enhancement issue to the backlog if you see an opportunity/added value to having ACL/ABAC support in the project.
SumanPapanaboina (Mon, 29 Oct 2018 07:44:22 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=rAcKZGTqeYxfbPDMr) @kthblmfld Thank you for the clarification
yunhangc (Mon, 29 Oct 2018 19:12:30 GMT):
@adamgering @kthblmfld Adam and Keith, please take a moment to review PR325. caught some time this morning to finish it up. Thank you!!
kthblmfld (Mon, 29 Oct 2018 19:22:14 GMT):
Yep we are on it. Discussed this morning and will be getting it merged within the next few days. Thanks for following up
agoldingay (Tue, 30 Oct 2018 15:40:21 GMT):
Good morning! No standup this morning. Thanks!
bobonana (Tue, 30 Oct 2018 21:03:02 GMT):
if someone creates a new user in sawtooth do we want that to be a part of the delta sync?
bobonana (Tue, 30 Oct 2018 21:03:50 GMT):
if so, we need to supply an initial password to create a new user in Azure AD https://developer.microsoft.com/en-us/graph/docs/api-reference/beta/api/user_post_users
bobonana (Tue, 30 Oct 2018 21:04:23 GMT):
Does LDAP have a similar requirement @kthblmfld @mtn206
mtn206 (Tue, 30 Oct 2018 21:14:47 GMT):
For the test instance we have, user objects do not need a password defined, but this could be different for other AD instances
mtn206 (Tue, 30 Oct 2018 21:20:25 GMT):
Did we decided to create users within NEXT?
bobonana (Tue, 30 Oct 2018 21:45:06 GMT):
if we only make changes to users then AAD outbound delta sync is good to go and I'll make the PR
bobonana (Tue, 30 Oct 2018 21:45:49 GMT):
@ChrisSpanton are we allowing user creation in NEXT and syncing them to AD providers?
ChrisSpanton (Tue, 30 Oct 2018 22:44:41 GMT):
A few thoughts...
We’ll be triggering user creation at TMO from within NEXT, but it will be a custom call which generates the user on the directory side and then syncs it in
ChrisSpanton (Tue, 30 Oct 2018 22:45:27 GMT):
It should be easy to create from NEXT, but how do we ensure we meet password standards defined by directory environment?
ChrisSpanton (Tue, 30 Oct 2018 22:46:19 GMT):
Perhaps a generated user is a stub with ‘no access’ and to do anything you need to complete a process somehow? It’s an open discussion IMHO
ChrisSpanton (Tue, 30 Oct 2018 22:46:59 GMT):
I’m the generic use case, assuming we’ve solved for requirements, then yes I assume many will want to create users from NEXT
bobonana (Tue, 30 Oct 2018 23:40:11 GMT):
since this adds a layer of complexity to the delta sync (and questions like 'How do we decide which provider new users get synced to, or do we sync to all providers?') should we include it as a user-story/feature for another sprint?
bobonana (Tue, 30 Oct 2018 23:40:11 GMT):
@ChrisSpanton since this adds a layer of complexity to the delta sync (and questions like 'How do we decide which provider new users get synced to, or do we sync to all providers?') should we include it as a user-story/feature for another sprint?
bobonana (Tue, 30 Oct 2018 23:40:11 GMT):
@ChrisSpanton since this adds a layer of complexity to the delta sync (and questions like 'How do we decide which provider new users get synced to, or do we sync to all providers and how do we fulfill password requirements on all of them?') should we include it as a user-story/feature for another sprint?
bobonana (Tue, 30 Oct 2018 23:43:13 GMT):
Also, just made a PR and edited the wiki for windows dev environments, worked through it with Ana and if @Nonj wants to it would be a good first review for him. I'm wondering if instead of having users install libtool, automake, and pkgconfig usign the installers, should we have them install to git-bash as per https://gist.github.com/evanwill/0207876c3243bbb6863e65ec5dc3f058 ?
chainsaw (Wed, 31 Oct 2018 14:29:49 GMT):
Has joined the channel.
Nonj (Wed, 31 Oct 2018 17:59:44 GMT):
Yup, doing a test run today to see if the updated wiki fixes the issues on my end. Thanks @bobonana
agoldingay (Thu, 01 Nov 2018 16:12:14 GMT):
GM! Going over spring 4 open issues...
agoldingay (Thu, 01 Nov 2018 16:12:31 GMT):
#344 needs review
ChrisSpanton (Thu, 01 Nov 2018 16:31:52 GMT):
@bobonana @Nonj I'll leave it to you to decide on what the "happy path" for Windows looks like :)
ChrisSpanton (Thu, 01 Nov 2018 16:32:00 GMT):
keep us all in the loop there!
ChrisSpanton (Thu, 01 Nov 2018 16:32:43 GMT):
More generally, can anyone point me to current version of screen mockups?
ChrisSpanton (Thu, 01 Nov 2018 16:32:43 GMT):
More generally, can anyone point me to current version of screen mockups for the new UI?
bobonana (Thu, 01 Nov 2018 16:34:29 GMT):
We're at a point where we can get windows machines to run./bin/start
Trying to use cygwin to install libtool, automaker, and pkg-config. If that works we're all set and I'll update the documentation
kthblmfld (Thu, 01 Nov 2018 16:46:49 GMT):
Nice
pgobin (Thu, 01 Nov 2018 17:05:22 GMT):
@ChrisSpanton i'll put them on Dropbox and link it here.
adamgering (Thu, 01 Nov 2018 17:11:15 GMT):
Request for Feedback:
The project should be decomposed into user stories such that developers and stakeholders can prioritize and timeline the stories, developers have a practiced process for creating new stories, and developers are able to pick up stories to work on.
Brainstorm the components that need to get built to achieve the vision of this project. Decompose those components into deliverable pieces and create a user story for those pieces. Mark that user story "SX [User Story] {Title}", assign them to the current sprint. Put them on the groomed board if they have no dependencies and can be worked on this sprint, otherwise leave them on the backlog board. Don't assign points until picked up.
Epic #406
My thought is to create a User Story for each contributor this sprint, and for each person to attempt to create some user stories that have yet to have been captured, or decompose those that have that require decomposition.
adamgering (Thu, 01 Nov 2018 17:11:15 GMT):
Request for Feedback:
The project should be decomposed into user stories such that developers and stakeholders can prioritize and timeline the stories, developers have a practiced process for creating new stories, and developers are able to pick up stories to work on.
Brainstorm the components that need to get built to achieve the vision of this project. Decompose those components into deliverable pieces and create a user story for those pieces. Mark that user story "SX [User Story] {Title}", assign them to the current sprint. Put them on the groomed board if they have no dependencies and can be worked on this sprint, otherwise leave them on the backlog board. Don't assign points until picked up.
Epic #406
My thought is to create a User Story tied to this Epic with the same description assigned to each contributor this sprint, and for each contributor to attempt to create some user stories that have yet to have been captured, or decompose those that have that require decomposition.
pgobin (Thu, 01 Nov 2018 17:12:33 GMT):
latest UI mocks: https://www.dropbox.com/sh/lz9o9evp3d8sx88/AABYNBAEymyKthgvzibPIvuKa?dl=0. adobe xd can be downloaded for free @ https://www.adobe.com/products/xd.html.
adamgering (Thu, 01 Nov 2018 17:46:30 GMT):
I created one story and assigned it to everyone. #411 Project Decomposition. Reference both that and Epic #406 in the new user stories.
kthblmfld (Thu, 01 Nov 2018 20:37:07 GMT):
@pgobin Looks good. We will need to add packs to the backlog so we can get you that query for browsing
pgobin (Thu, 01 Nov 2018 20:43:12 GMT):
@kthblmfld yep exactly. that is on our radar. we will add stories to the backlog that address adding the concept of packs to the code.
kthblmfld (Thu, 01 Nov 2018 21:05:14 GMT):
Deal
adamgering (Mon, 05 Nov 2018 19:43:27 GMT):
Secp256k1 should not be a blocker for anyone.
You can run lint and tests in docker. You do not need any local dependencies installed other than pyaml and black.
bobonana (Mon, 05 Nov 2018 21:39:27 GMT):
what about the IDE?
bobonana (Mon, 05 Nov 2018 21:39:44 GMT):
we can't tell developers to do work when their IDE is telling them everything is broken
bobonana (Mon, 05 Nov 2018 21:39:52 GMT):
and asking them to disable the linter isn't coolk
bobonana (Mon, 05 Nov 2018 21:39:52 GMT):
and asking them to disable the linter isn't cool
adamgering (Mon, 05 Nov 2018 22:00:45 GMT):
Not blocking.
bobonana (Mon, 05 Nov 2018 22:15:11 GMT):
I have had it described to me by multiple other contributors as a blocking issue. It confuses new contributors who do not share our level of insight into this project or it's history. I feel it makes debugging and error tracking excessively difficult and confusing.
bobonana (Mon, 05 Nov 2018 22:16:55 GMT):
We also have two new developers working on Windows who are actively impacted by this. Yes, they can still make contributions, but do we really want to tell them that they need to exit the IDE and run a docker container every time they want to lint their code?
kthblmfld (Mon, 05 Nov 2018 22:46:46 GMT):
@bobonana understood. I pushed a feature out while my IDE was blowing chunks and it wasn't fun to work around. Are you trying to sort this out now?
adamgering (Tue, 06 Nov 2018 00:24:32 GMT):
Yes, it's perfectly reasonable to run lint in a terminal window and not use an IDE.
adamgering (Tue, 06 Nov 2018 22:41:57 GMT):
+1 notification / activity log queue
pgobin (Wed, 07 Nov 2018 00:15:08 GMT):
https://github.com/hyperledger/sawtooth-next-directory/wiki/Screens-and-Flows
pgobin (Wed, 07 Nov 2018 00:15:21 GMT):
first pass at adding docs for ui stuff.
kthblmfld (Wed, 07 Nov 2018 01:03:34 GMT):
Nice!
kthblmfld (Wed, 07 Nov 2018 01:24:08 GMT):
I was able to compile Sphinx docs on readthedocs.io using my fork of the repo. It required setting up the webhook between readthedocs and my fork.
kthblmfld (Wed, 07 Nov 2018 01:24:12 GMT):
https://sawtooth-next-directory.readthedocs.io/
kthblmfld (Wed, 07 Nov 2018 01:24:41 GMT):
Not sure how to move forward doing this on the main HL repo. I support I will reach out to HL help desk
kthblmfld (Wed, 07 Nov 2018 01:53:51 GMT):
Hmmm looks like it was already there. Docs are connected!
adamgering (Thu, 08 Nov 2018 23:28:47 GMT):
I believe this will reset the index if .gitattributes change confused get was to what type images are:
git reset --mixed
adamgering (Thu, 08 Nov 2018 23:28:47 GMT):
I believe this will reset the index if .gitattributes change confused git was to what type images are:
git reset --mixed
adamgering (Thu, 08 Nov 2018 23:28:47 GMT):
I believe this will reset the index if .gitattributes change confused git as to what type images are:
git reset --mixed
anasatkeeva (Fri, 09 Nov 2018 00:03:33 GMT):
@adamgering Thanks
adamgering (Fri, 09 Nov 2018 03:50:20 GMT):
Developers must run black before submitting a PR.
adamgering (Fri, 09 Nov 2018 03:50:22 GMT):
bin/build -f && bin/run_lint
adamgering (Fri, 09 Nov 2018 18:36:42 GMT):
https://github.com/hyperledger/sawtooth-next-directory/pull/527
kthblmfld (Fri, 09 Nov 2018 19:04:18 GMT):
@mtn206 can you take a look at that PR?
mtn206 (Fri, 09 Nov 2018 19:05:13 GMT):
Yes I can
kthblmfld (Fri, 09 Nov 2018 19:05:42 GMT):
Thank you sir!
adamgering (Sat, 10 Nov 2018 01:56:38 GMT):
https://github.com/hyperledger/sawtooth-next-directory/pull/532
adamgering (Mon, 12 Nov 2018 18:51:25 GMT):
https://github.com/hyperledger/sawtooth-next-directory/pull/532
agoldingay (Mon, 12 Nov 2018 21:31:24 GMT):
#384 needs review
agoldingay (Mon, 12 Nov 2018 21:32:56 GMT):
#388 needs review
adamgering (Mon, 12 Nov 2018 21:51:19 GMT):
https://github.com/hyperledger/sawtooth-next-directory/pull/536
adamgering (Tue, 13 Nov 2018 21:32:13 GMT):
https://sawtooth-next-directory.readthedocs.io/
agoldingay (Thu, 15 Nov 2018 18:53:13 GMT):
Hello All, stand up info 11:30amPST, https://meet.t-mobile.com/agnes.goldingay1/GLZW4V1B Dial in: 1-844-202-5500,,5597946674# (Northwest) Conference ID: 5597946674
agoldingay (Thu, 15 Nov 2018 23:29:54 GMT):
#538, #539 and #541 needs review. Thanks!
adamgering (Fri, 16 Nov 2018 16:45:30 GMT):
PRs and Commits should generally have the same title, so you can easily find the PR from given the commit title.
kthblmfld (Fri, 16 Nov 2018 17:00:34 GMT):
But if we go with the idea that I commit needs to be explicitly oriented towards exactly what it does (ie: feature, crlf, whitespace... all separate commits in one PR), then the PR -> commit relationship becomes one to many
kthblmfld (Fri, 16 Nov 2018 17:07:59 GMT):
@pgobin I would like to discuss the idea of changing requirements for approvals on UI merges during standup, or just float the idea now: I have not been reviewing your PRs. Rather, I have been rubber stamping them with instant approval. We all have, with the occasional non-blocking comment about obvious mistakes (typos, copyright, nitpick). My point: It feels like admin work more than it does code review and quality collaboration.
kthblmfld (Fri, 16 Nov 2018 17:09:26 GMT):
Likewise, we don't receive (and don't expect) much participation in our backend PRs from the front end team. I would like to transition towards an as-needed inclusion between teams so as to ensure the eyes on the PRs are those that add the most value
kthblmfld (Fri, 16 Nov 2018 17:09:38 GMT):
I hope that works for you, too :)
pgobin (Fri, 16 Nov 2018 18:35:30 GMT):
@kthblmfld agreed. i would highly recommend not rubber stamping anything just as a general rule. take a look at https://github.com/hyperledger/sawtooth-next-directory/pull/595 for instance. just glancing at this PR it's clear it doesn't meet a certain baseline. Lint aside, which is being worked (i know it's taking a while, but i'd like to see it implemented by offshore correctly + i've been thoroughly refactoring bad code that may have accidentally got in), there are obvious weird things. this is an example of a PR that should be rejected immediately by the first person to get their hands on reviewing it.
pgobin (Fri, 16 Nov 2018 18:40:46 GMT):
i would also like to see comments challenging the rationale of code decisions just like there would be on the backend.
pgobin (Fri, 16 Nov 2018 18:45:47 GMT):
so with regard to your idea of eyes on the backend PRs, i like the idea of as-needed. how we want to go about PR participation may just be as a general rule: see a PR, look over a PR. don't understand something then add a comment, whether you're asked as a reviewer or not.
pgobin (Fri, 16 Nov 2018 18:48:10 GMT):
that is a good bridge to better collaboration between teams for a start. what do you think?
kthblmfld (Fri, 16 Nov 2018 18:53:20 GMT):
"i would also like to see comments challenging the rationale of code decisions just like there would be on the backend."
kthblmfld (Fri, 16 Nov 2018 18:53:38 GMT):
Absolutely. Point received
kthblmfld (Fri, 16 Nov 2018 18:54:13 GMT):
We have a similar need in the backend to sort out some bad code
pgobin (Fri, 16 Nov 2018 18:55:08 GMT):
also when you said as-needed, i may have misinterpreted that. does that mean you want only approvers on a given PR that are relevant to it or does it mean you want to bring in more people on an as-need basis?
pgobin (Fri, 16 Nov 2018 19:00:07 GMT):
so for instance with UI PRs, i've been including you, adam, and nadia. am i right in interpreting as-needed as _not_ including those who aren't directly involved in the implemented functionality at hand?
kthblmfld (Fri, 16 Nov 2018 19:01:23 GMT):
It means relaxing requirements on UI work - the idea of required 2 approvers. Since code changes ultimately report up to you regarding UI, it is your approval that really matters
kthblmfld (Fri, 16 Nov 2018 19:02:16 GMT):
If/when that changes during integration and/or if we add React UI contributors, then that could change
kthblmfld (Fri, 16 Nov 2018 19:02:31 GMT):
Or you could do your approval + that of an additional offshore
kthblmfld (Fri, 16 Nov 2018 19:03:11 GMT):
"i like the idea of as-needed. how we want to go about PR participation may just be as a general rule: see a PR, look over a PR. don't understand something then add a comment, whether you're asked as a reviewer or not.
that is a good bridge to better collaboration between teams for a start. what do you think?"
kthblmfld (Fri, 16 Nov 2018 19:03:15 GMT):
Exactly. Agreed
pgobin (Fri, 16 Nov 2018 19:04:14 GMT):
ah gotcha. yeah that will certainly improve our pace as well. totally on the same page now.
mtn206 (Fri, 16 Nov 2018 19:28:55 GMT):
`LDAP_DC=DC=clouddev,DC=corporate,DC=t-mobile,DC=com`
mtn206 (Fri, 16 Nov 2018 19:28:55 GMT):
`DC=clouddev,DC=corporate,DC=t-mobile,DC=com`
kthblmfld (Fri, 16 Nov 2018 20:50:57 GMT):
@pgobin we are seeing an error in the client module
kthblmfld (Fri, 16 Nov 2018 20:51:00 GMT):
On master
kthblmfld (Fri, 16 Nov 2018 20:51:03 GMT):
The error:
kthblmfld (Fri, 16 Nov 2018 20:51:16 GMT):
module.js:550
throw err;
^
Error: Cannot find module './build/css'
at Function.Module._resolveFilename (module.js:548:15)
at Function.Module._load (module.js:475:25)
at Module.require (module.js:597:17)
at require (internal/module.js:11:18)
at Object.
kthblmfld (Fri, 16 Nov 2018 20:51:34 GMT):
yarn -> gulp -> module lookup -> doom
kthblmfld (Fri, 16 Nov 2018 20:51:34 GMT):
ok thanks!
pgobin (Fri, 16 Nov 2018 20:51:44 GMT):
i forgot to include a directory i believe
pgobin (Fri, 16 Nov 2018 20:51:47 GMT):
let me fix that
kthblmfld (Fri, 16 Nov 2018 20:52:23 GMT):
Ok thanks
kthblmfld (Fri, 16 Nov 2018 20:52:24 GMT):
!!!
pgobin (Fri, 16 Nov 2018 20:57:11 GMT):
pr that fixes issue https://github.com/hyperledger/sawtooth-next-directory/pull/598
pgobin (Fri, 16 Nov 2018 20:57:18 GMT):
will merge once build finishes
pgobin (Fri, 16 Nov 2018 21:08:14 GMT):
merged
adamgering (Sat, 17 Nov 2018 01:28:47 GMT):
I'll avoid reviewing UI until Phil approves first. The front-end need to tighten up the build (Travis) validation (lint, etc) so the obvious stuff doesn't pass build validation.
kthblmfld (Sat, 17 Nov 2018 03:29:01 GMT):
@bobonana @mtn206 I have been trying to sort out some outstanding mismatches in your common refactor and my PR, and am finding some issues in the refactored change. This doesn't affect my work since it isn't using the common features, but we should hold off on any additional consolidation work between the 2 features because they are currently in development.
kthblmfld (Sat, 17 Nov 2018 03:29:57 GMT):
Once they are stable, tested, hardened they can be cleaned up. Does that work? Thanks
bobonana (Sat, 17 Nov 2018 06:26:34 GMT):
As long as we all agree on it I'm down for whatever. I think one reason behind the refactor was so that we could test and harden a single provider pattern instead of splitting our efforts between the two, but if you feel we've past the point of diminishing returns I'm down to split and stabilize what we have
kthblmfld (Sun, 18 Nov 2018 04:56:43 GMT):
I am generally onboard with cleaning up clutter, deleting functions no longer in use, consolidating duplicate code, but AD and AAD integration is work-in-progress. Hands off until we have the fully built features plz
adamgering (Sun, 18 Nov 2018 21:14:56 GMT):
[20:51:46] Plumber found unhandled error:
Error in plugin "gulp-flatten"
Message:
not implemented
/client/node_modules/readable-stream/lib/_stream_transform.js:159
throw new Error('not implemented');
^
Error: not implemented
JayeshJawale2 (Mon, 19 Nov 2018 09:11:28 GMT):
Has joined the channel.
kthblmfld (Mon, 19 Nov 2018 18:25:00 GMT):
Can I get a review of https://github.com/hyperledger/sawtooth-next-directory/pull/592
kthblmfld (Mon, 19 Nov 2018 18:25:03 GMT):
??
adamgering (Mon, 19 Nov 2018 18:32:34 GMT):
I'm going to defer to Nadia and Michael
adamgering (Mon, 19 Nov 2018 18:33:08 GMT):
The configuration section is poor, but will be refactored later.
kthblmfld (Mon, 19 Nov 2018 18:34:11 GMT):
@adamgering Are you saying you are not going to review the PR? Are you also not joining us at TMO today?
adamgering (Mon, 19 Nov 2018 18:34:17 GMT):
There should be no DB_CONNECT_MAX_ATTEMPTS, the system should continue to retry forever. We will need to add monitoring instrumentation?
adamgering (Mon, 19 Nov 2018 18:34:17 GMT):
There should be no DB_CONNECT_MAX_ATTEMPTS, the system should continue to retry forever. We will need to add monitoring instrumentation.
adamgering (Mon, 19 Nov 2018 18:34:31 GMT):
I'll be at TMO later today.
kthblmfld (Mon, 19 Nov 2018 18:34:43 GMT):
If there is a log in an infinite loop, then it will spam
adamgering (Mon, 19 Nov 2018 18:35:05 GMT):
Then throttle the logging.
kthblmfld (Mon, 19 Nov 2018 18:35:17 GMT):
Can you refer to a requirements doc specifying that?
kthblmfld (Mon, 19 Nov 2018 18:35:39 GMT):
I let a ton of questionable WIP slide through last week while we were pushing PRs in
kthblmfld (Mon, 19 Nov 2018 18:35:49 GMT):
The plan is to harden later
kthblmfld (Mon, 19 Nov 2018 18:36:48 GMT):
Limiting retry attempts, breaking out of an infinite loop is not unorthodox or poor config
adamgering (Mon, 19 Nov 2018 18:37:29 GMT):
<
kthblmfld (Mon, 19 Nov 2018 18:37:48 GMT):
That is not the focus of the PR
adamgering (Mon, 19 Nov 2018 18:37:58 GMT):
The plan is to harden later >> then not throttling logging isn't spamming
kthblmfld (Mon, 19 Nov 2018 18:38:04 GMT):
The PR is intended to explicitly satisfy my sprint commitments
kthblmfld (Mon, 19 Nov 2018 18:39:13 GMT):
Whether it gives up after so many attempts or continues forever is easy to change
kthblmfld (Mon, 19 Nov 2018 18:39:24 GMT):
And I would prefer not to spend hours haggling over it
adamgering (Mon, 19 Nov 2018 18:48:03 GMT):
This needs to be in a configuration variable:
"DC=clouddev,DC=corporate,DC=t-mobile,DC=com"
kthblmfld (Mon, 19 Nov 2018 18:49:16 GMT):
I think it is at least in one case, although the name could be cleaner
kthblmfld (Mon, 19 Nov 2018 18:50:55 GMT):
Ah, it is already mapped in the file. Replacing the instance
adamgering (Mon, 19 Nov 2018 18:53:44 GMT):
This value isn't being used and isn't validated: MESSAGE_TARGET_VALUE_LDAP
adamgering (Mon, 19 Nov 2018 18:54:28 GMT):
Validate the value looks correct, rather than: MESSAGE_TARGET_VALUE_LDAP == MESSAGE_TARGET_VALUE_INVALID
adamgering (Mon, 19 Nov 2018 19:15:56 GMT):
run black before committing PRs
adamgering (Mon, 19 Nov 2018 19:22:12 GMT):
also, you'll do yourself a favor to turn on strict linting.
adamgering (Mon, 19 Nov 2018 19:22:39 GMT):
but black needs to be fixed, there will be a PR to add it to Travis.
adamgering (Mon, 19 Nov 2018 19:22:47 GMT):
rbac/providers/azure/delta_outbound_sync.py:77:4: R1705: Unnecessary "elif" after "return" (no-else-return)
rbac/providers/azure/delta_outbound_sync.py:93:4: R1705: Unnecessary "elif" after "return" (no-else-return)
rbac/providers/azure/delta_outbound_sync.py:103:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
rbac/providers/azure/delta_outbound_sync.py:112:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
kthblmfld (Mon, 19 Nov 2018 19:26:24 GMT):
We are pairing through this now
kthblmfld (Mon, 19 Nov 2018 19:26:31 GMT):
And I have been running black
adamgering (Mon, 19 Nov 2018 19:30:26 GMT):
reformatted /Users/adamgering/Src/Hyperledger/sawtooth-next-directory/rbac/providers/ldap/outbound_queue_listener.py
reformatted /Users/adamgering/Src/Hyperledger/sawtooth-next-directory/tests/unit/providers/ldap/ldap_message_validator_test.py
adamgering (Mon, 19 Nov 2018 19:31:16 GMT):
i.e. those files were not formatted in the PR
kthblmfld (Tue, 20 Nov 2018 01:37:50 GMT):
Got it. Yea there were a number of discussions happening followed by commits. Should be squashed and ready soon!
kthblmfld (Tue, 20 Nov 2018 02:23:35 GMT):
Ok, PR is stable again. Please review: https://github.com/hyperledger/sawtooth-next-directory/pull/592/files
kthblmfld (Tue, 20 Nov 2018 02:34:23 GMT):
Bah, linter is failing over some test restructuring we did earlier. Investigating
kthblmfld (Tue, 20 Nov 2018 02:59:36 GMT):
Ok, all sorted
Ankita1 (Tue, 20 Nov 2018 10:50:46 GMT):
Has joined the channel.
kthblmfld (Thu, 22 Nov 2018 05:49:19 GMT):
@mtn206 @bobonana I don't want to step on any toes but we committed this sprint to @nadiab22 and @bobonana delivering AAD sync and @mtn206 and myself delivering AD sync. It looks like the effort in moving features of each into common has resulted in bugs being duplicated across files, new features shimmed in, and uncommon functions going into a 'common' package.
kthblmfld (Thu, 22 Nov 2018 05:49:19 GMT):
@mtn206 @bobonana I don't want to step on any toes but we committed this sprint to @nadiab22 and @bobonana delivering AAD sync and @mtn206 and myself delivering AD sync. It looks like the effort in moving features of each into common has resulted in bugs being duplicated across files, disparate features shimmed in, and uncommon functions going into a 'common' package.
kthblmfld (Thu, 22 Nov 2018 05:52:38 GMT):
I am still committed to delivering something by Monday that behaves as expected. Because of this, I may ignore the changelog part of the sync since it is a separate story altogether IMO (if it isn't essential to data sync, then it is a feature in its own right)
kthblmfld (Thu, 22 Nov 2018 05:52:38 GMT):
I am still committed to delivering something by Monday that behaves as expected. Because of this, I may ignore the changelog part of the sync since it is a separate story altogether IMO (if it isn't essential to data sync, then it is an ancillary feature in its own right)
kthblmfld (Thu, 22 Nov 2018 05:54:23 GMT):
Also, I may keep my work local to 'ldap' leaving the idea of sharing functionality for later when we better understand the nuances of the systems we are integrating with
kthblmfld (Thu, 22 Nov 2018 06:01:02 GMT):
I will incorporate whatever other changes from 'common' I can manage to (filtering and mapping)
bobonana (Thu, 22 Nov 2018 06:02:11 GMT):
That's cool, I've resolved all of my blockers with the inbound sync and should wrap it up late tonight
kthblmfld (Thu, 22 Nov 2018 06:03:27 GMT):
Nice. I hit an issue with mapping the object from AD and am hoping the changes in the new filter/map resolve it
nadiab22 (Fri, 23 Nov 2018 16:37:08 GMT):
:thumbup_tone4:
kthblmfld (Sat, 24 Nov 2018 08:10:42 GMT):
I just had a Travis build fail on an auth error while attempting to pull sawtooth-rest-api :(. Hoping it's a one-off. Rebuilding...
pgobin (Sun, 25 Nov 2018 15:04:37 GMT):
hey everyone. please take a look at PR #630, which lays out the foundation of the chatbot: https://github.com/hyperledger/sawtooth-next-directory/pull/630. i would like feedback and a consensus on the direction. if folks like it, it’s ready to merge. thanks.
kthblmfld (Sun, 25 Nov 2018 17:10:45 GMT):
@pgobin Can we make a deal? I have a PR out as well that is laying down a foundation for our synchers while incorporating upstream/downstream WIP. Adding you to reviewers.
kthblmfld (Sun, 25 Nov 2018 17:11:21 GMT):
There will be a follow-up PR that completes the sync end to end for LDAP
agoldingay (Mon, 26 Nov 2018 17:02:54 GMT):
Please close out any tickets in Sprint 6 that are complete. I'm reconciling the S6 board this am. Thanks!
kthblmfld (Wed, 28 Nov 2018 20:14:48 GMT):
@bobonana @mtn206 We (@nadiab22, @adamgering , and I) will be continuing to visit and work in the 3305 offices as long as there is space available. Please (and thank you) continue booking rooms for our sessions and post them to @sawtooth-next-dev.
kthblmfld (Wed, 28 Nov 2018 20:14:48 GMT):
@bobonana @mtn206 We (@nadiab22, @adamgering , and I) will be continuing to visit and work in the 3305 offices as long as there is space available. Please (and thank you) continue booking rooms for our sessions and post them to #sawtooth-next-dev sawtooth-next-dev.
kthblmfld (Wed, 28 Nov 2018 20:14:48 GMT):
@bobonana @mtn206 We (@nadiab22, @adamgering , and I) will be continuing to visit and work in the 3305 offices as long as there is space available. Please (and thank you) continue booking rooms for our sessions and post them to #sawtooth-next-dev.
mtn206 (Wed, 28 Nov 2018 21:03:50 GMT):
Will do!
adamgering (Wed, 28 Nov 2018 22:06:22 GMT):
Some interesting (and successful) open source contribution guidelines (from Pieter Hintjens of ZMQ):
14. Maintainers SHALL NOT make value judgments on correct patches.
15. Maintainers SHALL merge correct patches from other Contributors rapidly.
18. Any Contributor who has value judgments on a patch SHOULD express these via their own patches.
https://rfc.zeromq.org/spec:42/C4/
A "correct patch" is:
2. A patch SHOULD be a minimal and accurate answer to exactly one identified and agreed problem.
3. A patch MUST adhere to the code style guidelines of the project if these are defined.
6. A patch MUST compile cleanly and pass project self-tests
+ compliance with 2.6. Evolution of Public Contracts
1. All Public Contracts (APIs or protocols) SHALL be documented.
etc..
kthblmfld (Wed, 28 Nov 2018 23:06:58 GMT):
@nadiab22 @mtn206 Just returned from a 1-1 with Patrick. Setting Nan up with a task so he can start adding value. Unable to work tonight and thus skeptical my current branch in progress will go into PR
nadiab22 (Wed, 28 Nov 2018 23:08:06 GMT):
Can you give me a summary of what you are working on? Like can we take over the issue from where you are?
nadiab22 (Wed, 28 Nov 2018 23:08:17 GMT):
Do a handoff like Ned and I did?
nadiab22 (Wed, 28 Nov 2018 23:08:35 GMT):
@kthblmfld ^
nadiab22 (Wed, 28 Nov 2018 23:09:19 GMT):
Or can we work with Nan?
nadiab22 (Wed, 28 Nov 2018 23:09:32 GMT):
To free you up?
nadiab22 (Wed, 28 Nov 2018 23:12:33 GMT):
@kthblmfld
kthblmfld (Wed, 28 Nov 2018 23:20:19 GMT):
Ok you scared Ned
nadiab22 (Wed, 28 Nov 2018 23:20:40 GMT):
?
kthblmfld (Wed, 28 Nov 2018 23:20:44 GMT):
You could work with Nan
kthblmfld (Wed, 28 Nov 2018 23:21:10 GMT):
I haven't looked at the feature for a few days
nadiab22 (Wed, 28 Nov 2018 23:21:15 GMT):
Great. So you will be working on your PR?
kthblmfld (Wed, 28 Nov 2018 23:21:27 GMT):
Also, encountered that 12:30-4:30 am issue in the last feature
kthblmfld (Wed, 28 Nov 2018 23:21:42 GMT):
Yes
kthblmfld (Wed, 28 Nov 2018 23:21:44 GMT):
soon
kthblmfld (Wed, 28 Nov 2018 23:22:05 GMT):
If I can get Nan setup, we will have one more person adding value
nadiab22 (Wed, 28 Nov 2018 23:22:40 GMT):
What are you doing to get him setup
nadiab22 (Wed, 28 Nov 2018 23:22:58 GMT):
He is telling me he is working on unit tests
kthblmfld (Wed, 28 Nov 2018 23:23:02 GMT):
Enabling unit tests in his IDE
kthblmfld (Wed, 28 Nov 2018 23:23:03 GMT):
corrent
kthblmfld (Wed, 28 Nov 2018 23:23:05 GMT):
correct
kthblmfld (Wed, 28 Nov 2018 23:23:13 GMT):
Also, we can open a ticket for him
nadiab22 (Wed, 28 Nov 2018 23:23:23 GMT):
Great. Can I do a call with him to free you up now?
kthblmfld (Wed, 28 Nov 2018 23:23:29 GMT):
Sure
kthblmfld (Wed, 28 Nov 2018 23:23:33 GMT):
Let's have a call
nadiab22 (Wed, 28 Nov 2018 23:23:41 GMT):
I am calling Nan
kthblmfld (Wed, 28 Nov 2018 23:23:41 GMT):
Ned will call
PatrickLammers (Fri, 30 Nov 2018 19:16:42 GMT):
Has joined the channel.
DirkT (Mon, 03 Dec 2018 13:00:06 GMT):
Has joined the channel.
PatrickLammers (Mon, 03 Dec 2018 18:54:17 GMT):
Hey Keith...
kthblmfld (Mon, 03 Dec 2018 18:54:27 GMT):
Hey @PatrickLammers
bobonana (Mon, 03 Dec 2018 23:09:18 GMT):
working on #667 for the next integration daemon, does anybody know the intended schema of the `state` table in rethink?
adamgering (Tue, 04 Dec 2018 02:20:35 GMT):
object_type, object_id, related_type, relationship_type, related_id, data
adamgering (Tue, 04 Dec 2018 02:20:51 GMT):
data == the container protobuf
adamgering (Tue, 04 Dec 2018 02:21:04 GMT):
so see the *.proto files for the schema
adamgering (Tue, 04 Dec 2018 20:03:48 GMT):
Proposing to adopt the Collective Code Construction Contract (C4):
adamgering (Tue, 04 Dec 2018 20:03:51 GMT):
https://rfc.zeromq.org/spec:42/C4/
kthblmfld (Wed, 05 Dec 2018 00:13:36 GMT):
The NEXT sync
PatrickLammers (Thu, 06 Dec 2018 00:31:31 GMT):
@bobonana Hey, I just read story #323 and I wanted to congratulate you on it... Probably the best written story I've seen so far in our backlog. I love the inclusion of the acceptance criteria and the business value. We should strive for this level of detail on every story... too bad this got closed as a dup of lesser stories. :-)
bobonana (Thu, 06 Dec 2018 00:41:16 GMT):
Haha, thanks @PatrickLammers I appreciate it! 😁
bobonana (Thu, 06 Dec 2018 00:43:07 GMT):
@mtn206 should get most of the credit for that, issue #321 was the baseline that I used
bobonana (Fri, 07 Dec 2018 20:26:55 GMT):
Our dev azure subscription has been disabled. Is there any way to re-enable it, or get admin rights in our enterprise dev environment (or someone with admin rights) to create the required resources for us so we can migrate? `rbac-provider-azure` will continue to break until we have a working azure instance with resources to point it at.
kthblmfld (Fri, 07 Dec 2018 22:17:29 GMT):
Docs appear to be fixed. Thanks for the rapid response @adamgering @nadiab22 : https://sawtooth-next-directory.readthedocs.io/en/latest/
nadiab22 (Fri, 07 Dec 2018 22:20:31 GMT):
:thumbup_tone4:
kthblmfld (Tue, 11 Dec 2018 21:42:50 GMT):
@mtn206 Cna we get an update on the test environment?
kthblmfld (Tue, 11 Dec 2018 21:42:50 GMT):
@mtn206 Can we get an update on the test environment?
nadiab22 (Wed, 12 Dec 2018 15:10:37 GMT):
I will be in at T-mobile at 1:30pm today. I have appointments until then so I will be offline.
kthblmfld (Thu, 13 Dec 2018 20:16:28 GMT):
Is anybody available to pick up tasks today?
kthblmfld (Thu, 13 Dec 2018 20:17:18 GMT):
Working on getting @nadiab22, @pgobin, and @anasatkeeva supported
kthblmfld (Thu, 13 Dec 2018 20:17:36 GMT):
@mtn206 , @bobonana what are y'all up to?
anasatkeeva (Thu, 13 Dec 2018 20:18:18 GMT):
They are at a Holiday Party
anasatkeeva (Thu, 13 Dec 2018 20:18:33 GMT):
The TMO Holiday Party
anasatkeeva (Thu, 13 Dec 2018 20:18:37 GMT):
@kthblmfld
kthblmfld (Thu, 13 Dec 2018 20:18:51 GMT):
Ah ok
kthblmfld (Thu, 13 Dec 2018 20:19:19 GMT):
Thanks @anasatkeeva . Is this an all-day thing?
anasatkeeva (Thu, 13 Dec 2018 20:19:54 GMT):
They finish at 4:30 I think. I am heading there soon too :)
bobonana (Wed, 19 Dec 2018 01:22:13 GMT):
Hey, we have a dev/stg deployment up and running at http://10.75.45.102:4201/login
bobonana (Wed, 19 Dec 2018 01:23:50 GMT):
it's pointed at our dev LDAP and the dev (deprecated) AAD. I'll update AAD once we get a new instance up with an active subscription. I need to contact michael but once I do I'll spin up a second stg instance tied to an on-prem LDAP if we want that.
bobonana (Wed, 19 Dec 2018 01:26:17 GMT):
anybody who wants to redeploy can get the ssh keys as per the instrucitons Michael sent out last week before his PTO using a script like this:
```
#!/usr/bin/env bash
#ssh into the server and upgrade the server
ssh -i
bobonana (Wed, 19 Dec 2018 01:26:17 GMT):
anybody who wants to redeploy can get the ssh keys as per the instrucitons Michael sent out last week before his PTO using a script like this:
```
#!/usr/bin/env bash
#ssh into the server and upgrade the server
ssh -i
satkeeva (Wed, 19 Dec 2018 18:38:26 GMT):
Has joined the channel.
dustinbarnes (Wed, 19 Dec 2018 19:28:51 GMT):
Has joined the channel.
ra_w (Thu, 20 Dec 2018 10:10:36 GMT):
`rbac-client | Failed to compile.
rbac-client |
rbac-client | ./src/semantic/semantic.css (./node_modules/css-loader??ref--6-oneOf-3-1!./node_modules/postcss-loader/src??postcss!./src/semantic/semantic.css)
rbac-client | Module not found: Can't resolve './dist/themes/default/assets/fonts/brand-icons.eot' in '/client/src/semantic'
`
Unable to start rbac client, is there any solution for this.
kthblmfld (Thu, 20 Dec 2018 15:48:22 GMT):
@ra_w Are you using the most recent code from master? There was a Semantic compilation issue a few weeks back.
ra_w (Thu, 20 Dec 2018 18:46:47 GMT):
@kthblmfld I have updated the code and rebuild docker but still same semantic compilation issue.
kthblmfld (Thu, 20 Dec 2018 18:47:36 GMT):
When you look in your sources, is the file there?
ra_w (Thu, 20 Dec 2018 18:51:33 GMT):
Yes the file is there in client/src/semantic/themes/default/assets/fonts/
ra_w (Thu, 20 Dec 2018 18:51:45 GMT):
but it is not building, dist is not there
kthblmfld (Thu, 20 Dec 2018 18:54:15 GMT):
client/src/sematic/dist is missing? @pgobin did you check it in?
pgobin (Thu, 20 Dec 2018 18:54:43 GMT):
i haven't checked dist in yet
pgobin (Thu, 20 Dec 2018 18:54:55 GMT):
as a workaround, run `yarn build:semantic`
kthblmfld (Thu, 20 Dec 2018 18:56:15 GMT):
Thanks. @ra_w does that work for you?
ra_w (Thu, 20 Dec 2018 18:56:57 GMT):
Thanks @pgobin and @kthblmfld I will check and update.
kthblmfld (Thu, 20 Dec 2018 18:57:07 GMT):
:thumbsup:
kthblmfld (Thu, 20 Dec 2018 18:58:50 GMT):
I am not seeing the issue because I am in that state. I have /dist built locally.
kthblmfld (Thu, 20 Dec 2018 19:06:57 GMT):
Opened #875. Thanks for the reminder, @rajatwasan.
ra_w (Thu, 20 Dec 2018 19:29:38 GMT):
Got it @kthblmfld Its working now.
kthblmfld (Thu, 20 Dec 2018 20:39:15 GMT):
:thumbsup:
bobonana (Fri, 21 Dec 2018 23:20:58 GMT):
hey guys
bobonana (Fri, 21 Dec 2018 23:21:13 GMT):
just set up an internal tinyurl for our STG environment
bobonana (Fri, 21 Dec 2018 23:21:14 GMT):
hit http://tm/nextstg while on the vpn
MohitJuneja (Sun, 23 Dec 2018 10:30:07 GMT):
Has joined the channel.
nadiab22 (Mon, 24 Dec 2018 17:12:22 GMT):
Nice thanks!
adamgering (Tue, 25 Dec 2018 20:15:55 GMT):
@ra_w Builds semantic on client container start #902 -- this will fix it.
adamgering (Tue, 25 Dec 2018 20:43:33 GMT):
and/or Prebuilds semantic assets #903
PatrickLammers (Wed, 26 Dec 2018 16:59:10 GMT):
are these tied to an existing story in S9?
adamgering (Wed, 26 Dec 2018 21:26:27 GMT):
Bug #875
nadiab22 (Thu, 27 Dec 2018 20:53:00 GMT):
Good news Patrick! I can role out the new version to the staging instance and you should be able to log in as users in our system.
nadiab22 (Thu, 27 Dec 2018 20:53:07 GMT):
@PatrickLammers ^
nadiab22 (Thu, 27 Dec 2018 20:53:19 GMT):
I will be working on that now and let you know when it is done
PatrickLammers (Thu, 27 Dec 2018 20:53:26 GMT):
kewl!
nadiab22 (Thu, 27 Dec 2018 21:55:25 GMT):
It is up and running
nadiab22 (Fri, 28 Dec 2018 22:27:30 GMT):
I have deployed the latest build
nadiab22 (Mon, 31 Dec 2018 21:01:44 GMT):
@PatrickLammers @pgobin Latest build deployed
MuhammedHafil (Tue, 08 Jan 2019 11:48:29 GMT):
Has joined the channel.
MuhammedHafil (Tue, 08 Jan 2019 11:48:46 GMT):
can anybody tell me how to use this app?
MuhammedHafil (Tue, 08 Jan 2019 11:48:49 GMT):
any demos?
MuhammedHafil (Tue, 08 Jan 2019 11:49:57 GMT):
next.png
PatrickLammers (Wed, 09 Jan 2019 00:02:08 GMT):
Hi Muhammed -- the reason yours looks blank is that there is no data in the DB. We should maybe whip up a script that would generate some content for people who are just getting started so they don't see this... I'll get that on our backlog. For now, you can click on the M in the upper right to drop down the menu and and go to "manage". Then select the "roles" tile and then "create a role" in the upper right.
PatrickLammers (Wed, 09 Jan 2019 00:02:57 GMT):
I'm going to assume you have read through the wiki and know what we are trying to accomplish around role based access control so I won't go into that...
PatrickLammers (Wed, 09 Jan 2019 00:03:20 GMT):
Remember that every time you take it down and bring it back up, your DB will be empty again.
adamgering (Wed, 09 Jan 2019 02:34:24 GMT):
You can start the app using ```bin/start -p``` if you want to data to persist.
MuhammedHafil (Wed, 09 Jan 2019 07:00:58 GMT):
Thanks @PatrickLammers @adamgering
amundson (Tue, 22 Jan 2019 16:15:25 GMT):
hi folks - we are reviewing repo permissions today and I've updated sawtooth-next-directory's permissions to match the MAINTAINERS.md file. Thanks.
amundson (Tue, 22 Jan 2019 16:16:43 GMT):
while doing this I noticed a "Untitled-7" file in the repo - looks like garbage
amundson (Tue, 22 Jan 2019 16:19:38 GMT):
what's chatbot?
amundson (Tue, 22 Jan 2019 16:20:25 GMT):
uhh, this windows-dependencies/ directory has a tar.gz file. things are off the rails here.
george.vanica (Tue, 22 Jan 2019 19:07:26 GMT):
Has joined the channel.
ChrisSpanton (Tue, 22 Jan 2019 23:45:28 GMT):
Hey @amundson - I appreciate that there's an effort to maintain cleanliness and consistency between projects here, however I dont think that unilaterally making these changes without discussing with our maintainers is appropriate. We're in alignment on objectives, but I question the timing and communication.
amundson (Wed, 23 Jan 2019 00:00:32 GMT):
Hmm, sorry, I thought you were onboard from the previous conversations.
amundson (Wed, 23 Jan 2019 00:01:46 GMT):
@ChrisSpanton want it reverted?
amundson (Wed, 23 Jan 2019 00:04:19 GMT):
It is reverted - going offline - lets chat about it tomorrow.
ChrisSpanton (Wed, 23 Jan 2019 00:13:50 GMT):
Thanks @amundson. We are ACTIVELY (like accepted in this sprint active) addressing this in a comprehensive way. We'll be onboard with a consolidated process and permission structure very soon :)
ChrisSpanton (Wed, 23 Jan 2019 00:13:56 GMT):
thanks for the response!
amundson (Wed, 23 Jan 2019 00:44:40 GMT):
@ChrisSpanton addressing it how? are you planning ot spin the project out of Sawtooth?
ChrisSpanton (Wed, 23 Jan 2019 17:33:04 GMT):
We're exploring all options. Initially and for the short term, implement an appropriate branching/commit flow and permission to that, allowing us to restrict master. Longer term, determining whether this or elsewhere is the best place for the project.
amundson (Wed, 23 Jan 2019 18:41:20 GMT):
I don't think it is appropriate to define any new branching/commit/versioning workflow or new permissioning model without going through the sawtooth governance/rfc process. It's not a T-Mobile-only or next-directory-only "project", or at least it shouldn't be, and we already have norms that work pretty well for Sawtooth. If its what you want to do, I am supportive of spinning next directory off as a lab and eventual HL project (though there is resistence to app projects, which should be considered) with its own governance structure. Right now it's positioned as an Sawtooth example app similar to sawtooth-supply-chain and sawtooth-marketplace, and I suspect that's not how you would describe the project. sawtooth-supply-chain is being spun off as the basis for Hyperledger Grid, and we will probably deprecate sawtooth-supply-chain as a result (or maybe just simplify it if we need to keep it as an example). So, there is good precedent for it.
amundson (Wed, 23 Jan 2019 18:41:20 GMT):
I don't think it is appropriate to define any new branching/commit/versioning workflow or new permissioning model without going through the sawtooth governance/rfc process. It's not a T-Mobile-only or next-directory-only "project", or at least it shouldn't be, and we already have norms that work pretty well for Sawtooth. If its what you want to do, I am supportive of spinning next directory off as a lab and eventual HL project (though there is TSC resistence to app projects, which should be considered) with its own governance structure. Right now it's positioned as an Sawtooth example app similar to sawtooth-supply-chain and sawtooth-marketplace, and I suspect that's not how you would describe the project. sawtooth-supply-chain is being spun off as the basis for Hyperledger Grid, and we will probably deprecate sawtooth-supply-chain as a result (or maybe just simplify it if we need to keep it as an example). So, there is good precedent for it.
agunde (Wed, 23 Jan 2019 20:20:04 GMT):
Has joined the channel.
nadiab22 (Tue, 29 Jan 2019 22:43:13 GMT):
https://stackoverflow.com/questions/33973820/rethinkdb-connection-must-be-open-but-never-gets-closed Possible cause of timeout error @bobonana
jramsdale (Wed, 30 Jan 2019 00:46:17 GMT):
Has joined the channel.
agunde (Thu, 07 Feb 2019 14:39:00 GMT):
Has left the channel.
bobonana (Mon, 11 Feb 2019 23:16:04 GMT):
hey guys
bobonana (Mon, 11 Feb 2019 23:16:32 GMT):
so I'm tracking down the inbound sync bug in ledger-sync
bobonana (Mon, 11 Feb 2019 23:16:56 GMT):
#1122
bobonana (Mon, 11 Feb 2019 23:17:55 GMT):
I'm pretty sure I've got it tracked down to the rethink query in lines 125-132 of rbac/ledger-sync/deltas/updating.py
bobonana (Mon, 11 Feb 2019 23:19:48 GMT):
I think it's replacing the document with the result of merging the changed fields with the document. which is why removing users from a group isn't working
bobonana (Mon, 11 Feb 2019 23:20:45 GMT):
do you guys have any suggestions for how to patch this quickly?
bobonana (Mon, 11 Feb 2019 23:20:49 GMT):
```def _update_legacy(database, block_num, address, resource, data_type):
""" Update the legacy sync tables (expansion by object type name)
"""
try:
data = {
"id": address,
"start_block_num": int(block_num),
"end_block_num": int(sys.maxsize),
**resource,
}
table_query = database.get_table(TABLE_NAMES[data_type])
query = table_query.get(address).replace(
lambda doc: r.branch(
# pylint: disable=singleton-comparison
(doc == None), # noqa
r.expr(data),
doc.merge(resource),
)
)
result = database.run_query(query)
if result["errors"] > 0:
LOGGER.warning("error updating legacy state table:\n%s\n%s", result, query)
except Exception as err: # pylint: disable=broad-except
LOGGER.warning("_update_legacy %s error:", type(err))
LOGGER.warning(err)```
bobonana (Tue, 12 Feb 2019 21:16:40 GMT):
quick question
bobonana (Tue, 12 Feb 2019 21:17:03 GMT):
does anybody have an example payload of an entry in hte inbound queue for a delta inbound sync from ldap?
bobonana (Tue, 12 Feb 2019 21:17:42 GMT):
for example, when removing a user from a group, what does that look like as a delta inbound entry in the inbound queue
bobonana (Tue, 12 Feb 2019 21:18:08 GMT):
Or does anybody have access to the test ldap instance that can help me generate and get that payload
ChrisSpanton (Fri, 15 Feb 2019 18:08:48 GMT):
@bobonana we talked about this Wednesday, and you said you would prep and hit me for a sample first thing yesterday :)
ChrisSpanton (Fri, 15 Feb 2019 18:08:48 GMT):
@bobonana you said you would prep and hit me for a sample first thing yesterday :)
ChrisSpanton (Fri, 15 Feb 2019 18:09:09 GMT):
*is waiting*
bobonana (Fri, 15 Feb 2019 18:19:53 GMT):
I know, I'm sorry, I had to review some PRs, assist Ana with a couple tickets, and deal with some issue with the deployment environments and wasn't able to prepare for the sample changes. We had more issues last night too. I'm reaching out to Nadia and Phil about that now and will make sure I've got my debug statements set locally and run a sync so that we can push that test change. I'll need to have it running for about an hour before we sync on that so that the change comes through in a Delta sync and not the initial sync
RickyS2 (Mon, 18 Feb 2019 17:43:57 GMT):
Has joined the channel.
harun (Tue, 19 Feb 2019 06:58:45 GMT):
Has joined the channel.
PatrickLammers (Fri, 22 Feb 2019 23:31:26 GMT):
@bobonana Can you hear me now?
bobonana (Fri, 22 Feb 2019 23:34:58 GMT):
just heard you
bobonana (Fri, 22 Feb 2019 23:35:26 GMT):
was offline till 3 and the app crashed on my phone, I can't sign in on mobile right now either so I lost my status updates that were supposed to be sent this morning
bobonana (Fri, 22 Feb 2019 23:35:36 GMT):
just sent @PatrickLammers a status update
danintel (Sat, 23 Feb 2019 00:05:08 GMT):
Has left the channel.
akgunkel (Wed, 06 Mar 2019 21:40:30 GMT):
Has joined the channel.
V1122am (Fri, 08 Mar 2019 18:13:25 GMT):
Has joined the channel.
Srinuthalapati (Fri, 08 Mar 2019 18:13:47 GMT):
Has joined the channel.
adityasingh177 (Sun, 17 Mar 2019 17:33:17 GMT):
Has joined the channel.
PatrickLammers (Tue, 19 Mar 2019 22:13:44 GMT):
are we still at PR freeze for S14 or did that get lifted since we decided not to merge to mater?
PatrickLammers (Tue, 19 Mar 2019 22:14:09 GMT):
*master... not the rusty old tow truck from the Cars movie.
PatrickLammers (Thu, 21 Mar 2019 18:09:52 GMT):
Question for the team... Our Def of Done for stories says "documentation is created/updated for your change"
PatrickLammers (Thu, 21 Mar 2019 18:10:41 GMT):
so with our pending drive toward a 1.0 release, we are trying to get our documentation up to snuff...
PatrickLammers (Thu, 21 Mar 2019 18:11:19 GMT):
We should be creating UML diagrams and getting them onto the Wiki for public consumption.
PatrickLammers (Thu, 21 Mar 2019 18:12:02 GMT):
*Question: Which stories in the current sprint *should* result in UML updates/creation?*
PatrickLammers (Thu, 21 Mar 2019 18:16:02 GMT):
Related question: Where should the live in the Wiki? Create a new page called "UML data flow diagrams" and we paste our diagrams onto that page?
ChrisSpanton (Thu, 21 Mar 2019 20:18:09 GMT):
@PatrickLammers I think the more ideal location is to include them in the Sphinx (https://sawtooth-next-directory.readthedocs.io/en/latest/) source, attached to appropriate doc sections
ChrisSpanton (Thu, 21 Mar 2019 20:19:13 GMT):
@bobonana @nadiab22 @mtn206 @akgunkel @V1122am @Srinuthalapati thoughts?
bobonana (Thu, 21 Mar 2019 20:20:29 GMT):
I agree, the Sphinx docs are our official wiki. The old wiki was deprecated a while back and IMHO we should probs remove it
bobonana (Thu, 21 Mar 2019 20:20:53 GMT):
I think every major feature should have a uml diagram
PatrickLammers (Thu, 21 Mar 2019 20:21:27 GMT):
Perfect! I see we already have inbound and outbound LDAP sync flow diagrams out there.
PatrickLammers (Thu, 21 Mar 2019 20:21:37 GMT):
are they correct?
bobonana (Thu, 21 Mar 2019 20:22:07 GMT):
So if you touch a feature that does not currently have a diagram, it should probs be a success criteria and the story should be sized appropriately. We can determine this quickly enough during Sprint planning and story sizing once we have our diagrams in Sphinx (and by checking the SharePoint Michael set up for now)
bobonana (Thu, 21 Mar 2019 20:23:09 GMT):
Same as testing. If your contribution breaks a test or you touch a feature that is untested you should probs write integration tests for that feature and size the story to account for the extra work
bobonana (Thu, 21 Mar 2019 20:23:32 GMT):
Unless we want to write extra tech debt tickets to cover those missing tests and diagrams?
PatrickLammers (Thu, 21 Mar 2019 20:31:08 GMT):
tech debt tickets are only a last resort. Documentation & testing are definitely part of the def of done for every story -- we need to make this part of our regular process.
PatrickLammers (Thu, 21 Mar 2019 20:33:22 GMT):
BTW: "testing and docmentation is extra work" is a mindset we need to change. They aren't _extra_... they are key parts of the work.
PatrickLammers (Thu, 21 Mar 2019 20:40:47 GMT):
Keeping the unanswered questions fresh:
PatrickLammers (Thu, 21 Mar 2019 20:41:04 GMT):
What stories in current sprint will need UML diagrams?
PatrickLammers (Thu, 21 Mar 2019 20:41:38 GMT):
Are the current LDAP inbound and outbound diagrams in Sphinx correct?
mtn206 (Thu, 21 Mar 2019 21:30:17 GMT):
Regarding Chris' suggestion I too agree that we should be placing our UML diagrams in Sphinx docs.
mtn206 (Thu, 21 Mar 2019 21:31:00 GMT):
My ticket #334 will be needing UML diagrams not quite sure about the other tickets, perhaps we should discuss about it as a group during stand up
mtn206 (Thu, 21 Mar 2019 21:32:15 GMT):
I currently only see one diagram in Sphinx docs and it is not up to date currently
Nish (Fri, 22 Mar 2019 09:27:47 GMT):
Has joined the channel.
Nish (Fri, 22 Mar 2019 09:28:27 GMT):
Clipboard - March 22, 2019 2:57 PM
PatrickLammers (Mon, 25 Mar 2019 16:21:09 GMT):
Stepping over to the Tmobile/sawtooth-next-directory repo... The repo is now live, the code is there and I *think* our premissions are right... while Chris and I explore bulk moving of issues, i will start by manually cloning the current sprint's stories to the new repo.
PatrickLammers (Mon, 25 Mar 2019 16:21:56 GMT):
I will be closing the old ones as I go with a comment to look in the new repo as I go...
ChrisSpanton (Tue, 26 Mar 2019 17:28:22 GMT):
responding to Patrick, but also calling out the understated meta there: T-Mobile is moving our daily PR's and contributions to the Sawtooth-Next-Directory project to a fork, and will be continuing to push PR's at a regular cadence, likely at the end of our sprints.
ChrisSpanton (Tue, 26 Mar 2019 17:29:14 GMT):
Any community members may still continue to submit PR's to the existing repository, or we can discuss providing access to our new daily commit repository, at https://github.com/tmobile/sawtooth-next-directory
duncanjw (Wed, 27 Mar 2019 13:20:06 GMT):
Has joined the channel.
PatrickLammers (Tue, 09 Apr 2019 20:27:26 GMT):
Hey fellow Next-ers! I would like some feedback on the idea of a group design/task breakdown meeting following the next Sprint planning session. We are still forming as a team and it's clear that there is 'unevenness' in the spread of knowledge about the codebase. The goal would be make sure that all of the non-trivial stories would get discussed and broken down into tasks *as a team* so we are all on the same page about the work _before it gets under way._
PatrickLammers (Tue, 09 Apr 2019 20:28:14 GMT):
Thoughts?
PatrickLammers (Tue, 09 Apr 2019 20:29:21 GMT):
For the old timers on the project, this would be the old "Technical deep dive" session only with fewer arguements! :-)
ChrisSpanton (Tue, 09 Apr 2019 23:06:36 GMT):
:+1:
ChrisSpanton (Tue, 09 Apr 2019 23:06:42 GMT):
<-- I like it!
nadiab22 (Wed, 10 Apr 2019 19:41:33 GMT):
:thumbup_tone4:
nadiab22 (Thu, 11 Apr 2019 15:56:36 GMT):
Going in to change .env files on all instances. Things may not appear to work correctly until tomorrow's deploys
nadiab22 (Thu, 11 Apr 2019 16:30:57 GMT):
All files changed.
bobonana (Thu, 18 Apr 2019 21:34:41 GMT):
https://github.com/tmobile/sawtooth-next-directory/issues/80#issuecomment-484697500
bobonana (Thu, 18 Apr 2019 21:34:48 GMT):
@PatrickLammers @ChrisSpanton
ChrisSpanton (Thu, 18 Apr 2019 23:46:12 GMT):
Open to debate I think - my suggestion is that no, that is not auto-approved. I’d suggest it’s only the role owner. Now, perhaps this should be a config option? That’s likely a separate ticket however
bobonana (Fri, 19 Apr 2019 20:53:01 GMT):
cool cool, ty
bobonana (Fri, 19 Apr 2019 20:57:09 GMT):
on another note, we currently use tables in rethink for our inbound and outbound queues, in the future after V1 we might want to look into repubsub https://www.rethinkdb.com/docs/publish-subscribe/python/ to streamline things and make our code as the way we currently do this works but is a little clunky. It's by no means a priority concern tho. Anybody have thoughts on this?
nadiab22 (Mon, 22 Apr 2019 16:50:33 GMT):
Could be a good solution. I would make a ticket to evaluate the possibility of using this or finding a different solution for future sprints
PatrickLammers (Wed, 24 Apr 2019 16:41:25 GMT):
Morning everyone! It looks like our Local instance is having issues this morning. First, the admin acct cannot log in -- I get "incorrect username or pw" error message.
PatrickLammers (Wed, 24 Apr 2019 16:42:47 GMT):
Second, I can't seem to creat a new acct there... The Create Acct workflow lets me enter the full name, email, username and PW but pressing signup sends off a request that never gets a response... eventually I get a pop-up that says "Network error has occurred, please try again later"
PatrickLammers (Wed, 24 Apr 2019 17:13:35 GMT):
@Srinuthalapati @mtn206 @bobonana hello?
bobonana (Wed, 24 Apr 2019 18:52:20 GMT):
hello
bobonana (Wed, 24 Apr 2019 18:52:31 GMT):
*Marco*
Srinuthalapati (Mon, 29 Apr 2019 17:33:34 GMT):
@PatrickLammers @bobonana could you plz share the Skype invite?
bobonana (Tue, 30 Apr 2019 17:03:09 GMT):
hello
bobonana (Tue, 30 Apr 2019 17:03:16 GMT):
oops, old message, haha
Srinuthalapati (Tue, 30 Apr 2019 18:18:24 GMT):
@mtn206 @nadiab22 @bobonana have you guys ever worked with mock LDAP server? I mean, I'm trying to achieve the below scenario:
Srinuthalapati (Tue, 30 Apr 2019 18:19:24 GMT):
for Integration tests
Srinuthalapati (Tue, 30 Apr 2019 18:43:17 GMT):
the above diagram is explained like this
bobonana (Tue, 30 Apr 2019 19:16:43 GMT):
can we set the test docker-compose file to use a separate `.env` file? if we can do that we could enter credentials for mock services
mtn206 (Tue, 30 Apr 2019 19:34:24 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=3tcXQdz5YuW3ow7mJ) @Srinuthalapati Just wanted everyone to know that Shan and I had a conversation on this via direct messages.
bobonana (Tue, 30 Apr 2019 19:39:48 GMT):
so how are you passing the mock server config values to the actual code?
Srinuthalapati (Tue, 30 Apr 2019 19:41:08 GMT):
That is my question
Srinuthalapati (Tue, 30 Apr 2019 19:41:43 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=2hF8MaE4b6FCZeKkD) @bobonana It is not just passing, but overwrite the actual .env values
Srinuthalapati (Tue, 30 Apr 2019 19:41:43 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=2hF8MaE4b6FCZeKkD) @bobonana It is not just passing, but overwrite the actual .env values when passing mock values
Srinuthalapati (Tue, 30 Apr 2019 19:44:18 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=oSFttii5PXM7p5i4m) @bobonana This is a good idea.
Srinuthalapati (Tue, 30 Apr 2019 19:44:18 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=oSFttii5PXM7p5i4m) @bobonana This is a good idea. But can the mock server handle the load that comes through all our tests?
bobonana (Tue, 30 Apr 2019 19:47:03 GMT):
you can set overrides or just use the environment parameters in the docker-test.yaml to set the mock server creds
bobonana (Tue, 30 Apr 2019 19:47:26 GMT):
https://docs.docker.com/compose/extends/
bobonana (Tue, 30 Apr 2019 20:04:24 GMT):
You'll need to override the .env file with environment values in the `docker-test.yaml` file anyway as I don't think the travis .env file enables ldap or azure syncs. I'm not sure how that'll affect the running project though, since the mock ldap server is created and removed as a module level fixture, right? You might need to see if there's a way to set up a global fixture, or what exactly the best practice would be in this situation. Do you have any feedback @nadiab22 ?
bobonana (Tue, 30 Apr 2019 23:53:54 GMT):
PR freeze for tonight until we push the new version release. *DO NOT* review or merge PRs until the new commit has been merged to hyperledger/sawtooth-next-directory:master
nadiab22 (Wed, 01 May 2019 03:26:41 GMT):
PR freeze is over. Feel free to review and merge code when approved
PatrickLammers (Thu, 02 May 2019 16:06:21 GMT):
@nadiab22 @bobonana @mtn206 @ChrisSpanton @akgunkel @v1122am Local seems broken today. I can see the login page and walk through the create acct wizard but when I press submit I get a pop-up that says 'network error' -- ERR_CONNECTION_REFUSED
PatrickLammers (Thu, 02 May 2019 16:09:10 GMT):
on STAGE, I enter my username and pw and it just sits... authorization says 'pending' perpetually.
PatrickLammers (Thu, 02 May 2019 16:09:43 GMT):
user error maybe?
Srinuthalapati (Mon, 06 May 2019 17:05:13 GMT):
@nadiab22, @bobonana @akgunkel ... Travis Job ran for around 8 hours long
mtn206 (Mon, 06 May 2019 17:48:27 GMT):
[ ](https://chat.hyperledger.org/channel/sawtooth-next-directory?msg=X5QZ84vAeL6qzHb6x) @Srinuthalapati @Srinuthalapati Ned is currently working on fixing tests at the moment. Once those changes have been fixed and pushed, we'll let you know and you can pull in the changes to your PR.
Srinuthalapati (Mon, 06 May 2019 17:49:03 GMT):
awesome, thanks for the info :)
PatrickLammers (Tue, 07 May 2019 16:06:30 GMT):
@bobonana @nonj @akgunkel @mtn206 Local seems to not exist this morning...
PatrickLammers (Tue, 07 May 2019 16:06:30 GMT):
ERR_CONNECTION_REFUSED
bobonana (Tue, 07 May 2019 16:12:38 GMT):
How many dev hours do we typically spend every sprint stabilizing deployments? I'd guess we're pretty close to the point of diminishing returns, if we haven't already exceeded it, with our current deployment methods
bobonana (Tue, 07 May 2019 16:19:51 GMT):
Thoughts?
PatrickLammers (Tue, 07 May 2019 21:32:38 GMT):
We shouldn't have to spend *any* hours stabilizing deployments... ideally all changes are carefully reviewed, unit tested and validated locally before they are merged. What was the root cause of today's outage?
PatrickLammers (Tue, 07 May 2019 21:34:30 GMT):
BTW: there is no SysAdmin accounot or NextAdmins group on local today...
rbuysse (Tue, 07 May 2019 21:35:46 GMT):
Has left the channel.
PatrickLammers (Tue, 07 May 2019 22:06:39 GMT):
@bobonana @akgunkel @mtn206 -- any word on root cause of today's issue on Local?
bobonana (Tue, 07 May 2019 22:07:03 GMT):
I already pushed a fix for it
bobonana (Tue, 07 May 2019 22:07:11 GMT):
there's a PR up now
bobonana (Tue, 07 May 2019 22:07:20 GMT):
were all 3 of us working on that?
bobonana (Tue, 07 May 2019 22:09:28 GMT):
that feels kinda wasteful, no? can we start making a weekly/bi-weekly ops ticket or something if we're not going to address these deployment issues with an epic for v1? It'd be nice to know exactly which dev is responsible for maintaining deployments at a given time. we could have them it would more accurately reflect the amount of work we're doing, and prevent that kind of wasteful overlap (which helps us push more features for v1 at a faster rate)
mtn206 (Tue, 07 May 2019 22:13:16 GMT):
We can decide in stand up on who will be the main point of contact for troubleshooting our deployments
mtn206 (Tue, 07 May 2019 22:13:16 GMT):
We can decide in stand up on who will be the main point of contact for troubleshooting our deployments for that day
bobonana (Tue, 07 May 2019 22:15:39 GMT):
I'm not talking about a permanent PoC. nobody on this team wants to be the "ops person" but we're devoting a ton of hours to this and there's some massively wasteful overlap. We might as well have a weekly/bi-weekly rotating "ops" ticket or something since we're doing devops and not going to devote time to stabilizing our deployments, right?
bobonana (Tue, 07 May 2019 22:17:48 GMT):
that way we each get a taste of it and can understand it more, and nobody feels pressured due to spending a lot of time on ops instead of working on tangible tickets. It doesn't feel great as a dev to walk into standup and say "I fixed the deployment" when everyone else made what feels like meaningful contributions
bobonana (Tue, 07 May 2019 22:18:00 GMT):
especially when it's a pattern and visibly impacts our contributions
bobonana (Tue, 07 May 2019 22:21:31 GMT):
@PatrickLammers *the issue in this case was a conflict from a dev changing a source file on the server. No idea who made the change or why, but a hard git reset fixed things. We were also having an issue with one of the environment variable defaults that my PR fixes*
PatrickLammers (Tue, 07 May 2019 22:24:45 GMT):
was the file that had been edited on the server the .env file?
bobonana (Tue, 07 May 2019 22:31:42 GMT):
no
bobonana (Tue, 07 May 2019 22:32:30 GMT):
i mean, it had a variable commented out, but there was a change to one of the source files that was causing a git conflict when the deployment script tried to fetch and merge
bobonana (Tue, 07 May 2019 22:33:41 GMT):
after resetting and rebasing I got an error due to the missing env variable. I added a default value, logged teh bug in a ticket, and pushed the fix (literally a few characters)
bobonana (Tue, 07 May 2019 22:34:19 GMT):
tbh, `local` was pitched to us as an unstable dev standbox, no? so aren't we supposed to go in and mess with it because it doesn't have to be stable?
bobonana (Tue, 07 May 2019 22:34:26 GMT):
or am I incorrect?
bobonana (Tue, 07 May 2019 22:34:26 GMT):
or am I misremembering?
bobonana (Tue, 07 May 2019 22:36:15 GMT):
or is that `dev`?
PatrickLammers (Tue, 07 May 2019 22:42:04 GMT):
Dev is the unstable sandbox. Local/stage are the daily builds to gather early feedback.
PatrickLammers (Tue, 07 May 2019 22:44:13 GMT):
We wouldn't want these endpoint's down for extended periods because that's just more changes to examine in debugging an issue
PatrickLammers (Tue, 07 May 2019 22:45:25 GMT):
BTW... Still no admin acct or role on Local
bobonana (Wed, 08 May 2019 00:10:47 GMT):
it should be good
bobonana (Wed, 08 May 2019 00:12:16 GMT):
despite this ticket https://github.com/docker/compose/pull/5831 I don't think our docker-compose defaults are taking effect
PatrickLammers (Wed, 08 May 2019 17:32:13 GMT):
@mtn206 @nadiab22 @bobonana @akgunkel @ChrisSpanton @V1122am I just noticed that the build is failing on the Hyperledger repo... how much do we care?
nadiab22 (Wed, 08 May 2019 17:33:02 GMT):
I kicked it again
nadiab22 (Wed, 08 May 2019 17:33:18 GMT):
I would expect the build issues to stop after then end of this sprint with all of our fixes going int
nadiab22 (Wed, 08 May 2019 17:33:19 GMT):
in
nadiab22 (Wed, 08 May 2019 17:33:28 GMT):
So I do not care that much right now
nadiab22 (Wed, 08 May 2019 17:33:38 GMT):
I kicked it to see if it would pass for now
PatrickLammers (Wed, 08 May 2019 21:16:22 GMT):
Hey gang! Chris and Ricky tasked me with documenting our usage of ZenHub so that new team members can quickly get up to speed with our process. In putting together my first draft I noticed some redundancy -- We have 6 pipelines in our workflow... but "Sprint committed" sticks out as not really being used in our ScrumBan process. Likewise, we use labels to categorize issues into 24 types -- with the exception of 'refined' which is used to indicate a step in our workflow. How about we stick to using the ZenHub pipelines for workflow by renaming 'Sprint Committed" to be "refined" and put our refined stories there instead of labeling them?
PatrickLammers (Wed, 08 May 2019 21:16:24 GMT):
Thoughts?
ChrisSpanton (Thu, 09 May 2019 18:18:02 GMT):
I think that's a good find on the inconsistency front, and it makes sense to keep with a single taxonomy as you've proposed
akgunkel (Thu, 09 May 2019 22:14:47 GMT):
I assume that means we are sticking with our ScrumBan process for a while, which I'm OK with. But I'm not sure where Refined fits in to the pipeline in relation to Backlog & On Deck and being able to prioritize things out of the backlog. Using a label allowed us to refine any story in the backlog or on deck, so that we can have a collection of items refined & prioritized. If we are going to make refined a pipeline stage, should it then come before On Deck, so that only items that have already been refined can be placed On Deck?
bobonana (Fri, 10 May 2019 22:47:04 GMT):
hey guys
bobonana (Fri, 10 May 2019 22:47:25 GMT):
does anybody know how to await an async coroutine in pytest?
bobonana (Fri, 10 May 2019 22:47:25 GMT):
does anybody know how to await an async coroutine in a pytest integration test?
V1122am (Tue, 14 May 2019 17:16:29 GMT):
@PatrickLammers @nadiab22 @bobonana @mtn206 sorry,all of you will be coming to the Bothell (No plan change)
mtn206 (Tue, 14 May 2019 17:17:01 GMT):
Got it! We'll come over tomorrow.
V1122am (Tue, 14 May 2019 17:17:21 GMT):
Sure thank you
bobonana (Tue, 21 May 2019 19:31:45 GMT):
https://github.com/huge-success/sanic/issues/555
ChrisSpanton (Tue, 21 May 2019 23:38:58 GMT):
@bobonana I'm sure thats relevant, care to provide the context? :)
bobonana (Wed, 22 May 2019 03:18:29 GMT):
Hey there, yup! We were having a discussion about how we should be passing aiohttp session connections around, and what was considered best practice
bobonana (Wed, 22 May 2019 22:01:05 GMT):
@ChrisSpanton @PatrickLammers since we've been implementing NEXT admins we've been trying to figure out what the purpose of role admins is and how they play into admin/owner restricted functionality. do either of you have details on that? Are role admins deprecated?
bobonana (Wed, 22 May 2019 22:17:55 GMT):
@ChrisSpanton @PatrickLammers Also, the update_manager endpoint currently creates a proposal
bobonana (Wed, 22 May 2019 22:17:55 GMT):
@ChrisSpanton @PatrickLammers Also, the update_manager endpoint currently only creates a proposal. what's teh desired behavior here? i.e.: should this endpoint only be called by a NEXT admin and be autoapproved? should users be able to change the managers of their direct reports (shoudl should that be autoapproved then?)? should any user be able to invoke this endpoint and create an update manager proposal? Should a proposal even be created or should we auth the user and push the transaction through as a change (like with user creation, etc.)
bobonana (Fri, 31 May 2019 23:13:33 GMT):
hey all, does the admin account not come up for anybody else when running integration tests?
mtn206 (Fri, 31 May 2019 23:15:06 GMT):
Yeah it isn't coming up to me either because rbac-provider-ldap service isn't being ran when we run integration tests
bobonana (Fri, 31 May 2019 23:16:52 GMT):
so why'd we use that to bootstrap the admin account and role?
bobonana (Tue, 04 Jun 2019 17:50:15 GMT):
is ticket #418 purely UI?
PatrickLammers (Wed, 05 Jun 2019 16:00:37 GMT):
I don't think so... we should discuss the user experience here
bobonana (Wed, 05 Jun 2019 20:00:22 GMT):
what do you mean by "here"?
bobonana (Wed, 05 Jun 2019 20:01:34 GMT):
btw, I'll be attending the prioritization meeting remotely, and am fully prepared to discuss my email, but I've also clued in michael and nadia earlier this morning so that we're all on the same page regarding the atomicity issues
bobonana (Wed, 12 Jun 2019 18:49:25 GMT):
Hey all, should we maybe consider changing our 200 responses to 202 down the road to reflect that it's a confirmation of successful submission of a message to sawtooth but not rethinkDB? (might be useful once we delay the head block to handle forking?) https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/202
mtn206 (Wed, 12 Jun 2019 21:09:29 GMT):
But this might cause confusion because if a user tries to hit our endpoint and they receive a 202 it might appear that the process of the API endpoint might have not fully completed. We had a little discussion yesterday regarding it was okay to send a 200 as a response to the API endpoint because it has completed the desired functions within the API. Even though the object has not been 100% updated/created/deleted from the Sawtooth blockchain and/or RethinkDb.
bobonana (Thu, 20 Jun 2019 20:12:23 GMT):
I'm still not understanding how a 202 message is confusing. I mean, what part of our architecture doesn't align with the description of a 202 response?
bobonana (Thu, 20 Jun 2019 20:15:11 GMT):
>The HyperText Transfer Protocol (HTTP) 202 Accepted response status code indicates that the request has been received but not yet acted upon. It is non-committal, *meaning that there is no way for the HTTP to later send an asynchronous response indicating the outcome of processing the request. It is intended for cases where another process or server handles the request, or for batch processing*.
I mean, this sounds almost exactly like our case where a successful submission indicates that the message has been accepted by the validator node but not yet added to the chain with consensus, and has not yet been added to rethink. and there's no way for us to send an asynchronus response indicating that it has been added to rethink. right?
jamesbarry (Wed, 31 Jul 2019 16:34:28 GMT):
Has joined the channel.
Dan (Wed, 29 Jan 2020 16:06:01 GMT):
Hi, these binaries are causing license scan issues: https://github.com/hyperledger/sawtooth-next-directory/pull/1442
Dan (Thu, 06 Feb 2020 20:21:15 GMT):
Seems pretty quiet here. I want to float the idea of archiving the repo. If any of you objects to that at all please speak up.
arsulegai (Mon, 10 Feb 2020 08:09:28 GMT):
AD integration is a great project, should be good for production use cases
Dan (Tue, 11 Feb 2020 16:55:40 GMT):
No doubt it is a great project. I
Dan (Tue, 11 Feb 2020 16:55:40 GMT):
No doubt it is a great project. I'm trying to discern whether the main contributors are still active though.
arsulegai (Tue, 11 Feb 2020 17:10:36 GMT):
^ @amundson I see potential code available here, parts of which can be put in as features for Sawtooth 2.0
amundson (Tue, 11 Feb 2020 17:49:56 GMT):
@arsulegai seems like something that might fit better with grid though, and would have to be designed in that context. at a minimum, needs to be rewritten from scratch as sabre contracts and rust apis too.
arsulegai (Tue, 11 Feb 2020 17:51:08 GMT):
Can we formulate a problem statement that can be taken up by an intern?
amundson (Tue, 11 Feb 2020 17:52:39 GMT):
You mean summarize why its interesting?
arsulegai (Tue, 11 Feb 2020 18:01:38 GMT):
I was thinking of getting help for these from an intern through the Hyperledger internship program
amundson (Tue, 11 Feb 2020 18:13:11 GMT):
Maybe creating a labs project around it with a new charter to become part of grid or something? Either way, such a project could be inspired by this even if its archived.
Dan (Mon, 24 Feb 2020 18:05:13 GMT):
I heard from @ChrisSpanton offline that he is cool with archiving this repo.
jmbarry (Tue, 16 Jun 2020 17:31:46 GMT):
Has joined the channel.
VarunLashkari (Thu, 09 Dec 2021 16:21:44 GMT):
Has joined the channel.
rjones (Wed, 23 Mar 2022 17:27:09 GMT):
rjones (Wed, 23 Mar 2022 17:27:09 GMT):
rjones (Wed, 23 Mar 2022 17:27:09 GMT):
